openh264

Author	SHA1	Message	Date
Ethan Hugg	f0c2cdd78c	Merge pull request #529 from mstorsjo/remove-unused-error-code Remove an unused error code	2014-03-19 09:21:41 -07:00
Ethan Hugg	e8540af9eb	Merge pull request #541 from licaiguo/disable-warnings disable most warnings produced by -Wall	2014-03-19 09:17:34 -07:00
volvet	048c23431c	add screen detector in builder	2014-03-19 16:55:21 +08:00
ruil2	028d39077f	Merge pull request #545 from mstorsjo/remove-extra-parentheses Remove unnecessary/superfluous parentheses in slice_multi_threading.cpp	2014-03-19 16:39:01 +08:00
Licai Guo	53553f351e	Merge pull request #542 from volvet/add-scene-change-detector-screen Add scene change detector screen	2014-03-19 16:28:36 +08:00
Licai Guo	a688f5278a	fix most of the warnings	2014-03-19 01:16:08 -07:00
Martin Storsjö	d75f677034	Remove unnecessary/superfluous parentheses in slice_multi_threading.cpp	2014-03-19 10:15:29 +02:00
ruil2	e74f01ad47	use the same frame type EVideoFrameType in encoder internal	2014-03-19 16:11:06 +08:00
volvet	fc4cd8b597	Merge pull request #543 from zhilwang/reorgcommon-xcode Modify xcode project to fit common reorg.	2014-03-19 15:36:21 +08:00
Licai Guo	3febdc1d2e	Modify xcode project to fit common reorg.	2014-03-19 15:08:14 +08:00
volvet	0f35049bb4	remove blank space	2014-03-19 15:00:54 +08:00
volvet	84903f145e	add screen change detector for desktop share	2014-03-19 14:56:45 +08:00
ruil2	3238c913cc	Merge pull request #535 from volvet/add-scene-change-detector Add scene change detector	2014-03-19 14:52:08 +08:00
Licai Guo	e39de8d404	reoranize common to inc/src/x86/arm	2014-03-18 19:41:32 -07:00
volvet	7313ecdbd0	Merge pull request #538 from mstorsjo/use-apple-builtin-define Use __APPLE__ instead of APPLE_IOS for apple/arm specific features	2014-03-19 09:45:56 +08:00
Licai Guo	4bbe61a783	Merge pull request #537 from mstorsjo/rename-x86-asm Rename the asm subdirectories to x86	2014-03-19 08:51:39 +08:00
Licai Guo	d897d362ab	Merge pull request #532 from huili2/WELS_CLIP1 Modify MACRO WELS_CLIP1 as inline functions	2014-03-19 08:50:04 +08:00
Martin Storsjö	9586c59b9e	Use __APPLE__ instead of APPLE_IOS in the arm assembly sources	2014-03-18 23:15:49 +02:00
Martin Storsjö	73ed237d73	Use __APPLE__ instead of APPLE_IOS for using the apple cpu feature detection	2014-03-18 23:15:49 +02:00
Martin Storsjö	ed9c03408f	Rename the asm subdirectories to x86 This is consistent with having the arm assembly in a subdirectory called arm.	2014-03-18 23:09:45 +02:00
Ethan Hugg	197423f271	Merge pull request #520 from ylatuya/master Fix compiler warnings and remove dead code	2014-03-18 13:28:02 -07:00
Andoni Morales Alastruey	8be8fe1775	Fix compiler warning -Werror=maybe-uninitialized	2014-03-18 19:15:25 +01:00
Andoni Morales Alastruey	e9e332bf4c	Fix -Werror=sign-compare compiler warnings	2014-03-18 19:15:25 +01:00
Andoni Morales Alastruey	ae60f1bee9	Fix compiler warnings and remove dead code Fix several -Werror=unused-variable and -Werror=unused-but-set-variable and removed dead code found with this warnings	2014-03-18 19:15:25 +01:00
Andoni Morales Alastruey	703c69de81	codec: add a new macro for unused functions Variables used only for tracing logs can trigger -Werror=unusef-variable when tracing is disabled. This macro helps to silent gcc in those casesWIP	2014-03-18 19:15:25 +01:00
Martin Storsjö	e1b5e038d2	Use .obj as suffix for object files on MSVC This avoids warnings when linking about "unrecognized source file type, object file assumed".	2014-03-18 19:41:06 +02:00
volvet	af522899bd	remove black space at lineend	2014-03-18 18:00:18 +08:00
volvet	d7b7419040	add scene change detector for further extension	2014-03-18 17:54:58 +08:00
ruil2	9cf9238cfc	fix bug that there is no output in encoder console	2014-03-18 17:38:48 +08:00
huili2	3b270aa901	remove unncessary cast	2014-03-18 02:15:57 -07:00
huili2	090e8cc1ed	modify WELS_CLIP1 to be inline functions	2014-03-18 01:54:25 -07:00
Martin Storsjö	72da7f8711	Remove an unused error code I don't see this error code being useful - working slowly hardly would be a reason for the library to return and fail to do what it was asked to do, so normal functions would never actually return this code.	2014-03-18 10:11:27 +02:00
volvet	b21411ad7c	Merge pull request #511 from mstorsjo/remove-unused-define Remove the unused FORMAT_COFF define	2014-03-18 16:11:22 +08:00
Martin Storsjö	4c829a12e2	Fix the comment in welsEncoderExt.h about the EncodeFrame return value This was changed in `36d56b6638` in the public api, but the internal implementation header was missed and left inconsistent.	2014-03-18 10:07:23 +02:00
volvet	fb1958ad13	Merge pull request #519 from mstorsjo/push-xmm-registers Backup/restore the xmm6-xmm15 SSE registers within asm functions on win64 Reviewed by zhiliang	2014-03-18 15:04:54 +08:00
Licai Guo	3956a32d41	Merge pull request #524 from sijchen/me_refactor33 Expand structure of MD and ME	2014-03-18 12:51:05 +08:00
Licai Guo	37fa5f554e	Merge pull request #513 from ruil2/encoder_interface Encoder interface	2014-03-18 09:51:32 +08:00
sijchen	7f0c7daad9	expand structure of MD and ME	2014-03-18 09:47:05 +08:00
volvet	b5353c8455	Merge pull request #516 from mstorsjo/fix-yasm-64bit Fix building with yasm in 64 bit mode	2014-03-18 09:29:42 +08:00
volvet	e75cd2298b	Merge pull request #517 from mstorsjo/simplify-x86-asm-func-macro Fold ALIGN 16 and the function label into WELS_EXTERN	2014-03-18 09:29:17 +08:00
Martin Storsjö	29a0c77acf	Don't clobber q4-q7 in WelsIntra16x16Combined3Satd_neon This is similar to what is done in other neon functions. This function was missed since it isn't covered by the current set of unittests.	2014-03-17 20:04:53 +02:00
Martin Storsjö	4633626d69	Remove XMMREG_PROTECT This isn't necessary any longer, when all the assembly routines take care of restoring registers as necessary.	2014-03-17 13:47:01 +02:00
Martin Storsjö	3cf52554f7	Backup/restore the xmm6-xmm15 SSE registers within asm functions on win64 According to the Win64 ABI, these registers need to be preserved, and compilers are allowed to rely on their content to stay available - not only for float usage but for any usage, anywhere, in the calling C++ code. This adds a macro which pushes the clobbered registers onto the stack if targeting win64 (and a matching one which restores them). The parameter to the macro is the number of xmm registers used (e.g. if using xmm0 - xmm7, the parameter is 8), or in other words, the number of the highest xmm register used plus one. This is similar to how the same issue is handled for the NEON registers q4-q7 with the vpush instruction, except that they needed to be preserved on all platforms, not only on one particular platform. This allows removing the XMMREG_PROTECT_* hacks, which can easily fail if the compiler chooses to use the callee saved xmm registers in an unexpected spot.	2014-03-17 13:44:33 +02:00
Martin Storsjö	9293f2f947	Remove commented out rodata sections and tables in assembly files	2014-03-17 13:42:18 +02:00
Martin Storsjö	eec968234d	Fold ALIGN 16 and the function label into WELS_EXTERN This simplifies the structure for all x86 assembly functions, reducing the amount of duplicated code structure.	2014-03-17 13:35:00 +02:00
Martin Storsjö	04f5bcd68d	Use movsxd in SIGN_EXTENSION This is what nasm ended up assembling movsx with 32 bit input to anyway. Keep using plain movsx for 16 bit input. This fixes building with yasm in 64 bit mode.	2014-03-17 13:26:46 +02:00
Martin Storsjö	f96918283f	Remove commented out code for old, 32-bit only x86 assembly function prologues/epilogues	2014-03-17 11:20:11 +02:00
Licai Guo	fc4e0cacec	Merge pull request #483 from volvet/develop_b use large/medium/similar to define scene change result	2014-03-17 16:32:31 +08:00
Licai Guo	b5a4d706b9	Merge pull request #496 from mstorsjo/use-sign-extend-macro Use the SIGN_EXTENSION macro where possible	2014-03-17 16:31:03 +08:00
Licai Guo	1c0ba88b0e	Merge pull request #501 from mstorsjo/neon-register-backup Avoid clobbering the registers q4-q7 in DeblockingBSCalcEnc_neon	2014-03-17 14:05:23 +08:00
ruil2	895c0ff635	fix typo	2014-03-17 12:09:52 +08:00
ruil2	36abe317a5	modify unit test for return type modification	2014-03-17 11:56:19 +08:00
ruil2	36d56b6638	modify EncoderFrame return type. commit b99a307ab94183c32a293ad5fda8b0e3323546a0 Author: ruil2 <ruil2@cisco.com> Date: Wed Mar 12 13:34:27 2014 +0800 fix typo	2014-03-17 10:46:38 +08:00
Licai Guo	2c796337ba	Merge pull request #510 from huili2/remove_basemb remove BASE_MB related code	2014-03-17 08:46:25 +08:00
Martin Storsjö	fc260b39e0	Remove the unused FORMAT_COFF define Nothing in the project currently sets FORMAT_COFF - the other generic branch works just fine on windows.	2014-03-16 17:54:55 +02:00
Martin Storsjö	eb238e6549	Use the SIGN_EXTENSION macro where possible This shortens the x86 assembly by 134 lines in total.	2014-03-16 17:54:24 +02:00
Martin Storsjö	91e5838621	Indent all WELS_ASM_FUNC_BEGIN properly By having all of them start at the start of the line, the code is more consistent and readable.	2014-03-16 12:01:54 +02:00
volvet	e654bf6b7f	Merge pull request #490 from ruil2/encoder_slice_auto fix dump file issue	2014-03-16 15:41:26 +08:00
volvet	1c3e87dd3f	Merge pull request #505 from mstorsjo/x86-asm-constants Format x86 assembly constants in a yasm compatible manner	2014-03-16 15:37:16 +08:00
volvet	ac990fdc38	Merge pull request #507 from mstorsjo/more-x86-asm-args Add defines for argument 11 and 12 in asm_inc	2014-03-16 10:21:35 +08:00
volvet	e606bae0e9	Merge pull request #504 from mstorsjo/fix-function-name-typo Fix a typo, Smple -> Sample	2014-03-16 10:18:03 +08:00
Martin Storsjö	d45e624cd4	Simplify code by using the arg11 and arg12 defines	2014-03-15 14:42:27 +02:00
Martin Storsjö	c82f548e6f	Add defines of arg11 and arg12 in asm_inc.asm	2014-03-15 14:42:07 +02:00
Martin Storsjö	ce8da27287	Format x86 assembly constants in a yasm compatible manner This is similar to what was done in `a6463be0cc` - yasm requires these constants to have a zero after $.	2014-03-15 14:38:28 +02:00
Licai Guo	6f2b98975e	Merge pull request #502 from mstorsjo/fix-macro-indentation Fix the indentation of some nasm macros	2014-03-15 07:16:37 +08:00
Martin Storsjö	f4fdb15397	Fix a typo, Smple -> Sample	2014-03-14 23:30:09 +02:00
Martin Storsjö	4d120781c1	Fix the indentation of some nasm macros	2014-03-14 22:26:33 +02:00
Martin Storsjö	cde30c155b	Avoid clobbering the registers q4-q7 in DeblockingBSCalcEnc_neon Remap q5 to q8, q6 to q9, q7 to q10 and q8 to q11, and push q4 to the stack. This was missed previously since the codec unittest doesn't test encoding with loop filter enabled yet.	2014-03-14 22:22:28 +02:00
Martin Storsjö	b3d04d88a0	Check for the right function pointer This code checked whether one function pointer was non-null, but the went on to call a different function pointer. Check for the one that actually was called.	2014-03-14 22:20:40 +02:00
volvet	6da9a9e5c8	Merge pull request #489 from sijchen/me_refactor22 refactor ME for easier adding other search methods	2014-03-14 17:53:10 +08:00
huili2	b1f596fd69	remove BASE_MB related code	2014-03-14 02:03:41 -07:00
Martin Storsjö	9199798f22	Fix a typo in a macro name, EXTENTION -> EXTENSION	2014-03-14 10:13:18 +02:00
Martin Storsjö	2bce50283f	Fix a mismatched ifdef comment This is an ifdef block for HAVE_NEON.	2014-03-14 10:01:18 +02:00
unknown	94f8c351ca	fix dump file issue	2014-03-14 15:13:24 +08:00
sijchen	6c3d83a8ac	refactor ME for easier adding other search methods	2014-03-14 15:04:35 +08:00
Licai Guo	f589c580eb	clean redundant checks in decoder	2014-03-13 23:56:54 -07:00
Licai Guo	8492aac917	Merge pull request #486 from huili2/nzc_bug_fix nzc bug fix and clear	2014-03-14 13:11:45 +08:00
huili2	734e60aeeb	add according to review opinion	2014-03-13 20:21:10 -07:00
Licai Guo	5bffb627d6	nzc bug fix and clear	2014-03-13 19:31:28 -07:00
volvet	6714b8ae99	Merge pull request #463 from mstorsjo/dont-clobber-neon-registers Avoid clobbering the neon registers q4-q7 Review and verified by zhilwang	2014-03-14 10:28:55 +08:00
volvet	fc5c48830a	fix the condition of scene change flag and comments	2014-03-14 09:53:24 +08:00
volvet	c8761c08ae	use large/medium/similar to define scene change result	2014-03-13 10:43:20 +08:00
volvet	8962b7c98b	Merge pull request #482 from sijchen/me_refactor1 mv range setting refactor	2014-03-13 10:21:39 +08:00
sijchen	d809a7981b	mv range setting refactor	2014-03-13 10:18:01 +08:00
Licai Guo	3d6fdfee3d	Merge pull request #480 from volvet/fix-idr-interval-issue fix idr interval issue	2014-03-12 19:23:51 +08:00
Martin Storsjö	efe32b7900	Make arm assembly labels always start from the beginning of the line A few labels were misformatted.	2014-03-12 12:01:01 +02:00
volvet	8b907c18fd	fix idr interval issue	2014-03-12 17:38:25 +08:00
sijchen	cf37fa3ef4	Merge pull request #476 from ruil2/encoder_slice_auto modify the parameter verification for SM_AUTO_SLICE mode, review at: https://rbcommons.com/s/OpenH264/r/184/	2014-03-12 16:41:57 +08:00
volvet	ce448a21d7	fix double free crash in encoder	2014-03-12 16:21:33 +08:00
volvet	4d74beb928	fix encode crash	2014-03-12 15:46:13 +08:00
ruil2	c7f2a0b7f6	3Author: ruil2 <ruil2@cisco.com> modify the parameter verification for SM_AUTO_SLICE mode -- uiSliceNum iis ignored	2014-03-12 10:44:13 +08:00
Ethan Hugg	cece1fe2cf	Merge pull request #473 from mstorsjo/arm-non-executable-stack Mark the stack as non-executable in the arm assembly	2014-03-11 09:40:49 -07:00
Martin Storsjö	dbdf8fbe9d	Remove something that looks like a personal todo note from the Android makefiles	2014-03-11 14:27:14 +02:00
Martin Storsjö	52e8973869	Mark the stack as non-executable in the arm assembly Otherwise the linker is forced to enable an executable stack for executables that the code is linked into.	2014-03-11 14:24:16 +02:00
Licai Guo	b773ec60ab	Merge pull request #472 from mstorsjo/android-remove-mkdir-workaround Remove a dubious/unnecessary workaround for an issue in a nonstandard toolchain	2014-03-11 17:30:00 +08:00
Martin Storsjö	966cc97496	Remove a dubious/unnecessary workaround for an issue in a nonstandard toolchain There's no requirement to work with the Intel NDK. The NDK build files don't even need to create any cpufeatures subdirectory since all of the cpufeatures library is handled within the normal build system. Finally, the encoder makefile tried to create a directory for "welsdecdemo", not anything for "welsencdemo". Thus, if this really was necessary, it would already have been noticed that it missed an entry for "welsencdemo". Therefore, remove this hack/workaround.	2014-03-11 10:09:17 +02:00
ruil2	7c8ce799c0	fix SM_FIXEDSLCNUM_SLICE bug, add SM_AUTO_SLICE mode	2014-03-11 10:23:46 +08:00
Martin Storsjö	c011890764	Push clobbered neon registers on the stack According to the calling convention, the registers q4-q7 should be preserved by functions. The caller (generated by the compiler) could be using those registers anywhere for any intermediate data. Functions that use more than 12 of the qX registers must push the clobbered registers on the stack in order to be able to restore them afterwards. In functions that don't use all 16 registers, but clobber some of the callee saved registers q4-q7, one or more of them are remapped to reduce the number of registers that have to be saved/restored. This incurs a very small (around 0.5%) slowdown in the decoder and encoder.	2014-03-10 22:07:36 +02:00
Martin Storsjö	811c647c0e	Remap registers to avoid clobbering the neon registers q4-q7 According to the calling convention, the registers q4-q7 should be preserved by functions. The caller (generated by the compiler) could be using those registers anywhere for any intermediate data. Functions that use 12 or less of the qX registers can avoid violating the calling convention by simply using other registers instead of the callee saved registers q4-q7. This change only remaps the registers used within functions - therefore this does not affect performance at all. E.g. in functions using registers q0-q7, we now use q0-q3 and q8-q11 instead.	2014-03-10 22:07:25 +02:00
Ethan Hugg	3627875986	Merge pull request #456 from mstorsjo/use-common-threadlib Make the processing lib use mutexes from WelsThreadLib from the common library	2014-03-10 09:45:51 -07:00
Licai Guo	731a1466e6	Merge pull request #469 from huili2/svc_sh_bug_fix modify and correct SVC slice header parse	2014-03-10 22:09:44 +08:00
Licai Guo	091315f84c	modify and correct SVC slice header parse	2014-03-10 02:37:41 -07:00
ruil2	44a49b1fef	Merge pull request #458 from mstorsjo/android-threading Don't try to set thread scope and scheduling policy on android	2014-03-10 17:26:00 +08:00
ruil2	a922155c9a	Merge pull request #466 from sijchen/add_memalign_test Add memalign unit test	2014-03-10 17:25:41 +08:00
sijchen	385128e403	Merge pull request #465 from ruil2/encoder_trace use global trace in encoder reviewed at https://rbcommons.com/s/OpenH264/r/176/	2014-03-10 17:22:19 +08:00
sijchen	53a570556d	add memalign unit test	2014-03-10 16:28:05 +08:00
ruil2	cbc2b9c986	keep the unrelated changed line	2014-03-10 16:11:27 +08:00
ruil2	e99df3377d	Merge pull request #460 from mstorsjo/add-const Mark pointers as const where possible in vaacalc	2014-03-10 15:35:57 +08:00
ruil2	02bafd9320	Merge pull request #445 from mstorsjo/use-thread-param Use the iMultipleThreadIdc field from SEncParamExt	2014-03-10 15:28:04 +08:00
ruil2	86f37f047c	Merge pull request #452 from mstorsjo/use-slice-mode-enum Use SliceModeEnum as data type for the slice mode fields	2014-03-10 15:27:04 +08:00
ruil2	2539d6e447	Merge pull request #462 from mstorsjo/fix-typos Fix two typos in variable and macro names	2014-03-10 15:25:20 +08:00
ruil2	ba6b2a8d62	use global trace in encoder	2014-03-10 15:22:40 +08:00
Licai Guo	4cc059bf5b	Merge pull request #461 from mstorsjo/fix-asm-comments Remove unnecessary/stray keywords in function signature comments in x86 assembly	2014-03-10 12:29:22 +08:00
Licai Guo	b2dafa5a92	fix WELS_READ_VERIFY	2014-03-09 18:12:53 -07:00
Martin Storsjö	cc7b81f3c3	Fix a typo in arm assembly, LORD -> LOAD	2014-03-09 19:19:38 +02:00
Martin Storsjö	e31ba7a775	Fix a typo, "heigth" -> "height"	2014-03-09 19:19:37 +02:00
Martin Storsjö	7c435ad295	Remove a stray inline keyword in a function signature comment in x86 assembly Assembly functions written in external assembly files is obviously not inlined.	2014-03-09 19:18:03 +02:00
Martin Storsjö	8d6b368a1c	Remove unnecessary stray __cdecl annotations in function signature comments in x86 assembly	2014-03-09 19:18:02 +02:00
Martin Storsjö	2a23a508e1	Mark pointers as const where possible in vaacalc	2014-03-09 18:52:17 +02:00
Martin Storsjö	1c6a910c11	Don't try to set thread scope and scheduling policy on android These APIs aren't implemented on android.	2014-03-08 20:37:42 +02:00
Martin Storsjö	fd90d14ece	Enable threading when building for iOS using the project files This was already enabled when building the library for iOS using the makefiles.	2014-03-08 13:06:05 +02:00
Martin Storsjö	45c21931de	Add NO_DYNAMIC_VP when building the encoder lib for the iOS simulator This was previously only added to builds for actual devices.	2014-03-08 13:05:45 +02:00
Martin Storsjö	c5390521ec	Make the processing lib use mutexes from WelsThreadLib from the common library This requires always building the WelsMutex* functions, even if MT_ENABLED isn't set.	2014-03-08 12:46:25 +02:00
Martin Storsjö	5df2e2a996	Use SliceModeEnum as data type for the slice mode fields This makes the use of the field clearer and safer by allowing the compiler check that users actually assign proper enum values.	2014-03-08 00:23:58 +02:00
Martin Storsjö	ce7b00ea72	Get rid of an unnecessary cast by declaring the right pointer type	2014-03-08 00:17:30 +02:00
Ethan Hugg	09b45e3ef9	Merge pull request #440 from licaiguo/refine-pps-sps Refine pps sps	2014-03-07 11:02:02 -08:00
Ethan Hugg	fb4f677f77	Merge pull request #446 from mstorsjo/remove-unnecessary-public-param Move the iCountThreadsNum field to SWelsSvcCodingParam	2014-03-07 09:18:52 -08:00
Ethan Hugg	7632510209	Merge pull request #450 from mstorsjo/publish-slice-mode-enum Move the slice mode enum to the public API	2014-03-07 09:17:03 -08:00
volvet	f62492716f	Merge pull request #449 from mstorsjo/avoid-opaque-pointer Make ParamValidationExt use the actual type instead of a void pointer	2014-03-08 00:27:47 +08:00
Martin Storsjö	014f4d8250	Merge the slice mode comments with the enum	2014-03-07 14:53:29 +02:00
Martin Storsjö	5f1c207845	Move the slice mode enum to the public header This simplifies setting the slice mode in the public API.	2014-03-07 14:53:29 +02:00
Martin Storsjö	495a4a392e	Make ParamValidationExt use the actual type instead of a void pointer	2014-03-07 14:51:34 +02:00
Martin Storsjö	555bf6340f	Remove a misleading cast uiSliceSizeConstraint is not of the SliceMode type, but is a normal int.	2014-03-07 14:49:33 +02:00
Martin Storsjö	656e4c5c35	Move the iCountThreadsNum field to SWelsSvcCodingParam There is no point in the user setting this field, it's only used as an internal field within the encoder.	2014-03-07 14:48:38 +02:00
Martin Storsjö	dbc324d5bb	Use the iMultipleThreadIdc field from SEncParamExt	2014-03-07 14:47:43 +02:00
volvet	355bbacc2d	Merge pull request #443 from mstorsjo/rerun-mktargets Rerun mktargets.sh	2014-03-07 18:25:20 +08:00
volvet	3382e8f8c4	Merge pull request #441 from mstorsjo/remove-stray-macro-parameters Remove unused/undeclared arm assembly macro parameters	2014-03-07 18:24:33 +08:00
Martin Storsjö	64b4556d13	Rerun mktargets.sh This fixes inconsistent indentation of one line, caused by manually editing one of the targets.mk files.	2014-03-07 11:30:19 +02:00
Martin Storsjö	5b8ee37162	Merge WelsThreadDestroy into WelsThreadJoin Now calling WelsThreadJoin is enough to finish and clean up the thread on all platforms. This unifies the thread cleanup code between windows and unix. Now all of the threading code should use the exact same codepaths between windows and unix.	2014-03-07 10:51:28 +02:00
Martin Storsjö	b4aa9be7de	Use WelsThreadJoin on windows as well This avoids using a separate event just for signalling that a thread has finished running.	2014-03-07 10:51:28 +02:00
Martin Storsjö	474deacd7a	Remove the now unused thread cancellation support This makes the thread library build on android - android does not have pthread_cancel.	2014-03-07 10:51:14 +02:00
Martin Storsjö	baaa38737e	Use pExitEncodeEvent instead of thread cancellation on unix as well This works now that we've got a suitably working implementation of WelsMultipleEventsWaitSingleBlocking.	2014-03-07 10:49:39 +02:00
volvet	38a3fada24	Merge pull request #435 from mstorsjo/threadlib-wait-single-unix Make WelsMultipleEventsWaitSingleBlocking usable on unix as well	2014-03-07 16:47:38 +08:00
Licai Guo	1b9aae8434	Merge pull request #439 from zhilwang/mc-arm-asm mv mc_neon.S to common,add MC arm code to encoder	2014-03-07 16:36:48 +08:00
ruil2	b3c45946ff	modify typing format	2014-03-07 16:29:12 +08:00
Martin Storsjö	c87bb2b449	Remove unused/undeclared arm assembly macro parameters The SAD_VAR_16_END macro only takes 3 parameters, never 4, and SAD_SSD_16_END never is called with more than 3 parameters either.	2014-03-07 10:26:54 +02:00
Licai Guo	e5f36822a9	Update targets.mk files	2014-03-07 16:22:59 +08:00
Licai Guo	d986c27b9d	remove mc_neon.S from encoder	2014-03-07 16:11:36 +08:00
ruil2	f0c6c2b318	Merge branch 'master' of https://github.com/cisco/openh264 into encoder_update	2014-03-07 15:59:23 +08:00
Licai Guo	8ad9e0b60d	use temp buffer to store new arrived PPS/SPS	2014-03-06 22:05:12 -08:00
Licai Guo	8a3518f7be	set bAuReadyFlag to true when we meet a PPS	2014-03-06 21:50:31 -08:00
Licai Guo	71467f948a	mv mc_neon.S to common,add MC arm code to encoder	2014-03-07 12:18:58 +08:00
Licai Guo	a4cecd8004	Merge pull request #426 from volvet/simplify-layer-process simplify-layer-process	2014-03-07 10:58:28 +08:00
volvet	14f5518e6a	Merge pull request #437 from mstorsjo/fix-arm-encoder-android Fix building arm encoder assembly for android	2014-03-07 10:41:34 +08:00
ruil2	594fc4fe7b	dump file refactor	2014-03-07 10:23:25 +08:00
volvet	b3fa8dd334	Merge pull request #418 from mstorsjo/ios-neon-detection Use the __ARM_NEON__ built-in compiler define for identifying neon capability on iOS	2014-03-07 09:15:17 +08:00
Ethan Hugg	2f2801dc78	Merge pull request #434 from mstorsjo/threadlib-core-count-android Use the cpu-features NDK library for detecting the number of cores in WelsThreadLib	2014-03-06 08:02:28 -08:00
Martin Storsjö	11bdebb12c	Explicitly enable the UAL syntax when using gnu tools Arm assembly has got two variants of the syntax, the old legacy syntax, and the new modern UAL (unified assembly language) syntax. Most arm assembly is the same in the both syntaxes, but some uncommon cases change the order of suffixes - the "subscs" instruction would be written "subcss" in the old syntax. The apple tools default to UAL, while the GNU tools (e.g. in android) require you to specify ".syntax unified" to enable the new syntax. When enabling the new syntax with the GNU tools, some cases of "sub r0, r1, lsl #1" needs to be written explicitly as "sub r0, r0, r1, lsl #1", handled in the previous commit. This allows using the same, modern syntax for things like subscs, without needing to have two alternate forms of writing it.	2014-03-06 16:21:54 +02:00
Martin Storsjö	c0043f7053	Use the three-operand form of add/sub with shift When using unified syntax, the two operand form with a shift isn't allowed.	2014-03-06 16:21:54 +02:00
Martin Storsjö	f1502c26e3	Don't use WELS_ASM_FUNC_END in the middle of a function WELS_ASM_FUNC_END declares the end of the function, and needs to be paired with WELS_ASM_FUNC_BEGIN.	2014-03-06 16:21:54 +02:00
Martin Storsjö	8ba79262bf	Rename a function to avoid conflicts between almost duplicate neon functions There's a different version of the same function in the encoder, but they're not identical - the encoder version has got stricter alignment requirements. If someone can confirm that it is ok to use the function from the encoder, pixel_sad_neon.S in processing could be deleted, and the encoder version moved to codec/common instead.	2014-03-06 16:19:48 +02:00
Martin Storsjö	4e4bfcc1bc	Regenerate makefiles to include the encoder arm assembly	2014-03-06 16:11:54 +02:00
Martin Storsjö	45e059ec5f	Rename expand_picture.S to expand_picture_neon.S This avoids ambiguity in the make based build system about whether expand_picture.o should be built from expand_picture.S or expand_picture.asm.	2014-03-06 16:11:40 +02:00
Martin Storsjö	ce4fa9e272	Correct the endif comment The code block is about HAVE_NEON, not X86_ASM.	2014-03-06 15:43:04 +02:00
Martin Storsjö	636df2bebb	Use WelsMultipleEventsWaitSingleBlocking within the worker thread on unix as well This avoids using a separate thread for handling pUpdateMbListEvent events, and later allowing using the encode exit event on unix instead of pthread cancellation.	2014-03-06 15:34:35 +02:00
Martin Storsjö	801da26d1d	Use WelsMultipleEventsWaitSingleBlocking with a master event for waiting on finished threads This allows using the same codepath for both unix and windows for distributing new slices to code to threads. This also improves the performance on unix - instead of waiting for all the current threads to finish their current slice before handing out a new slice to each of them (where the threads that finish first will just wait instead of immediately getting a new slice to work on), we now use the same logic as on windows. In one setup, it improves the performance of encoding from ~920 fps to ~950 fps, and in another setup it goes from ~390 fps to ~660 fps. (These tests were done with the SM_ROWMB_SLICE mode, which heavily exercises the code for distributing new slices to the worker threads.) The extra WelsEventSignal call on windows where it isn't strictly necessary doesn't incur any measurable slowdown, so it is kept without any extra ifdefs to keep the code more readable and unified.	2014-03-06 15:33:37 +02:00
Martin Storsjö	276b585f03	Use the cpu-features NDK library for detecting the number of cores in WelsThreadLib On arm, the exact same detection is done in WelsCPUFeatureDetect, but in the x86 version of that function we use x86 cpuid for getting the core count, and this is not available on all processors. For the case when cpuid can't tell the core count, use the NDK function as higher level API. The thread lib itself doesn't build properly on android yet, but will do so soon.	2014-03-06 15:28:59 +02:00
Martin Storsjö	d0a81355b0	Add support for using a separate "master event" in WelsMultipleEventsWait*Blocking This allows making the WelsMultipleEventsWaitSingleBlocking function work properly in unix, without polling. If a master event is provided, the function first waits for a signal on that event - once such a signal is received, it is assumed that one of the individual events in the list have been signalled as well. Then the function can proceed to check each of the semaphores in the list using sem_trywait to find the first one of them that has been signalled. Assuming that the master event is signalled in pair with the other events, one of the sem_trywait calls should succeed. The same master event is also used in WelsMultipleEventsWaitAllBlocking, to keep the semaphore values in sync across calls to the both functions.	2014-03-06 15:03:59 +02:00
Martin Storsjö	de32455d87	Remove the timeout parameter from WelsMultipleEventsWaitSingleBlocking All users of the function passed the value corresponding to "infinite", and the (currently unused) unix implementation of it only supported infinite wait as well.	2014-03-06 15:03:59 +02:00
Licai Guo	201ab42d7e	Merge pull request #431 from huili2/large_to_small_sps_bug Large to small sps bug for issue #373	2014-03-06 16:51:59 +08:00
volvet	8cc332dea1	Merge pull request #432 from zhilwang/arm-asm Arm asm	2014-03-06 16:50:56 +08:00
volvet	73452e0993	Merge pull request #429 from mstorsjo/simplify-ifdef-with-macro Use a macro for conditionally logging based on ENABLE_TRACE_MT	2014-03-06 16:01:41 +08:00
Licai Guo	8a7a9195d9	remove unused function	2014-03-05 23:14:57 -08:00
Licai Guo	4260a9b2ba	remove CS and RS syntaxs for issue 373	2014-03-05 22:59:27 -08:00
Licai Guo	7bfe801874	Remove trailing space	2014-03-06 14:55:36 +08:00
Licai Guo	67534b0fc0	arm asm code refine.	2014-03-06 14:30:16 +08:00
Martin Storsjö	fd6f8a83b3	Use a macro for conditionally logging based on ENABLE_TRACE_MT This avoids having an extra ifdef around every single WelsLog call.	2014-03-06 08:06:34 +02:00
ruil2	28a56a6752	Merge pull request #415 from volvet/remove-useless-mgs-code remove un-supported mgs code	2014-03-06 14:05:04 +08:00
ruil2	a59c8ea04c	Merge pull request #428 from sijchen/read_para3 [Encoder Console] add new para reading to get accord with the new API design	2014-03-06 14:04:33 +08:00
sijchen	a4a8eddb04	add new para reading to get accord with the new API design	2014-03-06 13:48:18 +08:00
volvet	50fe120a3e	simplify-layer-process	2014-03-06 11:19:33 +08:00
ruil2	334c5765c7	remove inter-deblock related parameters	2014-03-06 10:26:53 +08:00
volvet	8beb3c8c09	Merge pull request #417 from mstorsjo/unify-event-init Unify the interface for creating/deleting event objects	2014-03-06 09:13:13 +08:00
volvet	97376c6339	Merge pull request #413 from mstorsjo/remove-commented-code Remove commented out, unused code	2014-03-05 22:13:35 +08:00
volvet	7ea70491c8	Merge pull request #411 from mstorsjo/arm-add-func-markers Add .func/.endfunc markers in the arm assembly	2014-03-05 17:40:18 +08:00
Martin Storsjö	f384dde881	Add .func/.endfunc markers in the arm assembly This adds information to debug builds. This requires adding a separate definition of WELS_ASM_FUNC_END for apple tools.	2014-03-05 11:25:51 +02:00
Licai Guo	eb3dd8f0ae	Merge pull request #416 from huili2/move_iTotalNumMbRec_to_pCtx move iTotalNumMbRec from refpic to ctx	2014-03-05 17:12:43 +08:00
Licai Guo	e7cc8c2780	Add arm asm code for processing.	2014-03-05 16:54:05 +08:00
Martin Storsjö	ef7e05d47d	Use the __ARM_NEON__ built-in compiler define for identifying neon capability on iOS This avoids having to hardcode the names of devices that don't support neon. The devices that don't support neon don't run the armv7 variants of iOS binaries at all - they would need to be built for the armv6 architecture. (Building for armv6 isn't supported at all in modern iOS SDKs.) Therefore we can simply use the __ARM_NEON__ built-in compiler define to check if NEON code is allowed in the current build, and have the WelsCPUFeatureDetect function return flags accordingly. The only thing this disallows is doing an armv6 build which would optionally enable neon code at runtime if run on an armv7 capable device, but since Apple allows you to build the same binary for armv7 separately in the same app bundle, and since armv6 building isn't even possible in the current iOS SDKs, this isn't really a loss. This is in contrast to the android builds where the armv7 baseline does not include NEON.	2014-03-05 09:47:05 +02:00
Martin Storsjö	d4bdef2916	Use an event name that contains the process id This reduces the risk for namespace collisions if two processes run the encoder simultaneously without address space layout randomization.	2014-03-05 09:36:46 +02:00
Martin Storsjö	4814d5828d	Use unnamed semaphores on linux This avoids the risk of namespace collisions for named semaphores (where the names are global for the whole machine), on platforms where we strictly don't need to use the named semaphores.	2014-03-05 09:36:46 +02:00
Martin Storsjö	5480ffafdf	Use the WelsEventOpen interface with an event name on windows as well This unifies the event creation interface, even if the event name itself is unused on windows, allowing use the exact same code to initialize events regardless of the actual platform. Some ifdefs still remain in the event initialization code, since some events are only used on windows.	2014-03-05 09:36:04 +02:00
volvet	e9395bbd35	remove un-supported mgs code	2014-03-05 15:17:07 +08:00
Martin Storsjö	04917cd13f	Remove commented out, unused code Some few lines of commented out code is left, that might be useful for debugging.	2014-03-05 08:50:59 +02:00
volvet	adb27ff0b1	Merge pull request #405 from mstorsjo/simplify-threads Adjust WELS_EVENT definitions to allow sharing more code between unix and win32 codepaths	2014-03-05 12:31:15 +08:00
Licai Guo	9e4ab64c73	move iTotalNumMbRec from refpic to ctx	2014-03-04 19:23:15 -08:00
Licai Guo	ced9e41b5d	Merge pull request #399 from volvet/refine-multi-layer-process refine-multi-layer-process	2014-03-05 10:45:35 +08:00
Licai Guo	248f324c62	Add intra predictor arm asm code.	2014-03-05 10:25:15 +08:00
Licai Guo	efcee63692	Remove .DS_Store file.	2014-03-05 10:24:05 +08:00
Licai Guo	bb244d736b	Partly add arm asm code to encoder.	2014-03-05 10:24:05 +08:00
volvet	7150adc91b	Merge pull request #407 from mstorsjo/do-blocking-wait Do a blocking wait with WelsMultipleEventsWaitSingleBlocking	2014-03-05 09:18:45 +08:00
Martin Storsjö	dae8f4b737	Exclude the arm assembly header as well This avoids warnings about object files not containing any symbols.	2014-03-04 23:23:19 +02:00
Ethan Hugg	975a3e41bc	Merge pull request #404 from mstorsjo/arm-asm-type-func Mark the arm asm labels as functions	2014-03-04 10:17:07 -08:00
Ethan Hugg	01a2f582c3	Merge pull request #401 from mstorsjo/android-arm-assembly Enable the arm assembly in android builds	2014-03-04 09:50:07 -08:00
volvet	e61bd1b504	Merge pull request #408 from mstorsjo/exclude-asm-headers Exclude assembly files that are used as headers	2014-03-04 21:07:42 +08:00
volvet	bc9ee5b145	Merge pull request #406 from mstorsjo/use-proper-define Use the windows INFINITE define instead of manually casting -1 to uint32_t	2014-03-04 20:57:57 +08:00
Martin Storsjö	773cc4a797	Exclude assembly files that are used as headers This avoids some warnings about object files not containing any symbols.	2014-03-04 14:57:36 +02:00
Martin Storsjö	cf07d61f06	Do a blocking wait with WelsMultipleEventsWaitSingleBlocking There is no point in doing a timed wait here - there's no work that we can do if the wait timed out, and sleeping for 1 ms inbetween doesn't help, it only adds potential extra latency to reacting to threads that need more work to do.	2014-03-04 14:51:33 +02:00
Martin Storsjö	42592217c2	Use the windows INFINITE define instead of manually casting -1 to uint32_t	2014-03-04 14:47:25 +02:00
Martin Storsjö	1eaa38b130	Simplify code by allocating the arrays of events and thread handles statically This avoids having to malloc a whole lot of separate arrays, all which are all bounded by MAX_THREADS_NUM.	2014-03-04 12:17:32 +02:00
Martin Storsjö	ae63f064a0	Share the declarations for WELS_EVENT arrays between win32 and unix codepaths	2014-03-04 12:17:32 +02:00
Martin Storsjö	71bc52d103	Change the unix version of WELS_EVENT to sem_t* Typedeffing WELS_EVENT as sem_t* makes the typedef behave similarly to the windows version (typedeffed as HANDLE), unifying the code that allocates and uses these event objects (getting rid of most of the need for separate codepaths and ifdefs).	2014-03-04 12:17:32 +02:00
Martin Storsjö	e9c3403674	Merge some WIN32 ifdefs that were directly next to each other	2014-03-04 12:17:32 +02:00
Martin Storsjö	e20930ef73	Mark the arm asm labels as functions This fixes calling them from thumb code, on linux.	2014-03-04 11:23:04 +02:00
Martin Storsjö	d411d768b6	Add cpu feature detection for generic arm/linux For platforms without runtime detection, assume whoever built it with HAVE_NEON actually wanted it.	2014-03-04 10:18:30 +02:00
Martin Storsjö	9cf34e7615	Unify the interface for the different variants of WelsCPUFeatureDetect The caller of the function should not need to know exactly which implementation of it is being used. For the variants that don't support detecting the number of cores, the pNumberOfLogicProcessors parameter can be left untouched and the caller will use a higher level API for finding it out. This simplifies all the calling code, and simplifies adding more implementations of cpu feature detection.	2014-03-04 10:18:30 +02:00
volvet	4d729c9418	get cpu cores for android	2014-03-04 15:50:41 +08:00
Martin Storsjö	1118dd4f71	Update the makefile generator to support .S arm assembly files These are built if ASM_ARCH is set to arm.	2014-03-04 08:56:42 +02:00
Martin Storsjö	03e0dcd814	Convert the arm assembly sources to unix newlines	2014-03-04 08:42:28 +02:00
volvet	13d785ec6a	refine-multi-layer-process	2014-03-04 12:04:04 +08:00
volvet	d9a02d27f2	remove execute attribute of the arm asm files	2014-03-04 11:45:10 +08:00
Licai Guo	26218731c6	Merge pull request #386 from volvet/refine_processing refine build spatial list in processing	2014-03-04 11:15:35 +08:00
volvet	f8b0cec68d	Merge pull request #387 from zhilwang/arm-asm Arm asm	2014-03-04 11:08:17 +08:00
volvet	901b89f7ad	Merge pull request #376 from mstorsjo/simplify-x86-asm-makefiles Simplify makefiles with respect to x86 assembly	2014-03-04 10:16:01 +08:00
Licai Guo	cdeb6449c6	remove unused declarations in as264_common.h	2014-03-03 17:42:47 -08:00
Licai Guo	83d0791163	Modify function name according latest cisco master	2014-03-04 09:18:18 +08:00
volvet	bc1850a54d	remove uiFrameIdxRc	2014-03-04 09:08:54 +08:00
Ethan Hugg	1eb688264b	Merge pull request #395 from mstorsjo/printf-64bit-macro Use a standard macro for 64 bit printf conversion specifiers	2014-03-03 09:11:51 -08:00
Ethan Hugg	e9593682eb	Merge pull request #392 from mstorsjo/unify-threading-ifdefs Unify ifdef conditions related to threading code	2014-03-03 08:23:30 -08:00
Ethan Hugg	d940a204eb	Merge pull request #388 from mstorsjo/initialize-default Initialize sSpatialLayers[0] in SEncParamExt for GetDefaultParams	2014-03-03 08:20:36 -08:00
Martin Storsjö	e0951599ea	Unify ifdef conditions related to threading code The two different variants of the threadlib basically are win32 and unix - use _WIN32 to check for this consistently, instead of occasionally using __GNUC__ to enable the unix codepath. (__GNUC__ is also defined on mingw, which still is a windows platform and should use the _WIN32 code.)	2014-03-03 14:55:53 +02:00
Martin Storsjö	3c7dde97ee	Use a standard macro for 64 bit printf conversion specifiers This avoids duplicating the printf line with an ifdef every time a 64 bit number needs to be printed.	2014-03-03 12:33:34 +02:00
volvet	c7d98a8fa3	Merge pull request #394 from ruil2/encoder_update add timestamp in encoder interface --- review request#138	2014-03-03 17:31:48 +08:00
unknown	e0e7107ff1	add timestamp in encoder interface	2014-03-03 17:05:06 +08:00
Martin Storsjö	9ccabd1fe3	Fix cropping when using SEncParamBase The iFrameWidth/iFrameHeight fields are already aligned by the SetActualPicResolution() function. Previously when iFrameWidth was aligned directly in ParamBaseTranscode, this aligned value was used to set iActualWidth/iActualHeight - losing the original, cropped size. This makes sure the output bitstream from the test of encoding res/Static_152_100.yuv actually is cropped as it should.	2014-03-03 10:34:37 +02:00
Martin Storsjö	e392932ad2	Initialize sSpatialLayers[0] in SEncParamExt for GetDefaultParams	2014-03-03 10:32:20 +02:00
Licai Guo	21d6b3481f	Remove trailing space.	2014-03-03 16:05:07 +08:00
Licai Guo	7768cd0a98	Modify code style, remove trailing space.	2014-03-03 15:42:01 +08:00
volvet	775eebaf36	refine build spatial list in processing	2014-03-03 14:04:19 +08:00
ruil2	b552944453	fix sizeof() bug	2014-03-03 10:46:32 +08:00
volvet	e3bf5ced53	Merge pull request #371 from ruil2/encode_ret add verification on return value -- review request #128	2014-03-03 10:27:26 +08:00
volvet	aa043fa4e5	Merge pull request #384 from licaiguo/check-spsid-ppsid add checks for spsid and ppsid	2014-03-03 10:26:00 +08:00
Licai Guo	ba312b0b20	add checks for spsid and ppsid	2014-03-02 17:09:23 -08:00
ruil2	abdeb1951d	format update	2014-03-03 09:07:16 +08:00
volvet	a3f129d8cd	Merge pull request #382 from mstorsjo/avoid-overflow-in-timespec Avoid overflow when populating a struct timespec	2014-03-03 09:05:27 +08:00
ruil2	23df8a9ff6	add video format support verification	2014-03-03 09:03:59 +08:00
volvet	3a602a382b	Merge pull request #379 from mstorsjo/simplify-emms-calling Provide a no-op WelsEmms macro if X86_ASM is disabled	2014-03-03 09:03:41 +08:00
volvet	5be179e0aa	Merge pull request #378 from mstorsjo/fix-building-debug-code Fix building a logging statement in debug code	2014-03-03 09:00:59 +08:00
volvet	e34a08c0da	Merge pull request #380 from mstorsjo/fix-debug-printing Fix printing an event name for debugging	2014-03-03 08:58:30 +08:00
volvet	6c41cccb81	Merge pull request #377 from mstorsjo/threadlib-const-str Add const to string parameters in WelsThreadLib	2014-03-03 08:53:00 +08:00
volvet	8c7e0a6ac6	Merge pull request #381 from mstorsjo/clarify-threading-comment Clarify a comment in the threading code	2014-03-03 08:52:10 +08:00
Martin Storsjö	a96d83e762	Remove the broken WelsEventReset function This function didn't work properly with named semaphores, which are used in the unix codepaths. Since it's unused, just remove it instead.	2014-03-03 00:00:17 +02:00
Martin Storsjö	b7db015a8c	Avoid overflow when populating a struct timespec When adding the (dwMilliseconds % 1000) * 1000000 part to ts.tv_nsec, the ts.tv_nsec field can grow larger than one whole second. Therefore first add all of dwMilliseconds to the tv_nsec field and add all whole seconds to the tv_sec field instead - this way we make sure that the tv_nsec field actually is less than a second.	2014-03-02 23:53:51 +02:00
Martin Storsjö	d2fc2e47f2	Clarify a comment in the threading code Named semaphores are used instead of unnamed semaphores in the unix codepaths, since unnamed semaphores aren't available on OS X.	2014-03-02 23:51:59 +02:00
Martin Storsjö	2b82a5743d	Fix printing an event name for debugging	2014-03-02 23:49:50 +02:00
Martin Storsjö	dd47d4805f	Provide a no-op WelsEmms macro if X86_ASM is disabled This allows always calling this function, reducing the number of ifdefs in the calling code.	2014-03-02 23:46:20 +02:00
Martin Storsjö	26d66a4e1f	Fix building a logging statement in debug code	2014-03-02 23:45:14 +02:00
Martin Storsjö	8db97925a5	Add const to string parameters in WelsThreadLib	2014-03-02 23:43:45 +02:00
Martin Storsjö	3ccd2ae4cf	Remove a redundant makefile ifdef ASM_ARCH=x86 is only set if USE_ASM is enabled.	2014-03-01 23:56:14 +02:00
Ethan Hugg	6e9df66272	Merge pull request #369 from sijchen/mt_refactor3 [Encoder] remove macros to clear codes	2014-02-28 08:28:18 -08:00
volvet	33017fa722	Merge pull request #368 from huili2/sps_buffer_modif modify SPS, PPS buffer management and remove a build warning	2014-02-28 17:41:46 +08:00
Licai Guo	b7a25df13f	Remove deblocking arm asm code to common folder, add cpu detect for arm, clean some code.	2014-02-28 17:08:24 +08:00
Martin Storsjö	7d2c761604	Allow using the USE_ASM makefile variable for architectures other than x86 Add an ASM_ARCH variable which specifies which kind of assembly is supposed to be built.	2014-02-28 10:19:53 +02:00
volvet	4808eca022	update comments on welsEncoderEncodeExt	2014-02-28 15:27:54 +08:00
volvet	4c951aab83	refine welsEncoderEncodeExt	2014-02-28 15:13:38 +08:00
sijchen	10a4fb04c7	remove macros to clear codes	2014-02-28 14:54:11 +08:00
ruil2	823b3b6820	add verification on return value	2014-02-28 14:31:17 +08:00
Licai Guo	e4b6fc3f9a	modify SPS, PPS buffer management and remove a build warning	2014-02-27 22:28:16 -08:00
Licai Guo	0279cd7597	Merge pull request #367 from volvet/refine-enc-plus refine encode plus code	2014-02-28 14:18:06 +08:00
huili2	2dd41096d5	Merge pull request #366 from licaiguo/refine-rpl-pr refine rpl	2014-02-28 14:08:41 +08:00
Licai Guo	0fd9db2878	Add ARM 32bit asm code for decoder.	2014-02-28 13:36:34 +08:00
volvet	d0d050d8e5	refine encode plus code	2014-02-28 13:06:49 +08:00
Licai Guo	e902f0fea4	refine rpl	2014-02-27 21:04:31 -08:00
Ethan Hugg	3d47b7847d	Merge pull request #358 from volvet/add_ios_encDemo add encode test for iOS	2014-02-27 10:52:14 -08:00
Ethan Hugg	e5ee43173d	Merge pull request #361 from mstorsjo/get-core-count Use higher level APIs for getting the number of cores if WelsCPUFeatureDetect didn't report anything	2014-02-27 10:51:17 -08:00
ruil2	9319f879e4	Merge pull request #362 from mstorsjo/encoder-default-params Add a new public method for initializing SEncParamExt to default values	2014-02-27 17:38:16 +08:00
Licai Guo	573b02797b	Merge pull request #363 from huili2/remove_store_base remove unused codes in reference picture management	2014-02-27 12:39:23 +08:00
Licai Guo	5303eaaeb9	remove store_ref_base_pic_flag related codes in reference picture management	2014-02-26 20:00:32 -08:00
volvet	e8ecee2616	make the makefile is indepent with the pch file	2014-02-27 09:30:35 +08:00
volvet	3544aaaaab	remove boilerplate comments	2014-02-27 09:17:24 +08:00
Martin Storsjö	c7ff8876bb	Add a new public method for initializing SEncParamExt to default values This simplifies forward source compatibility when new fields are added to SEncParamExt - when new fields are added to SEncParamExt, this method makes sure those fields are initialized to the default value - otherwise all API users would have to manually check SEncParamExt every time it is updated to make sure there's no new fields that should be set to a nonzero value by default (e.g. like bEnableFrameSkip).	2014-02-26 22:12:11 +02:00
Martin Storsjö	6021ff3908	Refactor initializing defaults in a SEncParamExt to a separate function	2014-02-26 22:03:56 +02:00
Martin Storsjö	bb5b3978bf	Use higher level APIs for getting the number of cores if WelsCPUFeatureDetect didn't report anything On processors without HTT, WelsCPUFeatureDetect can't return a number of cores but might still return a nonzero set of CPU feature flags. Previously the nonzero cpu feature flag indicated that cpuid worked and the encoder wouldn't use the higher level API for getting the number of cores, even though the number of cores was left at 1.	2014-02-26 21:43:46 +02:00
Martin Storsjö	e239d9fddc	Fix a typo in a function pointer name	2014-02-26 21:26:54 +02:00
ruil2	cb4bc5ee28	add command line example	2014-02-26 16:58:03 +08:00
volvet	6dc1d43a5b	remove precompiled files	2014-02-26 16:26:16 +08:00
volvet	73ce4adc85	add encode test for iOS	2014-02-26 14:53:31 +08:00
ruil2	1edefc4d50	modify output help info and commands line input	2014-02-26 09:21:46 +08:00
huili2	c89a6911a0	Merge pull request #355 from licaiguo/check-sliceheader add a check to parseSliceHeaderSyntaxes	2014-02-25 16:56:33 +08:00
Licai Guo	a9fd78f1e2	add a check to parseSliceHeaderSyntaxes	2014-02-25 00:47:12 -08:00
Licai Guo	fc056c7ef0	Refine structure of iOS project to fix the issue.	2014-02-25 13:46:18 +08:00
Ethan Hugg	72990e1290	Merge pull request #349 from mstorsjo/cleanup-ios-project Remove unnecessary precompiled headers from the xcode projects	2014-02-24 07:44:41 -08:00
Martin Storsjö	38dbd57d36	Remove unnecessary precompiled headers This reduces the huge amount of near-useless small extra files scattered around for the sake of the platform demo projects. This requires explicitly listing all the ncessary include paths.	2014-02-24 13:26:37 +02:00
Martin Storsjö	8c9a0bac01	Add the necessary directories to the include path within xcode This is not necessary when using precompiled headers.	2014-02-24 13:24:39 +02:00
Licai Guo	3c29c92133	Merge pull request #347 from huili2/active_sps_ref_size use active SPS parameters instead of other SPS.	2014-02-24 17:03:25 +08:00
huili2	ab6931496b	Merge pull request #345 from licaiguo/fix-int-conversion-warning fix int conversion warning, using LD32/ST32	2014-02-24 17:02:35 +08:00
Licai Guo	2983c92e1c	use active SPS parameters instead of other SPS.	2014-02-24 00:52:17 -08:00
Licai Guo	d78f8c7ed8	fix int conversion warning, using LD32/ST32	2014-02-24 00:27:33 -08:00
Licai Guo	b7bee7af0a	refine level check	2014-02-24 00:09:40 -08:00
Licai Guo	d5e0b99372	cast to uint32_t in GET_WORD to prevent possible left shift error.	2014-02-23 22:22:13 -08:00
Licai Guo	c9a25e9494	Merge pull request #342 from volvet/rm-unsupported-para remove inter spatial layer prediction in parameters	2014-02-24 13:22:16 +08:00
volvet	f4d8882d2e	remove inter spatial layer prediction in parameters	2014-02-24 11:06:09 +08:00
ruil2	470fc4288c	minor update	2014-02-24 10:55:15 +08:00
ruil2	c79e78c4fb	cleanup encoder parameters	2014-02-24 10:40:17 +08:00
huili2	abc2495f2f	Merge pull request #335 from licaiguo/decoder-syntax-checks Decoder syntax checks	2014-02-24 10:35:10 +08:00
Licai Guo	265741e922	update according to review comments	2014-02-23 18:26:28 -08:00
volvet	bf0179310c	Merge pull request #340 from zhilwang/ios-support Ios support	2014-02-24 09:50:10 +08:00
volvet	14acd1e663	Merge pull request #339 from mstorsjo/console-trace-param Handle a -trace parameter for setting the trace level	2014-02-24 09:46:37 +08:00
Martin Storsjö	892d90175c	Handle a -trace parameter for setting the trace level A similar parameter already exists in the other version of the ParseCommandLine function. The WelsStderrSetTraceLevel isn't one of the functions that is exported from wels.dll (nor welsenc.dll) though, so this doesn't work (not currently either since the function is currently already referenced) if we would try to link to the encoder library dynamically.	2014-02-23 00:19:56 +02:00
Martin Storsjö	b31049df89	Respect the iDLayerQp parameter in SEncParamExt Previously the value set in the parameter struct was ignored completely.	2014-02-23 00:14:39 +02:00
Martin Storsjö	08c07db3c6	Respect the loop filter disabling encoder parameter Previously the loop filter was unconditionally enabled regardless of what encoder parameter was set. If using SEncParamBase instead, the loop filter was always disabled.	2014-02-23 00:14:39 +02:00
Martin Storsjö	8b7fb36f39	Set missed fields in ParamBaseTranscode Previously, these fields kept whatever value was set by FillDefault. The corresponding fields were set properly within sSpatialLayers, but the fields within the main struct were left with the default values. This doesn't change the hashes in the unit test, since these fields don't seem to be used in the produced bitstream at all.	2014-02-23 00:14:39 +02:00
volvet	75f8b41bcd	Merge pull request #334 from mstorsjo/cleanup-vp-interface Don't use a custom calling convention for the VP library entry points	2014-02-21 17:31:34 +08:00
Licai Guo	e7ed80c428	Merge pull request #322 from volvet/PreProcessExceptionHandle init the spatial last spatial picture if excption	2014-02-21 17:09:17 +08:00
Licai Guo	fee0f14732	finish syntax checks in ParseSps	2014-02-21 00:16:42 -08:00
Martin Storsjö	21e9c83746	Remove the local declarations of the VP interface functions There's no need to define them manually here, the normal declarations in IWelsVP.h work just fine even if not loading the WelsVP library dynamically.	2014-02-21 09:32:49 +02:00
Martin Storsjö	19efc59fae	Remove the WELSAPI definition There's no need to specify a custom calling convention for these functions.	2014-02-21 09:32:46 +02:00
Licai Guo	988a192579	Modify copyright for some files	2014-02-21 14:47:01 +08:00
Licai Guo	7e57d5205e	Add decoder ios demo	2014-02-21 14:43:09 +08:00
Licai Guo	68ebf05402	Add ios build for processing	2014-02-21 14:28:22 +08:00
Licai Guo	384ce47fc0	Remove processing ios build	2014-02-21 14:26:08 +08:00
Licai Guo	3a7305c2be	Add .gitignore to iOS folder	2014-02-21 14:23:28 +08:00
Licai Guo	c66b614dd3	Initial Commit	2014-02-21 14:07:52 +08:00
Licai Guo	97947c4d01	Add ios support for common	2014-02-21 14:04:53 +08:00
Licai Guo	672a98347f	Initial Commit	2014-02-21 13:59:43 +08:00
Licai Guo	1f7f82bad4	Add ios support for encoder.	2014-02-21 13:49:49 +08:00
volvet	a783fed407	remove cgs/mgs related code, it is not supported	2014-02-21 12:57:06 +08:00
Licai Guo	5c1c1c8347	Initial Commit	2014-02-21 11:29:38 +08:00
Licai Guo	21e1e7c966	Add ios support for dec	2014-02-21 11:26:11 +08:00
Licai Guo	4e0b8d4cbf	refine checks in ParseSps	2014-02-20 19:25:11 -08:00
Licai Guo	3873b6a0f6	Initial Commit	2014-02-21 11:15:04 +08:00
volvet	25efddd745	remove quality layer configuration. It is not supported	2014-02-21 10:51:47 +08:00
volvet	2bdf6d3736	Merge pull request #325 from sijchen/writenal_refactor3 add encoder error code and refactor WelsWriteNal	2014-02-21 08:41:02 +08:00
Ethan Hugg	df6f92096a	Merge pull request #330 from mstorsjo/android-build-fixes Android build fixes/cleanups	2014-02-20 15:39:22 -08:00
Martin Storsjö	8771e08f0f	Ignore files produced by XCode	2014-02-20 12:33:38 +02:00
Martin Storsjö	42e80cec0d	Don't use LOCAL_PATH in LOCAL_SRC_FILES These files are automatically relative to the directory of the current makefile.	2014-02-20 12:28:00 +02:00
Martin Storsjö	d9441dc793	Ignore project.properties This file is autogenerated when building nowadays.	2014-02-20 09:42:52 +02:00
Licai Guo	d69b2faa9f	fix the crash issues by changing the type iMbWidth & iMbHeight.	2014-02-19 23:06:35 -08:00
sijchen	e45e859473	Squashed merge from writenal_refactor2	2014-02-20 14:50:04 +08:00
Licai Guo	42cc716395	Merge pull request #324 from volvet/add-missed-namespace-for-encoder add missed namespace for encoder, remove un-used file	2014-02-20 14:46:05 +08:00
volvet	ab2e5fe207	Merge pull request #321 from licaiguo/add-android-target-option Add android target option	2014-02-20 14:40:27 +08:00
volvet	e565e50d4d	add missed namespace for encoder, remove un-used file	2014-02-20 14:33:03 +08:00
Licai Guo	46b9d5d0da	Merge pull request #323 from huili2/check_bit_read add safety check for bit-reading for headers	2014-02-20 14:17:07 +08:00
volvet	d6c5c138ee	init the spatial last spatial picture if excption	2014-02-20 12:50:37 +08:00
Licai Guo	538d22560f	refine android build, add TARGET option to specify target in sdk	2014-02-19 20:49:30 -08:00
Licai Guo	a921bc6589	Merge pull request #320 from huili2/mb_residual_size_check remain size to prevent MB residual reading overflow	2014-02-20 11:19:57 +08:00
ruil2	3ba6a5f4da	Simplify encoder interface--remove EncoderFrame2 from interface function	2014-02-20 10:33:07 +08:00
Licai Guo	65c7168d8d	Add iOS support for decoder.	2014-02-20 10:08:37 +08:00
Martin Storsjö	fe17cd5a13	Remove unnecessary commented out code in the android makefiles Comments isn't a place to store code snippets that might (or might not) be useful later.	2014-02-19 22:16:09 +02:00
Martin Storsjö	0b74eee631	Ignore files generated while building the android projects	2014-02-19 22:16:09 +02:00
Martin Storsjö	72fb054c10	Remove unused proguard config files	2014-02-19 22:16:09 +02:00
Martin Storsjö	810db4e3fd	Add a missing include directory in the android makefiles	2014-02-19 22:16:09 +02:00
Ethan Hugg	0a73155bdd	Merge pull request #306 from licaiguo/add-android-pull-clean Add android Support	2014-02-19 09:59:25 -08:00
Ethan Hugg	f7758a3074	Merge pull request #312 from mstorsjo/cleanup-vp-interface Avoid duplicating the IWelsVP.h header	2014-02-19 09:55:34 -08:00
Ethan Hugg	50e49f3704	Merge pull request #310 from mstorsjo/remove-unused-variables Avoid declaring unused variables	2014-02-19 09:26:00 -08:00
Martin Storsjö	7acb6cd4d0	Remove the duplicated IWelsVP.h file Instead have the encoder include it directly from the processing library. Both copies of the files were mostly identical so far.	2014-02-19 15:00:49 +02:00
Martin Storsjö	3e4e74a4d8	Remove unused include directories	2014-02-19 14:57:06 +02:00
Martin Storsjö	099595696b	Add the common processing include directories to the include path This avoids using relative paths for including these files.	2014-02-19 14:42:03 +02:00
Martin Storsjö	f6a46960c9	Check a string length before doing a strncpy	2014-02-19 10:42:52 +02:00
Martin Storsjö	fd100598ab	Avoid declaring unused variables Move the variable declarations within the ifdef instead.	2014-02-19 10:39:43 +02:00
Martin Storsjö	3532781556	Mark source parameters to MC functions as const	2014-02-19 10:19:56 +02:00
Martin Storsjö	ebb890e03e	Declare static functions within the file they are used/defined in It does not make sense to declare but not define static functions in a header.	2014-02-19 09:51:25 +02:00
Martin Storsjö	1a1b78e9c5	Remove unnecessary declarations of static functions These functions don't need to be declared in advance at all.	2014-02-19 09:25:27 +02:00
Licai Guo	a3c38b5631	add safety check for bit-reading for headers	2014-02-18 22:55:12 -08:00
ruil2	dd93aa90b2	Merge pull request #290 from volvet/develop_b Refactor CWelsPreProcess	2014-02-19 10:18:56 +08:00
volvet	bb58c5c720	correct style	2014-02-19 10:04:17 +08:00
Licai Guo	fbcf01cbbc	add missing icon files	2014-02-18 18:01:27 -08:00
Licai Guo	d058176c3b	add android support, single commit	2014-02-18 17:54:27 -08:00
ruil2	e79769fb88	Merge pull request #305 from mstorsjo/fix-encoder-param-interface Don't duplicate the SEncParamExt/SEncParamBase structs for C compatibility	2014-02-19 09:12:58 +08:00
huili2	0fcd066cde	Merge pull request #298 from licaiguo/decoder-syntax-element-step1 add decoder syntax checks	2014-02-19 08:57:50 +08:00
Martin Storsjö	7d638f8a6b	Remove the now unused INIT_TYPE data type	2014-02-18 22:52:00 +02:00
Martin Storsjö	49f4dad1b7	Split the encoder Initialize method into two This avoids the struct type casting and having to pass a parameter that says which kind of struct it actually is.	2014-02-18 22:51:54 +02:00
Martin Storsjö	622694935b	Use SEncParamExt in ProcessEncodingSvcWithParam Both FillSpecificParameters and ParseCommandLine use parameters that don't exist in SEncParamBase.	2014-02-18 22:51:54 +02:00
Martin Storsjö	a899f05f2d	Don't have SEncParamExt inherit SEncParamBase Instead just duplicate the common fields. These fields had to be duplicated for the C interface compatibility anyway - but this way there is no risk to accidentally introduce an ABI break since there is no need for the layout of SEncParamBase to actually match the start of SEncParamExt.	2014-02-18 22:51:54 +02:00
Martin Storsjö	80f5aa216a	Don't copy out the SEncParamBase, manually read the individual fields instead	2014-02-18 22:51:53 +02:00
Martin Storsjö	b6502a5406	Respect the bEnableRc field in SEncParamExt	2014-02-18 22:51:53 +02:00
Martin Storsjö	f432ddeea8	Remove a field from SWelsSvcCodingParam that already exists in SEncParamExt	2014-02-18 22:51:53 +02:00
Martin Storsjö	6d6a63a703	Mark the Initialize pointer parameter as const This makes it clear to the callers that the struct will not be modified by this call.	2014-02-18 22:51:53 +02:00
Martin Storsjö	2438b31323	Don't needlessly copy the input parameter struct	2014-02-18 22:51:53 +02:00
Martin Storsjö	bcd57f412a	Make Param*Transcode take a const reference There is no need to modify the caller's struct.	2014-02-18 22:51:53 +02:00
Martin Storsjö	a1f6e158ef	Move REC_FRAME_COUNT logging into the Initialize2 method	2014-02-18 22:51:53 +02:00
Martin Storsjö	fc970418fa	Fix building with REC_FRAME_COUNT defined	2014-02-18 22:51:53 +02:00
Martin Storsjö	525ad9e7c8	Remove unnecessary checks/initialization from the Initialize method Initialize2 does the same checks and initializes the same fields.	2014-02-18 22:51:53 +02:00
Martin Storsjö	1a32ae7120	Simplify the CWelsH264SVCEncoder::Initialize2 method Remove the useless iInitType parameter, make the method private within CWelsH264SVCEncoder class, give the pointer parameter the correct type, avoiding needless casting.	2014-02-18 22:51:53 +02:00
Martin Storsjö	5cb8518306	Remove the Initialize2 function from the external API This function no longer needs to be public since one can pass SEncParamExt to the normal Initialize function.	2014-02-18 22:51:53 +02:00
Ethan Hugg	413b301e9c	Merge pull request #303 from mstorsjo/simplify-decoder-api Simplify the Initialize decoder method	2014-02-18 11:27:38 -08:00
Ethan Hugg	2243467c1b	Merge pull request #304 from mstorsjo/remove-unused-variables Remove completely unused variables and private fields	2014-02-18 11:26:19 -08:00
Licai Guo	24359dcde1	Merge pull request #301 from ruil2/temporal_num use temporal layer num and remove gop size in external configure-- review request #94	2014-02-18 21:04:21 +08:00
Martin Storsjö	3b297ec866	Remove completely unused variables and private fields	2014-02-18 13:04:13 +02:00
Martin Storsjö	1075338b9b	Use the actual struct type instead of a void pointer to the decoder Initialize method	2014-02-18 13:00:59 +02:00
Martin Storsjö	658d1e3651	Remove the unused iInitType parameter to the decoder Initialize method	2014-02-18 13:00:45 +02:00
volvet	8435dd33af	Merge pull request #297 from licaiguo/refine-mc.cpp add refine mc.cpp on decoder	2014-02-18 18:56:30 +08:00
Martin Storsjö	647fff6e2b	Remove useless ifdefs This is in practice always enabled on all currently supported platforms.	2014-02-18 11:09:28 +02:00
ruil2	f5cd56ea74	use temporal layer num and remove gop size in external configure	2014-02-18 17:06:41 +08:00
Martin Storsjö	61067d488f	Fix building with MT_DEBUG enabled after the encoder interface update There is no struct named SMulSliceOption any longer.	2014-02-18 10:29:48 +02:00
Licai Guo	61b64190dd	add decoder syntax checks	2014-02-17 23:57:12 -08:00
volvet	592665a21d	Merge branch 'master' of https://github.com/cisco/openh264 into develop_b	2014-02-18 15:34:06 +08:00
ruil2	8e8972b6e8	fix build fail on osx	2014-02-18 15:16:10 +08:00
Licai Guo	d0a7f9b625	add refine mc.cpp on decoder 1. remove unecessary init 2. add static to constant function pointer array	2014-02-17 22:36:56 -08:00
Licai Guo	278597be2f	Merge pull request #292 from huili2/level_prefix fix level_prefix too large in residual decoding	2014-02-18 14:22:30 +08:00
Licai Guo	06d3ed8ddc	Merge pull request #294 from huili2/neg_left_shift negative data with left shift, use cast or multiplication instead	2014-02-18 14:21:44 +08:00
Licai Guo	f5d086eba1	merge the calculate	2014-02-17 22:16:51 -08:00
volvet	5fe3b6e362	update to the last commit: interface change	2014-02-18 14:00:42 +08:00
Ethan Hugg	287f3538d4	Merge pull request #295 from huili2/dec_api_rm_tl remove unused temporal ID info in decoder API	2014-02-17 20:43:58 -08:00
Licai Guo	a810408cdc	negative data with left shift, use cast or multiplication instead	2014-02-17 19:13:41 -08:00
ruil2	35fa429fb0	encoder interface update step1	2014-02-18 09:51:47 +08:00
Ethan Hugg	3ff7e3d045	Merge pull request #291 from volvet/name_process_step give right name to pre-process step1 and step3	2014-02-17 11:26:20 -08:00
Licai Guo	7bace8406e	remain size to prvent MB residual reading overflow	2014-02-17 00:47:41 -08:00
Licai Guo	b1d748294c	remove unused temporal ID info in decoder API	2014-02-16 23:57:06 -08:00
volvet	bb354d7c13	name pre-process steps	2014-02-17 14:41:37 +08:00
volvet	e61578785b	Merge pull request #286 from mstorsjo/remove-hw-decode Remove stub interfaces for hw decoding	2014-02-17 13:24:21 +08:00
volvet	600a79bea6	correct code style	2014-02-17 11:46:52 +08:00
volvet	475309307c	move spatial picture related variable to CWelsPreProcess	2014-02-17 11:35:52 +08:00
volvet	488482811c	add update spatial pictures method too CWeslPreProcess	2014-02-17 10:53:46 +08:00
volvet	0a5024d176	move alloc spatial picture and free spatial picture to CWelsPreProcess	2014-02-17 10:24:56 +08:00
volvet	7f59e2f8d9	use forward declaration to replace type cast	2014-02-14 16:50:13 +08:00
Licai Guo	0d1deb578e	fix level_prefix too large in residual decoding	2014-02-13 22:51:45 -08:00
Ethan Hugg	dbb894442f	Merge pull request #284 from volvet/clean_spatial_picture_code Clean spatial picture alloc code	2014-02-13 15:18:02 -08:00
Ethan Hugg	3343b1996b	Merge pull request #285 from volvet/develop_b remove duplicated function	2014-02-13 14:35:37 -08:00
Martin Storsjö	55d7491f3d	Remove stub interfaces for hw decoding There is no implementation available for actually doing decoding in HW.	2014-02-13 14:21:38 +02:00
volvet	6c5b22ceff	remove duplicate function	2014-02-13 17:40:02 +08:00
Martin Storsjö	c418a76d8e	Don't try to include stdbool.h on MSVC MSVC only got stdbool.h in MSVC 2013; provide a manual typedef for this compiler instead. The C interface test makes sure that this doesn't break the ABI.	2014-02-13 10:09:35 +02:00
volvet	b770bb80c0	Clean spatial picture alloc code	2014-02-13 12:00:02 +08:00
Martin Storsjö	ce22f84a2b	Regenerate target makefiles after the latest mktargets.py changes	2014-02-12 22:11:05 +02:00
Ethan Hugg	b51963c009	Merge pull request #219 from volvet/mozilla_bug_963392_fix fix crash bug 963392 and update the print help text.	2014-02-11 09:36:59 -08:00
Martin Storsjö	29ccdebad9	Correct the plane naming within the D3D code Within I420 (as the decoder outputs), the first chroma plane is U and the second is V, and similarly, in NV12, the chroma components are written in the order U, V. This doesn't have any practical effect, it only makes the variable naming while it previously was misleading.	2014-02-11 12:26:36 +01:00
volvet	d81f3d5037	Merge pull request #279 from sijchen/sad_fix2 fix the range of SAD	2014-02-11 10:32:58 +08:00
Martin Storsjö	83e7e7fbd9	Show the right message if no output file has been specified H264DecodeInstance expects the pointer to be a null pointer if no file has been specified.	2014-02-10 20:51:20 +02:00
Martin Storsjö	3e13874a77	Remove some needless casts by using the right data type	2014-02-10 20:51:20 +02:00
Ethan Hugg	8b8e0d4b3e	Merge pull request #274 from mstorsjo/typedef-cleanup Remove typedefs for standard C++ types	2014-02-10 10:46:12 -08:00
Ethan Hugg	1e549e6f9a	Merge pull request #271 from mstorsjo/merge-asm-headers Merge declarations of shared asm functions into the comon library	2014-02-10 10:40:34 -08:00
Ethan Hugg	007f5ba773	Merge pull request #258 from mstorsjo/endian-cleanup Avoid endian-specific code	2014-02-10 10:36:05 -08:00
Martin Storsjö	80862eec77	Use the C++ constants true/false instead of defining our own TRUE/FALSE has intentionally been left in use for the few platform specific APIs that define these constants themselves and expect them to be used, for consistency.	2014-02-10 08:06:37 +02:00
Martin Storsjö	f2bd22acd5	Use char instead of str_t	2014-02-10 08:06:37 +02:00
Martin Storsjö	7b96c6756e	Use void instead of void_t There's really no reason for adding a typedef for void.	2014-02-10 08:06:33 +02:00
Martin Storsjö	2b77fe7f49	Use bool instead of bool_t bool is one of the built in, standard types in C++, there's no need for a typedef for it.	2014-02-10 08:05:09 +02:00
Martin Storsjö	17d7b5d72e	Use bool_t instead of BOOL_T One bool typedef is already more than enough, two is too many.	2014-02-10 08:05:09 +02:00
Martin Storsjö	0f7a958ce3	Move declarations of functions in mc_chroma/luma.asm into a header in common	2014-02-10 08:05:02 +02:00
Martin Storsjö	ad209c2d14	Move declarations of functions in expand_picture.asm into a header in common	2014-02-10 08:05:02 +02:00
volvet	bf9a78085e	Merge pull request #273 from mstorsjo/remove-editor-state-file Remove an MSVC resource editor state file	2014-02-10 09:08:09 +08:00
volvet	a4d9ba3feb	Merge pull request #275 from mstorsjo/fix-win64-noasm-build Fix building for win64 with assembly disabled	2014-02-10 09:00:31 +08:00
Martin Storsjö	47934b3042	Fix building for win64 with assembly disabled	2014-02-09 02:19:48 +02:00
Martin Storsjö	83892ad056	Remove an MSVC resource editor state file This file contains the local UI state of the resource editor, and should not be committed to version control. A similar file was removed earlier in `c61b040`, but this one was missed.	2014-02-08 23:40:06 +02:00
Martin Storsjö	a532c1233b	Take the missed WelsDecoderI4x4LumaPredH_sse2 function into use Previously this function was never used.	2014-02-08 23:09:16 +02:00
Martin Storsjö	d0185ab253	Remove redundant /./ parts from pathnames in makefiles This is mostly a cosmetic improvement for the quiet make output.	2014-02-08 18:46:52 +02:00
Ethan Hugg	c80553bfa1	Merge pull request #270 from mstorsjo/c-interface-headers Include stdbool.h in the public interface headers in C mode	2014-02-08 08:42:48 -08:00
Martin Storsjö	bcd08d8713	Include stdbool.h in the public interface headers in C mode This avoids requiring the callers to explicitly include it before including codec_api.h	2014-02-08 14:37:26 +02:00
Martin Storsjö	e66ad9ab86	Remove the real32_t typedef The float type is defined in standards and is portably available on all supported compilers and platforms.	2014-02-08 14:12:03 +02:00
Martin Storsjö	d36b10fac5	Remove typedefs for float_t and double_t The actual float and double data types are defined in C89 and are usable as such without any extra typedefs. Removing the extra typedefs simplifies the compatibility typedef headers, simplifies portability and makes the code base easier to work with for people new to the library.	2014-02-08 14:11:44 +02:00
Martin Storsjö	ba6bf7da18	Consistently use inline instead of __inline This seemed to have been missed in `109fecc`.	2014-02-08 14:08:46 +02:00
Martin Storsjö	f252acf8a5	Remove fallback defines for NULL No actual (supported) compiler lacks a definition for NULL, and it is mandated to be present in stddef.h according to the C89 standard.	2014-02-06 10:38:15 +02:00
orbitcowboy	7d29cecc0e	cleanup variable initializations.	2014-01-31 23:13:21 +01:00
orbitcowboy	21197abe96	cleanup unused variable in codec/common/deblocking_common.cpp.	2014-01-31 23:00:30 +01:00
Martin Storsjö	8ecdcc7172	Add a make option for silencing the commands run Add "V=No" to the make command to silence the make output. This makes it easier to spot warnings or other unexpected messages in the build output.	2014-01-30 13:56:19 +02:00
Martin Storsjö	0a14d4c79b	Make the deblocking handling endian independent This avoids having to set a define indicating the endianness. This doesn't incur any significant measurable slowdown.	2014-01-30 10:33:21 +02:00
Martin Storsjö	21687726d0	Avoid requiring byteswapping functions Instead of byteswapping a 32 bit word and writing it out as a whole (which could even possibly lead to crashes due to incorrect alignment on some platforms), write it out explicitly in the intended byte order. This avoids having to set a define indicating the endianness.	2014-01-30 10:16:25 +02:00
Ethan Hugg	1e744b1933	Merge pull request #257 from mstorsjo/simplify-endian-func Simplify the implementation of GetValueOf4Bytes	2014-01-29 15:25:30 -08:00
Ethan Hugg	fbcd962169	Merge pull request #256 from mstorsjo/bigendian Make the library work on big endian	2014-01-29 15:24:32 -08:00
Martin Storsjö	1d2c37f7de	Simplify the implementation of GetValueOf4Bytes What the two different implementations currently do is simply to write a 32 bit number, in the native endianness, into the given buffer. The actual purpose of this function is still unknown though, it can be removed completely without breaking decoding - it is possibly a remnant from earlier functionality in the decoder.	2014-01-29 22:44:42 +02:00
Martin Storsjö	cadbec75d8	Fix shifting tricks in deblocking for big endian The code interprets an array of 4 uint8_t values as one uint32_t and does shifts on the value. The same optimization can be kept in big endian as well, but the shift has to be done in the other direction. This code could be made truly independent of endianness, but that could cause some minimal performance degradaion, at least in theory. This makes "make test" pass on big endian, assuming that WORDS_BIGENDIAN is defined while building.	2014-01-29 22:30:33 +02:00
Martin Storsjö	47ec78843a	Don't read an uint8_t array as an uint32_t This makes the code work properly on big endian. The MC case is similar to how it's done in the encoder. Neither of these should have any significant performance impact.	2014-01-29 22:27:55 +02:00
Martin Storsjö	66c39a4fd4	Remove the array_stack_align.h header from the encoder lib All of these macros are already available in the common macros.h header. Unify all the macros to be named ENFORCE_* instead of mixed FORCE/ENFORCE.	2014-01-29 22:07:52 +02:00
Martin Storsjö	b2178aacc0	Fix a typo in a directory name	2014-01-29 10:29:53 +02:00
Ethan Hugg	ec576baf25	Merge pull request #249 from mstorsjo/encconsole-arg-parsing-ifdef Fix parsing of the -drec option if ENABLE_FRAME_DUMP isn't set	2014-01-28 11:05:31 -08:00
Ethan Hugg	b58bf88b44	Merge pull request #247 from mstorsjo/simplify-missed-inline-asm-macro Unify the codepaths for WELS_GET_PERFIX_BITS at the second place	2014-01-28 11:04:50 -08:00
Ethan Hugg	08638a9396	Merge pull request #252 from mstorsjo/share-processing-asm Merge identical assembly code between the processing and encoder libs	2014-01-28 11:04:12 -08:00
Ethan Hugg	3c40261256	Merge pull request #251 from mstorsjo/crt-string-cleanup Clean up the rest of the usage of crt_safe_util_x	2014-01-28 09:42:56 -08:00
Ethan Hugg	0d7bafcebc	Merge pull request #248 from mstorsjo/msvc-proj-cleanup MSVC project file warning cleanup	2014-01-28 09:40:17 -08:00
Martin Storsjö	04dba61d22	Remove an unused assembly source file Nothing within processing uses functions from this file.	2014-01-28 13:55:41 +02:00
Martin Storsjö	3761901ed4	Remove sad.asm from the processing lib, move satd_sad from the encoder to the common lib sad.asm as used in processing is an exact subset of the code in satd_sad.asm in the encoder.	2014-01-28 13:54:57 +02:00
Martin Storsjö	e0da5a1686	Remove the now unused STRCAT macro	2014-01-28 12:43:22 +02:00
Martin Storsjö	208f033bcd	Use WelsStrcat instead of the STRCAT macro	2014-01-28 12:43:22 +02:00
Martin Storsjö	903f265965	Fix a format string to use the correct type	2014-01-28 12:42:01 +02:00
Martin Storsjö	5c5dcfb14c	Remove an unused global variable and commented out code	2014-01-28 12:36:54 +02:00
Martin Storsjö	fa93c88fa2	Implement WelsStrcat based on WelsStrncpy This is a more convenient behaviour (truncating on overflow and always null terminating the buffer) compared to the MSVC safe strcat_s which aborts the process if the string doesn't fit into the target buffer. Also mark the source buffer as const in the function prototype.	2014-01-28 12:27:22 +02:00
Martin Storsjö	9840f11784	Remove the now unused count parameter to WelsStrncpy Also remove manual null termination as WelsStrncpy now always takes care of it.	2014-01-28 12:13:11 +02:00
Martin Storsjö	a16ccc0b4d	Fix the implementations of WelsStrncpy Make the MSVC "safe" version truncate instead of aborting the process if the buffer is too small. Update all the other functions to use the right parameter (iSizeInBytes, not iCount) as 'n' parameter to strncpy. (By passing iCount as parameter to the normal strncpy functions, it meant that the resulting buffer actually never was null terminated.) Additionally make sure that the other implementations of WelsStrncpy always null terminate the resulting buffer, just as the MSVC safe version does when passed the _TRUNCATE parameter.	2014-01-28 12:08:35 +02:00
Martin Storsjö	74e7c9b6d8	Remove the now unused STRNCPY macro	2014-01-28 12:06:07 +02:00
Martin Storsjö	215eb56453	Use WelsStrncpy instead of STRNCPY	2014-01-28 12:05:28 +02:00
Martin Storsjö	7791a6d28d	Use WelsSnprintf instead of a combination of strlen and STRNCAT This simplifies the code and makes the buffer size checks more consistent. Additionally, the previous version wrote the extra space character without checking if it actually fit into the buffer.	2014-01-28 12:00:04 +02:00
Martin Storsjö	0318922654	Check the right pointer for being non-null in WelsLogDefault In case the log level was invalid, GetLogTag returns null. Checking pCtx doesn't make sense since nothing within the if block uses pCtx.	2014-01-28 12:00:04 +02:00
Martin Storsjö	9b59153263	Remove the STRNLEN/WelsStrnlen compatibility functions These were essentially useless - if strlen() ever was used as fallback, it either indicated that those ports of the library were insecure, or that strnlen never was required at all. In this case it turned out to be the latter (at least after the preceding cleanups) - all uses of it were with known null terminated strings.	2014-01-28 12:00:04 +02:00
Martin Storsjö	19f03d6a26	Fix parsing of the -drec option if ENABLE_FRAME_DUMP isn't set If the define wasn't set, the argument iterator didn't skip the file name argument.	2014-01-28 11:46:27 +02:00
Martin Storsjö	92fa4eb400	Use strlen instead of WelsStrnlen/STRNLEN for known null terminated strings strlen is not dangerous if the string is known to be null terminated (and MSVC does not warn about its use either). For the cases in the decoder welsCodecTrace.cpp, the string passed to all WriteString instances is produced by WelsVsnprintf which always null terminates the buffer nowadays. Additionally, as the string was passed to OutputDebugStringA without any length specifier before, it was already assumed to be null terminated. The file name parameter passed to DumpDependencyRec and DumpRecFrame in encoder.cpp is always null terminated, which was already assumed as it is passed to WelsFopen as is. As for the encoder utils.cpp, the strings returned by GetLogPath are string constants that are null terminated.	2014-01-28 11:40:54 +02:00
Martin Storsjö	082a986990	Use strlen() instead of WelsStrnlen/STRNLEN for string constants A string constant is guaranteed to be null terminated, and thus doesn't need to use a version of strlen with a fixed buffer size limit.	2014-01-28 11:38:26 +02:00
Martin Storsjö	da7d3d9bad	Remove an unused and unnecessary string length calculation This is unused since `771ff739b`.	2014-01-28 11:38:22 +02:00
Martin Storsjö	8a0bc0a8b9	Don't pass /LTCG to the linker for the console front end binary The object files for this tool aren't built with the /GL flag (Whole Program Optimization), leading to the following warning when linking: /LTCG specified but no code generation required; remove /LTCG from the link command line to improve linker performance Enabling link time code generation for the console front end binary isn't of much use, since this tool in itself isn't performance critical.	2014-01-28 11:01:54 +02:00
Martin Storsjö	e306888d0c	Unify the codepaths for WELS_GET_PERFIX_BITS at the second place This changes a second use of the macro which was missed in `60e0255677`. This avoids warnings about unused local variables in 64 bit builds in MSVC.	2014-01-28 11:00:20 +02:00
Martin Storsjö	3316938ae4	Enable incremental linking in debug configurations of WelsDecPlus This avoids the following warning when linking: LNK4075: ignoring '/EDITANDCONTINUE' due to '/INCREMENTAL:NO' specification	2014-01-28 10:30:46 +02:00
Ethan Hugg	4334812eee	Merge pull request #235 from mstorsjo/merge-ls-defines Merge the ls_defines.h headers into the common sub-library	2014-01-27 14:10:00 -08:00
Ethan Hugg	00a76419b4	Merge pull request #237 from mstorsjo/simplify-make-lib-rules Simplify the make rules for creating libraries	2014-01-27 14:09:20 -08:00
Ethan Hugg	d9cbe19110	Merge pull request #240 from mstorsjo/simplify-inline-asm Unify the fallback codepath for getting prefix bits into a macro	2014-01-27 13:07:38 -08:00
Ethan Hugg	5616ddb3a5	Merge pull request #242 from mstorsjo/simplify-debug-file-locations Simplify debugging code by always writing trace files to the current directory	2014-01-27 13:04:29 -08:00
Ethan Hugg	990a71dce7	Merge pull request #244 from mstorsjo/remove-unused-files Removed an unused pair of files generated by MSVC project wizards	2014-01-27 13:03:17 -08:00
Ethan Hugg	b00523329f	Merge pull request #243 from mstorsjo/use-stdio-wrappers Consistently use the compat wrappers for file IO	2014-01-27 13:02:51 -08:00
Martin Storsjö	d36939580a	Removed an unused pair of files generated by MSVC project wizards These files aren't actually even referenced by the MSVC project files.	2014-01-27 22:55:33 +02:00
Martin Storsjö	3559f425b4	Consistently use the compat wrappers for file IO As long as WelsFileHandle* is equal to FILE* this doesn't matter, but for consistency use the WelsF* functions for all handles opened by WelsFopen, and use WelsFileHandle* as type for it instead of FILE*.	2014-01-27 22:49:41 +02:00
Martin Storsjö	98614924e2	Remove the now meaningless field sTracePath	2014-01-27 22:37:11 +02:00
Martin Storsjö	771ff739b6	Simplify debugging code - always write debug trace files to the cur directory This reduces the amount of platform ifdefs.	2014-01-27 22:36:50 +02:00
Martin Storsjö	60e0255677	Unify the fallback codepath for getting prefix bits into a macro This avoids having to know the details about when the optimized codepath is available at the place where it's used.	2014-01-27 22:30:00 +02:00
Martin Storsjö	55717d3fb8	Remove an unused function for byte order swapping	2014-01-27 22:18:23 +02:00
Ethan Hugg	e17e664e1a	Merge pull request #239 from mstorsjo/remove-unnecessary-calls Remove some unnecessary STRNCPY/WelsStrncpy calls and intermediate buffers	2014-01-27 11:50:19 -08:00
Ethan Hugg	e05b607daa	Merge pull request #223 from mstorsjo/typedef-cleanup Clean up typedefs within the libraries	2014-01-27 11:46:44 -08:00
Martin Storsjö	ec20ab58ef	Remove some unnecessary STRNCPY/WelsStrncpy calls and intermediate buffers	2014-01-27 20:00:15 +02:00
Martin Storsjö	2bcadff204	Use WelsGetTimeOfDay and WelsStrftime instead of LOCALTIME/FTIME/strftime	2014-01-27 19:20:45 +02:00
Martin Storsjö	0439392a79	Fix a typo Millsecond -> Millisecond	2014-01-27 19:20:27 +02:00
Martin Storsjö	3a5ff9b6c8	Use WelsVsnprintf instead of VSPRINTF	2014-01-27 19:18:36 +02:00
Martin Storsjö	f6fe4ddeaa	Use WelsSnprintf instead of SNPRINTF	2014-01-27 19:18:36 +02:00
Ethan Hugg	6fea084a42	Merge pull request #234 from mstorsjo/merge-measure-time Move the measure_time.h header to the common library	2014-01-27 08:57:16 -08:00
Ethan Hugg	2a55578a98	Merge pull request #208 from mstorsjo/remove-unused-mk-field Remove an unnecessary field from generated makefiles	2014-01-27 08:55:23 -08:00
Ethan Hugg	d5affbaa3c	Merge pull request #232 from mstorsjo/merge-fopen-wrappers Remove the FOPEN macro, use WelsFopen instead	2014-01-27 08:54:20 -08:00
Ethan Hugg	5a8f5f9ad1	Merge pull request #233 from mstorsjo/snprintf-fixes Make the *snprintf (and similar) functions always null terminate the buffer properly on all platforms	2014-01-27 08:52:37 -08:00
Ethan Hugg	dacd6735fb	Merge pull request #230 from mstorsjo/remove-legacy-make Remove the legacy makefile based build system	2014-01-27 07:59:03 -08:00
Ethan Hugg	fbf7836b8d	Merge pull request #236 from mstorsjo/msvc-proj-moved-headers Update the MSVC project files for earlier moved/removed files	2014-01-27 07:56:25 -08:00
Ethan Hugg	f3afcd51ff	Merge pull request #231 from mstorsjo/fix-msvc-build Readd a removed include	2014-01-27 07:54:29 -08:00
Martin Storsjö	ea8a00278f	Simplify the make rules for creating libraries	2014-01-27 14:45:18 +02:00
Martin Storsjö	ea333863ee	Update the MSVC project files for earlier moved/removed files	2014-01-27 14:23:22 +02:00
Martin Storsjö	a44808e276	Merge the ls_defines.h headers into the common sub-library	2014-01-27 14:14:41 +02:00
Martin Storsjö	11bdd8adad	Move the measure_time.h header to the common library Both encoder and decoder versions were functionally equivalent, but I picked the decoder version (but added the static inline keywords to it) since the encoder one was quite messy with a lot of commented out code.	2014-01-27 12:58:23 +02:00
Martin Storsjö	c7b74b2b12	Make sure the buffer is null terminated after strftime If the buffer is too small, there's no guarantee that it is null terminated. The docs (on both unix and MSVC) say explicitly that the function returns 0 and the buffer contents are indeterminate in this case.	2014-01-27 12:07:00 +02:00
Martin Storsjö	7884e77b2d	Make sure the buffer always is null terminated in the *snprintf calls for old MSVC These functions leave the buffer unterminated in case it was too small.	2014-01-27 12:06:24 +02:00
Martin Storsjö	4a8f54d767	Use vsnprintf in the old MSVC version of WelsSnprintf as well	2014-01-27 12:06:08 +02:00
Martin Storsjö	0ce42ffb89	Rename WelsVsprintf to WelsVsnprintf, to indicate that it actually checks the length	2014-01-27 12:05:53 +02:00
Martin Storsjö	e42e82aa1f	Make WelsVsprintf use vsnprintf, to check the buffer size Otherwise builds on platforms other than MSVC might be insecure. Use vsnprintf_s with the _TRUNCATE flag instead of vsprintf_s when using MSVC - this truncates the buffer instead of aborting the whole process in case it's too small.	2014-01-27 12:05:39 +02:00
lyao2	00948873fb	fix spell error of RcInitGoomParameters	2014-01-27 17:29:24 +08:00
Martin Storsjö	c174dcd652	Remove the FOPEN macro, use WelsFopen instead This avoids ifdefs at each place the macro is used.	2014-01-27 10:29:05 +02:00
Martin Storsjö	febf6bb51e	Readd a removed include This fixes builds without NO_DYNAMIC_VP (such as with the MSVC project files), the include was removed in `d809b7e9`.	2014-01-27 10:25:32 +02:00
volvet	33fe2b5883	Merge pull request #225 from mstorsjo/simplify-ifdefs Simplify ifdefs in measure_time.h	2014-01-27 00:14:44 -08:00
Martin Storsjö	b468ed3c0b	Unify the declaration of int8_t within the processing lib with the rest int8_t in general should to be defined as signed char, since there are actual envrionments where a plain 'char' is unsigned. This also reduces the differences between the typedef headers of the different sub-libraries.	2014-01-27 08:44:48 +02:00
Martin Storsjö	a24fd5e120	Make the bool_t typedef in the processing lib match the others There is no specific reason to use int32_t for this type.	2014-01-27 08:44:48 +02:00
Martin Storsjö	09f0254d5e	Remove the now unused long_t typedef	2014-01-27 08:44:48 +02:00
Martin Storsjö	cc4507462b	Use int32_t instead of long_t in WELS_SIGN/WELS_ABS in the processing lib This makes them match the same macros in the main decoder/encoder libraries. long_t (which is typedeffed to long) actually is 64 bit on 64 bit unix platforms, which might not be what was intended.	2014-01-27 08:44:48 +02:00
Martin Storsjö	0339cd51c5	Unify the definition of WELS_THREAD_ERROR_CODE between libraries This simplifies the code base, reduces the risk for mixups and gets rid of the use of a local nonstandard typedef.	2014-01-27 08:44:48 +02:00
Martin Storsjö	109fecc547	Consistently use inline instead of __inline	2014-01-27 08:44:48 +02:00
Martin Storsjö	98dd2d91d9	Use 'inline' instead of 'inline_t' in the processing lib Just use the standard inline keyword with sufficient backwards compatibility defines, similar to how it is done in the main decoder and encoder libraries.	2014-01-27 08:44:48 +02:00
volvet	cbe650a3e5	Merge pull request #227 from mstorsjo/snprintf-fixes Fix handling of snprintf return values and buffer size calculations	2014-01-26 22:26:38 -08:00
Martin Storsjö	30bcfea6b8	Simplify ifdefs in measure_time.h Instead of using "defined(MSC_VER) \|\| defined(__MINGW32__)" to indicate the windows platform, just check for the _WIN32 define instead. Also remove an unused codepath - the removed codepath would only be used under the condition "(defined(MSC_VER) \|\| defined(__MINGW32__)) && !defined(_WIN32)", and I'm not aware of any environment with MSVC or MinGW that doesn't define _WIN32, thus this codepath never was used.	2014-01-27 08:08:23 +02:00
Martin Storsjö	076b1116d6	Fix calculating buffer positions when appending with SNPRINTF/WelsSnprintf This fixes two separate issues. First, with the MSVC _snprintf implementations, the return value is negative if the buffer wasn't large enough - this would in the worst case lead to making iBufferUsed negative, writing before the start of the buffer. Secondly, when both iBufferUsed and iBufferLeft are accumulated, one can't do "iBufferLeft -= iBufferUsed;". As an example, say the buffer is 100 bytes in total and iBufferLeft is 40 and iBufferUsed is 60. If SNPRINTF then writes 5 more bytes to the buffer, iBufferUsed would be 65, but if we now do "iBufferLeft -= iBufferUsed;" then iBufferLeft would end up as -25 even though there's 35 bytes left in the buffer to use. Therefore, we use a separate variable to store the return value from the latest SNPRINTF call. This is checked to make sure it wasn't negative, and only this amount is added to iBufferUsed and subtracted from iBufferLeft. This is the same pattern used in codec/encoder/core/src/utils.cpp. strftime never returns negative numbers, so those calls don't need as much checking.	2014-01-27 08:03:56 +02:00
Martin Storsjö	a344d100ae	Fix buffer size checks when appending using SNPRINTF/WelsSnprintf Checking iBufferLeft > iBufferUsed does not make sense, since this would stop writing into the buffer alredy after the buffer is half full, when there is less space left than has been used. The right check is iBufferLeft > 0.	2014-01-27 08:03:56 +02:00
Martin Storsjö	98bad4f2b3	Don't manually null terminate after calling SNPRINTF The following pattern is unsafe on all platforms: n = SNPRINTF(buf, ...); buf[n] = '\0'; On windows, the _snprintf variants return a negative number if the buffer was too small, thus buf[n] would be outside of (before the start of) the buffer. On other platforms, the C99 snprintf function returns the total number of characters which would have been written if the buffer had been large enough, which can be larger than the buffer size itself, and thus buf[n] would be beyond the end of the buffer. The C99 snprintf function always null terminate the buffer. These invocations of SNPRINTF are within !WIN32, so we can be sure that the SNPRINTF call itself already null terminated the buffer.	2014-01-27 08:03:56 +02:00
Martin Storsjö	2f5f25b7e3	Merge the encoder/decoder crt_util_safe_x.h into the common lib	2014-01-27 08:03:03 +02:00
Ethan Hugg	55336dee64	Merge pull request #221 from mstorsjo/freebsd Update building on FreeBSD	2014-01-26 20:41:11 -08:00
Ethan Hugg	b401098a67	Merge pull request #216 from varunbpatil/processing_cleanup Removed unused header files in processing src	2014-01-26 20:35:32 -08:00
Ethan Hugg	627c1558ae	Merge pull request #215 from varunbpatil/dec_core_cleanup Removed unused headers in decoder core	2014-01-26 20:09:19 -08:00
Ethan Hugg	36054ac2a2	Merge pull request #212 from varunbpatil/enc_core_cleanup Removed unused header files in encoder core	2014-01-26 19:24:35 -08:00
kali2	fa91f77b1b	Merge pull request #214 from licaiguo/fix-rpl fix reference picture modification bug -- review #67	2014-01-26 19:24:25 -08:00
volvet	488cc4ec8e	Merge pull request #228 from mstorsjo/remove-hardcoded-path Remove a hardcoded debug path specific to somebody's environment	2014-01-26 18:17:31 -08:00
volvet	5ac52e31e9	Merge pull request #224 from mstorsjo/msvc2005 Fix building on MSVC 2005	2014-01-26 17:51:44 -08:00
Martin Storsjö	7394254fb5	Remove the legacy makefile based build system The new one is much more flexible. The old one is unmaintained.	2014-01-26 16:28:58 +02:00
Martin Storsjö	2963f4ab6e	Remove a hardcoded debug path specific to somebody's environment Instead of using platform specific paths, just use the local directory instead, reducing the amounts of ifdefs.	2014-01-26 15:22:41 +02:00

... 9 10 11 12 13 ...

1286 Commits