generic-library/openh264
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Simplify the implementation of GetValueOf4Bytes

Browse Source 
What the two different implementations currently do is simply
to write a 32 bit number, in the native endianness, into the
given buffer.

The actual purpose of this function is still unknown though,
it can be removed completely without breaking decoding - it
is possibly a remnant from earlier functionality in the
decoder.
This commit is contained in:
Martin Storsjö 2014-01-29 22:10:15 +02:00
parent e413ed20a2
commit 1d2c37f7de
1 changed files with 2 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
codec/decoder/core/src/decoder.cpp
View File

@ -51,6 +51,7 @@
#include "expand_pic.h"
#include "decode_slice.h"
#include "mem_align.h"
#include "ls_defines.h"
namespace WelsDec {
@ -58,21 +59,9 @@ extern PPicture AllocPicture (PWelsDecoderContext pCtx, const int32_t kiPicWidth
extern void_t FreePicture (PPicture pPic);
#ifdef WORDS_BIGENDIAN
inline void_t GetValueOf4Bytes (uint8_t* pDstNal, int32_t iDdstIdx) {
pDstNal[0] = (iDdstIdx & 0xff000000) >> 24;
pDstNal[1] = (iDdstIdx & 0xff0000) >> 16;
pDstNal[2] = (iDdstIdx & 0xff00) >> 8;
pDstNal[3] = (iDdstIdx & 0xff);
ST32(pDstNal, iDdstIdx);
}
#else //WORDS_BIGENDIAN
inline void_t GetValueOf4Bytes (uint8_t* pDstNal, int32_t iDdstIdx) {
pDstNal[0] = (iDdstIdx & 0xff);
pDstNal[1] = (iDdstIdx & 0xff00) >> 8;
pDstNal[2] = (iDdstIdx & 0xff0000) >> 16;
pDstNal[3] = (iDdstIdx & 0xff000000) >> 24;
}
#endif //WORDS_BIGENDIAN
static int32_t CreatePicBuff (PWelsDecoderContext pCtx, PPicBuff* ppPicBuf, const int32_t kiSize,
const int32_t kiPicWidth, const int32_t kiPicHeight) {