generic-library/openh264
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Make sure the buffer always is null terminated in the *snprintf calls for old MSVC

Browse Source 
These functions leave the buffer unterminated in case it was too
small.
This commit is contained in:
Martin Storsjö 2014-01-26 14:50:30 +02:00
parent 4a8f54d767
commit 7884e77b2d
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
codec/common/crt_util_safe_x.cpp
View File

@ -125,6 +125,8 @@ int32_t WelsSnprintf (str_t* pBuffer, int32_t iSizeOfBuffer, const str_t* kpFor
va_start (pArgPtr, kpFormat);
iRc = vsnprintf (pBuffer, iSizeOfBuffer, kpFormat, pArgPtr); //confirmed_safe_unsafe_usage
if (iRc < 0)
pBuffer[iSizeOfBuffer - 1] = '\0';
va_end (pArgPtr);
@ -142,7 +144,10 @@ int32_t WelsStrnlen (const str_t* kpStr, int32_t iMaxlen) {
}
int32_t WelsVsnprintf (str_t* pBuffer, int32_t iSizeOfBuffer, const str_t* kpFormat, va_list pArgPtr) {
return vsnprintf (pBuffer, iSizeOfBuffer, kpFormat, pArgPtr); //confirmed_safe_unsafe_usage
int32_t iRc = vsnprintf (pBuffer, iSizeOfBuffer, kpFormat, pArgPtr); //confirmed_safe_unsafe_usage
if (iRc < 0)
pBuffer[iSizeOfBuffer - 1] = '\0';
return iRc;
}