generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
5,074 Commits 1 Branch 0 Tags 108 MiB
ffe2620c97
Commit Graph

331 Commits

Author SHA1 Message Date
kjellander@webrtc.org
8b7ec82cf4 Exclude P2PTransportChannelSameNatTest.TestConesBehindSameCone for TSan Linux 
I cannot reproduce locally but I can see 10+ consecutive
failing runs at the TSan RV bot at
http://build.chromium.org/p/client.webrtc.fyi/waterfall

TEST=verified the new exclude file is picked up by running:
tools/valgrind-webrtc/webrtc_tests.sh --tool=tsan_rv -b out/Release -t libjingle_p2p_unittest --gtest_filter=P2PTransportChannel*Test.*
(which runs the test if this file does not exist)
BUG=2396
TBR=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2320004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4869 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-27 20:03:03 +00:00
wu@webrtc.org
6049787252 Add protection to few more methods of AudioDeviceLinuxALSA. Those methods can be called from 
a different thread.

One example is the _playWarning can be changed in AudioDeviceLinuxALSA::Init, which is called on the application's thread. At the same time it can be read via PlayoutWarning() on the VoE's process_thread.

RISK=P2
TESTED=try bots and tsan test:
tools/valgrind-webrtc/webrtc_tests.sh --tool=tsan -t out/Debug/libjingle_peerconnection_unittest --gtest_filter=PeerConnectionFactoryTestInternal.CreatePCUsingInternalModules
BUG=1205
R=xians@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2315004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4866 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-27 18:19:25 +00:00
andrew@webrtc.org
c2ac5ed588 Add more TSAN suppressions for libjingle_media_unittest. 
BUG=2078
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2282004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4830 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-24 18:45:19 +00:00
kjellander@webrtc.org
6e86349273 Disable tests that crash the OS X kernel when run under memcheck. 
These libjingle tests crashes the OS X kernel when run under
memcheck on Mac 10.6. I didn't file bugs for them since it's unlikely
we can fix this anyway. There are several other tests disabled
in the libjingle code with similar comments, without bugs
assigned to them.
See talk/base/physicalsocketserver_unittest.cc for examples.

Affected waterfall: http://build.chromium.org/p/client.webrtc.fyi/waterfall

TEST=none
BUG=none
R=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2278006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4825 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-24 12:34:51 +00:00
jiayl@webrtc.org
dd57cd6ed5 Removing the tsan text exclusion since the tests should be passing now. 
BUG=2299, 2290, 2291
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2260004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4799 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-20 00:51:53 +00:00
kjellander@webrtc.org
7a968a8f07 Add more TSan and Dr Memory suppressions for modules_unittests 
I'm trying to get these tests green on Windows in
http://build.chromium.org/p/client.webrtc.fyi

BUG=2319,2323
TEST=local runs passing
R=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2230004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4781 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-18 19:18:20 +00:00
stefan@webrtc.org
5f1051631a Fix disabling of tests. 
BUG=2378
R=pbos@webrtc.org
TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2244005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4778 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-18 15:28:10 +00:00
stefan@webrtc.org
da79008ab4 Disabling crashing or flaky tests in peerconnection_unittest. 
R=kjellander@webrtc.org
TBR=wu@webrtc.org
TESTS=trybots
BUG=2378

Review URL: https://webrtc-codereview.appspot.com/2227004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4767 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-17 13:11:38 +00:00
pbos@webrtc.org
be63fd644f Initialize CodecInst structs in test_api_audio.cc. 
Fixes errors detected by DrMemory on Windows.

BUG=2382
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2228004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4764 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-17 09:33:17 +00:00
kjellander@webrtc.org
f6ae62ffa3 Add Win TSan exclude and Dr Memory suppressions 
To green up the FYI builders.

BUG=2323,2382
TEST=passing local run.
TBR=phoglund

Review URL: https://webrtc-codereview.appspot.com/2218005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4755 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-16 21:16:48 +00:00
kjellander@webrtc.org
eddbfb8cf8 Add more Dr Memory suppressions for common_audio_unittests 
BUG=2321
TEST=passing local run.
TBR=andrew

Review URL: https://webrtc-codereview.appspot.com/2220004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4754 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-16 20:53:20 +00:00
stefan@webrtc.org
ab800f64bc Disable flaky libjingle tests under tsan and memcheck. 
BUG=2380, 2379
TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2218004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4752 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-16 15:22:32 +00:00
phoglund@webrtc.org
62b816afcf Fixed pylint warnings. 
Passing variables into the page template with vars() is how it's regularly done AFAIK, so I'll just disable the warnings.

BUG=2371
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2206005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4749 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-16 11:26:12 +00:00
pbos@webrtc.org
e07049f19f Lock RTPSender statistics. 
Suppressing these errors in TSan has become tedious. It's better to just
lock them.

BUG=2349
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2197004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4713 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-10 11:29:17 +00:00
pbos@webrtc.org
26b0d77baf Suppress RTPSender race regardless of codec. 
New test uses SendGeneric instead of SendVP8.

BUG=2349
TBR=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2194004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4705 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-09 15:34:36 +00:00
pbos@webrtc.org
0181b5f8dd ExternalVideoDecoder for new VideoEngine API. 
Implements the ExternalVideoDecoder interface for VideoReceiveStream.
Also adds a FakeDecoder used in tests, removing the overhead of running
the EngineTest tests with VP8 under Memcheck/TSan, allowing us to enable
them under Memcheck/TSan as well.

BUG=2346,2312
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2172004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4702 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-09 08:26:30 +00:00
andrew@webrtc.org
9080518a39 Restore severity precondition to logging.h. 
I mistakenly ommitted the checks when logging.h was ported from
libjingle to webrtc. This caused a significant CPU cost for logs which
were later filtered out anyway.

Verified with LS_VERBOSE logging in neteq4, running:
$ out/Release/modules_unittests \
--gtest_filter=NetEqDecodingTest.TestBitExactness \
--gtest_repeat=50 > time.txt
$ grep "case ran" time.txt | grep "[0-9]* ms" -o | sort

Results on a MacBook Retina, averaged over 5 runs:
Verbose logs disabled:                          666 ms
Exisiting implementation, verbose logs enabled: 944 ms (1.42x)
New implementation, verbose logs enabled:       673 ms (1.01x)

BUG=2314
R=henrik.lundin@webrtc.org, henrike@webrtc.org, kjellander@webrtc.org, turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2160005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4682 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-05 16:40:43 +00:00
mflodman@webrtc.org
e2d4da6586 Enable EngineTest.ReceivesPliAndRecoversWithNack and fix memcheck suppression filter. 
BUG=2346
R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2169004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4677 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-04 14:21:57 +00:00
mflodman@webrtc.org
be23b32727 Adding tsan suppression for BUG 2349. 
TSAN found a read/write race for RTPSender::[packets_sent_/payload_bytes_sent)] between RTPSender::SendToNetwork and RTCPSender::SendRTCP.

BUG=2349
R=holmer@google.com

Review URL: https://webrtc-codereview.appspot.com/2168004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4676 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-04 13:36:52 +00:00
mikhal@webrtc.org
3abb82d8df Suppress video engine test 
BUG=2346
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2161005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4670 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-03 22:19:31 +00:00
kjellander@webrtc.org
c8c32638be Remove JpegEncoder suppression as jpeg is now removed. 
See https://code.google.com/p/webrtc/source/detail?r=4646

BUG=2322
TEST=Ran common_video_unittests with the suppression removed
TBR=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2164004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4664 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-03 18:38:52 +00:00
mflodman@webrtc.org
f5f5da0df1 Adding TSAN suppression for test posix udp transport. 
This is race for reading a bool in the WebRTC test UDP transport and
not in any production code.

R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2159006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4663 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-03 14:15:21 +00:00
kjellander@webrtc.org
3a6ff41e8f Document the source of test scenarios for Dummynet wrapper script. 
I just wanted to put this in here since I got the question
from an external user.

TEST=none
BUG=none
TBR=phoglund

Review URL: https://webrtc-codereview.appspot.com/2162004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4662 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-03 13:01:31 +00:00
kjellander@webrtc.org
5aedb295d5 Add TSan and Dr Memory suppressions for Windows 
This works enables us to add add more memory tools bots to the
WebRTC FYI waterfall at
http://build.chromium.org/p/client.webrtc.fyi/waterfall
These suppressions will be needed to get the bots green initially.

This CL also updates the PRESUBMIT.py scripts for the previous
memcheck and TSan suppression directories with the trybots we
currently have. It also adds a PRESUBMIT.py script for the
Dr Memory suppressions.

BUG=1938,2319,2321,2322,2323,2324,2328,2329,2330,2333
TEST=Local execution of the tests passes when these suppressions
are used.

R=niklas.enbom@webrtc.org, phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2149004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4653 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-02 11:50:46 +00:00
kjellander@webrtc.org
f8c16b8bf4 Disabling CondVarTest for TSan v2 (take 2) 
This test goes into an eternal loop sometimes when run under
TSan v2, therefore I'm disabling it until this is resolved.
Doing that, the TSan v2 bot in our new WebRTC FYI waterfall at
http://build.chromium.org/p/client.webrtc.fyi/waterfall
will hopefully go green.

The define used only exists for TSan v2, so v1 should be
unaffected.

The suppression added in http://review.webrtc.org/2126005/
turns out actually has no effect, so I'm removing it again.
It's probably useless since TSan v2 obviously alters the code's
behavior, causing these errors. Since the errors are not TSan v2
failures, the suppression has no effect.

BUG=2259
TEST=test passing locally when run as described in 2259 (since
no tests are run).

R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2115005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4639 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-29 09:47:18 +00:00
kjellander@webrtc.org
8ae641edfb Add suppressions file for Leak Sanitizer. 
Add a suppressions file that must exist in order for the Leak Sanitizer
(LSan) bot to be able to run with the default configuration.
This bot is located in the new WebRTC FYI waterfall at:
http://build.chromium.org/p/client.webrtc.fyi/waterfall

More info about LSan on http://www.chromium.org/developers/testing/leaksanitizer

BUG=none
TEST=Running a local master+slave passes fine with this file added locally.
R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2135004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4636 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-28 20:29:35 +00:00
kjellander@webrtc.org
5f8d05add2 Disabling CondVarTest for TSan v2. 
This test goes into an eternal loop sometimes when run under
TSan v2, therefore I'm disabling it until this is resolved.
Doing that, our new WebRTC FYI waterfall with a TSan v2 bot will hopefully go green when deployed (see https://codereview.chromium.org/23231004)

The define used only exists for TSan v2, so v1 should be
unaffected.

BUG=2259
TEST=test passing locally when run as described in 2259 (since
no tests are run).

R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2126005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4635 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-28 19:54:33 +00:00
pbos@webrtc.org
2b325e8394 TSan suppression for RampUpTest/* and EngineTest/*Nack*. 
BUG=2312
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2132004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4633 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-28 10:29:10 +00:00
phoglund@webrtc.org
02421fcf0b Corrected documentation on webrtc_test.sh. 
R=kjellander@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/2122004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4628 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-27 14:00:10 +00:00
tina.legrand@webrtc.org
89502c1ca8 Memory and tsan tests: Turning off renamned tests 
In r4625 AudioCodingModuleTest.RunAllTests was broken down to a number of
smaller tests. This CL turns off these tests, as RunAllTests was turned off
before.

TBR=kjellander@webrtc.org

BUG=issue2173

Review URL: https://webrtc-codereview.appspot.com/2121004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4626 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-27 09:38:10 +00:00
phoglund@webrtc.org
c9fa0fede5 Removed build status tracking, refreshed front page. 
BUG=
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2106004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4613 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-26 08:45:22 +00:00
henrike@webrtc.org
442709ea96 Disable broken test and add suppressions. 
BUG=2299,1205

TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2101004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4606 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-23 21:42:01 +00:00
henrike@webrtc.org
69a774fc42 Suppresses another tsan warning. Warning is reported here: http://chromegw/i/client.webrtc/builders/Linux%20Tsan/builds/460/steps/memory%20test%3A%20libjingle_peerconnection_unittest/logs/D5CAED6268DAACB7 
TBR=wu@webrtc.org

BUG=N/A

Review URL: https://webrtc-codereview.appspot.com/2096004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4603 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-23 14:38:15 +00:00
henrike@webrtc.org
61b262c427 Disable tests according to issues: 1205,2272,2288,2290,2291 
BUG=1205,2272,2288,2290,2291
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2069005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4596 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-22 20:27:49 +00:00
phoglund@webrtc.org
17018ed39c Added perf summary pages to the dashboard server. 
The purpose is to make the WebRTC performance metrics easier to overview.

BUG=
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2081004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4583 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-21 16:31:12 +00:00
wu@webrtc.org
ebe68aad44 Fix memory leak in portallocatorsessionproxy_unittest. 
Remove the suppressions that have been fixed.

BUG=1972,2263
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2062005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4576 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-20 21:14:39 +00:00
phoglund@webrtc.org
32fe90b3f9 Made all integration tests use consistent naming. 
After decision by pbos@, mflodman@ et. al.

BUG=
R=kjellander@webrtc.org, mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2041004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4565 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-19 11:40:19 +00:00
kjellander@webrtc.org
f3bf5e02c8 Add suppressions file for TSan v2 
This is needed for our tests to pass when run under TSan v2.
More details on TSan v2 can be found at
http://www.chromium.org/developers/testing/threadsanitizer-tsan-v2

BUG=chromium:274414
TEST=ran tests locally standing in trunk/ using:
GYP_DEFINES=tsan=1 linux_use_tcmalloc=0 release_extra_cflags="-gline-tables-only" gclient runhooks
ninja -C out/Release
TSAN_OPTIONS=suppressions=tools/valgrind-webrtc/tsan_v2/suppressions.txt print_suppressions=1 report_signal_unsafe=0 report_thread_leaks=0 history_size=7 out/Release/testname
R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2057004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4564 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-19 05:33:20 +00:00
wu@webrtc.org
166991fa1f Suppress tsan errors on libjingle_peerconnection_unittest. 
TBR=mallinath
BUG=1205

Review URL: https://webrtc-codereview.appspot.com/2055004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4560 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-16 17:57:44 +00:00
wu@webrtc.org
a2e0901e54 Suppress tsan errors. 
BUG=1205,2079
TBR=mallinath

Review URL: https://webrtc-codereview.appspot.com/2054004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4558 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-16 17:00:01 +00:00
fischman@webrtc.org
dde7d4c6ed Roll chromium_revision 214260:217707 and gflags 45:84 
gflags roll is needed mostly to pick up fixes for warnings triggered by newer
compiler/settings pulled in by the chromium roll.  Had to switch from the old
google-gflags project the current gflags project to pick up this fix (see
https://code.google.com/p/gflags/source/detail?r=74 for details).

Update android build.xml file to reflect tools moves in new SDK pulled in by the chromium_revision roll.

R=niklas.enbom@webrtc.org, wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2043004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4555 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-15 23:31:30 +00:00
wu@webrtc.org
97d1a988b6 Remove suppressions for the cases that's already fixed. 
Rename some of the suppressions to new issue.
Fix leaks in virtualsocket_unittest.

BUG=1972,1976,2100
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2010005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4536 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-13 00:13:26 +00:00
wu@webrtc.org
94349552de Disable P2PTransportChannelTest.* on memcheck and tsan bots due to issue 1972. 
TBR=mallinath
BUG=1972
RISK=P3
TEST=with below cmd lines and disabled tests won't run
tools/valgrind-webrtc/webrtc_tests.sh --build_dir out/Debug --test libjingle_p2p_unittest --gtest_filter=P2PTransportChannelTest* --tool tsan
tools/valgrind-webrtc/webrtc_tests.sh --build_dir out/Debug --test libjingle_p2p_unittest --gtest_filter=P2PTransportChannelTest* --tool memcheck

Review URL: https://webrtc-codereview.appspot.com/1954004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4479 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-02 23:30:50 +00:00
wu@webrtc.org
4ebd8efc09 Supress libjingle_unittest fails on TSan. 
BUG=2080
TBR=mallinath

Review URL: https://webrtc-codereview.appspot.com/1943005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4471 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-02 00:14:41 +00:00
wu@webrtc.org
0dc0f172a3 sscanf isn't safe with strings that aren't null-terminated. In such case, create a local copy that is null-terminated first. 
TESTED=GYP_DEFINES=build_for_tool=memcheck gclient runhooks
ninja -C out/Debug/ libjingle_unittest
tools/valgrind-webrtc/webrtc_tests.sh --tool memcheck --test out/Debug/libjingle_unittest  --gtest_filter=Http*

R=noahric@google.com

Review URL: https://webrtc-codereview.appspot.com/1941004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4469 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-01 21:20:46 +00:00
wu@webrtc.org
6abb750993 Delete gtest_exclude for asan which doesn't have effect with how the bots are setup now 
Add gtest_exclude for tsan to disable some flakey tests.
Change tsan suppression since the function name has been changed from DecodeWithErrors to DecodeErrorMode.

TBR=mallinath

Review URL: https://webrtc-codereview.appspot.com/1930004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4465 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-01 18:00:02 +00:00
wu@webrtc.org
27c0408a16 Suppressing tsan errors on libjingle_unittest and libjingle_peerconnection_unittest. 
BUG=1205,2080
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1924004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4458 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-07-31 22:41:15 +00:00
henrike@webrtc.org
a543114004 Removes no longer needed valgrind-libjingle folder. Was workaround for some bots using wrong valgrind script. 
TBR=wu@webrtc.org

BUG=2146

Review URL: https://webrtc-codereview.appspot.com/1920004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4454 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-07-31 17:53:39 +00:00
wu@webrtc.org
d40b4d9685 Fix libjingle memory bots by suppressing some of the errors. 
BUG=1205,2153
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1923004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4453 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-07-31 17:32:36 +00:00
wu@webrtc.org
7446870a0f Suppress failing tests on Linux Memcheck bot. 
BUG=2153
TBR=mallinath

Review URL: https://webrtc-codereview.appspot.com/1914004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4439 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-07-30 23:36:42 +00:00
wu@webrtc.org
9c9fc767b1 Fixing the memory check bots by suppressing some of the tests. 
BUG=1205,2078,2080
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1913004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4438 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-07-30 22:54:08 +00:00
wu@webrtc.org
933946ac55 Suppress libjingle_peerconnection_unittest failures on linux memcheck build bot. 
BUG=2153
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1912004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4437 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-07-30 22:28:29 +00:00
wu@webrtc.org
0342e65f8d Disable peerconnection tests that are failing on memcheck. 
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1910006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4436 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-07-30 22:28:14 +00:00
wu@webrtc.org
ae7bf1525b Disable p2p tests that are failing on memory test. 
BUG=1972
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1911004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4435 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-07-30 21:40:39 +00:00
henrike@webrtc.org
a0b2f1794b Adds files still expected by the libjingle bots. 
BUG=2146
R=andrew@webrtc.org, wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1897004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4423 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-07-29 21:34:08 +00:00
phoglund@webrtc.org
5bb8e7e220 Adjusted net delay perf expectations slightly. 
This should fix the flakiness we see on the Windows vie_auto_test bot.

TBR=kjellander@webrtc.org
BUG=1871

Review URL: https://webrtc-codereview.appspot.com/1845004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4378 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-07-22 13:15:59 +00:00
henrike@webrtc.org
5e44b8fac1 Add libjingle's valgrind suppressions 
BUG=2104
R=kjellander@webrtc.org, wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1834004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4375 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-07-19 16:00:41 +00:00
henrike@webrtc.org
2a7fd5355d Moves tools/update.py to trunk/webrtc/tools and updates it so that it no longer pulls any information from the DEPS file. 
BUG=N/A
R=andrew@webrtc.org, kjellander@google.com, kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1730004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4277 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-06-27 18:36:28 +00:00
kjellander@webrtc.org
63e988856e Merge more tests into modules_{unit,integration}tests. 
A new test target named 'modules_integrationtests' is created
and the following test targets were merged into it:
* audio_coding_module_test
* test_fec
* video_coding_integrationtests
* vp8_integrationtests

A couple of other targets were merged into modules_unittests:
* audio_coding_unittests
* audioproc_unittest
* common_unittests
* video_coding_unittests
* video_processing_unittests
* vp8_unittests

I wasn't able to merge audio_decoder_unittests and neteq_unittests due to
conflicts with different defines in these tests.

Some tests that have special requirements aren't merged into
modules_integrationtests yet. I took the opportunity to rename them
since the bot configs will need to be update anyway:
* audio_device_test_api -> audio_device_integrationtests
* video_capture_module_test -> video_capture_integrationtests
* video_render_module_test -> video_render_integrationtests

Exclude files were added for modules_integrationtests to make sure
the memcheck and tsan bots doesn't tests that are too slow
(audio_coding_module_test and vp8_integrationtests were previously
disabled on those bots).

Suppressions for AudioCodingModuleTest needed to be added to get
modules_integrationtests to pass memcheck (even if the test is
excluded from execution).

BUG=1843
TEST=local execution on Linux and trybots (passing except the merged tests of course)
R=andrew@webrtc.org, tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1656004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4228 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-06-14 20:09:44 +00:00
kjellander@webrtc.org
18275a8429 Update bots to make LKGR progress. 
This is just a temporary fix until we have fixed a working solution for
the new buildbot waterfalls in Chrome infrastructure.

TEST=none
BUG=none
R=phoglund
TBR=phoglund

Review URL: https://webrtc-codereview.appspot.com/1654005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4216 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-06-12 08:10:18 +00:00
kjellander@webrtc.org
6c35e0b0f7 Reorganize test targets in WebRTC 
This CL will lower the number of test targets in WebRTC by:

Add common_audio_unittests and merge the following targets into it (copied from http://review.webrtc.org/1584006):
* resampler_unittests
* signal_processing_unittests
* vad_unittests

Merge into modules_unittests:
* bitrate_controller_unittests
* desktop_capture_unittests
* media_file_unittests
* remote_bitrate_estimator_unittests
* rtp_rtcp_unittests
* paced_sender_unittests

Merge into test_support_unittests:
* channel_transport_unittests

channel_transport.gyp was also removed in favor for test.gyp.

I had to remove a main method from rtcp_format_remb_unittest.cc
since it caused the fileutils.h code to not be able to find the
right project root path in ordrer to provide correct paths
to test files.

Buildbot configuration update will be synced with the commit of this CL.

TEST=trybots
BUG=1843
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1639004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4213 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-06-11 08:29:17 +00:00
kjellander@webrtc.org
6d6d95e2b8 Add support for test disable files in webrtc_tests.py 
Adding support for text files in
tools/valgrind-webrtc/gtest_exclude that are used by the
wrapper script for memory tool execution (webrtc_tests.py).

This allows fine-grained disabling of tests using checked in
text files instead of maintaining such in the buildbot config.

For more details on naming of these text files and what to put
in them, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/memory-sheriff#TOC-Excluding-tests

TEST=local execution of tsan and memcheck on Linux, using an
exclude file (done during development of http://review.webrtc.org/1647005)
BUG=none
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1648004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4212 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-06-11 06:03:32 +00:00
andrew@webrtc.org
f791b1cebf Rename voice_engine_core -> voice_engine and move targets to voice_engine.gyp. 
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1574004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4126 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-05-29 00:38:02 +00:00
phoglund@webrtc.org
736c6f775e Fixed more perf expectations. 
For Linux, the expectations just look a bit too tightly wound. On Windows there's a long-term increasing trend that we may want to have someone look at.

http://www.corp.google.com/~webrtc-cb/perf//linux-large-tests/vie_auto_test/report.html?history=1500&rev=-1&graph=total_delay_incl_network
http://www.corp.google.com/~webrtc-cb/perf//linux-large-tests/vie_auto_test/report.html?history=1500&rev=-1&graph=total_delay_incl_network

BUG=
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1472005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4025 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-05-14 11:26:14 +00:00
phoglund@webrtc.org
80c7e3b606 Adjusted perf expectations for mac large tests. 
BUG=
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1472004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4024 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-05-14 10:51:13 +00:00
phoglund@webrtc.org
6d07ad9ccc Added protoc_wrapper to blacklist, fixed tools/PRESUBMIT.py which was passing in the wrong args to CheckLongLines. 
BUG=
R=kjellander@webrtc.org, tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1470005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4021 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-05-14 09:42:39 +00:00
mikhal@webrtc.org
571b3369e7 Updating perf 
R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1428011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3997 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-05-09 20:03:47 +00:00
mikhal@webrtc.org
06806701f0 Updating perf 
R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1447004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3995 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-05-09 17:42:58 +00:00
phoglund@webrtc.org
aeb7d8757d Tweaked webrtc_reformat. 
Fixed variable names such as maskByte and stuff within brackets.

Fixed bug where we would think that for instance foo_internal.h was the self include when the right answer was foo.h.

Removed comment conversion: it was doing more damage than good.

BUG=
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1442005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3983 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-05-08 13:56:23 +00:00
pwestin@webrtc.org
e30823911c Move the VoE tests to use external transport instead of the built in udp transport 
Review URL: https://webrtc-codereview.appspot.com/1223006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3708 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-03-22 16:12:57 +00:00
kjellander@webrtc.org
3cb42b11bf Remove GCC 4.6 bot from LKGR parsing. 
As all Linux bots are gPrecise now, this bot is removed.

TEST=none
BUG=none
TBR=phoglund

Review URL: https://webrtc-codereview.appspot.com/1218004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3679 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-03-18 16:05:36 +00:00
pwestin@webrtc.org
684f0577fb Revert r3667 and r3665 
Review URL: https://webrtc-codereview.appspot.com/1199004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3668 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-03-13 23:20:57 +00:00
pwestin@webrtc.org
361bac7a4f Removed the engine API:s related to transport such as SetSendDestination, the functionality is now provided via the test frame work. 
Review URL: https://webrtc-codereview.appspot.com/1029004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3665 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-03-13 17:52:42 +00:00
phoglund@webrtc.org
6ddb9071a1 Corrected dashboard script error. 
BUG=

Review URL: https://webrtc-codereview.appspot.com/1187004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3657 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-03-12 13:16:51 +00:00
jansson@webrtc.org
0ef22c24c0 Fixed style according to reviewer and a refactoring error 
I had to create this CL due to comitting before the final comments in the last CL
http://review.webrtc.org/1157005/ in revision:
https://code.google.com/p/webrtc/source/detail?r=3642

Changed e.msg to e.fail_msg in logging.error in emulate.py

Added space to error message for windows in check_permissions() in network_emulator

BUG=none
TEST=Windows and linux
Review URL: https://webrtc-codereview.appspot.com/1167006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3646 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-03-11 14:52:56 +00:00
kjellander@webrtc.org
db8ca9a395 Add Mac 64 bit bots to LKGR parser. 
BUG=1394
TEST=none

Review URL: https://webrtc-codereview.appspot.com/1174004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3645 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-03-11 09:00:37 +00:00
jansson@webrtc.org
5d3ced5df0 Fixed sync issues in network emulator script + fix lint complaints 
Somehow a merge conflict was committed when I submitted
http://review.webrtc.org/1158006/ which resulted in
https://code.google.com/p/webrtc/source/detail?r=3639

Changed _run_ipfw_command from a method to a function to satisfy lint in network_emulator.py, removed "self." on the function calls.

Renamed msg to fail_msg in the _run_ipfw_command and __init__ to make it more clear that it contains a failure message.
Review URL: https://webrtc-codereview.appspot.com/1157005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3642 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-03-08 13:43:36 +00:00
kjellander@webrtc.org
38ebf98c2a Refactor barcode decoder to use Zxing's C++ version 
By using the C++ version of Zxing, we can avoid having Java and Ant
as a dependency when running Video quality analysis on the bots.
This makes it far more easy to setup automation on new machines.

I also moved the scripts into the webrtc/ folder so it will be synced by default when building in Chrome (eliminating the need of a separate solution).

This CL also removes the need of the FFMPEG_HOME variable and replaces
its use with a command line flag to make the tool run smoothly on
Windows.

BUG=none
TEST=locally running the script on Windows, Mac and Linux.

Review URL: https://webrtc-codereview.appspot.com/1099007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3640 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-03-08 10:58:21 +00:00
jansson@webrtc.org
755e19adfc - Checks the OS and runs the appropriate commands for Dummynet (ipfw) 
- Added pipe rule flush handling
- Also fixed a bug preventing any rule settings other than default from being 
  used no matter what preset was chosen
- Fixed some comments.

BUGS=none
TEST= Windows and linux
Review URL: https://webrtc-codereview.appspot.com/1158006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3639 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-03-08 10:50:14 +00:00
phoglund@webrtc.org
5d37139374 Fixed a ton of Python lint errors, enabled python lint checking. 
BUG=

Review URL: https://webrtc-codereview.appspot.com/1166004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3627 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-03-07 09:59:43 +00:00
phoglund@webrtc.org
17238576ba Removed astyle from webrtc_reformat since clang-format-chrome.py handles that now. 
BUG=

Review URL: https://webrtc-codereview.appspot.com/1101009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3519 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-02-15 09:43:20 +00:00
kjellander@webrtc.org
e580be993c Add regression monitoring for audioproc and iSAC fixed-point tests. 
BUG=none
TEST=none

Review URL: https://webrtc-codereview.appspot.com/1094011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3513 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-02-14 12:27:17 +00:00
tina.legrand@webrtc.org
23e3559507 Updating Perf numbers for Win Large Test. 
Due to a bug in the RTP module, which appeared during packet loss, we have had too short delay in the Win Large Test. When the bug was fixed we had a regression error that should be fixed with this update.

Review URL: https://webrtc-codereview.appspot.com/1091005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3466 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-02-04 13:25:11 +00:00
phoglund@webrtc.org
d087789b9c Adjusted net_50_5_plr_5 on Linux, removed all gilbert_elliot metrics (too flaky), added mac expectations. 
BUG=

Review URL: https://webrtc-codereview.appspot.com/1075006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3453 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-02-01 13:28:58 +00:00
phoglund@webrtc.org
96a08cef68 Fixed stale regression values and calibrated some vie_auto_test values. 
BUG=

Review URL: https://webrtc-codereview.appspot.com/1066010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3441 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-01-31 10:06:44 +00:00
phoglund@webrtc.org
8382ad557b Added perf expectations for stack tests. 
BUG=

Review URL: https://webrtc-codereview.appspot.com/1043006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3396 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-01-22 12:19:24 +00:00
phoglund@webrtc.org
4ad64458cb Fixed URL unquoting in bot names. Added iOS Device. Removed unnecessary filter code. 
BUG=

Review URL: https://webrtc-codereview.appspot.com/1046005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3387 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-01-18 13:44:21 +00:00
kjellander@webrtc.org
c39962aa8d Adding TRYSERVER_ROOT to codereview.settings 
This is needed for tryjobs to work with updated trybot configurations.

BUG=webrtc:1309
TEST=Submitted try jobs and verified the patch applies properly.

Review URL: https://webrtc-codereview.appspot.com/1045004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3386 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-01-18 08:27:48 +00:00
kjellander@webrtc.org
14d1898bf9 Removing arena_thread_freeres suppression 
It is no longer needed since we are now using a Chromium revision that
is newer than
http://src.chromium.org/viewvc/chrome?view=rev&revision=172313
In that revision, the arena_thread_freeres suppression was added to
ignore.txt.

BUG=300
TEST=tools/valgrind-webrtc/webrtc_tests.sh --tool=tsan -t
out/Release/system_wrappers_unittests
and trybot execution on linux_tsan

Review URL: https://webrtc-codereview.appspot.com/1019010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3375 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-01-16 10:49:31 +00:00
phoglund@webrtc.org
171ac59426 Corrected TSAN suppression. 
BUG=

Review URL: https://webrtc-codereview.appspot.com/1029007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3356 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-01-10 12:44:27 +00:00
kjellander@webrtc.org
dc6fa02422 Fixing error in argument parsing 
The change in r3354 caused the --tool argument to not be parsed if it's passed after the test executable. Then it's considered an argument to the test rather than a script flag.
This CL cleans the code a bit and makes it possible to pass all the supported argument in the different ways possible.

NOTICE: To pass arguments to the test executable, you must use the -- argument must be specified before the test arguments start, to signal that everything that comes after it are positional arguments only (which are passed on to the test during execution).

BUG=none
TEST=The following combinations have been tested:
tools/valgrind-webrtc/webrtc_tests.sh -b out/Debug -t test_support_unittests --tool asan
tools/valgrind-webrtc/webrtc_tests.sh -b out/Debug -t test_support_unittests --tool asan -- --foo --bar
tools/valgrind-webrtc/webrtc_tests.sh --tool asan -b out/Debug -t test_support_unittests
tools/valgrind-webrtc/webrtc_tests.sh --tool asan -b out/Debug -t test_support_unittests -- --foo --bar

Review URL: https://webrtc-codereview.appspot.com/1026005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3355 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-01-10 10:06:15 +00:00
kjellander@webrtc.org
8f13810cf2 Improved memory tool test wrapper script 
* Clarified that the test only supports specifying a single test (multiple didn't work before, so better not claim to support it).
* No longer needs test executable arguments to use ++ instead of --
* Only appends the build_dir path to the test executable if not already
  present.
* Simplified suppression path handling.
* Fixed crash when -v was used (import logging was missing)
* Style fixes.
* Thorougly tested with all the supported flags.

I noted that the --gtest_filter flag does not work as expected (it's
only for 'additional gtest_filter arguments', which seems to mean
additional arguments to the gtest filter text files that are used by
Chrome. I left it in here anyway. If --gtest_filter is given after the
test executable it will work, since those arguments are added straight
to the test executable
the test

BUG=none
TEST=I ran the following commands and verified that the suppressions and flags were handled correct:
tools/valgrind-webrtc/webrtc_tests.sh -v --gtest_repeat=2 --keep_logs --tool_flags=--trace-children=yes -t out/Debug/test_support_unittests --foo --bar

tools/valgrind-webrtc/webrtc_tests.sh -v --gtest_repeat=2 --keep_logs --tool_flags=--trace-children=yes -b out/Debug -t test_support_unittests --foo --bar

tools/valgrind-webrtc/webrtc_tests.sh -v --gtest_repeat=2 --keep_logs --tool_flags=--trace-children=yes -b out/Debug -t out/Debug/test_support_unittests --foo --bar

tools/valgrind-webrtc/webrtc_tests.sh -v --tool=tsan --gtest_repeat=2 --keep_logs --tool_flags=--trace-children=yes -t out/Debug/test_support_unittests --foo --bar

tools/valgrind-webrtc/webrtc_tests.sh -v --tool=tsan --gtest_repeat=2 --keep_logs --tool_flags=--trace-children=yes -b out/Debug -t test_support_unittests --foo --bar

tools/valgrind-webrtc/webrtc_tests.sh -v --tool=tsan --gtest_repeat=2 --keep_logs --tool_flags=--trace-children=yes -b out/Debug -t out/Debug/test_support_unittests --foo --bar

Review URL: https://webrtc-codereview.appspot.com/1029005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3354 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-01-10 08:13:52 +00:00
phoglund@webrtc.org
bc9a959bd7 Generalized suppression for Trace::Add 
BUG=1194
TEST=Local run

Review URL: https://webrtc-codereview.appspot.com/1023007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3340 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-01-07 13:01:46 +00:00
phoglund@webrtc.org
acc54b41da Added perf expectations and corrected existing tests to remove spaces from series names. 
The make_expectations.py script is copied from Chrome. It can look at a test's result history and automagically compute good regress/improve values.

This patch comes into play together with https://chromereviews.googleplex.com/6242014/.

NOTE TO SELF: save history on master when deploying!

Review URL: https://webrtc-codereview.appspot.com/1019005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3339 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-01-07 12:05:53 +00:00
kjellander@webrtc.org
91d893324f Dashboard LKGR parsing builder names 
Needs to update this script as builders names are changed.

BUG=none
TEST=none

Review URL: https://webrtc-codereview.appspot.com/1016004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3332 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-01-04 10:30:54 +00:00
phoglund@webrtc.org
943770b1ab Fixed various problems with the reformat script: 
* Improved sort checker so we sort includes more.
* Fixed vars in brackets and varsLikeTHIS.
* Added automatic x++ to ++x conversion in for loops.

TEST=Ran on various source files and verified manually.

Review URL: https://webrtc-codereview.appspot.com/1017004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3325 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-01-02 15:46:43 +00:00
kjellander@webrtc.org
a19d04e707 Coverity now uses Visual Studio 2010 project file 
TBR=phoglund
BUG=none
TEST=Local run on Win machine.

Review URL: https://webrtc-codereview.appspot.com/1003007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3323 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-12-22 16:48:48 +00:00
kjellander@webrtc.org
b13dfbffd7 Making barcode tools work on Windows + fixes. 
This makes it possible to compile on the bots without hardcoding paths
to Ant, Java and ffmpeg deep into the Python scripts (hardcoded paths exists only in the buildbot configuration).
For bots, the ANT_HOME, JAVA_HOME and FFMPEG_HOME environment variables must be set to the install locations for each of these dependencies, for Windows.

This CL also improves the return code handling to make failures easier to detect when things break.

TEST=running build_zxing.py without Ant or Java in the PATH, but with
ANT_HOME, JAVA_HOME and FFMPEG_HOME set. Running Chromium's src/chrome/test/functional/webrtc_video_quality.py.
BUG=none

Review URL: https://webrtc-codereview.appspot.com/1002005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3311 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-12-18 19:53:00 +00:00
kjellander@webrtc.org
0240e8e90f Wider TSAN suppression for issue 300 
On some machines, this test has still been failing, so I'm widening the
suppression to resolve this.

BUG=300
TEST=passing linux_tsan trybot.

Review URL: https://webrtc-codereview.appspot.com/992004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3280 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-12-13 13:02:29 +00:00
kjellander@webrtc.org
d2bcde2e4e Suppressing TSan warnings for system_wrappers_unittests 
This CL makes system_wrappers_unittests pass on Lucid (it passed on Precise
without them for me).

BUG=300
TEST=Try job on linux_tsan
TBR=henrike

Review URL: https://webrtc-codereview.appspot.com/976007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3263 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-12-11 21:39:18 +00:00