Commit Graph

4694 Commits

Author SHA1 Message Date
wu@webrtc.org
f6d6ed0c66 Update talk to 59039880.
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6569004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5339 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-03 22:08:47 +00:00
fbarchard@google.com
e667234ee2 libyuv r949 includes changes to allow any width, mainly relating to fixed point math overflows.
BUG=none
TEST=try bots
R=ronghuawu@google.com

Review URL: https://webrtc-codereview.appspot.com/6579004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5338 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-03 18:57:22 +00:00
bjornv@webrtc.org
a89d17d5b7 Delay Estimator: robust_validation should be stored over a reset
BUG=None
TESTED=modules_unittests, trybots
R=aluebs@webrtc.org, andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5959004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5337 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-02 07:07:04 +00:00
fbarchard@google.com
2240763ec2 libyuv r930 for RGB24ToUV_NEON improved color accuracy to avoid red tint, and use malloc with variable sized row buffers to avoid stack overflow and relax width restrictions. Previously was limited to 4k on x86 and 1080p on arm. In practice the new limitation is 32767 pixels wide.
BUG=none
TESTED=try bots
R=tpsiaki@google.com, wjia@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6439004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5336 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-28 07:00:18 +00:00
braveyao@webrtc.org
2fb72cfeec Add include guards to forward_error_correction_internal.h
R=henrika@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5789005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5335 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-24 05:06:12 +00:00
braveyao@webrtc.org
0062a6d099 Fix the include guard in transmit_mixer.h
R=henrika@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5879004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5334 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-24 03:58:51 +00:00
braveyao@webrtc.org
a7cfa6704a Fix the include guard in transmit_mixer.h
R=henrika@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5879004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5333 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-24 03:39:10 +00:00
fischman@webrtc.org
000dde99c8 Android build: make it quiet on success and not overly noisy on failure.
- OpenSLDemo and WebRTCDemo get the sauce that AppRTCDemo got in r5271
- libjingle_peerconnection_jar is now silent on success
- Fix a bug introduced by r5271 which caused ant logs to be emitted to a subdir of talk/examples instead of in the gyp output directory.

R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6199005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5332 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-20 22:49:35 +00:00
vikasmarwaha@webrtc.org
a63fc87139 Fix JS error in adapter.js for FF for the case when ?transport=xxx is missing in TURN url.
BUG=2737
R=juberti@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6279004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5331 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-20 22:10:17 +00:00
andresp@webrtc.org
f6acf98a46 Fix the android clang bot for compiling with thread annotations.
TBR=niklas.enbom@webrtc.org
R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6279005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5330 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-20 21:54:26 +00:00
kjellander@webrtc.org
cf2b3acc48 Update Android trybots in the default try job list.
This updates the default set of trybots that are used
when no bot names are specified when submitting a try job.

TBR=andrew@webrtc.org
TEST=Ran git try -t compile and verified it was sent to all bots.
BUG=none

Review URL: https://webrtc-codereview.appspot.com/6289004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5329 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-20 21:20:42 +00:00
andresp@webrtc.org
7fb75ecbd4 Add thread_annotations for clang targets.
TESTED: As expected clang bots catched a few issues which are fixed with this CL, other bots ignore the annotations and compile fine.

R=niklas.enbom@webrtc.org, phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6209004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5328 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-20 20:20:50 +00:00
mflodman@webrtc.org
6031001565 If the configured start bitrate is higher than the configures max
bitrate, cap the star rate accordingly.

BUG=2720
R=asapersson@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6239004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5327 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-20 15:07:12 +00:00
sprang@webrtc.org
8dbca8d665 Race condition in ViECapturer::RegisterObserver
Critical section ViECapturer.observer_cs_ should be taken when
registering an observer.

BUG=2734
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5999004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5326 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-20 11:36:03 +00:00
tnakamura@webrtc.org
a463d73b99 Update WebRTC to version 3.48
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6189004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5324 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-19 22:38:38 +00:00
sprang@webrtc.org
54ae4ffb9e Add callbacks for receive channel RTCP statistics.
This allows a listener to receive new statistics as it is generated - avoiding the need to poll. This also makes handling stats from multiple RTP streams more tractable.
The change is primarily targeted at the new video engine API.

TEST=Unit test in ReceiveStatisticsTest. Integration tests to follow as call tests when fully wired up.

BUG=2235
R=henrika@webrtc.org, pbos@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5089004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5323 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-19 13:26:02 +00:00
andresp@webrtc.org
e682aa5077 Refactoring MediaOptimization so it can easily be turned into a thread-safe class.
BUG=2732
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6149004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5322 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-19 10:59:48 +00:00
stefan@webrtc.org
faada6e604 Integrate fake_network_pipe into direct_transport.
TEST=trybots
R=mflodman@webrtc.org, pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5529004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5321 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-18 20:28:25 +00:00
fbarchard@google.com
8f99a18119 Port scale and compare functions to pepper_33 and mips.
BUG=none
TEST=validator passes with new toolchain.
R=andrew@webrtc.org, pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6059004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5320 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-18 19:51:37 +00:00
kjellander@webrtc.org
5fe2d65c43 Remove metrics_unittests
This target has been merged into video_engine_tests in r5284.

BUG=webrtc:1843
R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6129004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5319 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-18 13:27:37 +00:00
pbos@webrtc.org
8a54417968 Remove media_file from VideoEngine dependencies.
BUG=
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6139004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5318 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-18 10:00:29 +00:00
mflodman@webrtc.org
b429e516a9 cpplint cleaning new API and its implementation files.
R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6089005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5317 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-18 09:46:22 +00:00
mflodman@webrtc.org
bcd124cdba Reduced execution time for CallTest::ReceivesPliAndRecovers, by dropping only one packet and made it predictable by removing rand().
Follow up steps is to support NackConfig.rtp_hostory_ms and/or increase fake encoder bitrate.

R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6109005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5316 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-18 09:45:45 +00:00
mflodman@webrtc.org
1fa41be66a Speeding up CallTest.ReceivesAndRetransmitsNack and removed the random packet loss.
R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6119004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5315 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-18 09:44:53 +00:00
sergeyu@chromium.org
8ae72560dd Make MouseCursor mutable
MouseCursor objects were previous immutable which makes it harder to
implement deserializers when MouseCursor is sent over IPC in Chromium.

R=dcaiafa@chromium.org

Committed: https://code.google.com/p/webrtc/source/detail?r=5310

Review URL: https://webrtc-codereview.appspot.com/6059005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5314 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-18 02:18:01 +00:00
fischman@webrtc.org
f8be8df33a audio_processing_unittest: unbreak clang compilation.
BUG=2735
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6069004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5313 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-17 23:46:39 +00:00
fischman@webrtc.org
179908c81c JNI Audio: remove dead members.
BUG=2735
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6049004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5312 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-17 23:46:14 +00:00
sergeyu@chromium.org
e4c927208b Revert "Make MouseCursor mutable"
This reverts commit a6db8ab8bc4b569a26633b0ca3665297f1a5349b.

TBR=dcaiafa@chromium.org

Review URL: https://webrtc-codereview.appspot.com/6079004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5311 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-17 22:48:50 +00:00
sergeyu@chromium.org
8fd1d26536 Make MouseCursor mutable
MouseCursor objects were previous immutable which makes it harder to
implement deserializers when MouseCursor is sent over IPC in Chromium.

R=dcaiafa@chromium.org

Review URL: https://webrtc-codereview.appspot.com/6059005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5310 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-17 22:19:12 +00:00
fischman@webrtc.org
af320fd2f7 The designated initializer method declaration in the Objective-C headers for RTCICEServer does't match its implementation.
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6019004

Patch from Rafael Lopez Diez <rafalopezdiez@gmail.com>.

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5309 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-17 21:33:27 +00:00
fbarchard@google.com
50f7b2da5d roll libyuv to r915 for webview jpeg build fix and NaCL pepper_33 initial support.
BUG=none
TEST=try bots
R=andrew@webrtc.org, pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5889006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5308 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-17 18:18:17 +00:00
pbos@webrtc.org
052fa6243a Stop transport in test SuspendBelowMinBitrate.
Avoids race when packets are still left in the network while the Call is
being destroyed.

R=mflodman@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/6009004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5307 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-17 11:19:58 +00:00
mflodman@webrtc.org
e6b871bb29 Added method for getting default module state and protect agains a
read/write race for child_modules_.

BUG=2731
TEST=tsan
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5919005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5306 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-17 08:30:40 +00:00
fbarchard@google.com
9df6674b26 Scale down by 4x with box filter. Fix for 1 pixel wide bilinear filter. Fix for I420ToARGB overread on V plane that causes valgrind fail.
BUG=none
TESTED=gcl try libyuv_r911 --bot=linux_valgrind
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5459004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5305 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-17 08:25:31 +00:00
pbos@webrtc.org
eb7b7bce3d Modify video_render/ to allow a single old frame.
This stabilizes tests as a single frame reaches end-to-end, as well as
allowing slow or heavily-loaded systems to see any video updates even if
the frame takes more than 500ms in the pipeline.

R=mflodman@webrtc.org, stefan@webrtc.org
BUG=2724

Review URL: https://webrtc-codereview.appspot.com/5949004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5303 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-16 18:24:37 +00:00
fischman@webrtc.org
5b3c67ef25 objc/README: Remove outdated advice about target_os.
BUG=chromium:248168
TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5979005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5302 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-16 17:15:19 +00:00
pbos@webrtc.org
919f87fb36 Delete capturers after destroying streams in test.
Since the renderers in CallTest.SendsAndReceiveStreams also stopped the
capturers they must be deleted after the VideoReceiveStream is stopped
or an use-after-free may occur.

R=mflodman@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/5969004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5300 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-16 14:55:54 +00:00
asapersson@webrtc.org
e7b1e11283 Revert 5285 "Revert 5228 "Use the RTT from RtcpRttStats class if..."
> Revert 5228 "Use the RTT from RtcpRttStats class if provided whe..."
> 
> > Use the RTT from RtcpRttStats class if provided when sending/receiving NACK.
> > 
> > R=holmer@google.com
> > 
> > Review URL: https://webrtc-codereview.appspot.com/5049004
> 
> TBR=asapersson@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/5799004

TBR=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5989004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5299 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-16 14:40:36 +00:00
bjornv@webrtc.org
1e7d61270c Simplification of histogram normalization in delay estimator.
- Replaces a for loop with a single element update to save complexity. No regression in performance seen on set of recordings.
- Removes UpdatesMadeUponChange() and put code straight into ProcessBinarySpectrum().

BUG=None
TESTED=module_unittest, trybots, verified manually on set of recordings.
R=aluebs@webrtc.org, andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5929004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5298 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-16 13:37:28 +00:00
pbos@webrtc.org
5ab756703e Revert r5294 to re-roll r5293.
To fix races in test each stream now owns its own encoder/decoder.

R=mflodman@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/5919004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5297 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-16 12:24:44 +00:00
bjornv@webrtc.org
5c64508b03 Adds robust validation functionality to the delay estimator
Evaluated over a 51 recordings:
False positives went from 4.4% to 0.7%
Missed detections unchanged at 0.8%
No increase in complexity, but need to re-evaluate that.

TESTED=trybots, unittests, verified against Matlab implementation
BUG=None
R=aluebs@webrtc.org, andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5419004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5296 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-16 10:57:53 +00:00
sprang@webrtc.org
87ad57bc75 Incorrect iterator++ in ModuleRtpRtcpImpl::RegisterVideoBitrateObserver
The iterator is incremented both in loop header and loop body. Should
only be incremented in header.

BUG=2727
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5899004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5295 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-16 07:43:51 +00:00
turaj@webrtc.org
41e2615e02 Revert 5293 "Auto instantiate RBE depending on whether AST or TO..."
> Auto instantiate RBE depending on whether AST or TOF is available in incoming packet stream.
> 
> BUG=
> R=mflodman@webrtc.org, stefan@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/5409004

TBR=solenberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5889004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5294 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-15 18:42:32 +00:00
solenberg@webrtc.org
341e91441a Auto instantiate RBE depending on whether AST or TOF is available in incoming packet stream.
BUG=
R=mflodman@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5409004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5293 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-13 23:57:54 +00:00
turaj@webrtc.org
e1bc6c8d8b Disabled tests on Android. The issue 2723 is filed to investigate the reason for tests failing.
BUG=
R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5809005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5292 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-13 22:04:18 +00:00
stefan@webrtc.org
dd393e7b9d Measure pacer queue size based on when packets are inserted rather than captured.
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5659004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5291 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-13 22:03:27 +00:00
turaj@webrtc.org
167b6dfc73 Fix jitter buffer delay estimate.
BUG=b/12099925
R=niklas.enbom@webrtc.org, niklase@google.com, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5739004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5289 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-13 21:05:07 +00:00
wu@webrtc.org
24301a67c6 Update talk to 58174641 together with http://review.webrtc.org/4319005/.
R=turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5809004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5287 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-13 19:17:43 +00:00
mflodman@webrtc.org
92c2793154 Adding REMB to receive stream configuration, the send side will always
react to incoming REMB for now.

Adding a test to verify the receive side is generating RTCP REMB and
will follow up with a send side test as soon as the bitrate stats are
wired up for the new API.

TEST=See above.
R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5779004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5286 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-13 16:36:28 +00:00
asapersson@webrtc.org
86bb56a7f5 Revert 5228 "Use the RTT from RtcpRttStats class if provided whe..."
> Use the RTT from RtcpRttStats class if provided when sending/receiving NACK.
> 
> R=holmer@google.com
> 
> Review URL: https://webrtc-codereview.appspot.com/5049004

TBR=asapersson@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5799004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5285 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-13 16:16:45 +00:00