Commit Graph

3650 Commits

Author SHA1 Message Date
andrew@webrtc.org
6be1e934ad Properly error check calls to AudioProcessing.
Checks must be made with "!= 0", not "== -1". Additionally:
* Clean up the function calling into AudioProcessing.
* Remove the unused _noiseWarning.
* Make the other warnings bool.

BUG=chromium:178040

Review URL: https://webrtc-codereview.appspot.com/1147004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3590 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-01 18:47:28 +00:00
leozwang@webrtc.org
9ee5a4ccd8 Enable External MediaProcessing on Mobile
Bug=None
TEST=trybots
Review URL: https://webrtc-codereview.appspot.com/1133005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3589 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-01 17:19:35 +00:00
bemasc@google.com
603ae3ece2 Make RtpHeaderExtensionMap::Register and ::Deregister idempotent.
This CL changes the return code of these methods to indicate
success instead of failure when there is nothing to change.

This change appears to resolve an issue where enabling the
timestamp offset extension via SDP would result in a failure if
that extension had already been enabled.
Review URL: https://webrtc-codereview.appspot.com/1118008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3588 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-01 17:03:02 +00:00
andrew@webrtc.org
78693fe37c Return an error when greater than 16 kHz is used with AECM.
BUG=chromium:178040

Review URL: https://webrtc-codereview.appspot.com/1146005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3587 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-01 16:36:19 +00:00
mflodman@webrtc.org
6648093911 Destroy VCM and VPM instead of delete.
Review URL: https://webrtc-codereview.appspot.com/1149004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3586 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-01 14:51:23 +00:00
phoglund@webrtc.org
527fb4d607 Revert "Will now run pylint on all python files if there's at least one modified python file in the checkin."
This reverts commit 6bd8730dfad6e7c5a5cf9a089605fcb9f83a13e0.

TBR=ajm@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/1150004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3585 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-01 14:08:28 +00:00
kma@webrtc.org
a0936a6e45 Limit ARM instruction "strheq" to Apple's clang compiler only.
bug =
Review URL: https://webrtc-codereview.appspot.com/1111008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3583 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-01 00:20:10 +00:00
marpan@webrtc.org
7d052c3cb2 Turn off error concealment in videoprocessor_integration tests.
Review URL: https://webrtc-codereview.appspot.com/1123006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3581 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-28 16:44:28 +00:00
braveyao@webrtc.org
6b6eb44cca Add supporting to V4L2_PIX_FMT_JPEG since it works same as MJPEG.
ISSUE=529
TEST=unittest
Review URL: https://webrtc-codereview.appspot.com/1120006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3580 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-28 10:08:02 +00:00
stefan@webrtc.org
9e254133ad Rewrite the jitter buffer statistics test and put make it robust under valgrind.
BUG=1158

Review URL: https://webrtc-codereview.appspot.com/1116008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3579 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-28 08:45:23 +00:00
vikasmarwaha@webrtc.org
98fce15c6f Adding webrtc-sample demos under trunk/samples.
Review URL: https://webrtc-codereview.appspot.com/1126005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3578 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-27 23:22:10 +00:00
bjornv@webrtc.org
132c15de30 AEC Refactoring:
* Adds pointer to low level AecCore struct.
* Adds a simple unit test of this new call.

Tested with audioproc_unittest, trybots

TEST=none
BUG=none

Review URL: https://webrtc-codereview.appspot.com/1121006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3577 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-27 21:03:41 +00:00
stefan@webrtc.org
e1c4ed958d Fix to send a full NACK list at least roughly once every 1.5 x RTT.
BUG=1434

Review URL: https://webrtc-codereview.appspot.com/1111007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3576 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-27 16:23:06 +00:00
kma@webrtc.org
83561fb173 Fixed a bug in WebRtcNsx_PrepareSpectrumNeon() for NS in ARM Neon platform.
No written bug report.

Tested with Nexus-S. Issue disappeared with the change.
Review URL: https://webrtc-codereview.appspot.com/1126006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3575 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-27 01:16:44 +00:00
andrew@webrtc.org
91f325586d Refactor WebRtc_CreateBuffer to return the instance.
Review URL: https://webrtc-codereview.appspot.com/1140005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3574 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-27 00:35:06 +00:00
wu@webrtc.org
ff0cd88e3d PeerConnection client and server can now be built from libjingle trunk. So we no longer need this folder. The getting-started page has also been updated.
TEST=n/a

BUG=

Review URL: https://webrtc-codereview.appspot.com/1057005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3573 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-26 18:06:19 +00:00
andrew@webrtc.org
dd5482cd2f Use ninja with merge_libs.py on Windows and clean up.
BUG=b/8110634

Review URL: https://webrtc-codereview.appspot.com/1094006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3571 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-26 02:47:50 +00:00
andrew@webrtc.org
9fbd9ca849 Force a memcpy directly from the AEC ring buffer.
Review URL: https://webrtc-codereview.appspot.com/1140004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3570 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-25 23:31:56 +00:00
andrew@webrtc.org
ac1f877a5e Remove unneeded libvpx path from vp8 include_dirs.
This is already provided by libvpx.gyp.

BUG=webrtc:1428

Review URL: https://webrtc-codereview.appspot.com/1139004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3568 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-25 17:10:38 +00:00
andrew@webrtc.org
9ae1354e25 Refactor ring_buffer interface, add a feature and a test.
* Add a RingBuffer typedef.
* Add the ability to force a memcpy by passing a null ptr. In some cases,
  we know we want a memcpy. This allows us to skip a potential
  intermediate memcpy.
* Add a stress test.

Review URL: https://webrtc-codereview.appspot.com/1111004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3567 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-25 17:07:35 +00:00
phoglund@webrtc.org
8a0662306d New attempt at fixing hard-coded libvpx source.
TBR=ajm@webrtc.org
BUG=1428

Review URL: https://webrtc-codereview.appspot.com/1138004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3566 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-25 15:05:01 +00:00
phoglund@webrtc.org
9a6623b629 Revert "Fixing hard-coded libvpx source path."
This reverts commit 1c603646da11971f13d66a75da31ebbb6eff37d9.

TBR=phoglund@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/1137004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3565 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-25 14:27:14 +00:00
phoglund@webrtc.org
8571c90c7f Fixing hard-coded libvpx source path.
BUG=1428
TBR=ajm@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1127006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3564 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-25 14:09:12 +00:00
kma@webrtc.org
2f9bd247ad Ported assembly coding in APM from Android to iOS.
Bugs=none
Test=trybots, and offline file bit-exact tests.
Review URL: https://webrtc-codereview.appspot.com/1066009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3563 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-23 04:16:59 +00:00
mikhal@webrtc.org
0d8d010017 Handle multiple calls to set initial delay
BUG= 1419

Review URL: https://webrtc-codereview.appspot.com/1113005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3562 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-22 19:30:44 +00:00
wjia@webrtc.org
7bf7326d0b Remove WEBRTC_TRACE completely when tracing is disabled.
This will help to cut the code size since those logging messages are removed.
Contributed by Henrik Ellner.
Review URL: https://webrtc-codereview.appspot.com/1125004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3560 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-22 00:54:58 +00:00
vikasmarwaha@webrtc.org
10987a851d Minor bug fix in maxFPS parameter declaration.
TBR = perkj@webrtc.org,mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1123005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3559 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-21 22:03:39 +00:00
vikasmarwaha@webrtc.org
bf3a9b3cce Fix for WebRTC Issue 1384. Some cameras return 0 fps for all capabilities which causes divide-by-zero.
Review URL: https://webrtc-codereview.appspot.com/1101013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3558 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-21 20:25:54 +00:00
andrew@webrtc.org
5140e24037 MIPS optimizations for Signal Processing Library patch01
Review URL: https://webrtc-codereview.appspot.com/1028004
Patch from Ljubomir Papuga <lpapuga@mips.com>.

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3557 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-21 20:12:21 +00:00
bjornv@webrtc.org
60f83131e4 AEC refactoring: Moved typedefs to _internal.h
* This was actually part of r3553
* Tested with audioproc_unittest, trybots

TBR=andrew@webrtc.org
TEST=none
BUG=none

Review URL: https://webrtc-codereview.appspot.com/1118005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3556 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-21 16:12:24 +00:00
tina.legrand@webrtc.org
7a7a008031 Changing non-const reference arguments to pointers, ACM
Part of refactoring of ACM, and recent lint-warnings.
This CL changes non-const references in the ACM API to pointers.

BUG=issue1372

Committed: https://code.google.com/p/webrtc/source/detail?r=3543

Review URL: https://webrtc-codereview.appspot.com/1103012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3555 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-21 10:27:48 +00:00
fischman@webrtc.org
f61e02c81f Misc cleanups to webrtc/android code:
- Replace some deprecated calls/enums with their more modern equivalents.
- Clean up some usage of global data and/or hide it better
- Catch specific exceptions instead of Exception, and log the exception instead
  of just its message.
- Random log message cleanups
- Added a build_with_libjingle gyp variable to mimic build_with_chromium for
  when webrtc is built as part of a libjingle project but not part of chromium.

BUG=webrtc:1169
TEST=none

Review URL: https://webrtc-codereview.appspot.com/1105010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3554 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-20 23:13:46 +00:00
bjornv@webrtc.org
56a9ec30e9 Refactoring AEC: AecCore struct made private
* Added aec_core_internal.h for private variables.
* Moved aec_t struct to aec_core_internal.h
* Name change aec_t -> AecCore
* Moved additional declarations to aec_core_internal.h
* Tested with audioproc_unittest and trybots

TEST=none
BUG=none

Review URL: https://webrtc-codereview.appspot.com/1117004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3553 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-20 22:38:47 +00:00
bjornv@webrtc.org
71e91f3b64 Refactor AEC: PowerLevel
* Style changes
* Tested with audioproc_unittest and trybots

TEST=none
BUG=none

Review URL: https://webrtc-codereview.appspot.com/1116005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3551 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-20 19:24:50 +00:00
bjornv@webrtc.org
4d1cfae622 Added a pointer getter to the system_delay variable.
Tested with audioproc_unittest, trybots

TEST=None
BUG=None

Review URL: https://webrtc-codereview.appspot.com/1101015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3549 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-20 17:31:38 +00:00
bjornv@webrtc.org
47b274de44 Refactoring AEC: Added a SetConfigCore function
* Configuraion parameters now passed down the AEC Core struct.
* Tested with audioproc_unittest and on trybots.

TEST=none
BUG=none

Review URL: https://webrtc-codereview.appspot.com/1098014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3548 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-20 17:09:47 +00:00
bjornv@webrtc.org
716fd90ff2 Moved out buffer handling to ProcessFrame()
Tested with audioproc_unittest, trybots and verified bit exactness on recording data base.

TEST=none
BUG=none

Review URL: https://webrtc-codereview.appspot.com/1110006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3547 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-20 16:59:41 +00:00
bjornv@webrtc.org
ee7202f7a4 Removed unused get_config function. The configuration is already stored and handled in the audio processing module, so there is no need for this functionality.
Tested with audioproc_unittest and on trybots.

TEST=none
BUG=none

Review URL: https://webrtc-codereview.appspot.com/1103016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3546 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-20 16:36:59 +00:00
mflodman@webrtc.org
59b2d5fbce Stop and restart fix.
BUG=1398
TEST=Local stop and start test.

Review URL: https://webrtc-codereview.appspot.com/1115004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3545 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-20 16:00:27 +00:00
tina.legrand@webrtc.org
eb7ebf20ed Revert 3543
> Changing non-const reference arguments to pointers, ACM
> 
> Part of refactoring of ACM, and recent lint-warnings.
> This CL changes non-const references in the ACM API to pointers.
> 
> BUG=issue1372
> 
> Review URL: https://webrtc-codereview.appspot.com/1103012

TBR=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1116004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3544 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-20 15:57:31 +00:00
tina.legrand@webrtc.org
374aa49e1a Changing non-const reference arguments to pointers, ACM
Part of refactoring of ACM, and recent lint-warnings.
This CL changes non-const references in the ACM API to pointers.

BUG=issue1372

Review URL: https://webrtc-codereview.appspot.com/1103012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3543 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-20 15:22:23 +00:00
pbos@webrtc.org
0b6293aaaa Fixed typo in vie_autotest_loopback.cc.
Review URL: https://webrtc-codereview.appspot.com/1114004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3542 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-20 12:13:10 +00:00
andrew@webrtc.org
83663efba4 Replace gtest_prod.h include with our own FRIEND_TEST macro.
This small bit of duplication avoids depending on any part of GTest in
production code.

TBR=phoglund
BUG=1395

Review URL: https://webrtc-codereview.appspot.com/1098013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3541 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-19 23:43:57 +00:00
fischman@webrtc.org
aea96d36e3 Rename webrtc::StatsObserver to webrtc::CallStatsObserver
to avoid ODR violations with peerconnectioninterface.h in libjingle.

Conflict introduced in
https://webrtc-codereview.appspot.com/1060005/diff/14010/webrtc/modules/interface/module_common_types.h#newcode326

TEST=none
BUG=none

Review URL: https://webrtc-codereview.appspot.com/1105011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3540 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-19 22:09:36 +00:00
bjornv@webrtc.org
0a480cbe4d Added getter for far_time_buf in AEC. Only used in AEC debug dump.
TEST=audioproc_unittest, trybots
BUG=None

Review URL: https://webrtc-codereview.appspot.com/1110005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3539 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-19 21:41:27 +00:00
bjornv@webrtc.org
5fc829200c This refactoring CL moves the nlp_mode member value from aecpc_t to aec_t, since it it never used at that level. Further, I removed two suppression variables by depending on nlp_mode directly.
TEST=audioproc_unittest, trybots
BUG=None

Review URL: https://webrtc-codereview.appspot.com/1095007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3538 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-19 21:06:52 +00:00
bjornv@webrtc.org
cea70f4055 * Name change
* Removed WebRtcAec_ function name prepending on private function.

TEST=audioproc_unittest, trybots
BUG=None

Review URL: https://webrtc-codereview.appspot.com/1096012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3537 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-19 21:03:10 +00:00
marpan@webrtc.org
95b48c3551 Update to codec unit test:
enable frame dropper for rate control test.
Review URL: https://webrtc-codereview.appspot.com/1099014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3536 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-19 20:02:32 +00:00
mikhal@webrtc.org
77fced32e2 fixing nack list size calculation
Review URL: https://webrtc-codereview.appspot.com/1093012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3535 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-19 19:42:35 +00:00
elham@webrtc.org
10741b32b8 Updated version number to 3.24
Review URL: https://webrtc-codereview.appspot.com/1110004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3533 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-19 19:05:14 +00:00