AEC Refactoring:

* Adds pointer to low level AecCore struct.
* Adds a simple unit test of this new call.

Tested with audioproc_unittest, trybots

TEST=none
BUG=none

Review URL: https://webrtc-codereview.appspot.com/1121006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3577 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
bjornv@webrtc.org 2013-02-27 21:03:41 +00:00
parent e1c4ed958d
commit 132c15de30
4 changed files with 70 additions and 0 deletions

View File

@ -700,6 +700,13 @@ WebRtc_Word32 WebRtcAec_get_error_code(void *aecInst)
return aecpc->lastError;
}
AecCore* WebRtcAec_aec_core(void* handle) {
if (!handle) {
return NULL;
}
return ((aecpc_t*) handle)->aec;
}
static int EstBufDelay(aecpc_t* aecpc) {
int nSampSndCard = aecpc->msInSndCardBuf * sampMsNb * aecpc->rate_factor;
int current_delay = nSampSndCard - WebRtcAec_system_delay(aecpc->aec);

View File

@ -0,0 +1,50 @@
/*
* Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
// TODO(bjornv): Make this a comprehensive test.
#include "webrtc/modules/audio_processing/aec/include/echo_cancellation.h"
#include <cstdlib>
#include <ctime>
extern "C" {
#include "webrtc/modules/audio_processing/aec/aec_core.h"
}
#include "testing/gtest/include/gtest/gtest.h"
namespace webrtc {
TEST(EchoCancellationTest, CreateAndFreeHandlesErrors) {
EXPECT_EQ(-1, WebRtcAec_Create(NULL));
void* handle = NULL;
ASSERT_EQ(0, WebRtcAec_Create(&handle));
EXPECT_TRUE(handle != NULL);
EXPECT_EQ(-1, WebRtcAec_Free(NULL));
EXPECT_EQ(0, WebRtcAec_Free(handle));
}
TEST(EchoCancellationTest, ApplyAecCoreHandle) {
void* handle = NULL;
ASSERT_EQ(0, WebRtcAec_Create(&handle));
EXPECT_TRUE(handle != NULL);
EXPECT_TRUE(WebRtcAec_aec_core(NULL) == NULL);
AecCore* aec_core = WebRtcAec_aec_core(handle);
EXPECT_TRUE(aec_core != NULL);
// A simple test to verify that we can set and get a value from the lower
// level |aec_core| handle.
int delay = 111;
WebRtcAec_SetSystemDelay(aec_core, delay);
EXPECT_EQ(delay, WebRtcAec_system_delay(aec_core));
EXPECT_EQ(0, WebRtcAec_Free(handle));
}
} // namespace webrtc

View File

@ -56,6 +56,8 @@ typedef struct {
AecLevel aNlp;
} AecMetrics;
struct AecCore;
#ifdef __cplusplus
extern "C" {
#endif
@ -240,6 +242,16 @@ int WebRtcAec_GetDelayMetrics(void* handle, int* median, int* std);
*/
WebRtc_Word32 WebRtcAec_get_error_code(void *aecInst);
// Returns a pointer to the low level AEC handle.
//
// Input:
// - handle : Pointer to the AEC instance.
//
// Return value:
// - AecCore pointer : NULL for error.
//
struct AecCore* WebRtcAec_aec_core(void* handle);
#ifdef __cplusplus
}
#endif

View File

@ -31,6 +31,7 @@
],
'sources': [
'aec/system_delay_unittest.cc',
'aec/echo_cancellation_unittest.cc',
'test/unit_test.cc',
'utility/delay_estimator_unittest.cc',
'utility/ring_buffer_unittest.cc',