Commit Graph

640 Commits

Author SHA1 Message Date
henrike@webrtc.org
e2a34f8275 Removes the API for setting RX VAD since the RX vad should always be on anyways.
Review URL: http://webrtc-codereview.appspot.com/264001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@897 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-07 21:33:24 +00:00
mflodman@webrtc.org
5ae9f5ed6c Adding logs in RTPSender::ReSendToNetwork.
Review URL: http://webrtc-codereview.appspot.com/273001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@896 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-07 20:03:00 +00:00
kjellander@webrtc.org
bf483844af Restructuring and removing neteq_tests.gypi according to project structure discussed with Andrew. We want to flatten out the hierarchy and minimize the number of GYP files.
I also fixed compilation on Mac (by enabling exceptions for the NetEqTestTools target). Executing the test fails on Mac, but I assume this is because it checks bit exactness, similar to the issue we had with audio_coding_module (see issue 114)

Review URL: http://webrtc-codereview.appspot.com/255004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@895 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-07 16:05:19 +00:00
kjellander@webrtc.org
36e1ad9b5d Restructuring and removing ilbc_test.gypi.
According to project structure discussed with Andrew. We want to flatten out the hierarchy and minimize the number of GYP files.

No changes at all are being made in the source files; they are just moved.
The only modified files are the GYP file and Android.mk

Kevin: I updated relative paths in Android.mk so please verify it is correct, since I don't know how to build that.

Review URL: http://webrtc-codereview.appspot.com/256006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@894 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-07 15:27:11 +00:00
vikasmarwaha@webrtc.org
a5c4c1f1d4 Fix for WebRTC issue 64, removed the screenupdate thread and events from start render as they are already created in the ctor.
Review URL: http://webrtc-codereview.appspot.com/253008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@890 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-04 23:22:51 +00:00
marpan@webrtc.org
040cb71e0a Fix windows compilation errors and warning for test_fec. Disabled VERBOSE_OUTPUT.
Review URL: http://webrtc-codereview.appspot.com/253005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@889 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-04 22:57:56 +00:00
tina.legrand@webrtc.org
731e9aea79 Fixes ACM API test to build on 32-bits machines.
Changing counters from unsigned int64 to int.
Review URL: http://webrtc-codereview.appspot.com/256010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@887 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-04 07:34:22 +00:00
kjellander@webrtc.org
20a370e875 Changing the namespace of TestSuite to webrtc::test.
Adding gmock initialization into main test runner class

Review URL: http://webrtc-codereview.appspot.com/254004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@885 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-04 01:19:16 +00:00
kjellander@webrtc.org
1a8d08ad76 Changing usage of gtest_main target, to use test_support_main instead.
Review URL: http://webrtc-codereview.appspot.com/252002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@884 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-03 23:28:47 +00:00
andrew@webrtc.org
89088b963e Fix the path to protoc.gypi.
It was mistakenly pointing to the trunk/build rather than the
trunk/src/build copy, causing the Chrome build to fail.

TEST=./build/gyp_chromium in Chrome

Review URL: http://webrtc-codereview.appspot.com/253006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@883 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-03 20:43:45 +00:00
tina.legrand@webrtc.org
2475a1953a Committing a file that was part of CL 175002, but for wome reason weren't uploaded correctly.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@882 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-03 17:54:27 +00:00
tina.legrand@webrtc.org
fb389e3b02 This CL is divided in several patches, to make review easier.
Patch Set 1: Removing blanks at end of lines.
Patch Set 2: Removing tabs.
Patch Set 3: Fixing include-guards.
Patch Set 4-7: Formatting files in the list.
Patch Set 8: Formatting CNG.

Patch Set 9: 
* Fixing comments from code review
* Fixing formating in acm_dtmf_playout.cc
* Started fixing formating of acm_g7221.cc. More work needed, so don't spend too much time reviewing.
* Refactored constructor of ACMGenericCodec. Rest of file still to be fixed.
* Fixing break; after return ...; in several files.

Patch Set 10:
* Chaning from reintepret_cast to static_cast in three files, acm_amr.cc, acm_cng.cc and acm_g722.cc
NOTE! Not all files have the right format. That work will continue in separate CLs.

Review URL: http://webrtc-codereview.appspot.com/175002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@881 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-03 17:20:10 +00:00
mikhal@webrtc.org
e203de7ba2 jitter_buffer updates:
1. Determining continuity based on pictureId and not seq. numbers when available.
2. Hybrid bug fix: Don't set to decodable when the nack list is empty.
Review URL: http://webrtc-codereview.appspot.com/255001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@878 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-03 00:42:52 +00:00
pwestin@webrtc.org
7232ad78b2 reverted back the sanity and changed the test
Review URL: http://webrtc-codereview.appspot.com/254006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@877 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-03 00:36:32 +00:00
pwestin@webrtc.org
cfc1070586 Fixed sanity for min length
Review URL: http://webrtc-codereview.appspot.com/259003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@876 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-03 00:15:44 +00:00
pwestin@webrtc.org
075e91fa27 Added parsing of width and height from VP8 header
Review URL: http://webrtc-codereview.appspot.com/241012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@875 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-02 23:14:58 +00:00
henrik.lundin@webrtc.org
679cb07980 Fix build error for release build
Review URL: http://webrtc-codereview.appspot.com/252003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@874 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-02 19:52:27 +00:00
henrik.lundin@webrtc.org
baf6db5ead Making dual decoder work again in VCM
Changing the assignment operator in VCMJitterBuffer to a named
function (CopyFrom) instead, since it is not a straight
assignment. Also fixing two bugs in the jitter copy function.

Bug fix in VCMEncodedFrame: The copy constructor did not
copy _length.

In VCM codec database, make sure that the callback object is
preserved when copying back from secondary to primary decoder.

In VP8 wrapper, adding code to copy the _decodedImage to the
Copy() method.

Bugfix in video_coding_test rtp_player:
The retransmissions where made in reverse order. Now new items are
appended to the end of the LostPackets list, which makes the order
correct when retransmitting.

Handling the case when cloning an unused decoder state:
When the decoder has not successfully decoded a frame yet,
it cannot be cloned. A NULL pointer will be returned all
the way out to VideoCodingModuleImpl::Decode(). When this
happens, the VCM will call Reset() for the dual receiver,
in order to reset the state to kPassive.

Review URL: http://webrtc-codereview.appspot.com/239010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@873 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-02 18:58:39 +00:00
kjellander@webrtc.org
d292b9c9da Unit tests now compile and run at all platforms.
Cosmetic changes to mocks.h.

Review URL: http://webrtc-codereview.appspot.com/253003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@871 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-02 16:34:52 +00:00
henrik.lundin@webrtc.org
895870b68f Adding marker bit to RTPanalyze results
Review URL: http://webrtc-codereview.appspot.com/254005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@867 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-02 08:44:42 +00:00
mikhal@webrtc.org
bb8dfbdee2 updating vpm unit_test following r858
Review URL: http://webrtc-codereview.appspot.com/255005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@865 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-01 22:07:16 +00:00
turaj@webrtc.org
7395d3d8e9 Addressing issue 115 http://code.google.com/p/webrtc/issues/detail?id=115
Review URL: http://webrtc-codereview.appspot.com/261002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@864 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-01 17:33:06 +00:00
turaj@webrtc.org
fac5316856 Address the problem that iSAC could not go 16 kHz. It was addressed in P4 but not moved to svn.
Review URL: http://webrtc-codereview.appspot.com/261001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@863 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-01 17:32:46 +00:00
turaj@webrtc.org
9116cf7c9b Have a guard on computing nrg to avoid wrap-around. This is discovered in a release test. During entropy coding of spectrum the value of "nrg" was too large and after shifting it became negative, resulting in decoder error.
Review URL: http://webrtc-codereview.appspot.com/239016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@862 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-01 17:29:34 +00:00
mflodman@webrtc.org
29d75b3f7d Only allow increasing capture time.
Review URL: http://webrtc-codereview.appspot.com/259001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@861 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-01 17:10:49 +00:00
andrew@webrtc.org
18ee6ec8e9 Use __inline in NS-fixed.
The use of "inline" was failing to build on Windows.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/255003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@860 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-01 17:07:46 +00:00
andrew@webrtc.org
3119ecfec8 Fix audioproc build errors on Windows.
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/254003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@859 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-01 17:00:18 +00:00
mikhal@webrtc.org
c4ab8706f4 video_processing: Adding logic to avoid a memcpy when not required
Review URL: http://webrtc-codereview.appspot.com/255002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@858 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-01 16:44:24 +00:00
punyabrata@webrtc.org
0ab521f754 Resolving a crash related to strncopy followed by a strcat
call. strncopy will not explicity copy or add a "\0" therefore
strcat did not know where to append the "\n" which was causing
an out of bounds crash.
Because we are checking the length, strcpy should be good enough
as it also copies the "\0". Please note that that I am pre-emptively
adding 2 instead of 1 to the length to take into account of the \n
that will be added later.
Review URL: http://webrtc-codereview.appspot.com/253004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@857 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-01 15:19:44 +00:00
kjellander@webrtc.org
d6837709cf Fixing VPMUnitTest compilation error on Windows.
It tried to include Visual Leak Detector which is not a tool that is installed/configured by default in the build.

Review URL: http://webrtc-codereview.appspot.com/257002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@854 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-01 01:51:10 +00:00
henrike@webrtc.org
b37c628ae4 Fixes crash due to r841.
Review URL: http://webrtc-codereview.appspot.com/256004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@853 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-31 23:53:04 +00:00
kma@webrtc.org
e9f909b575 Move the SetAndroidObjects to VideoCaptureFactory so that ViE can get access to it.
Review URL: http://webrtc-codereview.appspot.com/244002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@852 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-31 22:24:57 +00:00
kma@webrtc.org
27957508a3 Changed Android makefile to make the lastest video render code run.
Review URL: http://webrtc-codereview.appspot.com/247005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@849 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-31 21:29:50 +00:00
henrike@webrtc.org
066f9e5a2f Ray, please verify that this cl fixes the issue. Once the verification has been made, please review:
Henrik A: VoE
Andrew: audio_conference_mixer

Thanks!
Review URL: http://webrtc-codereview.appspot.com/241010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@841 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-28 23:15:47 +00:00
henrike@webrtc.org
731ecba47d Review URL: http://webrtc-codereview.appspot.com/251002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@840 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-28 22:49:24 +00:00
braveyao@webrtc.org
1f6d740571 This CL is about to manually reset the ShutdownRenderEvent at StopPlayout().
It could happen that if you want to restart playout, the new sponsored Render thread would catch this event
if the previous Render thread quits before this event is set.
With this modification, the device plugging out/in during talking would be supported well.
Review URL: http://webrtc-codereview.appspot.com/248002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@839 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-28 21:30:30 +00:00
stefan@webrtc.org
f960211f8b Fixes two jitter buffer bugs related to NACK.
Avoid decoding delta frames after a Flush() and after requesting
a key frame due to full NACK list.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/247011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@837 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-28 16:00:49 +00:00
stefan@webrtc.org
eb65860720 Reverts the workaround in r823 and solves a macro bug.
The macro bug caused frames to be dropped after being grabbed
for decoding.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/248004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@831 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-28 12:25:34 +00:00
tina.legrand@webrtc.org
8b1f621e3a Updated gypi for tests to work on osx.
Review URL: http://webrtc-codereview.appspot.com/250002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@830 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-28 08:57:34 +00:00
mikhal@webrtc.org
5200a05500 video_coding/jitter_buffer Updating condition on which we return a frame.
Review URL: http://webrtc-codereview.appspot.com/240011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@825 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-27 16:54:54 +00:00
mikhal@webrtc.org
30f6376802 VP8: Updating codec version: VP8 version will now return the libvpx version used.
Review URL: http://webrtc-codereview.appspot.com/247009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@824 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-27 16:45:00 +00:00
stefan@webrtc.org
2d28aff785 Workaround for an issue where frames are grabbed for decoding prematurely.
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/240013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@823 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-27 16:13:18 +00:00
stefan@webrtc.org
fbea4e555d Solves two bandwidth estimation issues and measures the sent video bitrate.
Issues solved:
1. Possible overflow when reducing the bandwidth estimate at the send-side
2. A burst of loss reports could make us reduce the rate way too far since
   we reduced the rate relative the current estimate and not the actual
   rate sent.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/244011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@822 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-27 16:08:29 +00:00
mflodman@webrtc.org
7e4269e9ee Changed VP8 qp min and added noise reduction.
Review URL: http://webrtc-codereview.appspot.com/248003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@821 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-27 12:59:47 +00:00
kjellander@webrtc.org
6b7799021c Fixing build errors on Windows platform. Minor changes...
Review URL: http://webrtc-codereview.appspot.com/241004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@819 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-26 02:38:09 +00:00
andrew@webrtc.org
cb18121990 Add an unpacker tool for audioproc debug files.
- It only unpacks audio data at the moment.
- Also switch to Chrome's protoc.gypi for protobuf targets. This reduces
  the complexity of our targets.

Review URL: http://webrtc-codereview.appspot.com/241009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@817 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-26 00:27:17 +00:00
frkoenig@google.com
fc9bcef8c7 Data alignment fix for SSIM.
WebRtc_UWord64[2] wasn't always aligned to 128 bytes, which
is necessary for _mm_store_si128.  By declaring the 
variable as __m128i it will always be 128 bytes aligned.

Incorrect include files.

__m128i is defined in emmintrin.h for visual studio.  Extra include on mac and linux is not a problem.
Review URL: http://webrtc-codereview.appspot.com/239013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@816 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-26 00:07:32 +00:00
stefan@webrtc.org
d855c1a4e8 Reverts r807 and fixes the real issue in the VCM.
This fixes an issue in the VCM where we don't wait for a packet to arrive
if the jitter buffer is empty. This also fixes an issue where an old
packet can trigger a packet event signal for a future frame.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/248001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@814 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-25 11:52:48 +00:00
henrika@webrtc.org
bdb55c806f This CL is an attempt to remove a crash we can see when closing down VoiceEgine.
It can happen that the capture thread tries to access an invalid object after StopPlayout has been called.

I have also extended the usage of the new ScopedCOMInitializer to all threads. See this step as code cleanup.
Review URL: http://webrtc-codereview.appspot.com/239014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@813 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-25 11:03:28 +00:00
henrika@webrtc.org
a6c23357c0 Solves crash in ADM API unit test for Core Audio on Windows
Review URL: http://webrtc-codereview.appspot.com/244009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@812 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-25 08:31:33 +00:00
henrika@webrtc.org
5423bc2d0b Adds correct absolute paths to all input files in ADM functional unit tests.
Files are now read and played out correctly.
Review URL: http://webrtc-codereview.appspot.com/246006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@811 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-25 08:24:20 +00:00
kma@webrtc.org
ca325ececd Corrected a linux build error introduced in issue 246005.
Review URL: http://webrtc-codereview.appspot.com/246008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@809 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-25 02:36:09 +00:00
wjia@webrtc.org
f0cd394a2e Put fwrite calls under corresponding macros since they shouldn't show up in release build.
This also make chromeos build happy.
BUG=none
TEST=compile
Review URL: http://webrtc-codereview.appspot.com/247006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@808 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-25 00:40:43 +00:00
mikhal@webrtc.org
f31826e17b adding a wait on the decode thread when no frames are available
Review URL: http://webrtc-codereview.appspot.com/246009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@807 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-25 00:20:54 +00:00
mikhal@webrtc.org
a412924c0e VP8:Setting number of cores based on image size
Review URL: http://webrtc-codereview.appspot.com/242010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@806 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-25 00:02:43 +00:00
kma@webrtc.org
913644b92d For commiting changes in CL 277002, due to file structure changes introduced during
the review of the code.
Review URL: http://webrtc-codereview.appspot.com/246005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@805 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-24 21:36:33 +00:00
andrew@webrtc.org
537096a5c1 Remove unnecessary objective-c compiler flags.
Review URL: http://webrtc-codereview.appspot.com/239011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@802 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-24 15:07:08 +00:00
henrika@webrtc.org
bf478faebb Ensures that ADM unit tests builds on all platforms.
Review URL: http://webrtc-codereview.appspot.com/240009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@800 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-24 10:31:02 +00:00
stefan@webrtc.org
5eb64f06be Fix BitrateSent() API when having a default RTP module.
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/242004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@796 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-21 13:42:50 +00:00
stefan@webrtc.org
158f496030 Fixes a rate control bug in the VP8 wrapper.
Changes how we signal frame rate and frame durations to the encoder. Rather
than changing the time base, we now only modify the frame durations, while
keeping the timebase constant. The frame duration is currently calculated
from the average input frame rate. Ideally, the frame duration should
be calculated as the timestamp diff, which is the real duration of a
frame, but the encoder doesn't seem to like too varying durations.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/247001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@795 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-21 13:15:16 +00:00
stefan@webrtc.org
ead87b5051 Fix potential issue where frame buffers might be freed while being decoded.
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/243004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@791 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-21 06:46:37 +00:00
stefan@webrtc.org
2b0f094c8f Avoid reallocating the decodedImage for every decoded frame.
Also made sure the right size is allocated.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/240004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@790 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-21 06:39:03 +00:00
mikhal@webrtc.org
ee3dfa6f43 Review URL: http://webrtc-codereview.appspot.com/241007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@789 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-21 00:46:09 +00:00
mikhal@webrtc.org
1af915d8ae video_coding: vp8: Updating error propagation threshold
Review URL: http://webrtc-codereview.appspot.com/246002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@788 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-20 18:19:18 +00:00
kma@webrtc.org
d75889e2eb Change of Android makefiles to build latest video coding code.
Review URL: http://webrtc-codereview.appspot.com/239008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@786 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-20 16:28:56 +00:00
henrika@webrtc.org
cedbb036d1 [Issue 101] Solves memory leak on Windows
git-svn-id: http://webrtc.googlecode.com/svn/trunk@784 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-20 12:11:45 +00:00
stefan@webrtc.org
c4d1983b7b Changes in rtp_format_vp8_unittest to match the changes in CL 774.
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/241006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@782 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-20 08:19:34 +00:00
kjellander@webrtc.org
81f25f9ff8 Fixing build errors on Windows platform. Minor changes...
Review URL: http://webrtc-codereview.appspot.com/241004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@779 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-19 20:06:56 +00:00
wu@webrtc.org
f3f2f6abdb * Add include_internal_video_capture and include_internal_video_render to include/exclude the internal VCM and VRM.
* Split the WEBRTC_VIDEO_EXTERNAL_CAPTURE_AND_RENDER into WEBRTC_INCLUDE_INTERNAL_VIDEO_CAPTURE and WEBRTC_INCLUDE_INTERNAL_VIDEO_RENDER.
* Add DummyDeviceInfo for the case when WEBRTC_INCLUDE_INTERNAL_VIDEO_CAPTURE is not defined.
Review URL: http://webrtc-codereview.appspot.com/224005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@778 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-19 18:42:17 +00:00
henrike@webrtc.org
509c9c5d09 operator + is evaluated before ?:
Parenthesis ensures the intended behavior.
Review URL: http://webrtc-codereview.appspot.com/239003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@777 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-19 18:31:01 +00:00
henrike@webrtc.org
4df8c9a2ed Review URL: http://webrtc-codereview.appspot.com/243001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@776 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-19 18:30:25 +00:00
stefan@webrtc.org
ffd28f95c5 Request key frames to battle error propagation.
The VP8 decoder wrapper will request key frames 30 frames after seeing
a packet loss, if it hasn't received a state refresh (only possible
through key frames in this version).

For this to be possible the jitter buffer has been made aware of
picture ids to be able to detect frame losses. Legacy JB code to
handle streams without marker bits was also removed since it
conflicts with streams with FEC.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/239002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@774 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-19 15:55:39 +00:00
mikhal@webrtc.org
d0752c370d video_coding: Update to hybrid mode: Set FEC values for zero below a threshold.
Review URL: http://webrtc-codereview.appspot.com/245001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@773 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-19 15:48:30 +00:00
bjornv@webrtc.org
4c636764b7 Updated the AEC delay logging to output values in ms. PB output updated.
Review URL: http://webrtc-codereview.appspot.com/223003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@770 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-19 08:47:40 +00:00
mflodman@webrtc.org
ce8813da4e Using id instead of name when setting Mac/QTKit capture device.
Review URL: http://webrtc-codereview.appspot.com/241002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@768 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-19 06:45:16 +00:00
andrew@webrtc.org
4d5d5c1267 Reorganize the audio_processing source.
- Remove main and source directories.
- Change .gyp, .gypi and Android.mk files correspondingly. No other
  source changes.

Review URL: http://webrtc-codereview.appspot.com/241001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@767 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-19 01:40:33 +00:00
wu@webrtc.org
8fd93d4d96 Move DeliverCapturedFrame from private to protected.
Review URL: http://webrtc-codereview.appspot.com/246001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@765 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-19 00:16:36 +00:00
stefan@webrtc.org
5b15cfc6dd Fix BWE unit test build issue
git-svn-id: http://webrtc.googlecode.com/svn/trunk@762 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-18 07:22:33 +00:00
kjellander@webrtc.org
61f07c3184 I have made a small fix so it will execute properly from the default working directory location (trunk), finding its resource files.
The ApmTest.Process test is still failing and needs to be resolved.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/194002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@761 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-18 06:54:58 +00:00
wu@webrtc.org
76aea651ff When _audioConfigured, should not try to use the _video.
Review URL: http://webrtc-codereview.appspot.com/224004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@758 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-17 21:40:32 +00:00
wu@webrtc.org
f10ea31211 Add IncomingFrameI420 to ViEExternalCapture interface to take captured video frame buffer as 3 planes.
Review URL: http://webrtc-codereview.appspot.com/219004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@753 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-14 17:16:04 +00:00
marpan@webrtc.org
14aaaf116a Some re-organization of the fec-uep code: updated protection modes, comments, and some variable/function re-naming.
Review URL: http://webrtc-codereview.appspot.com/231001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@752 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-14 16:28:02 +00:00
wu@webrtc.org
55c39f0940 Add mallinath@webrtc.org and wu@webrtc.org as the capture owner for US office.
Review URL: http://webrtc-codereview.appspot.com/230001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@751 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-14 15:34:19 +00:00
wu@webrtc.org
58691ebb97 Remove the DestroyDeviceInfo for mac video capture. (This is missed in r731.)
Review URL: http://webrtc-codereview.appspot.com/229001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@750 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-14 15:13:16 +00:00
stefan@webrtc.org
d0bdab0128 Adding API to get sent total bitrate, FEC bitrate and NACK bitrate.
Also adding tests for this in vie_auto_test.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/199001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@749 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-14 14:24:54 +00:00
marpan@webrtc.org
5a3e20f678 Removed unused variables (build error) for test_fec.
Review URL: http://webrtc-codereview.appspot.com/223001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@738 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-13 16:59:24 +00:00
pwestin@webrtc.org
1da1ce0da5 First implementation of simulcast, adds VP8 simulcast to video engine.
Changed API to RTP module
Expanded Auto test with a test for simulcast
Made the video codec tests compile
Added the vp8_simulcast files to this cl
Added missing auto test file
Review URL: http://webrtc-codereview.appspot.com/188001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@736 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-13 15:19:55 +00:00
stefan@webrtc.org
4c059d87b3 Add metric for number of packets discarded by JB due to not being decodable
Also fixes a couple of bugs related to sequence number wrap found while
testing.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/218001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@732 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-13 07:35:37 +00:00
wu@webrtc.org
77d7d5455e Replace the DestroyDeviceInfo with a virtual destructor.
Review URL: http://webrtc-codereview.appspot.com/212005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@731 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-12 16:57:53 +00:00
wu@webrtc.org
ea89922b56 Add VideoCaptureFactory so that we don't need to expose VideoCaptureImpl.
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/213002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@727 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-11 17:13:51 +00:00
andrew@webrtc.org
199f4defd3 Rename all .cc files which include Objective-C headers to .mm.
This allows the Mac Make build to pass. We were hacking it in XCode with "-x objective-c++", but gyp/Make doesn't seem to accept that flag.

Also switch Objective-C #includes to #imports.

There is one file missing from this: vie_autotest_main.cc, because it's required on multiple platforms. I'm not immediately sure what the best approach is there, but the Objective-C headers should be somehow hidden.
Review URL: http://webrtc-codereview.appspot.com/153005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@726 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-11 15:43:35 +00:00
stefan@webrtc.org
791eec7424 Add API to get the number of packets discarded by the video jitter buffer due to being too late.
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/200001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@723 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-11 07:53:43 +00:00
stefan@webrtc.org
06887aebae Fixes two bugs when decoding with packet losses.
Disable _missingFrame bit since we can't set it correctly with FEC.

No longer return more than one decoded frame per Decode() call.
This is a work-around for a bug where the frame info map was popped more often than items were added to the map.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/215001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@722 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-10 14:17:46 +00:00
kjellander@webrtc.org
25e0b8e3a0 Python output flag and keyframe interval flags.
Refactored main method into using 6 helper methods for better overview.

Review URL: http://webrtc-codereview.appspot.com/207001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@710 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-07 07:52:00 +00:00
kjellander@webrtc.org
a31b254084 Python output flag and keyframe interval flags.
Refactored main method into using 6 helper methods for better overview.

Review URL: http://webrtc-codereview.appspot.com/207001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@709 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-07 06:50:22 +00:00
henrike@webrtc.org
bf54ef9bb7 Removed code under a non-existing define.
Review URL: http://webrtc-codereview.appspot.com/193006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@706 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-06 18:14:25 +00:00
andrew@webrtc.org
b2d4921f3b Remove trailing whitespace in AudioDevice.
(That I introduced...)
Review URL: http://webrtc-codereview.appspot.com/198002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@703 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-06 16:34:36 +00:00
kjellander@webrtc.org
35a1756502 First version of video quality measurement program and test framework.
See https://docs.google.com/a/google.com/document/d/1w6Nrxw6yTg_sDu18Ux8oZPEMo5F_R-zt62udrmmTeOc/edit?hl=en_US
for background, details and additional instructions on usage.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/175001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@700 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-06 06:44:54 +00:00
kma@webrtc.org
af57de006a Some code style changes in audio_processing/ns/main/source/ by Astyle,
with a little manual modification.
Review URL: http://webrtc-codereview.appspot.com/201002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@698 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-05 23:36:01 +00:00
henrik.lundin@webrtc.org
01ca01f6e6 Adding neteq_tests to modules tests
Also moving neteq_tests.gyp and renaming to gypi. Cleaning up a
little in neteq_tests.gypi.

Review URL: http://webrtc-codereview.appspot.com/191004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@696 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-05 20:38:19 +00:00
kma@webrtc.org
bbc1f10187 Changed modules/audio_processing/utility/Android.mk, to correct a build error in
Android with the change from version r674.
Review URL: http://webrtc-codereview.appspot.com/197003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@694 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-05 18:09:02 +00:00
kma@webrtc.org
bf39ff4271 Some general optimization in NS.
No big effort in introducing new style.
Speed improved ~2%.
Bit exact.
Will introduce mulpty-and-accumulate and sqrt_floor next, which increase speed another 2% or so.

Note: In function WebRtcNsx_DataAnalysis, did the block separation because I found one "if" case is more frequent than "else" within a for loop; rest is kind of code re-aligning.
Review URL: http://webrtc-codereview.appspot.com/181002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@692 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-05 17:10:06 +00:00
stefan@webrtc.org
4b6f747373 Fixes a newly introduced bug in the jitter buffer where buffer reallocation
causes corrupt pointers.
Review URL: http://webrtc-codereview.appspot.com/186003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@688 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-04 06:58:39 +00:00
stefan@webrtc.org
93d216c23f Fixed bug in jitter buffer which caused the missingFrames bit to never be set.
Also updated the VP8 wrapper to return fully concealed frames (for rendering).

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/190003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@687 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-04 06:48:11 +00:00
stefan@webrtc.org
61b4abf1f8 Proper use of frame rate argument in generic_codec_test.
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/181005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@686 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-04 06:40:21 +00:00
mikhal@webrtc.org
e06be4f678 video coding tests: Adding ssimFrame to interface
Review URL: http://webrtc-codereview.appspot.com/188004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@685 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-03 22:54:43 +00:00
mikhal@webrtc.org
ae7a0522c5 video_coding robustness: Updating hybrid mode's settings
1. Disabling adjustment factor - temporary update. 
2. Enabling a windowed filtered loss for the hybrid mode.  
Review URL: http://webrtc-codereview.appspot.com/192003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@684 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-03 22:54:34 +00:00
marpan@google.com
f1f3fb33b5 Update to rate-mismatch factor in media_opt_util.
Review URL: http://webrtc-codereview.appspot.com/193003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@678 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-03 19:09:45 +00:00
stefan@webrtc.org
5b91464edf Allow an aggregated partition to spill over to a new packet.
Adds support for the case where the partition 0 and parts of partition 1
are transmitted in packet 1, and the end of partition 2 is transmitted
in packet 2.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/181003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@675 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-03 10:26:12 +00:00
bjornv@google.com
1ba3dbecbb Adds possibility to log delay estimates in AEC.
Review URL: http://webrtc-codereview.appspot.com/178001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@674 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-03 08:18:10 +00:00
kma@google.com
c611b1a950 Bit-exact with non-Neon version.
Review URL: http://webrtc-codereview.appspot.com/180002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@660 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-28 16:03:38 +00:00
andrew@webrtc.org
18421f2063 Remove unnecessary include from NS interface.
http://code.google.com/p/webrtc/issues/detail?id=46
Review URL: http://webrtc-codereview.appspot.com/183001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@656 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-27 19:50:52 +00:00
mikhal@webrtc.org
848fad23c6 video_coding: Updating media opt test - fixing call to protection callback.
Review URL: http://webrtc-codereview.appspot.com/179003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@653 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-27 16:30:59 +00:00
bjornv@google.com
a2c6ea09b0 Removed a segmentation fault error when processing near_file only.
Review URL: http://webrtc-codereview.appspot.com/174001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@650 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-27 08:04:45 +00:00
mikhal@webrtc.org
e185e9f68a video_coding: updates to jitter buffer logic: Make sure that every frame is inserted only once to the list.
Review URL: http://webrtc-codereview.appspot.com/165001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@648 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-23 22:02:40 +00:00
turajs@google.com
cf136186f5 Deleting matlab files
git-svn-id: http://webrtc.googlecode.com/svn/trunk@647 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-23 21:49:25 +00:00
turajs@google.com
13335ccd7a Deleting matlab files
git-svn-id: http://webrtc.googlecode.com/svn/trunk@646 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-23 21:47:25 +00:00
turajs@google.com
610f478705 Deleting matlab files
git-svn-id: http://webrtc.googlecode.com/svn/trunk@645 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-23 21:45:34 +00:00
turajs@google.com
53439d9982 Deleting matlab files
git-svn-id: http://webrtc.googlecode.com/svn/trunk@644 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-23 21:44:00 +00:00
mikhal@webrtc.org
105ff39dec video coding: updating offline tests.
Additional clean-up to the offline test: Placing test callbacks in a designated file. 
Review URL: http://webrtc-codereview.appspot.com/167002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@642 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-23 16:41:11 +00:00
turajs@google.com
496ef8aca8 To fix warnings in test files.
Review URL: http://webrtc-codereview.appspot.com/169001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@641 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-23 15:45:48 +00:00
bjornv@google.com
8e9e83b530 This CL adds guards against division by zero, that should fix http://b/issue?id=5278531
In addition a read outside memory event has been detected and removed.
Also an improper noise weighting has been corrected.
Review URL: http://webrtc-codereview.appspot.com/152001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@640 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-23 12:39:47 +00:00
bjornv@google.com
dc743a8bba Replaces a use of log2.
I've replaced a log2 operation so it works on Windows.
Review URL: http://webrtc-codereview.appspot.com/171002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@637 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-23 08:13:53 +00:00
wu@webrtc.org
221b522118 Return the number of /dev/video* without trying to open it.
Consider the case when there're /dev/video0 and /dev/video1. But for somereason the video0 is not in a correct state and can't be open. As a result, current NumberOfDevices will return 1, which is fine. However, we will then never be able to get the device we really want - /dev/video1. Consider the code below, the GetCaptureDevice will fail because it calls into DeviceInfoLinux::GetDeviceName(0, ...) which will again try to open the /dev/video0. So the root cause is the mismatching of the NumberOfDevices and GetDeviceName.

Since we will open the device in DeviceInfoLinux::GetDeviceName anyway, I think we should return the number of /dev/video* in DeviceInfoLinux::NumberOfDevices without trying to open it. Otherwise the DeviceInfoLinux::NumberOfDevices should return more information like which /dev/video* is valid which is not.

bool found = false;
for (int i = 0; i < vie_capture->NumberOfCaptureDevices(); ++i) {
  if (vie_capture->GetCaptureDevice(i, ...) == 0) {
    found = true;
    break;
  }
}
Review URL: http://webrtc-codereview.appspot.com/148004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@635 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-21 16:57:15 +00:00
bjornv@google.com
65e6ab31eb Temporary log2 remove to build in chrome
git-svn-id: http://webrtc.googlecode.com/svn/trunk@633 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-21 11:56:46 +00:00
pwestin@webrtc.org
741da942ec Added support for new RTCP message REMB (remote estimated max bitrate)
Review URL: http://webrtc-codereview.appspot.com/149001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@628 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-20 13:52:04 +00:00
andrew@webrtc.org
86b85db67e Add missing intrinsic casts for VS 2005.
Allows re-enabling SSE optimization on Windows.
Review URL: http://webrtc-codereview.appspot.com/161003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@623 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-19 18:48:25 +00:00
leozwang@google.com
522f42bb80 Add kPlatformAndroid to platform check function
Review URL: http://webrtc-codereview.appspot.com/161002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@622 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-19 17:39:05 +00:00
andrew@webrtc.org
ed083d4079 Modify the _vadActivity member of the AudioFrame passed to AudioProcessing.
This saves the user from having to explicitly check stream_has_voice(). It will allow typing detection to function, which relies on this behaviour.
Review URL: http://webrtc-codereview.appspot.com/144004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@621 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-19 15:28:51 +00:00
andrew@webrtc.org
94c7413b0d Allow echo metrics to be enabled in process_test.
Review URL: http://webrtc-codereview.appspot.com/155002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@620 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-19 15:17:57 +00:00
henrik.lundin@webrtc.org
4c36d3b424 Fixing windows warnings in rtp_utility
Adding explicit casting to bool to avoid warnings when compiling
in windows.

Review URL: http://webrtc-codereview.appspot.com/140002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@619 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-19 08:16:20 +00:00
andrew@webrtc.org
d02dc6e682 Removing bwe_standalone from modules.gyp
Review URL: http://webrtc-codereview.appspot.com/144003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@614 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-17 00:44:23 +00:00
wjia@google.com
fdaee9c014 include build/common.gypi directly
Review URL: http://webrtc-codereview.appspot.com/153006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@613 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-17 00:06:08 +00:00
andrew@webrtc.org
7b7c045b75 Fix MSVC issues in AEC to enable SSE2 optimization on Windows.
Variables now declared at top of scope and replacing C casts with intrinsic cast functions.
Review URL: http://webrtc-codereview.appspot.com/160001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@611 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-16 22:51:57 +00:00
leozwang@google.com
b37ec71dbd Remove delay_estimator_float.c from android build
Review URL: http://webrtc-codereview.appspot.com/161001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@610 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-16 21:50:36 +00:00
leozwang@google.com
ce95069ade Fix buidling error
Review URL: http://webrtc-codereview.appspot.com/151002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@603 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-15 22:28:08 +00:00
andrew@webrtc.org
4537c2a464 Remove the UNCONSTR code path from AEC.
Leave the unconstrained filter adaptation in a commented out function. Consider using this for a low-complexity mode.
Review URL: http://webrtc-codereview.appspot.com/146001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@601 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-15 18:25:14 +00:00
tommi@webrtc.org
8dc3985a10 Fix windows build.
Review URL: http://webrtc-codereview.appspot.com/150001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@600 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-15 15:01:04 +00:00
bjornv@google.com
b47d4b287d This CL includes a move of the fixed point delay estimator from aecm to apm/utility. There has also been a code change that makes it possible to enable/disable the far end alignment, so that we save complexity when used as a quality metrics.
Review URL: http://webrtc-codereview.appspot.com/135014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@599 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-15 12:27:36 +00:00
henrik.lundin@webrtc.org
29fd9a5f30 Removing warnings in all NetEQ test targets
Now all targets in neteq.gypi builds again. Also added payload type to
the log produced by RTPanalyze.

Review URL: http://webrtc-codereview.appspot.com/148001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@598 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-15 08:25:45 +00:00
andrew@webrtc.org
b524f441d0 Correct some comment spelling errors. Skipping review.
Review URL: http://webrtc-codereview.appspot.com/144002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@594 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-13 18:04:30 +00:00
andrew@webrtc.org
a3c6d61c44 Integrate the built-in WASAPI AEC DMO to VoE.
Review URL: http://webrtc-codereview.appspot.com/108006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@592 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-13 17:17:49 +00:00
leozwang@google.com
b1b3e67c97 Fix compilation errors
Review URL: http://webrtc-codereview.appspot.com/142002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@591 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-13 17:16:24 +00:00
andrew@webrtc.org
2cef36fa98 Fix Windows gyp run.
On Windows, gyp seems to require valid source files. The matlab_plotting_test target was missing its one source file, so I removed the target.

Also moving bwe_standalone.gypi to the test include list.
Review URL: http://webrtc-codereview.appspot.com/143001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@589 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-13 17:03:15 +00:00
andrew@webrtc.org
f5fb095bf9 Fix audio processing tests gypi after recent changes.
Review URL: http://webrtc-codereview.appspot.com/137025

git-svn-id: http://webrtc.googlecode.com/svn/trunk@588 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-13 01:04:59 +00:00
marpan@google.com
45fa141f0a qm_select: changed default settings for uep.
Review URL: http://webrtc-codereview.appspot.com/132015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@584 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-12 16:53:19 +00:00
henrik.lundin@webrtc.org
9f710d08e1 Switch to new sqrt in NetEQ
Switched to WebRtcSpl_SqrtFloor instead of WebRtcSpl_Sqrt in
NetEQ. The output is not bit-exact, but subjective listening
tests show no audible difference. Analysis shows that almost
all of the difference is in changed delay.

The reference file for NetEQ's unit test was updated.

Review URL: http://webrtc-codereview.appspot.com/139019

git-svn-id: http://webrtc.googlecode.com/svn/trunk@583 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-12 16:44:37 +00:00
kjellander@webrtc.org
f0a8464b74 Added more statistics during SSIM/PSNR calculation, including calculation of min/max value.
Moved video_metrics.h into a GYP library so it can be used from other projects.

Review URL: http://webrtc-codereview.appspot.com/132013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@582 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-12 13:45:39 +00:00
xians@google.com
d3185fe219 refactor the gyp file to gypi file.
Basically, the gypi file is a copy of gyp file, but has some difference on the
path of the dependencies.
Review URL: http://webrtc-codereview.appspot.com/137020

git-svn-id: http://webrtc.googlecode.com/svn/trunk@581 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-12 12:24:39 +00:00
perkj@webrtc.org
0cc68dc38a Change Video capture module to be reference counting. Also prevent the module from beeing deleted using the interface.
Furthermore remove all static module creation and deletion functions.
Review URL: http://webrtc-codereview.appspot.com/133012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@580 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-12 08:53:36 +00:00
tina.legrand@webrtc.org
31c6b60456 Adding calls to Version functions for external codecs.
Also clarified in comments where to put interface files for external codecs.
Review URL: http://webrtc-codereview.appspot.com/135017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@579 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-12 07:18:37 +00:00
zakkhoyt@google.com
c6e8b72c83 Removing qualifiers on include path
Review URL: http://webrtc-codereview.appspot.com/132014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@576 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-09 17:41:13 +00:00
marpan@google.com
30ecda146a media_opt_util: Added comment and lowered window size parameter.
Review URL: http://webrtc-codereview.appspot.com/135018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@575 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-09 17:15:12 +00:00
marpan@google.com
3f28061f3a media_opt_util: Modification to correction factor in FEC overhead.
Review URL: http://webrtc-codereview.appspot.com/133019

git-svn-id: http://webrtc.googlecode.com/svn/trunk@573 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-09 16:39:40 +00:00
mikhal@webrtc.org
6f54c20703 video coding test: Adding MT functionality
Review URL: http://webrtc-codereview.appspot.com/135008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@570 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-09 14:38:59 +00:00
henrik.lundin@webrtc.org
35dcc23110 Adding regression test to NetEQ
The test inputs RTP packets from an RTPdump file into NetEQ
and compares the output to the corresponding reference file.
Test files are included.

The change also includes a new method in NETEQTEST_RTPpacket
class, which reads past the initial file header in an RTPdump
file.

Finally, a few warnings are removed.
Review URL: http://webrtc-codereview.appspot.com/138012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@568 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-09 08:01:16 +00:00
stefan@webrtc.org
06e2c11703 Remove unintentional printfs
Review URL: http://webrtc-codereview.appspot.com/131018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@563 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-08 13:16:24 +00:00
stefan@webrtc.org
167328eab6 Disable libvpx partitions code for libvpx versions prior Cayuga.
Necessary for WebRTC to build with Chromium. 
Also fixes the decoder wrapper's Reset() function so that properly
reinitializes the decoder.
Review URL: http://webrtc-codereview.appspot.com/132012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@562 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-08 13:05:48 +00:00
stefan@webrtc.org
9e812fca9f Adding missing parts related to VP8 partitions
Review URL: http://webrtc-codereview.appspot.com/131017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@561 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-08 10:11:24 +00:00
stefan@webrtc.org
42ab82bf2f Disable independent partitions by default.
Review URL: http://webrtc-codereview.appspot.com/140006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@559 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-08 06:55:29 +00:00
stefan@webrtc.org
c3d891059e Adds support for VP8 partitions
This change adds support for VP8 partitions in the video jitter buffer and 
the VP8 encoder and decoder wrappers. The feature is currently disabled by
default since it requires a later version of libvpx.

With this change the jitter buffer will also start keeping track of each
packet header until decoding, and the VCMSessionInfo and VCMPacket objects 
will keep pointers into the encoded frame buffers.
Review URL: http://webrtc-codereview.appspot.com/137021

git-svn-id: http://webrtc.googlecode.com/svn/trunk@558 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-08 06:50:28 +00:00
henrik.lundin@webrtc.org
dd07d5932a Let VP8 decoder handle NULL codecSpecificInfo
VP8Decoder::Decode() can now handle the case when
codecSpecificInfo is NULL. Previously, it would crash.

Review URL: http://webrtc-codereview.appspot.com/135015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@554 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-07 15:21:38 +00:00
henrik.lundin@webrtc.org
ea05973e68 Fixing VCM tests for VP8
Removing asserts since the PictureID (and other parameters)
is now piped through codecSpecific. Also made sure the VCM
send callbacks (test code) copies the appropriate paramters.
Finally, enabling I420 in tests.

Review URL: http://webrtc-codereview.appspot.com/137022

git-svn-id: http://webrtc.googlecode.com/svn/trunk@553 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-07 15:20:17 +00:00
henrika@google.com
73d65513f1 Adds reference counting to the ADM.
This CL modifies the ADM interface to ensure that an external ADM
can't call Create and Destroy any longer.

It also contains some minor style nits to conform better with
the Chromium style guide.
Review URL: http://webrtc-codereview.appspot.com/133014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@552 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-07 15:11:18 +00:00
andrew@webrtc.org
b44172dab9 Fix "braces recommended" warning in audio_conference_mixer.
Review URL: http://webrtc-codereview.appspot.com/131014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@539 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-06 18:04:32 +00:00
perkj@google.com
ac75cab618 Fix reference counting assert.
Change assert("teo") to assert(!"teo") so that the assert is actually triggered.
Review URL: http://webrtc-codereview.appspot.com/133018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@533 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-06 13:58:34 +00:00
stefan@webrtc.org
269f8a14c6 Undoing change committed in r514 since it broke bandwidth estimation
Review URL: http://webrtc-codereview.appspot.com/132011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@531 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-06 09:51:59 +00:00
perkj@google.com
ea72c34fb9 Temporary add dummy implementation to RefCountModule. The reason is so that ADM and VideoCapture implementations can change to refcounted versions before forcing them.
Review URL: http://webrtc-codereview.appspot.com/139014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@527 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-05 11:11:04 +00:00
henrik.lundin@webrtc.org
1e53166569 Fix VP8 tests
These are changes that make the VP8 tests work again after the
wrapper was updated. The codec specific info is now propagated
properly through the encoder callback and into the queue struct.

Also added an fclose to get rid of a valgrind warning.
Review URL: http://webrtc-codereview.appspot.com/138011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@526 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-05 07:23:33 +00:00
zakkhoyt@google.com
fb298d3783 Modified path on speex lib
Review URL: http://webrtc-codereview.appspot.com/137018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@524 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-02 22:06:49 +00:00
andrew@webrtc.org
413b993166 Put some table size information in one place.
Motivated by fixing an unused variable warning in release mode.
Review URL: http://webrtc-codereview.appspot.com/132007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@523 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-02 22:03:56 +00:00
turajs@google.com
d7a41774ce header included twice.
Review URL: http://webrtc-codereview.appspot.com/139013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@522 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-02 20:52:47 +00:00
henrik.lundin@webrtc.org
2641fd1d19 Remove warnings in vp8_test
Most modifications are either reordering of the initializers in constructors, removed unused variables, or comparison mismatches taken care of. A few other special cases are commented.
Review URL: http://webrtc-codereview.appspot.com/132008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@518 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-02 12:09:07 +00:00
perkj@google.com
ef04cf4b2e Adding reference counted version of the module interface.
The reason for this is that we would like to have reference counting on the modules you can register externally with ViE and VoE.
Currently we plan to use this on the ADM, VideoCapture module and VideoRenderModule.
Review URL: http://webrtc-codereview.appspot.com/138010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@517 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-02 09:47:28 +00:00
andrew@webrtc.org
4d905f88c6 Fix clang warnings in rtp.
Review URL: http://webrtc-codereview.appspot.com/132006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@514 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-01 19:22:27 +00:00
andrew@webrtc.org
bbd8908664 Fix clang warnings in video coding.
Review URL: http://webrtc-codereview.appspot.com/138007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@511 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-01 17:30:01 +00:00
tina.legrand@webrtc.org
84519ec0a2 Fixing some inconsistencies in WebRTC audio coding module. I've added setup information for all codecs which are not part of WebRTC, but possible to hook in.
Please help me review.
Henrik: review neteq_defines.h
Turaj: review all files, but the one Henrik reviews.
Zakk: FYI only.
Review URL: http://webrtc-codereview.appspot.com/138004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@505 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-01 07:47:31 +00:00
marpan@google.com
243db12616 media_opt_util: Fixed an assert and some code cleanup for AvgRecoveryFEC function.
Review URL: http://webrtc-codereview.appspot.com/139007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@502 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-31 22:14:52 +00:00
turajs@google.com
ebb2744337 To fix warning for unused variable. And fix some warning in test.
Review URL: http://webrtc-codereview.appspot.com/131010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@500 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-31 21:28:08 +00:00
turajs@google.com
eaf3185105 Take care of unused variable.
Review URL: http://webrtc-codereview.appspot.com/137013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@499 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-31 21:27:53 +00:00
andrew@webrtc.org
9562a3664c Last fixes to build with gcc 4.6.
Set but unused parameter/variable warnings.
http://code.google.com/p/webrtc/issues/detail?id=52
Review URL: http://webrtc-codereview.appspot.com/139006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@498 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-31 18:50:12 +00:00
andrew@webrtc.org
830099eba4 Add a gyp flag to disable video functionality from dependencies shared by voice and video engine.
Currently, this is just the utility module. It relies on the already existing WEBRTC_MODULE_UTILITY_VIDEO define.
Review URL: http://webrtc-codereview.appspot.com/133007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@496 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-31 17:03:54 +00:00
pwestin@webrtc.org
e9f0e2eb20 Moved _rtpReceiver to protected
Review URL: http://webrtc-codereview.appspot.com/132005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@495 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-31 13:16:52 +00:00
tommi@webrtc.org
c7d5f6249b Fix build errors on Windows.
Since this is a C file, variables must be declared at the top of the function
so I'm moving the fix for the warning (inst = NULL) to the bottom of the funciton.
Otherwise, the compiler will complain when it sees int i; on systems that do
not have WEBRTC_BIG_ENDIAN defined.
Review URL: http://webrtc-codereview.appspot.com/139005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@494 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-31 12:11:24 +00:00
turajs@google.com
74c640aebb fix build break
Review URL: http://webrtc-codereview.appspot.com/132004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@493 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-30 20:44:24 +00:00
turajs@google.com
7796c02b42 Wrap encode, decode, PLC NB functions in #define to avoid warnings.
Review URL: http://webrtc-codereview.appspot.com/133005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@492 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-30 20:30:17 +00:00
turajs@google.com
8ecd0e8f3d Remove Clang warning for PCM16B.
Review URL: http://webrtc-codereview.appspot.com/137006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@491 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-30 20:29:50 +00:00
punyabrata@google.com
eba8c32840 Resolving a race condition issue related to using shared devices
(e.g. usb headsets) where we were not stopped the shared callback
until both StopPlayout() and StopRecording() are called. Google
internal bugid 4478351
Review URL: http://webrtc-codereview.appspot.com/130001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@489 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-30 14:32:22 +00:00
xians@google.com
e74a9ea303 AudioDeviceUtility::WaitForKey() pulls two characters if the first one is a newline, but discards the final value.
The current code assigns that second value to a local variable, which generates a set-but-unused warning on gcc 4.6.0. Instead, cast the result away.

I also refactor the code a bit by adding the right indentation and removing empty lines.

Bug=http://code.google.com/p/webrtc/issues/detail?id=53
Test=none
Review URL: http://webrtc-codereview.appspot.com/135005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@486 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-30 08:27:02 +00:00
xians@google.com
932096c84f Porting gtalk alsa impl from depot to webrtc
Review URL: http://webrtc-codereview.appspot.com/123002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@484 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-30 07:41:55 +00:00
mikhal@webrtc.org
46171cf546 video coding tests: Adding a Normal distribution to simulate packet arrival times
Review URL: http://webrtc-codereview.appspot.com/138003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@483 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-29 23:38:04 +00:00
henrik.lundin@webrtc.org
8571af7be6 Updating to new VP8 rtp format
The VP8 packetizer and tests have been updated to the new
RTP draft (http://tools.ietf.org/html/draft-ietf-payload-vp8-01).
The receive-side parser is also updated, and a new unit test
is implemented for it. Finally, some data traversing work to
get the parsed information into the decoder.
Review URL: http://webrtc-codereview.appspot.com/116011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@482 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-29 15:37:12 +00:00
hellner@google.com
09734086c6 Fixes build issue in http://code.google.com/p/webrtc/issues/detail?id=56.
Review URL: http://webrtc-codereview.appspot.com/131008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@481 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-29 14:10:01 +00:00
tina.legrand@webrtc.org
81fd2bfbba New ACM codec database, created at compile time.
Review URL: http://webrtc-codereview.appspot.com/127002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@480 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-29 11:18:44 +00:00
tina.legrand@webrtc.org
a41b4ce7da Changing iLBC to use the new improved SQRT, WebRtcSpl_SqrtFloor().
The bit-stream has not change with the new SQRT, but the output signal has. The change in output is small, and all test-files pass a subjective quality test.
New test-files will be committed to svn after this CL.
Review URL: http://webrtc-codereview.appspot.com/136001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@478 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-29 08:19:30 +00:00
tina.legrand@webrtc.org
2aa5d500af Issue reported in WebRTC. A variable is defined and set, but never used.
Review URL: http://webrtc-codereview.appspot.com/139001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@474 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-29 06:36:37 +00:00
henrik.lundin@webrtc.org
36450af2b3 Removing unsupported codecs from ptypes file
The file ptypes.txt tells test program NetEqRTPplay how to
map the RTP payload types in an RTP file. Now removing payload
types that are not supported in WebRTC.
Review URL: http://webrtc-codereview.appspot.com/119009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@473 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-27 01:25:35 +00:00
andrew@webrtc.org
bd4494cb20 Remove the divide-by-2 when mixing.
Review URL: http://webrtc-codereview.appspot.com/137007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@471 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 22:58:00 +00:00
mikhal@webrtc.org
b7ac56d92b video coding tests: updating quality tests following r466
Review URL: http://webrtc-codereview.appspot.com/131009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@470 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 21:18:35 +00:00
mikhal@webrtc.org
d24a97fae1 video coding test: deleting unused file(resampler_test.cc)
Review URL: http://webrtc-codereview.appspot.com/137008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@469 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 21:18:17 +00:00
mikhal@webrtc.org
2c3b1fb4f3 video_coding tests: removing unused functionality from test_util
Review URL: http://webrtc-codereview.appspot.com/137009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@468 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 21:18:04 +00:00
mikhal@webrtc.org
a057a9561c video_coding: Updating protection logic in media optimization utility:
1. Changing protection logic structure: Accepts only one method (not a list)
2. Removed unused code (unreferenced protection methods)
3. Removed inline constructors/destructors.  
Review URL: http://webrtc-codereview.appspot.com/120005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@467 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 21:17:34 +00:00
mikhal@webrtc.org
552f173979 video_coding: Moving video metrics computation to a designated file.
This is the first stage of a general clean-up to test_util. Will try to divide this clean-up to small changes, so it will be easier to review. 
Review URL: http://webrtc-codereview.appspot.com/120004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@466 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 17:38:09 +00:00
andrew@webrtc.org
e46d69f762 Fix gcc 4.6 set but unused warnings in AEC.
Review URL: http://webrtc-codereview.appspot.com/134003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@465 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 17:20:54 +00:00
andrew@webrtc.org
ffbe7a75fd Cast away the unused state argument value to silence gcc 4.6 warnings.
The WebRTC C wrapper for the G711 codec doesn't actually use the 'state' 
argument, but declares one anyway for API uniformity.

At the beginning of functions like WebRTCG711_EncodeA(), there's a stanza:

    // Set to avoid getting warnings
    state = NULL;

This might work around an unused parameter warning, but under gcc 4.6.0 
it ends up generating another warning, that state is set but not used.  

Casting the assignment to void silences the warning, restoring 
compilation under -Werror.

Reported as https://code.google.com/p/webrtc/issues/detail?id=50
Review URL: http://webrtc-codereview.appspot.com/135002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@463 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 17:16:30 +00:00
turajs@google.com
7f2bbbbefd To remove all calls involving scratch-memory
Review URL: http://webrtc-codereview.appspot.com/129001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@462 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 16:03:49 +00:00
turajs@google.com
ac55f7b33c Review URL: http://webrtc-codereview.appspot.com/115004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@461 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 16:02:16 +00:00
xians@webrtc.org
c57f9c38ad Using IAudioEndpointVolume in IsSpeakerMuteAvailable and IsMicrophoneMuteAvailable to be consistent with SpeakerMute and MicrophoneMute APIs.
Review URL: http://webrtc-codereview.appspot.com/112007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@458 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 12:28:33 +00:00
mflodman@webrtc.org
4fcb0caf78 Removing warning in video capture module for linux and auto test.
Review URL: http://webrtc-codereview.appspot.com/134002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@457 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 10:54:48 +00:00
mikhal@webrtc.org
ba9bd692ea video_coding_tests: Fix build error
Review URL: http://webrtc-codereview.appspot.com/132001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@452 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-25 20:12:03 +00:00
stefan@webrtc.org
44d356d6df Fix unused variable warning in spatial_resampler.cc
Issue 60: [Patch] Fix unused variable warning in spatial_resampler.cc
Review URL: http://webrtc-codereview.appspot.com/125003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@444 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-25 07:53:53 +00:00
turajs@google.com
5cc9c68e8d Fixing a warning discovered while compiling with clang.
Review URL: http://webrtc-codereview.appspot.com/120003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@441 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-24 21:20:33 +00:00
marpan@google.com
057efc8f98 Removed unused variables and unnecessary assert: causing build error in vpm_test.
Review URL: http://webrtc-codereview.appspot.com/128001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@440 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-24 20:53:15 +00:00
andrew@webrtc.org
4f390000dd Fix warnings on Ubuntu 11.04 (gcc 4.5)
http://code.google.com/p/webrtc/issues/detail?id=63
Review URL: http://webrtc-codereview.appspot.com/125004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@439 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-24 20:35:35 +00:00
wu@webrtc.org
37fd004c69 Remove the X11 headers we don't need.
Review URL: http://webrtc-codereview.appspot.com/123003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@438 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-24 17:06:38 +00:00
frkoenig@google.com
cf36b2aa9b Match new[] / delete []
Quiet valgrind warnings by correctly matching 
new[] with delete[].
Review URL: http://webrtc-codereview.appspot.com/126005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@437 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-24 15:48:47 +00:00
stefan@webrtc.org
49cbc512ae Fix unused variable warning in video_coding.
Issue 57: [Patch] Fix unused variable warnings in the video_coding module
Review URL: http://webrtc-codereview.appspot.com/126004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@435 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-24 08:51:08 +00:00
andrew@webrtc.org
7f593c1e62 Fix gcc 4.6 unused variable warnings in audio_processing.
Issues:
http://code.google.com/p/webrtc/issues/detail?id=54
http://code.google.com/p/webrtc/issues/detail?id=55
Review URL: http://webrtc-codereview.appspot.com/121003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@434 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-24 01:00:50 +00:00
mikhal@webrtc.org
6724cf8183 VP8: Adding a flag to indicate the libvpx version. When in Cayuga, additional API's will be used.
Review URL: http://webrtc-codereview.appspot.com/120006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@433 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-24 00:51:36 +00:00
wjia@google.com
4482b04207 revert r430 to keep webrtc always ready to roll in chromium.
r430 will be used when libvpx in chromium is rolled to Cayuga.
Review URL: http://webrtc-codereview.appspot.com/119008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@431 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-23 23:41:00 +00:00
wjia@google.com
f9f1deba8f Get ready for libvpx Cayuga (v0.9.7-p1).
When building with Chromium, on Windows, only header files are needed; otherwise, libvpx.gyp:libvpx is needed.

This patch is based on http://webrtc-codereview.appspot.com/91019/
Review URL: http://webrtc-codereview.appspot.com/122005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@430 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-23 23:08:30 +00:00
hellner@google.com
a386fc0a8b Fixes build warnings due to unused variables.
Code directly from http://code.google.com/p/webrtc/issues/detail?id=58.
Review URL: http://webrtc-codereview.appspot.com/119007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@428 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-23 21:26:09 +00:00
hellner@google.com
9aa9996a19 Different solution than the one suggested in http://code.google.com/p/webrtc/issues/detail?id=56 however, should solve the same problem.
Review URL: http://webrtc-codereview.appspot.com/126003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@427 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-23 21:25:55 +00:00
andrew@webrtc.org
ceb148ce59 Fix compile warnings in Release configuration.
Review URL: http://webrtc-codereview.appspot.com/119003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@424 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-23 17:53:54 +00:00
mikhal@webrtc.org
06ad81fd58 video_coding: changing the UpdateMethod function (protection settings).
Review URL: http://webrtc-codereview.appspot.com/126002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@423 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-23 16:03:59 +00:00
perkj@google.com
12f1fc4fe5 Fix initialization defect in constructor webrtc::ModuleRtpRtcpImpl::ModuleRtpRtcpImpl(WebRtc_Word32, bool) initialization list.
Review URL: http://webrtc-codereview.appspot.com/125002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@422 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-23 14:26:33 +00:00
perkj@google.com
a3fc1aac52 Fix Issue 59. Fix a constructor cast warning in video_X11_channel.cc.
http://code.google.com/p/webrtc/issues/detail?id=59.
Review URL: http://webrtc-codereview.appspot.com/122002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@421 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-23 13:38:14 +00:00
pwestin@webrtc.org
a070adbab2 Moved member RTPSender from private to protected.
Review URL: http://webrtc-codereview.appspot.com/119006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@420 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-23 11:17:03 +00:00
xians@webrtc.org
9d64705dea The method AudioDeviceWindowsWave::RecProc can use uninitialized variables t1 and t2.
This results in an exception in debug mode and unpredictable behavior in release mode.

The problem is at line 3514:

        // Calculate processing time
        consumedTime = (int)(t2.QuadPart-t1.QuadPart);

Bug=http://code.google.com/p/webrtc/issues/detail?id=42
Test=none
Review URL: http://webrtc-codereview.appspot.com/121002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@419 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-23 09:14:56 +00:00
punyabrata@webrtc.org
5895ea1573 Fixes volume problem controls, happening with some Logitech headsets. Originally submitted as gips p4 depot CL 38122.
Review URL: http://webrtc-codereview.appspot.com/116008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@418 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-22 22:46:38 +00:00
punyabrata@google.com
9695e75fbd Resolve a crash related to pulseAudio where we need to check if
pa_context_get_source_info_by_name/pa_context_get_sink_info_by_name 
has early failure and returns NULL,then to avoid WaitForOperationCompletion
from crashing, paOperation must be checked to ensure it is not NULL.

Please note that ::WaitForOperationCompletion( ) is a void function
therefore returning without any error code if paOperation is indeed NULL

Google internal bug id [4356730]
Review URL: http://webrtc-codereview.appspot.com/122003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@417 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-22 22:35:14 +00:00
cduvivier@google.com
288c8698cb Optimization of 'cftmdl':
* scalar optimization, vectorization.
* 1.7% AEC overall speedup for the straight C path.
* 9.2% AEC overall speedup for the SSE2 path.
Review URL: http://webrtc-codereview.appspot.com/109008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@416 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-22 21:55:33 +00:00
mikhal@webrtc.org
0e16b78ec9 VP8: Removing VP8Latest flag following the update to the Cayuga release
Review URL: http://webrtc-codereview.appspot.com/116012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@415 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-22 21:25:39 +00:00
mikhal@webrtc.org
d70b77d19f video_coding: Updating offline tests
1. Adding parameters to the  input arguments. 
2. Introducing delay in the RTPSend callback
3. Clean-up
Review URL: http://webrtc-codereview.appspot.com/116006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@414 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-22 21:08:15 +00:00
andrew@webrtc.org
f81f9f8c2a Add -Werror and -Wextra to the Linux build.
Includes all fixes required for -Wextra.
Review URL: http://webrtc-codereview.appspot.com/117006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@410 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-19 22:56:22 +00:00
frkoenig@google.com
9139fddf0e Optimize ssim_8x8 for SSE2.
Code was pulled from libvpx assembly and converted
to intrinsics.
Review URL: http://webrtc-codereview.appspot.com/122001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@409 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-19 22:33:08 +00:00
andrew@webrtc.org
6423509efc Fix Valgrind warnings in audio_processing.
Review URL: http://webrtc-codereview.appspot.com/119001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@408 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-19 21:22:08 +00:00
frkoenig@google.com
f53055d60e Use optimized SSIM from libvpx.
Review URL: http://webrtc-codereview.appspot.com/117005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@407 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-19 18:16:59 +00:00
holmer@google.com
2cdc7b94d2 Enabling libvpx error concealment.
Review URL: http://webrtc-codereview.appspot.com/116010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@399 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-18 09:35:45 +00:00
tina.legrand@webrtc.org
2e09692006 This CL fixes the warnings when building acm or acm test.
Review URL: http://webrtc-codereview.appspot.com/109013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@397 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-18 06:20:30 +00:00
frkoenig@google.com
ff476c6c4e Optimize temporal difference metric for SSE2.
Quick optimizations using intrinsics.
Review URL: http://webrtc-codereview.appspot.com/115006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@395 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-17 23:24:57 +00:00
mikhal@webrtc.org
685383dd37 video_coding/media_opt_util: Removing windows warnings
Review URL: http://webrtc-codereview.appspot.com/113006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@394 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-17 23:19:54 +00:00
frkoenig@google.com
31f24de5e3 Use the correct include file.
There shouldn't be a dependency on spatial_resampler.h, defines
that were needed are in video_processing_defines.h.
Review URL: http://webrtc-codereview.appspot.com/117003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@393 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-17 22:23:28 +00:00
turaj@webrtc.org
ca758c268e To remove warnings found by clang
Review URL: http://webrtc-codereview.appspot.com/113005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@392 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-17 20:25:36 +00:00
mikhal@webrtc.org
ebeb5a656b video_coding - JB: Ensuring that every frame is inserted only once to the list
Review URL: http://webrtc-codereview.appspot.com/114006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@391 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-17 18:43:21 +00:00
henrik.lundin@webrtc.org
473bac8582 Propagate codec specific info to decoder
Add explicit use of CodecSpecificInfo to VCMGenericDecoder and
the codecs (VP8 and I420). Propagate information from
WebRtcRTPHeader in VCM (IncomingPacket) to GenericDecoder.
Review URL: http://webrtc-codereview.appspot.com/109011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@390 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-17 09:47:33 +00:00
punyabrata@webrtc.org
7049389794 Fixes volume problem controls, happening with some Logitech headset [from gips P4 depot CL 38122]
Review URL: http://webrtc-codereview.appspot.com/108004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@389 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-17 00:15:52 +00:00
punyabrata@webrtc.org
7bd857bc99 Apple Airfoil audio casting software crash resolution [Google Internal buglist id: 4444985]
Review URL: http://webrtc-codereview.appspot.com/109001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@387 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-17 00:01:05 +00:00
marpan@google.com
771ca422df Fixed assert error in media_opt_util that may have caused index for look-up table to be out of range.
Review URL: http://webrtc-codereview.appspot.com/112005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@385 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-16 20:51:04 +00:00
hellner@google.com
977c2966fc Review URL: http://webrtc-codereview.appspot.com/109006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@383 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-16 17:30:30 +00:00
andrew@webrtc.org
ad2a37093a Fix unused variable warnings.
Review URL: http://webrtc-codereview.appspot.com/114005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@381 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-16 17:18:17 +00:00
leozwang@google.com
7189270640 Fix compliation error
Review URL: http://webrtc-codereview.appspot.com/114003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@379 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-16 16:37:45 +00:00
hellner@google.com
17a018716c Minimal fixes to remove build warnings.
Review URL: http://webrtc-codereview.appspot.com/109007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@378 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-16 16:23:46 +00:00
hellner@google.com
1abe7a0555 Minimal fixes to remove build warnings.
Review URL: http://webrtc-codereview.appspot.com/116004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@377 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-16 15:52:57 +00:00
xians@google.com
0134facd53 Get rid of the ADM test warnings.
Review URL: http://webrtc-codereview.appspot.com/116001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@375 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-16 09:30:51 +00:00
xians@google.com
bf5d2ba8fb This CL will exclude the built-in ADM when building with chromium.
When building with chromium, we use dummy ADM for all the platforms.
Review URL: http://webrtc-codereview.appspot.com/108001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@373 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-16 07:44:19 +00:00
kma@google.com
8dd7466b52 2nd check in
Review URL: http://webrtc-codereview.appspot.com/112002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@372 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-16 03:28:28 +00:00
hellner@google.com
56294c61c9 Review URL: http://webrtc-codereview.appspot.com/114002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@370 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-15 22:47:40 +00:00
andrew@webrtc.org
3296d76c50 Remove unneeded G167 define from AEC.
Review URL: http://webrtc-codereview.appspot.com/114001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@369 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-15 21:40:38 +00:00
frkoenig@google.com
241c4d0e8d Remove numPixels.
The number of pixels was used in both the numerator and denominator of
the final calculation and is therefore not needed.
Review URL: http://webrtc-codereview.appspot.com/112003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@368 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-15 19:08:48 +00:00
leozwang@google.com
95222074ba Some changes made in android makefile
Review URL: http://webrtc-codereview.appspot.com/109003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@367 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-15 17:40:56 +00:00
frkoenig@google.com
6d171c4f98 SSE2 optimizations for spatial content analysis.
Using intrinsics to work on 16 pixels at a time when
computing the spatial metrics.
Review URL: http://webrtc-codereview.appspot.com/92013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@366 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-15 15:56:23 +00:00
xians@google.com
3ab5d5f4d0 This patch just gets rid of the rest of warnings on voe_auto_test and adm.
Trivial changes.
Review URL: http://webrtc-codereview.appspot.com/111001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@364 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-15 11:07:54 +00:00
holmer@google.com
155188ce40 Handle all VP8 packets within a frame as depending on the previous packet
This is temporary until the VP8 receiver support fragments.
Review URL: http://webrtc-codereview.appspot.com/113002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@363 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-15 09:21:27 +00:00
andrew@webrtc.org
d11aa2b215 Fix build error on Windows due to gcc specific attribute.
Review URL: http://webrtc-codereview.appspot.com/115001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@361 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-14 23:25:28 +00:00
andrew@webrtc.org
2be2f694a4 Remove implicit declaration warnings.
Review URL: http://webrtc-codereview.appspot.com/113001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@360 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-13 18:22:42 +00:00
kma@google.com
1959e6fcb5 1st check-in for AECM Neon optimization.
Review URL: http://webrtc-codereview.appspot.com/104001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@359 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-13 06:33:38 +00:00
leozwang@google.com
4033e1245d Change folder name from Android to android
Review URL: http://webrtc-codereview.appspot.com/106002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@358 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-12 15:54:48 +00:00
leozwang@google.com
c5597353c6 Change folder name from Android to android
Review URL: http://webrtc-codereview.appspot.com/107001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@357 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-12 15:53:44 +00:00
marpan@google.com
319fbd107d Added simple model to test_util.cc to simulate bursty packet loss.
Review URL: http://webrtc-codereview.appspot.com/104002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@355 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-11 22:51:58 +00:00
mikhal@google.com
60873adc3e rtp_sender_video: Modify behavior on send video packet error. This issue was already updated in CL r217, and accidentally reverted in CL r231.
Review URL: http://webrtc-codereview.appspot.com/106004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@354 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-11 22:30:00 +00:00
mallinath@google.com
16f1dfc953 Review URL: http://webrtc-codereview.appspot.com/92006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@352 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-11 18:22:17 +00:00
leozwang@google.com
911e36c525 Also change folder name in audio_device test
Review URL: http://webrtc-codereview.appspot.com/105002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@351 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-11 17:04:26 +00:00
xians@google.com
0fe2627e6f adding audio_device_utility_mac.cc, which was misssing from previous CL.
Review URL: http://webrtc-codereview.appspot.com/106001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@349 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-11 14:32:40 +00:00
xians@google.com
77f66051e8 delete old folders
Review URL: http://webrtc-codereview.appspot.com/105001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@348 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-11 13:58:34 +00:00
xians@google.com
68efa21abc This CL refactor the audio_device.gyp to make use of the chromiurm _os suffix filter.
This CL looks big, but most of the changes are only renaming. I hope it is all right for you.

Changes include:
rename source/Windows to source/win
rename source/Linux to linux
rename source/Mac to source/mac

Also rename some files to  follow chromium standard, for examples:
from alsasymboltable.cc to alsasymboltable_linux.cc
from alsasymboltable.h to alsasymboltable_linux.h
from audio_device_linux_alsa.cc to audio_device_alsa_linux.cc
from audio_device_linux_alsa.h to audio_device_alsa_linux.h
...etc

Modified files:
audio_device.gyp and audio_device_impl.cc : 
adapt to the new file names.

Test=none
Bug=none
Review URL: http://webrtc-codereview.appspot.com/91017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@347 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-11 12:41:56 +00:00
kma@google.com
1489785326 Commit as part of http://webrtc-codereview.appspot.com/89018/
Committing separately as part of an OWNERS test.


git-svn-id: http://webrtc.googlecode.com/svn/trunk@345 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-10 23:30:11 +00:00
xians@google.com
c3976c8c92 exclude the video_capture_module_test target from building with chromium.
BUG=http://code.google.com/p/webrtc/issues/detail?id=34
TEST=None
Review URL: http://webrtc-codereview.appspot.com/93015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@343 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-10 08:02:41 +00:00
andrew@webrtc.org
8910f278c5 Switch to webrtc.org accounts (for those which exist).
Review URL: http://webrtc-codereview.appspot.com/97010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@342 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-10 05:16:31 +00:00
mikhal@google.com
9e9f86743c VP8 wrapper: Adding check for no show frames (NULL images)
Review URL: http://webrtc-codereview.appspot.com/102001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@341 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-09 22:12:19 +00:00
leozwang@google.com
22b699d2e0 Replace ANDROID with WEBRTC_ANDROID
Review URL: http://webrtc-codereview.appspot.com/97008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@337 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-09 17:27:33 +00:00
mikhal@google.com
5ce0ff05ae Removing compiler warnings from video components
Review URL: http://webrtc-codereview.appspot.com/101002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@336 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-09 17:17:39 +00:00
kma@google.com
579ee4d3f1 Neon optimization for an NS function.
Review URL: http://webrtc-codereview.appspot.com/89017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@334 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-09 04:30:06 +00:00
xians@google.com
f67f197049 exclude the neteq test targets from building with chromium.
BUG=http://code.google.com/p/webrtc/issues/detail?id=34
TEST=None
Review URL: http://webrtc-codereview.appspot.com/93017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@326 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-08 12:56:26 +00:00
xians@google.com
508eba5321 exclude vp8 and test_framework test targets from chromium.
BUG=http://code.google.com/p/webrtc/issues/detail?id=34
Test=None
Review URL: http://webrtc-codereview.appspot.com/95012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@324 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-08 12:48:13 +00:00
xians@google.com
0922815173 exclude the test target from building with chromium.
Review URL: http://webrtc-codereview.appspot.com/93016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@321 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-08 11:44:07 +00:00
xians@google.com
0b0665acc1 This CL changes all the freq relevant variables to be int type. So it will take away the VoE "comparison between signed and unsigned integer expressions" warnings.
BR,
/SX
Review URL: http://webrtc-codereview.appspot.com/89014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@320 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-08 08:18:44 +00:00
leozwang@google.com
81520b7955 Enable protobuf for apm module
Review URL: http://webrtc-codereview.appspot.com/93019

git-svn-id: http://webrtc.googlecode.com/svn/trunk@319 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-05 22:20:03 +00:00
marpan@google.com
8726e270ec Build error fix from r316/r314.
Review URL: http://webrtc-codereview.appspot.com/95013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@317 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-05 21:38:56 +00:00
marpan@google.com
7bb8a9444d Change to r315: code to return error for
incomplete frames (for _feedbackMode off) 
is commented out.
Review URL: http://webrtc-codereview.appspot.com/91016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@316 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-05 21:20:29 +00:00
leozwang@google.com
79835d1bd3 Clean up Android.mk
Review URL: http://webrtc-codereview.appspot.com/92014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@315 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-05 21:01:02 +00:00
marpan@google.com
a1ec48dec2 Updates to VP8 wrapper:
1) Added VP8E_SET_STATIC_THRESHOLD which sets threshold for
   forcing static macroblocks to skipped mode
   (useful for encoding of static background).
2) Removed some code in decoding to allow for 
   decoding of incomplete frames.
3) Minor change to MaxIntraTarget()
4) Added control setting for maximum (target) size of 
   intra-frame.
5) Increased kf_max_dist(reduce/remove key-frame periodicity)  
   since we use kf_auto_mode. 
Review URL: http://webrtc-codereview.appspot.com/101001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@314 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-05 20:51:32 +00:00
ajm@google.com
9f726b9d78 Resubmit r300 with changes required for Windows build.
Review URL: http://webrtc-codereview.appspot.com/97005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@313 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-05 16:46:33 +00:00
xians@google.com
88f94f985e exclude the ACM test target from building with chromium.
Review URL: http://webrtc-codereview.appspot.com/95011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@312 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-05 16:14:51 +00:00
xians@google.com
4d79bf164b exclude the g722 test target from building with chromium.
Review URL: http://webrtc-codereview.appspot.com/92011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@311 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-05 16:14:25 +00:00
xians@google.com
e1cfd5f252 exclude test target from chromium
Review URL: http://webrtc-codereview.appspot.com/92012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@310 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-05 16:14:02 +00:00
xians@google.com
7fa20c3880 exclude both audio_device_test_api and audio_device_test_func test targets from building with chromium.
Review URL: http://webrtc-codereview.appspot.com/97006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@308 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-05 12:04:30 +00:00
xians@google.com
3d292f1649 this CL will strip the test targets from building with chromium.
Review URL: http://webrtc-codereview.appspot.com/99004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@307 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-05 08:32:13 +00:00
xians@google.com
15ad55b03c This CL fixes the gclient runhooks problem with building with chromium.
The problem is 
src/third_party/webrtc/third_party/protobuf/protobuf.gyp not found
Review URL: http://webrtc-codereview.appspot.com/92008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@306 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-05 08:21:25 +00:00
ronghuawu@google.com
102944a22b Revert r300.
Review URL: http://webrtc-codereview.appspot.com/91014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@303 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-04 20:48:36 +00:00