mflodman@webrtc.org
c80d9d9361
Removed default cases causing clang errors, -Wcovered-switch-default.
...
BUG=
TEST=Bulid with clang version 3.1 (trunk 148911)
Review URL: https://webrtc-codereview.appspot.com/379008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1604 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 10:11:25 +00:00
kma@webrtc.org
de66b91274
In voice engine, added member audioFrame to classes AudioCodingModuleImpl and VoEBaseImpl,
...
and touched VoEBaseImpl::NeedMorePlayData and AudioCodingModuleImpl::PlayoutData10Ms(), for
performance reasons in Android platforms.
The two functions used about 6% of VoE originally. After the change, the percentage reduced
to about 0.2%.
Review URL: https://webrtc-codereview.appspot.com/379001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1589 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-01 18:39:44 +00:00
xians@webrtc.org
79af734807
This patch fixes the converity warnings in voice engine.
...
Review URL: https://webrtc-codereview.appspot.com/373017
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1579 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-31 12:22:14 +00:00
henrika@webrtc.org
2919e95c2a
Resolves Coverty issue #10347 .
...
Uninitialized member (UNINIT_CTOR).
Review URL: https://webrtc-codereview.appspot.com/369023
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1577 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-31 08:45:03 +00:00
phoglund@webrtc.org
048eb7cda6
Finished rewriting the audio processing test.
...
Partial rewrite of audio processing tests.
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/367008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1561 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-27 11:58:41 +00:00
andrew@webrtc.org
b9d7d934de
Rename interface/ to include/ in audio_processing.
...
BUG=none
TEST=build on Linux.
Review URL: https://webrtc-codereview.appspot.com/367007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1552 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-25 19:21:13 +00:00
andrew@webrtc.org
24bd58e689
Properly count anonymous mixing participants.
...
When _amountOfMixableParticipants == 1, we skip mixing and saturation
protection. Without this fix, an anonymous participant would only be
properly counted if it was the last added.
For example, if an anonymous participant was added first, followed by
a regular participant, _amoutOfMixableParticipants would == 1 and the
regular participant would not be mixed.
BUG=issue209
TEST=New test added to voe_auto_test to verify, and used voe_cmd_test.
Review URL: https://webrtc-codereview.appspot.com/367006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1551 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-25 18:57:44 +00:00
andrew@webrtc.org
eeaf3d1fc1
Merge /branches/3.2:r1380 to /trunk
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1523 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 06:30:02 +00:00
leozwang@webrtc.org
f5cacdce8c
Fix line aligement
...
Review URL: https://webrtc-codereview.appspot.com/373002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1516 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-23 23:14:13 +00:00
phoglund@webrtc.org
12dbc23851
Rewrote volume test.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/367004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1506 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-23 16:03:04 +00:00
phoglund@webrtc.org
3b57ee0238
Rewrote DTMF test.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/368001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1502 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-23 09:22:33 +00:00
leozwang@webrtc.org
2638577f03
Add an argument in ANDROID_NOT_SUPPORT macro
...
Review URL: https://webrtc-codereview.appspot.com/363003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1499 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-20 18:45:45 +00:00
tommi@webrtc.org
9ff87db5c0
Remove the diamond inheritance pattern from VoEVideoSyncImpl in attempt to see if this fixes coverity reports.
...
CID=10446,10445,10444,10443
Review URL: https://webrtc-codereview.appspot.com/343018
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1472 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-19 15:05:36 +00:00
punyabrata@webrtc.org
ad1927d368
Changing the typing detection sensitivity as the current
...
setting does not work well in some scenarios especially
using webcams with built-in microphones.
Review URL: https://webrtc-codereview.appspot.com/349009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1455 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-18 18:53:04 +00:00
phoglund@webrtc.org
5badc7e969
Put system cpu tests back in, improved documentation.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/350011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1452 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-18 10:46:07 +00:00
phoglund@webrtc.org
c12f815de6
Rewrote hardware test and fixed broken tests on Windows.
...
Fixed broken tests on Windows, including old tests.
Rewrote hardware test.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/347008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1434 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-16 12:40:18 +00:00
henrika@webrtc.org
f75901fa4c
Resolves CID 10540: Copy into fixed size buffer (STRING_OVERFLOW).
...
You might overrun the 32 byte fixed-size string "receiveCodec.plname" by copying "payloadName" without checking the length.
Note: This defect has an elevated risk because the source argument is a parameter of the current function.
Review URL: http://webrtc-codereview.appspot.com/352009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1428 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-16 08:45:42 +00:00
braveyao@webrtc.org
f5c6573725
fix defect http://code.google.com/p/webrtc/issues/detail?id=215 , audio device is not stopped appropriately.
...
Review URL: http://webrtc-codereview.appspot.com/350008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1427 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-16 03:04:46 +00:00
andrew@webrtc.org
7859e10985
Propagate decoding errors to the mixer module.
...
Review URL: http://webrtc-codereview.appspot.com/348001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1417 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-13 00:30:11 +00:00
henrik.lundin@webrtc.org
053c7991e3
Add minimum waiting time to NetEQ metrics
...
Adding minWaitingTimeMs to ACMNetworkStatistics and to
NetworkStatistics. Also adding unittest.
TEST=audio_coding_unittests
Review URL: http://webrtc-codereview.appspot.com/350006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1408 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-12 14:16:44 +00:00
kjellander@webrtc.org
7f3c724e12
Renaming 47 files from .cpp to .cc
...
In addition to our naming guidelines, this will cause these files to get parsed by Sonar, and to make searching/grepping the source using file extensions easier in the future.
BUG=
TEST=Compiling on Linux.
Review URL: http://webrtc-codereview.appspot.com/348005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1405 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-12 10:23:41 +00:00
perkj@webrtc.org
ce5990cb0b
Fix defect http://code.google.com/p/webrtc/issues/detail?id=222
...
"ViE GetSentRTCPStatistics fails on a sending channel if it don't receive rtp video packets.
BUG=222
TEST= tested in loopback. No new test added yet.
Review URL: http://webrtc-codereview.appspot.com/343003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1387 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-11 13:00:08 +00:00
phoglund@webrtc.org
01530a2ac2
Rewrote the rcp_rtcp test.
...
Finished rewriting the rtp_rtcp test.
Rewrote first RTP RTCP test
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/342007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1386 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-11 12:26:34 +00:00
phoglund@webrtc.org
0aa7b32652
Finished rewriting the codec test.
...
Rewrote more tests.
Rewrote most of the codec test and removed it from the regular test.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/329008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1355 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-09 11:15:46 +00:00
pwestin@webrtc.org
c450a19669
Removed Version function from all modules.
...
TBR=henrik_a
Review URL: http://webrtc-codereview.appspot.com/329023
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1330 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 15:00:12 +00:00
henrik.lundin@webrtc.org
d439870473
Adding two new network metrics to NetEQ
...
Clock-drift (in parts-per-million) and peaky-jitter mode status.
Both metrics are propagated to the VoE API. Tests are added
in the NetEQ unittests, and to some extent in ACM unittests
and VoE tests.
Introducing a proper translation between structs NetworkStatistics
and ACMNetworkStatistics.
Note: The file neteq_network_stats.dat in resources must be updated
for the unittests to pass.
Review URL: http://webrtc-codereview.appspot.com/337005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1328 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 13:09:55 +00:00
andrew@webrtc.org
3192d655bd
Fix for devices lacking stereo support.
...
The number of capture channels can only be determined upon receiving the
first captured frame. We now assume stereo capture by default and set the
number of AudioProcessing input channels based on captured frames.
TEST=Windows mono-only device now runs AudioProcessing correctly (NS etc.), voe_auto_test (though some new, seemingly unrelated, tests are failing)
Review URL: http://webrtc-codereview.appspot.com/330013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1273 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-21 18:00:59 +00:00
henrik.lundin@webrtc.org
dbba1f969f
Packet waiting-time statistics
...
Adding new statistics API to NetEQ, reporting the waiting time
for each frame. The output is raw waiting time for the frames
that have been decoded since the last statistics report (or
maximum 100 frames). The statistics are reset on each query.
Implemented functionality in ACM to query NetEQ for the raw
waiting times, and process it to produce max, average and
median.
Updating common_types.h and VoiceEngine tests to include the
new metrics.
Unit tests are also added for NetEQ and AcmNetEq.
Review URL: http://webrtc-codereview.appspot.com/328011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1251 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-20 15:45:05 +00:00
phoglund@webrtc.org
f3cea2336b
Added an empty voice engine unit test binary in order to get correct coverage measurements. This will make the voice engine show up in the coverage measurements. The empty test is necessary to get the coverage tool to pick it up (and it will be easier to start writing unit tests for the voice engine later).
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/334003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1245 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-20 10:14:53 +00:00
phoglund@webrtc.org
fda17c2b00
Rewrote NetEQ test, made standard suite run googletestified tests too.
...
The standard suite will now also run the googletestified tests.
Removed NetEQ tests from the standard test.
Initial version of new neteq test. Moved fixtures to own folder.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/328010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1242 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-20 09:07:37 +00:00
phoglund@webrtc.org
86a9f9b946
Fixed build error.
...
Merge branch 'master' into voe_rewrites
Conflicts:
src/voice_engine/main/test/auto_test/standard/after_streaming_fixture.cc
Revert "Rewrote network-before-streaming."
This reverts commit f1a07b813a90e4feef0a0737ebde9fb15acfd459.
Rewrote network-before-streaming.
Fixed strange build error.
Merge branch 'master' into voe_rewrites
Revert "Rewrote network-before-streaming."
This reverts commit f1a07b813a90e4feef0a0737ebde9fb15acfd459.
Rewrote network-before-streaming.
Nit fixes
Clarified some comments and method names.
Style fixes.
Removed tab characters.
Merge branch 'master' into voe_rewrites
Conflicts:
src/voice_engine/main/test/auto_test/voe_standard_test.cc
Revert "Rewrote network-before-streaming."
This reverts commit f1a07b813a90e4feef0a0737ebde9fb15acfd459.
Rewrote network-before-streaming.
Rewrote the hold test.
Abstracted out resource handling and created a new fixture for starting and stopping playing.
Rewrote network-before-streaming.
Revert "Rewrote network-before-streaming."
This reverts commit f1a07b813a90e4feef0a0737ebde9fb15acfd459.
Rewrote network-before-streaming.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/333007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1230 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-19 10:24:46 +00:00
phoglund@webrtc.org
188fc35e07
Rewrote the hold and netw-before-streaming tests.
...
Rewrote the hold test.
Abstracted out resource handling and created a new fixture for starting and stopping playing.
Rewrote network-before-streaming.
BUG=
TEST=voe_auto_test
Review URL: http://webrtc-codereview.appspot.com/331001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1228 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-19 09:36:03 +00:00
phoglund@webrtc.org
610e90e910
Completed rewrite of codec test.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/324011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1203 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-15 10:40:19 +00:00
leozwang@webrtc.org
eda2da796e
Fix compilation errors
...
Review URL: http://webrtc-codereview.appspot.com/322014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1195 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 20:03:09 +00:00
phoglund@webrtc.org
667eca6290
Rewrote the hardware-before-streaming test.
...
Restructured the test hierarchy somewhat - there is now a fixture for before-voe-init time and one for after-voe-init time.
Rewrote the hardware-before-streaming test.
Separated unrelated tests out from the rtp_rtcp tests.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/323009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1184 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 13:55:34 +00:00
phoglund@webrtc.org
fe61bc3607
Merge branch 'master' into voe_create_test
...
Fixed broken build.
Nit fix.
Fixed style issues.
Removed accidental comment-out.
Removed test that no longer makes sense.
Rewrote hardware-before-init and rtp-rtcp-before-streaming test code to gtest.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/320009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1162 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-12 17:02:16 +00:00
phoglund@webrtc.org
6418a24795
Rewrote hardware-before-init and rtp-rtcp-before-streaming test code to gtest.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/322003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1161 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-12 16:24:23 +00:00
phoglund@webrtc.org
dd094fd6ae
Started extracting methods out of the main test.
...
Started extracting methods out of the main test, which will hopefully make us able to make the tests independent.
Merge branch 'master' into voe_split_methods
Conflicts:
src/voice_engine/main/test/auto_test/voe_extended_test.cc
src/voice_engine/main/test/auto_test/voe_extended_test.h
src/voice_engine/main/test/auto_test/voe_standard_test.cc
src/voice_engine/main/test/auto_test/voe_standard_test.h
Extracted methods out of the standard test.
Added space before inheritance colons.
Rolled back some header file changes.
Fixed long lines.
Fixed long lines.
Fixed indentation. There is nothing but whitespace changes here, except for removing some extraneous semicolons in .h files and fixing a spelling error in a comment.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/313001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1131 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 15:07:59 +00:00
phoglund@webrtc.org
693240f2d9
Fixed many formatting and indentation problems in voe_auto_test.
...
Fixed indentation. There is nothing but whitespace changes here, except for removing some extraneous semicolons in .h files and fixing a spelling error in a comment.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/305004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1122 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-07 12:32:58 +00:00
henrika@webrtc.org
af71f0e5d9
Fixes two minor issues reported by the Coverty Integration Manager.
...
BUG=none
TEST=voe_auto_test
Review URL: http://webrtc-codereview.appspot.com/302002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1098 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-05 07:02:22 +00:00
perkj@webrtc.org
68f2168978
Remove global voe::Channel::numSocketThreads.
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1067 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-30 18:11:23 +00:00
henrik.lundin@webrtc.org
524eb48081
Removing deprecated NetEQ APIs
...
Removing WebRtcNetEQ_GetPreferredBufferSize and
WebRtcNetEQ_GetCurrentDelay and all dependent APIs.
Review URL: http://webrtc-codereview.appspot.com/289006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1063 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-30 16:21:22 +00:00
xians@webrtc.org
e07247af8d
Valgrind reports a racing condition on _sending because it is accessed by
...
both TransmitMixer::PrepareDemux() and StartSend()/StopSend().
Put a lock to resolve it.
Review URL: http://webrtc-codereview.appspot.com/293005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1038 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-28 16:31:28 +00:00
xians@webrtc.org
83661f534e
fixing the racing conditions
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1025 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-25 10:58:15 +00:00
braveyao@webrtc.org
0a18522e1b
Add support to 96kHz sampling rate to Windows CoreAudio interface.
...
Review URL: http://webrtc-codereview.appspot.com/295003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1018 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-25 02:45:39 +00:00
henrik.lundin@webrtc.org
df10de4b27
Removing statistics API from NetEQ
...
Removing WebRtcNetEQ_GetJitterStatistics(),
WebRtcNetEQ_ResetJitterStatistics(), and the associated
struct WebRtcNetEQ_JitterStatistics. The change ripples
through all the way to the VoiceEngine API.
Review URL: http://webrtc-codereview.appspot.com/285002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@998 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-23 09:36:23 +00:00
henrike@webrtc.org
31d30700d6
Addressed review comments from http://webrtc-codereview.appspot.com/256004/
...
Review URL: http://webrtc-codereview.appspot.com/256007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@979 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-18 19:59:32 +00:00
kjellander@webrtc.org
3f1cb8e546
Restructuring and adding dummy unit test target.
...
Empty test added to get code coverage recorded.
Review URL: http://webrtc-codereview.appspot.com/269018
git-svn-id: http://webrtc.googlecode.com/svn/trunk@967 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-17 13:56:54 +00:00
kjellander@webrtc.org
cc2ecb3c2e
Restructuring and adding dummy unit test target.
...
Empty test added to get code coverage recorded.
Review URL: http://webrtc-codereview.appspot.com/267019
git-svn-id: http://webrtc.googlecode.com/svn/trunk@966 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-17 13:48:36 +00:00
kjellander@webrtc.org
b72268e147
Restructuring and adding dummy unit test target.
...
Empty test added to get code coverage recorded.
Review URL: http://webrtc-codereview.appspot.com/280004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@965 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-17 13:39:15 +00:00
kjellander@webrtc.org
64a897a772
Restructuring and adding dummy unit test target.
...
Empty test added to get code coverage recorded.
Review URL: http://webrtc-codereview.appspot.com/282001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@964 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-17 13:33:11 +00:00
kjellander@webrtc.org
0403ef419f
Restructuring and adding unit test targets on project level instead of in common_audio.
...
Review URL: http://webrtc-codereview.appspot.com/280001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@959 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-17 08:35:47 +00:00
niklas.enbom@webrtc.org
af26f64616
Inband DTMF stereo support
...
Review URL: http://webrtc-codereview.appspot.com/267011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@956 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-16 12:41:36 +00:00
niklas.enbom@webrtc.org
e33a102eee
Resubmitting http://webrtc-codereview.appspot.com/269007/
...
Review URL: http://webrtc-codereview.appspot.com/268012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@955 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-16 10:33:53 +00:00
andrew@webrtc.org
755b04a06e
Add RMS computation for the RTP level indicator.
...
- Compute RMS over a packet's worth of audio to be sent in Channel, rather than the captured audio in TransmitMixer.
- We now use the entire packet rather than the last 10 ms frame.
- Restore functionality to LevelEstimator.
- Fix a bug in the splitting filter.
- Fix a number of bugs in process_test related to a poorly named
AudioFrame member.
- Update the unittest protobuf and float reference output.
- Add audioproc unittests.
- Reenable voe_extended_tests, and add a real function test.
- Use correct minimum level of 127.
TEST=audioproc_unittest, audioproc, voe_extended_test, voe_auto_test
Review URL: http://webrtc-codereview.appspot.com/279003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@950 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-15 16:57:56 +00:00
andrew@webrtc.org
0db7dc6e18
Add file-playing channels to voe_cmd_test.
...
Fix file reading and writing.
TEST=voe_cmd_test
Review URL: http://webrtc-codereview.appspot.com/279001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@938 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-13 01:34:05 +00:00
stefan@webrtc.org
b351d6a8d8
Reverting rev 929 due to failing assert on Linux.
...
Failing at: audio_buffer.cc:159
TBR=mflodman
Review URL: http://webrtc-codereview.appspot.com/270008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@935 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-11 13:26:05 +00:00
niklas.enbom@webrtc.org
50b3cbe979
First pass. You can now enable a stereo codec and send and receive. This does not include more advances use cases (DTMF etc), but I'd rather keep the CLs manageable.
...
Review URL: http://webrtc-codereview.appspot.com/269007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@929 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-11 08:31:32 +00:00
kma@webrtc.org
b61c410347
Fixed a couple of Android makefiles to let voe and vie build properly.
...
Review URL: http://webrtc-codereview.appspot.com/278001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@928 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-10 18:10:25 +00:00
andrew@webrtc.org
c4f129f97c
Improve the mixing saturation protection scheme.
...
A single participant is not processed at all. With multiple
participants, we divide-by-2 as before when mixing. Afterwards,
the mixed signal is limited by the AGC to -7 dBFS and then doubled to
restore the original level.
This preserves the level while guaranteeing good saturation protection.
Add a test to voe_auto_test. Hijack and improve the existing mixing test
for this.
TEST=voe_auto_test, voe_cmd_test
Review URL: http://webrtc-codereview.appspot.com/241013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@920 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-10 03:41:22 +00:00
andrew@webrtc.org
d30b688751
Remove TraceScan executable.
...
Review URL: http://webrtc-codereview.appspot.com/270002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@918 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-09 22:23:20 +00:00
niklas.enbom@webrtc.org
f3c1b87f00
my eyes started bleeding when I saw this...
...
Review URL: http://webrtc-codereview.appspot.com/268005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@907 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-09 12:43:48 +00:00
phoglund@webrtc.org
cff98ca6ff
Made it possible to run the voe_auto_test standard test in GTest behind a flag. The purpose is to run the whole test without any manual intervention since we want to run the test on a build bot in automated mode.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/267001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@903 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-08 13:08:25 +00:00
henrike@webrtc.org
e2a34f8275
Removes the API for setting RX VAD since the RX vad should always be on anyways.
...
Review URL: http://webrtc-codereview.appspot.com/264001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@897 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-07 21:33:24 +00:00
andrew@webrtc.org
a4b9660372
Add mistakenly removed VAD enabling function.
...
This resolves the unknown VAD status warnings introduced in r845.
BUG=
TEST=voe_cmd_test
Review URL: http://webrtc-codereview.appspot.com/252004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@879 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-03 01:36:27 +00:00
kma@webrtc.org
4bb141078f
A change to Android makefile for building voe auto test.
...
Review URL: http://webrtc-codereview.appspot.com/255007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@872 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-02 16:38:22 +00:00
henrike@webrtc.org
b37c628ae4
Fixes crash due to r841.
...
Review URL: http://webrtc-codereview.appspot.com/256004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@853 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-31 23:53:04 +00:00
andrew@webrtc.org
3134aacd6b
Use fileutils for the audio file in voe_auto_test.
...
BUG=
TEST=voe_auto_test
Review URL: http://webrtc-codereview.appspot.com/250010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@850 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-31 21:31:07 +00:00
andrew@webrtc.org
2c74bab8b9
Remove unneeded assert and tracing.
...
This is related to r840.
BUG=
TEST=voe_auto_test
Review URL: http://webrtc-codereview.appspot.com/239019
git-svn-id: http://webrtc.googlecode.com/svn/trunk@845 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-31 19:54:20 +00:00
henrike@webrtc.org
066f9e5a2f
Ray, please verify that this cl fixes the issue. Once the verification has been made, please review:
...
Henrik A: VoE
Andrew: audio_conference_mixer
Thanks!
Review URL: http://webrtc-codereview.appspot.com/241010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@841 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-28 23:15:47 +00:00
andrew@webrtc.org
4d5d5c1267
Reorganize the audio_processing source.
...
- Remove main and source directories.
- Change .gyp, .gypi and Android.mk files correspondingly. No other
source changes.
Review URL: http://webrtc-codereview.appspot.com/241001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@767 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-19 01:40:33 +00:00
bjornv@webrtc.org
3765bd2cc2
Added AEC delay logging metrics to VoE. Echo metrics and delay logging metrics are enabled simultaneously through the SetEcMetricsStatus(). Updated standard and extended VoE tests.
...
class VoEAudioProcessing
-API renaming:
SetEchoMetricsStatus() to SetEcMetricsStatus()
GetEchoMetricsStatus() to GetEcMetricsStatus()
since delay logging is not strictly an echo metric.
-New API:
GetEcDelayMetrics()
-Implementations
--SetEcMetricsStatus() sets same status to all EC related metrics, currently Echo Metrics and Delay Logging.
--GetEcMetricsStatus() gets an error if all EC related metrics don't have the same status.
--GetEcDelayMetrics() gets the median and standard deviation of AEC internal delay (on a block by block basis).
class VoECallReport
The changes above leads to changes in the Call Report.
-New API:
GetEcDelaySummary()
-API updates:
ResetCallReportStatistics()
WriteReportToFile()
auto_tests updates:
-Standard test, with new Call Report calls and APM calls
-Extended test, with new Call Report calls and APM calls
Review URL: http://webrtc-codereview.appspot.com/187004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@754 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-17 08:49:23 +00:00
pwestin@webrtc.org
1da1ce0da5
First implementation of simulcast, adds VP8 simulcast to video engine.
...
Changed API to RTP module
Expanded Auto test with a test for simulcast
Made the video codec tests compile
Added the vp8_simulcast files to this cl
Added missing auto test file
Review URL: http://webrtc-codereview.appspot.com/188001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@736 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-13 15:19:55 +00:00
amyfong@webrtc.org
e5542a0af5
Add file record and play functions to voe_cmd_test, fix Play local file (path was incorrect)
...
Fixed:
24. Play local file (audio_long16.pcm)
New:
34. Record a PCM file
35. Play a previously recorded PCM file locally
36. Play a previously recorded PCM file as microphone
Review URL: http://webrtc-codereview.appspot.com/209001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@729 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-11 20:30:56 +00:00
andrew@webrtc.org
3ce62fcfe4
Move merge_libs targets to their own gyp.
...
The main reason is to depend on all ("*") targets in voice_engine.gyp and video_engine.gyp. We don't want the merge_lib targets building by default, since they do funny stuff like delete some libraries.
Review URL: http://webrtc-codereview.appspot.com/191003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@699 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-06 01:03:18 +00:00
andrew@webrtc.org
f458916145
Returning errors if any of the Init() settings in VoE fail.
...
There's no reason to try to continue if these simple settings fail; better to know about it immediately.
Also, readjusting the indentation to avoid breaking strings over several lines. This bends GStyle a bit, but it's well worth it to avoid the common "forgot to add a space" error.
Review URL: http://webrtc-codereview.appspot.com/173003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@676 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-03 15:22:28 +00:00
punyabrata@webrtc.org
6b6d08164f
Remove assert "currentVoEMicLevel <= kMaxVolumeLevel". We ran into an issue on a Linux system where the currentVoEMicLevel was in fact greater than the kMaxVolumeLevel. Therefore we are removing this assert and capping the currentMicLevel to the maxVolumeLevel when this case is detected.
...
Review URL: http://webrtc-codereview.appspot.com/180001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@661 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-28 17:45:03 +00:00
bjornv@google.com
0beae6798d
Removed level estimator calls, since it is not supported. There are still one place left; used within SetRTPAudioLevelIndicationStatus(). The error return value of level_estimator() has no effect there.
...
The VoE auto tests have been updated as well.
Review URL: http://webrtc-codereview.appspot.com/178003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@658 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-28 14:08:19 +00:00
xians@google.com
49d025f262
Get the right guid str for GetRecordingDeviceName
...
Bug=http://code.google.com/p/webrtc/issues/detail?id=99
Test=none
Review URL: http://webrtc-codereview.appspot.com/183002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@652 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-27 14:43:06 +00:00
leozwang@google.com
90eff6c7c6
Fix compilation error in build-in AEC test
...
Review URL: http://webrtc-codereview.appspot.com/164001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@636 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-21 18:02:03 +00:00
amyfong@webrtc.org
3be70ca17e
Added mute, hold and typing detect to voe_cmd_test to increase functionality in the voe_cmd_test application.
...
Typing Detect is applicable only for Mac.
Review URL: http://webrtc-codereview.appspot.com/156002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@632 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-20 23:41:06 +00:00
leozwang@google.com
ec5e87614e
Enable OPENELSE defination when compile voice engine
...
Review URL: http://webrtc-codereview.appspot.com/150005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@629 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-20 16:41:09 +00:00
leozwang@google.com
a5700876c0
Add include path to auto test
...
Review URL: http://webrtc-codereview.appspot.com/155001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@608 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-16 20:38:31 +00:00
andrew@webrtc.org
416d702ace
Fix autotest error on non-Win platforms.
...
Review URL: http://webrtc-codereview.appspot.com/149007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@607 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-16 14:22:39 +00:00
wu@webrtc.org
fcd12b3b7d
Add necessary spaces to log.
...
Review URL: http://webrtc-codereview.appspot.com/148002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@602 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-15 20:49:50 +00:00
andrew@webrtc.org
b524f441d0
Correct some comment spelling errors. Skipping review.
...
Review URL: http://webrtc-codereview.appspot.com/144002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@594 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-13 18:04:30 +00:00
andrew@webrtc.org
7a585a7903
Correct voe_auto_test file path on Windows.
...
Needs to be changed due to the recent move of voice_engine.gyp.
Review URL: http://webrtc-codereview.appspot.com/144001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@593 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-13 17:46:36 +00:00
andrew@webrtc.org
a3c6d61c44
Integrate the built-in WASAPI AEC DMO to VoE.
...
Review URL: http://webrtc-codereview.appspot.com/108006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@592 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-13 17:17:49 +00:00
leozwang@google.com
803a5f2795
Add include path
...
Review URL: http://webrtc-codereview.appspot.com/141003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@590 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-13 17:15:22 +00:00
xians@google.com
d3185fe219
refactor the gyp file to gypi file.
...
Basically, the gypi file is a copy of gyp file, but has some difference on the
path of the dependencies.
Review URL: http://webrtc-codereview.appspot.com/137020
git-svn-id: http://webrtc.googlecode.com/svn/trunk@581 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-12 12:24:39 +00:00
zakkhoyt@google.com
b448ae229c
Permanently adding additional logs
...
Review URL: http://webrtc-codereview.appspot.com/137024
git-svn-id: http://webrtc.googlecode.com/svn/trunk@577 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-09 17:41:49 +00:00
punyabrata@webrtc.org
955d0eed2f
Removing echo warning because it seems to be flooding the logs
...
anytime there is any echo. Secondly, this should be treated as
a warning in the sense that echo in the signal does not mean
something is wrong with the engine.f
Review URL: http://webrtc-codereview.appspot.com/139018
git-svn-id: http://webrtc.googlecode.com/svn/trunk@572 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-09 16:28:51 +00:00
henrika@google.com
73d65513f1
Adds reference counting to the ADM.
...
This CL modifies the ADM interface to ensure that an external ADM
can't call Create and Destroy any longer.
It also contains some minor style nits to conform better with
the Chromium style guide.
Review URL: http://webrtc-codereview.appspot.com/133014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@552 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-07 15:11:18 +00:00
andrew@webrtc.org
e0ed8b26de
Fix "return value unused" warnings in voe_cmd_test release mode.
...
Review URL: http://webrtc-codereview.appspot.com/140001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@530 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-06 02:36:17 +00:00
xians@google.com
b875349537
fixing a bug in GetPlayoutDeviceName, previously it returns name as guid.
...
Bug=http://code.google.com/p/webrtc/issues/detail?id=77
Test=none
Review URL: http://webrtc-codereview.appspot.com/135011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@528 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-05 12:17:30 +00:00
leozwang@google.com
9d23ba096d
Make test app work on android
...
Review URL: http://webrtc-codereview.appspot.com/137014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@525 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-04 03:33:44 +00:00
andrew@webrtc.org
a80d026517
Fix clang warnings in voice engine.
...
Review URL: http://webrtc-codereview.appspot.com/133008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@512 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-01 17:30:09 +00:00
andrew@webrtc.org
9562a3664c
Last fixes to build with gcc 4.6.
...
Set but unused parameter/variable warnings.
http://code.google.com/p/webrtc/issues/detail?id=52
Review URL: http://webrtc-codereview.appspot.com/139006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@498 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-31 18:50:12 +00:00
xians@google.com
3266d8d85d
have the voe_cmd_test compiled with external transport enabled.
...
Bug=http://code.google.com/p/webrtc/issues/detail?id=43
Test=none
Review URL: http://webrtc-codereview.appspot.com/133006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@487 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-30 08:29:07 +00:00
xians@google.com
c9b75e0a4b
removing the warnings from the voe tests.
...
Bug=http://code.google.com/p/webrtc/issues/detail?id=61
Test=None
Review URL: http://webrtc-codereview.appspot.com/139003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@475 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-29 07:30:16 +00:00