Commit Graph

173 Commits

Author SHA1 Message Date
phoglund@webrtc.org
b73f01e7fd Removed some obviously dead stuff from voe_auto_test.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/495001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2081 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-20 10:59:31 +00:00
phoglund@webrtc.org
a36a4bb340 Disabled flaky voe tests.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/491007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2025 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-13 10:11:15 +00:00
tina.legrand@webrtc.org
16b6b90a82 Split of stereo packets moved
In this CL I have rewritten the way we handle stereo packets in VoE.
Before this change we split the packets in the RTP module and added two packets to ACM, one for the left channel and one for the right. This lead to timing problems caused when a different thread called RecOut in between the two calls to add stereo packet to ACM. (RecOut is called to pull audio data, decode packets, on the receiving side).

While doing the change I also took the opportunity to changed some functions so that the data stream is uint8 everywhere.

The list of files in this CL is long, but should be fairly easy to review. It is difficult to see what has been changed  in some of the tests, but I can explain offline.

Reviewers:
Björn - /src/modules/audio_coding
Patrik - /src/modules/rtp_rtcp
Patrik -/src/modules/utility
Henrik A - /src/voice_engine

BUG=410
TEST=voe_cmd_test

Review URL: https://webrtc-codereview.appspot.com/473003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2012 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-12 11:02:38 +00:00
phoglund@webrtc.org
e1bbdb488e Rewrote external media test.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/482002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2007 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-11 14:15:48 +00:00
andrew@webrtc.org
e713fd0eee Enable the "unused variable" warning on Windows.
- Break out direct_show_base_classes to its own gyp file to have it
  treated as third party code.
- Fix the resulting warnings (courtesy of Tommi).

BUG=
TEST=build on Windows (vie_auto_test currently failing at HEAD)

Review URL: https://webrtc-codereview.appspot.com/489001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2000 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-10 07:13:46 +00:00
phoglund@webrtc.org
a1facdcf0f Re-enabled video sync tests (new attempt).
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/478001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1992 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-05 16:59:01 +00:00
tommi@webrtc.org
851becd00c Remove public virtual voe::SharedData inheritance.
This is a fix for coverity issues: 10446, 10445, 10444, 10443.

Although the cl is rather big, there aren't many code changes:

* Instead of an implicit vtable pointer, there is now an explicit |_data| member to access the shared data.
* We don't access the member variables of SharedData directly.  There are accessors instead.
* SharedData setters that set values that must be freed, automatically free the previous value and 'addref' if required the new one.
* Lots and lots of 'rewrapping' due to search/replace after the above changes.

BUG=10446, 10445, 10444, 10443
TEST=Run all tests for VoE.
Review URL: https://webrtc-codereview.appspot.com/472009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1987 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-04 14:57:19 +00:00
niklas.enbom@webrtc.org
06e722ae77 Adding parameter setting for typing detection
Review URL: https://webrtc-codereview.appspot.com/476001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1984 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-04 07:44:27 +00:00
phoglund@webrtc.org
afc39731dc Rewrote NetEQ stats test.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/466002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1982 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-03 23:09:42 +00:00
phoglund@webrtc.org
f3bbc3e5b3 Temporarily disabled new test since it segfaults randomly.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/474002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1972 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-30 23:13:33 +00:00
phoglund@webrtc.org
9b96e02c20 Adjusted the deviation limit since the test seems to fail on the bot.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/471002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1971 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-30 22:20:48 +00:00
phoglund@webrtc.org
b5617869fc Fixed problem with previous commit.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/472002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1970 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-30 21:02:45 +00:00
phoglund@webrtc.org
e5f74bdbbc Rewrote the video sync test.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/463001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1969 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-30 19:51:11 +00:00
niklas.enbom@webrtc.org
3dc886561c Adding time since last typing
Review URL: https://webrtc-codereview.appspot.com/471001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1960 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-30 09:53:54 +00:00
phoglund@webrtc.org
1b1a39fdef Rewrote external encryption test.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/456009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1959 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-29 16:58:35 +00:00
xians@webrtc.org
f35f54bf68 Fix coverity warning.
Review URL: https://webrtc-codereview.appspot.com/465002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1955 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-29 13:59:24 +00:00
braveyao@webrtc.org
d713143d99 To support playing mono file with stereo codec as mixing with microphone capture
BUG=413
TEST=Manual test.
Review URL: https://webrtc-codereview.appspot.com/460004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1953 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-29 10:39:44 +00:00
niklas.enbom@webrtc.org
40197d7b3b Fixing build issus on non-Win
TBR: bjornv
Review URL: https://webrtc-codereview.appspot.com/460005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1940 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-26 08:45:47 +00:00
niklas.enbom@webrtc.org
5398d9583b Force commit of 449006'
Review URL: https://webrtc-codereview.appspot.com/455006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1939 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-26 08:11:25 +00:00
mflodman@webrtc.org
3e820e5109 Remove RTP Keep-alive from VoE and ViE. The RTP module functionality will be removed in a follow-up CL shortly.
TEST=VoE autotest and ViE autotest

Review URL: https://webrtc-codereview.appspot.com/458002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1929 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-23 09:41:44 +00:00
phoglund@webrtc.org
4aa57b4150 Extracted a helper library from vie_auto_test.
This CL does not attempt to fix the style issues in the moved tb_ files, at least not yet. In general I've tried to avoid dependencies between the library and vie_auto_test: vie_auto_test depends on the library but not the other way around. I had to make some slight changes to achieve this. I had to remove some ViETest::Log statements in tb_interfaces.cc and I had to move knowledge of where to put output files to the library. I think it ended up being pretty clean in the end but let me know if I missed something. I tried to convert all paths I touched to src-relative paths, so look out if I missed something there.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/450004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1923 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-22 12:56:54 +00:00
phoglund@webrtc.org
aaf62ac019 Temporarily disabled flaky tests.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/446010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1919 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-21 08:04:43 +00:00
phoglund@webrtc.org
7e26ad3828 Disabled more flaky volume tests.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/451012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1902 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-16 09:46:52 +00:00
henrika@webrtc.org
907bc55c19 Removes WebRtc_Word8 dependecy in the AudioDeviceModule.
This CL also modifies the ADM callback interface and introduces void* instead of WebRtc_Word8*
as pointer types for data buffers. This change also affects the VoiceEngine.
Review URL: https://webrtc-codereview.appspot.com/443001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1863 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-09 08:59:19 +00:00
andrew@webrtc.org
8012474552 Use a const rather than macro for EcDefault.
- This should be a better solution to the build error in
  https://webrtc-codereview.appspot.com/425005
- Ideally all of the similar macros should go away, but one thing at
  a time...

BUG=
TEST=voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/438002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1860 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-08 17:54:24 +00:00
mflodman@webrtc.org
9a065d1eae VoiceEngine now uses pointer constructor of CriticalSectionScoped, instead of reference.
BUG=184
TEST=Compiles on all platforms.

Review URL: https://webrtc-codereview.appspot.com/436001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1853 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-07 08:12:21 +00:00
leozwang@webrtc.org
30185916aa Fix error in test app which was introduced when payload type was converted to int
TBR=mflodman, phoglund
Review URL: https://webrtc-codereview.appspot.com/439004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1851 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-06 21:43:55 +00:00
leozwang@webrtc.org
0975d2158c Cleanup messy data type of unknown_payload_type
BUG=322
TEST=build on all platforms
Review URL: https://webrtc-codereview.appspot.com/430002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1848 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-06 20:59:13 +00:00
andrew@webrtc.org
8b111eb3e6 Reformat voe_audio_processing_impl to Goog style.
TBR=xians@webrtc.org
BUG=
TEST=voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/439003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1847 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-06 19:50:12 +00:00
andrew@webrtc.org
6f9f817e06 Add an API to offset system delay.
Plumb it through VoiceEngine.

BUG=
TEST=voe_auto_test,audioproc_unittest

Review URL: https://webrtc-codereview.appspot.com/428010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1846 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-06 19:03:39 +00:00
leozwang@webrtc.org
53ed5a41a2 Fix building errors and enable test app
TEST=build on all platforms
Review URL: https://webrtc-codereview.appspot.com/428008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1841 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-05 20:15:58 +00:00
leozwang@webrtc.org
e47efe291e Fix building error on android
Review URL: https://webrtc-codereview.appspot.com/425005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1834 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-05 16:05:30 +00:00
andrew@webrtc.org
d62d7301f4 Remove TARGET_PC and cruft from typedefs.h.
Additionally remove all TARGET defines (e.g. TARGET_MAC), which weren't used anyway.

BUG=
TEST=build on Linux, Mac, Win

Review URL: https://webrtc-codereview.appspot.com/432001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1822 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-01 21:39:57 +00:00
andrew@webrtc.org
fa2f5627ca Change error code.
TBR=henrika@webrtc.org
BUG=
TEST=build

Review URL: https://webrtc-codereview.appspot.com/429004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1821 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-01 21:19:01 +00:00
leozwang@webrtc.org
813e4b0af0 Correct WebRtc_Word8 in voice engine
BUG=http://code.google.com/p/webrtc/issues/detail?id=311&sort=-id
TEST=build on all platforms

Review URL: https://webrtc-codereview.appspot.com/425002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1816 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-01 18:34:25 +00:00
andrew@webrtc.org
0e28566247 Only reset AudioProcessing if number of channels has changed.
Calling SetSendCodec() would always reset AudioProcessing.

BUG=
TEST=voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/417002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1799 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-29 17:00:56 +00:00
leozwang@webrtc.org
07c68b9c9d Correct wrong usage of WebRtc_Word8 in rtp and udp module
BUG=http://code.google.com/p/webrtc/issues/detail?id=311&sort=-id
TEST=build on all platforms

Review URL: https://webrtc-codereview.appspot.com/418001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1798 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-29 16:09:51 +00:00
phoglund@webrtc.org
2d124f3d88 Enabled the volume tests we believe are nonflaky and the vie_auto_test extended tests.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/422002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1797 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-29 14:34:06 +00:00
phoglund@webrtc.org
b45ceed9ef Rewrote the call report test.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/399006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1726 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-20 08:55:04 +00:00
leozwang@webrtc.org
a52838b684 Update Android.mk and add test app
Review URL: https://webrtc-codereview.appspot.com/388010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1713 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-17 01:16:43 +00:00
xians@webrtc.org
3ab6dda5cb Truncated the volume to 255 when the users set the volume above 100%.
Allowed the users to set the volume above 100% when AGC is enabled, in this case AGC can gradually scale down the volume instead of jumping to 100% immediately.
Reduced the flakiness of the volume tests in linux.
Review URL: https://webrtc-codereview.appspot.com/387011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1706 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-16 18:15:54 +00:00
braveyao@webrtc.org
59d6cec291 Fix the crash at playing 48kHz stereo wav file.
http://code.google.com/p/webrtc/issues/detail?id=208
Review URL: https://webrtc-codereview.appspot.com/396001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1681 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-14 18:17:16 +00:00
phoglund@webrtc.org
292da24166 New attempt.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/391006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1672 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-10 15:21:33 +00:00
phoglund@webrtc.org
dbe1e13b53 Fixed compilation error on Windows.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/389007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1670 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-10 14:03:44 +00:00
phoglund@webrtc.org
6b3bb89f12 Rewrote file test.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/391004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1668 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-10 12:14:54 +00:00
phoglund@webrtc.org
aaa76f3ba8 Rewrote network test.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/383003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1656 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-09 16:41:30 +00:00
phoglund@webrtc.org
78088c2f36 Removed warnings on Windows and enabled warnings-as-errors on Windows.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/377004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1624 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-07 14:56:45 +00:00
niklas.enbom@webrtc.org
87885e8409 This CL will look a bit strange. Essentially I've removed sanity checks for > 1 channel and then fixed the bugs that remained. Will add testing in a separate CL.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/390001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1623 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-07 14:48:59 +00:00
wu@webrtc.org
06c7dbae14 Disable flaky test AudioProcessingTest.TestVoiceActivityDetectionWithObserver.
BUG=263
TBR=phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/380009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1615 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 23:13:21 +00:00
phoglund@webrtc.org
56b85c6ba8 Reduced potential for flakiness in voice detection tests.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/367024

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1612 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 18:48:33 +00:00