Commit Graph

2608 Commits

Author SHA1 Message Date
stefan@webrtc.org
81ebe38acb Fixing LatestEstimate().
TBR=henrik.lundin@webrtc.org

BUG=

Review URL: https://webrtc-codereview.appspot.com/865005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2877 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-05 08:45:25 +00:00
henrik.lundin@webrtc.org
25fadd74d0 Fix dummy RTP playout in NetEqRTPplay
Make sure that playing dummy RTP files works, i.e., RTP dumps with only
headers, no actual payloads. It turs out that some RTP dumps did not
state how long the actual packet was (including the discarded payload),
which resulted in packets with zero length payload being inserted into
NetEQ. Now, the dummy packet will contain at least one byte of payload
(set to zero).

Also added capability to filter out a specific SSRC from the RTP
dump file.

Finally, added SSRC printout from RTPanalyze, and corresponding
change in RTPchange.

TEST=trybots

Review URL: https://webrtc-codereview.appspot.com/857007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2876 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-05 08:34:37 +00:00
henrik.lundin@webrtc.org
3df18d72ba Added test for NetEQ stereo with no input
This test verifies that NetEQ behaves as it should when using
stereo and not inserting any data before calling recout. The
main purpose of the test is to find memory issues.

BUG=http://code.google.com/p/webrtc/issues/detail?id=270
TEST=trybots, neteq_unittests

Review URL: https://webrtc-codereview.appspot.com/863010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2875 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-05 08:23:32 +00:00
stefan@webrtc.org
b0a8a3bfdd Return bw_estimate / num-streams from the multi-stream estimator for now until updating ViE APIs.
BUG=

Review URL: https://webrtc-codereview.appspot.com/842006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2874 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-05 08:15:37 +00:00
kma@webrtc.org
6679dcc6c5 Fixed a bug in an Android macro definition in SPL that caused issue 833.
Review URL: https://webrtc-codereview.appspot.com/863007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2873 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-05 00:27:10 +00:00
kma@webrtc.org
ac4d70de04 Moved calling points of spl_int routines from module init to module create routines.
Review URL: https://webrtc-codereview.appspot.com/789006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2872 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-05 00:19:01 +00:00
mikhal@webrtc.org
3f9a721da5 Adding SSIM and PSNR videoFrame based functions
Review URL: https://webrtc-codereview.appspot.com/867005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2871 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-04 17:22:32 +00:00
leozwang@webrtc.org
f9a0713866 Make Android.mk to be able to inclucde subfolder makefiles
BUG=None
TEST=trybot
Review URL: https://webrtc-codereview.appspot.com/868006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2870 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-04 15:59:11 +00:00
leozwang@webrtc.org
2a84f63719 Rename android file name
Rename file name to follow code style.

BUG=None
TEST=trybots
Review URL: https://webrtc-codereview.appspot.com/867004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2869 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-03 21:40:06 +00:00
kma@webrtc.org
0a4cdc40fc Made CrossCorrelationTest valid in ARM-Neon platforms, with changes in signal_processing_unittest.cc.
Review URL: https://webrtc-codereview.appspot.com/828006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2868 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-03 21:15:39 +00:00
stefan@webrtc.org
4bfe990337 Remove unused files from gypi.
TBR=wu

BUG=

Review URL: https://webrtc-codereview.appspot.com/863008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2867 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-03 19:58:50 +00:00
henrike@webrtc.org
46d4073a64 Made the aligned malloc templated.
BUG=N/A

Review URL: https://webrtc-codereview.appspot.com/865004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2866 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-03 16:50:37 +00:00
wu@webrtc.org
2e5192fa6a Add peerconnection_all.gyp to include everything.
Add a dummy peerconnection_client target for mac so that we don't get an error when doing runhooks.
Review URL: https://webrtc-codereview.appspot.com/855005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2865 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-03 16:35:45 +00:00
mikhal@webrtc.org
60ac6a642a Updates to videoFrame:
1. Adding non-const members.
2. Updating copy interface.

Review URL: https://webrtc-codereview.appspot.com/866005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2864 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-03 16:24:14 +00:00
leozwang@webrtc.org
aee9120409 Move video android test to test folder
BUG=N/A
TEST=local test
Review URL: https://webrtc-codereview.appspot.com/863005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2862 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-02 20:13:56 +00:00
henrike@webrtc.org
28625c1af3 Updates according to style guide.
BUG=N/A

Review URL: https://webrtc-codereview.appspot.com/864004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2861 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-02 15:38:35 +00:00
phoglund@webrtc.org
4743f938d6 Added more suppressions.
These tests are really flaky for sure. None of these showed up locally or in previous runs.

BUG=
TBR=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/863006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2860 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-02 09:22:51 +00:00
phoglund@webrtc.org
321da3bc4f Added more suppressions found on the bot.
I will look over and split them into different bugs later - seems a bad idea to use one bug for everything.

BUG=
TBR=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/861005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2859 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-02 08:54:45 +00:00
mikhal@webrtc.org
1e033e1594 Updating ConvertFromI420 to use VideoFrame - Related calls to DeliverFrame were also updated, and some refactoring (style-wise) was done on the way.
Review URL: https://webrtc-codereview.appspot.com/838006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2858 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-01 20:09:32 +00:00
fbarchard@google.com
cc82cff82e libyuv roll r389 for mac visibility, Q420 and YUY2 optimization, AVX2 detect.
BUG=none
TEST=none
Review URL: https://webrtc-codereview.appspot.com/858004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2857 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-01 18:32:41 +00:00
leozwang@webrtc.org
3632ca1c6e Make thread name readable in log
Shorten thread name to make more readable when run top on android
Review URL: https://webrtc-codereview.appspot.com/851006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2856 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-01 17:58:32 +00:00
phoglund@webrtc.org
4fdc102f03 Added suppression for one missed error.
BUG=
TBR=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/862004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2855 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-01 14:53:30 +00:00
phoglund@webrtc.org
8ff3ff1a8b Made ViE standard tests runnable under valgrind.
Ensured there are bugs for all open valgrind issues in the standard tests and suppressed the known issues. This way, we can get it running in continuous integration and keep new issues from entering.

Removed bad check in codec test, added suppressions.

Fixed simple memory leaks in tests.

BUG=Related to bug 329
TEST=Ran the vie_auto_test standard suite many times under valgrind to root out flakiness. Ran the standard suite without valgrind to ensure I didn't break anything.

Review URL: https://webrtc-codereview.appspot.com/843005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2854 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-01 10:04:26 +00:00
fbarchard@google.com
133f5d06aa libyuv roll to r381 for I422ToRGBA
BUG=none
TEST=libyuv unittest
Review URL: https://webrtc-codereview.appspot.com/820007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2853 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-30 19:25:38 +00:00
wu@webrtc.org
d515d3fc73 Add jsoncpp as the peerconnection_client dependency for windows.
BUG=865
Review URL: https://webrtc-codereview.appspot.com/849007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2852 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-29 20:36:01 +00:00
henrike@webrtc.org
cd9adf7ae3 This cl adds an API for getting an aligned pointer from a pointer to memory. Also adds a short-hand for creating scoped pointers of aligned memory.
BUG=N/A

Review URL: https://webrtc-codereview.appspot.com/849006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2851 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-29 03:49:36 +00:00
mikhal@webrtc.org
2a476e9c95 Switching scale functions to use VideoFrame.
Review URL: https://webrtc-codereview.appspot.com/852004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2849 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-28 19:47:23 +00:00
kma@webrtc.org
507146c56c Changed alignment code in AECM, to work with an issue in GCC 4.6 in Android.
Review URL: https://webrtc-codereview.appspot.com/841009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2848 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-28 17:14:08 +00:00
mikhal@webrtc.org
c7ecc11571 Switching to a general align function.
Review URL: https://webrtc-codereview.appspot.com/851005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2847 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-28 16:07:10 +00:00
kjellander@webrtc.org
d1e7a9a90c ThreadSanitizer and Dr Memory for Windows
Added new wrapper script webrtc_tests.bat for executing memory/threading tests on Windows.
Updated webrtc_tests.sh to include modifications in chrome_tests.sh that has happened since we copied it.

To setup TSAN for Windows, see http://www.chromium.org/developers/how-tos/using-valgrind/threadsanitizer
I did like this:
1. Added "third_party/tsan": "http://src.chromium.org/chrome/trunk/deps/third_party/tsan"
to custom_deps in my .gclient file
2. gclient sync
3. SET GYP_DEFINES=build_with_tool=tsan && gclient runhooks
4. Compiled.
5. Ran the test using the wrapper script (see below).

To setup Dr Memory for Windows, see http://www.chromium.org/developers/how-tos/using-drmemory
I did like this:
1. Added "third_party/drmemory": "http://src.chromium.org/svn/trunk/deps/third_party/drmemory",
to custom_deps in my .gclient file (using the drmemory.DEPS as described on Chromium's wiki ends up in the wrong location)
2. gclient sync
3. SET GYP_DEFINES=build_with_tool=drmemory && gclient runhooks
4. Compiled.
5. Ran the test using the wrapper script (see below).


TEST=
On Windows: 
tools\valgrind-webrtc\webrtc_tests.bat --tool=tsan --test build\Debug\voice_engine_unittests.exe
tools\valgrind-webrtc\webrtc_tests.bat --tool=drmemory_light --test build\Debug\voice_engine_unittests.exe
tools\valgrind-webrtc\webrtc_tests.bat --tool=drmemory_full --test build\Debug\voice_engine_unittests.exe
On Linux: 
tools/valgrind-webrtc/webrtc_tests.sh --tool=memcheck --test out/Release/test_support_unittests
tools/valgrind-webrtc/webrtc_tests.sh --tool=tsan --test out/Release/test_support_unittests
tools/valgrind-webrtc/webrtc_tests.sh --tool=asan --test out/Release/test_support_unittests
Review URL: https://webrtc-codereview.appspot.com/845004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2846 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-28 15:34:18 +00:00
kjellander@webrtc.org
1101278a17 Wider suppression filter for tz-warnings in TSAN
This catches the remaining warnings we see which it seems like the fun:__tz* suppression in Chromium's tools/valgrind/tsan/suppressions.txt file is aimed for.

BUG=884

Review URL: https://webrtc-codereview.appspot.com/841006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2845 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-28 15:30:58 +00:00
mflodman@webrtc.org
953368bf73 Remove unused video tests.
Review URL: https://webrtc-codereview.appspot.com/841010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2843 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-28 12:34:25 +00:00
mflodman@webrtc.org
7cf8121a52 Fix signed/unsigned mis-match.
TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/854004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2842 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-28 11:44:38 +00:00
mflodman@webrtc.org
f4f2145c6e Added API to set expected render delay.
BUG=905
TEST=API test added and manual delay tests.

Review URL: https://webrtc-codereview.appspot.com/810005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2841 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-28 11:27:35 +00:00
stefan@webrtc.org
a30eb31729 Make sure FEC packets aren't passed to the VCM with non-zero length.
BUG=902

Review URL: https://webrtc-codereview.appspot.com/843007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2840 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-28 11:13:08 +00:00
tina.legrand@webrtc.org
95c2364d2f Memory error in cng_unittest
Review URL: https://webrtc-codereview.appspot.com/845008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2839 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-28 10:49:59 +00:00
stefan@webrtc.org
1ca4bf97ff Remove unneccessary includes.
BUG=

Review URL: https://webrtc-codereview.appspot.com/853005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2838 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-28 08:26:00 +00:00
tina.legrand@webrtc.org
a4f9ba6a3f Refactor and unittest for CNG.
Patch Set 1:
- Formatted file.
- Fixed format of comments.
- Removed:
  - WebRtcCng_Version,
  - WebRtcCng_AssignSizeEnc
  - WebRtcCng_AssignSizeDec.
- Changed type of input variable |fs| in WebRtcCng_InitEnc
  to unsigned.
- Added extra check in WebRtcCng_CreateEnc and
  WebRtcCng_CreateDec.
- Added extra check in WebRtcCng_InitEnc for |quality|.
- Removed () on return values.

Patch Set 2:
- Formatted cng_helpfunc.*.
- Added tests for Encoder.
- Added calls to WebRtcSpl_Init();

Patch Set 3:
- Added tests for WebRtcCng_UpdateSid.
- Added tests for WebRtcCng_Generate.

Patch Set 4:
- More comments.
- Re-ordered some lines.
- Adding calls to WebRtcCng_GetErrorCodeEnc and WebRtcCng_GetErrorCodeDec.

TEST=cng_unittests

Review URL: https://webrtc-codereview.appspot.com/822004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2837 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-28 07:12:00 +00:00
henrike@webrtc.org
9a6dac4193 Re-fixes issue 300.
BUG=300

Review URL: https://webrtc-codereview.appspot.com/839007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2835 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-27 22:20:34 +00:00
mikhal@webrtc.org
2338131274 Switching Mirror functions to VideoFrame
Review URL: https://webrtc-codereview.appspot.com/834005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2834 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-27 15:36:15 +00:00
kjellander@webrtc.org
0d7eaaa166 Ignoring Android NDK build output
BUG=

Review URL: https://webrtc-codereview.appspot.com/841008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2833 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-27 14:14:53 +00:00
stefan@webrtc.org
c9cc41ac9c Remove unneccessary include.
BUG=

Review URL: https://webrtc-codereview.appspot.com/838007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2832 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-27 10:56:05 +00:00
stefan@webrtc.org
a3a230f2cb Fixes potential race in the jitter buffer.
BUG=879

Review URL: https://webrtc-codereview.appspot.com/845007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2831 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-27 10:00:38 +00:00
phoglund@webrtc.org
e8ebbdad09 Removed branch coverage since it turned out to be essentially useless as a metric.
BUG=

Review URL: https://webrtc-codereview.appspot.com/812006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2830 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-27 09:27:08 +00:00
stefan@webrtc.org
64d9decc8d Move RtpToNtp functionality to its own file.
Removes the dependency on VideoEngine from RemoteBitrateEstimator.

BUG=

Review URL: https://webrtc-codereview.appspot.com/850004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2828 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-26 16:47:40 +00:00
perkj@webrtc.org
d162cd1d1f Revert 2823 - Protects the file class with rw-locks.
This change causes failure in voe_auto_test.
BUG=300

Review URL: https://webrtc-codereview.appspot.com/841004

TBR=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/839006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2826 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-26 09:07:06 +00:00
asapersson@webrtc.org
a8d2a81423 Renamed constant and added comments.
Review URL: https://webrtc-codereview.appspot.com/847004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2825 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-26 07:51:16 +00:00
elham@webrtc.org
db6eca446d updating version number to 3.13
Review URL: https://webrtc-codereview.appspot.com/842004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2824 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-25 21:53:25 +00:00
henrike@webrtc.org
4d91a12ba0 Protects the file class with rw-locks.
BUG=300

Review URL: https://webrtc-codereview.appspot.com/841004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2823 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-25 21:49:33 +00:00
henrike@webrtc.org
9f84723725 Some style fixes.
Refactors the rw lock implementation.

BUG=N/A

Review URL: https://webrtc-codereview.appspot.com/797004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2822 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-25 20:27:51 +00:00