Commit Graph

2593 Commits

Author SHA1 Message Date
henrike@webrtc.org
28625c1af3 Updates according to style guide.
BUG=N/A

Review URL: https://webrtc-codereview.appspot.com/864004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2861 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-02 15:38:35 +00:00
phoglund@webrtc.org
4743f938d6 Added more suppressions.
These tests are really flaky for sure. None of these showed up locally or in previous runs.

BUG=
TBR=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/863006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2860 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-02 09:22:51 +00:00
phoglund@webrtc.org
321da3bc4f Added more suppressions found on the bot.
I will look over and split them into different bugs later - seems a bad idea to use one bug for everything.

BUG=
TBR=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/861005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2859 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-02 08:54:45 +00:00
mikhal@webrtc.org
1e033e1594 Updating ConvertFromI420 to use VideoFrame - Related calls to DeliverFrame were also updated, and some refactoring (style-wise) was done on the way.
Review URL: https://webrtc-codereview.appspot.com/838006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2858 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-01 20:09:32 +00:00
fbarchard@google.com
cc82cff82e libyuv roll r389 for mac visibility, Q420 and YUY2 optimization, AVX2 detect.
BUG=none
TEST=none
Review URL: https://webrtc-codereview.appspot.com/858004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2857 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-01 18:32:41 +00:00
leozwang@webrtc.org
3632ca1c6e Make thread name readable in log
Shorten thread name to make more readable when run top on android
Review URL: https://webrtc-codereview.appspot.com/851006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2856 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-01 17:58:32 +00:00
phoglund@webrtc.org
4fdc102f03 Added suppression for one missed error.
BUG=
TBR=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/862004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2855 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-01 14:53:30 +00:00
phoglund@webrtc.org
8ff3ff1a8b Made ViE standard tests runnable under valgrind.
Ensured there are bugs for all open valgrind issues in the standard tests and suppressed the known issues. This way, we can get it running in continuous integration and keep new issues from entering.

Removed bad check in codec test, added suppressions.

Fixed simple memory leaks in tests.

BUG=Related to bug 329
TEST=Ran the vie_auto_test standard suite many times under valgrind to root out flakiness. Ran the standard suite without valgrind to ensure I didn't break anything.

Review URL: https://webrtc-codereview.appspot.com/843005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2854 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-01 10:04:26 +00:00
fbarchard@google.com
133f5d06aa libyuv roll to r381 for I422ToRGBA
BUG=none
TEST=libyuv unittest
Review URL: https://webrtc-codereview.appspot.com/820007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2853 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-30 19:25:38 +00:00
wu@webrtc.org
d515d3fc73 Add jsoncpp as the peerconnection_client dependency for windows.
BUG=865
Review URL: https://webrtc-codereview.appspot.com/849007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2852 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-29 20:36:01 +00:00
henrike@webrtc.org
cd9adf7ae3 This cl adds an API for getting an aligned pointer from a pointer to memory. Also adds a short-hand for creating scoped pointers of aligned memory.
BUG=N/A

Review URL: https://webrtc-codereview.appspot.com/849006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2851 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-29 03:49:36 +00:00
mikhal@webrtc.org
2a476e9c95 Switching scale functions to use VideoFrame.
Review URL: https://webrtc-codereview.appspot.com/852004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2849 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-28 19:47:23 +00:00
kma@webrtc.org
507146c56c Changed alignment code in AECM, to work with an issue in GCC 4.6 in Android.
Review URL: https://webrtc-codereview.appspot.com/841009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2848 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-28 17:14:08 +00:00
mikhal@webrtc.org
c7ecc11571 Switching to a general align function.
Review URL: https://webrtc-codereview.appspot.com/851005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2847 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-28 16:07:10 +00:00
kjellander@webrtc.org
d1e7a9a90c ThreadSanitizer and Dr Memory for Windows
Added new wrapper script webrtc_tests.bat for executing memory/threading tests on Windows.
Updated webrtc_tests.sh to include modifications in chrome_tests.sh that has happened since we copied it.

To setup TSAN for Windows, see http://www.chromium.org/developers/how-tos/using-valgrind/threadsanitizer
I did like this:
1. Added "third_party/tsan": "http://src.chromium.org/chrome/trunk/deps/third_party/tsan"
to custom_deps in my .gclient file
2. gclient sync
3. SET GYP_DEFINES=build_with_tool=tsan && gclient runhooks
4. Compiled.
5. Ran the test using the wrapper script (see below).

To setup Dr Memory for Windows, see http://www.chromium.org/developers/how-tos/using-drmemory
I did like this:
1. Added "third_party/drmemory": "http://src.chromium.org/svn/trunk/deps/third_party/drmemory",
to custom_deps in my .gclient file (using the drmemory.DEPS as described on Chromium's wiki ends up in the wrong location)
2. gclient sync
3. SET GYP_DEFINES=build_with_tool=drmemory && gclient runhooks
4. Compiled.
5. Ran the test using the wrapper script (see below).


TEST=
On Windows: 
tools\valgrind-webrtc\webrtc_tests.bat --tool=tsan --test build\Debug\voice_engine_unittests.exe
tools\valgrind-webrtc\webrtc_tests.bat --tool=drmemory_light --test build\Debug\voice_engine_unittests.exe
tools\valgrind-webrtc\webrtc_tests.bat --tool=drmemory_full --test build\Debug\voice_engine_unittests.exe
On Linux: 
tools/valgrind-webrtc/webrtc_tests.sh --tool=memcheck --test out/Release/test_support_unittests
tools/valgrind-webrtc/webrtc_tests.sh --tool=tsan --test out/Release/test_support_unittests
tools/valgrind-webrtc/webrtc_tests.sh --tool=asan --test out/Release/test_support_unittests
Review URL: https://webrtc-codereview.appspot.com/845004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2846 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-28 15:34:18 +00:00
kjellander@webrtc.org
1101278a17 Wider suppression filter for tz-warnings in TSAN
This catches the remaining warnings we see which it seems like the fun:__tz* suppression in Chromium's tools/valgrind/tsan/suppressions.txt file is aimed for.

BUG=884

Review URL: https://webrtc-codereview.appspot.com/841006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2845 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-28 15:30:58 +00:00
mflodman@webrtc.org
953368bf73 Remove unused video tests.
Review URL: https://webrtc-codereview.appspot.com/841010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2843 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-28 12:34:25 +00:00
mflodman@webrtc.org
7cf8121a52 Fix signed/unsigned mis-match.
TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/854004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2842 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-28 11:44:38 +00:00
mflodman@webrtc.org
f4f2145c6e Added API to set expected render delay.
BUG=905
TEST=API test added and manual delay tests.

Review URL: https://webrtc-codereview.appspot.com/810005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2841 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-28 11:27:35 +00:00
stefan@webrtc.org
a30eb31729 Make sure FEC packets aren't passed to the VCM with non-zero length.
BUG=902

Review URL: https://webrtc-codereview.appspot.com/843007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2840 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-28 11:13:08 +00:00
tina.legrand@webrtc.org
95c2364d2f Memory error in cng_unittest
Review URL: https://webrtc-codereview.appspot.com/845008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2839 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-28 10:49:59 +00:00
stefan@webrtc.org
1ca4bf97ff Remove unneccessary includes.
BUG=

Review URL: https://webrtc-codereview.appspot.com/853005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2838 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-28 08:26:00 +00:00
tina.legrand@webrtc.org
a4f9ba6a3f Refactor and unittest for CNG.
Patch Set 1:
- Formatted file.
- Fixed format of comments.
- Removed:
  - WebRtcCng_Version,
  - WebRtcCng_AssignSizeEnc
  - WebRtcCng_AssignSizeDec.
- Changed type of input variable |fs| in WebRtcCng_InitEnc
  to unsigned.
- Added extra check in WebRtcCng_CreateEnc and
  WebRtcCng_CreateDec.
- Added extra check in WebRtcCng_InitEnc for |quality|.
- Removed () on return values.

Patch Set 2:
- Formatted cng_helpfunc.*.
- Added tests for Encoder.
- Added calls to WebRtcSpl_Init();

Patch Set 3:
- Added tests for WebRtcCng_UpdateSid.
- Added tests for WebRtcCng_Generate.

Patch Set 4:
- More comments.
- Re-ordered some lines.
- Adding calls to WebRtcCng_GetErrorCodeEnc and WebRtcCng_GetErrorCodeDec.

TEST=cng_unittests

Review URL: https://webrtc-codereview.appspot.com/822004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2837 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-28 07:12:00 +00:00
henrike@webrtc.org
9a6dac4193 Re-fixes issue 300.
BUG=300

Review URL: https://webrtc-codereview.appspot.com/839007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2835 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-27 22:20:34 +00:00
mikhal@webrtc.org
2338131274 Switching Mirror functions to VideoFrame
Review URL: https://webrtc-codereview.appspot.com/834005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2834 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-27 15:36:15 +00:00
kjellander@webrtc.org
0d7eaaa166 Ignoring Android NDK build output
BUG=

Review URL: https://webrtc-codereview.appspot.com/841008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2833 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-27 14:14:53 +00:00
stefan@webrtc.org
c9cc41ac9c Remove unneccessary include.
BUG=

Review URL: https://webrtc-codereview.appspot.com/838007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2832 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-27 10:56:05 +00:00
stefan@webrtc.org
a3a230f2cb Fixes potential race in the jitter buffer.
BUG=879

Review URL: https://webrtc-codereview.appspot.com/845007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2831 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-27 10:00:38 +00:00
phoglund@webrtc.org
e8ebbdad09 Removed branch coverage since it turned out to be essentially useless as a metric.
BUG=

Review URL: https://webrtc-codereview.appspot.com/812006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2830 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-27 09:27:08 +00:00
stefan@webrtc.org
64d9decc8d Move RtpToNtp functionality to its own file.
Removes the dependency on VideoEngine from RemoteBitrateEstimator.

BUG=

Review URL: https://webrtc-codereview.appspot.com/850004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2828 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-26 16:47:40 +00:00
perkj@webrtc.org
d162cd1d1f Revert 2823 - Protects the file class with rw-locks.
This change causes failure in voe_auto_test.
BUG=300

Review URL: https://webrtc-codereview.appspot.com/841004

TBR=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/839006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2826 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-26 09:07:06 +00:00
asapersson@webrtc.org
a8d2a81423 Renamed constant and added comments.
Review URL: https://webrtc-codereview.appspot.com/847004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2825 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-26 07:51:16 +00:00
elham@webrtc.org
db6eca446d updating version number to 3.13
Review URL: https://webrtc-codereview.appspot.com/842004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2824 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-25 21:53:25 +00:00
henrike@webrtc.org
4d91a12ba0 Protects the file class with rw-locks.
BUG=300

Review URL: https://webrtc-codereview.appspot.com/841004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2823 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-25 21:49:33 +00:00
henrike@webrtc.org
9f84723725 Some style fixes.
Refactors the rw lock implementation.

BUG=N/A

Review URL: https://webrtc-codereview.appspot.com/797004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2822 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-25 20:27:51 +00:00
phoglund@webrtc.org
b6cceb8b92 Added location.reload() insertion to fuzzer.
BUG=

Review URL: https://webrtc-codereview.appspot.com/833005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2821 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-25 12:53:58 +00:00
mikhal@webrtc.org
2f4ff89a90 A step forward toward switching WebRtc to the new VideoFrame.
Review URL: https://webrtc-codereview.appspot.com/818005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2820 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-24 21:09:54 +00:00
mikhal@webrtc.org
0e6f597eb0 Adding NumOfPlanes to PlaneTypes.
Review URL: https://webrtc-codereview.appspot.com/837004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2819 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-24 20:35:40 +00:00
leozwang@webrtc.org
66ddf72a72 Correct filename which is missed in r2815
TBR=wu
BUG=None
TEST=try bot
Review URL: https://webrtc-codereview.appspot.com/833007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2817 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-24 19:16:15 +00:00
mikhal@webrtc.org
6e2e0b8ed2 Reverting r2812
TBR=mflodman
Review URL: https://webrtc-codereview.appspot.com/829007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2816 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-24 19:14:40 +00:00
leozwang@webrtc.org
e4ba864368 Fix building error and rename java class name
1. Fix building error because of r2804
2. Rename java class name to WebRTCAudioDevice, so it's more meaningful
to 3rd party devleoper

BUG=None
TEST=try bots
Review URL: https://webrtc-codereview.appspot.com/821006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2815 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-24 18:46:05 +00:00
marpan@webrtc.org
81f09d709e Roll libvpx to get changes/fix to cyclic refresh.
Review URL: https://webrtc-codereview.appspot.com/835004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2814 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-24 18:06:42 +00:00
mflodman@webrtc.org
f2c750deee Hooking up EncoderStateFeedback to handle intra requests instead of trigger
ViEEncoder directly. This is one step towards adding send- and receive only
channels and getting rid of the default module.

BUG=769

Review URL: https://webrtc-codereview.appspot.com/824004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2812 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-24 16:20:47 +00:00
marpan@webrtc.org
76962b8ce9 Update to video_codecs_integrationtest:
-Removed a TODO regarding key frame size (fixed in libvpx)
-Changed a few parameters in the tests.
Review URL: https://webrtc-codereview.appspot.com/827006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2811 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-24 15:13:40 +00:00
stefan@webrtc.org
2dcbcc147b Changing two asserts which should have returned errors instead.
BUG=

Review URL: https://webrtc-codereview.appspot.com/827007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2810 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-24 15:13:30 +00:00
asapersson@webrtc.org
23fd559bcd Increased bytes per interval factor. Added limits for the delay between packets.
Review URL: https://webrtc-codereview.appspot.com/828005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2809 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-24 12:07:13 +00:00
asapersson@webrtc.org
ce42ace6ed Added initial fec configuration for rtp module.
Review URL: https://webrtc-codereview.appspot.com/833004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2808 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-24 11:33:49 +00:00
phoglund@webrtc.org
69d46b4821 Added basic fuzzer for new API and made both work.
Added a nice mode, cleaned up.

BUG=

Review URL: https://webrtc-codereview.appspot.com/832004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2807 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-24 07:44:02 +00:00
leozwang@webrtc.org
60c741281d Simplify SetLoudSpeaker calls and add a function to receive plug intent
Remove reduntant calls and add a function to receive plug intent.

BUG=None
TEST=local

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2806 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-24 07:06:40 +00:00
kjellander@webrtc.org
31b61b5fb6 Updating Android demo app src path for audio_device
Due to source files moved in r2804, the build.xml needed to be updated.

TBR=leozwang
TEST=AndroidNDK trybot
BUG=none

Review URL: https://webrtc-codereview.appspot.com/822005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2805 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-22 22:06:32 +00:00