Luca Boccassi
211898d243
Problem: epoll leaks socket on fork+exec
...
Solution: if available, use epoll_create1 with EPOLL_CLOEXEC flag to
make the process close the socket on fork+exec
2016-12-26 19:08:27 +01:00
Constantin Rack
16439e42d2
Merge pull request #2272 from bluca/document_read_after_free
2016-12-26 15:24:44 +01:00
Constantin Rack
d68e2e018e
Merge pull request #2273 from bluca/docs
2016-12-26 15:12:40 +01:00
Luca Boccassi
3dc016cab3
Problem: no documentation for ZMQ_SOCKS_PROXY
...
Solution: add paragraphs to zmq_get/setsockopt man pages
2016-12-26 14:54:58 +01:00
Luca Boccassi
baf32a1985
Problem: no documentation for zmq_curve_public
...
Solution: add manpage
2016-12-26 14:54:58 +01:00
Luca Boccassi
a06f97d73a
Problem: fix for read-after-free not documented
...
Solution: add a comment as it's easy to miss and very tempting to
"optimize"
2016-12-25 18:01:55 +01:00
Luca Boccassi
dc39ceb347
Merge pull request #2268 from imkos/master
...
Mingw32 Compile
2016-12-22 13:55:03 +01:00
Kos
43941052a9
add link libsodium.a
2016-12-22 14:25:00 +08:00
Kos
edad90f770
mingw32 fix
2016-12-22 09:35:49 +08:00
Luca Boccassi
fe3756defa
Merge pull request #2266 from Cziken/master
...
Problem: Duplicated code
2016-12-19 18:07:37 +01:00
Wojciech Kula
ee72493e14
Problem: Duplicated code
...
Solution: set_curve_key method in options_t struct with little
improvement in switch-case block
2016-12-19 12:13:14 +01:00
Constantin Rack
7a8180ece7
Merge pull request #2265 from bluca/contribution_notice_github
...
Problem: contributing guidelines unclear for new devs
2016-12-18 16:52:15 +01:00
Luca Boccassi
e6b1f56131
Problem: contributing guidelines unclear for new devs
...
Solution: port Github PR template from CZMQ
2016-12-18 11:46:08 +00:00
Constantin Rack
2dec320b22
Merge pull request #2263 from bluca/revert_curve_break
2016-12-16 18:12:37 +01:00
Luca Boccassi
48e9e24726
Problem: #2262 broke curve
...
Solution: Revert "Problem: Duplicated code"
This reverts commit 022eeaf33d
.
2016-12-16 16:50:17 +00:00
Constantin Rack
2aa09d34ff
Merge pull request #2262 from Cziken/master
...
Problem: Duplicated code
2016-12-16 17:32:27 +01:00
Wojciech Kula
022eeaf33d
Problem: Duplicated code
...
Solution: set_curve_key method in options_t struct with little
improvement in switch-case block
2016-12-16 17:09:53 +01:00
Cziken
d514bb598a
Fixed handling of WSAEWOULDBLOCK to be generic ( #2260 )
...
* Fixed handling of WSAEWOULDBLOCK to be generic
I don't know what was the intention of this early if statement but
now this is properly evaluated in wsa_error_no function if this is
performance issue I suggest moving evaluating this error code to the
beginning of wsa_error_no.
* Fixed handling of WSAEWOULDBLOCK to be generic
Introduced default pointer to const char * and overrides this as NULL
if function is called by zmq::wsa_error()
* Fixed handling of WSAEWOULDBLOCK to be generic
Introduced default pointer to const char * and overrides this as NULL
if function is called by zmq::wsa_error()
2016-12-16 15:51:00 +01:00
Luca Boccassi
2b565088d0
Merge pull request #2257 from minrk/check-event
...
zmq_poll: only compare FD when neither item is a zmq socket
2016-12-15 14:20:46 +01:00
Min RK
0abdc28c84
only compare FD when neither item is a zmq socket
2016-12-15 14:05:40 +01:00
Luca Boccassi
1910ef8d3e
Merge pull request #2256 from laplaceyang/pr_zmq4_pub_with_zmtp_v1_sub
...
fix bug zmq4.x PUB msg to ZMTP1.0 SUB server
2016-12-15 14:02:50 +01:00
Min RK
02a6079968
Merge pull request #2255 from bluca/poll_fd_testcase
...
Problem: no mixed FD and zmq socket zmq_poll test
2016-12-15 13:39:20 +01:00
laplaceyang
8e8fdcc9ed
fix bug zmq4.x PUB msg to ZMTP1.0 SUB server
2016-12-15 20:29:58 +08:00
Luca Boccassi
272d340c1f
Problem: no mixed FD and zmq socket zmq_poll test
...
Solution: add one
2016-12-15 12:03:48 +00:00
Luca Boccassi
f9d231437a
Merge pull request #2251 from hnwyllmm/master
...
misuse of 'close'
2016-12-13 12:43:07 +01:00
Laughing
a4e448d586
misuse of 'close'
...
use 'pollset_destroy' instead of 'close' to release pollset_fd
2016-12-13 11:09:01 +08:00
Constantin Rack
9052862619
Merge pull request #2250 from bluca/poll_regression
...
Problem: check for item.fd causes zloop_poller regression
2016-12-11 07:51:31 +01:00
Luca Boccassi
72176d5fbe
Problem: check for item.fd causes zloop_poller regression
...
Solution: fix the check for the socket.
This regression happens when using zloop with zmq_pollitem_it with
only file descriptors registerted through zloop_poller.
2016-12-10 23:49:18 +00:00
Luca Boccassi
c47e017bdd
Merge pull request #2249 from pavel-pimenov/fix-v817
...
"%" -> '%'
2016-12-10 16:01:38 +01:00
pavel.pimenov
4d6fbe17e0
"%" -> '%'
2016-12-10 17:27:42 +03:00
Luca Boccassi
39947d55c7
Merge pull request #2248 from pavel-pimenov/fix-precompiled
...
Add #include "precompiled.hpp"
2016-12-10 14:57:14 +01:00
pavel.pimenov
eff42fa321
Add #include "precompiled.hpp"
2016-12-10 16:44:51 +03:00
Constantin Rack
f64d3ad1e7
Merge pull request #2247 from bluca/trusty_unwind
...
Problem: there is no libunwind-dev on Ubuntu 14.04LTS
2016-12-09 20:57:01 +01:00
Luca Boccassi
379028fbd9
Problem: there is no libunwind-dev on Ubuntu 14.04LTS
...
Solution: depend on libunwind-dev | libunwind8-dev | libunwind7-dev
2016-12-09 18:42:19 +00:00
Luca Boccassi
ad4a1bd0f3
Merge pull request #2245 from anass-b/builds-vs2017
...
Build support for VS2017, Windows SDK 10.0.14393.0, toolset v141
2016-12-09 10:41:07 +01:00
Anass Bouassaba
ad045512b9
Build support for VS2017, Windows SDK 10.0.14393.0, toolset v141
2016-12-09 09:21:11 +01:00
Luca Boccassi
d4076578a3
Merge pull request #2244 from rotty/wip/fix-mstcpip-include
...
Fix #include case for <mstcpip.h>
2016-12-08 16:50:03 +01:00
Andreas Rottmann
365ca8595d
Fix #include case for <mstcpip.h>
...
On native Windows, the file system is case-insensitive, so this this
doesn't matter there.
However, when compiling on a case-sensitive filesystem, such as when
cross-compiling from a Unixoid using mingw, we have to use the case
the file is supplied with, which is all lowercase.
2016-12-08 16:35:44 +01:00
Constantin Rack
519940d07c
Merge pull request #2241 from bluca/aix_test
...
Problem: test_stream_exceeds_buffer fails to build on AIX
2016-12-07 05:46:34 +01:00
Luca Boccassi
dcec022358
Problem: test_stream_exceeds_buffer does not build on AIX
...
Solution: add missing includes
2016-12-06 20:34:10 +00:00
Luca Boccassi
8325355d73
Problem: test_stream_exceeds_buffer has redundant includes
...
Solution: remove them as they are already in testutil.hpp
2016-12-06 20:33:46 +00:00
Constantin Rack
5e03ad6d87
Merge pull request #2240 from bluca/aix_poll
...
Problem: 4.2.0 won't compile on AIX 7.1
2016-12-06 19:34:20 +01:00
Luca Boccassi
57db5f2a5c
Problem: 4.2.0 won't compile on AIX 7.1
...
Solution: restore inclusion of poll.h if using poll before zmq.h as
it was originally, as AIX redefines the POSIX structures and provides
compatibility macros.
Also add alternative aliases for 32 bit AIX's pollitem struct:
events -> reqevents
revents -> rtnevents
2016-12-05 22:50:10 +00:00
Luca Boccassi
3f8e6c0812
Merge pull request #2239 from loachfish/master
...
avoid crashing in the multi-thread operation for std::vector
2016-12-05 14:22:28 +01:00
Justin.Hung
52ebffd715
avoid crashing in the multi-thread operation for std::vector
...
1. stl container is not thread safety
2. rm_fd() and loop() end to clear the retired event source will in multi-thread operation
3. may be crashed in reaper thread to delete the items in the std::vector as the source is nullptr
2016-12-05 09:28:05 +08:00
Constantin Rack
42c63368e6
Merge pull request #2238 from bluca/revert
...
Problem: PR #2236 breaks the build
2016-12-04 07:42:47 +01:00
Luca Boccassi
e46d91d41f
Problem: PR #2236 breaks the build
...
Solution: Revert "avoid crashing in the multi-thread operation for std::vector"
This reverts commit e1368bdac8
.
2016-12-03 22:10:19 +00:00
Constantin Rack
324f10494a
Merge pull request #2236 from loachfish/master
...
avoid crashing in the multi-thread operation for std::vector
2016-12-03 16:09:56 +01:00
Justin.Hung
e1368bdac8
avoid crashing in the multi-thread operation for std::vector
...
1. stl container is not thread safety
2. rm_fd() and loop() end to clear the retired event source will in multi-thread operation
3. may be crashed in reaper thread to delete the items in the std::vector as the source is nullptr
2016-12-02 17:33:13 +08:00
Constantin Rack
9a20f42f62
Merge pull request #2235 from bluca/cmake_soversion
...
Problem: CMake build uses library version as the ABI version
2016-12-02 07:32:55 +01:00