pbos@webrtc.org
c9b3f77e65
Fix data races in VideoAdapterTest.
Adressing clear races between the test thread and capturer thread shown as heap-use-after-free in vpx_codec_destroy in WebRtcVideoMediaChannelTest.SetSend (way later in the rest run). When capturing a frame the test copied it to a separate frame that would then be read by the test without synchronization, if the test didn't manage to examine the frame in between captures the adapted frame would be overwritten by the following frame during accesses to it. The actual races are suppressed by race:webrtc/base/messagequeue.cc and race:webrtc/base/thread.cc. These fixes reduce the suppression count locally from around 3000 to 30 for VideoAdapterTest.*. Also removing tsan suppressions for talk/base as it's been moved to webrtc/base. R=tommi@webrtc.org BUG=3671 Review URL: https://webrtc-codereview.appspot.com/22169004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6979 4adac7df-926f-26a2-2b94-8c16560cd09d
As expected, r6569 (https://code.google.com/p/webrtc/source/detail?r=6965) caused memcheck bots to complain. Adding expections for that, in line with outher peerconnection tests.
Description
No description provided
Languages
C++
76%
C
16%
Python
2.3%
Java
2.1%
Objective-C++
1.5%
Other
1.9%