kjellander@webrtc.org
8f13810cf2
Improved memory tool test wrapper script
* Clarified that the test only supports specifying a single test (multiple didn't work before, so better not claim to support it). * No longer needs test executable arguments to use ++ instead of -- * Only appends the build_dir path to the test executable if not already present. * Simplified suppression path handling. * Fixed crash when -v was used (import logging was missing) * Style fixes. * Thorougly tested with all the supported flags. I noted that the --gtest_filter flag does not work as expected (it's only for 'additional gtest_filter arguments', which seems to mean additional arguments to the gtest filter text files that are used by Chrome. I left it in here anyway. If --gtest_filter is given after the test executable it will work, since those arguments are added straight to the test executable the test BUG=none TEST=I ran the following commands and verified that the suppressions and flags were handled correct: tools/valgrind-webrtc/webrtc_tests.sh -v --gtest_repeat=2 --keep_logs --tool_flags=--trace-children=yes -t out/Debug/test_support_unittests --foo --bar tools/valgrind-webrtc/webrtc_tests.sh -v --gtest_repeat=2 --keep_logs --tool_flags=--trace-children=yes -b out/Debug -t test_support_unittests --foo --bar tools/valgrind-webrtc/webrtc_tests.sh -v --gtest_repeat=2 --keep_logs --tool_flags=--trace-children=yes -b out/Debug -t out/Debug/test_support_unittests --foo --bar tools/valgrind-webrtc/webrtc_tests.sh -v --tool=tsan --gtest_repeat=2 --keep_logs --tool_flags=--trace-children=yes -t out/Debug/test_support_unittests --foo --bar tools/valgrind-webrtc/webrtc_tests.sh -v --tool=tsan --gtest_repeat=2 --keep_logs --tool_flags=--trace-children=yes -b out/Debug -t test_support_unittests --foo --bar tools/valgrind-webrtc/webrtc_tests.sh -v --tool=tsan --gtest_repeat=2 --keep_logs --tool_flags=--trace-children=yes -b out/Debug -t out/Debug/test_support_unittests --foo --bar Review URL: https://webrtc-codereview.appspot.com/1029005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@3354 4adac7df-926f-26a2-2b94-8c16560cd09d
Description
No description provided
Languages
C++
76%
C
16%
Python
2.3%
Java
2.1%
Objective-C++
1.5%
Other
1.9%