Go to file
tommi@webrtc.org 5b06b06cc0 Revert 6897 (i.e. Reland 6863) - "Revert 6863 "Refactor StatsCollector and associated..."
The bot that had the problem was using an old version of STL, so relanding.

> Revert 6863 "Refactor StatsCollector and associated types."
> 
> Breaks chrome compilation on Mac:
> 
> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk/usr/include/c++/4.2.1/bits/vector.tcc:252:8:
> error: no matching constructor for initialization of
> 'webrtc::StatsReport'
>           _Tp __x_copy = __x;
>               ^          ~~~
> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk/usr/include/c++/4.2.1/bits/stl_vector.h:608:4:
> note: in instantiation of member function
> 'std::vector<webrtc::StatsReport, std::allocator<webrtc::StatsReport>
> >::_M_insert_aux' requested here
>           _M_insert_aux(end(), __x);
>           ^
> ../../content/renderer/media/mock_peer_connection_impl.cc:282:11:
> note: in instantiation of member function
> 'std::vector<webrtc::StatsReport, std::allocator<webrtc::StatsReport>
> >::push_back' requested here
>   reports.push_back(report1);
>           ^
> ../../third_party/libjingle/source/talk/app/webrtc/statstypes.h:49:3:
> note: candidate constructor not viable: requires 0 arguments, but 1
> was provided
>   StatsReport() : timestamp(0) {}
> 
> 
> 
> > Refactor StatsCollector and associated types.
> > * Due to the type changes, I'm going to update the OnCompleted event in two phases to sync with Chrome. This is the first phase.
> > * Reports are now managed in a set, not a map, since it's enough to store the id in one place.
> > * Report ids are now const.
> > * Copying of data has been greatly reduced.
> > * This change includes preparation work for making GetStats fully async.
> > 
> > This is a reland of r6778 which was reverted due to fyi bots failing.
> > I found and fixed the issue which was that in a couple of places I needed to replace a report instead of finding+updating an existing one.
> > 
> > R=xians@webrtc.org
> > 
> > Review URL: https://webrtc-codereview.appspot.com/15119004
> 
> TBR=tommi@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/21169004

TBR=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/22099004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6908 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-15 08:38:30 +00:00
data modules/audio_processing: Updates output_data_fixed.pb test file 2014-08-12 07:35:52 +00:00
resources NetEq background noise generation off by default 2014-08-13 09:45:40 +00:00
talk Revert 6897 (i.e. Reland 6863) - "Revert 6863 "Refactor StatsCollector and associated..." 2014-08-15 08:38:30 +00:00
third_party Added mirror of gtest-parallel. 2014-05-23 09:37:29 +00:00
tools Exlcude two tests in VideoAdapter for WinDrMemoryFull. 2014-08-14 16:25:38 +00:00
webrtc common_audio/signal_processing: Remove macro WEBRTC_SPL_UMUL_32_16_RSFT16 2014-08-15 05:17:20 +00:00
.clang-format Style-option file for clang-format. 2013-11-25 15:30:37 +00:00
.gitignore .gitignore removed openssl 2014-08-12 16:04:00 +00:00
all.gyp Allow root build dependencies to be overridden. 2014-08-08 00:08:58 +00:00
android-webrtc.mk Changed a flag in ARM build for platform build. 2012-09-08 00:32:59 +00:00
Android.mk Added buildbot benchmarking in iSAC and APM into Android platform build. 2012-12-07 15:26:28 +00:00
AUTHORS Implement command line flags for peerconnection client example on Windows 2014-07-01 16:28:13 +00:00
BUILD.gn Initial GN work for WebRTC 2014-06-17 08:54:03 +00:00
codereview.settings Add a root codereview.settings file. 2013-04-24 02:08:50 +00:00
COPYING Libjingle in webrtc needs updated AUTHORS, COPYING, LICENSE_THIRD_PARTY AND README. 2013-07-16 18:04:56 +00:00
DEPS Remove more dependencies on openssl, add dependency on boringssl. Continues on r6798 2014-08-11 21:06:30 +00:00
drover.properties Add a drover.properties file for reference. 2013-05-30 18:15:54 +00:00
libvpx.mk Change android makefile to reflect recent file structure change 2011-07-13 17:49:49 +00:00
LICENSE Updated license path in LICENSE and LICENSE_THIRD_PARTY. 2012-11-22 12:06:21 +00:00
license_template.txt Update template to follow chromium copyright style 2013-04-24 01:01:28 +00:00
LICENSE_THIRD_PARTY Libjingle in webrtc needs updated AUTHORS, COPYING, LICENSE_THIRD_PARTY AND README. 2013-07-16 18:04:56 +00:00
OWNERS GN: Add BUILD.gn files + kjellander to OWNERS 2014-06-23 19:21:07 +00:00
PATENTS Add references to src/ copies for LICENSE etc. 2011-10-26 01:05:07 +00:00
PRESUBMIT.py GN: Add PRESUBMIT.py check for GN changes + default bots. 2014-08-06 09:11:18 +00:00
WATCHLISTS Adding the new video folder and pacer to the wathclist. 2014-06-10 13:59:37 +00:00