webrtc/talk
wu@webrtc.org 3c5d2b43ec Thread::Stop() must be called before any subclass's destructor completes.
Update Thread documentation, fix all subclasses that had a problem.

This is to avoid a data racing between the destructor modifying the vtable, and
Thread::PreRun calling virtual method Run at the same time.

For example:
[ RUN      ] FileMediaEngineTest.TestGetCapabilities
==================
WARNING: ThreadSanitizer: data race on vptr (ctor/dtor vs virtual call) (pid=2967)
  Read of size 8 at 0x7d480000bd00 by thread T1:
     talk_base::Thread::PreRun(void*) /mnt/data/b/build/slave/Linux_Tsan_v2/build/src/out/Release/../../talk/base/thread.cc:353 (libjingle_media_unittest+0x000000234da8)

  Previous write of size 8 at 0x7d480000bd00 by main thread:
     talk_base::Thread::~Thread() /mnt/data/b/build/slave/Linux_Tsan_v2/build/src/out/Release/../../talk/base/thread.cc:158 (libjingle_media_unittest+0x00000023478c)
     ~RtpSenderReceiver /mnt/data/b/build/slave/Linux_Tsan_v2/build/src/out/Release/../../talk/media/base/filemediaengine.cc:122 (libjingle_media_unittest+0x0000001b551f)
    ...

RISK=P2
TESTED=try bots and tsan
BUG=2078,2080
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2428004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4999 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-18 16:27:26 +00:00
..
app/webrtc Update talk to 54898858. 2013-10-16 18:12:02 +00:00
base Thread::Stop() must be called before any subclass's destructor completes. 2013-10-18 16:27:26 +00:00
build Update talk to 54527154. 2013-10-13 17:18:27 +00:00
examples AppRTCDemo(android): remove vestigial mentions of PowerManager 2013-10-17 20:53:12 +00:00
media Thread::Stop() must be called before any subclass's destructor completes. 2013-10-18 16:27:26 +00:00
p2p Update talk to 54898858. 2013-10-16 18:12:02 +00:00
session Update talk to 54898858. 2013-10-16 18:12:02 +00:00
site_scons Update talk folder to revision=49952949 2013-07-26 19:17:59 +00:00
sound Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
third_party/libudev Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
xmllite Thread::Stop() must be called before any subclass's destructor completes. 2013-10-18 16:27:26 +00:00
xmpp Thread::Stop() must be called before any subclass's destructor completes. 2013-10-18 16:27:26 +00:00
COPYING Libjingle in webrtc needs updated AUTHORS, COPYING, LICENSE_THIRD_PARTY AND README. 2013-07-16 18:04:56 +00:00
libjingle_examples.gyp AppRTCDemo(android): uncaught exceptions now display a modal dialog box before killing the app. 2013-10-03 18:09:40 +00:00
libjingle_media_unittest.isolate Add isolate targets for libjingle 2013-10-04 19:31:27 +00:00
libjingle_p2p_unittest.isolate Add isolate targets for libjingle 2013-10-04 19:31:27 +00:00
libjingle_peerconnection_unittest.isolate Add isolate targets for libjingle 2013-10-04 19:31:27 +00:00
libjingle_sound_unittest.isolate Add isolate targets for libjingle 2013-10-04 19:31:27 +00:00
libjingle_tests.gyp Add isolate targets for libjingle 2013-10-04 19:31:27 +00:00
libjingle_unittest.isolate Add isolate targets for libjingle 2013-10-04 19:31:27 +00:00
libjingle.gyp Update talk to 54898858. 2013-10-16 18:12:02 +00:00
libjingle.scons Update talk to 54898858. 2013-10-16 18:12:02 +00:00
LICENSE_THIRD_PARTY Libjingle in webrtc needs updated AUTHORS, COPYING, LICENSE_THIRD_PARTY AND README. 2013-07-16 18:04:56 +00:00
main.scons Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
OWNERS Add owners to [webrtc,talk]/build and *.isolate (take 2) 2013-10-04 19:36:45 +00:00
PRESUBMIT.py talk/PRESUBMIT: Accept copyright years going back to 2004. 2013-08-05 15:01:33 +00:00