generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
4,399 Commits 1 Branch 0 Tags 108 MiB
C++ 76%
C 16%
Python 2.3%
Java 2.1%
Objective-C++ 1.5%
Other 1.9%
3c5d2b43ec
Go to file
wu@webrtc.org 3c5d2b43ec Thread::Stop() must be called before any subclass's destructor completes. 
Update Thread documentation, fix all subclasses that had a problem.

This is to avoid a data racing between the destructor modifying the vtable, and
Thread::PreRun calling virtual method Run at the same time.

For example:
[ RUN      ] FileMediaEngineTest.TestGetCapabilities
==================
WARNING: ThreadSanitizer: data race on vptr (ctor/dtor vs virtual call) (pid=2967)
  Read of size 8 at 0x7d480000bd00 by thread T1:
    #0 talk_base::Thread::PreRun(void*) /mnt/data/b/build/slave/Linux_Tsan_v2/build/src/out/Release/../../talk/base/thread.cc:353 (libjingle_media_unittest+0x000000234da8)

  Previous write of size 8 at 0x7d480000bd00 by main thread:
    #0 talk_base::Thread::~Thread() /mnt/data/b/build/slave/Linux_Tsan_v2/build/src/out/Release/../../talk/base/thread.cc:158 (libjingle_media_unittest+0x00000023478c)
    #1 ~RtpSenderReceiver /mnt/data/b/build/slave/Linux_Tsan_v2/build/src/out/Release/../../talk/media/base/filemediaengine.cc:122 (libjingle_media_unittest+0x0000001b551f)
    ...

RISK=P2
TESTED=try bots and tsan
BUG=2078,2080
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2428004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4999 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-18 16:27:26 +00:00
data ADM no longer reads PCM files from data/audio_device. Now uses the resource folder instead. 2012-08-20 09:44:59 +00:00
samples/js Support video constraints and use key/value pairs. 2013-10-05 02:26:50 +00:00
talk Thread::Stop() must be called before any subclass's destructor completes. 2013-10-18 16:27:26 +00:00
third_party Document updating gflags and remove code duplication. 2013-08-20 16:17:10 +00:00
tools Thread::Stop() must be called before any subclass's destructor completes. 2013-10-18 16:27:26 +00:00
webrtc Have padding decay to zero if no frames are being captured. 2013-10-18 15:05:29 +00:00
.gitignore Add /webrtc/modules/audio_device/android/test/{bin,gen,libs} to .gitignore 2013-10-16 21:08:17 +00:00
all.gyp Enable ObjC build by default and reenable 64-bit mac libjingle build 2013-08-26 19:31:21 +00:00
android-webrtc.mk Changed a flag in ARM build for platform build. 2012-09-08 00:32:59 +00:00
Android.mk Added buildbot benchmarking in iSAC and APM into Android platform build. 2012-12-07 15:26:28 +00:00
AUTHORS Libjingle in webrtc needs updated AUTHORS, COPYING, LICENSE_THIRD_PARTY AND README. 2013-07-16 18:04:56 +00:00
codereview.settings Add a root codereview.settings file. 2013-04-24 02:08:50 +00:00
COPYING Libjingle in webrtc needs updated AUTHORS, COPYING, LICENSE_THIRD_PARTY AND README. 2013-07-16 18:04:56 +00:00
DEPS Roll chromium_revision 226126:228675 and fix clang warnings 2013-10-15 20:10:17 +00:00
drover.properties Add a drover.properties file for reference. 2013-05-30 18:15:54 +00:00
libvpx.mk Change android makefile to reflect recent file structure change 2011-07-13 17:49:49 +00:00
LICENSE Updated license path in LICENSE and LICENSE_THIRD_PARTY. 2012-11-22 12:06:21 +00:00
license_template.txt Update template to follow chromium copyright style 2013-04-24 01:01:28 +00:00
LICENSE_THIRD_PARTY Libjingle in webrtc needs updated AUTHORS, COPYING, LICENSE_THIRD_PARTY AND README. 2013-07-16 18:04:56 +00:00
OWNERS Add owners to [webrtc,talk]/build and *.isolate 2013-10-04 17:35:26 +00:00
PATENTS Add references to src/ copies for LICENSE etc. 2011-10-26 01:05:07 +00:00
PRESUBMIT.py Isolate GYP target and .isolate files for tests 2013-08-22 07:57:00 +00:00
WATCHLISTS Update myself in webrtc watchlist 2013-07-03 01:13:18 +00:00