Commit Graph

3347 Commits

Author SHA1 Message Date
fischman@webrtc.org
f4e070eca5 Added auto-call feature to WebRTCDemo.
This (compile-time switchable) option automatically starts & stops calls in
series to stress-test the setup/teardown codepaths.  When startCPULoad() is
removed (https://webrtc-codereview.appspot.com/972008/) this showed no
hangs/crashes after completing 200 start/stop pairs.

Also fixed a tiny shutdown-order bug (onDestroy() calling super.onDestroy()
before performing self-shutdown) and changed default video frame resolution to
640x480 to more effectively stress the device (and be a more compelling demo).

BUG=1162

Review URL: https://webrtc-codereview.appspot.com/939032

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3238 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-04 16:53:43 +00:00
perkj@webrtc.org
2cf22a6abc Revert 3231 - VoE Changes to enable dual_streaming.
TEST=added new unit-test

This CL depends on issue 933015 http://webrtc-codereview.appspot.com/933015/
which is under review. Should be committed after issue 933015 is committed.
Review URL: https://webrtc-codereview.appspot.com/970005

TBR=turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/929040

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3236 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-04 10:02:02 +00:00
stefan@webrtc.org
e861359925 Adds two full stack performance metrics for end-to-end delay.
Review URL: https://webrtc-codereview.appspot.com/937034

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3235 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-04 09:40:46 +00:00
dwkang@webrtc.org
6bd737a714 First pass of MediaCodecDecoder which uses Android MediaCodec API.
Background:
As of now, MediaCodec API is the only public interface which enables us
to access low level HW resource in Android. ViEMediaCodecDecoder will be
used for further experiments/exploration.

TODO:
  To fix known issues. (detaching thread from VM and frequent GC)
Review URL: https://webrtc-codereview.appspot.com/933033

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3233 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-04 06:38:19 +00:00
fbarchard@google.com
781cf06124 libyuv r508 with scaler fix for overread horizontally that was caught by valgrind.
BUG=none
TEST=valgrind bots
Review URL: https://webrtc-codereview.appspot.com/968013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3232 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-04 03:07:29 +00:00
turaj@webrtc.org
767d87cf24 VoE Changes to enable dual_streaming.
TEST=added new unit-test

This CL depends on issue 933015 http://webrtc-codereview.appspot.com/933015/
which is under review. Should be committed after issue 933015 is committed.
Review URL: https://webrtc-codereview.appspot.com/970005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3231 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-03 22:51:37 +00:00
turaj@webrtc.org
226db898f7 Dual-stream implementation, not including VoE APIs.
Review URL: https://webrtc-codereview.appspot.com/933015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3230 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-03 22:13:31 +00:00
turaj@webrtc.org
277ec8e3f5 Fix a bug when iSAC-48kHz was added.
I discovered this by running extended VoE test on "Codecs."

TBR=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/973010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3229 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-03 21:16:23 +00:00
mikhal@webrtc.org
f18de86db1 Revert 3227
> vp8 unittest: Adding qcif stride test
> 
> Review URL: https://webrtc-codereview.appspot.com/930030

TBR=mikhal@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/929037

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3228 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-03 20:08:57 +00:00
mikhal@webrtc.org
ab83bb39ad vp8 unittest: Adding qcif stride test
Review URL: https://webrtc-codereview.appspot.com/930030

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3227 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-03 19:12:29 +00:00
turaj@webrtc.org
b0dff12d2b 48 kHz extension to iSAC.
Test:
-manual test with voe_cmd_test.
-manual test with RTPEncode & NetEqRTPPlay.
-manual test with simpleKenny.
-Bit-exact test of iSAC-swb and iSAC-wb with head revision of trunk. The bit-exactness is confirmed on all files generated by running webrtc/modules/audio_coding/codecs/isac/main/test/QA/runiSACLongtest.txt
Review URL: https://webrtc-codereview.appspot.com/937025

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3226 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-03 17:43:52 +00:00
phoglund@webrtc.org
0bacb635cb Removed stale version of fuzzer; it's now internal.
BUG=

Review URL: https://webrtc-codereview.appspot.com/971015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3225 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-03 14:28:40 +00:00
stefan@webrtc.org
8d0cd07d0c Add test to verify that padding only frames are passing through the RTP module.
Review URL: https://webrtc-codereview.appspot.com/934023

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3224 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-03 14:01:46 +00:00
tina.legrand@webrtc.org
5b4fe494e7 Changing default bitrate to 64000 bps for Opus.
Default settings for Opus in WebRtc is stereo, but we had default rate to 32 kbps. This is too low for stereo, where we need to encode using 64 kbps to get the quality we like.

BUG=

Review URL: https://webrtc-codereview.appspot.com/974008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3223 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-03 12:08:53 +00:00
kjellander@webrtc.org
ad0f3baf90 Removing redundant codec unittest targets.
The following targets have been merged into audio_coding_unittests:
* cng_unittests
* g711_unittests
* g722_unittests
* isacfix_unittests
* pcm16b_unittests

Some of them were empty and were created with the assumption they were
needed in order to get code coverage (which was actually not needed).

The following test has been removed since it was empty:
* audio_conference_mixer_unittests

BUG=none
TEST=trybots passing (well, except for the unittests that are removed, they're failing until the try server configuration is updated)

Review URL: https://webrtc-codereview.appspot.com/971008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3222 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-03 10:52:29 +00:00
phoglund@webrtc.org
ba21c95e15 Reformatted data_log.
BUG=

Review URL: https://webrtc-codereview.appspot.com/974007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3221 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-03 09:01:21 +00:00
stefan@webrtc.org
c94f8d4e8f Fix OOB read in padding tests.
BUG=1177

Review URL: https://webrtc-codereview.appspot.com/973009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3220 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-03 08:57:54 +00:00
phoglund@webrtc.org
78bec2dcbe Fixed bug where we would rewrite *deref_ptr = ...; to // deref_ptr = ...;
BUG=

Review URL: https://webrtc-codereview.appspot.com/929036

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3219 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-03 08:48:07 +00:00
henrike@webrtc.org
fc4a7ee807 Fixes chromium build bots.
BUG=N/A

Review URL: https://webrtc-codereview.appspot.com/971014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3213 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-30 16:17:44 +00:00
brykt@google.com
c7896df420 Fixed bug that caused frame_cutter_unittest to fail when built with MVS2008.
This was caused by not supplying a correct pointer to where fread should read. The files are now opened in binary mode (which I have under stood can cause problems between different OS if it is not done). I also check for EOF when I compare data from fread. Previously the checking for correct amount of bytes read failed when the end of the file had been reached.

BUG=

Review URL: https://webrtc-codereview.appspot.com/937032

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3212 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-30 12:37:14 +00:00
phoglund@webrtc.org
53034fb247 Improved the conformance test: it will now show video tags and better verify that we set up a call.
BUG=

Review URL: https://webrtc-codereview.appspot.com/930031

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3211 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-30 11:59:20 +00:00
phoglund@webrtc.org
99f7c917d2 Reformatted critical_section wrappers.
BUG=
TEST=ran trybots

Review URL: https://webrtc-codereview.appspot.com/971012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3210 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-30 10:44:49 +00:00
andrew@webrtc.org
219df91095 Delete bad mergeinfo from webrtc/modules/video_capture/windows
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3208 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-30 02:46:24 +00:00
andrew@webrtc.org
dddc02b9dc Use <(webrtc_root) to point to webrtc files in tools.gyp.
TBR=brykt@google.com

Review URL: https://webrtc-codereview.appspot.com/939034

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3206 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-30 02:28:27 +00:00
fischman@webrtc.org
d814d71d92 Delete {start,stop}CPULoad() since they're broken.
- stopCPULoad is incorrect; since mIsBackgroudLoadRunning isn't declared
  volatile, the empty while loop in the background thread isn't required to do a
  memory read (as opposed to reading the value just once and caching it).  The
  result is that stopCPULoad() may never return as the .join() waits forever.
- startCPULoad isn't guaranteed to tax the CPU; the JVM is free to replace the
  while loop in startCPULoad() with a thread pause since it can prove it'll
  never exit the loop once entered (b/c of the previous item).

It's not clear what correct behavior here would be so I'm deleting the code
rather than trying to make it work.  This was responsible for at least most if
not all of the hanginess of start/stop'ing multiple calls in series.

BUG=1162

Review URL: https://webrtc-codereview.appspot.com/972008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3202 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-29 23:00:41 +00:00
fischman@webrtc.org
be5b5ba490 Enable building WebRTCDemo apk using Release webrtc libs, take 2.
Now passing BUILDTYPE=Release to both the make that builds the libs and the
ndk-build that builds the app makes the app use non-Debug libs.

Review URL: https://webrtc-codereview.appspot.com/966029

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3201 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-29 18:06:00 +00:00
stefan@webrtc.org
bd941d3f4c Fixes two bugs related to padding in the jitter buffer.
- Pad packets (empty) were often NACKed even though they were received.
- Padding only frames (empty) were didn't properly update the decoding state,
  and would therefore be NACKed even though they were received.

This is a recommit of r3183. Extensive testing suggest that this may have been caused by virtual machine flakiness.

TBR=mflodman@webrtc.org

BUG=1150

Review URL: https://webrtc-codereview.appspot.com/971011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3200 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-29 14:37:18 +00:00
henrik.lundin@webrtc.org
8552c71290 Fixing neteq_unittests for VS 2012
For Visual Studio versions older than 2012, we are using a
separate reference output file for windows. (All other platforms
share the same generic reference file.) In VS 2012, the output
matches the generic reference, and not the platform-specific one.

Since, the ResourcePath() method cannot change behavior depending
on compiler version, this fix will short-cut ResourcePath() for
VS 2012 or newer (_MSC_VER >= 1700).

Also made NetEqDecodingTest.TestBitExactnes stop on the first diff.
Once there is a difference, the output is no longer bit-exact, and
the test should be declared a failure.

BUG=
TEST=neteq_unittests on VS2012, try bots

Review URL: https://webrtc-codereview.appspot.com/966028

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3199 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-29 12:03:18 +00:00
phoglund@webrtc.org
34dab50bb4 Corrected .h path.
TBR=mflodman@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/972009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3198 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-29 10:20:18 +00:00
phoglund@webrtc.org
273ccad59d Fixed standard PSNR/SSIM test.
BUG=1103

Review URL: https://webrtc-codereview.appspot.com/971005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3197 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-29 10:08:16 +00:00
stefan@webrtc.org
bf41508807 Properly remove the bitrate observer when ViEEncoder is destructed.
BUG=1090

Review URL: https://webrtc-codereview.appspot.com/969013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3196 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-29 09:18:53 +00:00
fbarchard@google.com
662651ac95 Disable denoise filter for Arm, as it is not optimized enough yet.
BUG=https://code.google.com/p/chrome-os-partner/issues/detail?id=16318
TEST=none
Review URL: https://webrtc-codereview.appspot.com/968008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3195 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-29 09:01:21 +00:00
phoglund@webrtc.org
cde46fa5d2 Disabled some more flaky tests. Memcheck vie_auto_test should be very stable after this.
BUG=1152

Review URL: https://webrtc-codereview.appspot.com/964019

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3194 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-29 08:22:45 +00:00
henrik.lundin@webrtc.org
f826bb6fb2 Fixing a bug related to RCU in NetEQ
RCU was disabled due to that the RCU flag was overwritten with zero
in the packet buffer.

BUG=1156
TEST=trybots, neteq_unittests, audio_coding_module_test, audio_coding_unittests

Review URL: https://webrtc-codereview.appspot.com/969012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3193 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-29 07:32:38 +00:00
leozwang@webrtc.org
56a1c2cc20 Enable java soundcard impl as the default
BUG=None
TEST=trybots
Review URL: https://webrtc-codereview.appspot.com/974006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3192 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-29 03:13:00 +00:00
fischman@webrtc.org
de6f8fbd6d Revert 3190 - Enable building WebRTCDemo apk using Release webrtc libs.
Now passing BUILDTYPE=Release to both the make that builds the libs and the
ndk-build that builds the app makes the app use non-Debug libs.

TBR=leozwang@webrtc.org,

Review URL: https://webrtc-codereview.appspot.com/968010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3191 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-29 01:18:04 +00:00
fischman@webrtc.org
28afee04ae Enable building WebRTCDemo apk using Release webrtc libs.
Now passing BUILDTYPE=Release to both the make that builds the libs and the
ndk-build that builds the app makes the app use non-Debug libs.

Review URL: https://webrtc-codereview.appspot.com/972007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3190 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-29 01:09:44 +00:00
marpan@webrtc.org
f3cefe1104 Added metrics test code for the FEC packet masks.
The test computes metrics (average residual loss) for each mask type and size, 
for a given set of loss models (random and bursty), and verifies various 
behaviour of the codes (including relation/comparison to RS code).

http://webrtc-codereview.appspot.com/748008
TBR=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/929034

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3189 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 23:27:34 +00:00
marpan@webrtc.org
c09e779766 Allow for 1 layer case to be set in temporal_layers.
Review URL: https://webrtc-codereview.appspot.com/971007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3188 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 22:06:21 +00:00
henrike@webrtc.org
7d5dacc985 Revert 3183 - Fixes two bugs related to padding in the jitter buffer.
- Pad packets (empty) were often NACKed even though they were received.
- Padding only frames (empty) were didn't properly update the decoding state,
  and would therefore be NACKed even though they were received.

http://webrtc-cb-linux-master.cbf.corp.google.com:8010/builders/Win32Release/builds/1704/steps/video_coding_unittests/logs/stdio

TEST=trybots

BUG=1150

Review URL: https://webrtc-codereview.appspot.com/929031

TBR=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/971010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3187 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 22:04:45 +00:00
marpan@webrtc.org
c244cefe1d Reverting r3185
TBR=marpan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/933029

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3186 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 21:00:36 +00:00
marpan@webrtc.org
993494764d Added metrics test code for the FEC packet masks.
The test computes metrics (average residual loss) for each mask type and size, 
for a given set of loss models (random and bursty), and verifies various 
behaviour of the codes (including relation/comparison to RS code).
Review URL: https://webrtc-codereview.appspot.com/748008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3185 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 19:43:58 +00:00
leozwang@webrtc.org
aa46ea0b8b Remove ringtone from test app
BUG=None
TEST=trybots
Review URL: https://webrtc-codereview.appspot.com/968009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3184 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 19:39:23 +00:00
stefan@webrtc.org
e4fb44c29d Fixes two bugs related to padding in the jitter buffer.
- Pad packets (empty) were often NACKed even though they were received.
- Padding only frames (empty) were didn't properly update the decoding state,
  and would therefore be NACKed even though they were received.

TEST=trybots

BUG=1150

Review URL: https://webrtc-codereview.appspot.com/929031

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3183 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 19:36:20 +00:00
henrike@webrtc.org
891d55eb35 Revert 3181 - Fixes two bugs related to padding in the jitter buffer.
- Pad packets (empty) were often NACKed even though they were received.
- Padding only frames (empty) didn't properly update the decoding state,
  and would therefore be NACKed even though they were received.

Broke [Builder Win32Debug] (http://webrtc-cb-linux-master.cbf.corp.google.com:8010/builders/Win32Debug/builds/1728)

TEST=trybots

BUG=1150

Review URL: https://webrtc-codereview.appspot.com/966026

TBR=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/939031

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3182 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 17:45:01 +00:00
stefan@webrtc.org
d42e51ce7c Fixes two bugs related to padding in the jitter buffer.
- Pad packets (empty) were often NACKed even though they were received.
- Padding only frames (empty) didn't properly update the decoding state,
  and would therefore be NACKed even though they were received.

TEST=trybots

BUG=1150

Review URL: https://webrtc-codereview.appspot.com/966026

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3181 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 16:40:28 +00:00
phoglund@webrtc.org
0f8286fd75 Added last (?) suppressions for known issues.
BUG=1152

Review URL: https://webrtc-codereview.appspot.com/933027

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3180 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 14:21:12 +00:00
phoglund@webrtc.org
7d74bdbeac Added conformance tests.
BUG=

Review URL: https://webrtc-codereview.appspot.com/929030

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3179 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 13:03:17 +00:00
phoglund@webrtc.org
8d334d387b Disabled flaky test on Linux, added disable-on-platform macros, fixed \n's
BUG=1155

Review URL: https://webrtc-codereview.appspot.com/972006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3178 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 12:28:06 +00:00
tina.legrand@webrtc.org
c4590580e8 Opus mono/stereo on the same payloadtype, and fix of memory bug
During call setup Opus should always be signaled as a 48000 Hz stereo codec, not depending on what we plan to send, or how we plan to decode received packets.
The previous implementation had different payload types for mono and stereo, which breaks the proposed standard.

While working on this CL I ran in to the problem reported earlier, that we could get a crash related to deleting decoder memory. This should now be solved in Patch Set 3.

BUG=issue1013, issue1112

Review URL: https://webrtc-codereview.appspot.com/933022

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3177 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 12:23:29 +00:00