generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Removing redundant codec unittest targets.

Browse Source 
The following targets have been merged into audio_coding_unittests:
* cng_unittests
* g711_unittests
* g722_unittests
* isacfix_unittests
* pcm16b_unittests

Some of them were empty and were created with the assumption they were
needed in order to get code coverage (which was actually not needed).

The following test has been removed since it was empty:
* audio_conference_mixer_unittests

BUG=none
TEST=trybots passing (well, except for the unittests that are removed, they're failing until the try server configuration is updated)

Review URL: https://webrtc-codereview.appspot.com/971008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3222 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
kjellander@webrtc.org 2012-12-03 10:52:29 +00:00
parent ba21c95e15
commit ad0f3baf90
13 changed files with 6 additions and 179 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
webrtc/modules/audio_coding/codecs/cng/cng.gypi
View File

@ -30,24 +30,6 @@
],
},
], # targets
'conditions': [
['include_tests==1', {
'targets': [
{
'target_name': 'cng_unittests',
'type': 'executable',
'dependencies': [
'CNG',
'<(DEPTH)/testing/gtest.gyp:gtest',
'<(webrtc_root)/test/test.gyp:test_support_main',
],
'sources': [
'cng_unittest.cc',
],
}, # CNG_unittests
], # targets
}], # include_tests
], # conditions
}
# Local Variables:

12
webrtc/modules/audio_coding/codecs/g711/g711.gypi
View File

@ -30,18 +30,6 @@
'conditions': [
['include_tests==1', {
'targets': [
{
'target_name': 'g711_unittests',
'type': 'executable',
'dependencies': [
'G711',
'<(webrtc_root)/test/test.gyp:test_support_main',
'<(DEPTH)/testing/gtest.gyp:gtest',
],
'sources': [
'g711_unittest.cc',
],
},
{
'target_name': 'g711_test',
'type': 'executable',

17
webrtc/modules/audio_coding/codecs/g711/g711_unittest.cc
View File

@ -1,17 +0,0 @@
/*
* Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
/*
* Empty test just to get code coverage metrics for this dir.
*/
#include "g711_interface.h"
#include "gtest/gtest.h"
TEST(G711Test, EmptyTestToGetCodeCoverage) {}

12
webrtc/modules/audio_coding/codecs/g722/g722.gypi
View File

@ -30,18 +30,6 @@
'conditions': [
['include_tests==1', {
'targets': [
{
'target_name': 'g722_unittests',
'type': 'executable',
'dependencies': [
'G722',
'<(webrtc_root)/test/test.gyp:test_support_main',
'<(DEPTH)/testing/gtest.gyp:gtest',
],
'sources': [
'g722_unittest.cc',
],
},
{
'target_name': 'G722Test',
'type': 'executable',

17
webrtc/modules/audio_coding/codecs/g722/g722_unittest.cc
View File

@ -1,17 +0,0 @@
/*
* Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
/*
* Empty test just to get code coverage metrics for this dir.
*/
#include "g722_interface.h"
#include "gtest/gtest.h"
TEST(G722Test, EmptyTestToGetCodeCoverage) {}

14
webrtc/modules/audio_coding/codecs/isac/isacfix_test.gypi
View File

@ -23,20 +23,6 @@
'./fix/test/kenny.c',
],
},
{
'target_name': 'isacfix_unittests',
'type': 'executable',
'dependencies': [
'iSACFix',
'<(DEPTH)/testing/gtest.gyp:gtest',
'<(webrtc_root)/test/test.gyp:test_support_main',
],
'sources': [
'fix/source/filters_unittest.cc',
'fix/source/filterbanks_unittest.cc',
'fix/source/lpc_masking_model_unittest.cc',
],
},
],
}

18
webrtc/modules/audio_coding/codecs/pcm16b/pcm16b.gypi
View File

@ -25,24 +25,6 @@
],
},
], # targets
'conditions': [
['include_tests==1', {
'targets': [
{
'target_name': 'pcm16b_unittests',
'type': 'executable',
'dependencies': [
'PCM16B',
'<(webrtc_root)/test/test.gyp:test_support_main',
'<(DEPTH)/testing/gtest.gyp:gtest',
],
'sources': [
'pcm16b_unittest.cc',
],
}, # PCM16B_unittests
], # targets
}], # include_tests
], # conditions
}
# Local Variables:

17
webrtc/modules/audio_coding/codecs/pcm16b/pcm16b_unittest.cc
View File

@ -1,17 +0,0 @@
/*
* Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
/*
* Empty test just to get code coverage metrics for this dir.
*/
#include "pcm16b.h"
#include "gtest/gtest.h"
TEST(Pcm16bTest, EmptyTestToGetCodeCoverage) {}

6
webrtc/modules/audio_coding/main/source/audio_coding_module.gypi
View File

@ -147,6 +147,8 @@
'type': 'executable',
'dependencies': [
'audio_coding_module',
'CNG',
'iSACFix',
'NetEq',
'<(webrtc_root)/common_audio/common_audio.gyp:vad',
'<(DEPTH)/testing/gtest.gyp:gtest',
@ -155,6 +157,10 @@
],
'sources': [
'acm_neteq_unittest.cc',
'../../codecs/cng/cng_unittest.cc',
'../../codecs/isac/fix/source/filters_unittest.cc',
'../../codecs/isac/fix/source/filterbanks_unittest.cc',
'../../codecs/isac/fix/source/lpc_masking_model_unittest.cc',
],
}, # audio_coding_unittests
],

19
webrtc/modules/audio_conference_mixer/source/audio_conference_mixer.gypi
View File

@ -43,25 +43,6 @@
],
},
], # targets
'conditions': [
['include_tests==1', {
'targets': [
{
'target_name': 'audio_conference_mixer_unittests',
'type': 'executable',
'dependencies': [
'audio_conference_mixer',
'<(DEPTH)/testing/gtest.gyp:gtest',
'<(webrtc_root)/test/test.gyp:test_support_main',
'<(webrtc_root)/system_wrappers/source/system_wrappers.gyp:system_wrappers',
],
'sources': [
'audio_conference_mixer_unittest.cc',
],
}, # audio_conference_mixer_unittests
], # targets
}], # include_tests
], # conditions
}
# Local Variables:

17
webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_unittest.cc
View File

@ -1,17 +0,0 @@
/*
* Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
/*
* Empty test just to get code coverage metrics for this dir.
*/
#include "audio_conference_mixer.h"
#include "gtest/gtest.h"
TEST(AudioConferenceMixerTest, EmptyTestToGetCodeCoverage) {}

17
webrtc/modules/utility/source/file_player_unittest.cc
View File

@ -1,17 +0,0 @@
/*
* Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
/*
* Empty test just to get code coverage metrics for this dir.
*/
#include "file_player.h"
#include "gtest/gtest.h"
TEST(FilePlayerTest, EmptyTestToGetCodeCoverage) {}

1
webrtc/modules/utility/source/utility.gypi
View File

@ -80,7 +80,6 @@
],
'sources': [
'audio_frame_operations_unittest.cc',
'file_player_unittest.cc',
],
}, # webrtc_utility_unittests
], # targets