Commit Graph

3918 Commits

Author SHA1 Message Date
andresp@webrtc.org
72d0b0cf1f Add self to video_engine watchlist.
BUG=

Review URL: https://webrtc-codereview.appspot.com/1305009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3925 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-30 22:20:53 +00:00
stefan@webrtc.org
4980679d35 Fixes two bugs in receive statistics.
- Reported bitrate wasn't reset correctly when no frames had been received.
- Internal framerate estimate wasn't reset when no frames had been received.

BUG=1713

Review URL: https://webrtc-codereview.appspot.com/1377004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3924 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-30 22:05:07 +00:00
pwestin@webrtc.org
d35964a1ce Fixing AV sync.
Increased 2 const to allow for a bigger difference in AV sync.

BUG=1711

Re-wrote the ComputeDelays to be readable and remove the possibilities of returning values lower than base_target_delay_ms

R=mflodman@webrtc.org, mikhal@webrtc.org, niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1367004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3922 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-30 16:06:10 +00:00
mikhal@webrtc.org
6faba6edc9 VCM: Setting buffering delay in timing
Review URL: https://webrtc-codereview.appspot.com/1338004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3921 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-30 15:39:34 +00:00
mikhal@webrtc.org
dd807ac474 Adding buffered mode to loopback test
Review URL: https://webrtc-codereview.appspot.com/1371004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3920 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-30 15:19:47 +00:00
solenberg@webrtc.org
8efc623fc2 Apply Chromium C++ style to RemoteRateControl.
BUG=

Review URL: https://webrtc-codereview.appspot.com/1329004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3919 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-30 08:33:46 +00:00
sergeyu@chromium.org
15e32ccd30 Add DesktopCapturer interface for desktop capturers.
The new DesktopCapturer interface will be used for screen and window
captures. Beside DesktopCapturer itself also added classes/interfaces
that it depends on.

R=alexeypa@chromium.org, tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1322007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3917 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-29 20:10:57 +00:00
mikhal@webrtc.org
865ada3a52 Don't reset the last je value and mode
Review URL: https://webrtc-codereview.appspot.com/1369004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3916 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-29 19:09:41 +00:00
andrew@webrtc.org
50b2efef6e Add a wrapper around PushSincResampler and the old Resampler.
The old resampler is used whenever it supports the requested rates. Otherwise
the sinc resampler is enabled.

Integrated with output_mixer in order to test the change through
output_mixer_unittest. The sinc resampler will not yet be used, since we don't
feed VoE with any rates that trigger it.

BUG=webrtc:1395
R=bjornv@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1355004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3915 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-29 17:27:29 +00:00
stefan@webrtc.org
5b7120c81b Fix two issues where we might end up busy looping in decoder_render mode.
This happens if
- Next frame is far into the future (> 200 ms).
- Next frame is ready for decode/render but incomplete.

BUG=1696
TESTS=trybots

Review URL: https://webrtc-codereview.appspot.com/1354005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3914 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-29 16:41:30 +00:00
pwestin@webrtc.org
b0061f94b2 Enable Nack pacing.
Review URL: https://webrtc-codereview.appspot.com/1357004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3912 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-27 00:41:08 +00:00
mikhal@webrtc.org
47128ab5ab Removing vie file related code from vie_custom_call
Follow up on https://code.google.com/p/webrtc/source/detail?r=3900

Review URL: https://webrtc-codereview.appspot.com/1361004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3911 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-26 20:09:54 +00:00
pwestin@webrtc.org
4e545b33b3 Fixed remaining nits from Stefan
Review URL: https://webrtc-codereview.appspot.com/1323007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3910 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-26 15:23:34 +00:00
andrew@webrtc.org
8fc05feed4 Add a push-based wrapper around SincResampler.
Includes a unittest to ensure we meet the same quality thresholds as SincResampler (modulo quantization error).

BUG=webrtc:1395

Review URL: https://webrtc-codereview.appspot.com/1323011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3909 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-26 14:56:51 +00:00
fbarchard@google.com
42b0b84367 libyuv r680 fixes arm version of I444ToARGB and some lint changes
BUG=none
TEST=libyuv unittests pass on arm with Neon disabled.
Review URL: https://webrtc-codereview.appspot.com/1356005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3908 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-26 02:23:32 +00:00
andrew@webrtc.org
1acb3b33bc Add comfort noise disabling and routing mode selection to audioproc.
TBR=bjornv

Review URL: https://webrtc-codereview.appspot.com/1358004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3907 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-26 00:39:27 +00:00
mikhal@webrtc.org
4cea79b830 Removing another instance of file api
Review URL: https://webrtc-codereview.appspot.com/1356004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3906 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-25 23:31:27 +00:00
vikasmarwaha@webrtc.org
77ac84814d Added new demo states.html & updated existing demos to work on firefox.
Review URL: https://webrtc-codereview.appspot.com/1327007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3905 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-25 23:22:03 +00:00
pwestin@webrtc.org
91563e42da Fix the encoder pause logic.
BUG=1691

Review URL: https://webrtc-codereview.appspot.com/1352004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3904 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-25 22:20:08 +00:00
mikhal@webrtc.org
381da4be9c VCM: Adding API for the size(duration) of the jitter buffer.
Refers to the duration in time of the frames which are ready to be sent to the decoder.

Review URL: https://webrtc-codereview.appspot.com/1319004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3903 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-25 21:45:29 +00:00
mikhal@webrtc.org
8392cd9edd VCM/JB: Using last decoded state for waiting for key
relanding 1323006

BUG=

Review URL: https://webrtc-codereview.appspot.com/1354004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3902 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-25 21:30:50 +00:00
mikhal@webrtc.org
dc3cd217b2 VCM/JB: FrameForDecoding->IncompleteFrameForDecoding
- Update complete frame for decoding
- Remove FrameForDecodingNack

This CL should only be committed after issue http://webrtc-codereview.appspot.com/1313007/

Review URL: https://webrtc-codereview.appspot.com/1316007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3901 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-25 20:27:04 +00:00
mikhal@webrtc.org
b84f13f185 Disabling avi file interface
Review URL: https://webrtc-codereview.appspot.com/1351004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3900 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-25 18:07:32 +00:00
pwestin@webrtc.org
52aa019e98 Avoid adding duplicates in pacer lists.
Review URL: https://webrtc-codereview.appspot.com/1329007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3899 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-25 17:35:56 +00:00
stefan@webrtc.org
cb60fb2e6c Make sure timestamps are monotonically increasing.
BUG=1563

Review URL: https://webrtc-codereview.appspot.com/1325008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3898 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-24 23:54:31 +00:00
fbarchard@google.com
c63772eb39 libyuv license file updates for Android WebView license check.
BUG=none
TEST=try bots
Review URL: https://webrtc-codereview.appspot.com/1313013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3897 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-24 02:12:49 +00:00
andrew@webrtc.org
df9c0e5ec9 Revert 3892 "VCM/JB: Using last decoded state for waiting for key"
> VCM/JB: Using last decoded state for waiting for key
> 
> Review URL: https://webrtc-codereview.appspot.com/1323006

Although I have no idea why, it appears this might be causing failures in ViEStandardIntegrationTest.RunsFileTestWithoutErrors. I was unable to reproduce locally. This is a trial revert to verify. If the errors continue to happen, I will restore this change.

TBR=mikhal@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1321010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3896 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-24 02:13:18 +00:00
andrew@webrtc.org
2e65346e98 Add a root codereview.settings file.
Chromium has one of these as well:
http://src.chromium.org/viewvc/chrome/codereview.settings

It's needed for drover reverts to work properly.

TBR=kjellander

Review URL: https://webrtc-codereview.appspot.com/1319014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3895 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-24 02:08:50 +00:00
fbarchard@google.com
6fec15941a Update template to follow chromium copyright style
BUG=none
TEST=none
Review URL: https://webrtc-codereview.appspot.com/1322008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3894 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-24 01:01:28 +00:00
andresp@webrtc.org
b5eeaa92ba Adding extra options to interact with external encoder/decoder.
Review URL: https://webrtc-codereview.appspot.com/1327006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3893 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-23 22:50:53 +00:00
mikhal@webrtc.org
1248d4effc VCM/JB: Using last decoded state for waiting for key
Review URL: https://webrtc-codereview.appspot.com/1323006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3892 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-23 20:57:06 +00:00
fbarchard@google.com
3a9a3cdaa2 Roll libyuv to r676 for improved llvm compatibility
BUG=none
TESTED=try bots
Review URL: https://webrtc-codereview.appspot.com/1313010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3891 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-23 18:05:46 +00:00
stefan@webrtc.org
8ca8a71de2 Revert "Add a default RTT to CallStats and use different values for buffered/real-time mode."
This reverts commit aae26db1da5803482b094357c546b8454ab1c26d.

BUG=1613
TBR=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1327008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3890 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-23 16:48:32 +00:00
turaj@webrtc.org
a942692725 Buf fix for r3883.
Review URL: https://webrtc-codereview.appspot.com/1319012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3889 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-23 16:08:29 +00:00
stefan@webrtc.org
ccd4b2aec8 Add a default RTT to CallStats and use different values for buffered/real-time mode.
BUG=1613

Review URL: https://webrtc-codereview.appspot.com/1326007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3888 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-23 15:58:23 +00:00
pbos@webrtc.org
d25b602dc0 VP8: Avoid copying the codec struct on Reset().
BUG=

Review URL: https://webrtc-codereview.appspot.com/1319013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3887 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-23 13:08:04 +00:00
mflodman@webrtc.org
efdf778d3f BUG=1351
Propose of this CL: Close the camera properly on MacOS in order to allow other apps to use it.

Changes in this CL:
1. video_capture_qtkit_info_objc.mm _captureDevicesInfo is never released. I have found this memory leak using Instruments from XCode. The patch is releasing it in dealloc.

2. In video_capture_qtkit_objc.h:
a) _captureDeviceName is not needed. Is allocated in the class but never used.
b) I don't see the role of the  NSAutoreleasePool. also if you use it you have to release it when the class is destroyed. Otherwise you will leak memory. Libjingle has for each thread a pool on mac os.

3. In video_capture_qtkit_objc.mm
a) the camera is not stopped properly . See the changes from dealloc. NOTE : If you don't call [[_captureVideoDeviceInput device] close] other apps will not be able to use the camera since you are not closing your app

b) Removed QTCaptureDevice* videoDevice = (QTCaptureDevice*)[_captureDevices objectAtIndex:0]; I don't know why this because the desired camera is opened in setCaptureDeviceById and can be different than position 0 in the camera array. At this moment if you have two cameras and user want to pick the one on index 1 the app also locks the one on 0 .

Other changes I have done to improve (and are not in this CL):
a) I have set the FPS properly to the desired. I have succeeded to reduce the CPU with 3 % doing this. The current code for setting FPS is commented in webrtc
b) I have removed _rLock from the equation. I don't know if it's good or not but I hadn't understood what exactly we are trying to protect with this. Anyway in the current implementation is never released.

Review URL: https://webrtc-codereview.appspot.com/1097014

Patch from Silviu Caragea <silviu.cpp@gmail.com>.

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3886 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-23 11:57:56 +00:00
mikhal@webrtc.org
c1f243f8e7 VCM/JB: Skip to the next complete key frame
Review URL: https://webrtc-codereview.appspot.com/1317006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3885 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-22 22:24:38 +00:00
pwestin@webrtc.org
63117339dc Updated the sync module with a slow moving filter
Review URL: https://webrtc-codereview.appspot.com/1326008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3884 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-22 18:57:14 +00:00
turaj@webrtc.org
28d54ab18f Improve AV-sync when initial delay is set and NetEq has long buffer.
Review URL: https://webrtc-codereview.appspot.com/1324006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3883 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-22 18:53:35 +00:00
kjellander@webrtc.org
1b427719dc emove desktop_capture.gypi from modules.gyp
When adding this in
we started getting linking problems on the mac_asan bot due to
the empty list of source files for the library target.

Please re-add it into modules.gyp when the library has source files
to compile.

BUG=none
TEST=Passing mac_asan trybot.

Review URL: https://webrtc-codereview.appspot.com/1313009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3882 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-22 13:13:49 +00:00
mflodman@webrtc.org
7c9e992d05 Removed unused variable.
Review URL: https://webrtc-codereview.appspot.com/1320013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3881 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-22 13:05:41 +00:00
mflodman@webrtc.org
aeff4f3003 Fixing Coverity issues.
BUG=C14457, C10611

Review URL: https://webrtc-codereview.appspot.com/1320012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3880 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-22 12:41:57 +00:00
tommi@webrtc.org
8aa4a90bd9 Set mime type on device-switch.html
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3879 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-22 05:43:13 +00:00
kjellander@webrtc.org
006acc45c2 Update iOS build script to run on bots.
The script previously only executed build/gyp_chromium to
generate projects. This is not sufficient since the
supplement.gypi has not yet been created (happens in
gclient runhooks). Therefore this CL changes it to run
gclient runhooks instead (marginally slower).
Otherwise the bots would have to generate the projects
twice, which is inefficient.

Annotations are also added to make the upcoming buildbot
steps more readable when the script is running as an
annotated step.

TEST=local compilation on OS X.
BUG=none

Review URL: https://webrtc-codereview.appspot.com/1342005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3878 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-20 13:04:05 +00:00
mikhal@webrtc.org
e0e029e8cb Revert 3876
Review URL: https://webrtc-codereview.appspot.com/1341005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3877 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-19 21:11:41 +00:00
mikhal@webrtc.org
ee184b9520 VCM/Receiver: Only update render time when decoding
Review URL: https://webrtc-codereview.appspot.com/1336004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3876 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-19 19:15:47 +00:00
kjellander@webrtc.org
c41478f7eb Ensure build_demo.py run subprocesses with bash shell.
It turns out the default shell becomes /bin/sh on Lucid. By specifying the shell for subprocess.check_call we ensure bash is used.

Thanks to yujie.mao@intel.com for pointing this out.

BUG=1659
TEST=Successful build with build_demo.py both on Ubuntu Lucid and Precise.
TBR=leozwang

Review URL: https://webrtc-codereview.appspot.com/1343004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3875 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-19 11:50:42 +00:00
braveyao@webrtc.org
a39a8fec16 Add owner to Apprtc
Review URL: https://webrtc-codereview.appspot.com/1328007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3874 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-19 02:34:45 +00:00
sjlee@webrtc.org
1fea17dae4 Add the build script of the voice engine for iOS.
Review URL: https://webrtc-codereview.appspot.com/1319007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3873 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-18 23:22:02 +00:00