generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
8,777 Commits 1 Branch 0 Tags 108 MiB
c62642c7a6
Commit Graph

8777 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Erik Språng
2c4c914819 In screenshare mode, suppress VP8 bitrate overshoot and increase quality 
This change includes several improvements:

* VP8 configured with new rate control
* Detection of frame dropping, with qp bump for next frame
* Increased target and TL0 bitrates
* Reworked rate control (TL allocation) in screenshare_layers

A note on performance: PSNR and SSIM is expected to get slightly worse with this cl. Frame drops and delays should however improve.

BUG=4171
R=pbos@webrtc.org, stefan@webrtc.org

Review URL: https://codereview.webrtc.org/1193513006.

Cr-Commit-Position: refs/heads/master@{#9495}
 2015-06-24 09:24:50 +00:00
phoglund
7ab5f801dd Adding an equals method for KeyValuePair for easier testing. 
With this we can write stuff like

assertThat(result.mandatory,
    hasItem(new KeyValuePair("minWidth", "1280")));

The above will currently fail because the object falls back to ==.

BUG=None

Review URL: https://codereview.webrtc.org/1193883006

Cr-Commit-Position: refs/heads/master@{#9494}
 2015-06-24 08:11:51 +00:00
Joachim Bauch
66f920ea57 Remove definition of non-existent method. 
The private method "CreateDefaultLocalDescription" is defined in the
class, but not implemented or used anywhere.

R=juberti@webrtc.org

Review URL: https://codereview.webrtc.org/1182793004.

Cr-Commit-Position: refs/heads/master@{#9493}
 2015-06-24 07:34:41 +00:00
Peter Kasting
084f3871b1 Reland mysterious cast that improves performance. 
BUG=499241
TEST=none
TBR=andrew

Review URL: https://codereview.webrtc.org/1206683002

Cr-Commit-Position: refs/heads/master@{#9492}
 2015-06-23 22:04:37 +00:00
pkasting
6bfc82aaf1 Test whether removing a cast still hurts performance. 
BUG=499241
TEST=none
TBR=andrew

Review URL: https://codereview.webrtc.org/1206653002

Cr-Commit-Position: refs/heads/master@{#9491}
 2015-06-23 21:38:42 +00:00
tommi
39b31001d2 Change kEchoCancellation to be 'echoCancellation'. 
This is the second cl in WebRTC for this change and will be landed after Chromium has been updated to use kGooglEchoCancellation where that variant is required. See also the first part: https://codereview.webrtc.org/1179233003

BUG=webrtc:4747
R=andrew@webrtc.org

Review URL: https://codereview.webrtc.org/1185963003

Cr-Commit-Position: refs/heads/master@{#9490}
 2015-06-23 16:50:50 +00:00
Ivo Creusen
747d5f6268 Reland "Added ACM_dump protobuf, class for reading/writing and...", commit e9bdfd859c. 
Changed the BUILD.gn file that was lacking some necessary items which caused Chromium to break.
Original review: https://webrtc-codereview.appspot.com/52059005/

The revert of the original CL was commit 7a75415419.

BUG=webrtc:4741
R=henrik.lundin@webrtc.org

Review URL: https://codereview.webrtc.org/1200833002.

Cr-Commit-Position: refs/heads/master@{#9489}
 2015-06-23 08:08:17 +00:00
Guo-wei Shieh
97c9f8d198 Remove iostream which causes a new static initializer 
TBR=pthatcher@webrtc.org
BUG=webrtc:4576

Review URL: https://codereview.webrtc.org/1205553002.

Cr-Commit-Position: refs/heads/master@{#9488}
 2015-06-23 04:54:22 +00:00
pkasting
72cfd6c468 Reland remaining bits of "Upconvert various types to int." 
Most of commit cb180976dd (which reverted
commit 83ad33a8ae) was already re-landed.  This relands the rest, including modifications by kwiberg to hopefully avoid regressing performance.

In a subsequent change I will see if removing the int16_t cast in this modified version still causes perf problems.

BUG=499241
TEST=none
TBR=andrew

Review URL: https://codereview.webrtc.org/1181693005

Cr-Commit-Position: refs/heads/master@{#9487}
 2015-06-23 02:33:55 +00:00
ekm
db4fecfb01 Attempt to reland: Allow intelligibility to compile in apm (https://codereview.webrtc.org/1182323005/) 
Revert of original: https://codereview.webrtc.org/1187033005/

Changes in original:
- Added files to gyp and BUILD
- Made minor fixes to get everything to compile
    and intelligibility_proc to run
- Added comments
- Auto-reformatting

New Changes:
- Added <numeric> header to intelligibility_enhancer.cc to address buildbot errors
- Switched to use WAV for i/o in intelligibility_proc.cc to address windows errors
- clean up

Note: Patch 1 duplicates Patch 7 of https://codereview.webrtc.org/1182323005/

R=andrew@webrtc.org

Review URL: https://codereview.webrtc.org/1190733004.

Cr-Commit-Position: refs/heads/master@{#9486}
 2015-06-23 00:49:14 +00:00
jbauch
be24c94c95 Set / verify stats report timestamps. 
This CL updates the track report timestamps which were fixed at "0" before
and updates the timestamps in reports for local audio tracks.

Also the timestamps are checked in various tests to make sure no "0" is
returned.

Original CL is at https://webrtc-codereview.appspot.com/51829004/

BUG=webrtc:4316
TBR=hta@webrtc.org, pthatcher@webrtc.org

Review URL: https://codereview.webrtc.org/1204493002

Cr-Commit-Position: refs/heads/master@{#9485}
 2015-06-22 22:06:50 +00:00
henrik.lundin
6b4a564d21 Add UMA logging for target audio bitrate 
This CL logs the target audio bitrate to a UMA histogram called
WebRTC.Audio.TargetBitrateInKbps. It logs the rate when a codec is
created, and when the target is explicitly updated. Note that since
each codec implementation is free to change or ignore the target
value, there is no guarantee that the logged value will actually be
used as the target.

BUG=chromium:488124

Review URL: https://codereview.webrtc.org/1178053002

Cr-Commit-Position: refs/heads/master@{#9484}
 2015-06-22 13:35:22 +00:00
Erik Språng
bdc0b0d869 Use RtcpPacket classes for SenderReport/ReceiveReport in RTCPSender 
BUG=2450
R=asapersson@webrtc.org

Review URL: https://codereview.webrtc.org/1170723002.

Cr-Commit-Position: refs/heads/master@{#9483}
 2015-06-22 13:21:40 +00:00
pbos
9874ee0d7a Add temporal-layers option to video_loopback. 
BUG=
R=asapersson@webrtc.org, sprang@webrtc.org

Review URL: https://codereview.webrtc.org/1194533002

Cr-Commit-Position: refs/heads/master@{#9482}
 2015-06-22 11:44:30 +00:00
Guo-wei Shieh
ecb9a70c2d Add AsyncInvoker files for chromium GN build 
TBR=pthatcher@webrtc.org
BUG=4576

Review URL: https://codereview.webrtc.org/1196993003.

Cr-Commit-Position: refs/heads/master@{#9481}
 2015-06-22 06:37:09 +00:00
Peter Boström
6a688f5265 Add default downscale threshold to QualityScaler. 
Prevents downscaling below 160x90 or 90x160 to gain more quality.

BUG=4625
R=mflodman@webrtc.org

Review URL: https://codereview.webrtc.org/1160403004.

Cr-Commit-Position: refs/heads/master@{#9480}
 2015-06-22 06:03:07 +00:00
Peter Boström
2ee2439a1f Merge video_engine_core into webrtc target. 
Merges the two video targets since video_engine is no longer usable
standalone.

BUG=webrtc:1695
R=mflodman@webrtc.org, stefan@webrtc.org

Review URL: https://codereview.webrtc.org/1184763009.

Cr-Commit-Position: refs/heads/master@{#9479}
 2015-06-22 05:57:26 +00:00
Henrik Kjellander
e8d191f00f Restore rows() and cols() in aligned_array.h 
These getters were removed in https://codereview.webrtc.org/1172163004
but are used in external code, so it makes sense to keep
them around to make the class more useful.

R=henrikg@webrtc.org, pkasting@chromium.org

Review URL: https://codereview.webrtc.org/1178043005.

Cr-Commit-Position: refs/heads/master@{#9478}
 2015-06-20 18:11:02 +00:00
kjellander
6ee4816d6f Roll chromium_revision 6e6b751..9729297 (334984:335266) 
Relevant changes:
* src/third_party/icu: a05f412..00af1a4
* src/tools/gyp: fdcd8bc..5122240
Details: 6e6b751..9729297/DEPS

Clang version changed 238013:239765
Details: 6e6b751..9729297/tools/clang/scripts/update.sh

TBR=pbos@webrtc.org

Review URL: https://codereview.webrtc.org/1199543004

Cr-Commit-Position: refs/heads/master@{#9477}
 2015-06-20 16:12:37 +00:00
tandrii
04465d286e Revert of Fix PRESUBMIT.py after disabling CQ. (patchset #1 id:1 of https://codereview.webrtc.org/1192673003/) 
Reason for revert:
CQ-Rietveld combination now supports webrtc custom domain.

Original issue's description:
> Fix PRESUBMIT.py after disabling CQ.
>
> The disabling of CQ in https://codereview.webrtc.org/1177243003/
> broke PRESUBMIT.py since it's trying to read cq.cfg.
>
> BUG=501332
> TBR=phoglund@webrtc.org
>
> Committed: 141725f50f

TBR=phoglund@webrtc.org,kjellander@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=501332

Review URL: https://codereview.webrtc.org/1190283003

Cr-Commit-Position: refs/heads/master@{#9476}
 2015-06-20 11:00:52 +00:00
Henrik Kjellander
45fec22e07 Revert "Temporarily disabling CQ due to infrastructure problems." 
This reverts commit 380884e0f0 since
the CQ-Rietveld integration is now supporting codereview.webrtc.org.

BUG=501332
TBR=phoglund@webrtc.org

Review URL: https://codereview.webrtc.org/1197713007.

Cr-Commit-Position: refs/heads/master@{#9475}
 2015-06-20 10:52:51 +00:00
Niklas Enbom
7a75415419 Revert "Added ACM_dump protobuf, class for reading/writing and unittest." 
This reverts commit e9bdfd859c.

This CL makes the GN chrome bot fail, not really sure why...

FAILED: /mnt/data/b/build/goma/gomacc
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/third_party/webrtc/modules/audio_coding/main/acm2/acm_dump.acm_dump.o.d
-DRTC_AUDIOCODING_DEBUG_DUMP -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2
-DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1
-DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1
-DENABLE_SPELLCHECK=1 -DDONT_EMBED_BUILD_METADATA -DUSE_UDEV
-DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_PANGO=1
-DUSE_CAIRO=1 -DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1
-DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DENABLE_WEBRTC=1
-DENABLE_EXTENSIONS=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_TASK_MANAGER=1
-DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1
-DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1
-DENABLE_SERVICE_DISCOVERY=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_REMOTING=1
-DENABLE_GOOGLE_NOW=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_HIDPI=1
-DV8_USE_EXTERNAL_STARTUP_DATA -DENABLE_BACKGROUND=1 -DENABLE_PRE_SYNC_BACKUP
-DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL
-DSAFE_BROWSING_SERVICE -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1
-DCR_CLANG_REVISION=239765-1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
-D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG
-DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGOOGLE_PROTOBUF_NO_RTTI
-DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -I../.. -Igen
-I../../third_party/protobuf/src -Igen/protoc_out
-I../../third_party/protobuf/src -I../../third_party/protobuf
-fno-strict-aliasing -fstack-protector --param=ssp-buffer-size=4 -m64
-march=x86-64 -funwind-tables -fPIC -pipe -pthread
-B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -Wall
-Wsign-compare -Wendif-labels -Werror -Wno-missing-field-initializers
-Wno-unused-parameter -Wno-c++11-narrowing -Wno-char-subscripts
-Wno-covered-switch-default -Wno-deprecated-register
-Wno-unneeded-internal-declaration -Wno-reserved-user-defined-literal
-Wno-inconsistent-missing-override -fvisibility=hidden -Xclang -load -Xclang
../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang
-plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -add-plugin
-Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -O2 -fno-ident
-fdata-sections -ffunction-sections -g1 -gsplit-dwarf -fno-threadsafe-statics
-fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exceptions -c
../../third_party/webrtc/modules/audio_coding/main/acm2/acm_dump.cc -o
obj/third_party/webrtc/modules/audio_coding/main/acm2/acm_dump.acm_dump.o
../../third_party/webrtc/modules/audio_coding/main/acm2/acm_dump.cc:11:10: fatal
error: 'webrtc/modules/audio_coding/main/acm2/acm_dump.h' file not found
#include "webrtc/modules/audio_coding/main/acm2/acm_dump.h"
         ^
1 error generated.
ninja: build stopped: subcommand failed.

TBR=ivoc@webrtc.org
BUG=

Review URL: https://codereview.webrtc.org/1195963002.

Cr-Commit-Position: refs/heads/master@{#9474}
 2015-06-19 21:30:27 +00:00
Guo-wei Shieh
7f04b08d3b Issue 4780: disabling multiple_routes breaks Turn/Tcp. 
BUG=webrtc:4780
R=pthatcher@chromium.org
TBR=pthatcher@webrtc.org

Review URL: https://codereview.webrtc.org/1196453005.

Cr-Commit-Position: refs/heads/master@{#9473}
 2015-06-19 18:27:16 +00:00
Alejandro Luebs
f260fc2136 Revert "Pull the Voice Activity Detector out from the AGC" 
This reverts commit 34be126c1b.

It breaks Chromium ASAN.

TBR=niklas.enbom@webrtc.org

Review URL: https://codereview.webrtc.org/1192863006.

Cr-Commit-Position: refs/heads/master@{#9472}
 2015-06-19 18:24:01 +00:00
Alejandro Luebs
f5f8f52a4b Revert "Increase the kMaxNoiseProbability in voice_activity_detector_test" 
This reverts commit c9b0f67568.

It breaks Chromium ASAN.

TBR=niklas.enbom@webrtc.org
BUG=

Review URL: https://codereview.webrtc.org/1194963003.

Cr-Commit-Position: refs/heads/master@{#9471}
 2015-06-19 18:18:02 +00:00
Qiang Chen
d4cec15c75 Resolved Rebase Conflicts 
This is just https://webrtc-codereview.appspot.com/53629004/

Remove a constructor of VCMJitterBuffer.

Remove unnecessary factory use

Comment Fix

Move frame incoming simulation to the clock

DCHECK typo fix

Coding Style Fix

Rephrased some comments, and removed some virtual for override function.

Coding Style Fix

Coding Style Fix

Add a unittest for VCMReceiver::FrameForDecoding. Mainly test the time control algorithm.

BUG=

TBR=holmer@chromium.org

Review URL: https://codereview.webrtc.org/1173253008.

Cr-Commit-Position: refs/heads/master@{#9470}
 2015-06-19 16:17:10 +00:00
Niklas Enbom
76eea37ed0 Workaround a (Windows) linker bug when doing a PGO build. 
It looks like having a function that ends with "FATAL()" but doesn't also have a return value (even if it's useless).

This is causing a hang in link.exe when doing a PGO build (this has been blocking us from doing PGO builds for more than a month now). See https://connect.microsoft.com/VisualStudio/feedback/details/996802/link-exe-hang-during-the-pgo-optimization-step for more details.
BUG=chromium:491914
R=turaj@webrtc.org

Review URL: https://codereview.webrtc.org/1181033009.

Cr-Commit-Position: refs/heads/master@{#9469}
 2015-06-19 16:11:10 +00:00
Henrik Kjellander
39ffaeac6e Roll chromium_revision 441009c..6e6b751 (334775:334984) 
Relevant changes:
* src/third_party/boringssl/src: b0acb77..af0e32c
Details: 441009c..6e6b751/DEPS

Clang version was not updated in this roll.

R=pbos@webrtc.org

Review URL: https://codereview.webrtc.org/1187563009.

Cr-Commit-Position: refs/heads/master@{#9468}
 2015-06-19 07:28:12 +00:00
Alejandro Luebs
c9b0f67568 Increase the kMaxNoiseProbability in voice_activity_detector_test 
Because it breaks on Android.

TBR=ajm

Review URL: https://codereview.webrtc.org/1177043017.

Cr-Commit-Position: refs/heads/master@{#9467}
 2015-06-18 21:48:09 +00:00
Guo-wei Shieh
dc13abc331 Initially when the design was to do this experiment in browser, which doesn't have webrtc code, it requires some glue code to bridge the difference between what's available in webrtc::base and browser process. Now since we're moving to renderer process, we could reuse a lot of existing interfaces instead of rolling our own. 
BUG=webrtc:4576
R=pthatcher@webrtc.org

Review URL: https://codereview.webrtc.org/1173353002.

Cr-Commit-Position: refs/heads/master@{#9466}
 2015-06-18 21:44:46 +00:00
Alejandro Luebs
34be126c1b Pull the Voice Activity Detector out from the AGC 
This change generates bit-exact values when running through audioproc_f than before.

R=andrew@webrtc.org, bloch@google.com

Review URL: https://codereview.webrtc.org/1181933002.

Cr-Commit-Position: refs/heads/master@{#9465}
 2015-06-18 19:34:00 +00:00
Peter Boström
ae37abbf6a Remove implicit-int-conversion warnings. 
BUG=webrtc:1348, webrtc:261
R=stefan@webrtc.org

Review URL: https://codereview.webrtc.org/1184443005.

Cr-Commit-Position: refs/heads/master@{#9464}
 2015-06-18 17:00:47 +00:00
Stefan Holmer
ff4ea9310e Only use paced packets for estimating bitrate probes. 
BUG=4778
R=mflodman@webrtc.org, solenberg@webrtc.org

Review URL: https://codereview.webrtc.org/1188823007.

Cr-Commit-Position: refs/heads/master@{#9463}
 2015-06-18 14:01:43 +00:00
Henrik Kjellander
141725f50f Fix PRESUBMIT.py after disabling CQ. 
The disabling of CQ in https://codereview.webrtc.org/1177243003/
broke PRESUBMIT.py since it's trying to read cq.cfg.

BUG=501332
TBR=phoglund@webrtc.org

Review URL: https://codereview.webrtc.org/1192673003.

Cr-Commit-Position: refs/heads/master@{#9462}
 2015-06-18 13:05:40 +00:00
Henrik Lundin
3e89dbf458 Add AudioEncoder::GetTargetBitrate 
The GetTargetBitrate implementation will return the
target bitrate of the codec. This may differ from the
desired target bitrate, as set by SetTargetBitrate, depending on implementation.

Tests are updated to exercise the new functionality.

R=kwiberg@webrtc.org

Review URL: https://codereview.webrtc.org/1184313002.

Cr-Commit-Position: refs/heads/master@{#9461}
 2015-06-18 12:58:46 +00:00
Ivo Creusen
e9bdfd859c Added ACM_dump protobuf, class for reading/writing and unittest. 
This adds a class to read and write ACM_dump protobuf files. In this CL
it is not hooked up to actually store any packets or debug events.
The unittest writes two dummy RTP packets to disk and reads them to see
if they contain the expected data.

BUG=webrtc:4741
R=andrew@webrtc.org, henrik.lundin@webrtc.org, kjellander@webrtc.org, kwiberg@webrtc.org, tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/52059005

Cr-Commit-Position: refs/heads/master@{#9460}
 2015-06-18 11:04:35 +00:00
Henrik Kjellander
380884e0f0 Temporarily disabling CQ due to infrastructure problems. 
BUG=501332
TBR=phoglund@webrtc.org

Review URL: https://codereview.webrtc.org/1177243003.

Cr-Commit-Position: refs/heads/master@{#9459}
 2015-06-18 10:40:11 +00:00
Bjorn Volcker
7101269c61 Reland "Revert "audio_processing/aec: make delay estimator aware of starving farend buffer"" 
Original review at https://codereview.webrtc.org/1180423006

SystemDelayTests was not updated w.r.t. extended_filter mode and some tests were disabled on Android since DA-AEC is automatically set.
All tests have now been updated for both extended_filter mode as well as DA-AEC, hence are now enabled on Android.

Also
* Moves default settings of extended_filter and DA-AEC form Init() to Create() to avoid unintentional loss of state during a reset.
* Fixes a potential bug of starting from scratch in extended_filter mode + DA-AEC.

This reverts commit 01c9b012e9.

BUG=
R=henrik.lundin@webrtc.org

Review URL: https://codereview.webrtc.org/1187943005.

Cr-Commit-Position: refs/heads/master@{#9458}
 2015-06-18 09:05:03 +00:00
Henrik Kjellander
9d2fdac46d Roll chromium_revision a08e761..441009c (334571:334775) 
Relevant changes:
* src/third_party/boringssl/src: af0e32c..b0acb77
* src/tools/gyp: 127b311..fdcd8bc
Details: a08e761..441009c/DEPS

Clang version was not updated in this roll.

TBR=pbos@webrtc.org

Review URL: https://codereview.webrtc.org/1188193004.

Cr-Commit-Position: refs/heads/master@{#9457}
 2015-06-18 07:09:25 +00:00
Andrew MacDonald
2d627a6d5b Add missing include guards for audio_ring_buffer.h. Yikes. 
R=aluebs@webrtc.org
TBR=aluebs@webrtc.org

Review URL: https://codereview.webrtc.org/1191853003.

Cr-Commit-Position: refs/heads/master@{#9456}
 2015-06-17 18:39:44 +00:00
aluebs
c555b99c13 Revert of Allow intelligibility to compile in apm (patchset #1 id:1 of https://codereview.webrtc.org/1182323005/) 
Reason for revert:
Breaking the build bots: http://build.chromium.org/p/client.webrtc/builders/Mac32%20Release%20%5Blarge%20tests%5D/builds/4544

Fails to compile with this error:

../../webrtc/modules/audio_processing/intelligibility/intelligibility_enhancer.cc:218:25: error: no member named 'accumulate' in namespace 'std'
    power_target = std::accumulate(clear_variance_.variance(),

Original issue's description:
> Allow intelligibility to compile in apm
>
> - Added files to gyp and BUILD
> - Made minor fixes to get everything to compile
>     and intelligibility_proc to run
> - Added comments
> - Auto-reformatting
>
> Original cl is at: https://webrtc-codereview.appspot.com/57579004/
>
> TBR=aluebs@webrtc.org
>
> Committed: b7553dfdbb

TBR=ekmeyerson@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.webrtc.org/1187033005

Cr-Commit-Position: refs/heads/master@{#9455}
 2015-06-17 03:26:20 +00:00
ekm
b7553dfdbb Allow intelligibility to compile in apm 
- Added files to gyp and BUILD
- Made minor fixes to get everything to compile
    and intelligibility_proc to run
- Added comments
- Auto-reformatting

Original cl is at: https://webrtc-codereview.appspot.com/57579004/

TBR=aluebs@webrtc.org

Review URL: https://codereview.webrtc.org/1182323005.

Cr-Commit-Position: refs/heads/master@{#9454}
 2015-06-17 01:57:37 +00:00
Bjorn Volcker
01c9b012e9 Revert "audio_processing/aec: make delay estimator aware of starving farend buffer" 
The code only affects DA-AEC, but since DA-AEC is the default AEC if run on Android tests failed. Reverting to fix that test.

This reverts commit 9002cc426d.

BUG=
TBR=henrik.lundin@webrtc.org

Review URL: https://codereview.webrtc.org/1183243003.

Cr-Commit-Position: refs/heads/master@{#9453}
 2015-06-16 21:09:51 +00:00
Bjorn Volcker
9002cc426d audio_processing/aec: make delay estimator aware of starving farend buffer 
We've seen that if we get a buffer underrun followed by a sudden buffer build up the DA-AEC can't really catch up even though it should be possible to estimate the upcoming difference. We have a feature for this already, but that is only used in the regular AEC. This CL turns that feature on also for DA-AEC.

- Adds a helper function MoveFarReadPtrWithoutSystemDelayUpdate()
- Only apply conservative correction for positive delays, where we can put the AEC into a non-causal state
- Stuff the farend buffer if we don't have enough data to process w.r.t. to current nearend buffer.
- Always run delay estimation based on reported delays to catch buffer starvation.

BUG=
R=henrik.lundin@webrtc.org

Review URL: https://codereview.webrtc.org/1180423006.

Cr-Commit-Position: refs/heads/master@{#9452}
 2015-06-16 20:29:52 +00:00
kjellander
979e0b30f1 Define uint64 and int64 using long long. 
This is to avoid typedef collisions with some compile configurations.
For more info, see
https://blogs.oracle.com/nike/entry/ilp64_lp64_llp64
http://www.unix.org/whitepapers/64bit.html

BUG=4497

Review URL: https://codereview.webrtc.org/1186093004

Cr-Commit-Position: refs/heads/master@{#9451}
 2015-06-16 14:13:40 +00:00
Henrik Kjellander
6befa00b44 Add presubmit trybot to CQ config. 
BUG=470518
TESTED=Ran the trybot on this CL and it seems to work (but fails due to missing LGTM): I'll run it again when I got an LGTM.
R=phoglund@webrtc.org

Review URL: https://codereview.webrtc.org/1188793002.

Cr-Commit-Position: refs/heads/master@{#9450}
 2015-06-16 14:09:36 +00:00
kjellander
47cfc3a8a8 Roll chromium_revision 4e76e79..a08e761 (334321:334571) 
Relevant changes:
* src/tools/gyp: fdc7b81..127b311
Details: 4e76e79..a08e761/DEPS

Clang version was not updated in this roll.

BUG=

Review URL: https://codereview.webrtc.org/1175413005

Cr-Commit-Position: refs/heads/master@{#9449}
 2015-06-16 11:33:53 +00:00
kjellander
986ee082b6 Move default trybots configuration to CQ config. 
This is the same set of trybots that used to be configured in PRESUBMIT.py

BUG=470518
TBR=

Review URL: https://codereview.webrtc.org/1189583003

Cr-Commit-Position: refs/heads/master@{#9448}
 2015-06-16 11:32:16 +00:00
kjellander
f050b9dd9a Revert of Whitespace change (patchset #1 id:1 of https://codereview.webrtc.org/1182933006/) 
Reason for revert:
Testing the revert button with our new CQ.

Original issue's description:
> Whitespace change to test CQ
>
> BUG=
> TBR=
>
> Committed: https://crrev.com/fe23090c6144b2c03fce3c4f05fb6d469415d41c
> Cr-Commit-Position: refs/heads/master@{#9440}

TBR=tommi@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.webrtc.org/1180143006

Cr-Commit-Position: refs/heads/master@{#9447}
 2015-06-16 11:18:49 +00:00
Åsa Persson
24b4eda6f4 Add sent framerates to histogram stats: 
"WebRTC.Video.InputFramesPerSecond",
"WebRTC.Video.SentFramesPerSecond".

BUG=488243
R=pbos@webrtc.org, stefan@webrtc.org

Review URL: https://codereview.webrtc.org/1169543005.

Cr-Commit-Position: refs/heads/master@{#9446}
 2015-06-16 08:17:09 +00:00