wu@webrtc.org
4c3e9917e7
Make sure b lines appear before all the a lines. Per RFC 4566, the order of media description should be:
...
m= (media name and transport address)
i=* (media title)
c=* (connection information -- optional if included at
session level)
b=* (zero or more bandwidth information lines)
k=* (encryption key)
a=* (zero or more media attribute lines)
BUG=2260
R=jiayl@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/15889004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6708 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-16 21:03:13 +00:00
jiayl@webrtc.org
46fb331bc5
Add support of multiple STUN servers in UDPPort.
...
Now UDPPort signals PortComplete or PortError when the Bind requests for all STUN servers are responded or failed. If any STUN bind is successful, PortComplete is signaled; otherwise, PortError is signaled.
I discovered a bug in SocketAddress while working on this. It didn't consider two addresses unequal if they have unresolved IP and different hosts. It's fixed now.
BUG=3310
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/13879004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6707 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-16 20:55:31 +00:00
buildbot@webrtc.org
a8d8ad2be6
(Auto)update libjingle 71240799-> 71250251
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6705 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-16 14:23:08 +00:00
pbos@webrtc.org
38ce7d03d8
Implement unittest for SetSendCodecsChangesExistingStreams.
...
BUG=1788
R=pbos@webrtc.org , wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/19869004
Patch from Changbin Shao <changbin.shao@intel.com>.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6699 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-16 08:01:38 +00:00
tommi@webrtc.org
47218956fc
Minor refactoring of StatsCollector.
...
* Make GetTimeNow a static method in the cc file.
* Make GetTransportIdFromProxy a static method as well and not a class method.
The second change is in preparation of removing the proxy_to_transport_ member variable which isn't needed and is just a copy from the session stats.
R=xians@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/20959004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6696 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-15 19:22:37 +00:00
tkchin@webrtc.org
42fe4350fe
Remove Thread::RunningForChannelManager().
...
I haven't heard of this failing, so it should be safe to remove. Let me know if this isn't the case.
BUG=3388
R=andrew@webrtc.org , wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/18659004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6695 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-15 17:52:43 +00:00
tommi@webrtc.org
2adc51c86e
Handle the case if an unusually long peer name is provided in the peerconnection example.
...
R=xians@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/21899004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6687 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-15 08:56:07 +00:00
pbos@webrtc.org
cb859ecd3b
Replace strcpy with talk_base::strcpyn.
...
Cpplint reports error 'Almost always, snprintf is better than strcpy'
when checking code styles. The function talk_base::strcpyn() is a better
option than strcpy().
BUG=1788
R=pbos@webrtc.org , wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12919004
Patch from Changbin Shao <changbin.shao@intel.com>.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6686 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-15 08:28:20 +00:00
henrike@webrtc.org
1b84116417
Add a facility to the Thread class to catch blocking regressions.
...
This facility should be used in methods that run on known threads
(e.g. signaling, worker) and do not have blocking thread syncronization
operations via the Thread class such as Invoke, Sleep, etc.
This is a reland of an already reviewed cl (r6679) that got reverted by mistake.
TBR=xians@google.com ,tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/21889004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6682 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-14 21:42:39 +00:00
tkchin@webrtc.org
b038c72369
Enable SCTP compile for iOS.
...
Chromium's been updated to pull a version of usrsctplib that will compile correctly. This update DEPS to point at new revision and turn on the compile time flags for iOS sctp.
BUG=3211
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/13929004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6681 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-14 20:24:09 +00:00
buildbot@webrtc.org
aac14973aa
(Auto)update libjingle 71116846-> 71117224
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6680 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-14 20:22:21 +00:00
tommi@webrtc.org
5be649fcfc
Add a facility to the Thread class to catch blocking regressions.
...
This facility should be used in methods that run on known threads
(e.g. signaling, worker) and do not have blocking thread syncronization
operations via the Thread class such as Invoke, Sleep, etc.
This is a reland of an already reviewed cl that got reverted by mistake.
TBR=xians@google.com
Review URL: https://webrtc-codereview.appspot.com/12999004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6679 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-14 20:21:36 +00:00
tommi@webrtc.org
242068d58c
A step towards changing StatsReport::Value::name to an enum.
...
The stats reporting code does a lot of unnecessary string copying.
This is a step in the direction of removing that and forcing use of only known constants.
This is a reland of an already reviewed cl that got reverted by mistake.
TBR=xians@google.com
Review URL: https://webrtc-codereview.appspot.com/12989004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6678 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-14 20:19:56 +00:00
tommi@webrtc.org
03505bcb7a
Make StatsCollector depend on always having a valid session pointer.
...
This is required since the session pointer is currently used on multiple threads but there's no synchronization code to guard it.
I'm removing the set_session() method and session() getter since they would cause problems if used without synchronization.
This is a reland of an already reviewed cl that got reverted by mistake.
TBR=xians@google.com
Review URL: https://webrtc-codereview.appspot.com/13959004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6677 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-14 20:15:26 +00:00
tommi@webrtc.org
b5348c64bb
Minor refactoring of the session classes.
...
Make member variables that never change and are touched on multiple threads, const.
Move implementations of setters/getters of variables that can change, into the cc file in preparation of adding thread correctness checks.
This is a relanding of a cl already reviewed but got reverted by mistake.
TBR=xians@google.com
Review URL: https://webrtc-codereview.appspot.com/12979004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6676 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-14 20:11:49 +00:00
buildbot@webrtc.org
d8524348bb
(Auto)update libjingle 71107853-> 71115715
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6675 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-14 20:05:09 +00:00
buildbot@webrtc.org
b92f6f9371
(Auto)update libjingle 71099685-> 71107853
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6674 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-14 18:22:37 +00:00
jiayl@webrtc.org
5f43ce6784
Fix a type cast issue for compiling webrtc with BoringSSL.
...
BUG=
R=juberti@google.com , juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/16039004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6672 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-14 16:42:46 +00:00
buildbot@webrtc.org
e04cb0eb81
(Auto)update libjingle 70948025-> 70959275
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6671 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-14 14:54:16 +00:00
pbos@webrtc.org
ccbed3b3c4
Implement unittest SetRecvCodecsAcceptDefaultCodecs.
...
BUG=1788
R=pbos@webrtc.org , wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14869004
Patch from Changbin Shao <changbin.shao@intel.com>.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6663 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-11 13:02:54 +00:00
buildbot@webrtc.org
72670206db
(Auto)update libjingle 70813271-> 70818369
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6642 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-09 20:40:58 +00:00
jiayl@webrtc.org
4b1f330b4f
Fix a bug in SocketAddress where "a.b.c.d:1" and "b.b.c.d:1" are incorrectly considered equal.
...
BUG=3558
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/18749004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6639 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-09 19:14:24 +00:00
tommi@webrtc.org
e9cefdef68
Improve libjingle's ASSERT and VERIFY macros on Windows.
...
This change has the effect that when using a debugger, a failing ASSERT/VERIFY will break exactly where the failing expression is and not two callstacks up.
Minidumps (for debug builds) will also have the failing expression at the top of the call stack.
R=xians@webrtc.org , xians
Review URL: https://webrtc-codereview.appspot.com/12929004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6633 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-09 08:04:12 +00:00
xians@webrtc.org
01bda2068b
Fixed the stats problem when new track is using the same ssrc as the previous track.
...
Before this patch, when switching from voice mode to stereo mode, the stats won't be updated because StatsCollector binded the ssrc report with the old track, so the report can't be updated by the new track.
This patch fixes the porblem by changing the ssrc report track id to use the new track id.
TEST=libjingle_peerconnection_unittest --gtest_filter="*StatsCollectorTest*"
R=hta@chromium.org
Review URL: https://webrtc-codereview.appspot.com/17859004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6632 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-09 07:38:38 +00:00
buildbot@webrtc.org
55535d4e58
(Auto)update libjingle 70711261-> 70733822
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6627 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-08 18:18:55 +00:00
tommi@webrtc.org
ecb8723402
Change Timing::WallTimeNow to be static.
...
There's no need to construct a Timing object to call this method.
On Windows we were unnecessarily calling CreateWaitableTimer + CloseHandle but never actually using that waitable timer.
There's otherwise no change in functionality.
R=xians@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/20869004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6624 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-08 12:48:29 +00:00
mallinath@webrtc.org
a70be68f65
Disabling shared socket mode for TURN ports. This is done as currently when
...
TURN server also used as STUN server, binding responses will be handed over
to TURN port, which simply discard these messages, as requests are originated
from StunPort.
Until we find the right solution for this problem, it's better we disable this
feature.
BUG=https://code.google.com/p/webrtc/issues/detail?id=3537
R=jiayl@webrtc.org , juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/19889004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6618 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-07 20:47:24 +00:00
pbos@webrtc.org
bd249bc711
Remove GetDefaultConfigs() from Call.
...
Defaults for configs are instead placed in the Config constructors.
BUG=
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/18729004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6608 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-07 04:45:15 +00:00
buildbot@webrtc.org
3ffa1f917e
(Auto)update libjingle 70422491-> 70424781
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6586 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-02 19:51:26 +00:00
buildbot@webrtc.org
0bb9fac98c
(Auto)update libjingle 70343444-> 70394475
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6581 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-02 11:54:09 +00:00
buildbot@webrtc.org
d8a9069080
(Auto)update libjingle 70340027-> 70343444
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6579 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-01 19:26:43 +00:00
tkchin@webrtc.org
74bf7a6523
Add tkchin@ to OWNERS.
...
Adding myself to OWNERS of subdirectories containing iOS bits. Added niklas.enbom@ for audio_device and wu@ for everything else.
R=niklas.enbom@webrtc.org , wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/18669004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6578 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-01 18:38:28 +00:00
jiayl@webrtc.org
974bbbb352
Fix uninitialized value in DtlsTransport and TransportDescription.
...
BUG=crbug/390304
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/21779004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6577 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-01 18:33:07 +00:00
buildbot@webrtc.org
6335645400
(Auto)update libjingle 70329914-> 70330023
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6575 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-01 16:46:01 +00:00
kjellander@webrtc.org
0402515d35
Implement command line flags for peerconnection client example on Windows
...
Adding the flags and functionality for 'autoconnect', 'autocall', 'server',
'port', and 'help' like in the linux example.
BUG=3459
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/13609004
Patch from Vicken Simonian <vsimon@gmail.com>.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6573 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-01 16:28:13 +00:00
henrike@webrtc.org
d5a0506e84
Use X509_NAME, not struct X509_name_st.
...
Also include openssl/x509.h explicitly since we're using functions and types
from it.
BUG=none
R=henrike@webrtc.org , wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12859004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6569 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-30 20:38:56 +00:00
buildbot@webrtc.org
bfa758a54c
(Auto)update libjingle 70004190-> 70103367
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6555 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-27 16:04:43 +00:00
pbos@webrtc.org
269605ce45
Implement SetSendCodecs() unit tests for WebRtcVideoChannel2.
...
BUG=
R=pbos@webrtc.org , wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12829004
Patch from Changbin Shao <changbin.shao@intel.com>.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6543 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-26 08:49:03 +00:00
buildbot@webrtc.org
420ca434b1
(Auto)update libjingle 69860953-> 70002228
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6542 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-26 08:08:40 +00:00
wu@webrtc.org
ec9f5fb34c
Change SdpSerializeCandidate to output candidate line without the "a=" and without the leading \r\n", i.e. candidate-attribute as defined in section 15.1 of [ICE].
...
BUG=crbug/387632
R=juberti@google.com
Review URL: https://webrtc-codereview.appspot.com/17779004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6533 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-24 17:05:10 +00:00
aluebs@webrtc.org
9a4f651037
Disable PhysicalSocketTest.TestUdpReadyToSendIPv4 for TSAN2
...
BUG=webrtc:3498
R=henrik.lundin@webrtc.org
TBR=tommi
Review URL: https://webrtc-codereview.appspot.com/21689005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6528 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-24 08:35:39 +00:00
buildbot@webrtc.org
71dffb76dc
(Auto)update libjingle 69648312-> 69830415
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6527 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-24 07:24:49 +00:00
wu@webrtc.org
ff1b1bf094
When creating an answer, takes the codec preference from the offer.
...
This change is based on RFC3264:
"Although the answerer MAY list the formats in their desired order of preference, it is RECOMMENDED that unless there is a specific reason, the answerer list formats in the same relative order they were present in the offer."
BUG=2868
TEST=unit tests and manually with munge-sdp test
R=juberti@google.com
Review URL: https://webrtc-codereview.appspot.com/14589004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6514 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-20 20:57:42 +00:00
buildbot@webrtc.org
0d15159b04
(Auto)update libjingle 69634309-> 69640360
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6512 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-20 19:02:09 +00:00
jiayl@webrtc.org
b43c99de29
Limits the send and receive buffer by bytes, not by packets.
...
The new limit is 16MB for each buffer.
Also refactors the code to handle send failure more consistently.
BUG=3429
R=juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/21559005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6511 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-20 17:11:14 +00:00
jiayl@webrtc.org
db397e5c6c
Re-evalutes the ICE role on ICE restart.
...
Also unifies the logic of ICE restart.
BUG=1775
R=juberti@google.com , juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/20619004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6510 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-20 16:32:09 +00:00
buildbot@webrtc.org
bb2d65895b
(Auto)update libjingle 69617317-> 69623266
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6508 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-20 14:58:56 +00:00
buildbot@webrtc.org
75ce92086c
(Auto)update libjingle 69600065-> 69617317
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6507 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-20 12:30:24 +00:00
pbos@webrtc.org
83785d37d1
Remove unused ALLOCATE_DELAY constant.
...
Breaks linux_tsan2 compile [-Wunused-const-variable].
TBR=mallinath@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/20749004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6505 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-20 10:28:39 +00:00
buildbot@webrtc.org
4c25c67146
(Auto)update libjingle 69589535-> 69600065
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6504 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-20 04:42:34 +00:00