This should fix the following error I'm seeing in Win8 GN trybot:
e:\b\build\slave\win_gn\build\src\third_party\webrtc\modules\bitrate_controller\bitrate_controller_impl.cc(78)
: error C2220: warning treated as error - no 'object' file generated
e:\b\build\slave\win_gn\build\src\third_party\webrtc\modules\bitrate_controller\bitrate_controller_impl.cc(30)
: warning C4373:
'webrtc::BitrateControllerImpl::RtcpBandwidthObserverImpl::OnReceivedEstimatedBitrate':
virtual function overrides 'webrtc::RtcpBandwidthObserver::OnReceivedEstimatedBitrate',
previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers
e:\b\build\slave\win_gn\build\src\third_party\webrtc\modules\rtp_rtcp\interface\rtp_rtcp_defines.h(286)
: see declaration of 'webrtc::RtcpBandwidthObserver::OnReceivedEstimatedBitrate'
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gn_dbg/builds/23/steps/compile/logs/stdio
The above was triggered in CL https://codereview.chromium.org/802113002/
BUG=None
R=kjellander@google.com, kjellander@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/37409004
Patch from Thiago Farina <tfarina@chromium.org>.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7911 4adac7df-926f-26a2-2b94-8c16560cd09d
This fixes a variety of MSVC warnings about value truncations when implicitly
storing the 64-bit values we get back from e.g. TimeTicks in 32-bit objects, and
removes the need for a number of explicit casts.
This also moves a number of constants so they're declared right where they're used, which is easier to read and maintain, and makes some of them of integral type rather than using the "enum hack".
BUG=chromium:81439
TEST=none
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/33649004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7905 4adac7df-926f-26a2-2b94-8c16560cd09d
GetRTT() was separated from GetRTPStatistics() but the warnings were not updated.
Now GetRTT() is only only used by GetRTPStatistics() and the warning pops up pointlessly and too often.
This CL is to suppress these warnings and maintain a proper warning for GetRTPStatistics().
BUG=
R=henrika@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/36469004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7899 4adac7df-926f-26a2-2b94-8c16560cd09d
This intrinsics version gives bit-exact result as the current assembly
neon code. And the performance is 38% better than current assembly
neon version, 5.92 times faster than current C version. The test runs
under Cortex-a53 aarch32 mode, other cpu should give similar performance
result.
BUG=4002
R=andrew@webrtc.org, jridges@masque.com
Change-Id: I257e33ef6d634a519fd71adc4f52b06dd655bd9d
Review URL: https://webrtc-codereview.appspot.com/32749004
Patch from Zhongwei Yao <zhongwei.yao@arm.com>.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7891 4adac7df-926f-26a2-2b94-8c16560cd09d
Expose adapter_type from Candidate such that we could add jmidata on top of this.
Created a new type of report just for Ice candidate. The candidate's id is used as part of report identifier. This code change only reports the best connection's local candidate's adapter type. There should be cleaning later to move other candidate's attributes to the new report.
This is migrated from issue 32599004
BUG=
R=juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/36379004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7885 4adac7df-926f-26a2-2b94-8c16560cd09d
This provides more flexibility if some component in AudioProcessing wants to operate before downmixing.
Now the AudioProcessing does only track the processing rate, but not the processing number of channels. This is tracked by the AudioBuffer itself and can be changed at any time to one smaller or equal the input number of channels. For each chunk it is reset to input number of channels and the end it should be equal to the output number of channels.
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/28169004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7879 4adac7df-926f-26a2-2b94-8c16560cd09d
Original cl description:
Change Android PeerConnectionUnittest to build using Chrome macros.
The purpose is to be able to run the tests using Chromes buildbots. To run:
CHECKOUT_SOURCE_ROOT=`pwd` build/android/test_runner.py instrumentation --test-apk=libjingle_peerconnection_android_unittest
This also add a new build target to build java PeerConnection using Chromes build macros.
BUG=4031
R=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/26349004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7874 4adac7df-926f-26a2-2b94-8c16560cd09d
This will make it easier to execute tests and allows
for more cleanup in the buildbot recipes.
Now tests can be listed using:
webrtc/build/android/test_runner.py gtest --help
and executed like
webrtc/build/android/test_runner.py gtest -s audio_decoder_unittests
TESTED=
Ran:
webrtc/build/android/test_runner.py gtest --help
and verified the tests were listed.
I wiped /sdcard/resources on my device, executed:
webrtc/build/android/test_runner.py gtest -s audio_decoder_unittests
and verified it passed and that resources/audio_coding/testfile32kHz.pcm
was copied to the device.
BUG=
R=phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/33619004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7873 4adac7df-926f-26a2-2b94-8c16560cd09d
It was not clear how one could know if ACM is using DTX from WebRTC or codec internal DTX.
This CL makes better use of IsInternalDTXReplacedWithWebRtc() which was designed for G.729 to export such information.
Before
IsInternalDTXReplacedWithWebRtc() gives true only if codec == G729 and G729's internal DTX is replaced with WebRTC DTX.
Now
IsInternalDTXReplacedWithWebRtc() gives true also when codec does not have internal DTX, i.e., must use WebRTC DTX, which is much more logical.
BUG=
R=henrik.lundin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/35459004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7870 4adac7df-926f-26a2-2b94-8c16560cd09d
