generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
7,170 Commits 1 Branch 0 Tags 108 MiB
C++ 76%
C 16%
Python 2.3%
Java 2.1%
Objective-C++ 1.5%
Other 1.9%
0198933b3d
Go to file
kjellander@webrtc.org 0198933b3d Cleanup: Remove 'const' qualifier from OnReceivedEstimatedBitrate(). 
This should fix the following error I'm seeing in Win8 GN trybot:

e:\b\build\slave\win_gn\build\src\third_party\webrtc\modules\bitrate_controller\bitrate_controller_impl.cc(78)
: error C2220: warning treated as error - no 'object' file generated
e:\b\build\slave\win_gn\build\src\third_party\webrtc\modules\bitrate_controller\bitrate_controller_impl.cc(30)
: warning C4373:
'webrtc::BitrateControllerImpl::RtcpBandwidthObserverImpl::OnReceivedEstimatedBitrate':
virtual function overrides 'webrtc::RtcpBandwidthObserver::OnReceivedEstimatedBitrate',
previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers
e:\b\build\slave\win_gn\build\src\third_party\webrtc\modules\rtp_rtcp\interface\rtp_rtcp_defines.h(286)
: see declaration of 'webrtc::RtcpBandwidthObserver::OnReceivedEstimatedBitrate'

http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gn_dbg/builds/23/steps/compile/logs/stdio

The above was triggered in CL https://codereview.chromium.org/802113002/

BUG=None
R=kjellander@google.com, kjellander@webrtc.org, tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/37409004

Patch from Thiago Farina <tfarina@chromium.org>.

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7911 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-16 12:29:59 +00:00
chromium Roll chromium_revision 6455c69..deaf2f7 (293954:295079) 2014-09-27 18:10:30 +00:00
data Revert "Revert part of r7561, "Refactor audio conversion functions."" 2014-10-31 04:58:14 +00:00
resources resources/audio_processing: Removed unused test files 2014-12-15 15:57:11 +00:00
talk Revert "Add adapter_type into Candidate object." 2014-12-16 05:28:10 +00:00
third_party GN: Enable libvpx, add link target and convert some test targets 2014-09-30 18:05:02 +00:00
tools Deleting quality dashboard code. 2014-12-11 07:57:22 +00:00
webrtc Cleanup: Remove 'const' qualifier from OnReceivedEstimatedBitrate(). 2014-12-16 12:29:59 +00:00
.clang-format Style-option file for clang-format. 2013-11-25 15:30:37 +00:00
.gitignore Merge audio_processing changes. 2014-12-15 09:41:24 +00:00
all.gyp Revert r7886:7887. 2014-12-15 07:03:04 +00:00
android-webrtc.mk Changed a flag in ARM build for platform build. 2012-09-08 00:32:59 +00:00
AUTHORS This fixes a small memory leak (found using Xcode/Instruments on iOS) in 2014-11-05 22:01:53 +00:00
BUILD.gn Initial GN work for WebRTC 2014-06-17 08:54:03 +00:00
check_root_dir.py Remove root_dir variable from DEPS + enforce rename. 2014-10-09 09:11:27 +00:00
codereview.settings Add FORCE_HTTPS_COMMIT_URL to codereview.settings. 2014-12-01 09:09:07 +00:00
COPYING Libjingle in webrtc needs updated AUTHORS, COPYING, LICENSE_THIRD_PARTY AND README. 2013-07-16 18:04:56 +00:00
DEPS Roll chromium_revision 24b4c73..8e72e1d 2014-12-08 11:48:35 +00:00
drover.properties Add a drover.properties file for reference. 2013-05-30 18:15:54 +00:00
libvpx.mk Change android makefile to reflect recent file structure change 2011-07-13 17:49:49 +00:00
LICENSE Updated license path in LICENSE and LICENSE_THIRD_PARTY. 2012-11-22 12:06:21 +00:00
license_template.txt Update template to follow chromium copyright style 2013-04-24 01:01:28 +00:00
LICENSE_THIRD_PARTY Libjingle in webrtc needs updated AUTHORS, COPYING, LICENSE_THIRD_PARTY AND README. 2013-07-16 18:04:56 +00:00
OWNERS Add kjellander as PRESUBMIT.py OWNER 2014-11-04 17:06:31 +00:00
PATENTS Add references to src/ copies for LICENSE etc. 2011-10-26 01:05:07 +00:00
PRESUBMIT.py PRESUBMIT: Add check for checkdeps. 2014-12-08 13:00:30 +00:00
setup_links.py Roll chromium_revision d8c9041..309cf65 2014-11-27 10:41:04 +00:00
sync_chromium.py Roll chromium_revision d8c9041..309cf65 2014-11-27 10:41:04 +00:00
WATCHLISTS Add myself to common_audio and audio_processing watchlists 2014-09-11 10:11:43 +00:00