generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
7,506 Commits 1 Branch 0 Tags 108 MiB
bc3241a8cc
Commit Graph

7506 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
tommi@webrtc.org
bc3241a8cc Update ProcessCallAfterXms to better match the performance of our faster bots. Previously I had made sure these tests didn't flake out on our slow trybots, but apparently I need to do the same for the fast bots :) 
TBR=bjornv@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/40659004

Cr-Commit-Position: refs/heads/master@{#8262}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8262 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-06 11:28:41 +00:00
tommi@webrtc.org
0c3e12b7bf Revamp the ProcessThreadImpl implementation. 
* Add a new WakeUp method that gives a module a chance to be called back right away on the worker thread.
* Wrote unit tests for the class.
* Significantly reduce the amount of locking.
  - ProcessThreadImpl itself does a lot less locking.
  - Reimplemented the way we keep track of when to make calls to Process.
    This reduces the amount of calls to TimeUntilNextProcess and since most implementations of that function grab a lock, this means less locking.
* Renamed ProcessThread::CreateProcessThread to ProcessThread::Create.
* Added thread checks for Start/Stop.  Threading model of other functions is now documented.
* We now log an error if an implementation of TimeUntilNextProcess returns a negative value (some implementations do, but the method should only return a positive nr of ms).
* Removed the DestroyProcessThread method and instead force callers to use scoped_ptr<> to maintain object lifetime.

BUG=2822
R=henrika@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/35999004

Cr-Commit-Position: refs/heads/master@{#8261}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8261 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-06 09:44:45 +00:00
pbos@webrtc.org
75025434bf Base RWLockWrapper on rtc::SharedExclusiveLock. 
Also moves rtc::Event and rtc::SharedExclusiveLock to rtc_base_approved.

R=tommi@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/38889004

Cr-Commit-Position: refs/heads/master@{#8260}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8260 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-06 08:33:15 +00:00
kjellander@webrtc.org
5e05731b0f Roll chromium_revision cd35af6..598c3e9 
Relevant changes:
* src/third_party/android_tools: aaeda3d..f6e2370
* src/third_party/boringssl/src: be629e0..8f5e2eb
Details: cd35af6..598c3e9/DEPS

Clang version was not updated in this roll.

TBR=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/37949004

Cr-Commit-Position: refs/heads/master@{#8259}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8259 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-06 07:25:16 +00:00
guoweis@webrtc.org
57ac2c84dd Default destination used by c line should be IPv4 only to avoid parsing error in legacy client. 
Make sure the IP family overwrites the preference of candidates. Also,
make sure only UDP is used as default destination.

BUG=4269
R=juberti@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/36009004

Cr-Commit-Position: refs/heads/master@{#8258}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8258 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-06 00:45:43 +00:00
guoweis@webrtc.org
3e733a43f5 Cleanup: unify rotation to be enum based instead of int for degree. 
Split from https://webrtc-codereview.appspot.com/37029004/

BUG=4145
R=pthatcher@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/37129004

Cr-Commit-Position: refs/heads/master@{#8257}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8257 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-05 23:40:43 +00:00
jan.skoglund@webrtc.org
74d27884af Remove defined(__cplusplus) tests in C++ code. 
This header is a C++ header (it contains keywords such as 'class'
and 'public'). It is not necessary to test defined(__cplusplus).
That test is appropriate in a C header that may be included by C++
code.

R=henrik.lundin@webrtc.org, jan.skoglund@webrtc.org, sprang@webrtc.org
BUG=none

Review URL: https://webrtc-codereview.appspot.com/38899004

Cr-Commit-Position: refs/heads/master@{#8256}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8256 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-05 19:18:21 +00:00
henrik.lundin@webrtc.org
f45c8ca88b Reland r8248 "Introduce ACMGenericCodecWrapper" 
This effectively reverts r8249.

This new class inherits from ACMGenericCodec. The purpose is to wrap
AudioEncoder objects into an ACMGenericCodec interface. This is a
temporary construction that will be used during the ACM redesign work.

BUG=4228
COAUTHOR=kwiberg@webrtc.org
TBR=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/38919004

Cr-Commit-Position: refs/heads/master@{#8255}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8255 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-05 18:30:16 +00:00
aluebs@webrtc.org
ec4521cdb4 Clean up Beamformer initialization 
This generates bit-exact output.

R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/37939004

Cr-Commit-Position: refs/heads/master@{#8254}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8254 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-05 18:17:11 +00:00
glaznev@webrtc.org
e69220ca84 Fix the value of the first byte of nal unit 
generated by fake H.264 encoder.

BUG=
R=kjellander@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/38849004

Cr-Commit-Position: refs/heads/master@{#8253}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8253 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-05 17:56:44 +00:00
glaznev@webrtc.org
f6932297e7 Fix Android video renderer to support video frames 
with stride > width.

Recent libvpx update generates output video frames with stride
value greater than width, which was not supported by Android OpenGL
video renderer (Android GLES2 doesn't have GL_UNPACK_ROW_LENGTH
to provide stride information for buffer in glTexImage2D call).

Fix it by implementing native frame copying for Java
VideoRenderer.I420Frame implementation.

BUG=4248
R=braveyao@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/40639004

Cr-Commit-Position: refs/heads/master@{#8252}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8252 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-05 17:30:17 +00:00
bjornv@webrtc.org
cc64a9cc4f voice_engine: Updates GetEcDelayMetrics() w.r.t. new metric 
As of r8230 (https://webrtc-codereview.appspot.com/39739004/) a new Echo Delay Metric was added calculating the fraction of poor values that may cause the AEC to fail. There are currently two methods for GetDelayMetrics() in webrtc::AutioProcessing and one is deprecated.

This CL updates
- GetEcDelayMetrics()
- voe_auto_test
- talk/media/(fake)webrtcvoiceengine

BUG=N/A
TESTED=locally and trybots
R=pbos@webrtc.org, tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/41749004

Cr-Commit-Position: refs/heads/master@{#8251}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8251 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-05 12:53:24 +00:00
pbos@webrtc.org
4b9622fb1e Roll gtest-parallel. 
Brings in a patch that reports the exit code for a failing test.

Also adding myself to new OWNERS file under gtest-parallel.

BUG=4234
R=kjellander@webrtc.org, mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/34119004

Cr-Commit-Position: refs/heads/master@{#8250}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8250 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-05 12:37:42 +00:00
henrik.lundin@webrtc.org
3a87630629 Revert r8248 "Introduce ACMGenericCodecWrapper" 
This reverts r8248 due to some build bot failures.

TBR=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/40649004

Cr-Commit-Position: refs/heads/master@{#8249}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8249 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-05 09:37:11 +00:00
henrik.lundin@webrtc.org
af8c13f2a1 Introduce ACMGenericCodecWrapper 
This new class inherits from ACMGenericCodec. The purpose is to wrap
AudioEncoder objects into an ACMGenericCodec interface. This is a
temporary construction that will be used during the ACM redesign work.

BUG=4228
COAUTHOR=kwiberg@webrtc.org
R=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/34939004

Cr-Commit-Position: refs/heads/master@{#8248}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8248 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-05 09:20:18 +00:00
tommi@webrtc.org
5d32f43219 Disable CondVarTest.InitFunctionsWork. 
The order of Sleep/Wake calls doesn't seem to be guaranteed, so this test
is flaky.

BUG=4262
TBR=bjornv@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/37189004

Cr-Commit-Position: refs/heads/master@{#8247}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8247 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-05 06:26:35 +00:00
pthatcher@webrtc.org
877ac765ad Cleanup and prepare for bundling. 
- Add a GetOptions function. Needed for eventual bundle testing to
  confirm that channel options are preserved.
- Simplify unit tests and cleanup unused code.

This is a re-roll of 8237 (https://webrtc-codereview.appspot.com/39699004) with a default GetOption implementation.

R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/38909004

Cr-Commit-Position: refs/heads/master@{#8245}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8245 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-04 22:03:41 +00:00
henrik.lundin@webrtc.org
cf7efeba37 Add new AudioEncoderOpusTest 
This test will replace AcmOpusTest when ACMOpus is removed. The old
AcmOpusTest also contains tests for setting and updating the
"application" setting in Opus. However, in the new AudioEncoderOpus
class, the application is trivially set in the Config struct at
construction, wherefore a test is no longer needed.

BUG=3926
R=minyue@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/37929004

Cr-Commit-Position: refs/heads/master@{#8244}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8244 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-04 15:34:40 +00:00
bjornv@webrtc.org
520a69e8ea Revert 8238 "Add RefCounting for TransportProxies" 
Failing on Mac64_Debug

> Add RefCounting for TransportProxies
> 
> BUG=1574
> R=pthatcher@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/37869004

TBR=decurtis@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/37159004

Cr-Commit-Position: refs/heads/master@{#8243}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8243 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-04 12:46:13 +00:00
tommi@webrtc.org
875c97ed9d Remove SetNotAlive method from the thread class. 
Also cleaning up methods with the same name in other classes that are derived from the above method.

R=perkj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/41759004

Cr-Commit-Position: refs/heads/master@{#8242}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8242 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-04 11:12:39 +00:00
bjornv@webrtc.org
c5f697135e Revert 8237 "Cleanup and prepare for bundling." 
libjingle_peerconnection_objc_test consistently failing on Mac64 Debug.

> Cleanup and prepare for bundling.
> 
> - Add a GetOptions function. Needed for eventual bundle testing to
>   confirm that channel options are preserved.
> - Simplify unit tests and cleanup unused code.
> 
> BUG=1574
> R=pthatcher@webrtc.org, tommi@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/39699004

TBR=pthatcher@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/34959004

Cr-Commit-Position: refs/heads/master@{#8241}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8241 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-04 10:22:43 +00:00
bjornv@webrtc.org
dc096f2c7e system_wrappers: Disabled flaky test CondVarTest.PassBatonMultipleTimes 
Has been flaky on Win since r8220.
Disabling for now.

BUG=4262
TBR=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/37149004

Cr-Commit-Position: refs/heads/master@{#8240}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8240 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-04 09:14:42 +00:00
asapersson@webrtc.org
4414939954 Add method for incrementing RtpPacketCounter. Removes duplicate code. 
Correction to check if rtx is enabled on send-side (and not receive) when updating rtx send bitrate stat.

Remove unneeded guarded by annotations.

BUG=
R=mflodman@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/41729004

Cr-Commit-Position: refs/heads/master@{#8239}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8239 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-04 08:35:21 +00:00
decurtis@webrtc.org
e2506670a4 Add RefCounting for TransportProxies 
BUG=1574
R=pthatcher@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/37869004

Cr-Commit-Position: refs/heads/master@{#8238}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8238 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-03 23:19:23 +00:00
pthatcher@webrtc.org
af01d93aa2 Cleanup and prepare for bundling. 
- Add a GetOptions function. Needed for eventual bundle testing to
  confirm that channel options are preserved.
- Simplify unit tests and cleanup unused code.

BUG=1574
R=pthatcher@webrtc.org, tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/39699004

Cr-Commit-Position: refs/heads/master@{#8237}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8237 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-03 23:14:18 +00:00
decurtis@webrtc.org
322a564f49 Fix datachannel stats id and timestamp. 
Makes the id now be "datachannel_#####" where '####' is the id number for the datachannel.

Adds a timestamp to the data channel reports.

Implements unit tests to verify that the timestamp is set correctly.

BUG=1805
R=juberti@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/33119004

Cr-Commit-Position: refs/heads/master@{#8236}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8236 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-03 22:10:13 +00:00
tommi@webrtc.org
d43bdf50c5 Rewrite ThreadPosix. 
This is the same change as already made for Windows:
https://webrtc-codereview.appspot.com/37069004/

* Remove "dead" and "alive" variables.
* Remove critical section
* Remove implementation of SetNotAlive()
* Always set thread name
* Add thread checks for correct usage.

* Changed AudioDeviceMac to create/start/stop/delete thread objects for playout and recording, inside the respective start and stop method.  The reason for this is because the AudioDeviceMac instance is currently being created on one thread and the above Start/Stop methods are being called on a different thread.  So, my change makes creation, start/stop, deletion of the thread objects always happen on the same thread.

I'm making CurrentThreadId() in rtc_base_approved more visible so that it can be used  from there instead of inside webrtc. Down the line we will have more thread concepts in rtc_base_approved, so I put a TODO for myself to move this functionality to there once we do.

R=henrika@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/40599004

Cr-Commit-Position: refs/heads/master@{#8235}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8235 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-03 16:30:21 +00:00
kjellander@webrtc.org
bfdee69d48 Roll chromium_revision 9070a80..cd35af6 (313233:314322) 
Relevant changes:
* src/third_party/boringssl/src: 347f025..be629e0
* src/third_party/libvpx: 5da40ca..5cdd302
* src/third_party/openmax_dl: 8f7bf0b..c01d587
* src/tools/gyp: b28bd7d..4d7c139
* src/tools/swarming_client: d863df3..c698ea2
Details: 9070a80..cd35af6/DEPS

Clang version was not updated in this roll.
webrtc_tests.py had to be updated to match changes in
https://codereview.chromium.org/882713002

A workaround for grit resources and the addition of V8 to the
Chromium checkout had to be done due to changed
dependencies caused by https://codereview.chromium.org/867073002

R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/35969004

Cr-Commit-Position: refs/heads/master@{#8234}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8234 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-03 15:24:22 +00:00
mflodman@webrtc.org
0ec50be2f7 Changing include guard in frame_callback.h. 
R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/39769004

Cr-Commit-Position: refs/heads/master@{#8233}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8233 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-03 14:51:39 +00:00
pbos@webrtc.org
200ac007ef Remove temp files in audio_processing_unittest.cc. 
These files are leaking, rapidly filling trybot disks.

BUG=4258
R=kjellander@webrtc.org
TBR=bjornv@webrtc.org
TEST=out/Debug/modules_unittests --gtest_filter=*AudioProcessingTest*Formats/0 && ls out

Review URL: https://webrtc-codereview.appspot.com/35979004

Cr-Commit-Position: refs/heads/master@{#8232}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8232 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-03 14:14:19 +00:00
stefan@webrtc.org
0e8bf6c4d3 Enable bitrate probing by default. 
Results from the experiment were all positive.

BUG=crbug:425925
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/38829004

Cr-Commit-Position: refs/heads/master@{#8231}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8231 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-03 12:34:17 +00:00
bjornv@webrtc.org
b1786dbab0 audio_processing: Added a new AEC delay metric value that gives the amount of poor delays 
To more easily determine if for example the AEC is not working properly one could monitor how often the estimated delay is out of bounds. With out of bounds we mean either being negative or too large, where both cases will break the AEC.

A new delay metric is added telling the user how often poor delay values were estimated. This is measured in percentage since last time the metrics were calculated.

All APIs have been updated with a third parameter with EchoCancellation::GetDelayMetrics() giving the option to exclude the new metric not to break existing code.

The new metric has been added to audio_processing_unittests with an additional protobuf member, and reference files accordingly updated.
voe_auto_test has not been updated to display the new metric.

BUG=4246
TESTED=audioproc on files
R=aluebs@webrtc.org, andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/39739004

Cr-Commit-Position: refs/heads/master@{#8230}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8230 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-03 06:07:21 +00:00
pkasting@chromium.org
0e81fdf5d2 Avoid implicit type truncations by inserting explicit casts or modifying prototypes to avoid needless up- and then down-casting. 
BUG=chromium:82439
TEST=none
R=henrik.lundin@webrtc.org, mflodman@webrtc.org, pthatcher@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/40569004

Cr-Commit-Position: refs/heads/master@{#8229}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8229 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-02 23:54:40 +00:00
pkasting@chromium.org
19f3f71c98 Fix apparent typo: int -> char. 
The surrounding similar methods all used unsigned char, using unsigned int in
this case looks like an accident, especially since the function passes on the
value in question to a function expecting a uint8.

BUG=none
TEST=none
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/40529004

Cr-Commit-Position: refs/heads/master@{#8228}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8228 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-02 19:44:42 +00:00
stefan@webrtc.org
946ad76f7e Switched lists of packets to lists of packet pointers. Allows Packet polymorphism. 
This allows for different packet types in a follow-up CL, so that feedback can be passed through the network instead being fed directly into senders. It also made the whole simulator faster.

BUG=4173
R=pbos@webrtc.org, sprang@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/39679004

Cr-Commit-Position: refs/heads/master@{#8227}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8227 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-02 14:51:45 +00:00
sprang@webrtc.org
c957ffc6dc Fixed potential crash if rtp packet history is completely full. 
Also performance enhanecement in rtp_sender (don't lookup if kDontStore)

BUG=4171
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/39759004

Cr-Commit-Position: refs/heads/master@{#8226}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8226 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-02 13:08:14 +00:00
henrik.lundin@webrtc.org
c420a86f4c Change name for local CriticalSectionScoped variable 
Tools were complaining about (harmless) shadowing of variable names.

This is a follow-up to
https://webrtc-codereview.appspot.com/41659004/#msg8

BUG=3926
TBR=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/37099004

Cr-Commit-Position: refs/heads/master@{#8225}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8225 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-02 10:36:39 +00:00
kwiberg@webrtc.org
a1dfbf1e5c WebRtcG722_Decode: Input array should be const uint8_t[] 
BUG=909
R=henrik.lundin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/38799004

Cr-Commit-Position: refs/heads/master@{#8224}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8224 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-02 08:58:39 +00:00
pkasting@chromium.org
026b892e72 Using << on an int8_t or uint8_t will output a character rather than a number. 
Places that do this need to cast to int to get the desired behavior.

BUG=none
TEST=none
R=henrik.lundin@webrtc.org, pthatcher@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/40579004

Cr-Commit-Position: refs/heads/master@{#8223}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8223 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-01-30 19:54:19 +00:00
pkasting@chromium.org
005b6fffe6 Convert some EXPECTs to ASSERTs to avoid crashes when object creation fails. 
BUG=none
TEST=none
R=perkj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/39649004

Cr-Commit-Position: refs/heads/master@{#8222}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8222 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-01-30 19:42:17 +00:00
pbos@webrtc.org
5e161616b1 Remove CPU monitor from WebRtcVideoEngine2. 
CPU adaptation is based on timings done inside webrtc, not actual CPU
values anymore. This code has never been wired up and is causing flakes
on at least valgrind, but possibly also on actual platforms.

BUG=1788
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/34089004

Cr-Commit-Position: refs/heads/master@{#8221}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8221 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-01-30 15:31:26 +00:00
tommi@webrtc.org
aef0779dab Rewrite ThreadWindows. 
* Remove "dead" and "alive" variables.
* Remove critical section
* Skip synchronizing with the worker thread to verify startup (no need).
* Remove implementation of SetNotAlive()
* Always set thread name
* Add thread checks for correct usage.

Also added some TODOs for myself for the ThreadWrapper interface.

I'm removing the HasNoMonitorThread test since it is no longer relevant and ends up checking the wrong thing (ProcessThread - a generic thread type) in the wrong way (parsing a debug log) :)  I think it served a purpose some years ago, but things have changed since.

BUG=2902
R=henrika@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/37069004

Cr-Commit-Position: refs/heads/master@{#8220}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8220 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-01-30 15:06:44 +00:00
kjellander@webrtc.org
f2ec814e0f Move use of DEPTH into build_with_chromium==1. 
For build_with_chromium==1 the includes will be the same.
For build_with_chromium==0 the <(DEPTH) variable is replaced by ../..
which should be the same in all common use cases.

This change makes the include paths for all GYP targets
more similar to the setup in the
direct_dependent_settings section further down.

BUG=4185
TESTED=Trybots + build in Chromium with third_party/webrtc patched with this CL.
R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/41739004

Cr-Commit-Position: refs/heads/master@{#8219}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8219 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-01-30 14:55:20 +00:00
stefan@webrtc.org
f88bee6d88 Refactor senders into senders and sources in the simulation framework. 
BUG=4173
R=sprang@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/38579005

Cr-Commit-Position: refs/heads/master@{#8218}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8218 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-01-30 14:37:09 +00:00
henrik.lundin@webrtc.org
a671f4b2cb Fixing a VoE test to set correct rate for iSAC 
The test was relying on that the code accepted an invalid rate.
Now the test passes a correct rate instead.

COAUTHOR=kwiberg@webrtc.org
R=henrika@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/33179004

Cr-Commit-Position: refs/heads/master@{#8217}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8217 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-01-30 13:04:47 +00:00
henrik.lundin@webrtc.org
05db352f56 Fix a bug in ACM test channel 
The test code could read outside the allocated memory. The bug could up
until now not be triggered by the production code, but coming changes
would uncover it.

COAUTHOR=kwiberg@webrtc.org
R=minyue@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/34929004

Cr-Commit-Position: refs/heads/master@{#8216}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8216 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-01-30 13:04:16 +00:00
henrik.lundin@webrtc.org
3154a1cf9d Reland r8210 "Add a new parameter to ACMGenericCodec constructor"" 
This effectively reverts r8211.

The problem with r8210 was that the change in constructor signature was not done for other codec selections that then default one. That is, some code that was hidden under #ifdef did not get updated. This is now fixed.

BUG=4228
COAUTHOR=kwiberg@webrtc.org
TBR=minyue@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/37879004

Cr-Commit-Position: refs/heads/master@{#8215}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8215 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-01-30 12:30:22 +00:00
henrik.lundin@webrtc.org
4455f6243a WebRtcIsacfix_Time2SpecNeon and _Spec2TimeNeon: Fix stack alignment 
The ABI
(http://infocenter.arm.com/help/topic/com.arm.doc.ihi0042e/IHI0042E_aapcs.pdf)
says to 8-byte-align stack frames. That means we have to push an even
number of registers on function entry if we want to be able to make
subroutine calls without adjusting the stack first.

BUG=4177
R=bjornv@webrtc.org, henrik.lundin@webrtc.org, zhongwei.yao@arm.com

Review URL: https://webrtc-codereview.appspot.com/33149004

Cr-Commit-Position: refs/heads/master@{#8214}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8214 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-01-30 11:58:15 +00:00
braveyao@webrtc.org
8820ac7cc4 peerconnectin_server: missing comma in sprintfn() in r8128 
BUG=4244
TEST=Manual Test
R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/37079004

Cr-Commit-Position: refs/heads/master@{#8213}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8213 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-01-30 09:58:45 +00:00
tommi@webrtc.org
2bbc35d896 Remove unused method, SetAffinity, from the ThreadWrapper class. 
The method was also not consistently implemented across all platforms.

R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/33169004

Cr-Commit-Position: refs/heads/master@{#8212}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8212 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-01-30 09:43:20 +00:00