generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
2,093 Commits 1 Branch 0 Tags 108 MiB
b3bea2eb3e
Commit Graph

1560 Commits

Author SHA1 Message Date
kjellander@webrtc.org
67fdd70e1b Refactoring audio_device_test_api for gtest and execution on all platforms. 
All the code that was previously in one single function is now broken up into 44 gtest tests. The creation of the Audio Device is done once (SetUpTestCase) and the audio device is initialized before each test (SetUp) and terminated after each test (TearDown). Doing this, the things that execute are basically the same since the test was structured as different sections separated by these calls:
TEST(audioDevice->Terminate() == 0);
TEST(audioDevice->Init() == 0);

I also cleaned up some unused helper functions and removed old test macros when replacing them by gtest macros.

The parts that are failing for Mac and Windows are excluded using #ifdef. Separate issues are filed for
this code to be fixed.

Formatting is updated to follow the WebRTC style guide.

BUG=None.
TEST=audio_device_test_api in Debug+Release on Linux, Mac and Windows. Test run audio_device_test_func on Linux.

Review URL: https://webrtc-codereview.appspot.com/437002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1861 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-09 08:11:04 +00:00
andrew@webrtc.org
8012474552 Use a const rather than macro for EcDefault. 
- This should be a better solution to the build error in
  https://webrtc-codereview.appspot.com/425005
- Ideally all of the similar macros should go away, but one thing at
  a time...

BUG=
TEST=voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/438002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1860 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-08 17:54:24 +00:00
tina.legrand@webrtc.org
f1befad273 Reregister of stereo receiver didn't work. 
This CL takes care of the re-registration of codecs, and tests unregistering stereo codecs.

One bug fixed in Celt too.

TEST=audio_coding_module_test: TestStereo.

Review URL: https://webrtc-codereview.appspot.com/436002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1859 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-08 13:23:18 +00:00
phoglund@webrtc.org
0e8b52c012 Rolled back and re-adapted the codec test. 
I don't really think this solves the problem and it makes the code worse, but it seems to make the vie_auto_test binary usable again. I've never seen it chrash on the standard tests since I rewrote it. It can still chrash on the API tests and extended tests though, which indicates that there is a fundamental design / threading problem somewhere, like we suspected. I think this is a kind of progress for now since we can use vie_auto_test to detect new errors again.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/425003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1857 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-08 09:19:31 +00:00
mflodman@webrtc.org
7845d07bf8 VideoCapture now uses pointer constructor of CriticalSectionScoped. 
BUG=184
TEST=video_capture_module compiles on all platforms when removing ref ctor of CriticalSectionScoped.

Review URL: https://webrtc-codereview.appspot.com/434001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1855 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-08 08:09:17 +00:00
marpan@webrtc.org
accf607b3e Updates for resolution adaptation. 
1) added support for two additional modes: 
    -3/4 spatial down-sampling
    -2/3 frame rate reduction
2) updated unittest and added a few more tests
3) some code refactoring
Review URL: https://webrtc-codereview.appspot.com/429005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1854 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-07 17:16:10 +00:00
mflodman@webrtc.org
9a065d1eae VoiceEngine now uses pointer constructor of CriticalSectionScoped, instead of reference. 
BUG=184
TEST=Compiles on all platforms.

Review URL: https://webrtc-codereview.appspot.com/436001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1853 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-07 08:12:21 +00:00
leozwang@webrtc.org
1d27039612 Disable CreateWindowManagerForCurrentPlatform on android 
Review URL: https://webrtc-codereview.appspot.com/436003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1852 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-06 22:48:43 +00:00
leozwang@webrtc.org
30185916aa Fix error in test app which was introduced when payload type was converted to int 
TBR=mflodman, phoglund
Review URL: https://webrtc-codereview.appspot.com/439004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1851 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-06 21:43:55 +00:00
leozwang@webrtc.org
57da718734 Fix building errors on android 
TBR=mflodman
Review URL: https://webrtc-codereview.appspot.com/441001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1850 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-06 21:28:48 +00:00
leozwang@webrtc.org
77fe431f57 Enable video render test on android 
Review URL: https://webrtc-codereview.appspot.com/428006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1849 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-06 20:59:55 +00:00
leozwang@webrtc.org
0975d2158c Cleanup messy data type of unknown_payload_type 
BUG=322
TEST=build on all platforms
Review URL: https://webrtc-codereview.appspot.com/430002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1848 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-06 20:59:13 +00:00
andrew@webrtc.org
8b111eb3e6 Reformat voe_audio_processing_impl to Goog style. 
TBR=xians@webrtc.org
BUG=
TEST=voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/439003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1847 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-06 19:50:12 +00:00
andrew@webrtc.org
6f9f817e06 Add an API to offset system delay. 
Plumb it through VoiceEngine.

BUG=
TEST=voe_auto_test,audioproc_unittest

Review URL: https://webrtc-codereview.appspot.com/428010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1846 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-06 19:03:39 +00:00
mflodman@webrtc.org
e22c5c3870 Disable REMB test when using vivi. 
BUG=321
TEST=vie_auto_test

Review URL: https://webrtc-codereview.appspot.com/435001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1844 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-06 12:49:33 +00:00
mflodman@webrtc.org
0e703f4d0d VideoRender now uses pointer constructor of CriticalSectionScoped. 
BUG=184
TEST=video_render_module compiles on all platforms when removing ref ctor of
CriticalSectionScoped.

Review URL: https://webrtc-codereview.appspot.com/427004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1843 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-06 12:02:20 +00:00
mflodman@webrtc.org
3e664faad6 Temporarily disabling flaky RTP test. 
TBR=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/430004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1842 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-05 20:30:35 +00:00
leozwang@webrtc.org
53ed5a41a2 Fix building errors and enable test app 
TEST=build on all platforms
Review URL: https://webrtc-codereview.appspot.com/428008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1841 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-05 20:15:58 +00:00
leozwang@webrtc.org
db2de5b49f Fix building errors on android 
TBR=Tina

BUG=
TEST=build on android
Review URL: https://webrtc-codereview.appspot.com/430001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1840 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-05 19:53:24 +00:00
leozwang@webrtc.org
66487e1629 Enable video test on android 
Review URL: https://webrtc-codereview.appspot.com/429006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1839 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-05 19:34:06 +00:00
leozwang@webrtc.org
8ea37f4f26 Fix building error on windows 
TBR=mflodman
Review URL: https://webrtc-codereview.appspot.com/427006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1838 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-05 18:05:08 +00:00
mflodman@webrtc.org
c7ae13da42 Update makefile. 
TBR=leozwang@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/430003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1837 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-05 17:34:05 +00:00
mflodman@webrtc.org
9ec883e8bd Allow multiple REMB groups and introduce receive channels. 
BUG=312
TEST=ViE standard autotest and API test.

Review URL: https://webrtc-codereview.appspot.com/432005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1836 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-05 17:12:41 +00:00
leozwang@webrtc.org
855ced7336 Further cleanup WebRtc_Word8 
Review URL: https://webrtc-codereview.appspot.com/426008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1835 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-05 16:07:51 +00:00
leozwang@webrtc.org
e47efe291e Fix building error on android 
Review URL: https://webrtc-codereview.appspot.com/425005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1834 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-05 16:05:30 +00:00
mflodman@webrtc.org
fa6bc673b0 Changed default module condition for BW estimate. 
Review URL: https://webrtc-codereview.appspot.com/433001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1832 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-05 11:59:55 +00:00
leozwang@webrtc.org
42e362eee5 Fix compilation error on android 
Review URL: https://webrtc-codereview.appspot.com/426006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1830 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-02 17:14:09 +00:00
leozwang@webrtc.org
3197d48407 Enable audio device test on android 
Review URL: https://webrtc-codereview.appspot.com/428005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1829 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-02 17:12:14 +00:00
leozwang@webrtc.org
c868b99ff3 Remove building errors in autotest 
Review URL: https://webrtc-codereview.appspot.com/432004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1828 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-02 17:02:51 +00:00
marpan@webrtc.org
26762e3e40 Allow for spatial-downsampling without reinitializaing encoder. Change of frame 
size will automatically trigger new key frame in codec. This feature is set off
in video engine until we upgrade to a newer version of libvpx.
Review URL: https://webrtc-codereview.appspot.com/427003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1827 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-02 16:48:36 +00:00
leozwang@webrtc.org
fa8c9f7a4f Remove unused variable 
Review URL: https://webrtc-codereview.appspot.com/432003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1823 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-02 07:15:03 +00:00
andrew@webrtc.org
d62d7301f4 Remove TARGET_PC and cruft from typedefs.h. 
Additionally remove all TARGET defines (e.g. TARGET_MAC), which weren't used anyway.

BUG=
TEST=build on Linux, Mac, Win

Review URL: https://webrtc-codereview.appspot.com/432001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1822 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-01 21:39:57 +00:00
andrew@webrtc.org
fa2f5627ca Change error code. 
TBR=henrika@webrtc.org
BUG=
TEST=build

Review URL: https://webrtc-codereview.appspot.com/429004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1821 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-01 21:19:01 +00:00
kma@webrtc.org
beb1851c2a Refactored and further optimized WebRtcSpl_MaxAbsValueW16() function in splib. 
Review URL: https://webrtc-codereview.appspot.com/395008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1820 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-01 20:03:26 +00:00
leozwang@webrtc.org
c9a3b81fd2 Further cleanup WebRtc_Word8 in video_capture on mac 
BUG=311
TBR=Wu, Mallinath
Review URL: https://webrtc-codereview.appspot.com/431002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1819 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-01 19:59:52 +00:00
leozwang@webrtc.org
4add6bc603 Fix building errors on window which caused by previous cl 
BUG=311
TBR=Wu, Mallinath
Review URL: https://webrtc-codereview.appspot.com/432002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1818 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-01 19:57:13 +00:00
leozwang@webrtc.org
09e771998c Correct WebRtc_word8 usage in media file module 
BUG=http://code.google.com/p/webrtc/issues/detail?id=311&sort=-id
TEST=build on all platforms

Review URL: https://webrtc-codereview.appspot.com/427002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1817 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-01 18:35:54 +00:00
leozwang@webrtc.org
813e4b0af0 Correct WebRtc_Word8 in voice engine 
BUG=http://code.google.com/p/webrtc/issues/detail?id=311&sort=-id
TEST=build on all platforms

Review URL: https://webrtc-codereview.appspot.com/425002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1816 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-01 18:34:25 +00:00
leozwang@webrtc.org
39e9659fc6 Correct wrong usage of WebRtc_Word8 in video enigne 
BUG=http://code.google.com/p/webrtc/issues/detail?id=311&sort=-id
TEST=build on all platforms

Review URL: https://webrtc-codereview.appspot.com/428002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1815 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-01 18:22:48 +00:00
leozwang@webrtc.org
28f3913ca9 Correct WebRtc_Word8 in adm 
Correct WebRtc_Word8 usage in adm

BUG=http://code.google.com/p/webrtc/issues/detail?id=311&sort=-id
TEST=buidl on all platforms

Review URL: https://webrtc-codereview.appspot.com/428001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1814 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-01 18:01:48 +00:00
leozwang@webrtc.org
af1f792cc3 nits 
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1813 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-01 16:31:06 +00:00
leozwang@webrtc.org
0689271d64 nits 
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1812 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-01 16:31:00 +00:00
leozwang@webrtc.org
1745e932cc Correct wrong usage of WebRtc_Word8 in video capture 
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1811 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-01 16:30:40 +00:00
tina.legrand@webrtc.org
1f2cabaecd Crash when deleting Celt. 
BUG=issue 6087770
TEST=audio_coding_module_test

Review URL: https://webrtc-codereview.appspot.com/420001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1805 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-01 08:46:09 +00:00
kjellander@webrtc.org
c81012b8e5 Fixing invalid linking for Linux that obviously wasn't properly tested in the cleanup of http://webrtc-codereview.appspot.com/406002/ 
TBR=mflodman
BUG=None
TEST=Compiled on Linux Debug+Relase.

Review URL: https://webrtc-codereview.appspot.com/425001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1803 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-29 21:28:22 +00:00
kjellander@webrtc.org
132eccbb69 Renamed platform specific code to use GYP conventions. 
Restructured GYP files a bit to clean up things.
Removed copying of images to /tmp
Fixed output location of DumpFileName.rtp.

BUG=None
TEST=Tested compiling and running on Mac, Win, Linux.

Review URL: https://webrtc-codereview.appspot.com/406002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1802 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-29 20:55:25 +00:00
andrew@webrtc.org
eaefea665f Remove unused files from src/build. 
These files were intended for a standalone build without depending on
Chromium's build/. In some bright future we might use them, but for
the moment, they're just confusing.

BUG=
TEST=build on Linux

Review URL: https://webrtc-codereview.appspot.com/416002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1800 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-29 18:19:34 +00:00
andrew@webrtc.org
0e28566247 Only reset AudioProcessing if number of channels has changed. 
Calling SetSendCodec() would always reset AudioProcessing.

BUG=
TEST=voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/417002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1799 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-29 17:00:56 +00:00
leozwang@webrtc.org
07c68b9c9d Correct wrong usage of WebRtc_Word8 in rtp and udp module 
BUG=http://code.google.com/p/webrtc/issues/detail?id=311&sort=-id
TEST=build on all platforms

Review URL: https://webrtc-codereview.appspot.com/418001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1798 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-29 16:09:51 +00:00
phoglund@webrtc.org
2d124f3d88 Enabled the volume tests we believe are nonflaky and the vie_auto_test extended tests. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/422002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1797 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-29 14:34:06 +00:00
mflodman@webrtc.org
6a60dbe81f Correcting ViE RTP RTCP autotest. 
Review URL: https://webrtc-codereview.appspot.com/417003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1793 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-29 07:06:49 +00:00
marpan@webrtc.org
4788bf4256 Fix to warnings on windows. 
Review URL: https://webrtc-codereview.appspot.com/415004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1792 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-29 01:11:39 +00:00
marpan@webrtc.org
9d76b4ea54 Updates for resolution adaptation: 
1) code cleanup and some updates to selection logic for qm_select.
2) added unit test for the QmResolution class.
3) update codec frame size and reset/update frame rate in media-opt:
4) removed unused motion vector metrics and some related code of content metrics processing.
Review URL: https://webrtc-codereview.appspot.com/405008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1791 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-28 23:39:31 +00:00
andrew@webrtc.org
c3cb0ca726 Enable -Woverloaded-virtual for gcc. 
BUG=
TEST=build on Linux/gcc.

Review URL: https://webrtc-codereview.appspot.com/417001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1790 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-28 23:14:11 +00:00
leozwang@webrtc.org
785db5a2a5 Enable rw_lock_posix on andorid 
Review URL: https://webrtc-codereview.appspot.com/404002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1789 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-28 23:10:03 +00:00
andrew@webrtc.org
547c157a49 Temporarily use _Word8 to avoid clang error. 
BUG=issue311
TEST=build on clang

Review URL: https://webrtc-codereview.appspot.com/415003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1788 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-28 22:30:30 +00:00
leozwang@webrtc.org
91b359ea9b Change WebRtc_Word8 to char 
Review URL: https://webrtc-codereview.appspot.com/407003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1787 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-28 17:26:14 +00:00
mflodman@webrtc.org
1a739bab59 Add StartSend check. 
Review URL: https://webrtc-codereview.appspot.com/414002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1783 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-28 16:11:33 +00:00
stefan@webrtc.org
4ce0ba00de Fix issue 310. 
BUG=310
TEST=session_info_unittest.cc

Review URL: https://webrtc-codereview.appspot.com/404004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1782 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-28 12:09:09 +00:00
pwestin@webrtc.org
14b0247f01 Silently ignore error from RegisteModule 
Review URL: https://webrtc-codereview.appspot.com/413001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1781 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-28 11:01:52 +00:00
henrike@webrtc.org
26085e18e0 Coverity fixes for module/media_file. 
BUG=Coverity report.
TEST=N/A.

Review URL: https://webrtc-codereview.appspot.com/397003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1780 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-27 21:50:40 +00:00
leozwang@webrtc.org
ead7d25c1a Revert r1775 which caused building errors. 
TBR=pwestin@webrtc.org, mflodman@webrtc.org

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1778 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-27 19:45:09 +00:00
leozwang@webrtc.org
2559cbf7b7 Change WebRtc_Word8 to char 
Review URL: https://webrtc-codereview.appspot.com/405003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1777 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-27 19:18:25 +00:00
leozwang@webrtc.org
3e9e0f0497 Change WebRtc_Word8 to char 
Review URL: https://webrtc-codereview.appspot.com/405004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1776 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-27 19:17:38 +00:00
leozwang@webrtc.org
adb89f56e0 Change WebRtc_Word8 to char 
Review URL: https://webrtc-codereview.appspot.com/405005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1775 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-27 19:12:19 +00:00
xians@webrtc.org
cf1b6aec30 iReduced the flakiness of the volume tests in linux pulseaudio 
Review URL: https://webrtc-codereview.appspot.com/390013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1774 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-27 17:22:49 +00:00
phoglund@webrtc.org
13e8528f32 Fixed silly error on Windows. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/408007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1773 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-27 16:27:50 +00:00
phoglund@webrtc.org
52b59d095e Implemented bit flipping fuzz test. 
Moved random encryption to its own file.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/392017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1771 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-27 15:29:52 +00:00
mflodman@webrtc.org
b4556cd29a Enabling mjpg for Windows. 
BUG=306
TEST=ViE loopback call on windows with resolution 960x720
Review URL: https://webrtc-codereview.appspot.com/411003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1770 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-27 14:02:12 +00:00
stefan@webrtc.org
1bb1da4c30 Enable MFQE if we are recieving temporal layers. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/411002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1769 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-27 13:52:34 +00:00
mflodman@webrtc.org
f3811194a5 Enable mjpg capture for Linux. 
BUG=306
TEST=ViE Loopback test using resolution larger than 640x480.

Review URL: https://webrtc-codereview.appspot.com/411001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1768 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-27 08:10:17 +00:00
punyabrata@webrtc.org
c29280d767 webrtc::CpuWindows::ProcessImpl() nullref crash resolution [6061101] 
Review URL: https://webrtc-codereview.appspot.com/410004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1766 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-24 19:17:25 +00:00
leozwang@webrtc.org
a68f05e841 Change WebRtc_Word8 to char 
Review URL: https://webrtc-codereview.appspot.com/410001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1765 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-24 16:08:52 +00:00
mflodman@webrtc.org
c3a73bb182 Add null termination to test string. 
BUG=307
TEST=out/Debug/vie_auto_test --automated --gtest_filter=ViEExtendedIntegrationTest.RunsRtpRtcpTestWithoutErrors

Review URL: https://webrtc-codereview.appspot.com/408005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1764 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-24 14:25:10 +00:00
mflodman@webrtc.org
2f6104bb93 Relanding r1749. 
BUG=306
TEST=libyuv_unittests

Review URL: https://webrtc-codereview.appspot.com/410002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1762 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-24 11:53:49 +00:00
mflodman@webrtc.org
8df260023b Prepared for MJPG capture without using MJPG DirectShow filter. MJPG is temporarily disabled and will enabled as soon as MJPG->I420 conversion is available. 
Review URL: https://webrtc-codereview.appspot.com/397011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1761 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-24 10:06:30 +00:00
kma@webrtc.org
bfa7f96d1e Optimized WebRtcSpl_ComplexBitReverse() for general ARM platforms and generic C. 
In ARMv5, the cycles were reduced by 88% (weight in VoE reduced from 3.554% to 0.432%). The tradeoff is a memory increase of 704 bytes.
Review URL: https://webrtc-codereview.appspot.com/388003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1757 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-23 22:38:56 +00:00
andrew@webrtc.org
3cc03be51f Remove deleted file from vie_auto_test.gypi. 
TBR=phoglund@webrtc.org
BUG=
TEST=build

Review URL: https://webrtc-codereview.appspot.com/408002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1756 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-23 22:05:24 +00:00
marpan@webrtc.org
946601e408 Change default packetization mode to an equal size mode. 
This will produce equal size packets for each frame, which should be somewhat more favorable (less overhead/padding data) for the FEC.
Review URL: https://webrtc-codereview.appspot.com/396013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1754 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-23 18:52:53 +00:00
henrike@webrtc.org
70efc3250d Factory method for the ADM in the interface file. 
BUG=N/A
TEST=no

Review URL: https://webrtc-codereview.appspot.com/396017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1753 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-23 17:45:33 +00:00
xians@webrtc.org
6eb0ca2e75 Two problems are fixed: 
#1, avoid leaving the lock without entering the lock.
#2, race problems in variables like _playError, _recError, _recWarning, _playWarning.
Review URL: https://webrtc-codereview.appspot.com/400006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1751 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-23 10:39:53 +00:00
mflodman@webrtc.org
a556b0d193 Reverting r1749. 
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1750 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-23 10:15:04 +00:00
mflodman@webrtc.org
cb57f9ba95 Updated libyuv revision to include mjpg and added mjpg to type conversion. 
BUG=306
TEST=libyuv_unittests

Review URL: https://webrtc-codereview.appspot.com/407001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1749 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-23 09:47:07 +00:00
mflodman@webrtc.org
4f9e44f5c5 Prepared for MJPG capturing on Linux. MJPG is conversion is not available in libyuv yet, so this CL is only made as preparation. 
When this is available in libyuv, I'll remove the ifdef.

BUG=306
TEST=Manual loopback test with a high resolution, verify high FR.

Review URL: https://webrtc-codereview.appspot.com/397008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1748 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-23 09:00:26 +00:00
leozwang@webrtc.org
682cd4e9d1 Add android target 
Review URL: https://webrtc-codereview.appspot.com/396016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1746 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-22 16:05:19 +00:00
leozwang@webrtc.org
4ad4c24092 Add android to audio device module 
Review URL: https://webrtc-codereview.appspot.com/402001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1745 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-22 16:04:59 +00:00
stefan@webrtc.org
0fe2171b59 Relax libyuv test threshold and upgrade to libyuv r182. 
BUG=http://code.google.com/p/webrtc/issues/detail?id=267
TEST=

Review URL: https://webrtc-codereview.appspot.com/391018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1742 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-22 11:21:18 +00:00
xians@webrtc.org
539ef94f20 Remove the deprecated kTraceModuleCall trace from audio coding module. 
Review URL: https://webrtc-codereview.appspot.com/399002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1741 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-22 08:35:03 +00:00
leozwang@webrtc.org
20e9cf274d Add android to video capture module 
Review URL: https://webrtc-codereview.appspot.com/399010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1740 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-22 00:40:45 +00:00
mallinath@webrtc.org
0d757b8610 Fixing coverity issues in capture module. 
Review URL: https://webrtc-codereview.appspot.com/399008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1736 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-21 16:47:55 +00:00
niklas.enbom@webrtc.org
7cb0c240cb Trying to free up hellner from review work, since he mainly works in libJingle. 
Review URL: https://webrtc-codereview.appspot.com/392020

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1734 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-21 13:58:58 +00:00
xians@webrtc.org
8435e8e3d8 Remove the deprecated kTraceModuleCall trace from audio processing module. 
Review URL: https://webrtc-codereview.appspot.com/399003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1733 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-21 10:37:26 +00:00
stefan@webrtc.org
a475556f5a Assume 200 ms RTT if we're only receiving. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/396012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1730 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-20 09:53:55 +00:00
xians@webrtc.org
20aabbb0be Remove the deprecated kTraceModuleCall trace from audio device module. 
Review URL: https://webrtc-codereview.appspot.com/396011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1729 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-20 09:17:41 +00:00
xians@webrtc.org
9a798d3fca Remove the deprecated kTraceModuleCall trace from video processing module. 
Review URL: https://webrtc-codereview.appspot.com/395012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1728 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-20 09:00:35 +00:00
phoglund@webrtc.org
b45ceed9ef Rewrote the call report test. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/399006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1726 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-20 08:55:04 +00:00
xians@webrtc.org
843c8c78ff Remove the deprecated kTraceModuleCall trace from video modules. 
Review URL: https://webrtc-codereview.appspot.com/391015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1725 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-20 08:45:02 +00:00
xians@webrtc.org
6bde7a88f1 Remove the deprecated kTraceModuleCall trace from utility module. 
Review URL: https://webrtc-codereview.appspot.com/401002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1724 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-20 08:39:25 +00:00
xians@webrtc.org
57fb09ac18 Remove the deprecated kTraceModuleCall trace from udp transport module. 
Review URL: https://webrtc-codereview.appspot.com/395011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1723 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-20 08:38:21 +00:00
xians@webrtc.org
03039d56e6 Remove the deprecated kTraceModuleCall trace from media file module. 
Review URL: https://webrtc-codereview.appspot.com/392016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1722 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-20 08:37:49 +00:00
xians@webrtc.org
56cfe80c74 Remove the deprecated kTraceModuleCall trace from conference mixer. 
Review URL: https://webrtc-codereview.appspot.com/396010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1721 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-20 08:35:37 +00:00
tina.legrand@webrtc.org
145f04f0c4 Changing Celt to use stereo as default. 
Review URL: https://webrtc-codereview.appspot.com/397009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1720 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-18 00:32:16 +00:00
marpan@webrtc.org
bd5648f2db Reverting 1718: failed linux video test. 
TBR=stefan, andrew, marpan.
Review URL: https://webrtc-codereview.appspot.com/392018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1719 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-17 23:16:58 +00:00
marpan@webrtc.org
883e716304 Removed unused motion vector metrics from VideoContentMetrics; 
also removed other related unused variables and code. 

Reset frame rate estimate in mediaOpt when frame rate reduction is decided.

Update content_metrics with frame rate and qm_resolution with frame size.
Review URL: https://webrtc-codereview.appspot.com/395007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1718 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-17 18:35:23 +00:00
henrike@webrtc.org
f3760dc8e9 Fixes coverity warning that I missed in system wrappers. 
BUG=Coverity
TEST=N/A

Review URL: https://webrtc-codereview.appspot.com/395005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1717 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-17 16:27:25 +00:00
phoglund@webrtc.org
b3172860d7 Added a retry mechanism to vie_auto_test's verifying tests to make them less flaky. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/392015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1716 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-17 13:08:57 +00:00
mflodman@webrtc.org
4cb060127c Disabled RTPModule VP8 packetizer assert. 
BUG=293

Review URL: https://webrtc-codereview.appspot.com/399005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1715 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-17 13:07:01 +00:00
phoglund@webrtc.org
8bfee84144 Initial revision of a ViE fuzz test. The idea is to inject randomized RTP packets and see what the video engine does. 
There are some small refactorings in here, but the real focus of this CL is in vie_autotest_rtp_fuzz.cc. This patch is mostly here to get a discussion going.

On my initial test the video engine doesn't recover, at least within 10 seconds of running with untampered packets. Not sure if this is according to specification though.

Ideas:
  - Generate random packets with correct RTP headers to get further into the code.
  - Don't generate fresh random data, but rather corrupt bits here and there in small amounts.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/383001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1714 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-17 09:32:48 +00:00
leozwang@webrtc.org
a52838b684 Update Android.mk and add test app 
Review URL: https://webrtc-codereview.appspot.com/388010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1713 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-17 01:16:43 +00:00
tina.legrand@webrtc.org
79e29e510f Adding option to change bitrate for Celt. 
I have updated the code so that Celt rate can be changed to any value between 48 and 128 kbps.
Tests for both mono and stereo are updated.Updated tests for Celt mono.

Review URL: https://webrtc-codereview.appspot.com/391014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1712 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-17 00:38:33 +00:00
mallinath@webrtc.org
ee628358f4 Updating the object-c++ file after change in the API 
GetBestMatchedCapability
Review URL: https://webrtc-codereview.appspot.com/396009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1710 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-16 19:30:37 +00:00
mallinath@webrtc.org
8b4a98d0f4 Change in the interface file for GetBestMatchedCapability method. Updating mac files. 
Review URL: https://webrtc-codereview.appspot.com/389013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1709 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-16 19:00:28 +00:00
wu@webrtc.org
69f8be3875 Change the ExternalRenderer to provide both rtp timestamp and the render time. 
Review URL: https://webrtc-codereview.appspot.com/394006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1708 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-16 18:32:02 +00:00
mallinath@webrtc.org
12984f0d02 Fixing Coverity issues 
Note: This doesn't address Google Code style guidelines issues.
Review URL: https://webrtc-codereview.appspot.com/391011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1707 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-16 18:18:21 +00:00
xians@webrtc.org
3ab6dda5cb Truncated the volume to 255 when the users set the volume above 100%. 
Allowed the users to set the volume above 100% when AGC is enabled, in this case AGC can gradually scale down the volume instead of jumping to 100% immediately.
Reduced the flakiness of the volume tests in linux.
Review URL: https://webrtc-codereview.appspot.com/387011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1706 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-16 18:15:54 +00:00
mflodman@webrtc.org
f7b6078f6f Allow multiple send channels for REMB. Current implementation splits the remote estimate evenly between all senders. 
This CL will be followed by a CL adding support for several REMB groups.

TEST=video_engine_core_unittests

Review URL: https://webrtc-codereview.appspot.com/394002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1705 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-16 14:50:24 +00:00
stefan@webrtc.org
439be29445 Add APIs for getting receive-side estimated bandwidth and codec target rate. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/391012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1704 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-16 14:45:37 +00:00
braveyao@webrtc.org
590e5eb283 Convert audio layer to WAV on Vista RTM(without any Service Pack) 
Review URL: https://webrtc-codereview.appspot.com/397001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1702 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-16 03:21:05 +00:00
henrike@webrtc.org
d6d014ff12 Fixes memory leaks introduced in 1698. 
Review URL: https://webrtc-codereview.appspot.com/387014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1701 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-16 02:18:09 +00:00
andrew@webrtc.org
cb333530fc Remove common_settings.gypi. 
Now fully replaced by src/build/common.gypi.

BUG=
TEST=build

Review URL: https://webrtc-codereview.appspot.com/395003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1699 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-16 01:16:28 +00:00
henrike@webrtc.org
f5da4da409 Removes a global non POD instance from the RTP_RTCP module that was introduced in https://code.google.com/p/webrtc/source/detail?r=1076. 
Review URL: https://webrtc-codereview.appspot.com/314001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1698 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-15 23:54:59 +00:00
leozwang@webrtc.org
0a272eb44b Disable SetAffinity on android 
CPU_ macros are only available in android source tree, not in NDK. Disable it for now. 
Review URL: https://webrtc-codereview.appspot.com/392008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1697 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-15 22:35:29 +00:00
henrike@webrtc.org
05e0601160 Fixes coverity warnings in the udp_transport module. 
BUG=Coverity warnings.
TEST=N/A.

Review URL: https://webrtc-codereview.appspot.com/392012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1696 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-15 19:43:51 +00:00
henrike@webrtc.org
6b9253eb4f Fixe issues reported by Coverity for modules/utility. 
BUG=From Coverity
TEST=N/A

Review URL: https://webrtc-codereview.appspot.com/389011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1695 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-15 18:48:16 +00:00
kjellander@webrtc.org
cd46385142 Fixing Android.mk for jpeg library 
TBR=leozwang
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/389009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1692 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-15 10:12:52 +00:00
kjellander@webrtc.org
0a57aae75b Converted old jpeg_test tool to gtest unit test. 
Restructured paths to new directory layout.

Stefan: common_video/*
Magnus: video_engine/*
Niklas: Android.mk

BUG=
TEST=jpeg_unittests on Debug+Release on Linux, Mac, Windows. Valgrind on Linux passes without warnings.

Review URL: https://webrtc-codereview.appspot.com/388007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1691 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-15 09:47:55 +00:00
andrew@webrtc.org
8bd6f19abe Disable flaky CpuTest.Usage on Windows. 
TBR=turaj@webrtc.org
BUG=290
TEST=system_wrapper_unittests

Review URL: https://webrtc-codereview.appspot.com/396005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1689 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-15 01:47:51 +00:00
henrike@webrtc.org
b38a66aaac Fixes a coverity warning in the mixer module. 
Review URL: https://webrtc-codereview.appspot.com/388009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1688 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-15 00:04:27 +00:00
marpan@webrtc.org
79a99de8e4 Reverting 1680: valgrind memory leak reported. 
TBR=marpan
Review URL: https://webrtc-codereview.appspot.com/392011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1686 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-14 22:37:10 +00:00
marpan@webrtc.org
738bcdc4ee Fix to coverity issue 10339. 
Review URL: https://webrtc-codereview.appspot.com/391010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1685 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-14 20:54:57 +00:00
andrew@webrtc.org
737c023e42 Properly disable sse2 source on non-x86. 
BUG=
TEST=build on Linux.

Review URL: https://webrtc-codereview.appspot.com/387008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1684 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-14 19:57:50 +00:00
braveyao@webrtc.org
59d6cec291 Fix the crash at playing 48kHz stereo wav file. 
http://code.google.com/p/webrtc/issues/detail?id=208
Review URL: https://webrtc-codereview.appspot.com/396001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1681 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-14 18:17:16 +00:00
marpan@webrtc.org
4e34dcbd62 Allow for spatial-downsampling without reinitializaing encoder. Change of frame size will automatically trigger new key frame in codec. This feature is set off in vie_encoder until we upgrade to the new libvpx. 
Also reset frame rate estimate in mediaOpt when frame rate reduction is decided.
Review URL: https://webrtc-codereview.appspot.com/390006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1680 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-14 17:26:24 +00:00
mflodman@webrtc.org
d7d46887a6 Update receive only channels with RTT. 
vie_autotest_loopback.cc will not be part of the commit, it's only to show the test.

TEST=temporary with attached loopback test.

Review URL: https://webrtc-codereview.appspot.com/390007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1678 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-14 12:49:59 +00:00
pwestin@webrtc.org
c76c096c19 Bugfix issue 273, workaround for compiler issue. 
Review URL: https://webrtc-codereview.appspot.com/392005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1675 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-13 09:56:57 +00:00
pwestin@webrtc.org
52fd98d876 Removing encoder reset. Function did not make sence. 
Review URL: https://webrtc-codereview.appspot.com/391005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1674 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-13 09:03:53 +00:00
marpan@webrtc.org
567d507707 Fixes a bug when number of media packets in a frame is larger than maximum allowed for the generateFEC. 
Review URL: https://webrtc-codereview.appspot.com/391003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1673 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-10 18:56:14 +00:00
phoglund@webrtc.org
292da24166 New attempt. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/391006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1672 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-10 15:21:33 +00:00
phoglund@webrtc.org
dbe1e13b53 Fixed compilation error on Windows. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/389007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1670 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-10 14:03:44 +00:00
mflodman@webrtc.org
8224e19dd9 Fixed incorrect packet loss reported to encoder. 
BUG=275

Review URL: https://webrtc-codereview.appspot.com/394004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1669 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-10 12:41:57 +00:00
phoglund@webrtc.org
6b3bb89f12 Rewrote file test. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/391004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1668 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-10 12:14:54 +00:00
pwestin@webrtc.org
5e954814a8 Clanup handling of key frame requests and FIR. 
Review URL: https://webrtc-codereview.appspot.com/387004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1667 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-10 12:13:12 +00:00
andrew@webrtc.org
75f1948b0e Restore AECM Coverity fix. 
Add a test which would have caught the crash introduced by r1628.

BUG=274
TEST=audioproc_unittest

Review URL: https://webrtc-codereview.appspot.com/388002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1657 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-09 17:16:18 +00:00
phoglund@webrtc.org
aaa76f3ba8 Rewrote network test. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/383003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1656 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-09 16:41:30 +00:00
stefan@webrtc.org
4b377414f1 Fix release build errors. 
TBR=mflodman
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/394005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1654 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-09 13:50:57 +00:00
xians@webrtc.org
3dbed8597e This CL makes the playout delay value thread safe. 
With the patch, _sndCardPlayDelay is calculated in the DoRenderThread instead of capture thread, an capture thread only gets the _sndCardPlayDelay value.
And _sndCardPlayDelay and _sndCardRecDelay are only changed to be Atomic32 to make them to be accessed by multiple threads.


Test=None
Bug=256
Review URL: https://webrtc-codereview.appspot.com/394001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1653 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-09 13:50:48 +00:00
stefan@webrtc.org
9c84b0dc9f Fix build errors with GCC. 
TBR=mflodman
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/389006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1652 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-09 13:14:04 +00:00
stefan@webrtc.org
7adab0922d This removes the knowledge of frame completeness from the FEC decoder. 
Therefore, with this change a recovered packet is only considered old,
and will be removed, if more than 48 recovered packets are stored.

Packets are immediately reconstructed and sent to the jitter
buffer. Before this CL packets were processed on a frame-by-frame
basis, and all packets belonging to a frame was sent to the
jitter buffer at the same time.

The number of FEC packets is also limited to 48. An FEC packet is
removed if all protected packets have been recovered or if the
FEC packet is considered old.

Lot's of tests added.

Patch-set 2:
- Fixed rtp_fec_unittest.cc to work with the new reconstruction.
- Added reference counting of Packet to be able to keep references to them from FecPacket between different reconstruction runs.
- Rewrote the packet search to use std::set_intersection.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/379005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1651 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-09 12:34:52 +00:00
kjellander@webrtc.org
cf6a295b13 Making video codecs test framework integration test execute in a reproducable fashion. 
Fixed reproducable random behavior in packet_manipulator.h.
Test is now fully reproducable (runs on only one core) so much tighter limits are now set for the SSIM/PSNR values for the encoding/decoding (verified on all platforms)

BUG=
TEST=out/Debug/video_codecs_test_framework_integrationtests in Debug+Release on Linux, Mac, Windows and in Linux Valgrind.

Review URL: https://webrtc-codereview.appspot.com/381005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1649 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-09 09:01:51 +00:00
henrike@webrtc.org
d5657c2f69 Refactored files according to google style since http://review.webrtc.org/314001/ is blocked on this and formatting changes should not be done with code changes. 
Review URL: https://webrtc-codereview.appspot.com/387005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1648 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 23:41:49 +00:00
andrew@webrtc.org
68da6adafe Remove WebRtc_ types. 
Allows us to avoid the "cast to UWord32" Coverity coverup.

BUG=
TEST=test_fec

Review URL: https://webrtc-codereview.appspot.com/379002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1647 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 22:24:14 +00:00
wu@webrtc.org
454a27c13d The pthread_t is non-pointer type. 
TBR=henrike
Review URL: https://webrtc-codereview.appspot.com/392004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1646 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 20:36:23 +00:00
henrike@webrtc.org
143abd95a3 Fixes coverity warnings in system_wrappers. 
Review URL: https://webrtc-codereview.appspot.com/389003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1645 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 19:39:38 +00:00
henrike@webrtc.org
0e7c060256 Linux logs were not displaying time at ms resolution. 
Review URL: https://webrtc-codereview.appspot.com/267012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1644 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 18:53:50 +00:00
wu@webrtc.org
a8084b07e3 Revert r1628 which causes the crash of voe_auto_test. 
With r1628, it's possible the second memcpy got a NULL nearendClean.

TBR=bjornv
Review URL: https://webrtc-codereview.appspot.com/390005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1643 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 17:56:39 +00:00
tina.legrand@webrtc.org
13ac430bef Adding missing timestamp calculation to RTPencode. 
Review URL: https://webrtc-codereview.appspot.com/392002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1641 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 13:20:36 +00:00
mflodman@webrtc.org
d2940f71e4 VCM::JB critsect fix. 
Review URL: https://webrtc-codereview.appspot.com/390004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1639 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 12:42:56 +00:00
stefan@webrtc.org
23307f7c4b Remove frame_list.cc from Andorid.mk. 
TBR=mflodman
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/390003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1638 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 10:39:13 +00:00
xians@webrtc.org
594ab3ce4b remove vie file API to take away media_file and utility modules. 
This CL reduce the size of chrome in release build by 70KB.
With this patch and r1592 , sizes.py reports 92255640 bytes with webrtc, down from 92485792 bytes.
The size is 88839360 bytes without webrtc.

BR,
/SX
Review URL: https://webrtc-codereview.appspot.com/380007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1637 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 10:38:12 +00:00
tina.legrand@webrtc.org
df69775bfa Adding support for full-stereo codec. 
This is an experiment, letting Celt represent a full-stereo codec.

Review URL: https://webrtc-codereview.appspot.com/379013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1636 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 10:22:21 +00:00
stefan@webrtc.org
2979461595 Refactored the jitter buffer to use std::list. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/352016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1635 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 08:58:55 +00:00
stefan@webrtc.org
7dfa883954 Disable spatial subsampling for denoiser variance estimation. 
With subsampling there are sometimes quite visible trailing
artifacts.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/387002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1634 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 08:27:31 +00:00
pwestin@webrtc.org
95392e64ba Bugfix EnableIPV6 issue 255 
Review URL: https://webrtc-codereview.appspot.com/378005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1633 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 08:08:37 +00:00
kjellander@webrtc.org
1970b2fcb3 Fixing uninitialized codec settings struct in test. 
BUG=
TEST=video_codecs_test_framework_unittests passing in Debug+Release on Linux, Mac and Windows.

Review URL: https://webrtc-codereview.appspot.com/378004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1632 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 07:09:32 +00:00
andrew@webrtc.org
648af7423f Clean up MapSetting(). 
- Add assert(false) for "impossible" cases.
- Remove tests for invalid enum values.
- Modify MapError() to look the same way.

BUG=
TEST=audioproc_unittest

Review URL: https://webrtc-codereview.appspot.com/386001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1631 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 01:57:29 +00:00
wu@webrtc.org
9143f774d1 Coverity fix for VideoRenderModule including issues 10084, 10226, 10267 and 10340. 
Review URL: https://webrtc-codereview.appspot.com/385001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1630 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 00:14:25 +00:00
kma@webrtc.org
551fcc04ec Optimized function WebRtcSpl_DownsampleFast for ARM-NEON platform. 
Review URL: https://webrtc-codereview.appspot.com/371001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1629 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-07 18:03:11 +00:00
bjornv@webrtc.org
236e842bca Removed memcpy of pointer to itself, triggering Valgrind warning. 
BUG=272
Review URL: https://webrtc-codereview.appspot.com/389002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1628 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-07 17:22:44 +00:00
kma@webrtc.org
59f16ec993 Introduced ARM version of WebRtcSpl_SqrtFloor(). Function cycles reduced by ~ 30% in a real time VOE test in an android device (Nexus-S, ARMv7a). 
// Fritz, I added you as a reviewer for the assembly files, just as a warm-up for future storms. :-) The assembly code was from public domain and there's little to touch.
Review URL: https://webrtc-codereview.appspot.com/369017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1627 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-07 17:15:15 +00:00
phoglund@webrtc.org
9d9ad88ba5 Fixed remaining warnings. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/393001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1626 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-07 16:16:52 +00:00
phoglund@webrtc.org
78088c2f36 Removed warnings on Windows and enabled warnings-as-errors on Windows. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/377004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1624 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-07 14:56:45 +00:00
niklas.enbom@webrtc.org
87885e8409 This CL will look a bit strange. Essentially I've removed sanity checks for > 1 channel and then fixed the bugs that remained. Will add testing in a separate CL. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/390001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1623 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-07 14:48:59 +00:00
bjornv@webrtc.org
530963925e Solves buffer overrun crash on Windows [issue 258]. 
Removed function calls not tested. Added a TODO on activating them when refactoring signal_processing.
Review URL: https://webrtc-codereview.appspot.com/379012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1620 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-07 08:10:46 +00:00
andrew@webrtc.org
daacee81b8 Use better reference files with audioproc_unittest. 
The files are shorter (7 s) with one set provided for each sample rate.

Will be accompanied by the following set of files in the resource bundle:
far8_stereo.pcm
far16_stereo.pcm
far32_stereo.pcm
near8_stereo.pcm
near16_stereo.pcm
near32_stereo.pcm

BUG=114
TEST=audioproc_unittest

Review URL: https://webrtc-codereview.appspot.com/380003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1617 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-07 00:01:04 +00:00
henrike@webrtc.org
2660460b89 Fixes flakyness in CPU unittest 
Review URL: https://webrtc-codereview.appspot.com/377005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1616 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-06 23:33:54 +00:00
wu@webrtc.org
06c7dbae14 Disable flaky test AudioProcessingTest.TestVoiceActivityDetectionWithObserver. 
BUG=263
TBR=phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/380009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1615 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-06 23:13:21 +00:00
wu@webrtc.org
50099af75f Disable flaky test VideoProcessorIntegrationTest.Process5PercentPacketLoss. 
BUG=262
TBR=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/379014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1614 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-06 22:50:48 +00:00
marpan@webrtc.org
6584e58001 Coverity fix for issues 10325,10326. 
Review URL: https://webrtc-codereview.appspot.com/377001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1613 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-06 19:02:54 +00:00
phoglund@webrtc.org
56b85c6ba8 Reduced potential for flakiness in voice detection tests. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/367024

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1612 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-06 18:48:33 +00:00
wu@webrtc.org
13e0345b35 Fix uninitialized variable error in Relase mode. 
TBR=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/377007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1611 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-06 16:19:15 +00:00
mflodman@webrtc.org
517e5e3846 NetEQ switch fix. 
Review URL: https://webrtc-codereview.appspot.com/381006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1610 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-06 15:04:00 +00:00
stefan@webrtc.org
94355e0a59 Fix crash in SessionInfo::BuildSoftNackList. 
BUG=259
TEST=

Review URL: https://webrtc-codereview.appspot.com/377006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1609 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-06 14:06:39 +00:00
mflodman@webrtc.org
a39621ee1b Disabling APM test for invalid enum values. 
Review URL: https://webrtc-codereview.appspot.com/378006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1608 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-06 14:00:12 +00:00
mflodman@webrtc.org
ec31bc1321 Fixed APM tests. 
TEST=ApmTest.*

Review URL: https://webrtc-codereview.appspot.com/380008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1607 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-06 12:42:45 +00:00
mflodman@webrtc.org
657b2a4965 Added return due to gcc complaints in r1604. 
TBR=andrew

TEST=Bulid with clang version 3.1 (trunk 148911) and gcc.

Review URL: https://webrtc-codereview.appspot.com/384004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1606 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-06 11:06:01 +00:00
mflodman@webrtc.org
c80d9d9361 Removed default cases causing clang errors, -Wcovered-switch-default. 
BUG=
TEST=Bulid with clang version 3.1 (trunk 148911)

Review URL: https://webrtc-codereview.appspot.com/379008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1604 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-06 10:11:25 +00:00
andrew@webrtc.org
4942832928 Fix "may be used uninitialized" warning. 
TBR=marpan@webrtc.org
BUG=
TEST=build on Linux/Release and rtp_rtcp_unittests

Review URL: https://webrtc-codereview.appspot.com/381004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1602 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-04 05:23:51 +00:00
marpan@webrtc.org
b783a55df3 Unit test for forward_error_correction. 
Review URL: https://webrtc-codereview.appspot.com/358006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1601 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-04 02:46:35 +00:00
marpan@webrtc.org
307c1ff20c Fix for issue #254: windows crash of test_fec. 
Review URL: https://webrtc-codereview.appspot.com/379010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1600 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-04 02:45:22 +00:00
andrew@webrtc.org
dde977ec83 AudioFrame payload shouldn't be mutable. 
This requires making Mute() non-const, which is correct anyway.

BUG=
TEST=voe_auto_test on Linux

Review URL: https://webrtc-codereview.appspot.com/376001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1599 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-03 17:47:32 +00:00
kjellander@webrtc.org
ce0a6ff43d Restoring previous vie_auto_test.gypi structure due to problems on Mac 
Now the unit test is included in the vie_auto_test target and executed when the automated flag is used.

TBR=mflodman
BUG=
TEST=vie_auto_test --automated --gtest_filter=FrameDropPrimitivesTest.FixOutputFileForComparison

Review URL: https://webrtc-codereview.appspot.com/381003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1598 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-03 14:06:46 +00:00
kjellander@webrtc.org
918a8bf40c External transport is modified to never drop packets from the first frame. 
Refactoring of FrameDropHandler: It now also tracks when frames are leaving the encoder and is being sent to external transport.

Previous 'Sent' state is now renamed to 'Created'.

NOTICE: The test seems to be a little flaky on Linux so it's not ready for buildbots yet. Since this might be caused by unstable production code further investigation should be performed to clear out the flakiness. I will file an issue for this when this CL is submitted (since I don't have any code to refer to before that). Usually the flakiness is caused by a decoded/rendered callback that is left out for the last frame, but I have seen other flaky failures too, which means it's not as simple as ignoring the last frame.
These errors occur even if 400kbps bit rate and 0% PL and 0 delay is configured.

BUG=
TEST=vie_auto_test --automated --gtest_filter="ViEVideoVerificationTest.RunsFullStackWithoutErrors" in Debug+Release on Linux, Mac and Windows.

Review URL: http://webrtc-codereview.appspot.com/339005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1597 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-03 12:40:28 +00:00
henrik.lundin@webrtc.org
683833442a Fix for warning in GCC 4.6 
Upstream copy of a fix provided in http://codereview.chromium.org/9309007/.

BUG=none
TEST=neteq_unittests

Review URL: https://webrtc-codereview.appspot.com/383002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1596 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-03 12:33:50 +00:00
henrik.lundin@webrtc.org
82e1c8d0e7 Fix for issue 253 
Initializing a few arrays to avoid compiler warnings under
the O3 flag.

BUG=http://code.google.com/p/webrtc/issues/detail?id=253

Review URL: https://webrtc-codereview.appspot.com/380005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1595 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-03 09:46:01 +00:00
pwestin@webrtc.org
fdf21c8c55 Removed dead version code. 
Review URL: https://webrtc-codereview.appspot.com/377003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1594 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-02 12:46:58 +00:00
pwestin@webrtc.org
4ea57e5e26 Changed VP8 to follow the style guide a little bit more. 
Review URL: https://webrtc-codereview.appspot.com/379003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1593 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-02 12:21:47 +00:00
xians@webrtc.org
9b3474aff8 Disable the unused API interfaces for VoE chromium build. 
Review URL: https://webrtc-codereview.appspot.com/377002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1592 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-02 08:59:11 +00:00
stefan@webrtc.org
07b45a5dc4 Added API for getting the send-side estimated bandwidth. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/372006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1591 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-02 08:37:48 +00:00
leozwang@webrtc.org
ac7e89ff1c Correct and update LICENSE 
Review URL: https://webrtc-codereview.appspot.com/382001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1590 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-01 23:04:48 +00:00
kma@webrtc.org
de66b91274 In voice engine, added member audioFrame to classes AudioCodingModuleImpl and VoEBaseImpl, 
and touched VoEBaseImpl::NeedMorePlayData and AudioCodingModuleImpl::PlayoutData10Ms(), for
performance reasons in Android platforms.
The two functions used about 6% of VoE originally. After the change, the percentage reduced
to about 0.2%.
Review URL: https://webrtc-codereview.appspot.com/379001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1589 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-01 18:39:44 +00:00
andrew@webrtc.org
7fe219f681 Add some additional checks for corrupt payload. 
Investigation with corrupt payloads revealed a few places we could
be using stronger checks. These are not foolproof by any means, but
I figure the earlier we catch this the better.

BUG=242
TEST=loopback call with a hacked ViE to insert corrupt payloads, and vie_auto_test without the hacks.

Review URL: https://webrtc-codereview.appspot.com/369015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1585 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-01 02:40:37 +00:00
kma@webrtc.org
727a0a03a1 Fixed a bug in assembly code in aecm_core.c (hasn't caused a problem yet). 
Did apm unit test. Bit exact.
Review URL: https://webrtc-codereview.appspot.com/366010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1583 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-01 00:05:22 +00:00
frkoenig@google.com
d8f58a4ab0 Cross platform build fix for SSIM (part 2) 
Data alignment fix for SSIM.

WebRtc_UWord64[2] wasn't always aligned to 128 bytes, which
is necessary for _mm_store_si128.  By declaring the 
variable as __m128i it will always be 128 bytes aligned.

Related to issue 239013.
http://webrtc-codereview.appspot.com/239013/
Review URL: https://webrtc-codereview.appspot.com/375004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1582 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-31 17:49:38 +00:00
bjornv@webrtc.org
26e8a58130 VAD refactor: Create() and Free() 
Style and return value changes. No impact externally, since audio_processing, audio_conference_mixer and audio_coding either already assumes 'int' as return value, assumes nothing or doesn't take care of the return value.

TESTS=vad_unittests, audioproc_unittest
Review URL: https://webrtc-codereview.appspot.com/374006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1581 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-31 14:42:50 +00:00
henrik.lundin@webrtc.org
dd478e2081 Fix for warning in GCC 4.6 
Upstream copy of a fix provided in http://codereview.chromium.org/9159058/.

Review URL: https://webrtc-codereview.appspot.com/369024

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1580 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-31 13:12:41 +00:00
xians@webrtc.org
79af734807 This patch fixes the converity warnings in voice engine. 
Review URL: https://webrtc-codereview.appspot.com/373017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1579 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-31 12:22:14 +00:00
stefan@webrtc.org
91c630851a Fix potential VCMReceiver crash. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/368012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1578 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-31 10:49:08 +00:00
henrika@webrtc.org
2919e95c2a Resolves Coverty issue #10347. 
Uninitialized member (UNINIT_CTOR).
Review URL: https://webrtc-codereview.appspot.com/369023

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1577 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-31 08:45:03 +00:00
marpan@webrtc.org
cdba1a836b test_fec: Reduce execution time of test, and use testsupport/fileutils.h for path of randomSeedLog file. 
Review URL: https://webrtc-codereview.appspot.com/373016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1576 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-31 00:36:14 +00:00
andrew@webrtc.org
293d22b39b Add a new macro for bit-exact audioproc tests. 
Enable bit-exact test for all fixed-point configs.

BUG=114
TEST=audioproc_unittest on all platforms.

Review URL: https://webrtc-codereview.appspot.com/369018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1575 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-30 22:04:26 +00:00
andrew@webrtc.org
40654039cd Use pointer-based CriticalSectionScoped(). 
The reference-based constructor is deprecated.

BUG=185
TEST=audioproc_unittest

Review URL: https://webrtc-codereview.appspot.com/373015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1573 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-30 20:51:15 +00:00
kma@webrtc.org
89a100092a A minor change in function WebRtcNetEQ_PacketBufferFindLowestTimestamp for 
NetEq, for performance reasons.
In Android platform, with an offline testing file, the function cycles was reduced by 25%.
This function was also reformatted.
Review URL: https://webrtc-codereview.appspot.com/367010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1571 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-30 15:37:33 +00:00
mflodman@webrtc.org
7627843352 Added NULL check in external transport test code. 
BUG=C-10246

Review URL: https://webrtc-codereview.appspot.com/367022

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1570 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-30 13:21:26 +00:00
pwestin@webrtc.org
5dad00be52 Coverty fix: FEC unintended signed extension and resource leaks. 
Review URL: https://webrtc-codereview.appspot.com/368010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1569 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-30 13:05:29 +00:00
mflodman@webrtc.org
d3b22c9356 Resolved X11 shared memiory leak. 
BUG=248
TEST=See bug

Review URL: https://webrtc-codereview.appspot.com/367016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1568 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-30 09:44:28 +00:00
bjornv@webrtc.org
0c6f931420 Removed versions in module/audio_processing and common_audio/vad. 
Affected vad_unittest only.
In addition changed to correct header guards.
Review URL: https://webrtc-codereview.appspot.com/367019

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1567 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-30 09:39:08 +00:00
stefan@webrtc.org
2fd1e1e40d Add unittests for ReceiverFec. 
Also added mock for RtpReceiverVideo and did appropriate changes to
allow for mocking.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/367017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1566 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-30 09:03:37 +00:00
pwestin@webrtc.org
04cf69a714 Coverty: cleanup CheckCSRC. 
Review URL: https://webrtc-codereview.appspot.com/369014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1564 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-27 13:47:19 +00:00
phoglund@webrtc.org
2f7740973d Fixed C errors from GCC 4.6. 
Fixed errors in .c files.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/373014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1563 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-27 13:44:26 +00:00
mflodman@webrtc.org
1f992807eb Fixed frame scaler bugs. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/367018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1562 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-27 13:42:53 +00:00
phoglund@webrtc.org
048eb7cda6 Finished rewriting the audio processing test. 
Partial rewrite of audio processing tests.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/367008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1561 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-27 11:58:41 +00:00
mflodman@webrtc.org
832adebca2 Removed MapWrapper from ViEFrameProviderBase. 
BUG=C-10189

Review URL: https://webrtc-codereview.appspot.com/356002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1560 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-27 09:31:34 +00:00
mflodman@webrtc.org
194a93ac66 Adding ViE NULL checks. 
BUG=C-10188, C-10246, C-10595

Review URL: https://webrtc-codereview.appspot.com/373013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1559 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-27 09:11:22 +00:00
tina.legrand@webrtc.org
cbe1de9aa6 This CL solves three remaining Coverity warnings. 
A few more members were left uninitialized, and one more size mismatch in a multiplication.

Review URL: https://webrtc-codereview.appspot.com/367001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1558 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-27 09:00:46 +00:00
mallinath@webrtc.org
a8c568f0a4 Fix external codec erase in destructor. 
Review URL: https://webrtc-codereview.appspot.com/368008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1555 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-26 16:19:03 +00:00
phoglund@webrtc.org
d1a860b415 Fixed GCC 4.6 errors (mostly 'unused variable' errors and incorrect usage of EXPECT_EQ with booleans. 
Fixed remaining compilation errors in release, etc.

Fixed errors from GCC 4.6 compilation.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/366008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1554 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-26 14:49:28 +00:00
andrew@webrtc.org
42ae41e5a2 Fix enumeral comparison error. 
TBR=henrike
BUG=
TEST=build on Linux.

Review URL: https://webrtc-codereview.appspot.com/372007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1553 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-25 19:38:16 +00:00
andrew@webrtc.org
b9d7d934de Rename interface/ to include/ in audio_processing. 
BUG=none
TEST=build on Linux.

Review URL: https://webrtc-codereview.appspot.com/367007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1552 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-25 19:21:13 +00:00
andrew@webrtc.org
24bd58e689 Properly count anonymous mixing participants. 
When _amountOfMixableParticipants == 1, we skip mixing and saturation
protection. Without this fix, an anonymous participant would only be
properly counted if it was the last added.

For example, if an anonymous participant was added first, followed by
a regular participant, _amoutOfMixableParticipants would == 1 and the
regular participant would not be mixed.

BUG=issue209
TEST=New test added to voe_auto_test to verify, and used voe_cmd_test.

Review URL: https://webrtc-codereview.appspot.com/367006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1551 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-25 18:57:44 +00:00
henrik.lundin@webrtc.org
dcf006480c Fix typo in a comment 
TBR=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/369012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1548 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-25 16:48:00 +00:00
henrik.lundin@webrtc.org
4679652d57 Implemented a fix for Issue 88. 
NetEQ now checks for too early CNG packets, and modifies the CNG
sample counter to jump forward in time if needed to combat clock
drift.

Adding a new unittest to reproduce and solve the issue. The
unittest LongCngWithClockDrift verifies that the buffer delay
before and after a long CNG period is almost constant. The test
introduces a clock drift of 25 ms/s.

BUG=http://code.google.com/p/webrtc/issues/detail?id=88
TEST=neteq_unittests NetEqDecodingTest.LongCngWithClockDrift

Review URL: https://webrtc-codereview.appspot.com/372002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1547 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-25 16:37:41 +00:00
mflodman@webrtc.org
9b0a820624 Fixed double erase in ViEChannelManager channel map. 
Review URL: https://webrtc-codereview.appspot.com/369011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1546 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-25 16:00:49 +00:00
mflodman@webrtc.org
b11424bc11 Remove ViEShared inheritance for interface impl. 
Review URL: https://webrtc-codereview.appspot.com/357002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1545 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-25 13:42:03 +00:00
bjornv@webrtc.org
f4b77fd722 VAD refactor: Mode changed to "int". 
As part of style this CL includes changing the input aggressiveness mode from int16_t to int. No other style changes made.
Impact on:
- Audio Processing: Changed return value on MapSetting().
- Function test in audio_conference_mixer already uses int. No action.
- NetEq: Function pointer changes and input parameter changes in SetVADMode() and SetVADModeInternal().
- Audio Coding: Uses enum ACMVADMode which is type independent.
- VAD: Two unit tests.

TESTS=vad_unittests, neteq_unittests, audioproc_unittest
Review URL: https://webrtc-codereview.appspot.com/373001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1544 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-25 12:40:00 +00:00
bjornv@webrtc.org
2a4dcd7d15 VAD refactor: WebRtcVad_InitCore(). 
Impact only locally.
- Replaced for loops with memset().
- Added guard against NULL pointer.
- Removed mode as input parameter (never really used).
- Updated unit tests.
- Made struct member init_flag "int".
- Updated function description.
- Updated Copyright notes with 2012.
- Removed some lint warnings.

TESTS=vad_unittests, audioproc_unitest
Review URL: https://webrtc-codereview.appspot.com/369005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1543 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-25 12:18:12 +00:00
henrike@webrtc.org
567b99be5f Coverity report: fixes an issue where the returnvalue of a function is not checked. 
Review URL: https://webrtc-codereview.appspot.com/347013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1542 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-24 23:43:54 +00:00
andrew@webrtc.org
f5d8c3bc3b Fix audioproc_unittest on Windows. 
On Windows, files have to be closed before they can be removed.

TBR=bjornv
BUG=none
TEST=audioproc_unittest on Windows.

Review URL: https://webrtc-codereview.appspot.com/369010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1541 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-24 21:35:39 +00:00
pwestin@webrtc.org
f6bb77a6f0 Cleaning up all use of RTP_PAYLOAD_NAME_SIZE and RTCP_CNAME_SIZE also fixed the char handing in trace. 
Review URL: https://webrtc-codereview.appspot.com/358001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1535 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-24 17:16:59 +00:00
mallinath@webrtc.org
218db3de20 Iterator was invalid while removing entries from codec db maps. 
Review URL: http://webrtc-codereview.appspot.com/373003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1534 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-24 17:11:44 +00:00
stefan@webrtc.org
9e332ab95b Make sure we check the return value from shmat(). 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/358007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1533 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-24 16:33:27 +00:00
pwestin@webrtc.org
b73c3d1f5d Bugfix android build. 
Review URL: https://webrtc-codereview.appspot.com/374003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1532 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-24 15:25:30 +00:00
pwestin@webrtc.org
28a5cb29ab Bugfix receive side only packet loss estimate with NACK. 
Review URL: https://webrtc-codereview.appspot.com/373006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1529 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-24 14:34:58 +00:00
perkj@webrtc.org
40d3c08be4 Changed max number of vie channels to 32. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/374002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1527 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-24 14:04:17 +00:00
mflodman@webrtc.org
ba09cf16ec Correcting uninitialized members. 
BUG=C-10344, C-10345, C-10346

Review URL: https://webrtc-codereview.appspot.com/345012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1525 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-24 07:49:33 +00:00
mflodman@webrtc.org
a5a5cbb992 Switched from WebRTC wrappers to stl in ChannelManager. 
BUG=C-10187

Review URL: https://webrtc-codereview.appspot.com/357001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1524 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-24 06:50:15 +00:00
andrew@webrtc.org
eeaf3d1fc1 Merge /branches/3.2:r1380 to /trunk 
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1523 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-24 06:30:02 +00:00
mflodman@webrtc.org
6cf529d082 Changed REMB return value to int instead of bool. 
Review URL: https://webrtc-codereview.appspot.com/366001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1522 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-24 06:16:16 +00:00
andrew@webrtc.org
d3a0c1cb66 Merge /branches/3.2:r1378 to /trunk 
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1521 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-24 03:20:53 +00:00
kma@webrtc.org
4bc24c4afa Optimized function WebRtcSpl_FilterARFastQ12 for ARM platform. 
Speed close to doubled for an offline test in NetEq.
Bit exact.
Review URL: https://webrtc-codereview.appspot.com/346001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1520 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-24 02:12:49 +00:00
punyabrata@webrtc.org
6da8eeb946 Removing an assert for a case that can occur 
when corrupt packets are injected into voice engine.
Review URL: https://webrtc-codereview.appspot.com/373004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1518 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-24 00:48:36 +00:00
leozwang@webrtc.org
f5cacdce8c Fix line aligement 
Review URL: https://webrtc-codereview.appspot.com/373002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1516 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-23 23:14:13 +00:00
leozwang@webrtc.org
f9cd693145 Enable vp8 and videoengine on android 
Review URL: https://webrtc-codereview.appspot.com/368003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1510 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-23 16:56:13 +00:00
leozwang@webrtc.org
a45d05a341 Add brighten.cc to makefile 
Review URL: https://webrtc-codereview.appspot.com/369003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1509 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-23 16:54:13 +00:00
leozwang@webrtc.org
376be6c904 Fix compilation error 
Review URL: https://webrtc-codereview.appspot.com/358005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1508 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-23 16:46:38 +00:00
pwestin@webrtc.org
b30f0edce6 Bugfix buffer usage out of scope. 
Review URL: https://webrtc-codereview.appspot.com/372001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1507 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-23 16:23:31 +00:00
phoglund@webrtc.org
12dbc23851 Rewrote volume test. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/367004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1506 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-23 16:03:04 +00:00
stefan@webrtc.org
175fecde97 Fix clang build error. 
TBR=henrik.lundin@webrtc.org
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/367005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1505 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-23 15:23:31 +00:00
stefan@webrtc.org
8fe03af674 Refactor to use std::list in the video rtp play tools. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/349013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1504 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-23 14:56:14 +00:00
bjornv@webrtc.org
152c34cf11 VAD-refactor. Changed to int as return value for WebRtcVad_set_mode(). 
Impact on NetEq function pointers. Other components already treat the output as int. These are:
* audio_processing
* funtion test in audio_conference_mixer
* audio_coding

TEST=vad_unittests, neteq_unittests
Review URL: https://webrtc-codereview.appspot.com/367003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1503 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-23 12:36:46 +00:00
phoglund@webrtc.org
3b57ee0238 Rewrote DTMF test. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/368001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1502 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-23 09:22:33 +00:00
leozwang@webrtc.org
31627fe82c Add vie_remb.cc to makefile 
Review URL: https://webrtc-codereview.appspot.com/358004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1501 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-20 23:10:26 +00:00
andrew@webrtc.org
e2ed5baf47 Enable audioproc_unittest on all platforms. 
But, for the time being, limit the bit-exact test to 64-bit Linux debug.

TEST=build and run all configs on Linux, and standard configs on Win and Mac.

Review URL: https://webrtc-codereview.appspot.com/343005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1500 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-20 19:06:38 +00:00
leozwang@webrtc.org
2638577f03 Add an argument in ANDROID_NOT_SUPPORT macro 
Review URL: https://webrtc-codereview.appspot.com/363003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1499 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-20 18:45:45 +00:00
stefan@webrtc.org
f27916a76a Remove use of MapWrapper in video_coding. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/344018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1498 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-20 14:04:13 +00:00
henrik.lundin@webrtc.org
d798953846 NetEqRTPplay modification 
Make the program look for the ptypes.txt file in the default trunk
path, if the path to the executable indicates that it sits in the
trunk/out/Debug folder.

Changing PT for CNG-WB to 98

Remove warnings when building NetEQ with NETEQ_DELAY_LOGGING

Review URL: https://webrtc-codereview.appspot.com/339003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1497 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-20 13:42:16 +00:00
phoglund@webrtc.org
d056abd62f Prepared tests for running on build bot. 
The changes will mostly clarify why PSNR and SSIM thresholds are chosen. I think those explanations will be good since these tests may well be a bit flaky.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/343017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1496 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-20 12:48:13 +00:00
mflodman@webrtc.org
c672d34ac7 Removed file duplicate added in r1312. 
Review URL: https://webrtc-codereview.appspot.com/357003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1495 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-20 12:30:42 +00:00
kjellander@webrtc.org
5e1625ed2d Fixing Valgrind problem detected by video_processing_unittests. 
Simple initialization of the allocated memory for the image buffer avoids reading uninitialized data in some special cases.

This fix is only intended for Linux, since the test is known to fail on Windows. But since we're currently only running Valgrind on Linux, this will give us improved control over memory issues.

BUG=
TEST=tools/valgrind-webrtc/webrtc_tests.sh -t cmdline out/Debug/video_processing_unittests

Review URL: http://webrtc-codereview.appspot.com/349012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1493 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-20 08:40:55 +00:00
pwestin@webrtc.org
56ee5d5d98 Bugfix 32 bit linux. 
Review URL: https://webrtc-codereview.appspot.com/353010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1490 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-20 07:47:38 +00:00
pwestin@webrtc.org
95cf47932d Remove list wrapper from FEC code. 
Review URL: https://webrtc-codereview.appspot.com/350013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1489 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-20 06:59:06 +00:00
leozwang@webrtc.org
9165f1fe91 Changed to use std::sort 
Review URL: https://webrtc-codereview.appspot.com/356003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1488 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-20 01:39:13 +00:00
andrew@webrtc.org
f33dfa89b9 Add target and config info to merged lib name. 
BUG=None
TEST=build merged_lib on Linux, Mac, Win

Review URL: https://webrtc-codereview.appspot.com/344014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1487 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-20 01:32:16 +00:00
leozwang@webrtc.org
a191506ce9 Enable all modules without building errors 
Review URL: https://webrtc-codereview.appspot.com/360004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1485 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 22:11:37 +00:00
mflodman@webrtc.org
2d03b8b217 REMB now works for two consecutive calls with different channels but same ViE instance. 
BUG=241

Review URL: https://webrtc-codereview.appspot.com/361001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1484 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 21:21:15 +00:00
andrew@webrtc.org
300aed945d Use -Wextra on Linux for standalone builds. 
BUG=None
TEST=build on Linux, Mac, Windows

Review URL: https://webrtc-codereview.appspot.com/348009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1482 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 20:10:19 +00:00
mflodman@webrtc.org
0f4cb131c6 Added NULL check in ViEFileImpl. 
BUG=C-10188

Review URL: https://webrtc-codereview.appspot.com/344016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1480 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 18:41:39 +00:00
marpan@webrtc.org
20cd06123c For TL(temporal layers) = 2, the alt-ref frame should not be used as a reference. 
Correction for the last frame in the cycle.
Review URL: https://webrtc-codereview.appspot.com/343015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1479 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 18:25:23 +00:00
pwestin@webrtc.org
0074187436 Removed map_wrapper from rtp_sender 
Review URL: https://webrtc-codereview.appspot.com/343014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1478 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 15:56:10 +00:00
pwestin@webrtc.org
3c9be1bc4d Removed list wrapper fromr overuse detector. 
Review URL: https://webrtc-codereview.appspot.com/353004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1477 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 15:55:54 +00:00
pwestin@webrtc.org
d4adc5b26f removed unused include from remote rate control. 
Review URL: https://webrtc-codereview.appspot.com/350015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1476 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 15:55:30 +00:00
pwestin@webrtc.org
af6f15c1bf Changed RTP reveivers to use stl map and list. 
Review URL: https://webrtc-codereview.appspot.com/349010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1475 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 15:53:59 +00:00
pwestin@webrtc.org
38f4816737 Removed unused include from rtp sender audio. 
Review URL: https://webrtc-codereview.appspot.com/348012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1474 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 15:53:33 +00:00
pwestin@webrtc.org
26f8d9c7f3 Removed list and map wrappers, for RTCP handling. 
Review URL: https://webrtc-codereview.appspot.com/349011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1473 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 15:53:09 +00:00
tommi@webrtc.org
9ff87db5c0 Remove the diamond inheritance pattern from VoEVideoSyncImpl in attempt to see if this fixes coverity reports. 
CID=10446,10445,10444,10443
Review URL: https://webrtc-codereview.appspot.com/343018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1472 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 15:05:36 +00:00
tina.legrand@webrtc.org
d71a11c15e Fixing Coverity issues in Audio Coding Module 
10198: Out-of-bounds read in acm_isac.cc
10251: Unintended sign extension in acm_resampler.cc
10273: Uninitialized pointer field in acm_amr.cc
10274: Uninitialized pointer field in acm_amrwb.cc
10275: Uninitialized scalar field in acm_dtmf_detection.cc
10276: Uninitialized pointer field in acm_g722.cc
10277: Uninitialized pointer field in acm_g7221.cc
10278: Uninitialized pointer field in acm_g7221c.cc
10279: Uninitialized pointer field in acm_g729.cc
10280: Uninitialized pointer field in acm_g7291.cc
10281: Uninitialized pointer scalar in acm_generic_codec.cc
10282: Uninitialized pointer field in acm_gsmfr.cc
10283: Uninitialized scalar field in acm_isac.cc
10284: Uninitialized pointer field in acm_opus.cc
10285: Uninitialized scalar field in acm_resampler.cc
10286: Uninitialized pointer field in acm_speex.cc
10287: Uninitialized scalar field in audio_coding_module_impl.cc
10581: Unintended sign extension in audio_coding_module_impl.cc

Additional change: removed unused function and member from ACMResampler.

Review URL: https://webrtc-codereview.appspot.com/343016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1471 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 13:22:22 +00:00
henrik.lundin@webrtc.org
dcdb744eee Remove an old comment in vp8 wrapper 
The operation that the comment describes was removed in r482.

Review URL: https://webrtc-codereview.appspot.com/353008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1470 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 13:06:43 +00:00
pwestin@webrtc.org
1da2327473 Changing header extension to use stl map. 
Review URL: https://webrtc-codereview.appspot.com/350014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1469 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 12:58:53 +00:00
mflodman@webrtc.org
70111e69bf Switching to stl instead of WebRTC wrappers. 
BUG=C-10436, C-10437, C-10438

Review URL: https://webrtc-codereview.appspot.com/343012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1468 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 12:48:53 +00:00
stefan@webrtc.org
8e50693736 Fixes for code analysis warnings. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/355004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1467 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 12:30:21 +00:00
bjornv@webrtc.org
6748087467 Incorrect pointer inputs in filter test. 
Two filter functions were called wrongly, which made us read from uninitialized values.
Added short comment.
No style changes. The tests will be revisited and extended during an upcoming refactor.

signal_processing_unittests now pass Valgrind.

TEST=signal_processing_unittests
Review URL: https://webrtc-codereview.appspot.com/344015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1466 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 10:41:39 +00:00
bjornv@webrtc.org
12cccddc63 NS-SWB: Actived SWB processing at once, i.e., no startup phase. 
Performance verified on a few 32 kHz files.
BUG=
TEST=audioproc, audioproc_unittest

Updated output_data_float.pb
Changes in SWB tests (3, 6, 9 and 12) as

Running test 3 of 12...
src/modules/audio_processing/test/unit_test.cc:1182: Failure
Value of: max_output_average
  Actual: 1363
Expected: test->max_output_average()
Which is: 1386

Running test 6 of 12...
src/modules/audio_processing/test/unit_test.cc:1182: Failure
Value of: max_output_average
  Actual: 2070
Expected: test->max_output_average()
Which is: 2109

Running test 9 of 12...
src/modules/audio_processing/test/unit_test.cc:1182: Failure
Value of: max_output_average
  Actual: 1314
Expected: test->max_output_average()
Which is: 1336

Running test 12 of 12...
src/modules/audio_processing/test/unit_test.cc:1182: Failure
Value of: max_output_average
  Actual: 2049
Expected: test->max_output_average()
Which is: 2085
Review URL: https://webrtc-codereview.appspot.com/344013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1465 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 08:56:38 +00:00
andrew@webrtc.org
17585856f5 Merged /branches/3.2:r1381 to /trunk 
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1464 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 00:15:08 +00:00
mflodman@webrtc.org
d5a83ce972 Changed to red and ULPFEC to ulpfec in GetCodec. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/355005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1462 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-18 22:39:32 +00:00
andrew@webrtc.org
267ca3162b Fix comparison-always-true warning with -Wextra. 
TEST=build on Linux with -Wextra.

Review URL: https://webrtc-codereview.appspot.com/353005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1456 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-18 19:41:40 +00:00
punyabrata@webrtc.org
ad1927d368 Changing the typing detection sensitivity as the current 
setting does not work well in some scenarios especially
using webcams with built-in microphones.
Review URL: https://webrtc-codereview.appspot.com/349009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1455 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-18 18:53:04 +00:00
bjornv@webrtc.org
ab2bb82ac9 VAD refactor: int return value for Init. 
For consistency and as part of style, the return value of WebRtcVad_Init() has been changed to int.

Impact:
 1) audio_processing, audio_coding, a test in CNG, functionTest in audio_conference_mixer, a test in net_eq all used int values. Hence, unaffected.
 2) Function pointers in net_eq changed.
 3) The VADInit in neteq/dsp.c boiled down to typecast into int anyhow, which now is removed.

TEST=vad_unittests, neteq_unittests
Review URL: https://webrtc-codereview.appspot.com/355003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1453 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-18 14:51:02 +00:00
phoglund@webrtc.org
5badc7e969 Put system cpu tests back in, improved documentation. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/350011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1452 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-18 10:46:07 +00:00
henrik.lundin@webrtc.org
4407edc314 Bugfix in VP8 packetizer 
Handle the case with no small partitions in Vp8PartitionAggregator.
Also added a new unit test for the packetizer to verify that the
bug is fixed.

TEST=RtpFormatVp8Test.TestAggregateModeTwoLargePartitions
TBR=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/348011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1451 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-18 10:01:03 +00:00
mflodman@webrtc.org
8224451ee4 Add check for ftell return value. 
BUG=C-10170

Review URL: https://webrtc-codereview.appspot.com/355001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1450 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-18 09:36:46 +00:00
mflodman@webrtc.org
cdeb483c6a Fixed ignored return value. 
BUG=C-10011

Review URL: https://webrtc-codereview.appspot.com/353003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1449 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-18 09:00:04 +00:00