pwestin@webrtc.org
b1313aac7c
Fix missing h file change.
...
Review URL: https://webrtc-codereview.appspot.com/535001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2136 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-27 05:42:05 +00:00
pwestin@webrtc.org
49888ce428
Breaking out send side bitrate controll cont.
...
Review URL: https://webrtc-codereview.appspot.com/475004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2135 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-27 05:25:53 +00:00
mallinath@webrtc.org
e611619f60
Fixing the header file path in gypi file.
...
BUG=473
Review URL: https://webrtc-codereview.appspot.com/529001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2134 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-26 23:03:15 +00:00
andrew@webrtc.org
9c4f6a5ff9
Add an AudioFrameOperations unittest.
...
Additionally, reformat audio_frame_operations to Goog style.
BUG=issue451
TEST=voice_engine_unittests
Review URL: https://webrtc-codereview.appspot.com/528001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2133 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-26 22:32:03 +00:00
tommi@webrtc.org
e49d908baf
Fix how we were using TbInterfaces and disallow operator=() and the copy constructor.
...
The reason is that this will cause a crash:
TbInterfaces foo = TbInterfaces("blah");
It relies on the generated copy constructor (or assignment operator), which copies the
pointer values from a temporary object. After |foo| in this case has been initialized
with values from the temporary object, the temp goes out of scope and is deleted.
The result is that |foo| has been initialized with pointers do a deleted object.
Also fixing expectations for the return value of VoE Release() calls after I checked
in my change that makes the VoiceEngine per-object ref counted and not per-interface.
Review URL: https://webrtc-codereview.appspot.com/509005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2128 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-26 17:05:32 +00:00
tommi@webrtc.org
a990e122c4
* Change the reference counting implementation for VoE to be per object and
...
not per interface. This simplifies things a bit, reduces code and makes it
possible to implement reference counting (if we ever want) without the
static Delete() method. (Reference counted objects are traditionally
implicitly deleted via the last Release())
* Since the reference counting code is now simpler, there's no need for the
RefCount class so I'm removing it.
* Also removing the optional |ignoreRefCounters| variable from the VoiceEngine::Delete
method. The justification is that it's no longer used and the reason it was there
in the first place was to avoid bugs in third party code, so it's an indication that
something is wrong elsewhere.
* Fix a crash in voe_network_impl and voe_extended_test that would happen on machines with IPv6 support.
* Fix an assert (handle the case) in the extended audio tests when SetCNAME is called with a NULL pointer.
* As a side effect of this change, hopefully the footprint of VoE will be slightly smaller :)
BUG=10445 (Coverity)
Review URL: https://webrtc-codereview.appspot.com/521003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2127 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-26 15:28:22 +00:00
phoglund@webrtc.org
497fb4fda9
Fixed vie_auto_test on mac so it will exit when the test completes instead of hanging like it used to.
...
Also applied an old patch I had which rewrites the window handling to do ui stuff on the main thread instead of the worker thread, which as far as I know is a very bad idea.
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/502001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2126 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-26 12:58:02 +00:00
tina.legrand@webrtc.org
bc1b43b297
Refactoring of audio_coding_module_impl
...
First patch set: pure formatting.
Review URL: https://webrtc-codereview.appspot.com/522001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2125 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-26 08:53:45 +00:00
tina.legrand@webrtc.org
a6ecd1ebb5
Refactoring one of the ACM tests: TestStereo, to follow the style guide.
...
(First patch: formatting the test file)
TEST=audio_coding_module_test
Review URL: https://webrtc-codereview.appspot.com/507001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2124 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-26 07:54:30 +00:00
phoglund@webrtc.org
61331137b6
Reduced the time from check-in to build significantly.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/525001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2123 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-26 07:32:07 +00:00
mflodman@webrtc.org
1868780c81
Disabled UnremovedSocketsGetCollectedAtManagerDeletion in UdpSocketManager unittest.
...
TBR= hta@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/520004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2122 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-26 06:40:00 +00:00
andrew@webrtc.org
1c7bfe02f7
Fail silently when swapping mono.
...
TBR=tina.legrand@webrtc.org
BUG=issue451
TEST=forthcoming unittest
Review URL: https://webrtc-codereview.appspot.com/527003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2121 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-26 00:20:28 +00:00
stefan@webrtc.org
da12dde4d2
Upgrade libvpx to dba0538.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/521002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2119 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-25 19:16:00 +00:00
hta@webrtc.org
ad929899c7
Tests for udp_socket_manager.
...
These tests basically check that socket allocation does not leak memory.
BUG=
TEST=unittested, ran under valgrind.
Review URL: https://webrtc-codereview.appspot.com/519003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2118 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-25 14:06:50 +00:00
phoglund@webrtc.org
52884813ad
Removed dependency which has moved into tools/DEPS.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/510003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2117 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-25 12:24:09 +00:00
phoglund@webrtc.org
6a65cfbb0e
Enabled the new PyAuto test on the build bot.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/520003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2116 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-25 10:11:55 +00:00
asapersson@webrtc.org
d18dd6dc7e
Made OnPacketLossStatisticsUpdate function virtual (needed for ViCE).
...
Review URL: https://webrtc-codereview.appspot.com/520002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2115 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-25 07:19:02 +00:00
andrew@webrtc.org
02d7174722
Add API to swap stereo channels.
...
BUG=issue451
TEST=manually with voe_cmd_test, using stereo and mono codecs
Review URL: https://webrtc-codereview.appspot.com/519001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2106 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-24 19:47:00 +00:00
andrew@webrtc.org
369166a179
Add API for disabling the high pass filter.
...
BUG=issue419
TEST=manually with voe_cmd_test
Review URL: https://webrtc-codereview.appspot.com/509003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2105 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-24 18:38:03 +00:00
leozwang@webrtc.org
48a5df6481
Embed svn revision number into code
...
BUG=
TEST=build on linux
Review URL: https://webrtc-codereview.appspot.com/516001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2104 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-24 14:50:50 +00:00
kjellander@webrtc.org
b28b43a66f
Adding alwaysUseLatest parameter for GClient sync.
...
Removed confusing use of Subversion URL in places where it doesn't have
any effect.
BUG=None
TEST=Successful build with local master and the Chrome slave.
Review URL: https://webrtc-codereview.appspot.com/521001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2103 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-24 07:48:21 +00:00
elham@webrtc.org
5f49dba1a1
Hi Magnus, I added some of the changes that you suggested before. Let me know what you think.
...
Review URL: https://webrtc-codereview.appspot.com/507004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2101 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 21:24:02 +00:00
kjellander@webrtc.org
7401a1f393
Updating Chrome excludes to use the same as Chrome buildbots.
...
See the NEEDED_COMPONENTS constant of http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/master/factory/chromium_factory.py?view=markup for more details.
BUG=None
TEST=None
Review URL: https://webrtc-codereview.appspot.com/513001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2099 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 18:59:40 +00:00
andrew@webrtc.org
4e423b3b1e
Handle master/slave timestamp wrap.
...
BUG=issue410
TEST=neteq_unittests, audio_coding_module_test
Review URL: https://webrtc-codereview.appspot.com/506001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2098 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 18:59:00 +00:00
kjellander@webrtc.org
55e4fffa5b
LCOV fix in addition to r2095.
...
https://webrtc-codereview.appspot.com/515002 was not properly tested.
BUG=None
TEST=Tested on local master and slave, verified fix working in twistd.log on master.
TBR=phoglund
Review URL: https://webrtc-codereview.appspot.com/513002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2097 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 18:22:20 +00:00
vikasmarwaha@webrtc.org
99ac3f7be5
Fixed trunacated trace problem in WebRTC. http://b.corp.google.com/issue?id=5607856
...
Review URL: https://webrtc-codereview.appspot.com/508004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2096 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 17:04:35 +00:00
kjellander@webrtc.org
f3794f8e5a
Fixed normal LCOV case
...
BUG=None
TEST=Tested on local master, with and without a test failure.
Review URL: https://webrtc-codereview.appspot.com/515002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2095 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 15:42:56 +00:00
pwestin@webrtc.org
ddab60be56
Wire up pading.
...
Review URL: https://webrtc-codereview.appspot.com/509002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2094 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 14:52:15 +00:00
bjornv@webrtc.org
11654c2344
VAD refactoring: Local variable name changes
...
Changes tested with vad_unittests and audioproc_unittest
BUG=None
TEST=None
Review URL: https://webrtc-codereview.appspot.com/485004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2093 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 14:50:11 +00:00
mflodman@webrtc.org
5284d6e905
Minor change to trigger REMB packets in RTCP RR if there is no sending channel.
...
BUG=
TEST=video_engine_core_unittest
Review URL: https://webrtc-codereview.appspot.com/508007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2092 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 13:22:26 +00:00
hta@webrtc.org
bf9f469a13
Lifetime management for UdpSocketManager
...
Make tests use Create/Destroy *or* new/delete for UdpSocketManager.
Move responsibility for calling Destroy on UdpSocketManager from transport
destructor to transport Destroy function.
This all ends up in not leaking memory in InitializeSourcePorts test.
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/512001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2091 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 13:19:30 +00:00
asapersson@webrtc.org
92591adc67
Fixes link issues in google3 (change by tomasl).
...
Review URL: https://webrtc-codereview.appspot.com/509001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2090 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 13:10:55 +00:00
asapersson@webrtc.org
83ed0a4359
Try to resend next packet in nack list even if previous packet is not found.
...
Review URL: https://webrtc-codereview.appspot.com/515001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2089 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 12:43:05 +00:00
phoglund@webrtc.org
f6cd33dd89
Implemented bloat calculation. This will measure the binary size of Chrome+WebRTC components each weekend.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/508005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2088 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 09:27:57 +00:00
kjellander@webrtc.org
39946f1380
Skipping code coverage HTML generation on failed builds.
...
BUG=None, except that the dashboard shows confusing stats.
TEST=Tested with local master and slave.
Review URL: https://webrtc-codereview.appspot.com/508002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2087 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 08:57:44 +00:00
pwestin@webrtc.org
fcbbe1f341
Removed unused callback code from video coding test.
...
Review URL: https://webrtc-codereview.appspot.com/504003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2086 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 08:33:18 +00:00
pwestin@webrtc.org
a2cd732139
Fix for calling OnNetworkChanged too often.
...
Review URL: https://webrtc-codereview.appspot.com/508006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2085 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 08:32:47 +00:00
marpan@webrtc.org
88ad06b999
VCM: Added condition(s) for setting FEC protection factor to zero at low bitrates.
...
Review URL: https://webrtc-codereview.appspot.com/494001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2084 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-20 16:05:24 +00:00
asapersson@webrtc.org
63a34f4f29
Fix in SendPadData. Do not increase sequence number if packet is "empty" and not sent.
...
Review URL: https://webrtc-codereview.appspot.com/508001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2083 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-20 13:20:27 +00:00
phoglund@webrtc.org
bb77000123
Added a virtual destructor to get the test to compile on all platforms.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/507003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2082 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-20 13:03:12 +00:00
phoglund@webrtc.org
b73f01e7fd
Removed some obviously dead stuff from voe_auto_test.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/495001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2081 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-20 10:59:31 +00:00
hta@webrtc.org
bbd6b561cf
Memory leak fix: Deleting a factory
...
Also expanded some documentation.
Bug found by Valgrind bot.
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/507002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2080 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-20 09:51:26 +00:00
bjornv@webrtc.org
bcde776340
Changed Delay Estimator create call
...
Unit tests updated and runs.
Change made w.r.t. issue 441.
BUG=Issue441
TEST=None
Review URL: https://webrtc-codereview.appspot.com/498001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2079 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-20 09:35:20 +00:00
hta@webrtc.org
0abe535e16
Refactored udp_transport to take socket manager as dependency injection
...
This avoids having to deal with the socket manager in the unittest.
Extended tests to cover one case where sockets got allocated.
BUG=
TEST=unittest
Review URL: https://webrtc-codereview.appspot.com/496001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2078 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-20 08:23:16 +00:00
kjellander@webrtc.org
4e645ee783
Improved error message when capture device is missing.
...
With this patch the test stops when it doesn't find a camera instead of crashing with a large hard-to-read stack trace.
BUG=None
TEST=vie_auto_test --automated in Debug+Release on lin, mac, win
Review URL: https://webrtc-codereview.appspot.com/497003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2077 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-20 08:10:37 +00:00
andrew@webrtc.org
b61f1fa675
Reset slave when switching to a stereo codec.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/494003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2073 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-20 01:10:14 +00:00
leozwang@webrtc.org
00a8dbb0ec
Change Watchlist
...
Review URL: https://webrtc-codereview.appspot.com/503001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2072 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-19 18:09:23 +00:00
tommi@webrtc.org
f4c80fc6cb
Switch the other android build over to android_posix.cc and not android_linux.cc.
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2070 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-19 15:41:33 +00:00
tommi@webrtc.org
9018c9f548
Fix androidndk build take two.
...
TBR=xians
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2069 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-19 15:38:10 +00:00
tommi@webrtc.org
3db5cb7438
Fix AndroidNDK build.
...
TBR=xians
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2068 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-19 15:29:08 +00:00