Commit Graph

807 Commits

Author SHA1 Message Date
henrike@webrtc.org
a4351a045d libjingle: use _stricmp instead of deprecated stricmp.
BUG=N/A
R=turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/25869004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7447 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-14 17:07:41 +00:00
pbos@webrtc.org
7fe1e03dd6 Wire up external encoders.
R=pthatcher@webrtc.org
BUG=1788

Review URL: https://webrtc-codereview.appspot.com/30649005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7440 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-14 04:25:33 +00:00
buildbot@webrtc.org
f68cc0b0c3 (Auto)update libjingle 77554188-> 77629208
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7439 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-14 01:17:42 +00:00
henrike@webrtc.org
1e6a5dd14e Removes xmllite from talk/xmllite since webrtc/xmllite is used instead.
BUG=3379
R=marpan@google.com

Review URL: https://webrtc-codereview.appspot.com/23039004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7436 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-13 18:27:11 +00:00
buildbot@webrtc.org
3c16d8bd1c (Auto)update libjingle 77414393-> 77554188
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7428 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-13 06:35:10 +00:00
xians@webrtc.org
3cefbc99f4 Mark all virtual overrides in the hierarchy of Transport as virtual + OVERRIDE.
This also marks all virtual overrides of other classes in the same files. 

This will make a subsequent change I intend to do safer, where I'll change the 
argument types of the base Transport functions, by breaking the compile if I 
miss any overrides. 

This also highlighted a number of unused functions. I've removed some of these. 

TBR=mflodman@webrtc.org, pkasting@chromium.org
BUG=none 
TEST=none

Review URL: https://webrtc-codereview.appspot.com/28709004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7421 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-10 09:42:53 +00:00
glaznev@webrtc.org
dae40dcde9 Change setting VP8 codec specific info values by HW VP8 encoder
to follow SW implementation.

This fixes video freezing observed when connecting Android AppRtcDemo
on devices with hW encoder support with Chrome apprtc.

BUG=
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/31629004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7414 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-09 17:53:09 +00:00
glaznev@webrtc.org
95bacfed08 Remove bad waiting code from video decoder release function.
Instead keep surface texture object alive while video codec
is re-initialized with a different resolution.

BUG=
R=tkchin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/28649004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7401 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-09 00:00:11 +00:00
buildbot@webrtc.org
97abeee282 (Auto)update libjingle 77263371-> 77296420
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7400 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-08 22:24:30 +00:00
pbos@webrtc.org
575d126a3d Protect send_/recv_streams_ in WebRtcVideoEngine2.
Important as OnLoadUpdate() won't be called on the worker thread and the
list of streams can't be concurrently modified while delivering this
callback to all send streams.

R=stefan@webrtc.org
BUG=1788

Review URL: https://webrtc-codereview.appspot.com/22959004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7395 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-08 14:48:08 +00:00
jiayl@webrtc.org
742922b313 Make the media content send only if offerToReceive is false while local streams exist.
We previously do not add the media content if offerToReceive is false.

BUG=3833
R=pthatcher@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/26609004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7390 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-07 21:32:43 +00:00
pbos@webrtc.org
d6bda09503 Initialize sctp_paddrparams in OpenSctpSocket().
Addresses 'use-of-uninitialized-value' detected with MemorySanitizer.
params.spp_address.sa_family was used without being initialized before
when calling usrsctp_setsockopt with SCTP_PEER_ADDR_PARAMS.

R=jiayl@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/23909004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7389 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-07 19:23:43 +00:00
glaznev@webrtc.org
46ffc70878 Temporary fix to allow Invoke() calls for VP8 HW encoder and decoder.
BUG=
R=jiayl@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/24849004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7387 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-07 17:11:36 +00:00
pbos@webrtc.org
963b979510 Remove potential deadlock in WebRtcVideoEngine2.
Fixes lock-order inversions between capturer's SignalVideoFrame and
WebRtcVideoSendStream. Additionally also removes all deadlock
suppressions for WebRtcVideoEngine2.

R=stefan@webrtc.org
TBR=kjellander@webrtc.org
BUG=1788,2999

Review URL: https://webrtc-codereview.appspot.com/26729004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7386 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-07 14:27:27 +00:00
kjellander@webrtc.org
6ed1cf49f0 Isolate: Remove use of --ignore_broken_items
BUG=chromium:395700
R=jam@chromium.org

Review URL: https://webrtc-codereview.appspot.com/30659004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7383 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-07 09:17:35 +00:00
henrike@webrtc.org
528fc650d8 Fixing build issue with L-sdk
Based on https://codereview.appspot.com/153000043/

BUG=https://code.google.com/p/chromium/issues/detail?id=420293
R=niklas.enbom@webrtc.org, serya@chromium.org, yfriedman@chromium.org

Review URL: https://webrtc-codereview.appspot.com/29659004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7374 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-06 17:56:43 +00:00
pbos@webrtc.org
42684be21b Wire up CPU adaptation in WebRtcVideoEngine2.
Includes clean-up work to be able to use the webrtc::Call::Config that's
set up. This introduced a CallFactory to spawn a FakeCall with the
config used and allowed removal of FakeWebRtcVideoChannel2.

BUG=1788
R=mflodman@webrtc.org, pthatcher@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/24779004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7370 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-03 11:25:45 +00:00
glaznev@webrtc.org
25cc745d6b Switch to SW video decoder on Android after getting 2 or more
critical errors from HW decoder.

BUG=410730
R=tkchin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/23819004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7368 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-02 16:58:05 +00:00
henrike@webrtc.org
4530b2ca48 Revert 7355 "Fix parallelization in libjingle_p2p_unittest."
Breaks waterfall.

TBR=pbos@webrtc.org
BUG=N/A

Review URL: https://webrtc-codereview.appspot.com/22909004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7357 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-01 15:43:55 +00:00
pbos@webrtc.org
fd29205e6e Fix parallelization in libjingle_p2p_unittest.
Adding VirtualSocketServers to SessionTest and RelayServerTest to avoid
contention on real ports.

R=juberti@webrtc.org
BUG=2597
TEST=third_party/gtest-parallel/gtest-parallel -w 64 out/Debug/libjingle_p2p_unittest

Review URL: https://webrtc-codereview.appspot.com/26679004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7355 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-01 12:31:31 +00:00
henrik.lundin@webrtc.org
4cebd84c79 Reland "Remove DTMF status methods from Voice Engine" r7276
This reverts r7277.

TBR=henrika@webrtc.org,pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/29599004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7353 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-01 08:23:21 +00:00
xians@webrtc.org
7aad5e5cce Revert 7338 "Fixed the android build by making the interface pur..."
> Fixed the android build by making the interface pure virtual.
> 
> TBR=asapersson@webrtc.org, bjornv@webrtc.org,
> 
> Review URL: https://webrtc-codereview.appspot.com/24789004

TBR=xians@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/30579004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7341 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-30 15:26:15 +00:00
xians@webrtc.org
90d1979d77 Fixed the android build by making the interface pure virtual.
TBR=asapersson@webrtc.org, bjornv@webrtc.org,

Review URL: https://webrtc-codereview.appspot.com/24789004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7338 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-30 15:15:22 +00:00
pbos@webrtc.org
1795c358fc Add default implementation of Add/RemoveObserver.
Needed to remove Add/RemoveObserver from RTCVideoEncoderFactory in
Chromium before removing these completely. This is done to keep the
chromium.webrtc.fyi bots happy and to make rolling webrtc revisions
easier.

R=stefan@webrtc.org
BUG=3876

Review URL: https://webrtc-codereview.appspot.com/23839004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7332 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-30 09:45:25 +00:00
kjellander@webrtc.org
8cad9432d5 Revert 7327 "Update isolate.gypi files + link to isolate_driver.py"
Breaks debug compilation (didn't run all trybots when testing this).

> Update isolate.gypi files + link to isolate_driver.py
> 
> This updates the isolate.gypi copies we're forced to
> maintain in our code repo to Chromium revision c264a05.
> 
> Since isolated testing is now using a new launch script
> in tools: isolate_driver.py, that is added to our links
> script.
> 
> BUG=395700
> TESTED=Ran one of our tests with:
> ninja -C out/Release tools_unittests_run
> tools/isolate_driver.py run --isolated out/Release/tools_unittests.isolated --isolate webrtc/tools/tools_unittests.isolate
> 
> R=henrika@webrtc.org, jam@chromium.org
> 
> Review URL: https://webrtc-codereview.appspot.com/26649004

TBR=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/31509004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7328 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-30 08:44:00 +00:00
kjellander@webrtc.org
02cd3067d2 Update isolate.gypi files + link to isolate_driver.py
This updates the isolate.gypi copies we're forced to
maintain in our code repo to Chromium revision c264a05.

Since isolated testing is now using a new launch script
in tools: isolate_driver.py, that is added to our links
script.

BUG=395700
TESTED=Ran one of our tests with:
ninja -C out/Release tools_unittests_run
tools/isolate_driver.py run --isolated out/Release/tools_unittests.isolated --isolate webrtc/tools/tools_unittests.isolate

R=henrika@webrtc.org, jam@chromium.org

Review URL: https://webrtc-codereview.appspot.com/26649004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7327 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-30 08:34:57 +00:00
glaznev@webrtc.org
359d720004 Allow Android apps to set video renderer scaling type.
Also add type check for EGL context object received from apps and
switch to byte buffer video decoding if EGL context is incorrect

BUG=3851
R=tkchin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/25669004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7326 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-29 23:07:08 +00:00
jiayl@webrtc.org
7dfb7fa189 Reland disallowing blocking calls on the worker thread.
This fixed the issue that invoking the call when the thread is not started.

BUG=3559
R=juberti@webrtc.org, thorcarpenter@google.com

Review URL: https://webrtc-codereview.appspot.com/24769004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7325 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-29 22:45:55 +00:00
asapersson@webrtc.org
626624061e Disable flaky tests:
JsepPeerConnectionP2PTestClient.ReceivedBweStatsCombined
JsepPeerConnectionP2PTestClient.ReceivedBweStatsNotCombined

BUG=3871
R=henrike@webrtc.org, kjellander@webrtc.org, pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/25709004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7323 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-29 14:30:07 +00:00
pbos@webrtc.org
34f2a9ea72 Initialize SSL in unittest_main.cc.
Instead of having each test individually initialize and tear down SSL
move this to unittest_main.cc so that all tests are properly
initialized and new tests "don't have to think about it".

R=pthatcher@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/30549004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7316 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-28 11:36:45 +00:00
jiayl@webrtc.org
bebc75e8bd Fix the duplicated candidate problem when using multiple STUN servers.
BUG=3723
R=pthatcher@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/26469004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7312 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-26 23:01:11 +00:00
thorcarpenter@google.com
a21d071607 Reverting part of
https://webrtc-codereview.appspot.com/15089004/diff/140001/talk/session/media/channelmanager.cc?context=10&column_width=80
because of a major regression hanging the executable on start.

R=jiayl@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/22799004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7309 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-26 17:19:14 +00:00
pbos@webrtc.org
05305116d6 Explicitly initialize SSL for tests.
Adding missing SSL initialization/cleanups in
TransportDescriptionFactoryTest and MediaSessionTest.

These being missing prevent these tests from being run individually
without other tests preceding them that initialize SSL.

BUG=3860
R=pthatcher@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/24739004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7300 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-25 15:50:26 +00:00
jiayl@webrtc.org
3987b6de50 Fix a problem in Thread::Send.
Previously if thread A->Send is called on thread B, B->ReceiveSends will be called, which enables an arbitrary thread to invoke calls on B while B is wait for A->Send to return. This caused mutliple problems like issue 3559, 3579.
The fix is to limit B->ReceiveSends to only process requests from A.
Also disallow the worker thread invoking other threads.

BUG=3559
R=juberti@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15089004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7290 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-24 17:14:05 +00:00
pbos@webrtc.org
d60d79a145 Thread annotation of rtc::CriticalSection.
Effectively re-lands r5516 which was reverted because talk/-only
checkouts existed. This now resides in webrtc/base/, so no talk/-only
checkouts should be possible.

This change also enables -Wthread-safety for talk/ and fixes a bug in
talk/media/webrtc/webrtcvideoengine2.cc where a guarded variable was
read without taking the corresponding lock.

R=andresp@webrtc.org, mflodman@webrtc.org, pthatcher@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/27569004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7284 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-24 07:10:57 +00:00
pbos@webrtc.org
38344ed280 Move thread_annotations.h to webrtc/base/.
R=andresp@webrtc.org, mflodman@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/27579004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7283 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-24 06:05:00 +00:00
glaznev@webrtc.org
8166faeff3 Change Android video renderer to maintain video aspect
ratio when displaying camera or decoded video frames.

-

R=tkchin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/30509004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7282 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-23 23:58:52 +00:00
glaznev@webrtc.org
90668b1633 Switch HW video decoder to output byte buffers if video
renderer EGL context is not provided by app.

R=tkchin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/24699004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7281 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-23 21:42:15 +00:00
buildbot@webrtc.org
1b7dcc1647 (Auto)update libjingle 76169599-> 76176062
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7280 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-23 17:41:48 +00:00
guoweis@webrtc.org
2c1bcea1bc Enable ipv6 by default for webrtc under a Finch experiment.
Reapply 23529005 after fixing the build break issue (Chromium:582133002)

Committed: https://code.google.com/p/webrtc/source/detail?r=7253

Review URL: https://webrtc-codereview.appspot.com/23529005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7278 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-23 16:23:02 +00:00
henrik.lundin@webrtc.org
3987f10c11 Revert "Remove DTMF status methods from Voice Engine" r7276
This change caused some trouble.

TBR=henrika@webrtc.org,pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/29569004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7277 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-23 13:15:14 +00:00
henrik.lundin@webrtc.org
bf7b9e0081 Remove DTMF status methods from Voice Engine
These methods are not used.

R=henrika@webrtc.org, pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/24689004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7276 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-23 12:54:04 +00:00
pbos@webrtc.org
0a2087a711 Skeleton for registering external encoders/decoders.
R=pthatcher@webrtc.org
BUG=1788

Review URL: https://webrtc-codereview.appspot.com/31429005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7270 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-23 09:40:22 +00:00
pbos@webrtc.org
83f95ba9a6 Remove engine-level SetOptions.
Already removed in WebRtcVideoEngine.

R=andresp@webrtc.org
BUG=1788

Review URL: https://webrtc-codereview.appspot.com/29549005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7265 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-22 16:07:18 +00:00
henrik.lundin@webrtc.org
64a2f10f4b Remove Get/SetNetEQPlayoutMode APIs
These are not used anymore.

R=henrika@webrtc.org, pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/26569004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7262 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-22 14:30:10 +00:00
guoweis@webrtc.org
97ed39344a Reapply 23529005 after fixing the build break issue (Chromium:582133002)
Review URL: https://webrtc-codereview.appspot.com/23529005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7253 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-19 21:06:12 +00:00
buildbot@webrtc.org
ed5ca1f122 (Auto)update libjingle 75925673-> 75926712
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7252 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-19 20:30:44 +00:00
buildbot@webrtc.org
c98f217c65 (Auto)update libjingle 75924589-> 75925673
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7251 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-19 20:18:10 +00:00
buildbot@webrtc.org
0c9fe72b21 (Auto)update libjingle 75922684-> 75924589
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7250 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-19 20:05:02 +00:00
glaznev@webrtc.org
ebf2757339 Fix HW video decoder crash on some Android KK devices.
Remove direct access to decoder Java output buffer memory
when HW decoder is configured to decode to surface.

-

R=tkchin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/30459005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7249 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-19 19:36:13 +00:00