Commit Graph

2870 Commits

Author SHA1 Message Date
henrik.lundin@webrtc.org
8552c71290 Fixing neteq_unittests for VS 2012
For Visual Studio versions older than 2012, we are using a
separate reference output file for windows. (All other platforms
share the same generic reference file.) In VS 2012, the output
matches the generic reference, and not the platform-specific one.

Since, the ResourcePath() method cannot change behavior depending
on compiler version, this fix will short-cut ResourcePath() for
VS 2012 or newer (_MSC_VER >= 1700).

Also made NetEqDecodingTest.TestBitExactnes stop on the first diff.
Once there is a difference, the output is no longer bit-exact, and
the test should be declared a failure.

BUG=
TEST=neteq_unittests on VS2012, try bots

Review URL: https://webrtc-codereview.appspot.com/966028

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3199 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-29 12:03:18 +00:00
phoglund@webrtc.org
34dab50bb4 Corrected .h path.
TBR=mflodman@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/972009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3198 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-29 10:20:18 +00:00
phoglund@webrtc.org
273ccad59d Fixed standard PSNR/SSIM test.
BUG=1103

Review URL: https://webrtc-codereview.appspot.com/971005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3197 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-29 10:08:16 +00:00
stefan@webrtc.org
bf41508807 Properly remove the bitrate observer when ViEEncoder is destructed.
BUG=1090

Review URL: https://webrtc-codereview.appspot.com/969013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3196 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-29 09:18:53 +00:00
fbarchard@google.com
662651ac95 Disable denoise filter for Arm, as it is not optimized enough yet.
BUG=https://code.google.com/p/chrome-os-partner/issues/detail?id=16318
TEST=none
Review URL: https://webrtc-codereview.appspot.com/968008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3195 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-29 09:01:21 +00:00
phoglund@webrtc.org
cde46fa5d2 Disabled some more flaky tests. Memcheck vie_auto_test should be very stable after this.
BUG=1152

Review URL: https://webrtc-codereview.appspot.com/964019

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3194 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-29 08:22:45 +00:00
henrik.lundin@webrtc.org
f826bb6fb2 Fixing a bug related to RCU in NetEQ
RCU was disabled due to that the RCU flag was overwritten with zero
in the packet buffer.

BUG=1156
TEST=trybots, neteq_unittests, audio_coding_module_test, audio_coding_unittests

Review URL: https://webrtc-codereview.appspot.com/969012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3193 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-29 07:32:38 +00:00
leozwang@webrtc.org
56a1c2cc20 Enable java soundcard impl as the default
BUG=None
TEST=trybots
Review URL: https://webrtc-codereview.appspot.com/974006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3192 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-29 03:13:00 +00:00
fischman@webrtc.org
de6f8fbd6d Revert 3190 - Enable building WebRTCDemo apk using Release webrtc libs.
Now passing BUILDTYPE=Release to both the make that builds the libs and the
ndk-build that builds the app makes the app use non-Debug libs.

TBR=leozwang@webrtc.org,

Review URL: https://webrtc-codereview.appspot.com/968010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3191 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-29 01:18:04 +00:00
fischman@webrtc.org
28afee04ae Enable building WebRTCDemo apk using Release webrtc libs.
Now passing BUILDTYPE=Release to both the make that builds the libs and the
ndk-build that builds the app makes the app use non-Debug libs.

Review URL: https://webrtc-codereview.appspot.com/972007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3190 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-29 01:09:44 +00:00
marpan@webrtc.org
f3cefe1104 Added metrics test code for the FEC packet masks.
The test computes metrics (average residual loss) for each mask type and size, 
for a given set of loss models (random and bursty), and verifies various 
behaviour of the codes (including relation/comparison to RS code).

http://webrtc-codereview.appspot.com/748008
TBR=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/929034

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3189 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 23:27:34 +00:00
marpan@webrtc.org
c09e779766 Allow for 1 layer case to be set in temporal_layers.
Review URL: https://webrtc-codereview.appspot.com/971007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3188 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 22:06:21 +00:00
henrike@webrtc.org
7d5dacc985 Revert 3183 - Fixes two bugs related to padding in the jitter buffer.
- Pad packets (empty) were often NACKed even though they were received.
- Padding only frames (empty) were didn't properly update the decoding state,
  and would therefore be NACKed even though they were received.

http://webrtc-cb-linux-master.cbf.corp.google.com:8010/builders/Win32Release/builds/1704/steps/video_coding_unittests/logs/stdio

TEST=trybots

BUG=1150

Review URL: https://webrtc-codereview.appspot.com/929031

TBR=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/971010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3187 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 22:04:45 +00:00
marpan@webrtc.org
c244cefe1d Reverting r3185
TBR=marpan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/933029

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3186 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 21:00:36 +00:00
marpan@webrtc.org
993494764d Added metrics test code for the FEC packet masks.
The test computes metrics (average residual loss) for each mask type and size, 
for a given set of loss models (random and bursty), and verifies various 
behaviour of the codes (including relation/comparison to RS code).
Review URL: https://webrtc-codereview.appspot.com/748008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3185 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 19:43:58 +00:00
leozwang@webrtc.org
aa46ea0b8b Remove ringtone from test app
BUG=None
TEST=trybots
Review URL: https://webrtc-codereview.appspot.com/968009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3184 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 19:39:23 +00:00
stefan@webrtc.org
e4fb44c29d Fixes two bugs related to padding in the jitter buffer.
- Pad packets (empty) were often NACKed even though they were received.
- Padding only frames (empty) were didn't properly update the decoding state,
  and would therefore be NACKed even though they were received.

TEST=trybots

BUG=1150

Review URL: https://webrtc-codereview.appspot.com/929031

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3183 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 19:36:20 +00:00
henrike@webrtc.org
891d55eb35 Revert 3181 - Fixes two bugs related to padding in the jitter buffer.
- Pad packets (empty) were often NACKed even though they were received.
- Padding only frames (empty) didn't properly update the decoding state,
  and would therefore be NACKed even though they were received.

Broke [Builder Win32Debug] (http://webrtc-cb-linux-master.cbf.corp.google.com:8010/builders/Win32Debug/builds/1728)

TEST=trybots

BUG=1150

Review URL: https://webrtc-codereview.appspot.com/966026

TBR=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/939031

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3182 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 17:45:01 +00:00
stefan@webrtc.org
d42e51ce7c Fixes two bugs related to padding in the jitter buffer.
- Pad packets (empty) were often NACKed even though they were received.
- Padding only frames (empty) didn't properly update the decoding state,
  and would therefore be NACKed even though they were received.

TEST=trybots

BUG=1150

Review URL: https://webrtc-codereview.appspot.com/966026

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3181 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 16:40:28 +00:00
phoglund@webrtc.org
0f8286fd75 Added last (?) suppressions for known issues.
BUG=1152

Review URL: https://webrtc-codereview.appspot.com/933027

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3180 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 14:21:12 +00:00
phoglund@webrtc.org
7d74bdbeac Added conformance tests.
BUG=

Review URL: https://webrtc-codereview.appspot.com/929030

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3179 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 13:03:17 +00:00
phoglund@webrtc.org
8d334d387b Disabled flaky test on Linux, added disable-on-platform macros, fixed \n's
BUG=1155

Review URL: https://webrtc-codereview.appspot.com/972006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3178 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 12:28:06 +00:00
tina.legrand@webrtc.org
c4590580e8 Opus mono/stereo on the same payloadtype, and fix of memory bug
During call setup Opus should always be signaled as a 48000 Hz stereo codec, not depending on what we plan to send, or how we plan to decode received packets.
The previous implementation had different payload types for mono and stereo, which breaks the proposed standard.

While working on this CL I ran in to the problem reported earlier, that we could get a crash related to deleting decoder memory. This should now be solved in Patch Set 3.

BUG=issue1013, issue1112

Review URL: https://webrtc-codereview.appspot.com/933022

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3177 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 12:23:29 +00:00
kjellander@webrtc.org
81fb7bfd8b Adding video_coding_integrationtests test.
These changes makes it possible to run this tool with some gtest additions in an automated manner on the buildbots.

This test was previously known as video_coding_test, which is an
integration test that is mostly used as a development tool.

Parts of this test should be extracted and kept as a separate
development tool, but that's something for a future CL.

I also refactored the old command line parsing to use gflags instead.

Previous code from the following tests were merged into
video_coding_integrationtests and video_coding_unittests:
* video_codecs_test_framework_integrationtests
* video_codecs_test_framework_unittests
So these targets are now gone.

BUG=none
TEST=trybots passing + Executing video_coding_integrationtests on Linux, Mac and Windows since it's not currently added to the trybots. I ran with a couple of different combinations of settings.

Review URL: https://webrtc-codereview.appspot.com/933026

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3176 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 08:40:16 +00:00
mikhal@webrtc.org
8049608226 VP8 wrapper: updating raw image allocation.
As we set the pointers to the data, there is no need to allocate that memory.

Review URL: https://webrtc-codereview.appspot.com/964021

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3175 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-27 17:06:10 +00:00
brykt@google.com
4de3dfe613 Tool for editing of yuv-files. Specify a path to the clip that should be edited, the height and width of the clip, one set of frames that should be removed from the clip, and a path to where the result should be written. There is a executable created that make use of the library where the functionality is implemented. There is also a unittest added for the library.
BUG=

Review URL: https://webrtc-codereview.appspot.com/929021

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3174 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-27 13:44:07 +00:00
kjellander@webrtc.org
52ec985d82 Fixing vie and voe auto test project paths for test execution.
By letting fileutils.h know the path to the executable, the tests will be able to find the project root dir and resource file paths even when the test is executed outside the checkout dir.

See http://review.webrtc.org/858014/ for more background.

Today, these tests are failing in the FYI waterfall since they are run "Chromium style" (i.e. from one level above the checkout dir). Since we're moving in that direction this needs to be fixed. It has been fixed for all other tests already.

TEST=Local test execution of vie_auto_test and voe_auto_test with CWD one level above trunk/

Review URL: https://webrtc-codereview.appspot.com/974004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3173 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-27 10:01:01 +00:00
andrew@webrtc.org
b43502e388 Revert 3170 - Added performance benchmarking in APM and iSAC-fix for Buildbots.
Review URL: https://webrtc-codereview.appspot.com/929022

TBR=kma@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/969009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3172 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-26 23:57:38 +00:00
kma@webrtc.org
4cd8f1f182 Added performance benchmarking in APM and iSAC-fix for Buildbots.
Review URL: https://webrtc-codereview.appspot.com/929022

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3170 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-26 22:02:47 +00:00
elham@webrtc.org
6e46d5b1c1 Updated version number to 3.18
Review URL: https://webrtc-codereview.appspot.com/930027

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3166 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-26 17:08:34 +00:00
kjellander@webrtc.org
107d4efd11 Rolling chromium_revision 157509:169394
This gives us, among other things:
* updated gtest that compiles with Visual Studio 2012
* newer build tools
* newer Clang compiler.

BUG=none
TEST=all trybots passing.

Review URL: https://webrtc-codereview.appspot.com/973004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3165 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-26 16:31:20 +00:00
phoglund@webrtc.org
ef90c3227e Will now correctly identify the first-ever received packet as the first packet in its frame.
We used to flag the _second_ packet in the first frame as the first. Subsequent frames worked as intended.

BUG=1103
TEST=vie_auto_test --automated, rtp_rtcp_unittests

Review URL: https://webrtc-codereview.appspot.com/964020

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3164 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-26 16:30:40 +00:00
mflodman@webrtc.org
7c894b7cc7 Wire up CallStats to provide modules with correct RTT.
BUG=769
TEST=Manual test since there is no ViE APi to get RTT for receive channels.

Review URL: https://webrtc-codereview.appspot.com/937027

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3163 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-26 12:40:15 +00:00
henrika@webrtc.org
5ba3decc94 Ensures that we can build using VS 2012 on Windows.
See more details at https://code.google.com/p/webrtc/issues/detail?id=1146&

TBR=Niklas
BUG=1146

Review URL: https://webrtc-codereview.appspot.com/939028

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3162 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-26 09:12:02 +00:00
tina.legrand@webrtc.org
221b11af22 Pulling Opus version 1.0.1 from Chromium
BUG=issue1055

Review URL: https://webrtc-codereview.appspot.com/933024

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3161 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-26 08:20:44 +00:00
andrew@webrtc.org
c3e5d3422b Add a logging_no_op.cc when enable_tracing==0.
This should hopefully fix static initializer warnings when rolling webrtc
in Chromium.

TEST=logging_unittest succeeds with enable_tracing==1 and fails appropriately with enable_tracing==0.

Review URL: https://webrtc-codereview.appspot.com/939026

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3159 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-23 19:30:59 +00:00
andrew@webrtc.org
418443c531 Remove operator overloading from RTPFragmentationHeader.
Instead supply a CopyFrom() method.

TEST=vie_auto_test

Review URL: https://webrtc-codereview.appspot.com/972004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3158 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-23 19:17:23 +00:00
stefan@webrtc.org
ad7f1fefad Fixes (or at least reduces) the flakiness in the full stack test by making sure the different frame monitors are registered and deregistered in the right order. Also makes sure only local preview frames which are actually transmitted are rendered by moving the local preview rendering to an effect filter.
BUG=

Review URL: https://webrtc-codereview.appspot.com/969005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3157 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-23 11:19:29 +00:00
kjellander@webrtc.org
6ba79a88e5 Condition for DirectX variable on Windows
The directx_sdk_path GYP variable got the value $(DXSDK_DIR) on non-windows platforms which is normally an uninitialized environment variable, causing an error during GYP generation.
Putting this include within a condition for Windows resolves this.

This was only triggered when GYP_GENERATORS=ninja and not for the default on Linux (make), so the bots haven't noticed this.

BUG=none
TEST=All default trybots passing. Successfully generating projects on Linux and Mac for make and ninja (plus XCode on Mac). Successful compile on Windows without DirectX SDK installed (but with files located in third_party/directxsdk/files).

Review URL: https://webrtc-codereview.appspot.com/936031

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3156 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-23 09:41:42 +00:00
phoglund@webrtc.org
849fb8ebd2 Removed codec comparison test: it didn't work and probably never will.
The central problem is that we cannot sync the frames in the input video with the output video, which makes PSNR/SSIM go crazy. The test only appeared to succeed earlier due to a bug in the test. We can consider this a failed experiment, but we did learn a lot from it :)

BUG=550

Review URL: https://webrtc-codereview.appspot.com/969006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3155 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-23 09:21:44 +00:00
phoglund@webrtc.org
e3b2bc6c40 Will now fix old src-relative paths so we go to webrtc/ paths.
We used to write paths relative to src, e.g. starting with video_engine/ etc, but now it should be webrtc/video_engine/. This script will now get that right.

BUG=

Review URL: https://webrtc-codereview.appspot.com/970006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3154 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-23 09:09:59 +00:00
kjellander@webrtc.org
97dcf36a7b Adding Direct X SDK include directory.
This makes it possible to keep a copy of the Direct X SDK in third_party/directxsdk/files and get it automatically used instead of having to install it manually on the system.

BUG=none
TEST=Compilation with SDK files in third_party/directxsdk/files  and uninstalled Direct X SDK on Windows.
Review URL: https://webrtc-codereview.appspot.com/937028

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3153 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-23 08:54:07 +00:00
mflodman@webrtc.org
087723bc4d Updated license path in LICENSE and LICENSE_THIRD_PARTY.
Review URL: https://webrtc-codereview.appspot.com/939025

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3152 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-22 12:06:21 +00:00
mflodman@webrtc.org
f89fb9dbf0 Remove ViE lint warnings that should have been caught at upload time.
TEST=cpplint.py video_engine/*

Review URL: https://webrtc-codereview.appspot.com/964018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3151 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-22 09:41:42 +00:00
mflodman@webrtc.org
1c61196095 Removed not used include.
TEST=Compiles.

Review URL: https://webrtc-codereview.appspot.com/966025

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3150 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-22 09:37:27 +00:00
andrew@webrtc.org
6e76ef430d Add third_party/winsdk_samples/src to gitignore.
TBR=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/929026

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3149 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-21 23:28:40 +00:00
mikhal@webrtc.org
4c4d01dd3d Setting capture stride to width
Review URL: https://webrtc-codereview.appspot.com/935021

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3148 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-21 22:18:32 +00:00
andrew@webrtc.org
4b97793f91 Ensure opus_demo has a targets block.
TBR=leozwang@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/933023

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3147 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-21 20:16:53 +00:00
andrew@webrtc.org
8cd18c55b8 Add winsdk_samples to provide directshow_baseclasses.
Builds locally on Windows (and passes try), and a gyp run succeeds with
include_internal_video_capture=0. This should ensure it won't impact
Chromium.

Review URL: https://webrtc-codereview.appspot.com/937026

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3146 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-21 18:46:45 +00:00
leozwang@webrtc.org
cfcadab8d4 Build opus_demo
BUG=1082
TEST=trybots

With this cl we can build opus_demo.
Review URL: https://webrtc-codereview.appspot.com/936029

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3144 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-21 18:13:46 +00:00