generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
8,726 Commits 1 Branch 0 Tags
Commit Graph

6 Commits

Author SHA1 Message Date
Henrik Kjellander
57e5fd2e60 PRESUBMIT: Improve PyLint check and add GN format check. 
Add pylintrc file based on
https://code.google.com/p/chromium/codesearch#chromium/src/tools/perf/pylintrc
bit tightened up quite a bit (the one in depot_tools is far
more relaxed).

Remove a few excluded directories from pylint check and fixed/
suppressed all warnings generated.

Add GN format check + formatted all GN files using 'gn format'.
Cleanup redundant rules in tools/PRESUBMIT.py

TESTED=Ran 'git cl presubmit -vv', fixed the PyLint violations.
Ran it again with a modification in webrtc/build/webrtc.gni, formatted
all the GN files and ran it again.

R=henrika@webrtc.org, phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/50069004

Cr-Commit-Position: refs/heads/master@{#9274}
 2015-05-25 10:55:50 +00:00
jansson@webrtc.org
0ef22c24c0 Fixed style according to reviewer and a refactoring error 
I had to create this CL due to comitting before the final comments in the last CL
http://review.webrtc.org/1157005/ in revision:
https://code.google.com/p/webrtc/source/detail?r=3642

Changed e.msg to e.fail_msg in logging.error in emulate.py

Added space to error message for windows in check_permissions() in network_emulator

BUG=none
TEST=Windows and linux
Review URL: https://webrtc-codereview.appspot.com/1167006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3646 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-03-11 14:52:56 +00:00
jansson@webrtc.org
5d3ced5df0 Fixed sync issues in network emulator script + fix lint complaints 
Somehow a merge conflict was committed when I submitted
http://review.webrtc.org/1158006/ which resulted in
https://code.google.com/p/webrtc/source/detail?r=3639

Changed _run_ipfw_command from a method to a function to satisfy lint in network_emulator.py, removed "self." on the function calls.

Renamed msg to fail_msg in the _run_ipfw_command and __init__ to make it more clear that it contains a failure message.
Review URL: https://webrtc-codereview.appspot.com/1157005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3642 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-03-08 13:43:36 +00:00
jansson@webrtc.org
755e19adfc - Checks the OS and runs the appropriate commands for Dummynet (ipfw) 
- Added pipe rule flush handling
- Also fixed a bug preventing any rule settings other than default from being 
  used no matter what preset was chosen
- Fixed some comments.

BUGS=none
TEST= Windows and linux
Review URL: https://webrtc-codereview.appspot.com/1158006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3639 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-03-08 10:50:14 +00:00
phoglund@webrtc.org
5d37139374 Fixed a ton of Python lint errors, enabled python lint checking. 
BUG=

Review URL: https://webrtc-codereview.appspot.com/1166004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3627 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-03-07 09:59:43 +00:00
kjellander@webrtc.org
29c5a2335c Renamed to Network Emulator and improved error handling. 
Changed default start port of the port-range to 32768.

BUG=None
TEST=Tested locally.

Review URL: https://webrtc-codereview.appspot.com/627004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2338 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-06-01 08:42:17 +00:00