Commit Graph

3452 Commits

Author SHA1 Message Date
henrike@webrtc.org
728b7ea245 Tool found: pass by value when pass by reference is better in system wrapper unit test.
BUG=N/A

Review URL: https://webrtc-codereview.appspot.com/1186006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3662 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-12 21:49:56 +00:00
kma@webrtc.org
d6cd64ac6a Change intrinsic code in isac fix to let it pass chrome clang compiler.
Compiler complains about variables not initialized in instructions veor_s32() and vset_lane_s32().
Review URL: https://webrtc-codereview.appspot.com/1187006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3660 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-12 17:45:41 +00:00
henrike@webrtc.org
23875c1694 Fixes issue detected by tool.
BUG=N/A

Review URL: https://webrtc-codereview.appspot.com/1189004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3659 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-12 17:36:54 +00:00
phoglund@webrtc.org
6ddb9071a1 Corrected dashboard script error.
BUG=

Review URL: https://webrtc-codereview.appspot.com/1187004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3657 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-12 13:16:51 +00:00
stefan@webrtc.org
03e3117d87 Removed redundant VP8 width/height and made sure the generic width/height is set.
Review URL: https://webrtc-codereview.appspot.com/1158005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3656 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-12 09:59:27 +00:00
dwkang@webrtc.org
7473f89f63 Revert "Internal clean up: removing unused include line."
(reverting https://webrtc-codereview.appspot.com/1177004)

BUG=none

Review URL: https://webrtc-codereview.appspot.com/1181005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3655 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-12 01:43:00 +00:00
dwkang@webrtc.org
25316b2a09 Internal clean up: removing unused include line.
BUG=none
TESTED=passed try server

Review URL: https://webrtc-codereview.appspot.com/1177004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3654 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-12 01:10:02 +00:00
kma@webrtc.org
e5a81ed793 Fixed issue 1497 in iSAC fixed point.
Bit exact.
Review URL: https://webrtc-codereview.appspot.com/1177005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3653 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-12 00:23:21 +00:00
vikasmarwaha@webrtc.org
da0f7086e1 Update demos to have local audio control muted by default.
Review URL: https://webrtc-codereview.appspot.com/1160007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3649 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-11 16:58:07 +00:00
kjellander@webrtc.org
3de314615f Fix frame_editing_unittest reference file handling.
This test was initializing strings for reference video files in a static
context, which makes is against the style guide and also makes the paths
become invalid when the test is launched from a working directory
outside the checkout.

Moving the initialization into the test fixture solves this.

BUG=none
TEST=Local execution launched from a directory outside the checkout tree on Win, Mac and Linux + trybots (for
compilation as they don't yet run the tools_unittests).

Review URL: https://webrtc-codereview.appspot.com/1178004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3647 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-11 15:30:33 +00:00
jansson@webrtc.org
0ef22c24c0 Fixed style according to reviewer and a refactoring error
I had to create this CL due to comitting before the final comments in the last CL
http://review.webrtc.org/1157005/ in revision:
https://code.google.com/p/webrtc/source/detail?r=3642

Changed e.msg to e.fail_msg in logging.error in emulate.py

Added space to error message for windows in check_permissions() in network_emulator

BUG=none
TEST=Windows and linux
Review URL: https://webrtc-codereview.appspot.com/1167006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3646 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-11 14:52:56 +00:00
kjellander@webrtc.org
db8ca9a395 Add Mac 64 bit bots to LKGR parser.
BUG=1394
TEST=none

Review URL: https://webrtc-codereview.appspot.com/1174004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3645 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-11 09:00:37 +00:00
fischman@webrtc.org
a33037ea6c Added an android_channel.html reflector page to allow Android apps to use a
WebView to speak the Channel API from Google AppEngine.

BUG=webrtc:1169

Review URL: https://webrtc-codereview.appspot.com/1145006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3644 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-10 18:28:08 +00:00
kma@webrtc.org
23da8622c0 Optimized EstCodeLpcCoef() for iSAC with intrinsics in Android-Neon platform.
Cycles of the whole iSAC codec was reduced by 7.9%, measured by offline file test, with time() function.

Bit exact.

** Code style cleanup is not considered in this CL. **
Review URL: https://webrtc-codereview.appspot.com/1069004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3643 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-09 00:38:14 +00:00
jansson@webrtc.org
5d3ced5df0 Fixed sync issues in network emulator script + fix lint complaints
Somehow a merge conflict was committed when I submitted
http://review.webrtc.org/1158006/ which resulted in
https://code.google.com/p/webrtc/source/detail?r=3639

Changed _run_ipfw_command from a method to a function to satisfy lint in network_emulator.py, removed "self." on the function calls.

Renamed msg to fail_msg in the _run_ipfw_command and __init__ to make it more clear that it contains a failure message.
Review URL: https://webrtc-codereview.appspot.com/1157005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3642 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-08 13:43:36 +00:00
pbos@webrtc.org
927296fd1b Lazy capture_device_info acquisition.
BUG=1484

Review URL: https://webrtc-codereview.appspot.com/1169005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3641 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-08 13:12:29 +00:00
kjellander@webrtc.org
38ebf98c2a Refactor barcode decoder to use Zxing's C++ version
By using the C++ version of Zxing, we can avoid having Java and Ant
as a dependency when running Video quality analysis on the bots.
This makes it far more easy to setup automation on new machines.

I also moved the scripts into the webrtc/ folder so it will be synced by default when building in Chrome (eliminating the need of a separate solution).

This CL also removes the need of the FFMPEG_HOME variable and replaces
its use with a command line flag to make the tool run smoothly on
Windows.

BUG=none
TEST=locally running the script on Windows, Mac and Linux.

Review URL: https://webrtc-codereview.appspot.com/1099007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3640 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-08 10:58:21 +00:00
jansson@webrtc.org
755e19adfc - Checks the OS and runs the appropriate commands for Dummynet (ipfw)
- Added pipe rule flush handling
- Also fixed a bug preventing any rule settings other than default from being 
  used no matter what preset was chosen
- Fixed some comments.

BUGS=none
TEST= Windows and linux
Review URL: https://webrtc-codereview.appspot.com/1158006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3639 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-08 10:50:14 +00:00
kjellander@webrtc.org
971278a962 Splitting out video_coding_test executable again.
This CL undoes the merge of the developer test tool and the gtest tests
that was merged in https://code.google.com/p/webrtc/source/detail?r=3176

Doing that, we get a pure gtest executable of
video_coding_integrationtests which can run properly on the bots.

BUG=none
TEST=Trybots passing + local execution on Linux with:
out/Debug/video_coding_integrationtests --gtest_print_time (to ensure it will be possible to run with runtest.py)

Review URL: https://webrtc-codereview.appspot.com/1171007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3638 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-08 10:20:53 +00:00
wu@webrtc.org
3137a21068 Dtmf twinkle-twinkle.
BUG=

Review URL: https://webrtc-codereview.appspot.com/1160005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3635 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-07 21:59:23 +00:00
andrew@webrtc.org
df123ed604 Roll libvpx 180104:186754.
Picks up the ability to disable VP9 through gyp.

Review URL: https://webrtc-codereview.appspot.com/1162009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3633 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-07 21:27:41 +00:00
kjellander@webrtc.org
603a7f47a4 Add third_party/ dependencies to svn:ignore
Adding the following directories to be ignored by SVN:
third_party/android_testrunner
third_party/android_tools
third_party/WebKit
This will speed up gclient sync/revert operations for the bots.



git-svn-id: http://webrtc.googlecode.com/svn/trunk@3632 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-07 20:31:45 +00:00
kma@webrtc.org
2951a6df4a Fixed an assembly code error in AECM for ARMv7.
Possibly related to an AECM quality issue encountered at Chrome testing.
No bug was logged.
Review URL: https://webrtc-codereview.appspot.com/1160006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3631 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-07 18:25:34 +00:00
stefan@webrtc.org
84cd8e39cf Disable frame dropper for screenshare mode.
BUG=1466

Review URL: https://webrtc-codereview.appspot.com/1170004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3629 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-07 13:12:32 +00:00
stefan@webrtc.org
7c16c3c4a1 Move video_coding OWNERS to video_coding/.
TBR=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1171004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3628 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-07 13:11:32 +00:00
phoglund@webrtc.org
5d37139374 Fixed a ton of Python lint errors, enabled python lint checking.
BUG=

Review URL: https://webrtc-codereview.appspot.com/1166004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3627 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-07 09:59:43 +00:00
andrew@webrtc.org
52b57cc0d5 Fix debug file buffer bug introduced in r3574.
This correctly uses int16_t rather than float. Only affects the debug
file buffer, not the production code path.

TBR=bjornv

Review URL: https://webrtc-codereview.appspot.com/1162008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3626 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-07 00:45:50 +00:00
mikhal@webrtc.org
efe4edb6da Enabling bufffering mode with no sync module or VoE
BUG= 1454

Review URL: https://webrtc-codereview.appspot.com/1149006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3625 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-06 23:29:33 +00:00
braveyao@webrtc.org
488d4c9493 Submit symlink in apprtc from Linux since it fails from Win
Review URL: https://webrtc-codereview.appspot.com/1169004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3622 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-06 06:45:14 +00:00
braveyao@webrtc.org
07db4a6918 Add symlink of adapter.js from apprtc to base
Review URL: https://webrtc-codereview.appspot.com/1160004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3621 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-06 03:35:03 +00:00
andrew@webrtc.org
a9a1df0035 Remove the error return on SetAGC failure introduced by r3605.
BUG=webrtc:1464

Review URL: https://webrtc-codereview.appspot.com/1166005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3616 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-05 23:36:10 +00:00
fbarchard@google.com
64dc671167 Roll libyuv to r590
BUG=none
TEST=try bots
Review URL: https://webrtc-codereview.appspot.com/1161004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3615 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-05 21:02:33 +00:00
elham@webrtc.org
90eb5c84f9 1. Updated test pages to include Chrome Frame meta tag
2. Updated test pages to use adapter.js
Review URL: https://webrtc-codereview.appspot.com/1142004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3614 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-05 19:53:01 +00:00
bjornv@webrtc.org
91d11b3cdd Adds new AEC API to audio_processing.
One unit test added.
Tested with audioproc_unittest and trybots

TEST=none
BUG=none

Review URL: https://webrtc-codereview.appspot.com/1154004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3613 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-05 16:53:09 +00:00
hta@webrtc.org
db3f42782c Using adapter.js and getRemoteStreams
Needed to make the stats demo work on M26.

BUG=

Review URL: https://webrtc-codereview.appspot.com/1165004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3612 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-05 15:23:40 +00:00
stefan@webrtc.org
1dc0aa2de2 Fix for build error on android introduced with r3609.
TBR=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1164004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3611 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-05 09:30:47 +00:00
stefan@webrtc.org
a27107004d Split the NACK list into multiple RTCPs if it's too big.
TEST=rtp_rtcp_unittests
BUG=1434

Review URL: https://webrtc-codereview.appspot.com/1148006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3609 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-05 09:02:06 +00:00
vikasmarwaha@webrtc.org
a856db26a6 Moved trace function to adapter.js and removed from pc1 & multiple.html.
Review URL: https://webrtc-codereview.appspot.com/1156005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3608 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-05 03:35:26 +00:00
turaj@webrtc.org
24045c5a02 None of the clients of VoE use SetNetEQBGNMode(), furthermore, NetEq 4 does not provide an API to change the mode of the background noise.
bug=issue1370
test=trybots
Review URL: https://webrtc-codereview.appspot.com/1121007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3607 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-05 03:14:22 +00:00
vikasmarwaha@webrtc.org
7881b574dd Updated path of adapter.js for dtmf & pc1-audio demos.
TBR = wu@webrtc.org,juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1151005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3606 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-05 02:04:07 +00:00
andrew@webrtc.org
f0a90c37c4 Expose the capture-side AudioProcessing object and allow it to be injected.
* Clean up the configuration code, including removing most of the weird defines.
* Add a unit test.

Review URL: https://webrtc-codereview.appspot.com/1152005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3605 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-05 01:12:49 +00:00
bjornv@webrtc.org
7f95732fe2 AEC Refactoring: Removes lint warning
Changed inlude order.

TBR=andrew@webrtc.org
TEST=none
BUG=none

Review URL: https://webrtc-codereview.appspot.com/1156004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3604 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-04 23:47:39 +00:00
vikasmarwaha@webrtc.org
99f13464df Typo in index.html and updated svn propset for dtmf & pc1-audio demos.
Review URL: https://webrtc-codereview.appspot.com/1145007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3603 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-04 19:34:46 +00:00
vikasmarwaha@webrtc.org
b203540e25 Redirect webrtc-demos.appspot.com to svn site and added dtmf & pc1-audio demos. Also updated index page to include information about new demos.
Review URL: https://webrtc-codereview.appspot.com/1148004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3602 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-04 18:57:09 +00:00
elham@webrtc.org
ec6226eedc Updated version number to 3.25
Review URL: https://webrtc-codereview.appspot.com/1149005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3600 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-04 18:05:56 +00:00
stefan@webrtc.org
a64300af50 Refactor NACK list creation to build the NACK list as packets arrive.
Also fixes a timer bug related to NACKing in the RTP module which could cause packets to only be NACKed twice if there's frequent packet losses.

Note that I decided to remove any selective NACKing for now as I don't think the gain of doing it is big enough compared to the added complexity. The same reasoning for empty packets. None of them will be retransmitted by a smart sender since the sender would know that they aren't needed.

BUG=1420
TEST=video_coding_unittests, vie_auto_test, video_coding_integrationtests, trybots

Review URL: https://webrtc-codereview.appspot.com/1115006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3599 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-04 15:24:40 +00:00
phoglund@webrtc.org
17b867ae00 compile fix for get_nprocs() with uClibc
BUG=

Review URL: https://webrtc-codereview.appspot.com/1150006
Patch from Mostyn Bramley-Moore <mostynb@opera.com>.

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3598 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-04 15:09:03 +00:00
phoglund@webrtc.org
44f85a49d8 Fixed coverity defects (CID 14657 and 14656).
BUG=

Review URL: https://webrtc-codereview.appspot.com/1153006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3597 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-04 14:59:31 +00:00
fischman@webrtc.org
73ec386d8a VideoCaptureAndroid can now capture just buffers without also rendering to a SurfaceView.
This saves ~15% CPU on a Nexus 7 running AppRTCDemo.

BUG=1169

Review URL: https://webrtc-codereview.appspot.com/1150005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3596 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-03 17:28:03 +00:00
andrew@webrtc.org
2412085bc1 Don't upsample the capture signal early.
* Remove the unneeded _mixingFrequency.
* Rename CheckForSendCodecChanges to better elucidate its function.
* Remove an unnecessary memcpy.

Upsampling should be done late in the chain. This is practically relevant
on mobile, where the capture rate is fixed at 16 kHz. When using Opus, the
signal was upsampled to 32 kHz and was no longer compatible with AECM, which only supports up to 16 kHz.

NEEDS_QA=true
TEST=run calls with a variety of capture device rates and codecs
BUG=chromium:178040,webrtc:1446

Review URL: https://webrtc-codereview.appspot.com/1146004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3594 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-02 00:14:46 +00:00