minyue@webrtc.org
0b62672576
adding default rates
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7562 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-30 07:19:49 +00:00
pbos@webrtc.org
776e6f289c
Use external VideoDecoders in VideoReceiveStream.
...
Removes direct VideoCodec use from the new API, exposes VideoDecoders
through webrtc/video_decoder.h similar to VideoEncoders.
Also includes some preparation for wiring up external decoders in
WebRtcVideoEngine2 by adding AllocatedDecoders that specify whether they
were allocated internally or externally.
Additionally addresses a data race in VideoReceiver that was exposed with this change.
R=mflodman@webrtc.org , stefan@webrtc.org
TBR=pthatcher@webrtc.org
BUG=2854,1667
Review URL: https://webrtc-codereview.appspot.com/27829004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7560 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-29 15:28:39 +00:00
buildbot@webrtc.org
1abc146aa5
(Auto)update libjingle 78738075-> 78738103
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7554 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-29 08:14:14 +00:00
minyue@webrtc.org
2623695dfb
Renaming bandwidth to bitrate in webrtcvoiceengine.
...
"bandwidth" is usually a misleading mentioning. It can mean network throughput, audio frequency contents, etc.
This is to remove the confusion inside webrtcvoiceengine
BUG=
R=juberti@webrtc.org , pbos@webrtc.org , tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/28799004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7551 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-29 02:27:08 +00:00
henrike@webrtc.org
269fb4bc90
move xmpp and p2p to webrtc
...
Create a copy of talk/xmpp and talk/p2p under webrtc/libjingle/xmpp and
webrtc/p2p. Also makes libjingle use those version instead of the one in the talk folder.
BUG=3379
Review URL: https://webrtc-codereview.appspot.com/26999004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7549 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-28 22:20:11 +00:00
buildbot@webrtc.org
ae694effd8
(Auto)update libjingle 78642371-> 78680406
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7545 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-28 17:37:17 +00:00
buildbot@webrtc.org
fbd55cb27d
(Auto)update libjingle 78616359-> 78642371
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7540 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-28 05:35:35 +00:00
buildbot@webrtc.org
068b529f46
(Auto)update libjingle 78583324-> 78583691
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7532 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-27 16:20:42 +00:00
pbos@webrtc.org
efc82c2c73
Implement screencast settings for WebRtcVideoEngine2.
...
Adds support for screencast_min_bitrate and sets content type
corresponding to the capture type.
R=stefan@webrtc.org
BUG=1788
Review URL: https://webrtc-codereview.appspot.com/29959004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7529 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-27 13:58:00 +00:00
buildbot@webrtc.org
3f7bcc126d
(Auto)update libjingle 78430441-> 78445452
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7522 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-24 17:26:28 +00:00
buildbot@webrtc.org
c7ed8db7fd
(Auto)update libjingle 78427027-> 78430441
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7521 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-24 12:59:08 +00:00
buildbot@webrtc.org
8fe75ee234
(Auto)update libjingle 78381351-> 78389679
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7516 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-23 23:07:23 +00:00
buildbot@webrtc.org
fb5e9fc44e
(Auto)update libjingle 78344087-> 78381351
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7515 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-23 21:36:17 +00:00
buildbot@webrtc.org
9d446f2e16
(Auto)update libjingle 78296920-> 78342456
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7507 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-23 12:22:06 +00:00
buildbot@webrtc.org
a9f0898e7d
(Auto)update libjingle 78273470-> 78296920
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7501 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-22 22:02:00 +00:00
buildbot@webrtc.org
fb5410a8b7
(Auto)update libjingle 78262388-> 78262615
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7496 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-22 15:45:17 +00:00
pbos@webrtc.org
eacc6e4657
Remove some disabled tests in WebRtcVideoEngine2.
...
Removes some tests that shouldn't have to be implemented or have already
been through other tests.
R=stefan@webrtc.org
BUG=1788
Review URL: https://webrtc-codereview.appspot.com/25929004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7495 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-22 15:36:54 +00:00
buildbot@webrtc.org
a5c36b397a
(Auto)update libjingle 78193292-> 78199328
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7485 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-21 20:44:16 +00:00
buildbot@webrtc.org
1288cbb704
(Auto)update libjingle 78106439-> 78193292
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7482 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-21 19:29:16 +00:00
pbos@webrtc.org
fa553ef605
Set up start bitrate in WebRtcVideoEngine2.
...
R=stefan@webrtc.org
BUG=1788
Review URL: https://webrtc-codereview.appspot.com/27789004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7476 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-20 11:07:07 +00:00
henrike@webrtc.org
28100cb388
Reverts r7459 "Create a copy of talk/xmpp and talk/p2p under webrtc/libjingle/xmpp and webrtc/p2p."
...
BUG=N/A
TBR=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/29829004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7472 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-17 22:03:39 +00:00
buildbot@webrtc.org
7992b40994
(Auto)update libjingle 77953038-> 77970462
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7471 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-17 21:20:28 +00:00
henrike@webrtc.org
d1ba6d9cbf
Create a copy of talk/xmpp and talk/p2p under webrtc/libjingle/xmpp and webrtc/p2p.
...
BUG=3379
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/27709005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7459 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-15 17:30:28 +00:00
buildbot@webrtc.org
81ddc78536
(Auto)update libjingle 77701902-> 77709729
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7450 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-14 22:39:24 +00:00
buildbot@webrtc.org
1ecbe45c7e
(Auto)update libjingle 77689511-> 77696841
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7449 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-14 20:29:28 +00:00
pbos@webrtc.org
43336b6b9f
Remove unused (no-op) VideoOptions.
...
Removing VideoOptions: adapt_input_to_encoder, adapt_view_switch,
video_one_layer_screencast and video_high_bitrate.
R=pthatcher@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/23079004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7448 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-14 19:12:06 +00:00
pbos@webrtc.org
7fe1e03dd6
Wire up external encoders.
...
R=pthatcher@webrtc.org
BUG=1788
Review URL: https://webrtc-codereview.appspot.com/30649005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7440 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-14 04:25:33 +00:00
buildbot@webrtc.org
3c16d8bd1c
(Auto)update libjingle 77414393-> 77554188
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7428 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-13 06:35:10 +00:00
xians@webrtc.org
3cefbc99f4
Mark all virtual overrides in the hierarchy of Transport as virtual + OVERRIDE.
...
This also marks all virtual overrides of other classes in the same files.
This will make a subsequent change I intend to do safer, where I'll change the
argument types of the base Transport functions, by breaking the compile if I
miss any overrides.
This also highlighted a number of unused functions. I've removed some of these.
TBR=mflodman@webrtc.org , pkasting@chromium.org
BUG=none
TEST=none
Review URL: https://webrtc-codereview.appspot.com/28709004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7421 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-10 09:42:53 +00:00
buildbot@webrtc.org
97abeee282
(Auto)update libjingle 77263371-> 77296420
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7400 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-08 22:24:30 +00:00
pbos@webrtc.org
575d126a3d
Protect send_/recv_streams_ in WebRtcVideoEngine2.
...
Important as OnLoadUpdate() won't be called on the worker thread and the
list of streams can't be concurrently modified while delivering this
callback to all send streams.
R=stefan@webrtc.org
BUG=1788
Review URL: https://webrtc-codereview.appspot.com/22959004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7395 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-08 14:48:08 +00:00
pbos@webrtc.org
d6bda09503
Initialize sctp_paddrparams in OpenSctpSocket().
...
Addresses 'use-of-uninitialized-value' detected with MemorySanitizer.
params.spp_address.sa_family was used without being initialized before
when calling usrsctp_setsockopt with SCTP_PEER_ADDR_PARAMS.
R=jiayl@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/23909004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7389 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-07 19:23:43 +00:00
pbos@webrtc.org
963b979510
Remove potential deadlock in WebRtcVideoEngine2.
...
Fixes lock-order inversions between capturer's SignalVideoFrame and
WebRtcVideoSendStream. Additionally also removes all deadlock
suppressions for WebRtcVideoEngine2.
R=stefan@webrtc.org
TBR=kjellander@webrtc.org
BUG=1788,2999
Review URL: https://webrtc-codereview.appspot.com/26729004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7386 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-07 14:27:27 +00:00
pbos@webrtc.org
42684be21b
Wire up CPU adaptation in WebRtcVideoEngine2.
...
Includes clean-up work to be able to use the webrtc::Call::Config that's
set up. This introduced a CallFactory to spawn a FakeCall with the
config used and allowed removal of FakeWebRtcVideoChannel2.
BUG=1788
R=mflodman@webrtc.org , pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/24779004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7370 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-03 11:25:45 +00:00
henrik.lundin@webrtc.org
4cebd84c79
Reland "Remove DTMF status methods from Voice Engine" r7276
...
This reverts r7277.
TBR=henrika@webrtc.org ,pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/29599004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7353 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-01 08:23:21 +00:00
xians@webrtc.org
7aad5e5cce
Revert 7338 "Fixed the android build by making the interface pur..."
...
> Fixed the android build by making the interface pure virtual.
>
> TBR=asapersson@webrtc.org , bjornv@webrtc.org ,
>
> Review URL: https://webrtc-codereview.appspot.com/24789004
TBR=xians@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/30579004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7341 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-30 15:26:15 +00:00
xians@webrtc.org
90d1979d77
Fixed the android build by making the interface pure virtual.
...
TBR=asapersson@webrtc.org , bjornv@webrtc.org ,
Review URL: https://webrtc-codereview.appspot.com/24789004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7338 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-30 15:15:22 +00:00
pbos@webrtc.org
1795c358fc
Add default implementation of Add/RemoveObserver.
...
Needed to remove Add/RemoveObserver from RTCVideoEncoderFactory in
Chromium before removing these completely. This is done to keep the
chromium.webrtc.fyi bots happy and to make rolling webrtc revisions
easier.
R=stefan@webrtc.org
BUG=3876
Review URL: https://webrtc-codereview.appspot.com/23839004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7332 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-30 09:45:25 +00:00
pbos@webrtc.org
34f2a9ea72
Initialize SSL in unittest_main.cc.
...
Instead of having each test individually initialize and tear down SSL
move this to unittest_main.cc so that all tests are properly
initialized and new tests "don't have to think about it".
R=pthatcher@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/30549004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7316 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-28 11:36:45 +00:00
pbos@webrtc.org
d60d79a145
Thread annotation of rtc::CriticalSection.
...
Effectively re-lands r5516 which was reverted because talk/-only
checkouts existed. This now resides in webrtc/base/, so no talk/-only
checkouts should be possible.
This change also enables -Wthread-safety for talk/ and fixes a bug in
talk/media/webrtc/webrtcvideoengine2.cc where a guarded variable was
read without taking the corresponding lock.
R=andresp@webrtc.org , mflodman@webrtc.org , pthatcher@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/27569004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7284 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-24 07:10:57 +00:00
pbos@webrtc.org
38344ed280
Move thread_annotations.h to webrtc/base/.
...
R=andresp@webrtc.org , mflodman@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/27579004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7283 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-24 06:05:00 +00:00
buildbot@webrtc.org
1b7dcc1647
(Auto)update libjingle 76169599-> 76176062
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7280 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-23 17:41:48 +00:00
henrik.lundin@webrtc.org
3987f10c11
Revert "Remove DTMF status methods from Voice Engine" r7276
...
This change caused some trouble.
TBR=henrika@webrtc.org ,pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/29569004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7277 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-23 13:15:14 +00:00
henrik.lundin@webrtc.org
bf7b9e0081
Remove DTMF status methods from Voice Engine
...
These methods are not used.
R=henrika@webrtc.org , pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/24689004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7276 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-23 12:54:04 +00:00
pbos@webrtc.org
0a2087a711
Skeleton for registering external encoders/decoders.
...
R=pthatcher@webrtc.org
BUG=1788
Review URL: https://webrtc-codereview.appspot.com/31429005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7270 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-23 09:40:22 +00:00
pbos@webrtc.org
83f95ba9a6
Remove engine-level SetOptions.
...
Already removed in WebRtcVideoEngine.
R=andresp@webrtc.org
BUG=1788
Review URL: https://webrtc-codereview.appspot.com/29549005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7265 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-22 16:07:18 +00:00
henrik.lundin@webrtc.org
64a2f10f4b
Remove Get/SetNetEQPlayoutMode APIs
...
These are not used anymore.
R=henrika@webrtc.org , pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/26569004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7262 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-22 14:30:10 +00:00
buildbot@webrtc.org
ed5ca1f122
(Auto)update libjingle 75925673-> 75926712
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7252 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-19 20:30:44 +00:00
buildbot@webrtc.org
c98f217c65
(Auto)update libjingle 75924589-> 75925673
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7251 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-19 20:18:10 +00:00
buildbot@webrtc.org
0c9fe72b21
(Auto)update libjingle 75922684-> 75924589
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7250 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-19 20:05:02 +00:00
thorcarpenter@google.com
c1eebfa107
Fix the libjingle_media_unittest failure in Windows build by modifying libjingle_tests.gyp and sctpdataengine_unittests.cc instead of ssladapter.cc.
...
R=harryjin@google.com , pthatcher@webrtc.org , tpsiaki@google.com
Review URL: https://webrtc-codereview.appspot.com/22699004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7245 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-19 17:54:00 +00:00
pbos@webrtc.org
bbe0a8517d
Config struct for VideoEncoder.
...
Used for config parameters in common between multiple codecs as well as
the encoder-specific pointer. In particular this contains content mode
(realtime video vs. screenshare).
BUG=1788
R=mflodman@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/16319004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7239 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-19 12:30:25 +00:00
buildbot@webrtc.org
6e5c78422d
(Auto)update libjingle 75875619-> 75878731
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7235 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-19 06:46:37 +00:00
buildbot@webrtc.org
b5a5c44ef7
(Auto)update libjingle 75865376-> 75875619
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7234 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-19 05:36:18 +00:00
buildbot@webrtc.org
d7acf11e8d
(Auto)update libjingle 75854833-> 75865376
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7233 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-19 02:01:09 +00:00
buildbot@webrtc.org
ccb3e3f3db
(Auto)update libjingle 75854418-> 75854833
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7232 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-18 23:31:03 +00:00
buildbot@webrtc.org
933d88af58
(Auto)update libjingle 75818332-> 75837294
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7227 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-18 20:23:05 +00:00
pbos@webrtc.org
6cd6ba8ae0
Expose VP8/H264 defaults through video_encoder.h.
...
Reduces code duplication quite a bit, these identical defaults were set
in quite a few different places.
R=mflodman@webrtc.org , stefan@webrtc.org
BUG=3070
Review URL: https://webrtc-codereview.appspot.com/19299004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7220 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-18 12:42:28 +00:00
pbos@webrtc.org
ab990ae43a
Revert 7151 "Revert 7114 "Expose VideoEncoders with webrtc/video_encoder.h.""
...
Re-lands r7114 after landing r7204 to adress the compile error causing
the rollback in r7151.
BUG=3070
TBR=henrikg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/28489004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7207 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-17 09:02:25 +00:00
pbos@webrtc.org
cddd17c0f8
Recreate VideoStreams when setting resolution.
...
Instead of just changing resolution on the last stream streams are
reallocated to make sure that all streams are updated to match the
new input resolution.
R=pthatcher@webrtc.org
BUG=1788
Review URL: https://webrtc-codereview.appspot.com/29469004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7197 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-16 16:33:13 +00:00
pbos@webrtc.org
88e85ad64d
Add pbos@webrtc.org (myself) to talk/media/webrtc/.
...
Allows easier reviews of webrtcvideoengine2.cc and landing the new video
API on shorter review cycles.
R=pthatcher@webrtc.org
BUG=1788
Review URL: https://webrtc-codereview.appspot.com/30409004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7196 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-16 16:14:51 +00:00
buildbot@webrtc.org
a42a3ade54
(Auto)update libjingle 75390072-> 75428737
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7174 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-13 01:09:18 +00:00
fbarchard@google.com
7e31197cb2
Revert 7170 "Revert 7121 "ValidateFrame, When dumping the first ..."
...
BUG=3789
TESTED=drmemory out\Debug\libjingle_media_unittest.exe --gtest_catch_exceptions=0 --gtest_filter=*Validate*
> Revert 7121 "ValidateFrame, When dumping the first 4 samples of a frame, first copy it to a temporary buffer that is zero padded, them use that."
>
> Breaks other repos.
>
> TBR=fbarchard@google.com
> BUG=N/A
>
> Review URL: https://webrtc-codereview.appspot.com/23639004
TBR=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/27479004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7173 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-13 00:52:42 +00:00
henrike@webrtc.org
3decd9b776
Revert 7121 "ValidateFrame, When dumping the first 4 samples of a frame, first copy it to a temporary buffer that is zero padded, them use that."
...
Breaks other repos.
TBR=fbarchard@google.com
BUG=N/A
Review URL: https://webrtc-codereview.appspot.com/23639004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7170 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-12 16:31:29 +00:00
henrikg@webrtc.org
307d3dbdee
Revert 7114 "Expose VideoEncoders with webrtc/video_encoder.h."
...
Speculative revert, seems to be reason for flaky Win FYI bot compile break.
> Expose VideoEncoders with webrtc/video_encoder.h.
>
> Exposes VideoEncoders as part of the public API and provides a factory
> method for creating them.
>
> BUG=3070
> R=mflodman@webrtc.org , stefan@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/21929004
TBR=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/19329004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7151 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-11 09:48:30 +00:00
henrik.lundin@webrtc.org
1972ff8a6e
Mark all virtual overrides in the hierarchy of Module as virtual and OVERRIDE.
...
This will make a subsequent change I intend to do safer, where I'll change the
return type of one of the base Module functions, by breaking the compile if I
miss any overrides.
This also highlighted a number of unused functions (in many cases apparently
virtual "overrides" of no-longer-existent base functions). I've removed some of
these.
This also highlighted several cases where "virtual" was used unnecessarily to
mark a function that was only defined in one class. Removed "virtual" in those
cases.
BUG=none
TEST=none
R=andrew@webrtc.org , henrik.lundin@webrtc.org , mallinath@webrtc.org , mflodman@webrtc.org , stefan@webrtc.org , turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/24419004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7146 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-11 06:20:28 +00:00
buildbot@webrtc.org
5d639b3ef3
(Auto)update libjingle 75141932-> 75179475
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-10 07:57:12 +00:00
fbarchard@google.com
54cf1505e2
ValidateFrame, When dumping the first 4 samples of a frame, first copy it to a temporary buffer that is zero padded, them use that.
...
BUG=3789
TESTED=drmemory out\Debug\libjingle_media_unittest.exe --gtest_catch_exceptions=0 --gtest_filter=*Validate*
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/24499004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7121 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-09 18:34:53 +00:00
pbos@webrtc.org
b420191743
Expose VideoEncoders with webrtc/video_encoder.h.
...
Exposes VideoEncoders as part of the public API and provides a factory
method for creating them.
BUG=3070
R=mflodman@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/21929004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7114 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-09 10:40:56 +00:00
pbos@webrtc.org
7118e61669
Finish work queue in SctpDataMediaChannelTest.
...
Always finishing the work queue prevents memory leak detected in
LeakSanitizer (packet is deleted on the receiver side).
R=jiayl@webrtc.org
BUG=3608,chromium:375154
Review URL: https://webrtc-codereview.appspot.com/28399004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7110 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-08 21:44:07 +00:00
buildbot@webrtc.org
fd42f9dd6f
(Auto)update libjingle 74955991-> 75042522
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7106 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-08 19:45:36 +00:00
thorcarpenter@google.com
cc060563f3
Remove unnecessary include from testutils.cc.
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7090 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-05 21:19:00 +00:00
buildbot@webrtc.org
992febb997
(Auto)update libjingle 74873066-> 74873164
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7089 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-05 16:39:08 +00:00
thorcarpenter@google.com
a3344cfda4
Fix webrtcvideoframe tests.
...
R=fbarchard@google.com , harryjin@google.com , henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/24429004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7088 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-05 16:34:13 +00:00
buildbot@webrtc.org
af5fa95258
(Auto)update libjingle 74857067-> 74860820
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7084 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-05 13:03:50 +00:00
buildbot@webrtc.org
7e3bd3d7de
(Auto)update libjingle 74851128-> 74857067
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7083 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-05 11:45:42 +00:00
buildbot@webrtc.org
bc6fa1876e
(Auto)update libjingle 74825992-> 74851128
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7082 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-05 11:08:01 +00:00
buildbot@webrtc.org
818b7b3ac9
(Auto)update libjingle 74825084-> 74825992
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7074 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-05 00:14:03 +00:00
pbos@webrtc.org
bcb6bcfe6c
Remove HybridVideoEngine.
...
This is currently unused dead code.
R=pthatcher@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/24409004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7055 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-04 07:32:26 +00:00
thorcarpenter@google.com
95c2458766
* Move test data assests required by video frame tests to be in libjingle instead of elsewhere and co-located with other libjingle test data files.
...
"gcl try" fails to upload these large files so adding them independently.
R=andrew@webrtc.org , harryjin@google.com , henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14319004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7050 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-03 23:17:36 +00:00
buildbot@webrtc.org
609f987488
(Auto)update libjingle 74696326-> 74723281
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7047 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-03 21:50:32 +00:00
pbos@webrtc.org
26c0c41a06
Network up/down signaling in Call.
...
BUG=2429
R=mflodman@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/13109005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7044 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-03 16:17:12 +00:00
pbos@webrtc.org
ebee401230
Remove flake in SendsLowerResolutionOnSmallerFrames.
...
Speculative fix for break on Linux64 Release. It looks like the second
frame is being dropped which is likely because the two frames are sent
too close to eachother. Adding a delay of 33ms in between them to make
sure the second one isn't dropped.
R=minyue@webrtc.org
TBR=pthatcher@webrtc.org
BUG=1788
Review URL: https://webrtc-codereview.appspot.com/22289004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7043 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-03 15:52:02 +00:00
pbos@webrtc.org
c4175b9fdf
Set resolution based on incoming VideoFrames.
...
R=pthatcher@webrtc.org
BUG=1788
Review URL: https://webrtc-codereview.appspot.com/17269004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7042 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-03 15:25:49 +00:00
buildbot@webrtc.org
72e448559d
(Auto)update libjingle 74628537-> 74648573
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7033 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-03 00:43:48 +00:00
pbos@webrtc.org
9f341283f6
Remove WebRtcVideoEngine::default_codec_format().
...
R=pthatcher@webrtc.org
BUG=1788
Review URL: https://webrtc-codereview.appspot.com/24399004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7029 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-02 16:33:09 +00:00
buildbot@webrtc.org
1f8a23757a
(Auto)update libjingle 74235596-> 74297316
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6997 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-28 10:52:44 +00:00
pbos@webrtc.org
75c3ec1763
Fix data races during VideoAdapterTest tear-down.
...
Explicitly disconnect the VideoCapturer to avoid frames being
delivered during listener destruction. This manifested only on DrMemory
Full on Windows which I was able to repro locally.
BUG=3671
R=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/15289004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6991 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-27 18:16:13 +00:00
buildbot@webrtc.org
573a1eef3d
(Auto)update libjingle 74202294-> 74230205
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6990 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-27 17:21:19 +00:00
buildbot@webrtc.org
3533bfcb94
(Auto)update libjingle 74132319-> 74133664
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6983 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-26 15:50:23 +00:00
buildbot@webrtc.org
4470d78c9b
(Auto)update libjingle 74128148-> 74132319
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6982 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-26 15:24:54 +00:00
pbos@webrtc.org
f21ac1fd46
Fix Win64 compile of videoadapter_unittest.cc.
...
Missed an typecast in videoadapter_unittest.cc in r6979 due to
tryservers being clogged and me waiting for a windows, linux, mac and
tsanv2 bot to finish was not enough. Committing fix straight away to
un-break tree.
TBR=tommi@webrtc.org
BUG=3671
Review URL: https://webrtc-codereview.appspot.com/18279004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6980 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-26 12:46:57 +00:00
pbos@webrtc.org
c9b3f77e65
Fix data races in VideoAdapterTest.
...
Adressing clear races between the test thread and capturer thread shown
as heap-use-after-free in vpx_codec_destroy in
WebRtcVideoMediaChannelTest.SetSend (way later in the rest run).
When capturing a frame the test copied it to a separate frame that would
then be read by the test without synchronization, if the test didn't
manage to examine the frame in between captures the adapted frame would
be overwritten by the following frame during accesses to it.
The actual races are suppressed by race:webrtc/base/messagequeue.cc and
race:webrtc/base/thread.cc. These fixes reduce the suppression count
locally from around 3000 to 30 for VideoAdapterTest.*.
Also removing tsan suppressions for talk/base as it's been moved to
webrtc/base.
R=tommi@webrtc.org
BUG=3671
Review URL: https://webrtc-codereview.appspot.com/22169004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6979 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-26 12:33:18 +00:00
pbos@webrtc.org
b648b9d85c
Remove test constructor in WebRtcVideoEngine2.
...
Removes the need for ::Construct().
BUG=1788
R=pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/15279004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6977 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-26 11:08:06 +00:00
kjellander@webrtc.org
b96ea2aab5
Remove former team members from OWNERS and WATCHLISTS
...
Remove the following (CCed) former team members from all
OWNERS files and the WATCHLISTS file:
* fischman@
* leozwang@
* mikhal@
* pwestin@
* wu@
BUG=
R=henrike@webrtc.org , niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/22509004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6973 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-26 06:12:08 +00:00
buildbot@webrtc.org
204cd56007
(Auto)update libjingle 74064646-> 74072040
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6972 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-25 21:10:18 +00:00
buildbot@webrtc.org
857130fd5b
(Auto)update libjingle 74039473-> 74044292
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6970 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-25 16:07:12 +00:00
buildbot@webrtc.org
b4c7b09c13
(Auto)update libjingle 73927775-> 74032598
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6965 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-25 12:11:58 +00:00
buildbot@webrtc.org
3740d74106
(Auto)update libjingle 73927658-> 73927775
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6958 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-22 22:27:04 +00:00
buildbot@webrtc.org
309a611670
(Auto)update libjingle 73891518-> 73927658
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6957 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-22 22:24:54 +00:00