generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
5,114 Commits 1 Branch 0 Tags 108 MiB
385a722646
Commit Graph

250 Commits

Author SHA1 Message Date
henrike@webrtc.org
5cf3e8f0f0 (Auto)update libjingle $LAST_P10_REVISION-> $NEW_P10_REVISION 
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5572 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-18 22:28:52 +00:00
fischman@webrtc.org
358e3367a3 PeerConnection(java): enable HW encoder on N5 for standalone build. 
Now that bug 2899 is fixed (r5562) packet-loss is recoverable.  Yay.

BUG=2575
R=noahric@google.com

Review URL: https://webrtc-codereview.appspot.com/8869004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5568 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-18 17:29:37 +00:00
fischman@webrtc.org
c2d75e0708 PeerConnection(java): account for thread shutdown vagaries. 
Android's JVM requires threads to detach before they exit, but ONLY if
they needed to AttachCurrentThread.  Conversly, threads that were
attached by the JVM (e.g. the result of making a native call from Java)
must NOT be detached by the application.  This is bug 2441.

The fix for the above is to only pthread_setspecific() for threads that
Attach(), not for already-attached threads.  To ensure that we only
detach Attached threads, added a GetEnv() call to ThreadDestructor(),
which revealed that Oracle's JVM can overly-eagerly clear TLS accounting
data, effectively detaching threads without their consent at shutdown.
Work around this with a specific check.

To guard against (some) regression, added a variant of PeerConnectionTest
that runs on a non-main thread.  This revealed a bug in LinuxDeviceManager
which implicitly assumes its talk_base::Thread has already been
initialized.  Fixed that here too.

BUG=2441
R=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8759004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5567 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-18 16:57:36 +00:00
mallinath@webrtc.org
92fdfebedd Update talk to 61699344. 
TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8809004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5560 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-17 18:49:41 +00:00
henrike@webrtc.org
b8c254abd6 (Auto)update libjingle 61549749-> 61608469 
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5555 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-14 23:38:45 +00:00
fischman@webrtc.org
c5d506a106 AppRTCDemo(android): clarified README on how to launch app using adb. 
TBR=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8689005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5553 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-14 17:55:13 +00:00
fischman@webrtc.org
a3708ecdfe PeerConnectionTest(java): unbreak following 61460797-p10 
BUG=1414
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8719004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5550 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-14 01:51:33 +00:00
mallinath@webrtc.org
385857dfd4 Update talk to 61549749. 
TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8709004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5549 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-14 00:56:12 +00:00
wu@webrtc.org
b9a088b920 Update talk to 61538839. 
TBR=mallinath

Review URL: https://webrtc-codereview.appspot.com/8669005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5548 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-13 23:18:49 +00:00
wu@webrtc.org
0de29504ab Revert 5545 "Update libjingle to 61514460" 
> Update libjingle to 61514460
> 
> TBR=tommi@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/8649004

TBR=xians@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8669004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5547 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-13 19:54:28 +00:00
xians@webrtc.org
e749c9ebdb Update libjingle to 61514460 
TBR=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8649004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5545 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-13 15:09:40 +00:00
fischman@webrtc.org
3eda643a91 PeerConnection(java): added MediaConstraints support to AudioSource, now fed to AudioTrack. 
BUG=2912
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8509004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5540 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-13 04:01:04 +00:00
fischman@webrtc.org
540acde5b3 PeerConnection(java): use MediaCodec for HW-accelerated video encode where available. 
Still disabled by default until https://code.google.com/p/webrtc/issues/detail?id=2899 is resolved.

Also (because I needed them during development):
- make AppRTCDemo "debuggable" for extra JNI checks
- honor audio constraints served by apprtc.appspot.com
- don't "restart" video when it hasn't been stopped (affects running with the
  screen off)

BUG=2575
R=noahric@google.com

Review URL: https://webrtc-codereview.appspot.com/8269004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5539 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-13 03:56:14 +00:00
jiayl@webrtc.org
14d80793a8 PeerConnectionClient needs to initialize SSL. 
BUG=2911
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8499004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5531 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-12 00:41:59 +00:00
wjia@webrtc.org
dd82fa726c Revert 5516 "Thread annotation of talk_base::CriticalSection." 
r5516 failed compilation on builds with enable_webrtc=0.

> Thread annotation of talk_base::CriticalSection.
> 
> Also enabling -Wthread-safety in talk/build/common.gypi for clang on
> Linux. Thread annotations are compile-time checks that for instance
> certain locks are held before accessing a value.
> 
> BUG=
> TEST=Local GUARDED_BY() annotations.
> R=andresp@webrtc.org, fischman@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/8189004

TBR=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8409004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5523 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-10 23:20:15 +00:00
fischman@webrtc.org
82387e4608 Add ability to receive calls for iOS 
BUG=2701
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7989005

Patch from Sajid Hussain <shussain@temasys.com.sg>.

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5518 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-10 18:47:11 +00:00
pbos@webrtc.org
0a7085ffc2 Thread annotation of talk_base::CriticalSection. 
Also enabling -Wthread-safety in talk/build/common.gypi for clang on
Linux. Thread annotations are compile-time checks that for instance
certain locks are held before accessing a value.

BUG=
TEST=Local GUARDED_BY() annotations.
R=andresp@webrtc.org, fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8189004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5516 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-10 13:58:37 +00:00
kjellander@webrtc.org
4723dc88b3 Revert 5511 "Revert 5510 "Disable failing libjingle_p2p_unittest..." 
So, the test apparently failed right away at 

http://build.chromium.org/p/client.webrtc/builders/Linux64%20Debug/builds/1224/steps/libjingle_p2p_unittest/logs/stdio


> Revert 5510 "Disable failing libjingle_p2p_unittest test on Linux"
> 
> According to https://code.google.com/p/webrtc/issues/detail?id=2907#c2
> r5505 was committed to resolve exactly these flakes.
> Let's revert the disabling and see.
> 
> BUG=2907
> TBR=mallinath@webrtc.org
> 
> > Disable failing libjingle_p2p_unittest test on Linux
> > 
> > I realize this diables 84 test cases and for all platforms, which
> > I'm not really comfortable with. I tried finding a better way but
> > couldn't without doing significant changes to the file.
> > I think the tests either needs to be fixed or otherwise refactored
> > in order to make more fine-grained disabling possible.
> > 
> > Another (too) large disabling was done by holmer@ in
> > https://webrtc-codereview.appspot.com/2227004 where he should only have
> > disabled them on Windows, if the failures in webrtc:2383 was all that
> > caused those flakes.
> > 
> > BUG=2907
> > TEST=Verified this ran 0 tests:
> > out/Release/libjingle_p2p_unittest --gtest_filter=P2PTransportChannelTest.TestNAT_ADDR_RESTRICTEDToNAT_PORT_RESTRICTEDAsGiceBothSharedUfragWithMinimumStepDelay
> > TBR=wu@webrtc.org
> > 
> > Review URL: https://webrtc-codereview.appspot.com/8309004
> 
> TBR=kjellander@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/8329004

TBR=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8339004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5513 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-09 18:48:56 +00:00
kjellander@webrtc.org
607c805b87 Roll chromium_revision 245382:249215 
The find_depot_tools.py is needed to workaround the import
error we get from gyp_chromium when importing it in
webrtc/build/gyp_webrtc (to avoid code duplication).
gyp_chromium introduced a dependency on it in
http://crrev.com/245412 but as we cannot sync all of Chrome's
src/tools (it's quite big), we'll work around this by
adding an empty find_depot_tools module.

The removal of the Cygwin relates to
http://crrev.com/248802 which is a step on the way to remove
Cygwin in Chromium. We seem to already be able to remove it
entirely for WebRTC though.

Changes in the isolate framework required us to update our
copies of the isolate.gypi files.

BUG=none
TEST=trybots passing on all platforms
R=andrew@webrtc.org, fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8099004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5512 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-09 18:38:31 +00:00
kjellander@webrtc.org
ce2b44532e Revert 5510 "Disable failing libjingle_p2p_unittest test on Linux" 
According to https://code.google.com/p/webrtc/issues/detail?id=2907#c2
r5505 was committed to resolve exactly these flakes.
Let's revert the disabling and see.

BUG=2907
TBR=mallinath@webrtc.org

> Disable failing libjingle_p2p_unittest test on Linux
> 
> I realize this diables 84 test cases and for all platforms, which
> I'm not really comfortable with. I tried finding a better way but
> couldn't without doing significant changes to the file.
> I think the tests either needs to be fixed or otherwise refactored
> in order to make more fine-grained disabling possible.
> 
> Another (too) large disabling was done by holmer@ in
> https://webrtc-codereview.appspot.com/2227004 where he should only have
> disabled them on Windows, if the failures in webrtc:2383 was all that
> caused those flakes.
> 
> BUG=2907
> TEST=Verified this ran 0 tests:
> out/Release/libjingle_p2p_unittest --gtest_filter=P2PTransportChannelTest.TestNAT_ADDR_RESTRICTEDToNAT_PORT_RESTRICTEDAsGiceBothSharedUfragWithMinimumStepDelay
> TBR=wu@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/8309004

TBR=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8329004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5511 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-09 18:21:00 +00:00
kjellander@webrtc.org
8d2ddd00f1 Disable failing libjingle_p2p_unittest test on Linux 
I realize this diables 84 test cases and for all platforms, which
I'm not really comfortable with. I tried finding a better way but
couldn't without doing significant changes to the file.
I think the tests either needs to be fixed or otherwise refactored
in order to make more fine-grained disabling possible.

Another (too) large disabling was done by holmer@ in
https://webrtc-codereview.appspot.com/2227004 where he should only have
disabled them on Windows, if the failures in webrtc:2383 was all that
caused those flakes.

BUG=2907
TEST=Verified this ran 0 tests:
out/Release/libjingle_p2p_unittest --gtest_filter=P2PTransportChannelTest.TestNAT_ADDR_RESTRICTEDToNAT_PORT_RESTRICTEDAsGiceBothSharedUfragWithMinimumStepDelay
TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8309004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5510 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-08 21:35:20 +00:00
sergeyu@chromium.org
cc685acbdf Disable AsyncInvokeTest.CancelInvoker test 
Test is flaky.

BUG=b/12944358
TBR=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8289004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5508 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-08 19:59:00 +00:00
sergeyu@chromium.org
0178810659 Don't use LOG() in callback.h 
Because chromium is compiled with a different version of logging macros
defined in logging.h that header cannot be used in headers that can
also included from chromium code. Removed LOG_F(LS_WARNING) from
callback.h . That issue would block this code from being rolled in
chromium.

R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8279004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5507 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-08 03:18:03 +00:00
mallinath@webrtc.org
5a59ccbb6d Switching to NSS random number generator and adding init method to unittests. 
R=jiayl@webrtc.org, sergeuy@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8259004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5505 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-07 23:22:00 +00:00
sergeyu@chromium.org
9cf037b831 Update libjingle to 61168196 
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8139004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5502 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-07 19:03:26 +00:00
pbos@webrtc.org
ea1c5ad58f Fix gunit compilation on VS2012. 
In VS2012 compiling gunit or its dependencies triggers a lot of
"'std::tuple' : too many template arguments" warnings. The workaround
for this, done for gtest already, is to define _VARIADIC_MAX=10.

BUG=2616
R=perkj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8089004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5493 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-06 13:17:20 +00:00
fischman@webrtc.org
6e08228525 PeerConnectionTest(java): remove the obsolete magical names of streams & tracks. 
BUG=1253
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7929005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5478 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-03 19:15:44 +00:00
fischman@webrtc.org
a06ebab1e1 PeerConnectionTest(java): test SCTP DataChannels. 
BUG=1408,2253,2626
R=jiayl@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7929004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5477 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-03 19:11:29 +00:00
mallinath@webrtc.org
ecd622eec3 Updating libjingle.gyp after addition new files yuvframescapturer.cc. 
TBR=pbos@webrc.org

Review URL: https://webrtc-codereview.appspot.com/7919006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5476 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-03 17:17:05 +00:00
mallinath@webrtc.org
67ee6b9a62 Update talk to 60923971 
Review URL: https://webrtc-codereview.appspot.com/7909004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5475 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-03 16:57:16 +00:00
jiayl@webrtc.org
808b99b111 Disable a test assert which fails due to usrsctp not cleaned up in SctpDataEngine.cc 
BUG=2749
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7739005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5460 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-29 19:44:40 +00:00
jiayl@webrtc.org
a576faf82a Enable SCTP and use OPENSSL on Anroid and NSS on other platforms. 
It includes unit test fixes to properly initialize SSL if DTLS or SSL random number generator is used in the tests.
The private key and certificate constant strings used in some tests are updated to be compatible with NSS.
A few potentially overflow type conversions caused compiling warning on Windows and they are fixed by importing and using Chromium's checked_cast, which aborts the program if overflow occurs.
It also fixes a leak in nssstreamadapter.cc by releasing the PRFileDesc* in StreamClose.

BUG=2253
R=fischman@webrtc.org, juberti@google.com, wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/4679005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5459 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-29 17:45:53 +00:00
mallinath@webrtc.org
7433a088d2 Revert 5444 "Revert 5421 "Fix deadlock on register/unregister ob..." 
We reverted the r5421 to allow us roll webrtc to chrome without any modifications
to libjingle. Since webrtc is rolled with r5444, we can add back the original CL
and changes to libjingle will be upstreamed in the next roll.

TBR=andresp@webrtc.org

> Revert 5421 "Fix deadlock on register/unregister observer while ..."
> 
> Failure to compile on Chromium Internal bots, because of API changes.
> 
> http://chromegw.corp.google.com/i/internal.chromium.webrtc.fyi/builders/Mac/builds/2805/steps/compile/logs/stdio
> 
> You need to follow the steps mentioned in 
> https://docs.google.com/a/google.com/document/d/1aHrmXECnu3-Jovc2-zYI267EaQCYz-IclYyBp9iA9Fc/edit that of a API changer.
> 
> Since I will be rolling the libjingle this week, I can push your changes along with libjingle roll, if you prepare the CLs
> as mentioned in the doc.
> 
> > Fix deadlock on register/unregister observer while there is a an going callback.
> > 
> > BUG=2835
> > R=mallinath@webrtc.org
> > 
> > Review URL: https://webrtc-codereview.appspot.com/7119005
> 
> TBR=andresp@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/7679004

TBR=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7729005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5453 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-29 00:56:02 +00:00
mallinath@webrtc.org
0dac5378e5 Revert 5447 "Update talk to 60420316." 
> Update talk to 60420316.
> 
> TBR=wu@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/7719005

TBR=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7729004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5448 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-28 06:58:42 +00:00
mallinath@webrtc.org
752a017809 Update talk to 60420316. 
TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7719005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5447 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-28 06:45:52 +00:00
mallinath@webrtc.org
18586d38bc Revert 5421 "Fix deadlock on register/unregister observer while ..." 
Failure to compile on Chromium Internal bots, because of API changes.

http://chromegw.corp.google.com/i/internal.chromium.webrtc.fyi/builders/Mac/builds/2805/steps/compile/logs/stdio

You need to follow the steps mentioned in 
https://docs.google.com/a/google.com/document/d/1aHrmXECnu3-Jovc2-zYI267EaQCYz-IclYyBp9iA9Fc/edit that of a API changer.

Since I will be rolling the libjingle this week, I can push your changes along with libjingle roll, if you prepare the CLs
as mentioned in the doc.

> Fix deadlock on register/unregister observer while there is a an going callback.
> 
> BUG=2835
> R=mallinath@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/7119005

TBR=andresp@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7679004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5444 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-27 22:00:57 +00:00
wu@webrtc.org
256d0ada35 Remove the check for audio codec num in WebRtcVoiceEngineTest.HasCorrectCodecs. 
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7589004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5430 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-24 18:58:51 +00:00
wu@webrtc.org
ca5ff9972e Re-enable webrtcvoice/videoengine unittests. 
TEST=try bots
BUG=
R=mallinath@webrtc.org

Committed: https://code.google.com/p/webrtc/source/detail?r=5387

Review URL: https://webrtc-codereview.appspot.com/7149004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5427 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-24 17:37:46 +00:00
andresp@webrtc.org
8d375c95b7 Fix deadlock on register/unregister observer while there is a an going callback. 
BUG=2835
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7119005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5421 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-23 23:09:25 +00:00
wu@webrtc.org
a8910d2f88 Update talk to 60094938. 
Review URL: https://webrtc-codereview.appspot.com/7489005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5420 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-23 22:12:45 +00:00
mallinath@webrtc.org
0d92ef67c4 Libjingle source code has some spelling mistakes and one of them is "renegotation", which should be "renegotiation". 
This CL is attempting to correct those.

BUG=2810
TBR=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7439004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5411 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-22 02:21:22 +00:00
mallinath@webrtc.org
68cbd01216 enabling disabled data channels tests on win32. The real culprit was that ice candidates not included in SDP when there were failure causing transport channels never becoming writable. 
BUG=2799
R=jiayl@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7369004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5410 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-22 00:16:46 +00:00
henrike@webrtc.org
28da47c52f Android example apps: fixes issue where useful failure information was suppressed. 
BUG=2808
R=andrew@webrtc.org, fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7309004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5408 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-21 19:03:51 +00:00
henrike@webrtc.org
2ce9a64b75 Talk: Removes deprecated example apps and moves the server apps to trunk/talk/examples. 
BUG=12545067
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7159004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5397 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-16 16:49:53 +00:00
sergeyu@chromium.org
4b26e2eee3 Update libjingle to 59676287 
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7229004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5390 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-15 23:15:54 +00:00
wu@webrtc.org
8f19cb9fbc Revert 5387 "Re-enable webrtcvoice/videoengine unittests." 
Missed the result from the last try bot.

> Re-enable webrtcvoice/videoengine unittests.
> 
> TEST=try bots
> BUG=
> R=mallinath@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/7149004

TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7179004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5388 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-14 22:31:11 +00:00
wu@webrtc.org
eda6823397 Re-enable webrtcvoice/videoengine unittests. 
TEST=try bots
BUG=
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7149004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5387 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-14 22:15:09 +00:00
wjia@webrtc.org
03cfde2d10 Roll Chromium 238260 -> 243863 
R=andrew@webrtc.org, henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6939004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5385 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-14 17:48:34 +00:00
henrika@webrtc.org
aebb1ade9d pRevert 5371 "Revert 5367 "Update talk to 59410372."" 
> Revert 5367 "Update talk to 59410372."
> 
> > Update talk to 59410372.
> > 
> > R=jiayl@webrtc.org, wu@webrtc.org
> > 
> > Review URL: https://webrtc-codereview.appspot.com/6929004
> 
> TBR=mallinath@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/6999004

TBR=henrika@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7109004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5381 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-14 10:00:58 +00:00
fischman@webrtc.org
d7568a08c3 PeerConnection(java): Add OnRenegotiationNeeded support 
Also:
- Make PeerConnectionObserver::OnRenegotiationNeeded() pure virtual to avoid
  this sort of mistake in the future.
- Sprinkle @Override annotations on some callback definitions that were missing
  them.
- Fix a JNI method-signature-lookup typo (s/(V)V/()V/) in PCOJava::OnError()
- Add an explicit ScopedLocalFrameRef to PCOJava::OnError() to match all other
  C++-fired callbacks, for consistency.

BUG=2771
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6829004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5376 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-13 22:04:12 +00:00
henrika@webrtc.org
44461fa5cb Revert 5367 "Update talk to 59410372." 
> Update talk to 59410372.
> 
> R=jiayl@webrtc.org, wu@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/6929004

TBR=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6999004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5371 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-13 09:35:02 +00:00
mallinath@webrtc.org
0f3356e20b Update talk to 59410372. 
R=jiayl@webrtc.org, wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6929004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5367 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-11 01:26:23 +00:00
sergeyu@chromium.org
4625df3e3e Fix NaCl compilation 
nethelpers.cc was using LOG() but didn't include logging.h

R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6829005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5360 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-09 21:26:50 +00:00
fischman@webrtc.org
4177615e87 PeerConnection(java): replace ScopedLocalRef with ScopedLocalRefFrame and fix a local reference leak in OnMessage. 
Hopefully the approach of pushing/popping frames will be easier to avoid messing up than remembering to annotate every single local reference with a ScopedLocalRef.

BUG=2761
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6729004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5355 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-09 00:31:17 +00:00
fischman@webrtc.org
1794693ec8 AppRTCDemo(android): close() the throw-away DataChannel. 
Otherwise, the PeerConnection remembers the channel enough to include an
m=application line in its offer SDP, causing connection to chrome to fail, since
apprtc.appspot.com doesn't include an RtpDataChannels:true constraint in its
RTCPeerConnection constructor call.

R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6729005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5354 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-08 18:29:34 +00:00
wu@webrtc.org
e00265ed49 Fix a compile error on Android on sctpdataengine.cc. 
TEST=try bots
BUG=
R=jiayl@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6719004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5350 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-07 19:32:40 +00:00
wu@webrtc.org
f6d6ed0c66 Update talk to 59039880. 
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6569004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5339 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-03 22:08:47 +00:00
fischman@webrtc.org
000dde99c8 Android build: make it quiet on success and not overly noisy on failure. 
- OpenSLDemo and WebRTCDemo get the sauce that AppRTCDemo got in r5271
- libjingle_peerconnection_jar is now silent on success
- Fix a bug introduced by r5271 which caused ant logs to be emitted to a subdir of talk/examples instead of in the gyp output directory.

R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6199005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5332 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-12-20 22:49:35 +00:00
fischman@webrtc.org
af320fd2f7 The designated initializer method declaration in the Objective-C headers for RTCICEServer does't match its implementation. 
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6019004

Patch from Rafael Lopez Diez <rafalopezdiez@gmail.com>.

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5309 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-12-17 21:33:27 +00:00
fischman@webrtc.org
5b3c67ef25 objc/README: Remove outdated advice about target_os. 
BUG=chromium:248168
TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5979005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5302 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-12-16 17:15:19 +00:00
wu@webrtc.org
24301a67c6 Update talk to 58174641 together with http://review.webrtc.org/4319005/. 
R=turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5809004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5287 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-12-13 19:17:43 +00:00
mallinath@webrtc.org
62451dcba0 Update talk to 58157731. 
R=wu@webrtc.org

TBR=wu@webrc.org

Review URL: https://webrtc-codereview.appspot.com/5339005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5282 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-12-13 12:29:34 +00:00
wu@webrtc.org
a9890800e0 Update talk to 58127566 together with 
https://webrtc-codereview.appspot.com/5309005/.

R=mallinath@webrtc.org, niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5719004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5277 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-12-13 00:21:03 +00:00
wu@webrtc.org
2018269dc3 Revert 5274 "Update talk to 58113193 together with https://webrt..." 
> Update talk to 58113193 together with https://webrtc-codereview.appspot.com/5309005/.
> 
> R=mallinath@webrtc.org, niklas.enbom@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/5719004

TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5729004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5275 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-12-12 22:54:25 +00:00
wu@webrtc.org
a129b6cd13 Update talk to 58113193 together with https://webrtc-codereview.appspot.com/5309005/. 
R=mallinath@webrtc.org, niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5719004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5274 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-12-12 22:40:39 +00:00
fischman@webrtc.org
df7b1d6e39 AppRTCDemo(android): make ant be quiet on success and not overly noisy on failure. 
Also silence a 'cd' that would otherwise emit the path/to/talk.

R=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5539004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5271 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-12-11 22:36:22 +00:00
henrike@webrtc.org
9ee75e9c77 Enables mixing and matching Java and native audio. It is used for getting best of both worlds capabilities (AEC and low latency). 
BUG=N/A
R=fischman@webrtc.org, niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/4189004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5270 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-12-11 21:42:44 +00:00
fischman@webrtc.org
f41f06b916 PeerConnection(java): rationalize pointer-to-jlong conversion. 
In r4665 I went a bit crazy with the manual reinterpretation of a pointer to a
jlong (to avoid undefined behavior) but that's what reinterpret_cast<> is for.
So use it directly now.
Added a do-nothing DataChannel to AppRTCDemo to regression test this, since the
only repro I've found of the original bug requires ARM ABI (PeerConnectionTest
on ia32 fails to repro).

BUG=2302
R=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5489004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5269 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-12-11 21:07:18 +00:00
wu@webrtc.org
9caf2765b2 Update talk to 58037405. 
R=sergeyu@chromium.org

Review URL: https://webrtc-codereview.appspot.com/5579004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5267 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-12-11 18:25:07 +00:00
turaj@webrtc.org
4c3faa9d73 Disable a libjingle unittest which is failing after a chromium roll out. 
TBR=kjellander@google.com

BUG=

Review URL: https://webrtc-codereview.appspot.com/5559007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5264 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-12-11 16:12:31 +00:00
kjellander@webrtc.org
f9bdbe3619 Roll chromium_revision 232627:238260 
This brings us the updated swarming_client
that has moved out from Chromium into a standalone
project.
Because of this, all .isolate files needed to be
updated as well, similar to the changes in
https://codereview.chromium.org/29993003

TEST=trybots passing
BUG=none
R=andrew@webrtc.org, perkj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/4859004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5260 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-12-11 13:37:12 +00:00
andrew@webrtc.org
77507eff4f Correctly define OVERRIDE when building with g++ 4.7 and C++11 support 
g++ 4.7 and later support explicit virtual overrides when building with C++11 support
enabled. However, libjingle does not detect that and makes OVERRIDE a no-op.

This CL updates base/common.h to define OVERRIDE properly when g++ 4.7 is used with
C++11 support enabled.

See this page for GCC support of C++11 features:
http://gcc.gnu.org/projects/cxx0x.html

R=fischman@webrtc.org, wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5159004

Patch from Chris Dumez <ch.dumez@samsung.com>.

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5255 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-12-11 00:07:11 +00:00
fischman@webrtc.org
eb7def234e Fix compilation errors on Fedora 20. 
peerconnection_jni.cc: syscall() comes from <unistd.h>
RTPtimeshift.cc: char* being compared to 0 instead of the atoi() of it
rtp_payload_registry_unittest.cc: avoid narrowing int to uint32.

BUG=2700
R=andrew@webrtc.org, fischman@webrtc.org, henrik.lundin@webrtc.org, henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5019004

Patch from Victor Costan <costan@gmail.com>.

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5248 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-12-09 21:34:30 +00:00
sergeyu@chromium.org
32f485b16a Fix constants.[h|cc] to avoid static initializer in webrtcvideoengine.cc. 
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5179004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5233 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-12-05 22:36:21 +00:00
sergeyu@chromium.org
57a5f64264 revert r5230 
r5230 broke windows build.

TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5169004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5232 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-12-05 22:14:46 +00:00
sergeyu@chromium.org
a1b21cd777 Fix constants.[h|cc] to avoid static initializer in webrtcvideoengine.cc. 
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5139004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5230 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-12-05 21:28:34 +00:00
sergeyu@chromium.org
5bc25c41fc Update libjingle to 57692857 
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/4999004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5217 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-12-05 00:24:06 +00:00
fischman@webrtc.org
e0034557a7 RTCPeerConnection(objc): avoid leaking ICE candidate on addition. 
BUG=2670
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/4379004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5199 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-12-02 18:49:54 +00:00
wu@webrtc.org
b43202d839 Disable PeerConnectionEndToEndTest for tsanv2 build. 
BUG=1205
TEST=try
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/4279004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5162 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-11-22 19:14:25 +00:00
fischman@webrtc.org
1977960866 AppRTCDemo(ios): remove codesigning hack now that gyp signs by default. 
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/4119005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5155 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-11-21 16:48:51 +00:00
wu@webrtc.org
364f204d16 Update talk to 56698267. 
TBR=sergeyu@chromium.org

Review URL: https://webrtc-codereview.appspot.com/4119004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5143 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-11-20 21:49:41 +00:00
sergeyu@chromium.org
183c727bca Disable datachannel_unittest.cc 
the test fails to compile because it uses incorrect gmock path (as 
some other tests).

TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/3849004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5121 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-11-13 22:59:20 +00:00
sergeyu@chromium.org
a23f0ca4ba Update talk to 56619788 
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/3839005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5120 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-11-13 22:48:52 +00:00
wu@webrtc.org
16d6254e8c Update talk to 56183333. 
TEST=try bots
R=sheu@chromium.org

Review URL: https://webrtc-codereview.appspot.com/3469004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5087 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-11-05 23:45:14 +00:00
fischman@webrtc.org
7b273a545d PeerConnection iOS: update README instructions 
This is needed to account for https://codereview.chromium.org/25535004/

R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/3059004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5079 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-11-04 18:48:12 +00:00
wu@webrtc.org
07a6fbe83d Update talk to 56092586. 
R=jiayl@webrtc.org, mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/3359004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5078 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-11-04 18:41:34 +00:00
wu@webrtc.org
de305014c6 Update talk to 55906045. 
Review URL: https://webrtc-codereview.appspot.com/3159005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5065 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-31 15:40:38 +00:00
wu@webrtc.org
f424cb8e13 Update talk to 55863981. 
TBR=mallinath

Review URL: https://webrtc-codereview.appspot.com/3089006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5056 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-30 17:57:33 +00:00
wu@webrtc.org
cecfd1832d Update talk to 55821645. 
TEST=try bots
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/3139004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5053 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-30 05:18:12 +00:00
fischman@webrtc.org
9ca93a8b8e Explicitly @synthesize ObjC @properties 
This is required after https://code.google.com/p/gyp/source/detail?r=1768
turned on -Wobjc-missing-property-synthesis for ninja builds (until then it
was only enabled for xcode builds) to allow chromium_deps to roll in
webrtc/DEPS.

BUG=2560
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/3089004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5047 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-29 00:14:15 +00:00
pbos@webrtc.org
850bcbe855 Remove frame_callback.h include in webrtcvie.h. 
This file is about to be moved and it's not really needed. The class
I420FrameCallback is forward declared inside vie_image_process.h and
only used in talk/ for a no-op implementation that doesn't access the
pointer.

BUG=
R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/3039004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5041 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-28 15:41:17 +00:00
wu@webrtc.org
97077a3ab2 Update libjingle to 55618622. 
Update libyuv to r826.

TEST=try bots
R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2889004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5038 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-25 21:18:33 +00:00
wu@webrtc.org
d371a29227 Fix tsan failures for libjingle_unittest. 
1) Change AsyncSocket's SignalReadEvent and SignalWriteEvent's thread mode to multi_threaded_local as they can be accessed from different threads.
2) Protect NATServer::TransEntry::whitelist.
3) Protect PhysicalSocket:error_.

Detail failures can be seen from issue 2080, comment #5.

TBR=fischman@webrtc.org

RISK=P1
TEST=try bots and tsanv2
BUG=2080

Review URL: https://webrtc-codereview.appspot.com/2669005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5026 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-23 23:56:09 +00:00
wu@webrtc.org
8804a29951 Add CriticalSection to fakeaudiocapturemodule to protect the variables which will be accessed from process_thread_ and the main thread. 
TEST=try bots
BUG=1205
R=henrike@webrtc.org, kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2419004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5019 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-22 23:09:20 +00:00
wu@webrtc.org
4d7116be7a Fix tsan failures on filevideocapturer.cc. 
1) init start_time_ns_ before the file_read_thread_ is started to avoid data racing as the start_time_ns_ will also be read by the file_read_thread_.
2) add CriticalSection to protect |finished_| that is accessed by FileReadThread and the main thread

Also remove the suppression for filemediaengine.cc, which has already been fixed in other cl.

TBR=henrike@webrtc.org
TEST=try bots and manual tsan v2 test
BUG=2078

Review URL: https://webrtc-codereview.appspot.com/2509004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5018 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-22 18:41:17 +00:00
andrew@webrtc.org
31628aae7e Upgrade scoped_ptr to Chromium's latest version. 
Analogous to the recent libjingle change: http://cl/54929753-p10.
This supports scoped_ptr<T[]> and scoped_ptr<C, FreeDeleter> rather
than scoped_array and scoped_ptr_malloc respectively.

- Add Chromium's template-based COMPILE_ASSERT. We didn't have this
previously in order to support the macro in C. Instead, move the
existing macro to compile_assert_c.h.
- Additionally copy the move.h and template_util.h depedencies and add
the WARN_UNUSED_RESULT macro.
- Leave scoped_array and scoped_ptr_malloc for now, but mark as
deprecated.
- Remove scoped_ptr foo(NULL) use. The default constructor handles it.
- Remove the now redundant COMPILE_ASSERT from peerconnection_jni.cc.
- Add a CHECK_ARRAY_SIZE macro to rtp_format_vp8_unittest.cc to remove
some repeated code.

TESTED=trybots
R=pbos@webrtc.org, tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2449005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5015 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-22 12:50:00 +00:00
mallinath@webrtc.org
50bc553852 Reenable DTLS renegotiation unittest in libjingle. 
This test is failing on memcheck bots. After investigation problem per
say is not in this particular unittest and rather is in suite. So this test
is added to memcheck exclude list.

R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2689004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5011 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-21 17:58:35 +00:00
wu@webrtc.org
3c5d2b43ec Thread::Stop() must be called before any subclass's destructor completes. 
Update Thread documentation, fix all subclasses that had a problem.

This is to avoid a data racing between the destructor modifying the vtable, and
Thread::PreRun calling virtual method Run at the same time.

For example:
[ RUN      ] FileMediaEngineTest.TestGetCapabilities
==================
WARNING: ThreadSanitizer: data race on vptr (ctor/dtor vs virtual call) (pid=2967)
  Read of size 8 at 0x7d480000bd00 by thread T1:
    #0 talk_base::Thread::PreRun(void*) /mnt/data/b/build/slave/Linux_Tsan_v2/build/src/out/Release/../../talk/base/thread.cc:353 (libjingle_media_unittest+0x000000234da8)

  Previous write of size 8 at 0x7d480000bd00 by main thread:
    #0 talk_base::Thread::~Thread() /mnt/data/b/build/slave/Linux_Tsan_v2/build/src/out/Release/../../talk/base/thread.cc:158 (libjingle_media_unittest+0x00000023478c)
    #1 ~RtpSenderReceiver /mnt/data/b/build/slave/Linux_Tsan_v2/build/src/out/Release/../../talk/media/base/filemediaengine.cc:122 (libjingle_media_unittest+0x0000001b551f)
    ...

RISK=P2
TESTED=try bots and tsan
BUG=2078,2080
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2428004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4999 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-18 16:27:26 +00:00
fischman@webrtc.org
1c82037494 AppRTCDemo(android): remove vestigial mentions of PowerManager 
R=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2402004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4995 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-17 20:53:12 +00:00
wu@webrtc.org
1d1ffc9ad2 Update talk to 54898858. 
TEST=try bots
TBR=mallinath

Review URL: https://webrtc-codereview.appspot.com/2414004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4979 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-16 18:12:02 +00:00