Commit Graph

1587 Commits

Author SHA1 Message Date
turaj@webrtc.org
3c383abd27 Revert 2211 - Refactor the internal API to the rtp/rtcp module.
Review URL: https://webrtc-codereview.appspot.com/568004

A series of CL:s by Patrik W. is breaking the auto-test. It started with CL 2211, but the later CL:s seems dependent on another. So I decided to go in reverse order and revert all of them.

TBR=pwestin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/563011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2226 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-10 23:01:04 +00:00
turaj@webrtc.org
980d6be535 Revert 2212 - Bug fix
Review URL: https://webrtc-codereview.appspot.com/576009

A series of CL:s by Patrik W. is breaking the auto-test. It started with CL 2211, but the later CL:s seems dependent on another. So I decided to go in reverse order and revert all of them.

TBR=pwestin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/575009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2225 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-10 22:57:21 +00:00
turaj@webrtc.org
449b525453 Revert 2214 - Bugfix
A series of CL:s by Patrik W. is breaking the auto-test. It started with CL 2211, but the later CL:s seems dependent on another. So I decided to go in reverse order and revert all of them.

TBR
Review URL: https://webrtc-codereview.appspot.com/570007

TBR=pwestin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/571010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2223 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-10 22:54:39 +00:00
turaj@webrtc.org
f02ee061ab Revert 2215 - Fixed destroy order.
A series of CL:s by Patrik W. is breaking the auto-test. It started with CL 2211, but the later CL:s seems dependent on another. So I decided to go in reverse order and revert all of them.

TBR
Review URL: https://webrtc-codereview.appspot.com/564007

TBR=pwestin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/562008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2222 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-10 22:53:33 +00:00
turaj@webrtc.org
f448ccd16c Revert 2216 - Fix for receive only channels.
A series of CL:s by Patrik W. is breaking the auto-test. It started with CL 2211, but the later CL:s seems dependent on another. So I decided to go in reverse order and revert all of them.

TBR
Review URL: https://webrtc-codereview.appspot.com/564008

TBR=pwestin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/579011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2221 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-10 22:52:19 +00:00
leozwang@webrtc.org
8aaf31d14f Create makefile for video engine
Description:
This build.xml will enable video engine build on android by ant. As we discussed before,
in order to make video engine build based on current webrtc file structure which is not
normal, I created this customized build.xml which is based on build.xml in android SDK.

BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/571008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2219 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-10 18:16:27 +00:00
leozwang@webrtc.org
f29d3fa177 Fix vp8 complexity parameter on android
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/575007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2217 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-10 18:12:01 +00:00
pwestin@webrtc.org
a69634aa92 Fix for receive only channels.
TBR
Review URL: https://webrtc-codereview.appspot.com/564008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2216 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-10 16:17:05 +00:00
pwestin@webrtc.org
c309c7c52b Fixed destroy order.
TBR
Review URL: https://webrtc-codereview.appspot.com/564007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2215 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-10 15:49:45 +00:00
pwestin@webrtc.org
fd3fef514b Bugfix
TBR
Review URL: https://webrtc-codereview.appspot.com/570007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2214 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-10 15:14:41 +00:00
pwestin@webrtc.org
e1c97a2723 Bug fix
Review URL: https://webrtc-codereview.appspot.com/576009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2212 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-10 13:55:23 +00:00
pwestin@webrtc.org
0774838f3d Refactor the internal API to the rtp/rtcp module.
Review URL: https://webrtc-codereview.appspot.com/568004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2211 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-10 12:33:50 +00:00
bjornv@webrtc.org
cd54e56d72 Delay estimation performance test.
Added a test to verify estimation performance. Tested with audioproc_unittest and trybots.

BUG=issue435
TEST=None

Review URL: https://webrtc-codereview.appspot.com/569006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2209 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-10 07:41:23 +00:00
andrew@webrtc.org
270e9db039 Clarify the impact of disabling VAD on DTX.
TBR=henrika@webrtc.org
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/566009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2207 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-09 19:09:03 +00:00
leozwang@webrtc.org
b213cd55ef Remove bitmap implementation from surfaceview render
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/571004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2205 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-09 18:24:39 +00:00
leozwang@webrtc.org
de6a6b40fa Rename ViEAndroidDemo to WebRTCDemo
Desription:
This CL will change VideoEngine application name to ViEAndroidDemo. This
is the first step to refactor videoengine test application on android.

"ViE" is not a proper name because the app also supports audio. And it's good
to put WebRTC in application name.

BUG=
TEST=build on all trybots
Review URL: https://webrtc-codereview.appspot.com/576006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2204 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-09 15:23:52 +00:00
niklas.enbom@webrtc.org
f6edfeff63 Adding one parameter to typing detection tuning
Review URL: https://webrtc-codereview.appspot.com/569009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2203 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-09 13:16:12 +00:00
leozwang@webrtc.org
9f49af9cea Add libbitrate_controller which is introduced recently
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/571007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2202 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-09 04:46:24 +00:00
leozwang@webrtc.org
d63cf71413 Fix broken build because gyp doesn't filter out platform specific file with suffixes of .c
BUG=
TEST=test on all trybots, failed only on win_rel for weird error.
Review URL: https://webrtc-codereview.appspot.com/563009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2200 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-08 21:33:04 +00:00
andrew@webrtc.org
710eac763a Update DEPS comment and remove tabs from common.gypi.
TBR=wu@webrtc.org
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/575005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2198 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-08 18:00:57 +00:00
andrew@webrtc.org
22f6f85fcc Remove redundant initialization.
TBR=xians@webrtc.org
BUG=6140661
TEST=build on Linux

Review URL: https://webrtc-codereview.appspot.com/576005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2197 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-08 17:18:28 +00:00
andrew@webrtc.org
e59a0aca6a Fix AudioFrame types.
volume_ is not set anywhere so I'm removing it.

BUG=
TEST=trybots

Review URL: https://webrtc-codereview.appspot.com/556004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2196 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-08 17:12:40 +00:00
leozwang@webrtc.org
f5fe1000de Enable cpu auto detection and ns optimized code on android
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/547006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2195 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-08 15:20:02 +00:00
hta@webrtc.org
9cc186405f Removed CleanUp call in Windows, since I couldn't find a call to it.
This solves Coverity issue 14424 by deleting the code.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/579005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2194 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-08 11:40:06 +00:00
mflodman@webrtc.org
e553031580 Refactore base, Capture, Codec and Custom Call parts of autotest. The CL doesn't contain any real functional changes, only style changes, cast changes and changing reference to pointer as input argument to functions.
Custome call still doesn't pass cpplint, but I'll take that in another CL to not change the structure in the style change CL.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/523001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2193 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-08 10:38:36 +00:00
braveyao@webrtc.org
113f851cc3 Merge Chromium issue 95797 into WebRTC.
Bug = 450
Test = Manual test
Review URL: https://webrtc-codereview.appspot.com/551004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2192 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-08 09:28:39 +00:00
pwestin@webrtc.org
7415f371ac Revert VP8 Deblocker.
Review URL: https://webrtc-codereview.appspot.com/563007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2191 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-08 09:06:31 +00:00
pwestin@webrtc.org
5019c9583c Enable VP8 deblocker.
Review URL: https://webrtc-codereview.appspot.com/578004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2190 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-08 08:40:28 +00:00
andrew@webrtc.org
589673f1cb Fix volume setting while not playing on PulseAudio.
We now only set the volume when starting playout if the user has called
SetSpeakerVolume while we weren't playing. This now also ensures it will
actually get set to what the user requested rather than being overridden
by a default value.

Add tests to voe_auto_test.

BUG=6140661
TEST=voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/566006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2188 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-07 21:42:49 +00:00
leozwang@webrtc.org
20a05cd778 Disable WEBRTC_SVNREVISION
Description:
This CL will temporally define WEBRTC_SVNREVISION as "n/a" because it
could break Chromium if svn is not installed.
The long term solution is a have a script that could deal with it, and
have it support git-svn which is used by most developers.

BUG=496
TEST=build on Linux
Review URL: https://webrtc-codereview.appspot.com/569007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2187 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-07 21:16:33 +00:00
turaj@webrtc.org
fe4cfa7e5e Hi Tina,
I have uploaded this patch for your review. I have done an extensive test to be sure that removing of tables does not create any problem. 

The test file, is called test_lpc.c which requires a hack to standard iSAC. The test computes LPC coefficients, then encodes and decodes with old and new (size-reduced) tables. It compares the results is all steps. I have ran the test over large set of files, more then 51 hours of audio, and there was no error. 

I tried to do no formatting so the review to be easier, but I know it can be a tricky CL. Hopefully, the test file helps you to be more confident on the CL. 

Thanks,... Turaj  

In this change list the LPC tables associated with mode 1 & 2 are remoded, and necessary cahnges are made to other files. 

The only model allowed is model number 0. Therefore, this CL breaks compatibility with iSAC released prior to 2.4.3. To avoid changing the bit-stream, we still keep the model number in the bit-stream. 

entropy_coding.c is cleaned up, especially encoding of LAR had KLT transform of LPC gains which are removed now. 
Review URL: https://webrtc-codereview.appspot.com/548004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2186 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-07 20:36:22 +00:00
leozwang@webrtc.org
d46fe7034b Two bug fixs in android surface render
Descritption:
This CL addresses two issues in android surface view render,
1. Uninitlized class members _javaByteBufferObj and _directBuffer which
   could cause crash.
2. Using ConvertI420ToRGB565. We should use high level libyuv apis
   to help libyuv maintainer.

BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/566005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2185 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-07 20:29:43 +00:00
braveyao@webrtc.org
ba0f9fe10b Trival fix to voe_auto_test according to the main source codes
BUG = NULL
TEST = voe_auto_test
Review URL: https://webrtc-codereview.appspot.com/554004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2184 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-07 10:06:43 +00:00
phoglund@webrtc.org
f5657efd31 Rolled back r2177 since it breaks vie_auto_test.
I'm not sure what is the right thing to do here. That would probably be to call Release() the right amount of times and ensuring that the last call returns 0 (e.g. all references have been released), but I'll leave it up to the CL author to investigate that.

TBR=elham@webrtc.org
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/569005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2183 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-07 07:59:32 +00:00
andrew@webrtc.org
07bf9a07f5 Add test to verify identical input channels result in identical output channels.
BUG=issue411
TEST=audioproc_unittest, trybots

Review URL: https://webrtc-codereview.appspot.com/553009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2182 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-05 00:32:00 +00:00
leozwang@webrtc.org
329fcbba29 Reduce PSNR because I420ToARGB888 return lowers number on windows
TBR=stefan, marpan

BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/562005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2178 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-04 21:31:22 +00:00
elham@webrtc.org
c2f8832a32 Fix for FileTest failure in vie_auto_test
Review URL: https://webrtc-codereview.appspot.com/570004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2177 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-04 21:17:30 +00:00
leozwang@webrtc.org
1ea25b4c3d Change PSNR for I420ToARGB888 and I420ToRGB565
TBR=stefan, marpan

BUG=
TEST=test on linux
Review URL: https://webrtc-codereview.appspot.com/569004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2176 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-04 17:55:57 +00:00
leozwang@webrtc.org
83958dfe06 Add ARGB and RGB565 unit test
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/563004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2175 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-04 17:07:45 +00:00
leozwang@webrtc.org
3ebff4c2e9 Add ConvertToARGB and enable RGB565
Review URL: https://webrtc-codereview.appspot.com/566004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2174 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-04 17:07:30 +00:00
leozwang@webrtc.org
e62fec2285 Bug fix and refactor video capture code on android
BUG=
TEST=test on android
Review URL: https://webrtc-codereview.appspot.com/541009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2173 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-04 17:06:32 +00:00
hta@webrtc.org
b6f2417f37 Renamed all _test.cc files to _unittest.cc, to conform to convention
for webrtc.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/560004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2172 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-04 08:13:57 +00:00
leozwang@webrtc.org
8b6f749b0a Rewrite makefile to link with stl statically
By doing this way, webrtc.so doesn't depend on stlport_shared

BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/546005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2170 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-03 16:07:15 +00:00
hta@webrtc.org
54536bb6d4 Refactoring of the TMMBRSet class, giving it a reasonably tight interface.
The CL also fixes a number of line length and tab issues in touched files.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/553005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2168 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-03 14:07:23 +00:00
pwestin@webrtc.org
3bc38c86e8 Fix color enhancement test.
Review URL: https://webrtc-codereview.appspot.com/553007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2167 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-03 13:15:35 +00:00
pwestin@webrtc.org
209442a560 Missing file
Review URL: https://webrtc-codereview.appspot.com/556005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2166 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-03 11:36:06 +00:00
pwestin@webrtc.org
e9727cdbaa Fixed some memory leaks.
Review URL: https://webrtc-codereview.appspot.com/558004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2165 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-03 11:32:25 +00:00
andrew@webrtc.org
63a509858d Rename AudioFrame members.
BUG=
TEST=trybots

Review URL: https://webrtc-codereview.appspot.com/542005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2164 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-02 23:56:37 +00:00
leozwang@webrtc.org
7fdb909339 Reformat and add more debug info into ViESurfaceRenderer
BUG=
TEST=test on android
Review URL: https://webrtc-codereview.appspot.com/546004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2163 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-02 16:45:55 +00:00
bjornv@webrtc.org
b286bfb13e VAD refactoring: Replaced hard coded array sizes with enum.
Further replaced hard coded calculations with a for loop for better understanding.

Tested with vad_unittests and audioproc_unittest.

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/519002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2162 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-02 12:14:57 +00:00
hta@webrtc.org
404843e6e5 Timeout tests for TMMBR
Added a test that injects 3 packets and then times out.

Rewrote the packet construction in test to use a builder format.
This makes tests a lot more readable.

Odd behaviour of timeout found; documented as test.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/553004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2161 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-02 09:56:45 +00:00
hta@webrtc.org
3c0df7d376 Fixed a build break: I'd forgotten to remove a DELETE statement.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/555004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2160 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-02 08:22:21 +00:00
hta@webrtc.org
47059b5dfb Adds unit tests for RTCP receiver, focusing on TMMBR handling.
This is the first part of a plan:

- Get basic unit tests for rtcp_receiver.
- Get an unit test for some code inside rtcp_receiver
  that touches the TMMBRSet class in hard-to-decipher ways
  (rtcp_receiver_help, GetTMMBRSet function, use of memmove()).
- Refactor the TMMBRSet class.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/547005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2159 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-02 07:46:22 +00:00
phoglund@webrtc.org
719dba7e79 Further cleaned up voe_standard_test.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/522003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2157 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-02 07:32:37 +00:00
andrew@webrtc.org
ecac9b721e Add tests for downmixing and no processing.
BUG=issue419
TEST=audioproc_unittest

Review URL: https://webrtc-codereview.appspot.com/532001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2154 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-02 00:04:10 +00:00
leozwang@webrtc.org
63ea5ef5da Regenerate jni files and bring audio alive
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/550004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2153 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-01 22:13:49 +00:00
andrew@webrtc.org
d5548f5d04 Disable clang Chrome plugins on all platforms.
(Will fix Linux-clang bot).

TBR=wu@webrtc.org
BUG=issue163
TEST=build on Linux-clang

Review URL: https://webrtc-codereview.appspot.com/545005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2152 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-01 21:39:34 +00:00
leozwang@webrtc.org
85b089a0ca Fix ConvertI420ToRGB565 bug
BUG=
TEST=test on android
Review URL: https://webrtc-codereview.appspot.com/541005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2150 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-30 17:59:08 +00:00
leozwang@webrtc.org
e7ac5fde72 Minor changes to remove dead code in opensl es
BUG=
TEST=build on all platforms
Review URL: https://webrtc-codereview.appspot.com/539004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2149 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-30 14:42:17 +00:00
hta@webrtc.org
65a4e4ed56 Minor refactoring: RTCPReceiver::BoundingSet
Remove ability to modify a pointer argument.

Added a test for transmitting a non-empty TMMBN

BUG=
TEST=unittest

Review URL: https://webrtc-codereview.appspot.com/542004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2148 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-30 11:23:41 +00:00
hta@webrtc.org
c2d985257b untabify
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2145 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-30 08:25:10 +00:00
hta@webrtc.org
9d54cd12ab TMMBN sender test passes, fixed receiver flag bug
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2144 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-30 08:24:55 +00:00
andrew@webrtc.org
5c0c18d823 Fix coverity issues in ACM.
Fixes: Big parameter passed by value (PASS_BY_VALUE)
Passing parameter codec of size 52 bytes by value.

BUG=
TEST=audio_coding_module_tests, trybots

Review URL: https://webrtc-codereview.appspot.com/529002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2142 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-27 17:06:48 +00:00
andrew@webrtc.org
a88cb6fce0 Add HighPassFilter and StereoChannelSwapping tests.
BUG=issue451
TEST=voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/531001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2141 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-27 17:00:20 +00:00
marpan@webrtc.org
2d0223286b VPM: fix to coverity issues 10255-10258 (unintended sign extension).
Review URL: https://webrtc-codereview.appspot.com/532002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2140 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-27 15:56:02 +00:00
phoglund@webrtc.org
ca08c41701 Replacing virtual camera on linux video bot: adaptings tests accordingly.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/537001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2139 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-27 12:38:17 +00:00
pwestin@webrtc.org
b1313aac7c Fix missing h file change.
Review URL: https://webrtc-codereview.appspot.com/535001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2136 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-27 05:42:05 +00:00
pwestin@webrtc.org
49888ce428 Breaking out send side bitrate controll cont.
Review URL: https://webrtc-codereview.appspot.com/475004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2135 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-27 05:25:53 +00:00
mallinath@webrtc.org
e611619f60 Fixing the header file path in gypi file.
BUG=473
Review URL: https://webrtc-codereview.appspot.com/529001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2134 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-26 23:03:15 +00:00
andrew@webrtc.org
9c4f6a5ff9 Add an AudioFrameOperations unittest.
Additionally, reformat audio_frame_operations to Goog style.

BUG=issue451
TEST=voice_engine_unittests

Review URL: https://webrtc-codereview.appspot.com/528001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2133 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-26 22:32:03 +00:00
tommi@webrtc.org
e49d908baf Fix how we were using TbInterfaces and disallow operator=() and the copy constructor.
The reason is that this will cause a crash:

TbInterfaces foo = TbInterfaces("blah");


It relies on the generated copy constructor (or assignment operator), which copies the
pointer values from a temporary object.  After |foo| in this case has been initialized
with values from the temporary object, the temp goes out of scope and is deleted.
The result is that |foo| has been initialized with pointers do a deleted object.

Also fixing expectations for the return value of VoE Release() calls after I checked
in my change that makes the VoiceEngine per-object ref counted and not per-interface.
Review URL: https://webrtc-codereview.appspot.com/509005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2128 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-26 17:05:32 +00:00
tommi@webrtc.org
a990e122c4 * Change the reference counting implementation for VoE to be per object and
not per interface. This simplifies things a bit, reduces code and makes it
  possible to implement reference counting (if we ever want) without the
  static Delete() method.  (Reference counted objects are traditionally
  implicitly deleted via the last Release())

* Since the reference counting code is now simpler, there's no need for the
  RefCount class so I'm removing it.

* Also removing the optional |ignoreRefCounters| variable from the VoiceEngine::Delete
  method.  The justification is that it's no longer used and the reason it was there
  in the first place was to avoid bugs in third party code, so it's an indication that
  something is wrong elsewhere.

* Fix a crash in voe_network_impl and voe_extended_test that would happen on machines with IPv6 support.

* Fix an assert (handle the case) in the extended audio tests when SetCNAME is called with a NULL pointer.

* As a side effect of this change, hopefully the footprint of VoE will be slightly smaller :)

BUG=10445 (Coverity)
Review URL: https://webrtc-codereview.appspot.com/521003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2127 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-26 15:28:22 +00:00
phoglund@webrtc.org
497fb4fda9 Fixed vie_auto_test on mac so it will exit when the test completes instead of hanging like it used to.
Also applied an old patch I had which rewrites the window handling to do ui stuff on the main thread instead of the worker thread, which as far as I know is a very bad idea.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/502001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2126 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-26 12:58:02 +00:00
tina.legrand@webrtc.org
bc1b43b297 Refactoring of audio_coding_module_impl
First patch set: pure formatting.

Review URL: https://webrtc-codereview.appspot.com/522001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2125 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-26 08:53:45 +00:00
tina.legrand@webrtc.org
a6ecd1ebb5 Refactoring one of the ACM tests: TestStereo, to follow the style guide.
(First patch: formatting the test file)

TEST=audio_coding_module_test

Review URL: https://webrtc-codereview.appspot.com/507001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2124 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-26 07:54:30 +00:00
mflodman@webrtc.org
1868780c81 Disabled UnremovedSocketsGetCollectedAtManagerDeletion in UdpSocketManager unittest.
TBR= hta@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/520004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2122 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-26 06:40:00 +00:00
andrew@webrtc.org
1c7bfe02f7 Fail silently when swapping mono.
TBR=tina.legrand@webrtc.org
BUG=issue451
TEST=forthcoming unittest

Review URL: https://webrtc-codereview.appspot.com/527003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2121 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-26 00:20:28 +00:00
hta@webrtc.org
ad929899c7 Tests for udp_socket_manager.
These tests basically check that socket allocation does not leak memory.

BUG=
TEST=unittested, ran under valgrind.

Review URL: https://webrtc-codereview.appspot.com/519003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2118 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-25 14:06:50 +00:00
asapersson@webrtc.org
d18dd6dc7e Made OnPacketLossStatisticsUpdate function virtual (needed for ViCE).
Review URL: https://webrtc-codereview.appspot.com/520002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2115 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-25 07:19:02 +00:00
andrew@webrtc.org
02d7174722 Add API to swap stereo channels.
BUG=issue451
TEST=manually with voe_cmd_test, using stereo and mono codecs

Review URL: https://webrtc-codereview.appspot.com/519001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2106 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-24 19:47:00 +00:00
andrew@webrtc.org
369166a179 Add API for disabling the high pass filter.
BUG=issue419
TEST=manually with voe_cmd_test

Review URL: https://webrtc-codereview.appspot.com/509003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2105 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-24 18:38:03 +00:00
leozwang@webrtc.org
48a5df6481 Embed svn revision number into code
BUG=
TEST=build on linux
Review URL: https://webrtc-codereview.appspot.com/516001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2104 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-24 14:50:50 +00:00
elham@webrtc.org
5f49dba1a1 Hi Magnus, I added some of the changes that you suggested before. Let me know what you think.
Review URL: https://webrtc-codereview.appspot.com/507004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2101 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 21:24:02 +00:00
andrew@webrtc.org
4e423b3b1e Handle master/slave timestamp wrap.
BUG=issue410
TEST=neteq_unittests, audio_coding_module_test

Review URL: https://webrtc-codereview.appspot.com/506001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2098 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 18:59:00 +00:00
vikasmarwaha@webrtc.org
99ac3f7be5 Fixed trunacated trace problem in WebRTC. http://b.corp.google.com/issue?id=5607856
Review URL: https://webrtc-codereview.appspot.com/508004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2096 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 17:04:35 +00:00
pwestin@webrtc.org
ddab60be56 Wire up pading.
Review URL: https://webrtc-codereview.appspot.com/509002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2094 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 14:52:15 +00:00
bjornv@webrtc.org
11654c2344 VAD refactoring: Local variable name changes
Changes tested with vad_unittests and audioproc_unittest

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/485004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2093 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 14:50:11 +00:00
mflodman@webrtc.org
5284d6e905 Minor change to trigger REMB packets in RTCP RR if there is no sending channel.
BUG=
TEST=video_engine_core_unittest

Review URL: https://webrtc-codereview.appspot.com/508007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2092 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 13:22:26 +00:00
hta@webrtc.org
bf9f469a13 Lifetime management for UdpSocketManager
Make tests use Create/Destroy *or* new/delete for UdpSocketManager.
Move responsibility for calling Destroy on UdpSocketManager from transport
destructor to transport Destroy function.

This all ends up in not leaking memory in InitializeSourcePorts test.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/512001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2091 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 13:19:30 +00:00
asapersson@webrtc.org
92591adc67 Fixes link issues in google3 (change by tomasl).
Review URL: https://webrtc-codereview.appspot.com/509001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2090 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 13:10:55 +00:00
asapersson@webrtc.org
83ed0a4359 Try to resend next packet in nack list even if previous packet is not found.
Review URL: https://webrtc-codereview.appspot.com/515001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2089 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 12:43:05 +00:00
pwestin@webrtc.org
fcbbe1f341 Removed unused callback code from video coding test.
Review URL: https://webrtc-codereview.appspot.com/504003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2086 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 08:33:18 +00:00
pwestin@webrtc.org
a2cd732139 Fix for calling OnNetworkChanged too often.
Review URL: https://webrtc-codereview.appspot.com/508006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2085 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 08:32:47 +00:00
marpan@webrtc.org
88ad06b999 VCM: Added condition(s) for setting FEC protection factor to zero at low bitrates.
Review URL: https://webrtc-codereview.appspot.com/494001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2084 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-20 16:05:24 +00:00
asapersson@webrtc.org
63a34f4f29 Fix in SendPadData. Do not increase sequence number if packet is "empty" and not sent.
Review URL: https://webrtc-codereview.appspot.com/508001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2083 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-20 13:20:27 +00:00
phoglund@webrtc.org
bb77000123 Added a virtual destructor to get the test to compile on all platforms.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/507003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2082 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-20 13:03:12 +00:00
phoglund@webrtc.org
b73f01e7fd Removed some obviously dead stuff from voe_auto_test.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/495001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2081 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-20 10:59:31 +00:00
hta@webrtc.org
bbd6b561cf Memory leak fix: Deleting a factory
Also expanded some documentation.
Bug found by Valgrind bot.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/507002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2080 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-20 09:51:26 +00:00
bjornv@webrtc.org
bcde776340 Changed Delay Estimator create call
Unit tests updated and runs.
Change made w.r.t. issue 441.

BUG=Issue441
TEST=None

Review URL: https://webrtc-codereview.appspot.com/498001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2079 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-20 09:35:20 +00:00
hta@webrtc.org
0abe535e16 Refactored udp_transport to take socket manager as dependency injection
This avoids having to deal with the socket manager in the unittest.

Extended tests to cover one case where sockets got allocated.

BUG=
TEST=unittest

Review URL: https://webrtc-codereview.appspot.com/496001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2078 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-20 08:23:16 +00:00