Commit Graph

1587 Commits

Author SHA1 Message Date
leozwang@webrtc.org
351fb6d3b4 Exclude code that don't work on android in voe_cmd_test
Description:
Ths cl makes voe_cmd_test work on android by excluding some code
that are availabel on android today, some highlights
1. change maxnumofchannles
2. disable audio device selection
3. disable set/get volume

BUG=
TEST=test on try bots
Review URL: https://webrtc-codereview.appspot.com/584009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2300 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-25 16:47:35 +00:00
turaj@webrtc.org
10d3b5239b I haven't done any refactoring here.
Resolve coverity warnings.

14305.

The warning is not really valid. The 'decode' function should be called with a 'mode' variable, where inside the function it is assumed that mode is either zero or one. If mode is taking other values some varibles are used uninitialized. However, this is an internal function and it is always called with either ZERO or ONE. Therefore, the code operates correctly. I made small changes as I beleive it is a bit nicer way. 

In ACM:
- Conditions on 'mode' is changed.


Tested with trybots.

BUG=None
TEST=None
Review URL: https://webrtc-codereview.appspot.com/564014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2297 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-24 21:20:25 +00:00
andrew@webrtc.org
f45d47ad7d Remove mixing tests from voe_extended_test.cc
These have been moved to:
src/voice_engine/main/test/auto_test/standard/mixing_test.cc

BUG=
TEST=build voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/588005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2296 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-24 17:27:59 +00:00
andrew@webrtc.org
51b4f3e6a8 Try to fix MixingTest on the Win bots.
- Relax the constraints on recording duration.
- Remove unneeded file deletes. (These files will be properly
  overwritten anyway).

TBR=henrike@webrtc.org
BUG=issue534
TEST=voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/600006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2295 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-24 17:26:05 +00:00
stefan@webrtc.org
42e78ac087 Disable normal_async_test and rename tests to vp8_integrationtests.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/598004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2294 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-24 14:36:34 +00:00
mflodman@webrtc.org
6af9594d71 Added gyp variable to include/exclude all tests.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/597004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2292 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-24 13:23:35 +00:00
niklas.enbom@webrtc.org
ee646c37d4 I know this is ugly, but it helps a lot to quickly update webRTC in Chrome and libJingle.
Review URL: https://webrtc-codereview.appspot.com/596004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2290 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-24 11:41:02 +00:00
pwestin@webrtc.org
2d1fc9bf17 Added critical section to prevent race.
Review URL: https://webrtc-codereview.appspot.com/595004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2289 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-24 11:28:31 +00:00
pwestin@webrtc.org
5c3a400fae Re-added ChangeUniqueId temporary for chrome.
Review URL: https://webrtc-codereview.appspot.com/594004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2287 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-24 09:52:19 +00:00
andrew@webrtc.org
7fbfc4ce79 Use correct variable in trace.
TBR=leozwang@webrtc.org
TEST=build

Review URL: https://webrtc-codereview.appspot.com/593004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2284 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-23 22:22:36 +00:00
andrew@webrtc.org
f98b6cc10e Remove noise during build on Win32
TBR=niklas.enbom@webrtc.org
BUG=chromium:126483

Review URL: https://webrtc-codereview.appspot.com/590006
Patch from Scott Graham <scottmg@chromium.org>.

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2283 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-23 18:49:47 +00:00
hta@webrtc.org
40300131dc No more TSAN errors on start_stop
A very pedestrian approach to making TSAN stop complaining about the state variables: Wrap them in a critical section.
More creative approaches can be considered.

(not sure if diffbase works here, but...)
DIFFBASE=583008

BUG=webrtc:300
TEST=

Review URL: https://webrtc-codereview.appspot.com/584008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2282 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-23 15:49:48 +00:00
turaj@webrtc.org
ea0aa13aa8 I haven't done any refactoring here.
Resolve coverity warnings.

14240, 14241.

In ACM:
- NULL pointer sanity checks corrected.

Tested with trybots.

BUG=None
TEST=None
Review URL: https://webrtc-codereview.appspot.com/571012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2281 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-23 15:43:51 +00:00
andrew@webrtc.org
9dc45dad1b Move trunk/test/data -> trunk/data
BUG=
TEST=all trybot test failures passed locally

Review URL: https://webrtc-codereview.appspot.com/583007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2280 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-23 15:39:01 +00:00
hta@webrtc.org
1484ac07cb Replaced 2 time functions with thread-safe equivalents
This does not fix bug 544, but changes where it reports issues.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/578008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2279 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-23 15:39:17 +00:00
stefan@webrtc.org
78d8d99180 Fixes the vp8_test on Linux.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/579015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2277 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-23 14:18:56 +00:00
bjornv@webrtc.org
cb0a86e913 VAD refactoring: Added function for repeated code.
Added WeightedAverage() to calculate global mean. This removes hard coded Gaussian model size and repeated code.

Tested with vad_unittests, audioproc_unittest and trybots.

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/571006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2275 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-23 07:56:51 +00:00
andrew@webrtc.org
a1a34d675f Avoid flakiness by skipping more output verification.
- Add a SCOPED_TRACE in case it flakes out again.
- The test doesn't need to be very long, so shorten it to save the bots some time.

TBR=henrike@webrtc.org
BUG=
TEST=voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/588006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2273 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-23 00:45:00 +00:00
hta@webrtc.org
6ed617be22 Fixing memory leak error in test.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/571013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2272 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-22 16:55:16 +00:00
marpan@webrtc.org
747cd87da1 FEC: For multi-frame FEC, allow for the size of the code to be increased,
under certain conditions. This generally improves the FEC recovery for 
     bursty loss under medium-high protection level.
Review URL: https://webrtc-codereview.appspot.com/566012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2271 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-22 16:50:00 +00:00
hta@webrtc.org
e1919f41b7 Unittest for thread_wrapper.
Added an explanation of the state variables of posix, wrote a simple test.
This might help in fixing the TSAN issue with thread.

BUG=webrtc:300
TEST=

Review URL: https://webrtc-codereview.appspot.com/583008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2270 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-22 15:57:34 +00:00
pwestin@webrtc.org
0d71c1cfe0 Cleanup code.
Review URL: https://webrtc-codereview.appspot.com/569021

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2269 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-22 14:23:25 +00:00
astor@webrtc.org
e231c61ba7 Style guide reformatting of overuse_detector.{h,cc}
Review URL: https://webrtc-codereview.appspot.com/575006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2268 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-22 12:24:00 +00:00
mflodman@webrtc.org
7597a85bc4 Changed merge-name.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/584007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2266 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-22 08:32:20 +00:00
andrew@webrtc.org
294be77c2e Permit mixing mono and stereo streams.
Add mixing tests based on older ones from the extended tests.

BUG=issue534
TEST=manual, voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/576014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2265 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-22 03:28:41 +00:00
pwestin@webrtc.org
b2179c20f0 Bugfix issue 533. Client does not handle NACK or PLI requests received from far end if a RTCP report from it has not been processed when RFC 5506 is enabled.
Review URL: https://webrtc-codereview.appspot.com/569020

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2263 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-21 12:00:49 +00:00
stefan@webrtc.org
1bca6d2437 Fixes coverity warnings.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/566014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2262 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-21 07:42:12 +00:00
andrew@webrtc.org
b3bea2eb3e Fix build errors on OS X Lion.
TBR=henrika@webrtc.org
TEST=build on Lion, trybots
Review URL: https://webrtc-codereview.appspot.com/583005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2261 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-18 19:02:42 +00:00
leozwang@webrtc.org
e3ba738ba3 Set OpenGL as the default renderer
Description:
This cl sets OpenGL as the default renderer which is widely used and should
be test first

BUG=
TEST=test on android
Review URL: https://webrtc-codereview.appspot.com/573007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2260 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-18 17:07:49 +00:00
leozwang@webrtc.org
ada5db4e75 Enable aecm neon optimized code in android build
Description:
This CL is a follow up of http://review.webrtc.org/575008/ and r2241.
Because of r2243, r2241 is messed up and reverted, I'm going to commit it again.
This is exact same to the last patch in 575008, just want to inform you and have
your double check before I commit it.

The original description
This cl enables cpu detection and aecm optimized code in android build.

BUG=
TEST=build on all platforms
Review URL: https://webrtc-codereview.appspot.com/568006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2259 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-18 16:48:45 +00:00
phoglund@webrtc.org
1ad477de3e Added a bit flip fuzz test to the voice engine.
Extracted encryption classes to a new test library.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/564009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2256 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-18 08:02:37 +00:00
leozwang@webrtc.org
00c07e66a7 Fix a random crash because of NULL point
Description:
This cl fixes NULL point crash problem which was not detected runtime.
Also, small reformats are added too.

BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/579009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2254 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-16 16:57:28 +00:00
leozwang@webrtc.org
4d7d23cde4 Refactor OpenGL Code
Description:
This CL refactored OpenGL java code. Most of code referenced sample code.
And bug-fix and reformats are added into this cl too.

BUG=
TEST=build and test on android
Review URL: https://webrtc-codereview.appspot.com/583004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2253 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-16 16:57:15 +00:00
hta@webrtc.org
3a698651d7 Coverity issue 14317 (uninitialized status may influence execution flow)
Solution: restructure the flow when AquireSocket fails

BUG=coverity:14317
TEST=trybot

Review URL: https://webrtc-codereview.appspot.com/573006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2252 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-16 14:28:52 +00:00
kjellander@webrtc.org
7e4a72a78a Revert 2241 - Enable aecm neon optimized code in android build
Description:
This cl enables cpu detection and aecm optimized code in android build.

BUG=
TEST=build on all platforms
Review URL: https://webrtc-codereview.appspot.com/575008

TBR=leozwang@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/566013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2249 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-16 11:49:45 +00:00
kjellander@webrtc.org
0290a7a827 Revert 2243 - Re-enable embedding svn revision into code
Description:
By using a python scription, this cl tries to get svn revision properly. It
current support git-svn and svn, if it fails, "n/a" will be defined as
svn revision.


BUG=500
TEST= test cases: w/o svn, w/o git-svn. test platforms, linux/windows. Passed all trybots.
Review URL: https://webrtc-codereview.appspot.com/564010

TBR=leozwang@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/577008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2248 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-16 11:39:14 +00:00
hta@webrtc.org
d429086f62 Deleted udp_socket_windows and all references to it.
This fixes a couple of Coverity issues, and doesn't impact any tested
platforms.

BUG=Coverity:14423
TEST=trybots

Review URL: https://webrtc-codereview.appspot.com/564012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2247 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-16 09:32:14 +00:00
tina.legrand@webrtc.org
86da94ea69 Remove functions for unregistering decoder
This cl removes unused functions in the ACMGenericCodec class.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/568005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2245 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-16 07:11:53 +00:00
leozwang@webrtc.org
d2d54c72b6 Improve WebRTCDemo
Description:
This cl basically bring video and audio alive and add couple features to
existing demo application,
1. Remove "stats" tab, add on screen stats display
2. Add a button to select surfaceview or opengl render
Also some reformat and minor bug-fixes are included

BUG=
TEST=build on android
Review URL: https://webrtc-codereview.appspot.com/579010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2244 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-16 03:18:23 +00:00
leozwang@webrtc.org
f6e27f5e03 Re-enable embedding svn revision into code
Description:
By using a python scription, this cl tries to get svn revision properly. It
current support git-svn and svn, if it fails, "n/a" will be defined as
svn revision.


BUG=500
TEST= test cases: w/o svn, w/o git-svn. test platforms, linux/windows. Passed all trybots.
Review URL: https://webrtc-codereview.appspot.com/564010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2243 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-15 19:25:37 +00:00
kma@webrtc.org
f1ccdb9fb5 Aligned video buffer to 32 bytes boundary, when using vpx_img_alloc() in vp8.
Review URL: https://webrtc-codereview.appspot.com/570009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2242 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-15 18:16:46 +00:00
leozwang@webrtc.org
fe742200d5 Enable aecm neon optimized code in android build
Description:
This cl enables cpu detection and aecm optimized code in android build.

BUG=
TEST=build on all platforms
Review URL: https://webrtc-codereview.appspot.com/575008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2241 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-15 16:11:24 +00:00
marpan@webrtc.org
cf2cd7e4c4 Enable VP8 deblocker.
Review URL: https://webrtc-codereview.appspot.com/569011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2237 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-14 16:50:36 +00:00
hta@webrtc.org
93116ba4fc Added an unittest for udp_socket_wrapper.
This involves checking what the reasonable call sequences for deleting a
socket is; documented the API for this by making the destructor protected.
Checked out that the behaviour of undeleted sockets is inconsistent across
platforms, and changed the udp_socket_manager_unittest accordingly.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/578007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2236 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-14 16:03:37 +00:00
kma@webrtc.org
4e7840d943 Revert 2233 - Aligned video buffer to 32 bytes boundary, when using vpx_img_alloc() in vp8.
M    vp8.cc



TBR=kma@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/579013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2234 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-11 18:16:35 +00:00
kma@webrtc.org
6d47c08e14 Aligned video buffer to 32 bytes boundary, when using vpx_img_alloc() in vp8.
M    vp8.cc



git-svn-id: http://webrtc.googlecode.com/svn/trunk@2233 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-11 17:29:59 +00:00
pwestin@webrtc.org
2853dde520 Refactor the internal API to the rtp/rtcp module.
Combination of previous CLs in revisions 2211, 2212, 2214, 2215, 2216.
Review URL: https://webrtc-codereview.appspot.com/570008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2231 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-11 11:08:54 +00:00
phoglund@webrtc.org
5dbe568417 Disabled flaky tests. Standard tests will no longer run within extended tests.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/578006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2230 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-11 08:59:11 +00:00
bjornv@webrtc.org
61d0745e86 Resolve coverity warnings.
14050, 14051, 14243, 14314

In APM:
- Uninitialized variable initialized.
- NULL pointer sanity checks corrected.

Tested with trybots and audioproc_unittest.

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/571009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2229 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-11 07:51:44 +00:00
phoglund@webrtc.org
7eadad6d95 Fixed valgrind errors so the fuzz test can be run under valgrind.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/576008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2228 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-11 07:36:53 +00:00