generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
7,960 Commits 1 Branch 0 Tags
2d25b44f470afdd56513b75d641166f6e7cdcd04
Commit Graph

497 Commits

Author SHA1 Message Date
changbin.shao@webrtc.org
2d25b44f47 Check associated payload type when negotiate RTX codecs. 
At the moment, only payload name is checked when match two RTX codecs.
This will cause wrong behavior of codec negotiation if multiple RTX codecs
are added.

BUG=
R=pthatcher@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/34189004

Cr-Commit-Position: refs/heads/master@{#8727}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8727 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-16 04:15:23 +00:00
tommi@webrtc.org
c29f7f3a5f Disable assert for nr of threads in PeerConnectionTest.java. 
This test is flaky so we need to figure out a better way to do it.
I've documented what we've observed and added a todo for myself to figure out a solution.

R=kjellander@webrtc.org
BUG=4424

Review URL: https://webrtc-codereview.appspot.com/46599004

Cr-Commit-Position: refs/heads/master@{#8725}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8725 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-14 18:15:47 +00:00
jiayl@webrtc.org
d83f4eff84 Fix an issue in DtlsIdentityStore when the store is destroyed before the worker thread task returns. 
BUG=crbug/464995
R=pthatcher@webrtc.org

Committed: https://code.google.com/p/webrtc/source/detail?r=8689

Committed: https://code.google.com/p/webrtc/source/detail?r=8701

Committed: https://code.google.com/p/webrtc/source/detail?r=8706

Review URL: https://webrtc-codereview.appspot.com/42659004

Cr-Commit-Position: refs/heads/master@{#8722}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8722 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-13 21:26:44 +00:00
pthatcher@webrtc.org
b01c707209 Use a NULL session in unit tests that don't actually use the session. 
This is a part of the big BUNDLE implementation at https://webrtc-codereview.appspot.com/45519004/

R=decurtis@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/49379004

Cr-Commit-Position: refs/heads/master@{#8721}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8721 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-13 20:05:46 +00:00
pthatcher@webrtc.org
b4aac13810 Cleanup SocketMonitor a little so that it can handle a change in transport channel. And cleanup some names and style and such as well. 
This is a part of the big BUNDLE implementation at https://webrtc-codereview.appspot.com/45519004/

R=guoweis@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/49399004

Cr-Commit-Position: refs/heads/master@{#8720}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8720 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-13 18:25:54 +00:00
jiayl@webrtc.org
8372888b07 Revert "Fix an issue in DtlsIdentityStore when the store is destroyed before the worker thread task returns." 
This reverts commit 45bc01a7172402aa4bb8d457474300533c273413.
TBR=pthatcher@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/47559004

Cr-Commit-Position: refs/heads/master@{#8711}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8711 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-13 00:32:43 +00:00
jiayl@webrtc.org
fde1de93f9 Fix an issue in DtlsIdentityStore when the store is destroyed before the worker thread task returns. 
BUG=crbug/464995
R=pthatcher@webrtc.org

Committed: https://code.google.com/p/webrtc/source/detail?r=8689

Committed: https://code.google.com/p/webrtc/source/detail?r=8701

Review URL: https://webrtc-codereview.appspot.com/42659004

Cr-Commit-Position: refs/heads/master@{#8706}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8706 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-12 23:02:13 +00:00
guoweis@webrtc.org
00c509ad1c Add concept of whether video renderer supports rotation. 
Rotation is best done when rendered in GPU, added the shader code which rotates the frame. For renderers which don't support rotation, the rotation will be done before sending down the frame to render. By default, assume renderer can't do rotation.

Tested with peerconnection_client on windows, AppRTCDemo on Mac.

BUG=4145
R=glaznev@webrtc.org, pthatcher@webrtc.org

Committed: https://code.google.com/p/webrtc/source/detail?r=8660

Committed: https://code.google.com/p/webrtc/source/detail?r=8661

Review URL: https://webrtc-codereview.appspot.com/43569004

Cr-Commit-Position: refs/heads/master@{#8705}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8705 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-12 21:38:19 +00:00
jiayl@webrtc.org
04cd69887d Revert "Fix an issue in DtlsIdentityStore when the store is destroyed before the worker thread task returns." 
This reverts commit 93604daf0e.

TBR=pthatcher@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/40329004

Cr-Commit-Position: refs/heads/master@{#8704}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8704 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-12 21:36:42 +00:00
guoweis@webrtc.org
4f85288e71 Socket options are only applied when first setting TransportChannelImpl. 
Also fixed the issue when we have an TransportChannelImpl, the socket
option is not preserved.

Since this is a code path that will be modified by bundle (which Peter also has a test case already), we don't need a test case here.

BUG=4374
R=pthatcher@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/42699004

Cr-Commit-Position: refs/heads/master@{#8702}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8702 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-12 20:10:22 +00:00
jiayl@webrtc.org
93604daf0e Fix an issue in DtlsIdentityStore when the store is destroyed before the worker thread task returns. 
BUG=crbug/464995
R=pthatcher@webrtc.org

Committed: https://code.google.com/p/webrtc/source/detail?r=8689

Review URL: https://webrtc-codereview.appspot.com/42659004

Cr-Commit-Position: refs/heads/master@{#8701}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8701 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-12 19:05:22 +00:00
tommi@webrtc.org
d3900296ae Use a variant for storing stats values in StatsCollector code. 
This cuts down on the amount of string copying we currently do and paves the way for separating the code that fetches the stats from the code that populates the stats reports.  As is, that code is intertwined, so we populate the stats on both signaling and worker thread.

I'm also adding some documentation and TODOs for further improvements.

BUG=2822
R=pthatcher@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/47459004

Cr-Commit-Position: refs/heads/master@{#8700}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8700 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-12 16:36:15 +00:00
tommi@webrtc.org
75b7f17c29 Temporary interface change to StatsReport::Id. 
This change is just to allow rolling into Chromium, update Chromium and then commit the actual change in WebRTC that requires the interface change. It allows using a StatsReport::Id object as a pointer (foo->Bar()), since in an upcoming change, Id objects will be pointers.

R=magjed@webrtc.org
BUG=2822

Review URL: https://webrtc-codereview.appspot.com/43689004

Cr-Commit-Position: refs/heads/master@{#8697}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8697 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-12 13:31:24 +00:00
mflodman@webrtc.org
e9413c686e Revert 8689 "Fix an issue in DtlsIdentityStore when the store is..." 
> Fix an issue in DtlsIdentityStore when the store is destroyed before the worker thread task returns.
> 
> BUG=crbug/464995
> R=pthatcher@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/42659004

TBR=jiayl@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/42729004

Cr-Commit-Position: refs/heads/master@{#8690}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8690 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-12 08:42:18 +00:00
jiayl@webrtc.org
2a3942adc6 Fix an issue in DtlsIdentityStore when the store is destroyed before the worker thread task returns. 
BUG=crbug/464995
R=pthatcher@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/42659004

Cr-Commit-Position: refs/heads/master@{#8689}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8689 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-11 23:33:42 +00:00
glaznev@webrtc.org
fc516077ed Fix Android AppRTCDemo failure on devices with one or no camera. 
- Disable video call on devices with no camera.
- Open default camera and disable camera switch on
devices with one camera.

BUG=4373
R=braveyao@webrtc.org, wzh@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/46539004

Cr-Commit-Position: refs/heads/master@{#8674}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8674 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-10 18:21:19 +00:00
guoweis@webrtc.org
f9a75d99b9 Revert "Add concept of whether video renderer supports rotation." 
This reverts commit 0ad48935fc.

TBR=guoweis@webrtc.org

BUG=

Review URL: https://webrtc-codereview.appspot.com/41199004

Cr-Commit-Position: refs/heads/master@{#8663}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8663 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-10 06:37:41 +00:00
guoweis@webrtc.org
0ad48935fc Add concept of whether video renderer supports rotation. 
Rotation is best done when rendered in GPU, added the shader code which rotates the frame. For renderers which don't support rotation, the rotation will be done before sending down the frame to render. By default, assume renderer can't do rotation.

BUG=4145
R=glaznev@webrtc.org, pthatcher@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/43569004

Cr-Commit-Position: refs/heads/master@{#8660}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8660 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-10 02:43:40 +00:00
henrika@webrtc.org
474d1eb223 Adds C++/JNI/Java unit test for audio device module on Android. 
This CL adds support for unittests of the AudioDeviceModule on Android using both Java and C++. The new framework uses ::testing::TesWithParam to support both Java-based audio and OpenSL ES based audio. However, given existing issues in our OpenSL ES implementation, the list of test parameters only contains Java in this first version. Open SL ES will be enabled as soon as the backend has been refactored.

It also:

- Removes the redundant JNIEnv* argument in webrtc::VoiceEngine::SetAndroidObjects().
- Modifies usage of enable_android_opensl and the WEBRTC_ANDROID_OPENSLES define.
- Adds kAndroidJavaAudio and kAndroidOpenSLESAudio to AudioLayer enumerator.
- Fixes some bugs which were discovered when running the tests.

BUG=NONE
R=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/40069004

Cr-Commit-Position: refs/heads/master@{#8651}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8651 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-09 12:40:43 +00:00
glaznev@webrtc.org
dc08a230da Fix H.264 start code position search. 
This will address incorrect start code search
in a sequence like 00 00 00 00 00 01.
Thanks Noah.

R=noahric@chromium.org, wzh@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/41159004

Cr-Commit-Position: refs/heads/master@{#8639}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8639 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-06 23:32:42 +00:00
magjed@webrtc.org
c2008a0e8c RTCOpenGLVideoRenderer: Add support for padded frames 
This CL allows RTCOpenGLVideoRenderer to handle frames with pitch > width by making an intermediate frame copy.

BUG=4381,1128
R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/46509004

Cr-Commit-Position: refs/heads/master@{#8637}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8637 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-06 16:59:23 +00:00
jiayl@webrtc.org
b4cd093f41 Change the unintentioal CHECK to DCHECK in DtlsIdentityStore. 
R=pthatcher@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/41139004

Cr-Commit-Position: refs/heads/master@{#8636}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8636 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-06 16:32:57 +00:00
magjed@webrtc.org
45cdcce5f5 Remove TextureVideoFrame 
TextureVideoFrame is currently an empty shell that only provides a convenience constructor of I420VideoFrame with a texture buffer. This CL moves that constructor, and all unittests, of TextureVideoFrame into the base class. Then it's possible to completely remove TextureVideoFrame and all its files. Also, there is no point in having I420VideoFrame virtual anymore.

R=pbos@webrtc.org, perkj@webrtc.org, stefan@webrtc.org
TBR=mflodman

Review URL: https://webrtc-codereview.appspot.com/40229004

Cr-Commit-Position: refs/heads/master@{#8629}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8629 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-06 10:41:47 +00:00
tommi@webrtc.org
5af41aabae Fix uninitialized variable. If FindConstraint() returns false, we check |value| in two places and at that point, it can hold an uninitialized value. Caught by Linux Memcheck builder. 
http://chromegw.corp.google.com/i/client.webrtc/builders/Linux%20Memcheck/builds/3351/steps/libjingle_peerconnection_unittest/logs/0A34BA777AB03D08

TBR=perkj@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/43579004

Cr-Commit-Position: refs/heads/master@{#8611}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8611 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-05 08:42:13 +00:00
guoweis@webrtc.org
bbce5efaa6 Turn on IPv6 for WebRTC as default as required before ramping the experiment to 30%. 
BUG=
R=juberti@webrtc.org

Committed: https://code.google.com/p/webrtc/source/detail?r=8582

Committed: https://code.google.com/p/webrtc/source/detail?r=8607

Review URL: https://webrtc-codereview.appspot.com/43529004

Cr-Commit-Position: refs/heads/master@{#8609}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8609 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-05 04:39:07 +00:00
guoweis@webrtc.org
d43b2c098d Revert "Turn on IPv6 for WebRTC as default as required before ramping the experiment to 30%." 
This reverts commit 86c33e3a94.

TBR=guoweis@webrtc.org

BUG=

Review URL: https://webrtc-codereview.appspot.com/47409004

Cr-Commit-Position: refs/heads/master@{#8608}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8608 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-05 04:03:44 +00:00
guoweis@webrtc.org
86c33e3a94 Turn on IPv6 for WebRTC as default as required before ramping the experiment to 30%. 
BUG=
R=juberti@webrtc.org

Committed: https://code.google.com/p/webrtc/source/detail?r=8582

Review URL: https://webrtc-codereview.appspot.com/43529004

Cr-Commit-Position: refs/heads/master@{#8607}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8607 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-05 03:40:48 +00:00
jiayl@webrtc.org
61e00b0bca Create a in-memory DTLS identity store that keeps a free identity generated in the background. 
BUG=4241
R=pthatcher@webrtc.org

Committed: https://code.google.com/p/webrtc/source/detail?r=8576

Committed: https://code.google.com/p/webrtc/source/detail?r=8581

Review URL: https://webrtc-codereview.appspot.com/37889004

Cr-Commit-Position: refs/heads/master@{#8605}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8605 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-04 22:18:18 +00:00
tommi@webrtc.org
92f4018d80 Start using std::map for Values in the statscollector. This is in preparaton for more work which will cut down on the string copying work we do. 
Rename "AddValue" methods to AddXxx where Xxx is the type being added. Moving forward, we'll support those types natively without conversion to string.

Normalizing the extraction code to have fewer places that add the same stats and data driven additions to reports instead of multiple call sites.

BUG=2822
R=perkj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/47369004

Cr-Commit-Position: refs/heads/master@{#8597}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8597 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-04 15:25:44 +00:00
kjellander@webrtc.org
14665ff7d4 Roll chromium_revision e144d30..6fdb142 (318658:318841) + remove OVERRIDE macro 
Clang version changed 223108:230914
Details: e144d30..6fdb142/tools/clang/scripts/update.sh

Removes the OVERRIDE macro defined in:
* webrtc/base/common.h
* webrtc/typedefs.h

The majority of the source changes were done by running this in src/:
perl -0pi -e "s/virtual\s([^({;]*(\([^({;]*\)[^({;]*))(OVERRIDE|override)/\1override/sg" `find {talk,webrtc} -name "*.h"  -o -name "*.cc*" -o -name "*.mm*"`

which converted all:
virtual Foo() OVERRIDE
functions to:
Foo() override

Then I manually edited:
* talk/media/webrtc/fakewebrtccommon.h
* webrtc/test/fake_common.h

Remaining uses of OVERRIDE was fixed by search+replace.

Manual edits were done to fix virtual destructors that were
overriding inherited ones.

Finally a build error related to the pure virtual definitions of
Read, Write and Rewind in common_types.h required a bit of
refactoring in:
* webrtc/common_types.cc
* webrtc/common_types.h
* webrtc/system_wrappers/interface/file_wrapper.h
* webrtc/system_wrappers/source/file_impl.cc

This roll should make it possible for us to finally re-enable deadlock
detection for TSan on the buildbots.

BUG=4106
R=pbos@webrtc.org, tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/41069004

Cr-Commit-Position: refs/heads/master@{#8596}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8596 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-04 13:04:54 +00:00
pbos@webrtc.org
058b1f17ac Remove GetReceiveBandwidthEstimatorStats. 
Removes unnecessary non-standard stats that we don't really make use of.

BUG=
R=pthatcher@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/47379004

Cr-Commit-Position: refs/heads/master@{#8588}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8588 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-04 08:55:16 +00:00
guoweis@webrtc.org
fc2f146af2 Revert "Turn on IPv6 for WebRTC as default as required before ramping the experiment to 30%." 
This reverts commit bbbdeed2bf.

TBR=juberti@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/41109004

Cr-Commit-Position: refs/heads/master@{#8585}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8585 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-04 04:50:41 +00:00
pthatcher@webrtc.org
7bea1ffe77 Expose negotiated ciphers through stats API. 
Use the new internal API to expose the negotiated SRTP/SSL ciphers
through the stats API.
This is a follow-up to https://webrtc-codereview.appspot.com/37209004.

BUG=3976
R=juberti@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/35169004

Cr-Commit-Position: refs/heads/master@{#8584}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8584 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-04 01:38:49 +00:00
jiayl@webrtc.org
be77872d2c Revert "Create a in-memory DTLS identity store that keeps a free identity generated in the background." 
Breaking Chromium FYI.

TBR=pthatcher@webrtc.org

This reverts commit 369f68255f.

BUG=4241
R=pthatcher@webrtc.org

Committed: https://code.google.com/p/webrtc/source/detail?r=8576

Review URL: https://webrtc-codereview.appspot.com/37889004


Review URL: https://webrtc-codereview.appspot.com/47389004

Cr-Commit-Position: refs/heads/master@{#8583}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8583 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-04 00:19:16 +00:00
guoweis@webrtc.org
bbbdeed2bf Turn on IPv6 for WebRTC as default as required before ramping the experiment to 30%. 
BUG=
R=juberti@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/43529004

Cr-Commit-Position: refs/heads/master@{#8582}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8582 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-03 23:27:41 +00:00
jiayl@webrtc.org
369f68255f Create a in-memory DTLS identity store that keeps a free identity generated in the background. 
BUG=4241
R=pthatcher@webrtc.org

Committed: https://code.google.com/p/webrtc/source/detail?r=8576

Review URL: https://webrtc-codereview.appspot.com/37889004

Cr-Commit-Position: refs/heads/master@{#8581}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8581 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-03 23:14:18 +00:00
jiayl@webrtc.org
8ad96605c1 Revert "Create a in-memory DTLS identity store that keeps a free identity generated in the background." 
Test failure: http://chromegw/i/client.webrtc/builders/Linux32%20Release/builds/3557

This reverts commit df512cc8b7.

TBR=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/41089004

Cr-Commit-Position: refs/heads/master@{#8579}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8579 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-03 20:35:34 +00:00
jiayl@webrtc.org
df512cc8b7 Create a in-memory DTLS identity store that keeps a free identity generated in the background. 
BUG=4241
R=pthatcher@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/37889004

Cr-Commit-Position: refs/heads/master@{#8576}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8576 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-03 16:42:21 +00:00
perkj@webrtc.org
a1c9803e32 Fix crash in setPictureSize on Galaxy Nexus. 
This cl tries to find the best supported pictureSize before setting it.
BUG=4197
R=magjed@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/45419004

Cr-Commit-Position: refs/heads/master@{#8571}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8571 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-03 10:54:21 +00:00
perkj@webrtc.org
1d82813961 Reland "Fix CVO in androidvideocapturer". 
This cl was originally revieved in https://webrtc-codereview.appspot.com/40759004/

Patchset 2 adds a unittest for VideoFrame::Reset with and without the apply_rotation flag set.

BUG=4145
R=pthatcher@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/42559004

Cr-Commit-Position: refs/heads/master@{#8564}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8564 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-03 06:44:40 +00:00
perkj@webrtc.org
60f9d6f959 Revert "Add default implementation to VideoSourceInterface." 
Chrome test mock has been updated so VideoSourceInterface can now be pure virtual again. This reverts commit ed8d52378c43a7a93e0d2ca586486ca06db9eabe.

R=magjed@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/45399004

Cr-Commit-Position: refs/heads/master@{#8551}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8551 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-02 11:33:41 +00:00
tommi@webrtc.org
afa6d16a05 Add a ToString() method to StatsReport::Value. 
This is an interface change only at this point which will be followed up by a matching change in Chromium that removes the dependency on the 'value' member variable.  Once that's been done, I'll add native support for non-string types in the Value class.

R=magjed@webrtc.org
BUG=2822

Review URL: https://webrtc-codereview.appspot.com/40139004

Cr-Commit-Position: refs/heads/master@{#8550}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8550 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-02 11:28:35 +00:00
aluebs@webrtc.org
73acc15c69 Revert 8538 "Reland "Fix CVO in androidvideocapturer.""" 
> Reland "Fix CVO in androidvideocapturer.""
> This reverts commit b8bcf8cbbf.
> after I fixed a rebase mistake. The fix is the delta between patchset 1 and 2.
> 
> The original cl was reviewed here:
> https://webrtc-codereview.appspot.com/40759004/
> 
> TBR=magjed@webrtc.org
> 
> BUG=4145
> 
> Review URL: https://webrtc-codereview.appspot.com/45409004

TBR=perkj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/44439004

Cr-Commit-Position: refs/heads/master@{#8539}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8539 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-27 23:27:41 +00:00
perkj@webrtc.org
3a93e33c56 Reland "Fix CVO in androidvideocapturer."" 
This reverts commit b8bcf8cbbf.
after I fixed a rebase mistake. The fix is the delta between patchset 1 and 2.

The original cl was reviewed here:
https://webrtc-codereview.appspot.com/40759004/

TBR=magjed@webrtc.org

BUG=4145

Review URL: https://webrtc-codereview.appspot.com/45409004

Cr-Commit-Position: refs/heads/master@{#8538}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8538 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-27 20:19:16 +00:00
perkj@webrtc.org
b8bcf8cbbf Revert "Fix CVO in androidvideocapturer." 
This reverts commit 02ed57bf9d.
https://webrtc-codereview.appspot.com/40759004/

Reason- breaks tests after rebase.

TBR=magjed@webrtc.org

BUG=4145

Review URL: https://webrtc-codereview.appspot.com/39349004

Cr-Commit-Position: refs/heads/master@{#8537}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8537 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-27 19:48:15 +00:00
perkj@webrtc.org
02ed57bf9d Fix CVO in androidvideocapturer. 
This add bool apply_rotation to WebrtcVideoFrame::Init and removes the need for WebrtcVideoFrame::SetRotation.

BUG=4145
R=guoweis@webrtc.org, pthatcher@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/40759004

Cr-Commit-Position: refs/heads/master@{#8536}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8536 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-27 19:10:45 +00:00
perkj@webrtc.org
41d8fda12d VideoCapturerAndroid allocates direct buffers so that the frame buffers can be used in C++ without a copy. However byte[] array = ByteBuffer.array() seems to point to the beginning of the underlaying buffer and that is what the camera fills. But it turns out that ByteBuffer.arrayOffset() returns an offset and it seems like the pointer returned by jni->GetDirectBufferAddress(j_frame). This cl reverts back to pass the byte[] to c++ and use jni->GetByteArrayElements to get the address of the buffer. 
R=glaznev@webrtc.org, magjed@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/35349004

Cr-Commit-Position: refs/heads/master@{#8535}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8535 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-27 18:51:18 +00:00
guoweis@webrtc.org
21ad37528e Ensure we set the right attrib for correct shader 
When using oesProgram, we still specify the yuvProgram for setting shader attributes. This should be changed to the correct shader program.

BUG=
R=glaznev@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/45379004

Cr-Commit-Position: refs/heads/master@{#8533}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8533 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-27 18:12:20 +00:00
magjed@webrtc.org
f09e7b8a4f WebRtcVideoFrame: DCHECK exclusive ownership for non-const pixel access 
Add some const safety by DCHECK(HasOneRef()) in non-const GetYPlane. This CL also replaces all incorrect non-const calls with const calls for pixel data access in cricket::VideoFrame. It's easy to call the non-const version of e.g. GetYPlane by mistake, even if only const-access is needed. For example:
const scoped_ptr<cricket::VideoFrame> foo;
const uint8_t* y = foo->GetYPlane();
will actually call the non-const version of GetYPlane.

R=mflodman@webrtc.org, perkj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/39079004

Cr-Commit-Position: refs/heads/master@{#8507}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8507 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-25 14:50:19 +00:00
hbos@webrtc.org
1e64263b90 Thread-safe ChannelManager.GetSupportedFormats, used by VideoSource 
VideoSource was using VideoCapturer's GetSupportedFormats in a non-thread safe manner.
Now this is handled to (new method) ChannelManager.GetSupportedFormats.

BUG=
R=perkj@webrtc.org, tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/42079004

Cr-Commit-Position: refs/heads/master@{#8495}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8495 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-25 09:50:22 +00:00