generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Disable assert for nr of threads in PeerConnectionTest.java.

Browse Source 
This test is flaky so we need to figure out a better way to do it.
I've documented what we've observed and added a todo for myself to figure out a solution.

R=kjellander@webrtc.org
BUG=4424

Review URL: https://webrtc-codereview.appspot.com/46599004

Cr-Commit-Position: refs/heads/master@{#8725}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8725 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
tommi@webrtc.org 2015-03-14 18:15:23 +00:00
parent 6107ba12f9
commit c29f7f3a5f
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
talk/app/webrtc/java/testcommon/src/org/webrtc/PeerConnectionTest.java
View File

@ -480,9 +480,19 @@ public class PeerConnectionTest {
}
void finalizeThreadCheck() throws Exception {
TreeSet<String> threadsAfterTest = allThreads();
assertEquals(threadsBeforeTest, threadsAfterTest);
Thread.sleep(100);
// TreeSet<String> threadsAfterTest = allThreads();
// TODO(tommi): Figure out a more reliable way to do this test. As is
// we're seeing three possible 'normal' situations:
// 1. before and after sets are equal.
// 2. before contains 3 threads that do not exist in after.
// 3. after contains 3 threads that do not exist in before.
//
// Maybe it would be better to do the thread enumeration from C++ and get
// the thread names as well, in order to determine what these 3 threads are.
// assertEquals(threadsBeforeTest, threadsAfterTest);
// Thread.sleep(100);
}
void doTest() throws Exception {