Commit Graph

56 Commits

Author SHA1 Message Date
leozwang@webrtc.org
29fafefa0e Fix building errors
Review URL: https://webrtc-codereview.appspot.com/399012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1738 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-21 19:46:33 +00:00
kjellander@webrtc.org
51198f1c68 More PRESUBMIT checks.
Checks for:
- No iostream includes in headers
- No use of FRIEND_TEST for gtest
- Verifies that all C/C++ code passes cpplint.py check.
- Verifies that BUG= is present in commit message
- Verifies that TEST= is present in commit message

For more details, see Chrome's PRESUBMIT.py at
http://src.chromium.org/viewvc/chrome/trunk/src/PRESUBMIT.py?revision=113979&view=markup
and the canned checks at
http://src.chromium.org/viewvc/chrome/trunk/tools/depot_tools/presubmit_canned_checks.py?view=markup

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/317011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1737 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-21 17:53:46 +00:00
kjellander@webrtc.org
0a57aae75b Converted old jpeg_test tool to gtest unit test.
Restructured paths to new directory layout.

Stefan: common_video/*
Magnus: video_engine/*
Niklas: Android.mk

BUG=
TEST=jpeg_unittests on Debug+Release on Linux, Mac, Windows. Valgrind on Linux passes without warnings.

Review URL: https://webrtc-codereview.appspot.com/388007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1691 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-15 09:47:55 +00:00
kjellander@webrtc.org
cf6a295b13 Making video codecs test framework integration test execute in a reproducable fashion.
Fixed reproducable random behavior in packet_manipulator.h.
Test is now fully reproducable (runs on only one core) so much tighter limits are now set for the SSIM/PSNR values for the encoding/decoding (verified on all platforms)

BUG=
TEST=out/Debug/video_codecs_test_framework_integrationtests in Debug+Release on Linux, Mac, Windows and in Linux Valgrind.

Review URL: https://webrtc-codereview.appspot.com/381005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1649 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-09 09:01:51 +00:00
phoglund@webrtc.org
9d9ad88ba5 Fixed remaining warnings.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/393001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1626 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-07 16:16:52 +00:00
andrew@webrtc.org
daacee81b8 Use better reference files with audioproc_unittest.
The files are shorter (7 s) with one set provided for each sample rate.

Will be accompanied by the following set of files in the resource bundle:
far8_stereo.pcm
far16_stereo.pcm
far32_stereo.pcm
near8_stereo.pcm
near16_stereo.pcm
near32_stereo.pcm

BUG=114
TEST=audioproc_unittest

Review URL: https://webrtc-codereview.appspot.com/380003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1617 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-07 00:01:04 +00:00
mflodman@webrtc.org
c80d9d9361 Removed default cases causing clang errors, -Wcovered-switch-default.
BUG=
TEST=Bulid with clang version 3.1 (trunk 148911)

Review URL: https://webrtc-codereview.appspot.com/379008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1604 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 10:11:25 +00:00
henrikg@webrtc.org
fede80c0b8 Updated test web page info for PeerConnection v2.
Different loopback pages are needed for v1 and v2.

Also removed obsolete comment.
Review URL: https://webrtc-codereview.appspot.com/375005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1587 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-01 13:10:48 +00:00
henrikg@webrtc.org
6a8147519c Removing year range in copyright statement in test web page.
Review URL: https://webrtc-codereview.appspot.com/365001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1494 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-20 08:54:16 +00:00
henrikg@webrtc.org
16a04273bb Updates for web test page.
- Only showing text about browser needing WebRTC support if support not detected. Text is now contains more information and link to blog post.
- Removed the debug buttons.
- Clarifications and corrections in the readme file.
Review URL: https://webrtc-codereview.appspot.com/352015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1491 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-20 07:53:26 +00:00
bjornv@webrtc.org
12cccddc63 NS-SWB: Actived SWB processing at once, i.e., no startup phase.
Performance verified on a few 32 kHz files.
BUG=
TEST=audioproc, audioproc_unittest

Updated output_data_float.pb
Changes in SWB tests (3, 6, 9 and 12) as

Running test 3 of 12...
src/modules/audio_processing/test/unit_test.cc:1182: Failure
Value of: max_output_average
  Actual: 1363
Expected: test->max_output_average()
Which is: 1386

Running test 6 of 12...
src/modules/audio_processing/test/unit_test.cc:1182: Failure
Value of: max_output_average
  Actual: 2070
Expected: test->max_output_average()
Which is: 2109

Running test 9 of 12...
src/modules/audio_processing/test/unit_test.cc:1182: Failure
Value of: max_output_average
  Actual: 1314
Expected: test->max_output_average()
Which is: 1336

Running test 12 of 12...
src/modules/audio_processing/test/unit_test.cc:1182: Failure
Value of: max_output_average
  Actual: 2049
Expected: test->max_output_average()
Which is: 2085
Review URL: https://webrtc-codereview.appspot.com/344013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1465 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-19 08:56:38 +00:00
henrikg@webrtc.org
267b877586 Add possibility to set HTML element values (e.g. server and name) in the URL for the test web page.
Example: .../webrtc_test.html?server=foo

This simplifies when one has to close and re-open the browser several times or use different servers and names, since it can be stored as bookmarks instead of changing it manually every time.
Review URL: http://webrtc-codereview.appspot.com/339006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1351 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-09 08:19:15 +00:00
kjellander@webrtc.org
cc33737a80 Changing all PSNR/SSIM calculations to use libyuv.
Removed old PSNR/SSIM implementations in:
* test/testsupport/metrics/video_metrics.cc
* src/modules/video_coding/codecs/test_framework/test.cc
The functions in video_metrics.cc is now using code in libyuv instead. Old code in test.cc is using the same functions.
The code for video_metrics.h had to be moved into a separate GYP file to avoid circular dependency error on Mac (see issue 160 for more details). The reason for this is that libyuv's unittest target depends on test_support_main.

BUG=
TEST=metrics_unittests in Debug+Release on Linux, Mac and Windows.

Review URL: http://webrtc-codereview.appspot.com/333025

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1325 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 08:09:32 +00:00
bjornv@webrtc.org
70adcd46b2 Delay estimator improvements.
Robustness improvements to the delay estimator used in AECM and AEC. In AEC only for logging. Faster convergence.

TEST=audioproc_unittest + offline file tests.

output_data_fixed.pb updated despite unverified changes in r1112.
Review URL: http://webrtc-codereview.appspot.com/337006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1306 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-29 14:51:21 +00:00
bjornv@webrtc.org
7270a6bcc2 Merged apm-buffer branch [r1293] back to trunk.
This CL includes a larger structural change in how we handle buffers in AEC. We now perform FFT at once and move within blocks to compensate for system delays.

TEST=audioproc_unittest(float and fix), voe_auto_test
Review URL: http://webrtc-codereview.appspot.com/335012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1299 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-28 08:44:17 +00:00
kjellander@webrtc.org
173b7bbc16 Integration test that tracks dropped frames and compares video output.
The recorded frame timestamps are used to modify the output video on a frame-per-frame so it can be compared with the reference video using PSNR. This code will make it possible to use vie_auto_test for full stack comparisons with network interference and similar interesting simulations.

There's some refactoring done in vie_comparison_test.cc to make it fit to the new test.

Compiled and executed in Debug+Release on Linux, Mac and Windows.

BUG=
TEST=vie_auto_test --automated --gtest_filter=ViEVideoVerificationTest.*

Review URL: http://webrtc-codereview.appspot.com/320002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1269 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-21 16:11:25 +00:00
kjellander@webrtc.org
5b97b1216f Splitted FileHandler into FrameReader and FrameWriter classes and moved them to testsupport in test.gyp.
Fixed unit tests so they don't use ASSERT_DEATH since that doesn't work with Valgrind.

Fixed all Valgrind warnings except the one caused by CriticalSectionWrapper in system_wrappers.

Reworked all includes and GYP include paths to use full directory paths.

Removed util.h for logging, since it rendered warnings in Valgrind because of gflags. Replaced it with a verbose flag and a new function in video_quality_measurement.cc

BUG=
TEST=Passed test_support_unittests and video_codecs_test_framework_unittests on Linux, Mac and Windows.

Review URL: http://webrtc-codereview.appspot.com/311001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1126 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 07:42:18 +00:00
kjellander@webrtc.org
80b2661dc6 Fixing invalid check for existing file.
Review URL: http://webrtc-codereview.appspot.com/313002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1124 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-07 18:50:17 +00:00
kjellander@webrtc.org
4ed4f24074 New fileutils.h method for managing resources on different platforms
Review URL: http://webrtc-codereview.appspot.com/304007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1105 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-05 16:31:12 +00:00
kjellander@webrtc.org
82d91ae6cf Fixing crash when calculating SSIM and PSNR with empty video files in video_metrics.cc
There were previously a dependency on system_wrappers that is now removed (uses defines to check for SEE2 instructions during compilation time instead).

Review URL: http://webrtc-codereview.appspot.com/296008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1102 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-05 13:03:38 +00:00
andrew@webrtc.org
a919d3a643 Don't return a zero delay with insufficient data.
For estimating a delay over a long segment (e.g. a file) this can
throw off the estimate. Better not to add values to the AEC's histogram
until they're reliable.

BUG=
TEST=audiproc, audioproc_unittest

Review URL: http://webrtc-codereview.appspot.com/292004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1035 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-27 23:40:58 +00:00
kjellander@webrtc.org
5483210c82 Fixed open file handle in fileutils.cc
Thanks Henrik L for pointing this out.

Review URL: http://webrtc-codereview.appspot.com/297001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1019 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-25 09:33:41 +00:00
henrikg@webrtc.org
91617ff948 Review URL: http://webrtc-codereview.appspot.com/269019
git-svn-id: http://webrtc.googlecode.com/svn/trunk@989 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-22 14:34:44 +00:00
andrew@webrtc.org
d0e5b96c54 Fix Amy's email address.
Review URL: http://webrtc-codereview.appspot.com/268010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@952 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-16 02:08:52 +00:00
andrew@webrtc.org
755b04a06e Add RMS computation for the RTP level indicator.
- Compute RMS over a packet's worth of audio to be sent in Channel, rather than the captured audio in TransmitMixer.
- We now use the entire packet rather than the last 10 ms frame.
- Restore functionality to LevelEstimator.
- Fix a bug in the splitting filter.
- Fix a number of bugs in process_test related to a poorly named
  AudioFrame member.
- Update the unittest protobuf and float reference output.
- Add audioproc unittests.
- Reenable voe_extended_tests, and add a real function test.
- Use correct minimum level of 127.

TEST=audioproc_unittest, audioproc, voe_extended_test, voe_auto_test

Review URL: http://webrtc-codereview.appspot.com/279003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@950 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-15 16:57:56 +00:00
andrew@webrtc.org
0db7dc6e18 Add file-playing channels to voe_cmd_test.
Fix file reading and writing.

TEST=voe_cmd_test

Review URL: http://webrtc-codereview.appspot.com/279001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@938 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-13 01:34:05 +00:00
phoglund@webrtc.org
9b18ed6220 Removed incorrect dependency.
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/267010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@933 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-11 12:14:25 +00:00
phoglund@webrtc.org
1144ba2268 Base and codec tests now run verify output and render to file instead of to screen.
Rewrote the codec test to render to file and do video comparisons.

Refactored the coded tests somewhat. I still need to figure out how to do comparison in the automated case.

Added video analysis to the test. This will make sure that the system output roughly the right thing.

Moved the video metrics library into the test_support library. Made the metrics library available in the automated tests.

Made sure no one passes in too large YUV videos into the autotest.

The standard test's output now gets captured for both the left and right windows.

Wrote a rendering device which just writes the raw frames to file, for analysis. Updated the base standard test to dump its left window output to file. We don't do anything with it yet though.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/249001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@931 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-11 09:01:03 +00:00
niklas.enbom@webrtc.org
62e48eb4ce adding owners for test
git-svn-id: http://webrtc.googlecode.com/svn/trunk@930 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-11 08:58:27 +00:00
kjellander@webrtc.org
4d8cd9d055 Adding GetOutputDir method to test_support library.
The unittest is not ideal for this, but I would have to use similar code as the implementation of the GetOutputDir in order to verify that it actually runs, so it wouldn't make much sense with a test like that.

It compiles and runs on Linux, Win and Mac. The folder gets created and is writeable from other tests.

I have tried using the GetOutputDir from another project that writes output files and it works as intended on all platforms.

Review URL: http://webrtc-codereview.appspot.com/270001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@906 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-09 11:24:14 +00:00
kjellander@webrtc.org
20a370e875 Changing the namespace of TestSuite to webrtc::test.
Adding gmock initialization into main test runner class

Review URL: http://webrtc-codereview.appspot.com/254004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@885 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-04 01:19:16 +00:00
kjellander@webrtc.org
1a8d08ad76 Changing usage of gtest_main target, to use test_support_main instead.
Review URL: http://webrtc-codereview.appspot.com/252002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@884 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-03 23:28:47 +00:00
andrew@webrtc.org
1e10bb32b9 Remove global std::strings from fileutils.
This is forbidden by the style guide and can cause the static
initialization order fiasco.

BUG=
TEST=test_support_unittests

Review URL: http://webrtc-codereview.appspot.com/248006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@846 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-31 20:22:02 +00:00
andrew@webrtc.org
5b5c31d8dd Update fixed point audio processing output.
Review URL: http://webrtc-codereview.appspot.com/247008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@810 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-25 03:29:08 +00:00
bjornv@webrtc.org
4c636764b7 Updated the AEC delay logging to output values in ms. PB output updated.
Review URL: http://webrtc-codereview.appspot.com/223003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@770 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-19 08:47:40 +00:00
hta@webrtc.org
e698eb7e27 Make the sanity check test a little more robust, and add a README file.
Review URL: http://webrtc-codereview.appspot.com/220006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@748 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-14 13:56:26 +00:00
bjornv@webrtc.org
a59d80db45 Updated fixed point output data file after changes in nsx. Verified bitexactness before that CL and the CLs afterwards towards the new file.
Review URL: http://webrtc-codereview.appspot.com/213003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@745 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-14 12:16:43 +00:00
kjellander@webrtc.org
7951e819af Simple utility method for finding the project root dir (to be used by tests loading resource files)
The code has no intent to be superportable in all possible scenarios, since it will only be used by our own test code.
I reviewed more sophisticated libraries for doing similar things but came to the conclusion that they introduced more dependencies than motivated for this single purpose.

The unit test has been tested successfully executed on Linux (cmd line and Eclipse), Mac (XCode) and Windows (VS2008).

Review URL: http://webrtc-codereview.appspot.com/223002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@734 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-13 12:24:41 +00:00
bjornv@google.com
1ba3dbecbb Adds possibility to log delay estimates in AEC.
Review URL: http://webrtc-codereview.appspot.com/178001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@674 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-03 08:18:10 +00:00
tommi@webrtc.org
e90265bd1a Commit http://webrtc-codereview.appspot.com/191001/
Review URL: http://webrtc-codereview.appspot.com/192001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@670 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-30 13:26:14 +00:00
andrew@webrtc.org
19eefdc9f0 Add a unit testing framework.
Populate it with the beginnings of a resampler unit test to have it do someting.

Also fix a bug in resampler caught with the test ;)
Review URL: http://webrtc-codereview.appspot.com/135019

git-svn-id: http://webrtc.googlecode.com/svn/trunk@595 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-14 17:02:44 +00:00
henrik.lundin@webrtc.org
9f710d08e1 Switch to new sqrt in NetEQ
Switched to WebRtcSpl_SqrtFloor instead of WebRtcSpl_Sqrt in
NetEQ. The output is not bit-exact, but subjective listening
tests show no audible difference. Analysis shows that almost
all of the difference is in changed delay.

The reference file for NetEQ's unit test was updated.

Review URL: http://webrtc-codereview.appspot.com/139019

git-svn-id: http://webrtc.googlecode.com/svn/trunk@583 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-12 16:44:37 +00:00
henrik.lundin@webrtc.org
35dcc23110 Adding regression test to NetEQ
The test inputs RTP packets from an RTPdump file into NetEQ
and compares the output to the corresponding reference file.
Test files are included.

The change also includes a new method in NETEQTEST_RTPpacket
class, which reads past the initial file header in an RTPdump
file.

Finally, a few warnings are removed.
Review URL: http://webrtc-codereview.appspot.com/138012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@568 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-09 08:01:16 +00:00
tina.legrand@webrtc.org
af931bdb39 Update of iLBC reference files for version 1.1.1, new SQRT.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@479 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-29 08:27:48 +00:00
andrew@webrtc.org
5daeae2e5f Update fixed profile data due to AECM sqrt change (no presubmit).
git-svn-id: http://webrtc.googlecode.com/svn/trunk@382 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-16 17:19:02 +00:00
leozwang@google.com
325bca7ccf Add unit test output. webrtc r319, ran on Xoom, synced source code on 8/8.
Review URL: http://webrtc-codereview.appspot.com/100005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@338 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-09 18:13:15 +00:00
andrew@webrtc.org
14acdbc14d Update fixed-point profile output due to r313.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@333 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-09 01:54:03 +00:00
ajm@google.com
59e41405d1 Add a fixed-point profile to the APM unit test.
It uses fixed-point NS, AECM and adaptive digital AGC. It's selected by enabling "prefer_fixed_point" in common.gypi.
Review URL: http://webrtc-codereview.appspot.com/88009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@266 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-28 17:34:04 +00:00
ajm@google.com
a769fa51c0 Adding more output data checks to APM unittest. Blowing out the protobuf definition (changing the tags) since we're still in the formative stages. Later, this would be very bad. Leaving a Frame message in case we want frame-by-frame data, but we prefer to keep the output storage small in general so avoiding it thus far.
Review URL: http://webrtc-codereview.appspot.com/68004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@203 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-13 21:57:58 +00:00
hellner@google.com
1b627c72b5 Tests using the rtp_rtcp test data should now be run from inside trunk/test/data/rtp_rtcp. I.e. all test files were moved to the test folder.
Review URL: http://webrtc-codereview.appspot.com/60006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@185 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-08 17:16:47 +00:00