Commit Graph

196 Commits

Author SHA1 Message Date
tkchin@webrtc.org
ff2733204d Implement ObjC DataChannel wrapper
R=fischman@webrtc.org
BUG=3112

Review URL: https://webrtc-codereview.appspot.com/16369004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6031 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-30 18:32:33 +00:00
fischman@webrtc.org
f04a6ea733 MediaCodecVideoEncoder: limit MediaCodec bitrate to 95% of requested to avoid overshoot.
BUG=3194
R=noahric@google.com

Review URL: https://webrtc-codereview.appspot.com/17379004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6021 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-29 17:53:30 +00:00
mallinath@webrtc.org
a0d3067575 Use CreatePeerConnection method which accepts port_allocator.
Other method will be removed, in a different CL.

R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/20369006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5987 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-26 00:00:15 +00:00
tkchin@webrtc.org
19b1be159e Provide GetStats method in RTCPeerConnection
BUG=3144
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/12069006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5960 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-22 21:05:38 +00:00
tkchin@webrtc.org
ec3d8ecdcc Fix typo by renaming RTCSessionDescriptonDelegate -> RTCSessionsDescriptionDelegate
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/12059004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5946 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-21 18:47:24 +00:00
fischman@webrtc.org
29540b1879 Revert "PeerConnectionFactory: delay deletion of owned threads."
This reverts r5933 because it broke
http://build.chromium.org/p/client.webrtc/builders/Win64%20Release/builds/1598

BUG=3100

Review URL: https://webrtc-codereview.appspot.com/12159004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5935 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-17 22:54:30 +00:00
fischman@webrtc.org
cea024d672 PeerConnectionFactory: delay deletion of owned threads.
Since PeerConnection holds a ref to its creating PeerConnectionFactory, it's
possible for ~PeerConnectionFactory() to be run on its signaling thread.
Deleting a thread from within that thread is sad times, so don't do it.

It would be nicer to avoid having PeerConnection hold a ref to the factory,
and instead require the user to keep the factory alive.  Unfortunately that
changes the contract on PeerConnection{,Factory} and it's unclear how to vet
existing callers for safety.

BUG=3100
R=juberti@webrtc.org, noahric@google.com

Review URL: https://webrtc-codereview.appspot.com/11289004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5933 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-17 22:36:00 +00:00
jiayl@webrtc.org
8f88f20af2 Expand the test max wait time from 1000ms to 2000ms.
The createOffer/createAnswer methods sometimes times out due to slow identity generation under memcheck.

BUG=2838
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/12089004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5920 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-16 17:14:21 +00:00
wu@webrtc.org
36eda7cf0e Workaround for https://bugzilla.mozilla.org/show_bug.cgi?id=996329, where the m line from firefox have a space at the end.
For example:
"m=application 38233 DTLS/SCTP 5000 "

BUG=3212
TEST=manually try to use DataChannel between FF 28 and Chrome with rtccopy.com
R=jiayl@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/12029005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5915 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-15 20:37:30 +00:00
buildbot@webrtc.org
f875f15afb (Auto)update libjingle 64709629-> 64813990
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5897 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-14 16:06:21 +00:00
buildbot@webrtc.org
61c1b8ea32 (Auto)update libjingle 64585415-> 64594651
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5870 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-09 06:06:38 +00:00
wu@webrtc.org
4e393070be Compare the answer's media type against offer to make sure they are match. Otherwise we should return failure.
BUG=2687
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/11079005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5858 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-07 17:04:35 +00:00
wu@webrtc.org
148149138d (Auto)update libjingle 64147530-> 64247466
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5835 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-02 23:25:15 +00:00
wu@webrtc.org
5e760e7b94 Check the return value of the FromString call and return failure when then value is invalid. I.e. uses
bool FromString(const std::string& s, T* t)
instead of
T FromString(const std::string& str)

Before this change we will silently continue the parsing and take whatever default value returned by FromString.

TEST=new tests
BUG=2507
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/11069004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5834 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-02 23:19:09 +00:00
fischman@webrtc.org
49c5ba32bb AppRTCDemo(iOS): now works in the iOS Simulator!
...which has no camera device emulation or pass-through, so no local video
view.

R=noahric@google.com

Review URL: https://webrtc-codereview.appspot.com/10919004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5815 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-31 20:22:19 +00:00
fischman@webrtc.org
4f2bd68744 Silence pointless LS_WARNING about port 0 for active-only candidates.
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/10899004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5808 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-28 18:13:34 +00:00
wu@webrtc.org
987f2c9aae (Auto)update libjingle 63913264-> 63948945
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5807 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-28 16:22:19 +00:00
wu@webrtc.org
f7d501d48a (Auto)update libjingle 63884381-> 63913264
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5805 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-27 23:48:25 +00:00
wu@webrtc.org
cfe5e9c894 (Auto)update libjingle 63837929-> 63884381
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5800 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-27 17:03:58 +00:00
henrike@webrtc.org
b0ecc1c6fb (Auto)update libjingle 63777286-> 63837929
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5797 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-26 22:44:28 +00:00
henrike@webrtc.org
dce3feb0b0 (Auto)update libjingle 63738002-> 63773382
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5787 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-26 01:17:30 +00:00
fischman@webrtc.org
76d4f389bb AppRTCDemo(iOS): allow rooms with no incoming audio.
Also fix a compile-time warning for a leftover unimplemented method
(RTCVideoRenderer:setTransform).

R=noahric@google.com

Review URL: https://webrtc-codereview.appspot.com/10629004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5780 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-25 17:40:38 +00:00
henrike@webrtc.org
6e3dbc2a77 (Auto)update libjingle 63648983-> 63738002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5779 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-25 17:09:47 +00:00
fischman@webrtc.org
385a722646 PeerConnection(iOS): make ARC-clean talk/.../objc* and talk/examples/ios
- Removes a strong-reference cycle between RTCPeerConnection and
  RTCPeerConnectionObserver
- Gives RTCPeerConnectionObserver a virtual dtor
- Ensures RTCPeerConnectionTest tears down correctly
- Ensures AppRTCDemo tears down correctly

This is the talk/ half; the webrtc/ half is in https://webrtc-codereview.appspot.com/10539005

BUG=3054,3055,3100
R=noahric@google.com

Review URL: https://webrtc-codereview.appspot.com/10499005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5771 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-25 05:16:29 +00:00
sergeyu@chromium.org
e42b8ab129 Cleanups in libjingle to make it compile with chromium_code=1
Fixed all warnings that show up when compiling libjingle
in chromium with compiling with chromium_code=1.
chromium_code=1 enables various warnings that are off by
default. Most changes are for unused variables and consts.

R=pthatcher@google.com, wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/9699004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5769 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-25 00:31:35 +00:00
fischman@webrtc.org
7fa1fcb72c AppRTCDemo(ios): style/cleanup fixes following cr/62871616-p10
BUG=2168
R=noahric@google.com

Review URL: https://webrtc-codereview.appspot.com/9709004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5768 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-25 00:11:56 +00:00
fischman@webrtc.org
c693a2a624 PeerConnection(iOS): fix case in #import statements.
We've been skating by on OS/X's default case-insensitive filesystem, but this
is a bit silly.

This change brought to you by:
sed -i '' 's/\+internal\.h/+Internal.h/g' $(git grep -l '+internal.h')

BUG=3088
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/10559004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5764 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-24 18:56:37 +00:00
henrike@webrtc.org
ffe2620c97 (Auto)update libjingle 63352036-> 63363208
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5731 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-19 22:20:10 +00:00
henrike@webrtc.org
e9793ab8b8 (Auto)update libjingle 63111035-> 63293120
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5717 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-18 14:36:23 +00:00
henrike@webrtc.org
d3d6bce9ed (Auto)update libjingle 62865357-> 62871616
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5674 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-10 20:41:22 +00:00
henrike@webrtc.org
0537634154 (Auto)update libjingle 62713454-> 62865357
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5670 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-10 15:53:12 +00:00
fischman@webrtc.org
a01daf0359 RTCPeerConnectionTest(objc): deflake by ignoring ICECompleted.
Delivery of the state seems intermittent at best on OS/X so
ignore it until we can make it reliable.

BUG=1414,2993,chromium:348982
TBR=bemasc@chromium.org

Review URL: https://webrtc-codereview.appspot.com/9609004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5664 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-08 03:17:55 +00:00
fischman@webrtc.org
13320ea3d3 PeerConnectionTest(objc): expect ICE Completed state post 61460797-p10
Also a few trivial cleanups:
- No need to use STUN for a loopback test
- Reduce test call duration 10s->2s for faster iteration
- Remove obviously-irrelevant Info.plist entries (copy/pasta from iOS)

BUG=1414,2993
R=noahric@google.com

Review URL: https://webrtc-codereview.appspot.com/9369004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5663 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-07 22:15:30 +00:00
jiayl@webrtc.org
11aab0edc2 Populate VoiceReceiverInfo::delay_estimate_ms, jitter_buffer_ms, and jitter_buffer_preferred_ms to getStats.
BUG=2665
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/9579004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5661 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-07 18:56:26 +00:00
pbos@webrtc.org
371243dfa3 Remove std:: prefixes from C functions in talk/.
std::memcpy -> memcpy for instance. This change was motivated by a
compile report complaining that std::rand() was used instead of rand(),
probably with a stdlib.h include instead of cstdlib. Use of C functions
without the std:: prefix is a lot more common, so removing std:: to
address this.

BUG=
R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/9559004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5657 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-07 15:22:04 +00:00
henrike@webrtc.org
b90991dade Update libjingle 62472237->62550414
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5640 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-04 19:54:57 +00:00
jiayl@webrtc.org
db41b4dbcd Remove the deprecated GetStats method from PeerConnectionInterface.
R=fischman@webrtc.org, wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8879004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5634 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-03 21:30:06 +00:00
henrike@webrtc.org
40b3b68cdf Update libjingle 62364298->62472237
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5632 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-03 18:30:11 +00:00
henrike@webrtc.org
1bbfb57d71 Rollback of r5629 "(Auto)update libjingle 62364298-> 62368661".
BUG=N/A
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/9329004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5631 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-03 17:37:52 +00:00
henrike@webrtc.org
31413dc635 (Auto)update libjingle 62364298-> 62368661
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5629 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-03 16:47:01 +00:00
mallinath@webrtc.org
d3dc424fe5 Remove posting of ICE messages from WebRTCSession in PeerConnection to signaling thread.
These callbacks are called from signal thread already. There is no point
in posting messages on the same thread again.

BUG=2922
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/9219004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5626 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-01 00:05:52 +00:00
henrike@webrtc.org
b8395ebe14 (Auto)update libjingle 62293974-> 62364298
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5623 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-28 21:57:22 +00:00
henrike@webrtc.org
704bf9ebec (Auto)update libjingle 62063505-> 62278774
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5617 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-27 17:52:04 +00:00
henrike@webrtc.org
a7b981843f Unrevert 5590 "description"(=(Auto)update libjingle 61834300->61901702).
BUG=N/A
R=xians@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/9009004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5595 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-21 15:51:43 +00:00
xians@webrtc.org
ef2215110c Revert 5590 "description"
> description

TBR=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8949006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5593 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-21 10:31:29 +00:00
henrike@webrtc.org
2643805a20 description
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5590 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-20 22:32:53 +00:00
henrike@webrtc.org
571df2dca9 Update libjingle 61759961->61834300
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5580 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-19 23:04:26 +00:00
fischman@webrtc.org
358e3367a3 PeerConnection(java): enable HW encoder on N5 for standalone build.
Now that bug 2899 is fixed (r5562) packet-loss is recoverable.  Yay.

BUG=2575
R=noahric@google.com

Review URL: https://webrtc-codereview.appspot.com/8869004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5568 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-18 17:29:37 +00:00
fischman@webrtc.org
c2d75e0708 PeerConnection(java): account for thread shutdown vagaries.
Android's JVM requires threads to detach before they exit, but ONLY if
they needed to AttachCurrentThread.  Conversly, threads that were
attached by the JVM (e.g. the result of making a native call from Java)
must NOT be detached by the application.  This is bug 2441.

The fix for the above is to only pthread_setspecific() for threads that
Attach(), not for already-attached threads.  To ensure that we only
detach Attached threads, added a GetEnv() call to ThreadDestructor(),
which revealed that Oracle's JVM can overly-eagerly clear TLS accounting
data, effectively detaching threads without their consent at shutdown.
Work around this with a specific check.

To guard against (some) regression, added a variant of PeerConnectionTest
that runs on a non-main thread.  This revealed a bug in LinuxDeviceManager
which implicitly assumes its talk_base::Thread has already been
initialized.  Fixed that here too.

BUG=2441
R=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8759004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5567 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-18 16:57:36 +00:00
fischman@webrtc.org
a3708ecdfe PeerConnectionTest(java): unbreak following 61460797-p10
BUG=1414
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8719004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5550 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-14 01:51:33 +00:00
mallinath@webrtc.org
385857dfd4 Update talk to 61549749.
TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8709004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5549 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-14 00:56:12 +00:00
wu@webrtc.org
b9a088b920 Update talk to 61538839.
TBR=mallinath

Review URL: https://webrtc-codereview.appspot.com/8669005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5548 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-13 23:18:49 +00:00
wu@webrtc.org
0de29504ab Revert 5545 "Update libjingle to 61514460"
> Update libjingle to 61514460
> 
> TBR=tommi@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/8649004

TBR=xians@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8669004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5547 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-13 19:54:28 +00:00
xians@webrtc.org
e749c9ebdb Update libjingle to 61514460
TBR=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8649004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5545 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-13 15:09:40 +00:00
fischman@webrtc.org
3eda643a91 PeerConnection(java): added MediaConstraints support to AudioSource, now fed to AudioTrack.
BUG=2912
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8509004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5540 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-13 04:01:04 +00:00
fischman@webrtc.org
540acde5b3 PeerConnection(java): use MediaCodec for HW-accelerated video encode where available.
Still disabled by default until https://code.google.com/p/webrtc/issues/detail?id=2899 is resolved.

Also (because I needed them during development):
- make AppRTCDemo "debuggable" for extra JNI checks
- honor audio constraints served by apprtc.appspot.com
- don't "restart" video when it hasn't been stopped (affects running with the
  screen off)

BUG=2575
R=noahric@google.com

Review URL: https://webrtc-codereview.appspot.com/8269004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5539 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-13 03:56:14 +00:00
sergeyu@chromium.org
9cf037b831 Update libjingle to 61168196
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8139004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5502 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-07 19:03:26 +00:00
fischman@webrtc.org
6e08228525 PeerConnectionTest(java): remove the obsolete magical names of streams & tracks.
BUG=1253
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7929005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5478 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-03 19:15:44 +00:00
fischman@webrtc.org
a06ebab1e1 PeerConnectionTest(java): test SCTP DataChannels.
BUG=1408,2253,2626
R=jiayl@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7929004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5477 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-03 19:11:29 +00:00
mallinath@webrtc.org
67ee6b9a62 Update talk to 60923971
Review URL: https://webrtc-codereview.appspot.com/7909004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5475 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-03 16:57:16 +00:00
jiayl@webrtc.org
808b99b111 Disable a test assert which fails due to usrsctp not cleaned up in SctpDataEngine.cc
BUG=2749
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7739005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5460 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-29 19:44:40 +00:00
jiayl@webrtc.org
a576faf82a Enable SCTP and use OPENSSL on Anroid and NSS on other platforms.
It includes unit test fixes to properly initialize SSL if DTLS or SSL random number generator is used in the tests.
The private key and certificate constant strings used in some tests are updated to be compatible with NSS.
A few potentially overflow type conversions caused compiling warning on Windows and they are fixed by importing and using Chromium's checked_cast, which aborts the program if overflow occurs.
It also fixes a leak in nssstreamadapter.cc by releasing the PRFileDesc* in StreamClose.

BUG=2253
R=fischman@webrtc.org, juberti@google.com, wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/4679005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5459 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-29 17:45:53 +00:00
mallinath@webrtc.org
0dac5378e5 Revert 5447 "Update talk to 60420316."
> Update talk to 60420316.
> 
> TBR=wu@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/7719005

TBR=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7729004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5448 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-28 06:58:42 +00:00
mallinath@webrtc.org
752a017809 Update talk to 60420316.
TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7719005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5447 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-28 06:45:52 +00:00
wu@webrtc.org
a8910d2f88 Update talk to 60094938.
Review URL: https://webrtc-codereview.appspot.com/7489005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5420 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-23 22:12:45 +00:00
mallinath@webrtc.org
0d92ef67c4 Libjingle source code has some spelling mistakes and one of them is "renegotation", which should be "renegotiation".
This CL is attempting to correct those.

BUG=2810
TBR=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7439004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5411 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-22 02:21:22 +00:00
mallinath@webrtc.org
68cbd01216 enabling disabled data channels tests on win32. The real culprit was that ice candidates not included in SDP when there were failure causing transport channels never becoming writable.
BUG=2799
R=jiayl@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7369004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5410 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-22 00:16:46 +00:00
sergeyu@chromium.org
4b26e2eee3 Update libjingle to 59676287
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7229004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5390 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-15 23:15:54 +00:00
henrika@webrtc.org
aebb1ade9d pRevert 5371 "Revert 5367 "Update talk to 59410372.""
> Revert 5367 "Update talk to 59410372."
> 
> > Update talk to 59410372.
> > 
> > R=jiayl@webrtc.org, wu@webrtc.org
> > 
> > Review URL: https://webrtc-codereview.appspot.com/6929004
> 
> TBR=mallinath@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/6999004

TBR=henrika@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7109004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5381 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-14 10:00:58 +00:00
fischman@webrtc.org
d7568a08c3 PeerConnection(java): Add OnRenegotiationNeeded support
Also:
- Make PeerConnectionObserver::OnRenegotiationNeeded() pure virtual to avoid
  this sort of mistake in the future.
- Sprinkle @Override annotations on some callback definitions that were missing
  them.
- Fix a JNI method-signature-lookup typo (s/(V)V/()V/) in PCOJava::OnError()
- Add an explicit ScopedLocalFrameRef to PCOJava::OnError() to match all other
  C++-fired callbacks, for consistency.

BUG=2771
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6829004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5376 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-13 22:04:12 +00:00
henrika@webrtc.org
44461fa5cb Revert 5367 "Update talk to 59410372."
> Update talk to 59410372.
> 
> R=jiayl@webrtc.org, wu@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/6929004

TBR=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6999004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5371 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-13 09:35:02 +00:00
mallinath@webrtc.org
0f3356e20b Update talk to 59410372.
R=jiayl@webrtc.org, wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6929004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5367 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-11 01:26:23 +00:00
fischman@webrtc.org
4177615e87 PeerConnection(java): replace ScopedLocalRef with ScopedLocalRefFrame and fix a local reference leak in OnMessage.
Hopefully the approach of pushing/popping frames will be easier to avoid messing up than remembering to annotate every single local reference with a ScopedLocalRef.

BUG=2761
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6729004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5355 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-09 00:31:17 +00:00
fischman@webrtc.org
af320fd2f7 The designated initializer method declaration in the Objective-C headers for RTCICEServer does't match its implementation.
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6019004

Patch from Rafael Lopez Diez <rafalopezdiez@gmail.com>.

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5309 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-17 21:33:27 +00:00
fischman@webrtc.org
5b3c67ef25 objc/README: Remove outdated advice about target_os.
BUG=chromium:248168
TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5979005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5302 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-16 17:15:19 +00:00
mallinath@webrtc.org
62451dcba0 Update talk to 58157731.
R=wu@webrtc.org

TBR=wu@webrc.org

Review URL: https://webrtc-codereview.appspot.com/5339005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5282 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-13 12:29:34 +00:00
wu@webrtc.org
a9890800e0 Update talk to 58127566 together with
https://webrtc-codereview.appspot.com/5309005/.

R=mallinath@webrtc.org, niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5719004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5277 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-13 00:21:03 +00:00
wu@webrtc.org
2018269dc3 Revert 5274 "Update talk to 58113193 together with https://webrt..."
> Update talk to 58113193 together with https://webrtc-codereview.appspot.com/5309005/.
> 
> R=mallinath@webrtc.org, niklas.enbom@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/5719004

TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5729004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5275 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-12 22:54:25 +00:00
wu@webrtc.org
a129b6cd13 Update talk to 58113193 together with https://webrtc-codereview.appspot.com/5309005/.
R=mallinath@webrtc.org, niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5719004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5274 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-12 22:40:39 +00:00
fischman@webrtc.org
f41f06b916 PeerConnection(java): rationalize pointer-to-jlong conversion.
In r4665 I went a bit crazy with the manual reinterpretation of a pointer to a
jlong (to avoid undefined behavior) but that's what reinterpret_cast<> is for.
So use it directly now.
Added a do-nothing DataChannel to AppRTCDemo to regression test this, since the
only repro I've found of the original bug requires ARM ABI (PeerConnectionTest
on ia32 fails to repro).

BUG=2302
R=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5489004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5269 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-11 21:07:18 +00:00
wu@webrtc.org
9caf2765b2 Update talk to 58037405.
R=sergeyu@chromium.org

Review URL: https://webrtc-codereview.appspot.com/5579004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5267 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-11 18:25:07 +00:00
fischman@webrtc.org
eb7def234e Fix compilation errors on Fedora 20.
peerconnection_jni.cc: syscall() comes from <unistd.h>
RTPtimeshift.cc: char* being compared to 0 instead of the atoi() of it
rtp_payload_registry_unittest.cc: avoid narrowing int to uint32.

BUG=2700
R=andrew@webrtc.org, fischman@webrtc.org, henrik.lundin@webrtc.org, henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5019004

Patch from Victor Costan <costan@gmail.com>.

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5248 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-09 21:34:30 +00:00
sergeyu@chromium.org
5bc25c41fc Update libjingle to 57692857
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/4999004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5217 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-05 00:24:06 +00:00
fischman@webrtc.org
e0034557a7 RTCPeerConnection(objc): avoid leaking ICE candidate on addition.
BUG=2670
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/4379004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5199 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-02 18:49:54 +00:00
wu@webrtc.org
b43202d839 Disable PeerConnectionEndToEndTest for tsanv2 build.
BUG=1205
TEST=try
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/4279004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5162 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-22 19:14:25 +00:00
wu@webrtc.org
364f204d16 Update talk to 56698267.
TBR=sergeyu@chromium.org

Review URL: https://webrtc-codereview.appspot.com/4119004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5143 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-20 21:49:41 +00:00
sergeyu@chromium.org
a23f0ca4ba Update talk to 56619788
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/3839005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5120 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-13 22:48:52 +00:00
fischman@webrtc.org
7b273a545d PeerConnection iOS: update README instructions
This is needed to account for https://codereview.chromium.org/25535004/

R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/3059004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5079 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-04 18:48:12 +00:00
wu@webrtc.org
07a6fbe83d Update talk to 56092586.
R=jiayl@webrtc.org, mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/3359004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5078 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-04 18:41:34 +00:00
wu@webrtc.org
de305014c6 Update talk to 55906045.
Review URL: https://webrtc-codereview.appspot.com/3159005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5065 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-31 15:40:38 +00:00
wu@webrtc.org
cecfd1832d Update talk to 55821645.
TEST=try bots
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/3139004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5053 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-30 05:18:12 +00:00
fischman@webrtc.org
9ca93a8b8e Explicitly @synthesize ObjC @properties
This is required after https://code.google.com/p/gyp/source/detail?r=1768
turned on -Wobjc-missing-property-synthesis for ninja builds (until then it
was only enabled for xcode builds) to allow chromium_deps to roll in
webrtc/DEPS.

BUG=2560
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/3089004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5047 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-29 00:14:15 +00:00
wu@webrtc.org
97077a3ab2 Update libjingle to 55618622.
Update libyuv to r826.

TEST=try bots
R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2889004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5038 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-25 21:18:33 +00:00
wu@webrtc.org
8804a29951 Add CriticalSection to fakeaudiocapturemodule to protect the variables which will be accessed from process_thread_ and the main thread.
TEST=try bots
BUG=1205
R=henrike@webrtc.org, kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2419004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5019 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-22 23:09:20 +00:00
andrew@webrtc.org
31628aae7e Upgrade scoped_ptr to Chromium's latest version.
Analogous to the recent libjingle change: http://cl/54929753-p10.
This supports scoped_ptr<T[]> and scoped_ptr<C, FreeDeleter> rather
than scoped_array and scoped_ptr_malloc respectively.

- Add Chromium's template-based COMPILE_ASSERT. We didn't have this
previously in order to support the macro in C. Instead, move the
existing macro to compile_assert_c.h.
- Additionally copy the move.h and template_util.h depedencies and add
the WARN_UNUSED_RESULT macro.
- Leave scoped_array and scoped_ptr_malloc for now, but mark as
deprecated.
- Remove scoped_ptr foo(NULL) use. The default constructor handles it.
- Remove the now redundant COMPILE_ASSERT from peerconnection_jni.cc.
- Add a CHECK_ARRAY_SIZE macro to rtp_format_vp8_unittest.cc to remove
some repeated code.

TESTED=trybots
R=pbos@webrtc.org, tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2449005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5015 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-22 12:50:00 +00:00
mallinath@webrtc.org
50bc553852 Reenable DTLS renegotiation unittest in libjingle.
This test is failing on memcheck bots. After investigation problem per
say is not in this particular unittest and rather is in suite. So this test
is added to memcheck exclude list.

R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2689004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5011 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-21 17:58:35 +00:00
wu@webrtc.org
1d1ffc9ad2 Update talk to 54898858.
TEST=try bots
TBR=mallinath

Review URL: https://webrtc-codereview.appspot.com/2414004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4979 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-16 18:12:02 +00:00
kjellander@webrtc.org
d1cfa7149e TSan v2 suppressions and exclusions for libjingle tests.
Add suppressions for libjingle tests so they pass under TSan v2.
Disable the following tests for TSan v2 (only) since they're failing:
* StunServerTest.TestGood
* JsepPeerConnectionP2PTestClient.*

See build logs at:
http://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20Tsan%20v2/
for more details.

BUG=1205,2078,2079,2080,2517
TEST=Ran a successful run of each test locally on Linux using:
GYP_DEFINES='tsan=1 linux_use_tcmalloc=0 release_extra_cflags="-gline-tables-only"' gclient runhooks
ninja -C out/Release
For each test, run standing in trunk/:
TSAN_OPTIONS="suppressions=tools/valgrind-webrtc/tsan_v2/suppressions.txt print_suppressions=1 report_signal_unsafe=0 report_thread_leaks=0 history_size=7" out/Release/[libjingle_testname]
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2411004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4977 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-16 16:51:52 +00:00
mallinath@webrtc.org
6fa456f928 Disabling the DTLS renegotiation test case for PeerConnection.
Currently it's failing on Linux memcheck, most likely due to timing issues.

TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2394006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4962 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-15 00:11:54 +00:00
mallinath@webrtc.org
19f27e6a24 Update talk to 54527154.
TBR=wu

Review URL: https://webrtc-codereview.appspot.com/2389004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4954 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-13 17:18:27 +00:00