generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

RTCPeerConnectionTest(objc): deflake by ignoring ICECompleted.

Browse Source 
Delivery of the state seems intermittent at best on OS/X so
ignore it until we can make it reliable.

BUG=1414,2993,chromium:348982
TBR=bemasc@chromium.org

Review URL: https://webrtc-codereview.appspot.com/9609004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5664 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
fischman@webrtc.org 2014-03-08 03:17:55 +00:00
parent 13320ea3d3
commit a01daf0359
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
talk/app/webrtc/objctests/RTCPeerConnectionSyncObserver.m
View File

@ -183,6 +183,9 @@
- (void)peerConnection:(RTCPeerConnection *)peerConnection
iceConnectionChanged:(RTCICEConnectionState)newState {
// See TODO(fischman) in RTCPeerConnectionTest.mm about Completed.
if (newState == RTCICEConnectionCompleted)
return;
int expectedState = [self popFirstElementAsInt:_expectedICEConnectionChanges];
NSAssert(expectedState == (int)newState, @"Empty expectation array");
}

4
talk/app/webrtc/objctests/RTCPeerConnectionTest.mm
View File

@ -181,7 +181,9 @@
[offeringExpectations expectICEConnectionChange:RTCICEConnectionChecking];
[offeringExpectations expectICEConnectionChange:RTCICEConnectionConnected];
[offeringExpectations expectICEConnectionChange:RTCICEConnectionCompleted];
// TODO(fischman): figure out why this is flaky and re-introduce (and remove
// special-casing from the observer!).
// [offeringExpectations expectICEConnectionChange:RTCICEConnectionCompleted];
[answeringExpectations expectICEConnectionChange:RTCICEConnectionChecking];
[answeringExpectations expectICEConnectionChange:RTCICEConnectionConnected];