mflodman@webrtc.org
2877bdc590
Cleaned up resource leaks.
...
BUG=C-10059, C-10228, C-10229.
Review URL: https://webrtc-codereview.appspot.com/345013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1439 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-17 12:18:16 +00:00
mflodman@webrtc.org
7b3f3b1e42
CalcBufferSize can return -1, which wasn't handled by ViERenderer.
...
BUG=C-10532
Review URL: https://webrtc-codereview.appspot.com/345010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1438 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-17 12:12:42 +00:00
pwestin@webrtc.org
df9bd9bdbd
Removed dead code.
...
Review URL: https://webrtc-codereview.appspot.com/352010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1437 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-17 11:42:02 +00:00
pwestin@webrtc.org
aafa5a331c
Coverty report: Unititialized members
...
Review URL: http://webrtc-codereview.appspot.com/349007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1436 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-17 07:07:37 +00:00
asapersson@webrtc.org
43b8fc5c0d
Review URL: http://webrtc-codereview.appspot.com/345011
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1435 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-16 13:49:04 +00:00
phoglund@webrtc.org
c12f815de6
Rewrote hardware test and fixed broken tests on Windows.
...
Fixed broken tests on Windows, including old tests.
Rewrote hardware test.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/347008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1434 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-16 12:40:18 +00:00
stefan@webrtc.org
8ddf9a4e18
Ported more jitter buffer tests to unit tests.
...
BUG=
TEST=jitter_buffer_unittest
Review URL: http://webrtc-codereview.appspot.com/350009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1433 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-16 11:59:01 +00:00
asapersson@webrtc.org
869ce2d441
Review URL: http://webrtc-codereview.appspot.com/353002
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1432 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-16 11:58:36 +00:00
asapersson@webrtc.org
0b3c35a258
Review URL: http://webrtc-codereview.appspot.com/321011
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1431 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-16 11:06:31 +00:00
mflodman@webrtc.org
67cdc22e7e
CpuLinux file handle leak.
...
BUG=crbug.com/110165
Review URL: http://webrtc-codereview.appspot.com/353001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1429 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-16 09:31:39 +00:00
henrika@webrtc.org
f75901fa4c
Resolves CID 10540: Copy into fixed size buffer (STRING_OVERFLOW).
...
You might overrun the 32 byte fixed-size string "receiveCodec.plname" by copying "payloadName" without checking the length.
Note: This defect has an elevated risk because the source argument is a parameter of the current function.
Review URL: http://webrtc-codereview.appspot.com/352009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1428 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-16 08:45:42 +00:00
braveyao@webrtc.org
f5c6573725
fix defect http://code.google.com/p/webrtc/issues/detail?id=215 , audio device is not stopped appropriately.
...
Review URL: http://webrtc-codereview.appspot.com/350008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1427 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-16 03:04:46 +00:00
leozwang@webrtc.org
03b7f50a48
Enable apm in android.mk
...
Review URL: http://webrtc-codereview.appspot.com/345009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1426 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-14 01:03:56 +00:00
andrew@webrtc.org
c8d012fb32
Use -msse2 for SSE2 optimized code.
...
When targeting 32-bit Linux, we need to pass -msse2 to gcc to compile
SSE2 intrinsics. However, -msse2 also gives gcc license to automatically
generate SSE2 instructions wherever it pleases. This will crash our code
on processors without SSE2 support.
This change breaks the files with SSE2 intrinsics into separate targets,
such that we can limit the scope of -msse2 to where it's needed.
We no longer need to employ the WEBRTC_USE_SSE2 define; the build system
decides when SSE2 is supported and compiles the appropriate files.
TBR=bjornv@webrtc.org
TEST=audioproc (performance testing), audioproc_unittest, video_processing_unittests, build on Linux (targeting ia32/x64, with disable_sse2==0/1), Mac, Windows
Review URL: http://webrtc-codereview.appspot.com/352008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1425 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-13 19:43:09 +00:00
andrew@webrtc.org
ee3fe5b982
Remove unused variable from mixer module.
...
R=henrike@webrtc.org
BUG=coverity-10288
Review URL: http://webrtc-codereview.appspot.com/344010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1424 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-13 17:54:57 +00:00
braveyao@webrtc.org
5f9a7baaea
Review URL: http://webrtc-codereview.appspot.com/347012
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1423 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-13 10:22:44 +00:00
mflodman@webrtc.org
117c119501
Only update REMB value if there is a calid bitrate estimate.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/352005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1421 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-13 08:52:58 +00:00
henrik.lundin@webrtc.org
33d5f69d5e
Fix issue 218 with new solution
...
This one is slightly more elegant and efficient.
BUG=http://code.google.com/p/webrtc/issues/detail?id=218
TEST=
Review URL: http://webrtc-codereview.appspot.com/344009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1420 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-13 07:46:50 +00:00
andrew@webrtc.org
7859e10985
Propagate decoding errors to the mixer module.
...
Review URL: http://webrtc-codereview.appspot.com/348001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1417 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-13 00:30:11 +00:00
stefan@webrtc.org
c8277db7c8
Fix selective retransmissions after corrupt merge in r1373.
...
BUG=228
TEST=
Review URL: http://webrtc-codereview.appspot.com/345006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1414 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-12 15:38:50 +00:00
pwestin@webrtc.org
9cbe6867e7
Removed experiment.
...
Review URL: http://webrtc-codereview.appspot.com/345005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1413 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-12 15:35:28 +00:00
stefan@webrtc.org
ad4af57abd
Fixes a jitter buffer NACK bug.
...
If no frame has been decoded the jitter buffer might generate huge
erroneous NACK lists.
Adds a couple of new jitter buffer unittests (some ported from
jitter_buffer_test.cc).
Adds a test to the VCM robustness tests.
BUG=226
TEST=VCMRobustnessTest, TestJitterBufferFull, TestNackListFull, TestNackBeforeDecode, TestNormalOperation
Review URL: http://webrtc-codereview.appspot.com/352002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1412 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-12 15:16:49 +00:00
mflodman@webrtc.org
80d60420ff
RTCPSender::_bitrate_observer not initialized.
...
BUG=227
TEST=Valgrind
Review URL: http://webrtc-codereview.appspot.com/352004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1410 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-12 14:28:53 +00:00
perkj@webrtc.org
5735a63e5a
Add video capture module to the list of dependent projects in video engine.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/348007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1409 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-12 14:22:58 +00:00
henrik.lundin@webrtc.org
053c7991e3
Add minimum waiting time to NetEQ metrics
...
Adding minWaitingTimeMs to ACMNetworkStatistics and to
NetworkStatistics. Also adding unittest.
TEST=audio_coding_unittests
Review URL: http://webrtc-codereview.appspot.com/350006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1408 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-12 14:16:44 +00:00
bjornv@webrtc.org
40ea5106f6
Refactoring vad_filterbank
...
Made internal function LogOfEnergy() more efficient.
Includes
- Name change "vector" -> "data"
- Complete refactor of LogOfEnergy()
- Removed lint warning
Major changes:
* Removed unnecessary variables
* Reduced number of shifts
* Removed one norm calculation
TEST=vad_unittests, audioproc_unittest
Review URL: http://webrtc-codereview.appspot.com/347004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1407 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-12 12:47:42 +00:00
kjellander@webrtc.org
b39a3b4a7a
Restoring unintentially renamed MS DirectShow source files in
...
http://webrtc-codereview.appspot.com/348005/
BUG=
TEST=Compiling on Linux, Mac and Windows.
Review URL: http://webrtc-codereview.appspot.com/352003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1406 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-12 12:22:03 +00:00
kjellander@webrtc.org
7f3c724e12
Renaming 47 files from .cpp to .cc
...
In addition to our naming guidelines, this will cause these files to get parsed by Sonar, and to make searching/grepping the source using file extensions easier in the future.
BUG=
TEST=Compiling on Linux.
Review URL: http://webrtc-codereview.appspot.com/348005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1405 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-12 10:23:41 +00:00
kjellander@webrtc.org
93546f8ed6
Removing unused file
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/347010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1404 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-12 10:00:33 +00:00
niklas.enbom@webrtc.org
553657b2f8
See http://codereview.chromium.org/9188022/ for details
...
Review URL: http://webrtc-codereview.appspot.com/347009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1403 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-12 08:49:34 +00:00
punyabrata@webrtc.org
9a85b500c5
Minor tracing fix in ::IncomfingFrame and ::IncomfingFrameI420
...
Review URL: http://webrtc-codereview.appspot.com/352001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1401 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-12 00:37:07 +00:00
andrew@webrtc.org
83c7f6db0e
Add missing file to iSAC gyp.
...
TBR=kma@webrtc.org
TEST=Linux build
Review URL: http://webrtc-codereview.appspot.com/344008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1394 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-11 20:16:32 +00:00
andrew@webrtc.org
921321ff62
Fix unused-variable warning in iSAC.
...
TBR=kma@webrtc.org
TEST=build on Linux
Review URL: http://webrtc-codereview.appspot.com/348006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1393 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-11 19:50:20 +00:00
kma@webrtc.org
badf2b8044
Optimized an AR function in iSAC fix for ARMv7 (not Neon) platforms.
...
Bit exact. Speed doubled.
Review URL: http://webrtc-codereview.appspot.com/327001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1392 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-11 18:01:39 +00:00
mflodman@webrtc.org
04c18cb37a
Update all child modules of with received bandwidth estimate.
...
BUG=224
Review URL: http://webrtc-codereview.appspot.com/347007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1391 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-11 14:18:33 +00:00
stefan@webrtc.org
cd8cea50a6
Fix decode error in NACK/FEC mode after network glitch.
...
Caused when recyclingframes until the next key frame to
regain frame buffers when the jitter buffer is full.
BUG=http://code.google.com/p/webrtc/issues/detail?id=225
TEST=
Review URL: http://webrtc-codereview.appspot.com/350005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1390 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-11 14:17:44 +00:00
mflodman@webrtc.org
684c7b71c3
Fixed vie_defines.h typo.
...
BUG=220
TEST=Mac debug build
Review URL: http://webrtc-codereview.appspot.com/347006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1389 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-11 13:52:06 +00:00
mflodman@webrtc.org
5007056767
Added REMB option to custom call.
...
Review URL: http://webrtc-codereview.appspot.com/347003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1388 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-11 13:46:10 +00:00
perkj@webrtc.org
ce5990cb0b
Fix defect http://code.google.com/p/webrtc/issues/detail?id=222
...
"ViE GetSentRTCPStatistics fails on a sending channel if it don't receive rtp video packets.
BUG=222
TEST= tested in loopback. No new test added yet.
Review URL: http://webrtc-codereview.appspot.com/343003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1387 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-11 13:00:08 +00:00
phoglund@webrtc.org
01530a2ac2
Rewrote the rcp_rtcp test.
...
Finished rewriting the rtp_rtcp test.
Rewrote first RTP RTCP test
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/342007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1386 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-11 12:26:34 +00:00
tina.legrand@webrtc.org
6b6ff558a8
Implementation if mono-to-stereo and vice versa in ACM.
...
Added stereo-to-mono and mono-to-stereo tests to end of TestStereo.cpp.
BUG=Aim to resolve issue 207, "Investigate stereo capture handling in modules"
TEST=audio_coding_module_test
Review URL: http://webrtc-codereview.appspot.com/345002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1385 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-11 10:12:54 +00:00
pwestin@webrtc.org
df9866fedb
Bugfix mac pid_t
...
Review URL: http://webrtc-codereview.appspot.com/350004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1384 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-11 08:57:47 +00:00
pwestin@webrtc.org
b54d72778c
Changed thread Id handling in trace.
...
Review URL: http://webrtc-codereview.appspot.com/331020
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1383 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-11 08:28:04 +00:00
braveyao@webrtc.org
e3eaf44ccf
one logical enhancement in CoreAudio error handler. It should never happen, but so far the only suspect to a rare crash report.
...
Review URL: http://webrtc-codereview.appspot.com/349002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1382 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-11 03:07:52 +00:00
andrew@webrtc.org
681172ef1e
Add libsrtp to .gitignore.
...
TBR=mallinath@webrtc.org
Review URL: http://webrtc-codereview.appspot.com/349004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1379 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-11 01:54:55 +00:00
stefan@webrtc.org
c5b73e3974
Further cleanup of OverUseDetector. Removed member no longer used.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/344007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1377 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-10 16:42:09 +00:00
leozwang@webrtc.org
e1fe43358f
Comment out one more component which is forgot in last CL
...
Review URL: http://webrtc-codereview.appspot.com/342005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1376 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-10 16:14:36 +00:00
pwestin@webrtc.org
a1783598a7
Bugfix for clang.
...
Review URL: http://webrtc-codereview.appspot.com/351001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1375 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-10 15:33:40 +00:00
pwestin@webrtc.org
5d35ceb34a
Bugfix array length in test.
...
Review URL: http://webrtc-codereview.appspot.com/343007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1374 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-10 15:06:09 +00:00
pwestin@webrtc.org
8281e7dd4a
Added RTX to ViE.
...
Review URL: http://webrtc-codereview.appspot.com/336001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1373 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-10 14:09:18 +00:00