Commit Graph

274 Commits

Author SHA1 Message Date
henrike@webrtc.org
09b0c10eed Talk: fixes warning: local variable is initialized but not referenced due to only using the variable in question for asserts.
BUG=N/A
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/11249004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5848 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-04 22:33:34 +00:00
fischman@webrtc.org
d1fe6b728e AppRTCDemo(android): fix a couple of SDP-related regressions.
- r5834 made it so that empty fields are a fatal SDP parsing error, exposing
  opportunities for improvement in the preferISAC; changed split/join to use
  \r\n instead of \n and now omitting the trailing space on the m=audio line
  that triggered the new failure.
- DTLS requires a different role for each endpoint so conflicts with loopback
  calling.  apprtc.py suppresses DTLS for that reason in loopback calls, so the
  android demo app now only enables DTLS by default if it is not suppressed by a
  constraint (matching Chrome).

BUG=3164,3165,2507
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/11229004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5847 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-04 21:40:46 +00:00
henrike@webrtc.org
f5bebd40f3 (Auto)update libjingle 64247466-> 64326665
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5845 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-04 18:39:07 +00:00
wu@webrtc.org
148149138d (Auto)update libjingle 64147530-> 64247466
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5835 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-02 23:25:15 +00:00
wu@webrtc.org
5e760e7b94 Check the return value of the FromString call and return failure when then value is invalid. I.e. uses
bool FromString(const std::string& s, T* t)
instead of
T FromString(const std::string& str)

Before this change we will silently continue the parsing and take whatever default value returned by FromString.

TEST=new tests
BUG=2507
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/11069004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5834 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-02 23:19:09 +00:00
wu@webrtc.org
e387771b98 Remove webrtc_unittest.cc from talk presubmit script.
BUG=
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/11059004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5833 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-02 22:23:16 +00:00
wu@webrtc.org
05e7b44b83 (Auto)update libjingle 63948945-> 64147530
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5825 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-01 17:44:24 +00:00
fischman@webrtc.org
49c5ba32bb AppRTCDemo(iOS): now works in the iOS Simulator!
...which has no camera device emulation or pass-through, so no local video
view.

R=noahric@google.com

Review URL: https://webrtc-codereview.appspot.com/10919004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5815 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-31 20:22:19 +00:00
fischman@webrtc.org
61e78fca6c AppRTCDemo(iOS): remote-video reliability fixes
Previously GAE Channel callbacks would be handled by JS string-encoding the
payload into a URL.  Unfortunately this is limited to the (undocumented,
silently problematic) maximum URL length UIWebView supports.  Replaced this
scheme by a notification from JS to ObjC and a getter from ObjC to JS (which
happens out-of-line to avoid worrying about UIWebView's re-entrancy, or lack
thereof).  Part of this change also moved from a combination of: JSON,
URL-escaping, and ad-hoc :-separated values to simply JSON.

Also incidentally:
- Removed outdated TODO about onRenegotiationNeeded, which is unneeded
- Move handling of PeerConnection callbacks to the main queue to avoid having
  to think about concurrency too hard.
- Replaced a bunch of NSOrderedSame with isEqualToString for clearer code and
  not having to worry about the fact that [nil compare:@"foo"]==NSOrderedSame
  is always true (yay ObjC!).
- Auto-scroll messages view.

BUG=3117
R=noahric@google.com

Review URL: https://webrtc-codereview.appspot.com/10899006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5814 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-31 20:16:49 +00:00
fischman@webrtc.org
fe16488184 AppRTCDemo(android): specify DtlsSrtpKeyAgreement:true in CreatePeerConnection's constraints.
This is required to interop with Chrome now that SDES is disabled in Chrome (as of r5640).

BUG=2774
R=jiayl@chromium.org

Review URL: https://webrtc-codereview.appspot.com/10749004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5809 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-28 19:58:03 +00:00
fischman@webrtc.org
4f2bd68744 Silence pointless LS_WARNING about port 0 for active-only candidates.
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/10899004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5808 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-28 18:13:34 +00:00
wu@webrtc.org
987f2c9aae (Auto)update libjingle 63913264-> 63948945
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5807 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-28 16:22:19 +00:00
wu@webrtc.org
f7d501d48a (Auto)update libjingle 63884381-> 63913264
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5805 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-27 23:48:25 +00:00
andrew@webrtc.org
a5586b50e5 Protect ENABLE_PROFILING to fix profiling=1.
Chromium defines ENABLE_PROFILING under the gyp flag profiling=1. This
corrects the resulting mulitple defintion error:
../../talk/base/profiler.h:61:9: error: 'ENABLE_PROFILING' macro redefined [-Werror]
#define ENABLE_PROFILING

and allows us to use profiling=1 in standalone builds.

TESTED=build passes with profiling=1
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/10829004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5804 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-27 22:44:13 +00:00
wu@webrtc.org
cfe5e9c894 (Auto)update libjingle 63837929-> 63884381
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5800 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-27 17:03:58 +00:00
henrike@webrtc.org
b0ecc1c6fb (Auto)update libjingle 63777286-> 63837929
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5797 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-26 22:44:28 +00:00
fischman@webrtc.org
b25576a75b talk/: enable _DEBUG in Debug for all posix
Chromium's build/common.gypi defines _DEBUG for Debug builds _except_ on
(OS=="mac" OS=="ios").  But libjingle uses _DEBUG on all platforms so define it on all posix (chromium covers non-posix separately and fine).

BUG=webrtc:3101
R=juberti@google.com

Review URL: https://webrtc-codereview.appspot.com/10699004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5795 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-26 21:53:47 +00:00
henrike@webrtc.org
1ca08f65e3 Fix after auto update in r5787. APPRTCVideoView.h/m was removed incorrectly.
BUG=3121
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/10739004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5793 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-26 16:42:14 +00:00
henrike@webrtc.org
5fb7428496 (Auto)update libjingle 63775799-> 63776369
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5789 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-26 02:00:10 +00:00
henrike@webrtc.org
a92fd74f40 (Auto)update libjingle 63773382-> 63775799
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5788 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-26 01:46:18 +00:00
henrike@webrtc.org
dce3feb0b0 (Auto)update libjingle 63738002-> 63773382
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5787 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-26 01:17:30 +00:00
henrike@webrtc.org
ae3347a546 Fix after auto update: removed files were brought back.
BUG=N/A
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/10649004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5782 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-25 18:17:02 +00:00
fischman@webrtc.org
76d4f389bb AppRTCDemo(iOS): allow rooms with no incoming audio.
Also fix a compile-time warning for a leftover unimplemented method
(RTCVideoRenderer:setTransform).

R=noahric@google.com

Review URL: https://webrtc-codereview.appspot.com/10629004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5780 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-25 17:40:38 +00:00
henrike@webrtc.org
6e3dbc2a77 (Auto)update libjingle 63648983-> 63738002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5779 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-25 17:09:47 +00:00
fischman@webrtc.org
385a722646 PeerConnection(iOS): make ARC-clean talk/.../objc* and talk/examples/ios
- Removes a strong-reference cycle between RTCPeerConnection and
  RTCPeerConnectionObserver
- Gives RTCPeerConnectionObserver a virtual dtor
- Ensures RTCPeerConnectionTest tears down correctly
- Ensures AppRTCDemo tears down correctly

This is the talk/ half; the webrtc/ half is in https://webrtc-codereview.appspot.com/10539005

BUG=3054,3055,3100
R=noahric@google.com

Review URL: https://webrtc-codereview.appspot.com/10499005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5771 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-25 05:16:29 +00:00
sergeyu@chromium.org
e42b8ab129 Cleanups in libjingle to make it compile with chromium_code=1
Fixed all warnings that show up when compiling libjingle
in chromium with compiling with chromium_code=1.
chromium_code=1 enables various warnings that are off by
default. Most changes are for unused variables and consts.

R=pthatcher@google.com, wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/9699004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5769 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-25 00:31:35 +00:00
fischman@webrtc.org
7fa1fcb72c AppRTCDemo(ios): style/cleanup fixes following cr/62871616-p10
BUG=2168
R=noahric@google.com

Review URL: https://webrtc-codereview.appspot.com/9709004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5768 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-25 00:11:56 +00:00
fischman@webrtc.org
c693a2a624 PeerConnection(iOS): fix case in #import statements.
We've been skating by on OS/X's default case-insensitive filesystem, but this
is a bit silly.

This change brought to you by:
sed -i '' 's/\+internal\.h/+Internal.h/g' $(git grep -l '+internal.h')

BUG=3088
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/10559004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5764 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-24 18:56:37 +00:00
wu@webrtc.org
1e6cb2c5d2 (Auto)update libjingle 63560528-> 63648983
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5762 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-24 17:01:50 +00:00
henrike@webrtc.org
152208adeb (Auto)update libjingle 63547048-> 63560528
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5753 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-21 21:43:26 +00:00
henrike@webrtc.org
be7e26d229 (Auto)update libjingle 63503990-> 63547048
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5751 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-21 16:40:18 +00:00
mallinath@webrtc.org
0c6f0f94f1 Revert 5737 "Add system wrapper dependency to libjingle targets."
Adding additional dependency is not required for libjingle targets.

> Add system wrapper dependency to libjingle targets.
> This is necessary to handle usage of STR_CASE_CMP in
> common_types.h ( as in https://webrtc-codereview.appspot.com/10099005/)
> 
> TBR=wu@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/10309004

TBR=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/10379004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5744 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-20 23:07:03 +00:00
henrike@webrtc.org
5e83c65aee (Auto)update libjingle 63493960-> 63503990
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5743 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-20 22:33:30 +00:00
henrike@webrtc.org
a8ebdb71e3 Revert "(Auto)update libjingle 63363208-> 63493960" (r5740)
BUG=N/A
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/10349004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5741 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-20 20:27:25 +00:00
henrike@webrtc.org
5f768adc27 (Auto)update libjingle 63363208-> 63493960
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5740 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-20 20:18:06 +00:00
mallinath@webrtc.org
979f1f8235 Add system wrapper dependency to libjingle targets.
This is necessary to handle usage of STR_CASE_CMP in
common_types.h ( as in https://webrtc-codereview.appspot.com/10099005/)

TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/10309004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5737 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-20 15:09:09 +00:00
henrike@webrtc.org
ffe2620c97 (Auto)update libjingle 63352036-> 63363208
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5731 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-19 22:20:10 +00:00
henrike@webrtc.org
8b61011b6f (Auto)update libjingle 63293120-> 63352036
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5720 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-18 21:39:10 +00:00
henrike@webrtc.org
e9793ab8b8 (Auto)update libjingle 63111035-> 63293120
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5717 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-18 14:36:23 +00:00
henrike@webrtc.org
18e5911d92 (Auto)update libjingle 63089643-> 63111035
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5705 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-14 17:19:38 +00:00
henrike@webrtc.org
f45a55083f (Auto)update libjingle 63019975-> 63089643
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5699 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-13 18:51:34 +00:00
mallinath@webrtc.org
827faae0ec Fixing incorrect memset.
Found when ENABLE_EXTERNAL_AUTH is enabled in chrome.

TBR=ronghuawu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/9909004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5691 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-13 02:15:12 +00:00
henrike@webrtc.org
c7bec8484b (Auto)update libjingle 62948689-> 63019975
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5689 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-12 19:53:43 +00:00
henrike@webrtc.org
10bd88e2b5 (Auto)update libjingle 62871616-> 62948689
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5683 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-11 21:07:25 +00:00
henrike@webrtc.org
d3d6bce9ed (Auto)update libjingle 62865357-> 62871616
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5674 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-10 20:41:22 +00:00
henrike@webrtc.org
0537634154 (Auto)update libjingle 62713454-> 62865357
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5670 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-10 15:53:12 +00:00
fischman@webrtc.org
a01daf0359 RTCPeerConnectionTest(objc): deflake by ignoring ICECompleted.
Delivery of the state seems intermittent at best on OS/X so
ignore it until we can make it reliable.

BUG=1414,2993,chromium:348982
TBR=bemasc@chromium.org

Review URL: https://webrtc-codereview.appspot.com/9609004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5664 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-08 03:17:55 +00:00
fischman@webrtc.org
13320ea3d3 PeerConnectionTest(objc): expect ICE Completed state post 61460797-p10
Also a few trivial cleanups:
- No need to use STUN for a loopback test
- Reduce test call duration 10s->2s for faster iteration
- Remove obviously-irrelevant Info.plist entries (copy/pasta from iOS)

BUG=1414,2993
R=noahric@google.com

Review URL: https://webrtc-codereview.appspot.com/9369004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5663 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-07 22:15:30 +00:00
jiayl@webrtc.org
11aab0edc2 Populate VoiceReceiverInfo::delay_estimate_ms, jitter_buffer_ms, and jitter_buffer_preferred_ms to getStats.
BUG=2665
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/9579004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5661 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-07 18:56:26 +00:00
pbos@webrtc.org
371243dfa3 Remove std:: prefixes from C functions in talk/.
std::memcpy -> memcpy for instance. This change was motivated by a
compile report complaining that std::rand() was used instead of rand(),
probably with a stdlib.h include instead of cstdlib. Use of C functions
without the std:: prefix is a lot more common, so removing std:: to
address this.

BUG=
R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/9559004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5657 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-07 15:22:04 +00:00