Commit Graph

2008 Commits

Author SHA1 Message Date
phoglund@webrtc.org
0b7ba967f5 Fixed comments and added new flags for the PyAuto test.
The ChromeBloat bot will now also be ignored for LKGRs.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/559004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2169 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-03 14:21:14 +00:00
hta@webrtc.org
54536bb6d4 Refactoring of the TMMBRSet class, giving it a reasonably tight interface.
The CL also fixes a number of line length and tab issues in touched files.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/553005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2168 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-03 14:07:23 +00:00
pwestin@webrtc.org
3bc38c86e8 Fix color enhancement test.
Review URL: https://webrtc-codereview.appspot.com/553007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2167 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-03 13:15:35 +00:00
pwestin@webrtc.org
209442a560 Missing file
Review URL: https://webrtc-codereview.appspot.com/556005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2166 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-03 11:36:06 +00:00
pwestin@webrtc.org
e9727cdbaa Fixed some memory leaks.
Review URL: https://webrtc-codereview.appspot.com/558004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2165 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-03 11:32:25 +00:00
andrew@webrtc.org
63a509858d Rename AudioFrame members.
BUG=
TEST=trybots

Review URL: https://webrtc-codereview.appspot.com/542005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2164 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-02 23:56:37 +00:00
leozwang@webrtc.org
7fdb909339 Reformat and add more debug info into ViESurfaceRenderer
BUG=
TEST=test on android
Review URL: https://webrtc-codereview.appspot.com/546004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2163 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-02 16:45:55 +00:00
bjornv@webrtc.org
b286bfb13e VAD refactoring: Replaced hard coded array sizes with enum.
Further replaced hard coded calculations with a for loop for better understanding.

Tested with vad_unittests and audioproc_unittest.

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/519002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2162 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-02 12:14:57 +00:00
hta@webrtc.org
404843e6e5 Timeout tests for TMMBR
Added a test that injects 3 packets and then times out.

Rewrote the packet construction in test to use a builder format.
This makes tests a lot more readable.

Odd behaviour of timeout found; documented as test.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/553004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2161 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-02 09:56:45 +00:00
hta@webrtc.org
3c0df7d376 Fixed a build break: I'd forgotten to remove a DELETE statement.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/555004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2160 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-02 08:22:21 +00:00
hta@webrtc.org
47059b5dfb Adds unit tests for RTCP receiver, focusing on TMMBR handling.
This is the first part of a plan:

- Get basic unit tests for rtcp_receiver.
- Get an unit test for some code inside rtcp_receiver
  that touches the TMMBRSet class in hard-to-decipher ways
  (rtcp_receiver_help, GetTMMBRSet function, use of memmove()).
- Refactor the TMMBRSet class.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/547005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2159 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-02 07:46:22 +00:00
kjellander@webrtc.org
1e1dd170e0 Disabling PTY for mv command on Android bot.
BUG=None
TEST=Tested on local master with the Android bot slave.

Review URL: https://webrtc-codereview.appspot.com/552004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2158 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-02 07:45:27 +00:00
phoglund@webrtc.org
719dba7e79 Further cleaned up voe_standard_test.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/522003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2157 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-02 07:32:37 +00:00
phoglund@webrtc.org
dbb7f91f36 The ChromeBloat bot will now also be ignored for LKGRs.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/543004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2156 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-02 06:32:30 +00:00
fbarchard@google.com
efecc18cdf libyuv updates for better code generation on OSX clang for scale
BUG=478
TEST=build libyuv and disassemble scale.o with otool -tV.  Should use registers for C loops, not stack.
Review URL: https://webrtc-codereview.appspot.com/550005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2155 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-02 00:41:29 +00:00
andrew@webrtc.org
ecac9b721e Add tests for downmixing and no processing.
BUG=issue419
TEST=audioproc_unittest

Review URL: https://webrtc-codereview.appspot.com/532001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2154 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-02 00:04:10 +00:00
leozwang@webrtc.org
63ea5ef5da Regenerate jni files and bring audio alive
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/550004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2153 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-01 22:13:49 +00:00
andrew@webrtc.org
d5548f5d04 Disable clang Chrome plugins on all platforms.
(Will fix Linux-clang bot).

TBR=wu@webrtc.org
BUG=issue163
TEST=build on Linux-clang

Review URL: https://webrtc-codereview.appspot.com/545005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2152 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-01 21:39:34 +00:00
andrew@webrtc.org
fed1894330 Roll Chromium 132375:134666 and libyuv 216:254.
BUG=
TEST=trybots

Review URL: https://webrtc-codereview.appspot.com/539006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2151 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-01 21:03:10 +00:00
leozwang@webrtc.org
85b089a0ca Fix ConvertI420ToRGB565 bug
BUG=
TEST=test on android
Review URL: https://webrtc-codereview.appspot.com/541005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2150 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-30 17:59:08 +00:00
leozwang@webrtc.org
e7ac5fde72 Minor changes to remove dead code in opensl es
BUG=
TEST=build on all platforms
Review URL: https://webrtc-codereview.appspot.com/539004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2149 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-30 14:42:17 +00:00
hta@webrtc.org
65a4e4ed56 Minor refactoring: RTCPReceiver::BoundingSet
Remove ability to modify a pointer argument.

Added a test for transmitting a non-empty TMMBN

BUG=
TEST=unittest

Review URL: https://webrtc-codereview.appspot.com/542004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2148 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-30 11:23:41 +00:00
kjellander@webrtc.org
890aa0d2c0 Disabling HTTP status push on Build master since we're not using it
Also updated .gitignore

BUG=None
TEST=Tested on local master and production master.

Review URL: https://webrtc-codereview.appspot.com/539005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2147 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-30 09:56:57 +00:00
kjellander@webrtc.org
be0ac630a1 Overriding tgrid URL for master web status
The change in r2143 changed so we're reusing Chromium scripts for setting up the web status. However Chrome doesn't use the tgrid page it seems (they put the Console page on that URL instead) but we need it for our LKGR parsing.

BUG=None
TEST=Tested on local master.

Review URL: https://webrtc-codereview.appspot.com/541004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2146 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-30 09:15:57 +00:00
hta@webrtc.org
c2d985257b untabify
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2145 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-30 08:25:10 +00:00
hta@webrtc.org
9d54cd12ab TMMBN sender test passes, fixed receiver flag bug
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2144 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-30 08:24:55 +00:00
kjellander@webrtc.org
c6c4ffc5d8 Android trybots + fixing web status config
BUG=None
TEST=Tested on local master and slave.

Review URL: https://webrtc-codereview.appspot.com/514001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2143 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-30 07:59:09 +00:00
andrew@webrtc.org
5c0c18d823 Fix coverity issues in ACM.
Fixes: Big parameter passed by value (PASS_BY_VALUE)
Passing parameter codec of size 52 bytes by value.

BUG=
TEST=audio_coding_module_tests, trybots

Review URL: https://webrtc-codereview.appspot.com/529002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2142 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-27 17:06:48 +00:00
andrew@webrtc.org
a88cb6fce0 Add HighPassFilter and StereoChannelSwapping tests.
BUG=issue451
TEST=voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/531001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2141 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-27 17:00:20 +00:00
marpan@webrtc.org
2d0223286b VPM: fix to coverity issues 10255-10258 (unintended sign extension).
Review URL: https://webrtc-codereview.appspot.com/532002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2140 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-27 15:56:02 +00:00
phoglund@webrtc.org
ca08c41701 Replacing virtual camera on linux video bot: adaptings tests accordingly.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/537001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2139 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-27 12:38:17 +00:00
stefan@webrtc.org
2191a47bc1 Update ARM specific libvpx config files.
BUG=
TEST=
TBR=niklas.enbom@webrtc.org,leozwang@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/534002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2138 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-27 08:50:05 +00:00
pwestin@webrtc.org
b1313aac7c Fix missing h file change.
Review URL: https://webrtc-codereview.appspot.com/535001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2136 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-27 05:42:05 +00:00
pwestin@webrtc.org
49888ce428 Breaking out send side bitrate controll cont.
Review URL: https://webrtc-codereview.appspot.com/475004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2135 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-27 05:25:53 +00:00
mallinath@webrtc.org
e611619f60 Fixing the header file path in gypi file.
BUG=473
Review URL: https://webrtc-codereview.appspot.com/529001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2134 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-26 23:03:15 +00:00
andrew@webrtc.org
9c4f6a5ff9 Add an AudioFrameOperations unittest.
Additionally, reformat audio_frame_operations to Goog style.

BUG=issue451
TEST=voice_engine_unittests

Review URL: https://webrtc-codereview.appspot.com/528001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2133 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-26 22:32:03 +00:00
tommi@webrtc.org
e49d908baf Fix how we were using TbInterfaces and disallow operator=() and the copy constructor.
The reason is that this will cause a crash:

TbInterfaces foo = TbInterfaces("blah");


It relies on the generated copy constructor (or assignment operator), which copies the
pointer values from a temporary object.  After |foo| in this case has been initialized
with values from the temporary object, the temp goes out of scope and is deleted.
The result is that |foo| has been initialized with pointers do a deleted object.

Also fixing expectations for the return value of VoE Release() calls after I checked
in my change that makes the VoiceEngine per-object ref counted and not per-interface.
Review URL: https://webrtc-codereview.appspot.com/509005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2128 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-26 17:05:32 +00:00
tommi@webrtc.org
a990e122c4 * Change the reference counting implementation for VoE to be per object and
not per interface. This simplifies things a bit, reduces code and makes it
  possible to implement reference counting (if we ever want) without the
  static Delete() method.  (Reference counted objects are traditionally
  implicitly deleted via the last Release())

* Since the reference counting code is now simpler, there's no need for the
  RefCount class so I'm removing it.

* Also removing the optional |ignoreRefCounters| variable from the VoiceEngine::Delete
  method.  The justification is that it's no longer used and the reason it was there
  in the first place was to avoid bugs in third party code, so it's an indication that
  something is wrong elsewhere.

* Fix a crash in voe_network_impl and voe_extended_test that would happen on machines with IPv6 support.

* Fix an assert (handle the case) in the extended audio tests when SetCNAME is called with a NULL pointer.

* As a side effect of this change, hopefully the footprint of VoE will be slightly smaller :)

BUG=10445 (Coverity)
Review URL: https://webrtc-codereview.appspot.com/521003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2127 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-26 15:28:22 +00:00
phoglund@webrtc.org
497fb4fda9 Fixed vie_auto_test on mac so it will exit when the test completes instead of hanging like it used to.
Also applied an old patch I had which rewrites the window handling to do ui stuff on the main thread instead of the worker thread, which as far as I know is a very bad idea.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/502001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2126 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-26 12:58:02 +00:00
tina.legrand@webrtc.org
bc1b43b297 Refactoring of audio_coding_module_impl
First patch set: pure formatting.

Review URL: https://webrtc-codereview.appspot.com/522001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2125 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-26 08:53:45 +00:00
tina.legrand@webrtc.org
a6ecd1ebb5 Refactoring one of the ACM tests: TestStereo, to follow the style guide.
(First patch: formatting the test file)

TEST=audio_coding_module_test

Review URL: https://webrtc-codereview.appspot.com/507001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2124 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-26 07:54:30 +00:00
phoglund@webrtc.org
61331137b6 Reduced the time from check-in to build significantly.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/525001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2123 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-26 07:32:07 +00:00
mflodman@webrtc.org
1868780c81 Disabled UnremovedSocketsGetCollectedAtManagerDeletion in UdpSocketManager unittest.
TBR= hta@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/520004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2122 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-26 06:40:00 +00:00
andrew@webrtc.org
1c7bfe02f7 Fail silently when swapping mono.
TBR=tina.legrand@webrtc.org
BUG=issue451
TEST=forthcoming unittest

Review URL: https://webrtc-codereview.appspot.com/527003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2121 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-26 00:20:28 +00:00
stefan@webrtc.org
da12dde4d2 Upgrade libvpx to dba0538.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/521002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2119 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-25 19:16:00 +00:00
hta@webrtc.org
ad929899c7 Tests for udp_socket_manager.
These tests basically check that socket allocation does not leak memory.

BUG=
TEST=unittested, ran under valgrind.

Review URL: https://webrtc-codereview.appspot.com/519003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2118 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-25 14:06:50 +00:00
phoglund@webrtc.org
52884813ad Removed dependency which has moved into tools/DEPS.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/510003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2117 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-25 12:24:09 +00:00
phoglund@webrtc.org
6a65cfbb0e Enabled the new PyAuto test on the build bot.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/520003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2116 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-25 10:11:55 +00:00
asapersson@webrtc.org
d18dd6dc7e Made OnPacketLossStatisticsUpdate function virtual (needed for ViCE).
Review URL: https://webrtc-codereview.appspot.com/520002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2115 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-25 07:19:02 +00:00
andrew@webrtc.org
02d7174722 Add API to swap stereo channels.
BUG=issue451
TEST=manually with voe_cmd_test, using stereo and mono codecs

Review URL: https://webrtc-codereview.appspot.com/519001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2106 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-24 19:47:00 +00:00