generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fixes coverity warning that I missed in system wrappers.

Browse Source 
BUG=Coverity
TEST=N/A

Review URL: https://webrtc-codereview.appspot.com/395005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1717 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
henrike@webrtc.org 2012-02-17 16:27:25 +00:00
parent b3172860d7
commit f3760dc8e9
1 changed files with 15 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/system_wrappers/source/critical_section_posix.cc
View File

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2011 The WebRTC project authors. All Rights Reserved. * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
* *
* Use of this source code is governed by a BSD-style license * Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source * that can be found in the LICENSE file in the root of the source
@ -8,31 +8,39 @@
* be found in the AUTHORS file in the root of the source tree. * be found in the AUTHORS file in the root of the source tree.
*/ */
// General note: return values for the various pthread synchronization APIs
// are explicitly ignored here. In Chromium, the same thing is done for release.
// However, in debugging, failure in these APIs are logged. There is currently
// no equivalent to DCHECK_EQ in WebRTC code so this is the best we can do here.
// TODO(henrike): add logging when pthread synchronization APIs are failing.
#include "critical_section_posix.h" #include "critical_section_posix.h"
namespace webrtc { namespace webrtc {
CriticalSectionPosix::CriticalSectionPosix() CriticalSectionPosix::CriticalSectionPosix()
{ {
pthread_mutexattr_t attr; pthread_mutexattr_t attr;
pthread_mutexattr_init(&attr); (void) pthread_mutexattr_init(&attr);
pthread_mutexattr_settype(&attr, PTHREAD_MUTEX_RECURSIVE); (void) pthread_mutexattr_settype(&attr, PTHREAD_MUTEX_RECURSIVE);
pthread_mutex_init(&_mutex, &attr); (void) pthread_mutex_init(&_mutex, &attr);
} }
CriticalSectionPosix::~CriticalSectionPosix() CriticalSectionPosix::~CriticalSectionPosix()
{ {
pthread_mutex_destroy(&_mutex); (void) pthread_mutex_destroy(&_mutex);
} }
void void
CriticalSectionPosix::Enter() CriticalSectionPosix::Enter()
{ {
pthread_mutex_lock(&_mutex); (void) pthread_mutex_lock(&_mutex);
} }
void void
CriticalSectionPosix::Leave() CriticalSectionPosix::Leave()
{ {
pthread_mutex_unlock(&_mutex); (void) pthread_mutex_unlock(&_mutex);
} }
} // namespace webrtc } // namespace webrtc