From f3760dc8e95fdcfae8cee0648a6a761fc29d8aa8 Mon Sep 17 00:00:00 2001
From: "henrike@webrtc.org"
 <henrike@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d>
Date: Fri, 17 Feb 2012 16:27:25 +0000
Subject: [PATCH] Fixes coverity warning that I missed in system wrappers.

BUG=Coverity
TEST=N/A

Review URL: https://webrtc-codereview.appspot.com/395005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1717 4adac7df-926f-26a2-2b94-8c16560cd09d
---
 .../source/critical_section_posix.cc          | 22 +++++++++++++------
 1 file changed, 15 insertions(+), 7 deletions(-)

diff --git a/src/system_wrappers/source/critical_section_posix.cc b/src/system_wrappers/source/critical_section_posix.cc
index b499b9ffe..70f85f9a6 100644
--- a/src/system_wrappers/source/critical_section_posix.cc
+++ b/src/system_wrappers/source/critical_section_posix.cc
@@ -1,5 +1,5 @@
 /*
- *  Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
+ *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
@@ -8,31 +8,39 @@
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
+// General note: return values for the various pthread synchronization APIs
+// are explicitly ignored here. In Chromium, the same thing is done for release.
+// However, in debugging, failure in these APIs are logged. There is currently
+// no equivalent to DCHECK_EQ in WebRTC code so this is the best we can do here.
+// TODO(henrike): add logging when pthread synchronization APIs are failing.
+
 #include "critical_section_posix.h"
 
 namespace webrtc {
+
 CriticalSectionPosix::CriticalSectionPosix()
 {
     pthread_mutexattr_t attr;
-    pthread_mutexattr_init(&attr);
-    pthread_mutexattr_settype(&attr, PTHREAD_MUTEX_RECURSIVE);
-    pthread_mutex_init(&_mutex, &attr);
+    (void) pthread_mutexattr_init(&attr);
+    (void) pthread_mutexattr_settype(&attr, PTHREAD_MUTEX_RECURSIVE);
+    (void) pthread_mutex_init(&_mutex, &attr);
 }
 
 CriticalSectionPosix::~CriticalSectionPosix()
 {
-    pthread_mutex_destroy(&_mutex);
+    (void) pthread_mutex_destroy(&_mutex);
 }
 
 void
 CriticalSectionPosix::Enter()
 {
-    pthread_mutex_lock(&_mutex);
+    (void) pthread_mutex_lock(&_mutex);
 }
 
 void
 CriticalSectionPosix::Leave()
 {
-    pthread_mutex_unlock(&_mutex);
+    (void) pthread_mutex_unlock(&_mutex);
 }
+
 } // namespace webrtc