generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Disable some PortAllocatorTest on asan due to flakiness

Browse Source 
TBR=kjellander@webrtc.org
BUG=4743

Review URL: https://codereview.webrtc.org/1151173009

Cr-Commit-Position: refs/heads/master@{#9377}
This commit is contained in:
Erik Språng 2015-06-05 09:41:26 +02:00
parent 7dbc076f34
commit efdce6927e
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
webrtc/p2p/client/portallocator_unittest.cc
View File

@ -472,6 +472,10 @@ TEST_F(PortAllocatorTest, TestDisableAdapterEnumerationMultipleInterfaces) {
CheckDisableAdapterEnumeration(); CheckDisableAdapterEnumeration();
} }
// Disable for asan, see
// https://code.google.com/p/webrtc/issues/detail?id=4743 for details.
#if !defined(ADDRESS_SANITIZER)
// Test that we can get OnCandidatesAllocationDone callback when all the ports // Test that we can get OnCandidatesAllocationDone callback when all the ports
// are disabled. // are disabled.
TEST_F(PortAllocatorTest, TestDisableAllPorts) { TEST_F(PortAllocatorTest, TestDisableAllPorts) {
@ -509,6 +513,8 @@ TEST_F(PortAllocatorTest, TestGetAllPortsNoUdpSockets) {
EXPECT_TRUE(candidate_allocation_done_); EXPECT_TRUE(candidate_allocation_done_);
} }
#endif // if !defined(ADDRESS_SANITIZER)
// Test that we don't crash or malfunction if we can't create UDP sockets or // Test that we don't crash or malfunction if we can't create UDP sockets or
// listen on TCP sockets. We still give out a local TCP address, since // listen on TCP sockets. We still give out a local TCP address, since
// apparently this is needed for the remote side to accept our connection. // apparently this is needed for the remote side to accept our connection.