From efdce6927ec37b53d9274ad604d5616d98cb58ca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Erik=20Spr=C3=A5ng?= Date: Fri, 5 Jun 2015 09:41:26 +0200 Subject: [PATCH] Disable some PortAllocatorTest on asan due to flakiness TBR=kjellander@webrtc.org BUG=4743 Review URL: https://codereview.webrtc.org/1151173009 Cr-Commit-Position: refs/heads/master@{#9377} --- webrtc/p2p/client/portallocator_unittest.cc | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/webrtc/p2p/client/portallocator_unittest.cc b/webrtc/p2p/client/portallocator_unittest.cc index 148623dfb..017c37a6f 100644 --- a/webrtc/p2p/client/portallocator_unittest.cc +++ b/webrtc/p2p/client/portallocator_unittest.cc @@ -472,6 +472,10 @@ TEST_F(PortAllocatorTest, TestDisableAdapterEnumerationMultipleInterfaces) { CheckDisableAdapterEnumeration(); } +// Disable for asan, see +// https://code.google.com/p/webrtc/issues/detail?id=4743 for details. +#if !defined(ADDRESS_SANITIZER) + // Test that we can get OnCandidatesAllocationDone callback when all the ports // are disabled. TEST_F(PortAllocatorTest, TestDisableAllPorts) { @@ -509,6 +513,8 @@ TEST_F(PortAllocatorTest, TestGetAllPortsNoUdpSockets) { EXPECT_TRUE(candidate_allocation_done_); } +#endif // if !defined(ADDRESS_SANITIZER) + // Test that we don't crash or malfunction if we can't create UDP sockets or // listen on TCP sockets. We still give out a local TCP address, since // apparently this is needed for the remote side to accept our connection.