generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

int16<->float conversions: Use size_t for array length argument, not int

Browse Source 
size_t is more appropriate for array lengths, since int might
theoretically be too small for a really large array. But more
importantly, if the caller's value is naturally of type size_t and the
function requires an int, VC++ will trigger warning C4267
(http://msdn.microsoft.com/en-us/library/6kck0s93.aspx) because the
implicit cast might be lossy, forcing the caller to do a manual cast.
Typing the function with size_t in the first place resolves the
problem.

R=aluebs@webrtc.org, andrew@webrtc.org, minyue@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/21909004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6702 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
kwiberg@webrtc.org 2014-07-16 08:36:52 +00:00
parent 0fa6366ed1
commit efb81d8d1f
2 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
webrtc/common_audio/audio_util.cc
View File

@ -14,18 +14,18 @@
namespace webrtc {
void RoundToInt16(const float* src, int size, int16_t* dest) {
for (int i = 0; i < size; ++i)
void RoundToInt16(const float* src, size_t size, int16_t* dest) {
for (size_t i = 0; i < size; ++i)
dest[i] = RoundToInt16(src[i]);
}
void ScaleAndRoundToInt16(const float* src, int size, int16_t* dest) {
for (int i = 0; i < size; ++i)
void ScaleAndRoundToInt16(const float* src, size_t size, int16_t* dest) {
for (size_t i = 0; i < size; ++i)
dest[i] = ScaleAndRoundToInt16(src[i]);
}
void ScaleToFloat(const int16_t* src, int size, float* dest) {
for (int i = 0; i < size; ++i)
void ScaleToFloat(const int16_t* src, size_t size, float* dest) {
for (size_t i = 0; i < size; ++i)
dest[i] = ScaleToFloat(src[i]);
}

6
webrtc/common_audio/include/audio_util.h
View File

@ -47,14 +47,14 @@ static inline float ScaleToFloat(int16_t v) {
}
// Round |size| elements of |src| to int16 with clamping and write to |dest|.
void RoundToInt16(const float* src, int size, int16_t* dest);
void RoundToInt16(const float* src, size_t size, int16_t* dest);
// Scale (from [-1, 1]) and round |size| elements of |src| to full-range int16
// with clamping and write to |dest|.
void ScaleAndRoundToInt16(const float* src, int size, int16_t* dest);
void ScaleAndRoundToInt16(const float* src, size_t size, int16_t* dest);
// Scale |size| elements of |src| to float [-1, 1] and write to |dest|.
void ScaleToFloat(const int16_t* src, int size, float* dest);
void ScaleToFloat(const int16_t* src, size_t size, float* dest);
// Deinterleave audio from |interleaved| to the channel buffers pointed to
// by |deinterleaved|. There must be sufficient space allocated in the