generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Disable DtmfSenderTest.InsertDtmfWithCommaAsDelay due to flakiness

Browse Source 
Disabling the test on all platforms since it's likely it can happen
on any platform, even if it's only been observed on Win x64 Release.

Running tests in parallel is a huge performance benefit to the team,
since it approximately reduces build cycle with 60-75%.

BUG=4219
TBR=pthatcher@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/34019004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@8138 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
kjellander@webrtc.org 2015-01-23 14:34:52 +00:00
parent 456f01441a
commit a02d76845f
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
talk/app/webrtc/dtmfsender_unittest.cc
View File

@ -324,7 +324,9 @@ TEST_F(DtmfSenderTest, InsertEmptyTonesToCancelPreviousTask) {
VerifyOnObserver("1");
}
TEST_F(DtmfSenderTest, InsertDtmfWithCommaAsDelay) {
// Flaky when run in parallel.
// See https://code.google.com/p/webrtc/issues/detail?id=4219.
TEST_F(DtmfSenderTest, DISABLED_InsertDtmfWithCommaAsDelay) {
std::string tones = "3,4";
int duration = 100;
int inter_tone_gap = 50;